November 2011 - Wine-commits

Jacek Caban : urlmon: Don' t set is_opaque for file URIs in validate_components.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 1fb705de628699c33c9906e0b71d99d2ce7a0355 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1fb705de628699c33c9906e0b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Nov 16 12:51:23 2011 +0100 urlmon: Don't set is_opaque for file URIs in validate_components. --- dlls/urlmon/tests/uri.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/urlmon/uri.c | 3 +- 2 files changed, 66 insertions(+), 1 deletions(-) diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c index 478a5f0..c8fb522 100644 --- a/dlls/urlmon/tests/uri.c +++ b/dlls/urlmon/tests/uri.c @@ -5525,6 +5525,70 @@ static const uri_builder_test uri_builder_tests[] = { 0,INET_E_INVALID_URL,FALSE, 0,INET_E_INVALID_URL,FALSE, 0,0,0,INET_E_INVALID_URL,FALSE + }, + { "file:///c:/dir/file.html",0,S_OK,FALSE, + { + {TRUE,NULL,NULL,Uri_PROPERTY_FRAGMENT,S_OK}, + }, + {FALSE}, + 0,S_OK,FALSE, + 0,S_OK,FALSE, + 0,0,0,S_OK,FALSE, + { + {"file:///c:/dir/file.html",S_OK}, + {"",S_FALSE}, + {"file:///c:/dir/file.html",S_OK}, + {"",S_FALSE}, + {".html",S_OK}, + {"",S_FALSE}, + {"",S_FALSE}, + {"",S_FALSE}, + {"/c:/dir/file.html",S_OK}, + {"/c:/dir/file.html",S_OK}, + {"",S_FALSE}, + {"file:///c:/dir/file.html",S_OK}, + {"file",S_OK}, + {"",S_FALSE}, + {"",S_FALSE} + }, + { + {Uri_HOST_UNKNOWN,S_OK}, + {0,S_FALSE}, + {URL_SCHEME_FILE,S_OK}, + {URLZONE_INVALID,E_NOTIMPL} + } + }, + { "file:///c:/dir/file.html",0,S_OK,FALSE, + { + {TRUE,"#",NULL,Uri_PROPERTY_FRAGMENT,S_OK}, + }, + {FALSE}, + 0,S_OK,FALSE, + 0,S_OK,FALSE, + 0,0,0,S_OK,FALSE, + { + {"file:///c:/dir/file.html#",S_OK}, + {"",S_FALSE}, + {"file:///c:/dir/file.html#",S_OK}, + {"",S_FALSE}, + {".html",S_OK}, + {"#",S_OK}, + {"",S_FALSE}, + {"",S_FALSE}, + {"/c:/dir/file.html",S_OK}, + {"/c:/dir/file.html",S_OK}, + {"",S_FALSE}, + {"file:///c:/dir/file.html#",S_OK}, + {"file",S_OK}, + {"",S_FALSE}, + {"",S_FALSE} + }, + { + {Uri_HOST_UNKNOWN,S_OK}, + {0,S_FALSE}, + {URL_SCHEME_FILE,S_OK}, + {URLZONE_INVALID,E_NOTIMPL} + } } }; diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c index 8f0e7e7..a36f730 100644 --- a/dlls/urlmon/uri.c +++ b/dlls/urlmon/uri.c @@ -3941,7 +3941,8 @@ static HRESULT validate_components(const UriBuilder *builder, parse_data *data, /* The URI is opaque if it doesn't have an authority component. */ if(!data->is_relative) - data->is_opaque = !data->username && !data->password && !data->host && !data->has_port; + data->is_opaque = !data->username && !data->password && !data->host && !data->has_port + && data->scheme_type != URL_SCHEME_FILE; else data->is_opaque = !data->host && !data->has_port;

1 0

Jacek Caban : mshtml: Update window URI when its binding is redirected.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 2bffcedc820db2da68ad49d3e15202714b20ac68 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2bffcedc820db2da68ad49d3e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Nov 16 12:52:43 2011 +0100 mshtml: Update window URI when its binding is redirected. --- dlls/mshtml/binding.h | 1 + dlls/mshtml/navigate.c | 11 +++++++++++ dlls/mshtml/nsio.c | 9 +++++++++ 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/binding.h b/dlls/mshtml/binding.h index 0b23af7..a392037 100644 --- a/dlls/mshtml/binding.h +++ b/dlls/mshtml/binding.h @@ -112,3 +112,4 @@ HRESULT super_navigate(HTMLWindow*,IUri*,const WCHAR*,BYTE*,DWORD) DECLSPEC_HIDD HRESULT create_channelbsc(IMoniker*,const WCHAR*,BYTE*,DWORD,nsChannelBSC**) DECLSPEC_HIDDEN; HRESULT channelbsc_load_stream(nsChannelBSC*,IStream*) DECLSPEC_HIDDEN; void channelbsc_set_channel(nsChannelBSC*,nsChannel*,nsIStreamListener*,nsISupports*) DECLSPEC_HIDDEN; +IUri *nsuri_get_uri(nsWineURI*); diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb97ee1..fe0d4c6 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -1134,6 +1134,17 @@ static nsresult NSAPI nsAsyncVerifyRedirectCallback_AsyncOnChannelRedirect(nsIAs ERR("AddRequest failed: %08x\n", nsres); } + if(This->bsc->window) { + IUri *uri = nsuri_get_uri(This->nschannel->uri); + + if(uri) { + set_current_uri(This->bsc->window, uri); + IUri_Release(uri); + }else { + WARN("Could not get IUri from nsWineURI\n"); + } + } + return NS_OK; } diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index 81dfab7..a5a974f 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -84,6 +84,15 @@ static BOOL ensure_uri(nsWineURI *This) return TRUE; } +IUri *nsuri_get_uri(nsWineURI *nsuri) +{ + if(!ensure_uri(nsuri)) + return NULL; + + IUri_AddRef(nsuri->uri); + return nsuri->uri; +} + static IUri *get_uri_nofrag(IUri *uri) { IUriBuilder *uri_builder;

1 0

Huw Davies : gdi32: Add a helper to return the maximum level to use for a given anti-aliasing format .
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: f3fab963938dad74cda7c469d5b44305c93ec82b URL: http://source.winehq.org/git/wine.git/?a=commit;h=f3fab963938dad74cda7c469d… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 16 11:20:50 2011 +0000 gdi32: Add a helper to return the maximum level to use for a given anti-aliasing format. --- dlls/gdi32/freetype.c | 44 +++++++++++++++++++++++++------------------- 1 files changed, 25 insertions(+), 19 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 06350be..9ec7785 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -5038,6 +5038,17 @@ static inline BOOL is_identity_MAT2(const MAT2 *matrix) return !memcmp(matrix, &identity, sizeof(MAT2)); } +static inline BYTE get_max_level( UINT format ) +{ + switch( format ) + { + case GGO_GRAY2_BITMAP: return 4; + case GGO_GRAY4_BITMAP: return 16; + case GGO_GRAY8_BITMAP: return 64; + } + return 255; +} + static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2* lpmat) @@ -5337,7 +5348,7 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, case GGO_GRAY8_BITMAP: case WINE_GGO_GRAY16_BITMAP: { - unsigned int mult, row, col; + unsigned int max_level, row, col; BYTE *start, *ptr; width = lpgm->gmBlackBoxX; @@ -5347,6 +5358,8 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, if(!buf || !buflen) break; + max_level = get_max_level( format ); + switch(ft_face->glyph->format) { case ft_glyph_format_bitmap: { @@ -5379,29 +5392,22 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, pFT_Outline_Get_Bitmap(library, &ft_face->glyph->outline, &ft_bitmap); - if(format == GGO_GRAY2_BITMAP) - mult = 4; - else if(format == GGO_GRAY4_BITMAP) - mult = 16; - else if(format == GGO_GRAY8_BITMAP) - mult = 64; - else /* format == WINE_GGO_GRAY16_BITMAP */ - return needed; - break; + if (max_level != 255) + { + for (row = 0, start = buf; row < height; row++) + { + for (col = 0, ptr = start; col < width; col++, ptr++) + *ptr = (((int)*ptr) * max_level + 128) / 256; + start += pitch; + } + } + return needed; } + default: FIXME("loaded glyph format %x\n", ft_face->glyph->format); return GDI_ERROR; } - - start = buf; - for(row = 0; row < height; row++) { - ptr = start; - for(col = 0; col < width; col++, ptr++) { - *ptr = (((int)*ptr) * mult + 128) / 256; - } - start += pitch; - } break; }

1 0

Huw Davies : gdi32: Return valid anti-alias format bitmaps if the glyph is a monochrome bitmap .
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 6c9c9107d4b542c7cd1c3ecf9bce53106d0419af URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c9c9107d4b542c7cd1c3ecf9… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 16 11:20:51 2011 +0000 gdi32: Return valid anti-alias format bitmaps if the glyph is a monochrome bitmap. --- dlls/gdi32/freetype.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 9ec7785..5fb8cda 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -5289,9 +5289,7 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, } if(ft_face->glyph->format != ft_glyph_format_outline && - (format == GGO_NATIVE || format == GGO_BEZIER || - format == GGO_GRAY2_BITMAP || format == GGO_GRAY4_BITMAP || - format == GGO_GRAY8_BITMAP)) + (format == GGO_NATIVE || format == GGO_BEZIER)) { TRACE("loaded a bitmap\n"); return GDI_ERROR; @@ -5369,7 +5367,7 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, memset( buf, 0, needed ); while(h--) { for(x = 0; x < pitch && x < ft_face->glyph->bitmap.width; x++) - if (src[x / 8] & (1 << ( (7 - (x % 8))))) dst[x] = 0xff; + if (src[x / 8] & (1 << ( (7 - (x % 8))))) dst[x] = max_level; src += ft_face->glyph->bitmap.pitch; dst += pitch; }

1 0

Huw Davies : gdi32: Use an array of masks to simplify the bitmap conversion .
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 48b1e66309ec2dd42ad6b0166cbf184d476f704a URL: http://source.winehq.org/git/wine.git/?a=commit;h=48b1e66309ec2dd42ad6b0166… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 16 11:20:52 2011 +0000 gdi32: Use an array of masks to simplify the bitmap conversion. --- dlls/gdi32/freetype.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 5fb8cda..3a1ae99 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -5049,6 +5049,8 @@ static inline BYTE get_max_level( UINT format ) return 255; } +static const BYTE masks[8] = {0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01}; + static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2* lpmat) @@ -5367,7 +5369,7 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, memset( buf, 0, needed ); while(h--) { for(x = 0; x < pitch && x < ft_face->glyph->bitmap.width; x++) - if (src[x / 8] & (1 << ( (7 - (x % 8))))) dst[x] = max_level; + if (src[x / 8] & masks[x % 8]) dst[x] = max_level; src += ft_face->glyph->bitmap.pitch; dst += pitch; } @@ -5439,7 +5441,7 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, { for (x = 0; x < width && x < ft_face->glyph->bitmap.width; x++) { - if ( src[x / 8] & (1 << ( (7 - (x % 8)))) ) + if ( src[x / 8] & masks[x % 8] ) ((unsigned int *)dst)[x] = ~0u; } src += src_pitch;

1 0

Huw Davies : gdi32: Add a helper to retrieve the octant bias.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 666f83bc0f82c4d8bae2f30f7a6dee8f2d4cf584 URL: http://source.winehq.org/git/wine.git/?a=commit;h=666f83bc0f82c4d8bae2f30f7… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 16 11:20:53 2011 +0000 gdi32: Add a helper to retrieve the octant bias. --- dlls/gdi32/dibdrv/objects.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/dlls/gdi32/dibdrv/objects.c b/dlls/gdi32/dibdrv/objects.c index 3de6cb9..c0dd7d2 100644 --- a/dlls/gdi32/dibdrv/objects.c +++ b/dlls/gdi32/dibdrv/objects.c @@ -308,6 +308,12 @@ static inline DWORD get_octant_mask(int dx, int dy) return 1 << (get_octant_number(dx, dy) - 1); } +static inline int get_bias( DWORD mask ) +{ + /* Octants 3, 5, 6 and 8 take a bias */ + return (mask & 0xb4) ? 1 : 0; +} + static void solid_pen_line_callback(dibdrv_physdev *pdev, INT x, INT y) { RECT rect; @@ -653,8 +659,7 @@ static BOOL solid_pen_line(dibdrv_physdev *pdev, POINT *start, POINT *end) params.dx = abs(dx); params.dy = abs(dy); params.octant = get_octant_mask(dx, dy); - /* Octants 3, 5, 6 and 8 take a bias */ - params.bias = (params.octant & 0xb4) ? 1 : 0; + params.bias = get_bias(params.octant); for(i = 0; i < clip->numRects; i++) { @@ -926,8 +931,7 @@ static BOOL dashed_pen_line(dibdrv_physdev *pdev, POINT *start, POINT *end) params.dx = abs(dx); params.dy = abs(dy); params.octant = get_octant_mask(dx, dy); - /* Octants 3, 5, 6 and 8 take a bias */ - params.bias = (params.octant & 0xb4) ? 1 : 0; + params.bias = get_bias(params.octant); for(i = 0; i < clip->numRects; i++) {

1 0

Piotr Caban : msvcrt: Don't use fputc in flsbuf implementation.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 764b85511c72ab9e4b4ab456c98e0e71b4aa4009 URL: http://source.winehq.org/git/wine.git/?a=commit;h=764b85511c72ab9e4b4ab456c… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Nov 16 12:50:50 2011 +0100 msvcrt: Don't use fputc in flsbuf implementation. --- dlls/msvcrt/file.c | 74 +++++++++++++++++++++++++++------------------------ 1 files changed, 39 insertions(+), 35 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 0ead68a..1334ec6 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -3062,37 +3062,6 @@ int CDECL MSVCRT__wfopen_s(MSVCRT_FILE** pFile, const MSVCRT_wchar_t *filename, return 0; } -/* MSVCRT_fputc calls MSVCRT__flsbuf which calls MSVCRT_fputc */ -int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file); - -/********************************************************************* - * fputc (MSVCRT.@) - */ -int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) -{ - int res; - - MSVCRT__lock_file(file); - if(file->_cnt>0) { - *file->_ptr++=c; - file->_cnt--; - if (c == '\n') - { - res = msvcrt_flush_buffer(file); - MSVCRT__unlock_file(file); - return res ? res : c; - } - else { - MSVCRT__unlock_file(file); - return c & 0xff; - } - } else { - res = MSVCRT__flsbuf(c, file); - MSVCRT__unlock_file(file); - return res; - } -} - /********************************************************************* * _flsbuf (MSVCRT.@) */ @@ -3109,10 +3078,17 @@ int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) return MSVCRT_EOF; } if(file->_bufsiz) { - int res=msvcrt_flush_buffer(file); - if(!res) - res = MSVCRT_fputc(c, file); - return res; + int res = 0; + + if(file->_cnt == 0) + res = msvcrt_flush_buffer(file); + if(!res) { + *file->_ptr++ = c; + file->_cnt--; + res = msvcrt_flush_buffer(file); + } + + return res ? res : c&0xff; } else { unsigned char cc=c; int len; @@ -3127,6 +3103,34 @@ int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) } /********************************************************************* + * fputc (MSVCRT.@) + */ +int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) +{ + int res; + + MSVCRT__lock_file(file); + if(file->_cnt>0) { + *file->_ptr++=c; + file->_cnt--; + if (c == '\n') + { + res = msvcrt_flush_buffer(file); + MSVCRT__unlock_file(file); + return res ? res : c; + } + else { + MSVCRT__unlock_file(file); + return c & 0xff; + } + } else { + res = MSVCRT__flsbuf(c, file); + MSVCRT__unlock_file(file); + return res; + } +} + +/********************************************************************* * _fputchar (MSVCRT.@) */ int CDECL MSVCRT__fputchar(int c)

1 0

Piotr Caban : msvcr90/tests: Added nonblocking FILE functions test.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: abd0f4318e964fd833923bb524cdec9d0c35755a URL: http://source.winehq.org/git/wine.git/?a=commit;h=abd0f4318e964fd833923bb52… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Nov 16 12:51:06 2011 +0100 msvcr90/tests: Added nonblocking FILE functions test. --- dlls/msvcr90/tests/msvcr90.c | 113 ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 113 insertions(+), 0 deletions(-) diff --git a/dlls/msvcr90/tests/msvcr90.c b/dlls/msvcr90/tests/msvcr90.c index b6ae4c3..09b4a40 100644 --- a/dlls/msvcr90/tests/msvcr90.c +++ b/dlls/msvcr90/tests/msvcr90.c @@ -100,6 +100,15 @@ static void* (__cdecl *p_get_terminate)(void); static void* (__cdecl *p_get_unexpected)(void); static int (__cdecl *p__vswprintf_l)(wchar_t*, const wchar_t*, _locale_t, __ms_va_list); static int (__cdecl *p_vswprintf_l)(wchar_t*, const wchar_t*, _locale_t, __ms_va_list); +static FILE* (__cdecl *p_fopen)(const char*, const char*); +static int (__cdecl *p_fclose)(FILE*); +static int (__cdecl *p_unlink)(const char*); +static void (__cdecl *p_lock_file)(FILE*); +static void (__cdecl *p_unlock_file)(FILE*); +static int (__cdecl *p_fileno)(FILE*); +static int (__cdecl *p_feof)(FILE*); +static int (__cdecl *p_ferror)(FILE*); +static int (__cdecl *p_flsbuf)(int, FILE*); /* type info */ @@ -268,6 +277,15 @@ static BOOL init(void) SET(p_get_unexpected, "_get_unexpected"); SET(p__vswprintf_l, "__vswprintf_l"); SET(p_vswprintf_l, "_vswprintf_l"); + SET(p_fopen, "fopen"); + SET(p_fclose, "fclose"); + SET(p_unlink, "_unlink"); + SET(p_lock_file, "_lock_file"); + SET(p_unlock_file, "_unlock_file"); + SET(p_fileno, "_fileno"); + SET(p_feof, "feof"); + SET(p_ferror, "ferror"); + SET(p_flsbuf, "_flsbuf"); if (sizeof(void *) == 8) { SET(p_type_info_name_internal_method, "?_name_internal_method(a)type_info@@QEBAPEBDPEAU__type_info_node@@@Z"); @@ -1025,6 +1043,100 @@ static void test__vswprintf_l(void) wine_dbgstr_w(buf), wine_dbgstr_w(format)); } +struct block_file_arg +{ + FILE *read; + FILE *write; + HANDLE blocked; +}; + +static DWORD WINAPI block_file(void *arg) +{ + struct block_file_arg *files = arg; + + p_lock_file(files->read); + p_lock_file(files->write); + SetEvent(files->blocked); + WaitForSingleObject(files->blocked, INFINITE); + p_unlock_file(files->read); + p_unlock_file(files->write); + return 0; +} + +static void test_nonblocking_file_access(void) +{ + HANDLE thread; + struct block_file_arg arg; + FILE *filer, *filew; + int ret; + + if(!p_lock_file || !p_unlock_file) { + win_skip("_lock_file not available\n"); + return; + } + + filew = p_fopen("test_file", "w"); + ok(filew != NULL, "unable to create test file\n"); + if(!filew) + return; + filer = p_fopen("test_file", "r"); + ok(filer != NULL, "unable to open test file\n"); + if(!filer) { + p_fclose(filew); + p_unlink("test_file"); + return; + } + + arg.read = filer; + arg.write = filew; + arg.blocked = CreateEvent(NULL, FALSE, FALSE, NULL); + ok(arg.blocked != NULL, "CreateEvent failed\n"); + if(!arg.blocked) { + p_fclose(filer); + p_fclose(filew); + p_unlink("test_file"); + return; + } + thread = CreateThread(NULL, 0, block_file, (void*)&arg, 0, NULL); + ok(thread != NULL, "CreateThread failed\n"); + if(!thread) { + CloseHandle(arg.blocked); + p_fclose(filer); + p_fclose(filew); + p_unlink("test_file"); + return; + } + WaitForSingleObject(arg.blocked, INFINITE); + + ret = p_fileno(filer); + ok(ret, "_fileno(filer) returned %d\n", ret); + ret = p_fileno(filew); + ok(ret, "_fileno(filew) returned %d\n", ret); + + ret = p_feof(filer); + ok(ret==0, "feof(filer) returned %d\n", ret); + ret = p_feof(filew); + ok(ret==0, "feof(filew) returned %d\n", ret); + + ret = p_ferror(filer); + ok(ret==0, "ferror(filer) returned %d\n", ret); + ret = p_ferror(filew); + ok(ret==0, "ferror(filew) returned %d\n", ret); + + ret = p_flsbuf('a', filer); + ok(ret==-1, "_flsbuf(filer) returned %d\n", ret); + ret = p_flsbuf('a', filew); + ok(ret=='a', "_flsbuf(filew) returned %d\n", ret); + + SetEvent(arg.blocked); + WaitForSingleObject(thread, INFINITE); + CloseHandle(arg.blocked); + CloseHandle(thread); + p_fclose(filer); + p_fclose(filew); + p_unlink("test_file"); +} + START_TEST(msvcr90) { if(!init()) @@ -1046,4 +1158,5 @@ START_TEST(msvcr90) test_typeinfo(); test_getptd(); test__vswprintf_l(); + test_nonblocking_file_access(); }

1 0

Jacek Caban : mshtml: Fixed some htmldoc.c tests on IE9.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 7377dfbb07cc13d45c45b2c1ccdb2a45394b8e33 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7377dfbb07cc13d45c45b2c1c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Nov 16 15:22:12 2011 +0100 mshtml: Fixed some htmldoc.c tests on IE9. --- dlls/mshtml/tests/htmldoc.c | 29 +++++++++++++++++++---------- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index b34b037..12717fe 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -927,7 +927,13 @@ static IPropertyNotifySink PropertyNotifySink = { &PropertyNotifySinkVtbl }; static HRESULT WINAPI Stream_QueryInterface(IStream *iface, REFIID riid, void **ppv) { - ok(0, "unexpected call\n"); + if(IsEqualGUID(&IID_IUnknown, riid) || IsEqualGUID(&IID_ISequentialStream, riid) || IsEqualGUID(&IID_IStream, riid)) { + *ppv = iface; + return S_OK; + } + + ok(0, "unexpected call %s\n", debugstr_guid(riid)); + *ppv = NULL; return E_NOINTERFACE; } @@ -1318,7 +1324,7 @@ static HRESULT WINAPI Moniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, IMon hres = IBindStatusCallback_GetBindInfo(callback, &bindf, &bindinfo); ok(hres == S_OK, "GetBindInfo failed: %08x\n", hres); - ok(bindf == (BINDF_PULLDATA|BINDF_ASYNCSTORAGE|BINDF_ASYNCHRONOUS), "bindf = %08x\n", bindf); + ok((bindf & ~BINDF_HYPERLINK /* IE9 */) == (BINDF_PULLDATA|BINDF_ASYNCSTORAGE|BINDF_ASYNCHRONOUS), "bindf = %08x\n", bindf); ok(bindinfo.cbSize == sizeof(bindinfo), "bindinfo.cbSize=%d\n", bindinfo.cbSize); ok(bindinfo.szExtraInfo == NULL, "bindinfo.szExtraInfo=%p\n", bindinfo.szExtraInfo); /* TODO: test stgmedData */ @@ -2687,6 +2693,7 @@ static HRESULT WINAPI OleCommandTarget_Exec(IOleCommandTarget *iface, const GUID test_readyState(NULL); return S_OK; case OLECMDID_UPDATETRAVELENTRY_DATARECOVERY: + case 6058: return E_FAIL; /* FIXME */ default: ok(0, "unexpected command %d\n", nCmdID); @@ -3668,6 +3675,12 @@ static HRESULT WINAPI WebBrowser_QueryInterface(IWebBrowser2 *iface, REFIID riid { *ppv = NULL; + if(IsEqualGUID(&IID_IUnknown, riid) || IsEqualGUID(&IID_IWebBrowser, riid) + || IsEqualGUID(&IID_IWebBrowserApp, riid) || IsEqualGUID(&IID_IWebBrowser2, riid)) { + *ppv = iface; + return S_OK; + } + if(IsEqualGUID(riid, &IID_IOleObject)) return E_NOINTERFACE; /* TODO */ @@ -4513,8 +4526,6 @@ static void _test_readyState(unsigned line, IUnknown *unk) hres = IHTMLDocument2_get_readyState(htmldoc, &state); ok(hres == S_OK, "get_ReadyState failed: %08x\n", hres); - trace("STATE %s\n", wine_dbgstr_w(state)); - if(!strcmp_wa(state, "interactive") && load_state == LD_LOADING) load_state = LD_INTERACTIVE; @@ -4557,8 +4568,6 @@ static void _test_readyState(unsigned line, IUnknown *unk) ok_(__FILE__,line) (V_VT(&out) == VT_I4, "V_VT(out)=%d\n", V_VT(&out)); ok_(__FILE__,line) (V_I4(&out) == load_state%5, "VT_I4(out)=%d, expected %d\n", V_I4(&out), load_state%5); - trace("READY STATE %d\n", V_I4(&out)); - test_doscroll((IUnknown*)htmldoc); IHTMLDocument2_Release(htmldoc); @@ -4722,7 +4731,7 @@ static void test_Load(IPersistMoniker *persist, IMoniker *mon) CHECK_CALLED(Invoke_AMBIENT_SILENT); CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); CHECK_CALLED(Invoke_AMBIENT_USERAGENT); - CHECK_CALLED(Invoke_AMBIENT_PALETTE); + CLEAR_CALLED(Invoke_AMBIENT_PALETTE); /* not called on IE9 */ CHECK_CALLED(GetOptionKeyPath); CHECK_CALLED(GetOverrideKeyPath); CHECK_CALLED(GetWindow); @@ -5705,7 +5714,7 @@ static void test_ClientSite(IOleObject *oleobj, DWORD flags) CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); CHECK_CALLED(Invoke_AMBIENT_SILENT); CHECK_CALLED(Invoke_AMBIENT_USERAGENT); - CHECK_CALLED(Invoke_AMBIENT_PALETTE); + CLEAR_CALLED(Invoke_AMBIENT_PALETTE); /* not called on IE9 */ todo_wine CHECK_CALLED(GetTravelLog); set_clientsite = TRUE; @@ -5761,7 +5770,7 @@ static void test_OnAmbientPropertyChange(IHTMLDocument2 *doc) SET_EXPECT(Invoke_AMBIENT_PALETTE); hres = IOleControl_OnAmbientPropertyChange(control, DISPID_AMBIENT_PALETTE); ok(hres == S_OK, "OnAmbientChange failed: %08x\n", hres); - CHECK_CALLED(Invoke_AMBIENT_PALETTE); + CLEAR_CALLED(Invoke_AMBIENT_PALETTE); /* not called on IE9 */ IOleControl_Release(control); } @@ -6857,7 +6866,7 @@ static void test_UIActivate(BOOL do_load, BOOL use_ipsex, BOOL use_ipsw) CHECK_CALLED(Invoke_AMBIENT_SILENT); CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); CHECK_CALLED(Invoke_AMBIENT_USERAGENT); - CHECK_CALLED(Invoke_AMBIENT_PALETTE); + CLEAR_CALLED(Invoke_AMBIENT_PALETTE); /* not called on IE9 */ CHECK_CALLED(GetOptionKeyPath); CHECK_CALLED(GetOverrideKeyPath); CHECK_CALLED(GetWindow);

1 0

Jacek Caban : mshtml: Fixed events tests on IE9.
by Alexandre Julliard 16 Nov '11

16 Nov '11

Module: wine Branch: master Commit: 938dcab3f48db1909e722712bb3a56dca644b48a URL: http://source.winehq.org/git/wine.git/?a=commit;h=938dcab3f48db1909e722712b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Nov 16 15:26:49 2011 +0100 mshtml: Fixed events tests on IE9. --- dlls/mshtml/tests/events.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/events.c b/dlls/mshtml/tests/events.c index 1498818..d83a511 100644 --- a/dlls/mshtml/tests/events.c +++ b/dlls/mshtml/tests/events.c @@ -646,6 +646,7 @@ static void _test_event_obj(unsigned line, const char *type, const xy_test_t *xy _test_event_screenx(line, event, -10); _test_event_screeny(line, event, -10); + V_VT(&v) = VT_NULL; hres = IHTMLEventObj_get_returnValue(event, &v); ok_(__FILE__,line)(hres == S_OK, "get_returnValue failed: %08x\n", hres); ok_(__FILE__,line)(V_VT(&v) == VT_EMPTY, "V_VT(returnValue) = %d\n", V_VT(&v));

1 0