November 2011 - Wine-commits

Frédéric Delanoy : cmd: Rename unicodePipes variable.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: 513ee9a3aa081175c88fdd34ab3f95db9ce80fe9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=513ee9a3aa081175c88fdd34a… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Nov 29 14:39:28 2011 +0100 cmd: Rename unicodePipes variable. --- programs/cmd/wcmdmain.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index c3c71a9..1947884 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -45,7 +45,7 @@ WCHAR quals[MAX_PATH], param1[MAXSTRING], param2[MAXSTRING]; BATCH_CONTEXT *context = NULL; extern struct env_stack *pushd_directories; static const WCHAR *pagedMessage = NULL; -static BOOL unicodePipes = FALSE; +static BOOL unicodeOutput = FALSE; #define MAX_WRITECONSOLE_SIZE 65535 @@ -89,7 +89,7 @@ static void WCMD_output_asis_len(const WCHAR *message, DWORD len, HANDLE device) DWORD convertedChars; char *buffer; - if (!unicodePipes) { + if (!unicodeOutput) { if (!(buffer = get_file_buffer())) return; @@ -2259,9 +2259,9 @@ int wmain (int argc, WCHAR *argvW[]) } else if (tolowerW(c)=='s') { opt_s = TRUE; } else if (tolowerW(c)=='a') { - unicodePipes=FALSE; + unicodeOutput = FALSE; } else if (tolowerW(c)=='u') { - unicodePipes=TRUE; + unicodeOutput = TRUE; } else if (tolowerW(c)=='t' && (*argvW)[2]==':') { opt_t=strtoulW(&(*argvW)[3], NULL, 16); } else if (tolowerW(c)=='x' || tolowerW(c)=='y') {

1 0

André Hentschel : po: Update German translation.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: 8a1d690ad47199c0574dc63c1399e3b5a00f5e8b URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a1d690ad47199c0574dc63c1… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Nov 29 19:04:06 2011 +0100 po: Update German translation. --- po/de.po | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/po/de.po b/po/de.po index 7c0dc12..99d2fe2 100644 --- a/po/de.po +++ b/po/de.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2011-11-24 22:08+0100\n" +"PO-Revision-Date: 2011-11-29 18:54+0100\n" "Last-Translator: André Hentschel\n" "Language-Team: none\n" "Language: German\n" @@ -12282,7 +12282,6 @@ msgstr "" "Wir entschuldigen uns für die Unannehmlichkeit." #: winedbg.rc:53 -#, fuzzy msgid "" "This can be caused by a problem in the program or a deficiency in Wine. You " "may want to check the <a href=\"http://appdb.winehq.org\">Application " @@ -12292,11 +12291,12 @@ msgid "" "you can <a href=\"http://wiki.winehq.org/Bugs\">file a bug report</a>." msgstr "" "Die Ursache kann ein Problem im Programm oder ein Fehler in Wine sein. Sie " -"können unter http://appdb.winehq.org Tipps zum ausführen der Anwendung " -"einholen.\n" +"können in der <a href=\"http://appdb.winehq.org\">Anwendungsdatenbank</a> " +"Tipps zum ausführen der Anwendung einholen.\n" "\n" "Tritt dieses Problem unter Windows nicht auf und wurde es noch nicht " -"gemeldet, können Sie unter http://bugs.winehq.org einen Eintrag hinterlassen." +"gemeldet, können Sie <a href=\"http://wiki.winehq.org/Bugs\">einen " +"Fehlerbericht hinterlassen</a>." #: winedbg.rc:35 msgid "Wine program crash"

1 0

Henri Verbeet : wined3d: Get rid of WINED3DDEVINFO_BANDWIDTHTIMINGS.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: adb0c0862639aefee707a07b27f75936c10477aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=adb0c0862639aefee707a07b2… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Nov 28 21:31:00 2011 +0100 wined3d: Get rid of WINED3DDEVINFO_BANDWIDTHTIMINGS. --- include/wine/wined3d.h | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 3fc6d16..88fd0de 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -1692,15 +1692,6 @@ struct wined3d_device_creation_parameters DWORD flags; }; -typedef struct _WINED3DDEVINFO_BANDWIDTHTIMINGS -{ - float MaxBandwidthUtilized; - float FrontEndUploadMemoryUtilizedPercent; - float VertexRateUtilizedPercent; - float TriangleSetupRateUtilizedPercent; - float FillRateUtilizedPercent; -} WINED3DDEVINFO_BANDWIDTHTIMINGS; - typedef struct _WINED3DDEVINFO_CACHEUTILIZATION { float TextureCacheHitRate;

1 0

Henri Verbeet : wined3d: Get rid of WINED3DDEVINFO_CACHEUTILIZATION.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: a84454aabb6c1eaabf15e6b0548711c0b74418cf URL: http://source.winehq.org/git/wine.git/?a=commit;h=a84454aabb6c1eaabf15e6b05… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Nov 28 21:31:01 2011 +0100 wined3d: Get rid of WINED3DDEVINFO_CACHEUTILIZATION. --- include/wine/wined3d.h | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 88fd0de..1ee94b7 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -1692,12 +1692,6 @@ struct wined3d_device_creation_parameters DWORD flags; }; -typedef struct _WINED3DDEVINFO_CACHEUTILIZATION -{ - float TextureCacheHitRate; - float PostTransformVertexCacheHitRate; -} WINED3DDEVINFO_CACHEUTILIZATION; - typedef struct _WINED3DDEVINFO_INTERFACETIMINGS { float WaitingForGPUToUseApplicationResourceTimePercent;

1 0

Eric Pouech : msvcrt: Implemented _ultow_s.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: d7bc2eff2f2651646753e13b7d840469347a7386 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7bc2eff2f2651646753e13b7… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Mon Nov 28 21:53:38 2011 +0100 msvcrt: Implemented _ultow_s. --- dlls/msvcr100/msvcr100.spec | 2 +- dlls/msvcr80/msvcr80.spec | 2 +- dlls/msvcr90/msvcr90.spec | 2 +- dlls/msvcrt/msvcrt.spec | 2 +- dlls/msvcrt/string.c | 54 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 58 insertions(+), 4 deletions(-) diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec index 4b5b525..16c8486 100644 --- a/dlls/msvcr100/msvcr100.spec +++ b/dlls/msvcr100/msvcr100.spec @@ -1202,7 +1202,7 @@ @ cdecl _ultoa(long ptr long) msvcrt._ultoa @ cdecl _ultoa_s(long ptr long long) msvcrt._ultoa_s @ cdecl _ultow(long ptr long) msvcrt._ultow -@ stub _ultow_s +@ cdecl _ultow_s(long ptr long long) msvcrt._ultow_s @ cdecl _umask(long) msvcrt._umask @ stub _umask_s @ stub _ungetc_nolock diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec index 5de5586..240b9f2 100644 --- a/dlls/msvcr80/msvcr80.spec +++ b/dlls/msvcr80/msvcr80.spec @@ -1055,7 +1055,7 @@ @ cdecl _ultoa(long ptr long) msvcrt._ultoa @ cdecl _ultoa_s(long ptr long long) msvcrt._ultoa_s @ cdecl _ultow(long ptr long) msvcrt._ultow -@ stub _ultow_s +@ cdecl _ultow_s(long ptr long long) msvcrt._ultow_s @ cdecl _umask(long) msvcrt._umask @ stub _umask_s @ stub _ungetc_nolock diff --git a/dlls/msvcr90/msvcr90.spec b/dlls/msvcr90/msvcr90.spec index 77e0e45..f1fa88a 100644 --- a/dlls/msvcr90/msvcr90.spec +++ b/dlls/msvcr90/msvcr90.spec @@ -1049,7 +1049,7 @@ @ cdecl _ultoa(long ptr long) msvcrt._ultoa @ cdecl _ultoa_s(long ptr long long) msvcrt._ultoa_s @ cdecl _ultow(long ptr long) msvcrt._ultow -@ stub _ultow_s +@ cdecl _ultow_s(long ptr long long) msvcrt._ultow_s @ cdecl _umask(long) msvcrt._umask @ stub _umask_s @ stub _ungetc_nolock diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index fac2104..2687fd6 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -991,7 +991,7 @@ @ cdecl _ultoa(long ptr long) ntdll._ultoa @ cdecl _ultoa_s(long ptr long long) @ cdecl _ultow(long ptr long) ntdll._ultow -# stub _ultow_s(long ptr long long) +@ cdecl _ultow_s(long ptr long long) @ cdecl _umask(long) MSVCRT__umask # stub _umask_s(long ptr) @ cdecl _ungetch(long) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index 608401d..ad9e88b 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -1288,6 +1288,60 @@ int CDECL _ultoa_s(MSVCRT_ulong value, char *str, MSVCRT_size_t size, int radix) } /********************************************************************* + * _ultow_s (MSVCRT.@) + */ +int CDECL _ultow_s(MSVCRT_ulong value, WCHAR *str, MSVCRT_size_t size, int radix) +{ + MSVCRT_ulong digit; + WCHAR buffer[33], *pos; + size_t len; + + if (!str || !size || radix < 2 || radix > 36) + { + if (str && size) + str[0] = '\0'; + + *MSVCRT__errno() = MSVCRT_EINVAL; + return MSVCRT_EINVAL; + } + + pos = buffer + 32; + *pos = '\0'; + + do + { + digit = value % radix; + value /= radix; + + if (digit < 10) + *--pos = '0' + digit; + else + *--pos = 'a' + digit - 10; + } + while (value != 0); + + len = buffer + 33 - pos; + if (len > size) + { + size_t i; + WCHAR *p = str; + + /* Copy the temporary buffer backwards up to the available number of + * characters. */ + + for (pos = buffer + 31, i = 0; i < size; i++) + *p++ = *pos--; + + str[0] = '\0'; + *MSVCRT__errno() = MSVCRT_ERANGE; + return MSVCRT_ERANGE; + } + + memcpy(str, pos, len * sizeof(WCHAR)); + return 0; +} + +/********************************************************************* * _i64toa_s (MSVCRT.@) */ int CDECL _i64toa_s(__int64 value, char *str, MSVCRT_size_t size, int radix)

1 0

Eric Pouech : cmd: Correctly parse program name when launching external processes.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: 6faea5a606c6cea586c3f4878f6b7fc9347341cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=6faea5a606c6cea586c3f4878… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Mon Nov 28 22:09:07 2011 +0100 cmd: Correctly parse program name when launching external processes. --- programs/cmd/wcmdmain.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index 5bcdbca..0811cd1 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -978,7 +978,12 @@ void WCMD_run_program (WCHAR *command, int called) { static const WCHAR envPathExt[] = {'P','A','T','H','E','X','T','\0'}; static const WCHAR delims[] = {'/','\\',':','\0'}; - WCMD_parse (command, quals, param1, param2); /* Quick way to get the filename */ + /* Quick way to get the filename + * (but handle leading / as part of program name, not qualifier) + */ + for (len = 0; command[len] == '/'; len++) param1[len] = '/'; + WCMD_parse (command + len, quals, param1 + len, param2); + if (!(*param1) && !(*param2)) return;

1 0

Luca Bennati : po: Update Italian translation.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: 29fddd83ffaf7896b0cdacfdc4f9e3486e93e55d URL: http://source.winehq.org/git/wine.git/?a=commit;h=29fddd83ffaf7896b0cdacfdc… Author: Luca Bennati <lucak3(a)gmail.com> Date: Mon Nov 28 08:31:34 2011 +0100 po: Update Italian translation. --- po/it.po | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/po/it.po b/po/it.po index aff677b..b4584d7 100644 --- a/po/it.po +++ b/po/it.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2011-11-21 21:59+0100\n" +"PO-Revision-Date: 2011-11-28 08:30+0100\n" "Last-Translator: Luca Bennati <lucak3(a)gmail.com>\n" "Language-Team: none\n" "Language: Italian\n" @@ -9352,7 +9352,6 @@ msgid "Unicode (UTF-8)" msgstr "Unicode (UTF-8)" #: notepad.rc:99 -#, fuzzy msgid "" "%1\n" "This file contains Unicode characters which will be lost if\n" @@ -9361,9 +9360,9 @@ msgid "" "one of the Unicode options in the Encoding drop down list.\n" "Continue?" msgstr "" -"%s\n" +"%1\n" "Questo file contiene caratteri Unicode che andranno persi se\n" -"salvi questo file nella codifica %s.\n" +"salvi questo file nella codifica %2.\n" "Per mantenere questi caratteri, clicca Annulla e scegli\n" "una delle opzioni Unicode nel menù a tendina Codifica.\n" "Continuare?" @@ -11178,9 +11177,8 @@ msgid "Processes: %d" msgstr "Processi: %d" #: taskmgr.rc:267 -#, fuzzy msgid "Mem Usage: %1!u!kB / %2!u!kB" -msgstr "Uso della Memoria: %dK / %dK" +msgstr "Uso della Memoria: %1!u!kB / %2!u!kB" #: taskmgr.rc:272 msgid "Image Name"

1 0

Jacek Caban : jscript: Use bytecode for '*' expression implementation.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: cf68237c8010f2b7fa8279753383cdf8e83067a4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cf68237c8010f2b7fa8279753… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Nov 29 11:08:54 2011 +0100 jscript: Use bytecode for '*' expression implementation. --- dlls/jscript/compile.c | 2 ++ dlls/jscript/engine.c | 15 ++++++++++++--- dlls/jscript/engine.h | 2 +- dlls/jscript/parser.y | 2 +- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index 3ee3d40..a529fe7 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -364,6 +364,8 @@ static HRESULT compile_expression(compiler_ctx_t *ctx, expression_t *expr) return compile_unary_expression(ctx, (unary_expression_t*)expr, OP_neg); case EXPR_MINUS: return compile_unary_expression(ctx, (unary_expression_t*)expr, OP_minus); + case EXPR_MUL: + return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_mul); case EXPR_NEW: return compile_new_expression(ctx, (call_expression_t*)expr); case EXPR_NOTEQ: diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 273281e..5e60381 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -2323,13 +2323,22 @@ static HRESULT mul_eval(script_ctx_t *ctx, VARIANT *lval, VARIANT *rval, jsexcep } /* ECMA-262 3rd Edition 11.5.1 */ -HRESULT mul_expression_eval(script_ctx_t *ctx, expression_t *_expr, DWORD flags, jsexcept_t *ei, exprval_t *ret) +HRESULT interp_mul(exec_ctx_t *ctx) { - binary_expression_t *expr = (binary_expression_t*)_expr; + VARIANT l, r; + HRESULT hres; TRACE("\n"); - return binary_expr_eval(ctx, expr, mul_eval, ei, ret); + hres = stack_pop_number(ctx, &r); + if(FAILED(hres)) + return hres; + + hres = stack_pop_number(ctx, &l); + if(FAILED(hres)) + return hres; + + return stack_push_number(ctx, num_val(&l)*num_val(&r)); } /* ECMA-262 3rd Edition 11.5.2 */ diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 807bb8a..120bf42 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -55,6 +55,7 @@ typedef struct _func_stack { X(jmp_nz, 0, ARG_ADDR, 0) \ X(jmp_z, 0, ARG_ADDR, 0) \ X(minus, 1, 0,0) \ + X(mul, 1, 0,0) \ X(neg, 1, 0,0) \ X(neq, 1, 0,0) \ X(neq2, 1, 0,0) \ @@ -555,7 +556,6 @@ HRESULT binary_or_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*, HRESULT binary_xor_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT binary_and_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT instanceof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; -HRESULT mul_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT div_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT mod_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT delete_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index 617c848..9b72d7f 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -1315,7 +1315,7 @@ static const expression_eval_t expression_eval_table[] = { compiled_expression_eval, compiled_expression_eval, compiled_expression_eval, - mul_expression_eval, + compiled_expression_eval, div_expression_eval, mod_expression_eval, delete_expression_eval,

1 0

Jacek Caban : jscript: Use bytecode for '/' expression implementation.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: 09306e434e97e9290ff916f27d114190357eb280 URL: http://source.winehq.org/git/wine.git/?a=commit;h=09306e434e97e9290ff916f27… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Nov 29 11:09:04 2011 +0100 jscript: Use bytecode for '/' expression implementation. --- dlls/jscript/compile.c | 2 ++ dlls/jscript/engine.c | 15 ++++++++++++--- dlls/jscript/engine.h | 2 +- dlls/jscript/parser.y | 2 +- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index a529fe7..8608bbe 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -350,6 +350,8 @@ static HRESULT compile_expression(compiler_ctx_t *ctx, expression_t *expr) return compile_comma_expression(ctx, (binary_expression_t*)expr); case EXPR_COND: return compile_conditional_expression(ctx, (conditional_expression_t*)expr); + case EXPR_DIV: + return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_div); case EXPR_EQ: return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_eq); case EXPR_EQEQ: diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 5e60381..97f19b5 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -2360,13 +2360,22 @@ static HRESULT div_eval(script_ctx_t *ctx, VARIANT *lval, VARIANT *rval, jsexcep } /* ECMA-262 3rd Edition 11.5.2 */ -HRESULT div_expression_eval(script_ctx_t *ctx, expression_t *_expr, DWORD flags, jsexcept_t *ei, exprval_t *ret) +static HRESULT interp_div(exec_ctx_t *ctx) { - binary_expression_t *expr = (binary_expression_t*)_expr; + VARIANT l, r; + HRESULT hres; TRACE("\n"); - return binary_expr_eval(ctx, expr, div_eval, ei, ret); + hres = stack_pop_number(ctx, &r); + if(FAILED(hres)) + return hres; + + hres = stack_pop_number(ctx, &l); + if(FAILED(hres)) + return hres; + + return stack_push_number(ctx, num_val(&l)/num_val(&r)); } /* ECMA-262 3rd Edition 11.5.3 */ diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 120bf42..f481a69 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -45,6 +45,7 @@ typedef struct _func_stack { X(add, 1, 0,0) \ X(bool, 1, ARG_INT, 0) \ X(bneg, 1, 0,0) \ + X(div, 1, 0,0) \ X(double, 1, ARG_SBL, 0) \ X(eq, 1, 0,0) \ X(eq2, 1, 0,0) \ @@ -556,7 +557,6 @@ HRESULT binary_or_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*, HRESULT binary_xor_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT binary_and_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT instanceof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; -HRESULT div_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT mod_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT delete_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT typeof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index 9b72d7f..79ecb12 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -1316,7 +1316,7 @@ static const expression_eval_t expression_eval_table[] = { compiled_expression_eval, compiled_expression_eval, compiled_expression_eval, - div_expression_eval, + compiled_expression_eval, mod_expression_eval, delete_expression_eval, compiled_expression_eval,

1 0

Jacek Caban : jscript: Use bytecode for modulo expression implementation.
by Alexandre Julliard 29 Nov '11

29 Nov '11

Module: wine Branch: master Commit: 7a20965bd28dd915b971a0357d103de35b0f25d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7a20965bd28dd915b971a0357… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Nov 29 11:09:20 2011 +0100 jscript: Use bytecode for modulo expression implementation. --- dlls/jscript/compile.c | 2 ++ dlls/jscript/engine.c | 15 ++++++++++++--- dlls/jscript/engine.h | 3 +-- dlls/jscript/parser.y | 2 +- 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index 8608bbe..4793fa3 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -366,6 +366,8 @@ static HRESULT compile_expression(compiler_ctx_t *ctx, expression_t *expr) return compile_unary_expression(ctx, (unary_expression_t*)expr, OP_neg); case EXPR_MINUS: return compile_unary_expression(ctx, (unary_expression_t*)expr, OP_minus); + case EXPR_MOD: + return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_mod); case EXPR_MUL: return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_mul); case EXPR_NEW: diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 97f19b5..1cdc4d0 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -2397,13 +2397,22 @@ static HRESULT mod_eval(script_ctx_t *ctx, VARIANT *lval, VARIANT *rval, jsexcep } /* ECMA-262 3rd Edition 11.5.3 */ -HRESULT mod_expression_eval(script_ctx_t *ctx, expression_t *_expr, DWORD flags, jsexcept_t *ei, exprval_t *ret) +static HRESULT interp_mod(exec_ctx_t *ctx) { - binary_expression_t *expr = (binary_expression_t*)_expr; + VARIANT l, r; + HRESULT hres; TRACE("\n"); - return binary_expr_eval(ctx, expr, mod_eval, ei, ret); + hres = stack_pop_number(ctx, &r); + if(FAILED(hres)) + return hres; + + hres = stack_pop_number(ctx, &l); + if(FAILED(hres)) + return hres; + + return stack_push_number(ctx, fmod(num_val(&l), num_val(&r))); } /* ECMA-262 3rd Edition 11.4.2 */ diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index f481a69..5ef2002 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -56,6 +56,7 @@ typedef struct _func_stack { X(jmp_nz, 0, ARG_ADDR, 0) \ X(jmp_z, 0, ARG_ADDR, 0) \ X(minus, 1, 0,0) \ + X(mod, 1, 0,0) \ X(mul, 1, 0,0) \ X(neg, 1, 0,0) \ X(neq, 1, 0,0) \ @@ -557,10 +558,8 @@ HRESULT binary_or_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*, HRESULT binary_xor_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT binary_and_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT instanceof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; -HRESULT mod_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT delete_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT typeof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; -HRESULT minus_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT post_increment_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT post_decrement_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT pre_increment_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index 79ecb12..36f8f19 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -1317,7 +1317,7 @@ static const expression_eval_t expression_eval_table[] = { compiled_expression_eval, compiled_expression_eval, compiled_expression_eval, - mod_expression_eval, + compiled_expression_eval, delete_expression_eval, compiled_expression_eval, typeof_expression_eval,

1 0