February 2011 - Wine-commits

Austin English : advapi32/tests: Make sure to use return value (LLVM/Clang) .
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: 33db33d474e77eaa280dc763b4a0b3303c2e76f0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=33db33d474e77eaa280dc763b… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:22:28 2011 -0800 advapi32/tests: Make sure to use return value (LLVM/Clang). --- dlls/advapi32/tests/service.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c index 5bacb1b..e86208f 100644 --- a/dlls/advapi32/tests/service.c +++ b/dlls/advapi32/tests/service.c @@ -1561,6 +1561,7 @@ static void test_enum_svc(void) neededW = 0xdeadbeef; ret = pEnumServicesStatusExW(scm_handle, 0, SERVICE_WIN32, SERVICE_STATE_ALL, NULL, 0, &neededW, &returnedW, NULL, NULL); + ok(!ret, "Expected failure\n"); ok(neededW == needed, "Expected needed buffersize to be the same for A- and W-calls\n"); /* Store the needed bytes */

1 0

Austin English : advapi32/tests: Remove Win9x hacks.
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: b7c18d104b2d68a2a07574f01bb306df3fc138d2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b7c18d104b2d68a2a07574f01… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:31:45 2011 -0800 advapi32/tests: Remove Win9x hacks. --- dlls/advapi32/tests/registry.c | 233 +++++++++++++++++----------------------- 1 files changed, 98 insertions(+), 135 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=b7c18d104b2d68a2a0757…

1 0

Austin English : crypt32/tests: Make sure to use return values (LLVM/Clang) .
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: b1d4d2b215df99b8df171bbb3319a4438f8c4d33 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b1d4d2b215df99b8df171bbb3… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:31:55 2011 -0800 crypt32/tests: Make sure to use return values (LLVM/Clang). --- dlls/crypt32/tests/store.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/crypt32/tests/store.c b/dlls/crypt32/tests/store.c index db31190..67ebe11 100644 --- a/dlls/crypt32/tests/store.c +++ b/dlls/crypt32/tests/store.c @@ -200,6 +200,7 @@ static void testMemStore(void) if (buf) { ret = CertSerializeCertificateStoreElement(context, 0, buf, &size); + ok(ret, "CertSerializeCertificateStoreElement failed: %08x\n", GetLastError()); ok(size == sizeof(serializedCert), "Wrong size %d\n", size); ok(!memcmp(serializedCert, buf, size), "Unexpected serialized cert\n"); @@ -1075,6 +1076,7 @@ static void testSystemRegStore(void) /* Now check whether deleting is allowed */ store = CertOpenStore(CERT_STORE_PROV_SYSTEM_REGISTRY, 0, 0, CERT_SYSTEM_STORE_CURRENT_USER | CERT_STORE_DELETE_FLAG, BogusW); + ok(!store, "CertOpenStore failed: %08x\n", GetLastError()); RegDeleteKeyW(HKEY_CURRENT_USER, BogusPathW); store = CertOpenStore(CERT_STORE_PROV_SYSTEM_REGISTRY, 0, 0, 0, NULL); @@ -2323,6 +2325,7 @@ static void testAddCertificateLink(void) /* The serialized linked certificate is identical to the serialized * original certificate. */ + ok(ret, "CertSerializeCertificateStoreElement failed: %08x\n", GetLastError()); ok(size == sizeof(serializedCert), "Wrong size %d\n", size); ok(!memcmp(serializedCert, buf, size), "Unexpected serialized cert\n"); @@ -2345,6 +2348,7 @@ static void testAddCertificateLink(void) { ret = CertGetCertificateContextProperty(linked, CERT_FRIENDLY_NAME_PROP_ID, buf, &size); + ok(ret, "CertGetCertificateContextProperty failed: %08x\n", GetLastError()); ok(!lstrcmpW((LPCWSTR)buf, WineTestW), "unexpected friendly name\n"); HeapFree(GetProcessHeap(), 0, buf);

1 0

Austin English : msi/tests: Remove dead assignments.
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: b6bea541db741f515dcdb26b160fe78246fb1b98 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b6bea541db741f515dcdb26b1… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:37:48 2011 -0800 msi/tests: Remove dead assignments. --- dlls/msi/tests/automation.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index a6f1ddb..a85b29d 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -489,7 +489,7 @@ static DISPID get_dispid( IDispatch *disp, const char *name ) str = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR) ); if (str) { - len = MultiByteToWideChar(CP_ACP, 0, name, -1, str, len ); + MultiByteToWideChar(CP_ACP, 0, name, -1, str, len ); r = IDispatch_GetIDsOfNames( disp, &IID_NULL, &str, 1, 0, &id ); HeapFree(GetProcessHeap(), 0, str); if (r != S_OK) @@ -871,7 +871,7 @@ static HRESULT invoke(IDispatch *pDispatch, LPCSTR szName, WORD wFlags, DISPPARA len = MultiByteToWideChar(CP_ACP, 0, szName, -1, NULL, 0 ); name = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR) ); if (!name) return E_FAIL; - len = MultiByteToWideChar(CP_ACP, 0, szName, -1, name, len ); + MultiByteToWideChar(CP_ACP, 0, szName, -1, name, len ); hr = IDispatch_GetIDsOfNames(pDispatch, &IID_NULL, &name, 1, LOCALE_USER_DEFAULT, &dispid); HeapFree(GetProcessHeap(), 0, name); ok(hr == S_OK, "IDispatch::GetIDsOfNames returned 0x%08x\n", hr);

1 0

Austin English : msi/tests: Make sure to use return values (LLVM/Clang).
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: 7de70a48046a8710f30a24c295016d6b5e68aa2c URL: http://source.winehq.org/git/wine.git/?a=commit;h=7de70a48046a8710f30a24c29… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:37:59 2011 -0800 msi/tests: Make sure to use return values (LLVM/Clang). --- dlls/msi/tests/format.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/format.c b/dlls/msi/tests/format.c index 6ac1242..facd298 100644 --- a/dlls/msi/tests/format.c +++ b/dlls/msi/tests/format.c @@ -1023,6 +1023,7 @@ static void test_formatrecord(void) ok( r == ERROR_SUCCESS, "format failed\n"); r = MsiRecordSetString(hrec, 0, "[]"); + ok( r == ERROR_SUCCESS, "set string failed\n"); sz = sizeof buffer; r = MsiFormatRecord(0, hrec, buffer, &sz); ok( sz == 2, "size wrong\n"); @@ -1964,6 +1965,7 @@ static void test_formatrecord_package(void) r = MsiRecordSetString(hrec, 4, "[prop]"); ok( r == ERROR_SUCCESS, "set string failed\n"); r = MsiRecordSetString(hrec, 5, "[noprop]"); + ok( r == ERROR_SUCCESS, "set string failed\n"); sz = sizeof buffer; r = MsiFormatRecord(package, hrec, buffer, &sz); ok( r == ERROR_SUCCESS, "format failed with empty buffer (%i)\n",r);

1 0

Austin English : gdiplus/tests: Make sure to use return values (LLVM/Clang) .
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: f817e547f9dee657951d7060d9822df78b40fe81 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f817e547f9dee657951d7060d… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:39:49 2011 -0800 gdiplus/tests: Make sure to use return values (LLVM/Clang). --- dlls/gdiplus/tests/graphics.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/tests/graphics.c b/dlls/gdiplus/tests/graphics.c index 040a714..9a746b1 100644 --- a/dlls/gdiplus/tests/graphics.c +++ b/dlls/gdiplus/tests/graphics.c @@ -1416,7 +1416,6 @@ static void test_Get_Release_DC(void) expect(ObjectBusy, status); /* try all Graphics calls here */ - status = Ok; status = GdipDrawArc(graphics, pen, 0.0, 0.0, 1.0, 1.0, 0.0, 0.0); expect(ObjectBusy, status); status = GdipDrawArcI(graphics, pen, 0, 0, 1, 1, 0.0, 0.0); @@ -1599,6 +1598,7 @@ static void test_Get_Release_DC(void) status = GdipGetDpiY(graphics, &r); expect(ObjectBusy, status); status = GdipMultiplyWorldTransform(graphics, m, MatrixOrderPrepend); + expect(ObjectBusy, status); status = GdipGetClip(graphics, region); expect(ObjectBusy, status); status = GdipTransformPoints(graphics, CoordinateSpacePage, CoordinateSpaceWorld, ptf, 5);

1 0

Austin English : inetmib1/tests: Remove a dead assignment (LLVM/Clang).
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: 6d66446baf2723884075b8fac037a13310d722c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6d66446baf2723884075b8fac… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:41:26 2011 -0800 inetmib1/tests: Remove a dead assignment (LLVM/Clang). --- dlls/inetmib1/tests/main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/inetmib1/tests/main.c b/dlls/inetmib1/tests/main.c index cc0e56f..03c9b62 100644 --- a/dlls/inetmib1/tests/main.c +++ b/dlls/inetmib1/tests/main.c @@ -251,7 +251,6 @@ static void testQuery(void) vars2[0].value.asnType = 0; list.len = 1; list.list = vars2; - moreData = TRUE; noChange = FALSE; ret = pQuery(SNMP_PDU_GETNEXT, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index);

1 0

Austin English : crypt32/tests: Remove a dead initialization (LLVM/Clang).
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: c4b1523b90cc2be7fb5ef3c8c84348d6aaf83cc1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4b1523b90cc2be7fb5ef3c8c… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Feb 16 17:50:14 2011 -0800 crypt32/tests: Remove a dead initialization (LLVM/Clang). --- dlls/crypt32/tests/protectdata.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/tests/protectdata.c b/dlls/crypt32/tests/protectdata.c index 29d04e8..70a8ba8 100644 --- a/dlls/crypt32/tests/protectdata.c +++ b/dlls/crypt32/tests/protectdata.c @@ -244,7 +244,6 @@ static void test_simpleroundtrip(const char *plaintext) START_TEST(protectdata) { HMODULE hCrypt32 = GetModuleHandleA("crypt32.dll"); - hCrypt32 = GetModuleHandleA("crypt32.dll"); pCryptProtectData = (void*)GetProcAddress(hCrypt32, "CryptProtectData"); pCryptUnprotectData = (void*)GetProcAddress(hCrypt32, "CryptUnprotectData"); if (!pCryptProtectData || !pCryptUnprotectData)

1 0

Juan Lang : wintrust/tests: Fix a leak (valgrind).
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: 7c42297bf3a9aa922b3bfedc08dfa025fa8203ec URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c42297bf3a9aa922b3bfedc0… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Feb 16 10:44:45 2011 -0800 wintrust/tests: Fix a leak (valgrind). --- dlls/wintrust/tests/softpub.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/dlls/wintrust/tests/softpub.c b/dlls/wintrust/tests/softpub.c index 0327bf5..7ec24a9 100644 --- a/dlls/wintrust/tests/softpub.c +++ b/dlls/wintrust/tests/softpub.c @@ -734,9 +734,16 @@ static void test_wintrust(void) r = WinVerifyTrust(INVALID_HANDLE_VALUE, &generic_action_v2, &wtd); ok(r == TRUST_E_NOSIGNATURE || r == CRYPT_E_FILE_ERROR, "expected TRUST_E_NOSIGNATURE or CRYPT_E_FILE_ERROR, got %08x\n", r); + wtd.dwStateAction = WTD_STATEACTION_CLOSE; + r = WinVerifyTrust(INVALID_HANDLE_VALUE, &generic_action_v2, &wtd); + ok(r == S_OK, "WinVerifyTrust failed: %08x\n", r); + wtd.dwStateAction = WTD_STATEACTION_VERIFY; hr = WinVerifyTrustEx(INVALID_HANDLE_VALUE, &generic_action_v2, &wtd); - ok(hr == TRUST_E_NOSIGNATURE || r == CRYPT_E_FILE_ERROR, + ok(hr == TRUST_E_NOSIGNATURE || hr == CRYPT_E_FILE_ERROR, "expected TRUST_E_NOSIGNATURE or CRYPT_E_FILE_ERROR, got %08x\n", hr); + wtd.dwStateAction = WTD_STATEACTION_CLOSE; + r = WinVerifyTrust(INVALID_HANDLE_VALUE, &generic_action_v2, &wtd); + ok(r == S_OK, "WinVerifyTrust failed: %08x\n", r); } static void test_get_known_usages(void)

1 0

Rico Schüller : d3dcompiler/tests: Add reflection vs desc test.
by Alexandre Julliard 17 Feb '11

17 Feb '11

Module: wine Branch: master Commit: c7ed17ac66ae6c2a0603249ced7723e496c2fe02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c7ed17ac66ae6c2a0603249ce… Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Feb 16 20:27:52 2011 +0100 d3dcompiler/tests: Add reflection vs desc test. --- dlls/d3dcompiler_43/tests/reflection.c | 287 ++++++++++++++++++++++++++++++++ 1 files changed, 287 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c7ed17ac66ae6c2a06032…

1 0