March 2011 - Wine-commits - list.winehq.org

Piotr Caban : mshtml: Report an error when navigation fails.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: c3a677d007607aa96b3564230956fe737483d75a URL: http://source.winehq.org/git/wine.git/?a=commit;h=c3a677d007607aa96b3564230… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:35:34 2011 +0200 mshtml: Report an error when navigation fails. --- dlls/mshtml/navigate.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 116 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb71c79..db624d8 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -1110,11 +1110,105 @@ static HRESULT async_stop_request(nsChannelBSC *This) return S_OK; } +static void handle_navigation_error(nsChannelBSC *This, DWORD result) +{ + HTMLDocumentObj *doc; + IOleCommandTarget *olecmd; + BOOL is_error_url; + SAFEARRAY *sa; + SAFEARRAYBOUND bound; + VARIANT var, varOut; + LONG ind; + BSTR url, unk; + HRESULT hres; + + if(!This->window) + return; + + doc = This->window->doc_obj; + if(!doc || !doc->doc_object_service || !doc->client) + return; + + hres = IDocObjectService_IsErrorUrl(doc->doc_object_service, + This->window->url, &is_error_url); + if(FAILED(hres) || is_error_url) + return; + + hres = IOleClientSite_QueryInterface(doc->client, + &IID_IOleCommandTarget, (void**)&olecmd); + if(FAILED(hres)) + return; + + bound.lLbound = 0; + bound.cElements = 8; + sa = SafeArrayCreate(VT_VARIANT, 1, &bound); + if(!sa) { + IOleCommandTarget_Release(olecmd); + return; + } + + ind = 0; + V_VT(&var) = VT_I4; + V_I4(&var) = result; + SafeArrayPutElement(sa, &ind, &var); + + ind = 1; + V_VT(&var) = VT_BSTR; + url = SysAllocString(This->window->url); + V_BSTR(&var) = url; + SafeArrayPutElement(sa, &ind, &var); + + ind = 3; + V_VT(&var) = VT_UNKNOWN; + V_UNKNOWN(&var) = (IUnknown*)&This->window->IHTMLWindow2_iface; + SafeArrayPutElement(sa, &ind, &var); + + /* FIXME: what are the following fields for? */ + ind = 2; + V_VT(&var) = VT_UNKNOWN; + V_UNKNOWN(&var) = NULL; + SafeArrayPutElement(sa, &ind, &var); + + ind = 4; + V_VT(&var) = VT_BOOL; + V_BOOL(&var) = FALSE; + SafeArrayPutElement(sa, &ind, &var); + + ind = 5; + V_VT(&var) = VT_BOOL; + V_BOOL(&var) = FALSE; + SafeArrayPutElement(sa, &ind, &var); + + ind = 6; + V_VT(&var) = VT_BSTR; + unk = SysAllocString(NULL); + V_BSTR(&var) = unk; + SafeArrayPutElement(sa, &ind, &var); + + ind = 7; + V_VT(&var) = VT_UNKNOWN; + V_UNKNOWN(&var) = NULL; + SafeArrayPutElement(sa, &ind, &var); + + V_VT(&var) = VT_ARRAY; + V_ARRAY(&var) = sa; + V_VT(&varOut) = VT_BOOL; + V_BOOL(&varOut) = VARIANT_TRUE; + IOleCommandTarget_Exec(olecmd, &CGID_DocHostCmdPriv, 1, 0, &var, FAILED(hres)?NULL:&varOut); + + SysFreeString(url); + SysFreeString(unk); + SafeArrayDestroy(sa); + IOleCommandTarget_Release(olecmd); +} + static HRESULT nsChannelBSC_stop_binding(BSCallback *bsc, HRESULT result) { nsChannelBSC *This = nsChannelBSC_from_BSCallback(bsc); - if(This->window && SUCCEEDED(result)) { + if(FAILED(result)) + handle_navigation_error(This, result); + else if(This->window) { result = async_stop_request(This); if(SUCCEEDED(result)) return S_OK; @@ -1148,6 +1242,27 @@ static HRESULT nsChannelBSC_on_progress(BSCallback *bsc, ULONG status_code, LPCW /* FIXME: We should find a better way to handle this */ set_wine_url(This->nschannel->uri, status_text); + break; + case BINDSTATUS_BEGINDOWNLOADDATA: { + IWinInetHttpInfo *http_info; + DWORD status, size = sizeof(DWORD); + HRESULT hres; + + if(!This->bsc.binding) + break; + + hres = IBinding_QueryInterface(This->bsc.binding, &IID_IWinInetHttpInfo, (void**)&http_info); + if(FAILED(hres)) + break; + + hres = IWinInetHttpInfo_QueryInfo(http_info, + HTTP_QUERY_STATUS_CODE|HTTP_QUERY_FLAG_NUMBER, &status, &size, NULL, NULL); + IWinInetHttpInfo_Release(http_info); + if(FAILED(hres) || status == HTTP_STATUS_OK) + break; + + handle_navigation_error(This, status); + } } return S_OK;

1 0

Piotr Caban : mshtml/tests: Added IWinInetHttpInfo interface.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: 9b4ee3176e0ece3527b8c3f6a8c6cf65cc1c97cb URL: http://source.winehq.org/git/wine.git/?a=commit;h=9b4ee3176e0ece3527b8c3f6a… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:36:03 2011 +0200 mshtml/tests: Added IWinInetHttpInfo interface. --- dlls/mshtml/tests/htmldoc.c | 71 ++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 66 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index d45eefb..2da187f 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -167,6 +167,7 @@ static BOOL set_clientsite, container_locked; static BOOL readystate_set_loading = FALSE, readystate_set_interactive = FALSE, load_from_stream; static BOOL editmode = FALSE; static BOOL inplace_deactivated, open_call; +static DWORD status_code = HTTP_STATUS_OK; static int stream_read, protocol_read; static enum load_state_t { LD_DOLOAD, @@ -981,13 +982,73 @@ static const IStreamVtbl StreamVtbl = { static IStream Stream = { &StreamVtbl }; -static HRESULT WINAPI Binding_QueryInterface(IBinding *iface, REFIID riid, void **ppv) +static HRESULT WINAPI WinInetHttpInfo_QueryInterface( + IWinInetHttpInfo* This, + REFIID riid, + void **ppvObject) { - if(IsEqualGUID(&IID_IWinInetHttpInfo, riid)) - return E_NOINTERFACE; /* TODO */ + ok(0, "unexpected call\n"); + return E_NOINTERFACE; +} - if(IsEqualGUID(&IID_IWinInetInfo, riid)) - return E_NOINTERFACE; /* TODO */ +static ULONG WINAPI WinInetHttpInfo_AddRef( + IWinInetHttpInfo* This) +{ + return 2; +} + +static ULONG WINAPI WinInetHttpInfo_Release( + IWinInetHttpInfo* This) +{ + return 1; +} + +static HRESULT WINAPI WinInetHttpInfo_QueryOption( + IWinInetHttpInfo* This, + DWORD dwOption, + LPVOID pBuffer, + DWORD *pcbBuf) +{ + return E_NOTIMPL; /* TODO */ +} + +static HRESULT WINAPI WinInetHttpInfo_QueryInfo( + IWinInetHttpInfo* This, + DWORD dwOption, + LPVOID pBuffer, + DWORD *pcbBuf, + DWORD *pdwFlags, + DWORD *pdwReserved) +{ + ok(pdwReserved == NULL, "pdwReserved != NULL\n"); + + if(dwOption == (HTTP_QUERY_STATUS_CODE|HTTP_QUERY_FLAG_NUMBER)) { + ok(pBuffer != NULL, "pBuffer == NULL\n"); + ok(*pcbBuf == sizeof(DWORD), "*pcbBuf = %d\n", *pcbBuf); + ok(pdwFlags == NULL, "*pdwFlags != NULL\n"); + *((DWORD*)pBuffer) = status_code; + return S_OK; + } + + return E_NOTIMPL; /* TODO */ +} + +static const IWinInetHttpInfoVtbl WinInetHttpInfoVtbl = { + WinInetHttpInfo_QueryInterface, + WinInetHttpInfo_AddRef, + WinInetHttpInfo_Release, + WinInetHttpInfo_QueryOption, + WinInetHttpInfo_QueryInfo +}; + +static IWinInetHttpInfo WinInetHttpInfo = { &WinInetHttpInfoVtbl }; + +static HRESULT WINAPI Binding_QueryInterface(IBinding *iface, REFIID riid, void **ppv) +{ + if(IsEqualGUID(&IID_IWinInetInfo, riid) || IsEqualGUID(&IID_IWinInetHttpInfo, riid)) { + *ppv = &WinInetHttpInfo; + return S_OK; + } ok(0, "unexpected call\n"); return E_NOINTERFACE;

1 0

Piotr Caban : mshtml/tests: Added IBrowserService interface.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: 9ebe31016cea69d30f26962ebc49782a08c37700 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9ebe31016cea69d30f26962eb… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:36:14 2011 +0200 mshtml/tests: Added IBrowserService interface. --- dlls/mshtml/tests/htmldoc.c | 351 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 351 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=9ebe31016cea69d30f269…

1 0

Piotr Caban : mshtml/tests: Added IDocObjectService interface.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: 21d500b37f19780742a7038acd52776e1b717530 URL: http://source.winehq.org/git/wine.git/?a=commit;h=21d500b37f19780742a7038ac… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:36:23 2011 +0200 mshtml/tests: Added IDocObjectService interface. --- dlls/mshtml/nsevents.c | 2 +- dlls/mshtml/tests/htmldoc.c | 159 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 158 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/nsevents.c b/dlls/mshtml/nsevents.c index 957b892..bd6faf6 100644 --- a/dlls/mshtml/nsevents.c +++ b/dlls/mshtml/nsevents.c @@ -254,7 +254,7 @@ static nsresult NSAPI handle_load(nsIDOMEventListener *iface, nsIDOMEvent *event update_title(doc_obj); } - if(doc_obj && doc_obj->doc_object_service) + if(doc_obj && doc_obj->usermode!=EDITMODE && doc_obj->doc_object_service) IDocObjectService_FireDocumentComplete(doc_obj->doc_object_service, &doc->basedoc.window->IHTMLWindow2_iface, 0); diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index bdabfd5..3dac323 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -161,6 +161,11 @@ DEFINE_EXPECT(OnViewChange); DEFINE_EXPECT(EvaluateNewWindow); DEFINE_EXPECT(GetTravelLog); DEFINE_EXPECT(UpdateBackForwardState); +DEFINE_EXPECT(FireNavigateComplete2); +DEFINE_EXPECT(FireDocumentComplete); +DEFINE_EXPECT(GetPendingUrl); +DEFINE_EXPECT(ActiveElementChanged); +DEFINE_EXPECT(IsErrorUrl); static IUnknown *doc_unk; static IMoniker *doc_mon; @@ -2834,6 +2839,134 @@ static const IDispatchVtbl DispatchVtbl = { static IDispatch Dispatch = { &DispatchVtbl }; +static HRESULT WINAPI DocObjectService_QueryInterface( + IDocObjectService* This, + REFIID riid, + void **ppvObject) +{ + /* F62D9369-75EF-4578-8856-232802C76468 (ITridentService2) */ + return E_NOTIMPL; +} + +static ULONG WINAPI DocObjectService_AddRef( + IDocObjectService* This) +{ + return 2; +} + +static ULONG WINAPI DocObjectService_Release( + IDocObjectService* This) +{ + return 1; +} + +static HRESULT WINAPI DocObjectService_FireBeforeNavigate2( + IDocObjectService* This, + IDispatch *pDispatch, + LPCWSTR lpszUrl, + DWORD dwFlags, + LPCWSTR lpszFrameName, + BYTE *pPostData, + DWORD cbPostData, + LPCWSTR lpszHeaders, + BOOL fPlayNavSound, + BOOL *pfCancel) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_FireNavigateComplete2( + IDocObjectService* This, + IHTMLWindow2 *pHTMLWindow2, + DWORD dwFlags) +{ + CHECK_EXPECT(FireNavigateComplete2); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_FireDownloadBegin( + IDocObjectService* This) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_FireDownloadComplete( + IDocObjectService* This) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_FireDocumentComplete( + IDocObjectService* This, + IHTMLWindow2 *pHTMLWindow, + DWORD dwFlags) +{ + CHECK_EXPECT(FireDocumentComplete); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_UpdateDesktopComponent( + IDocObjectService* This, + IHTMLWindow2 *pHTMLWindow) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_GetPendingUrl( + IDocObjectService* This, + BSTR *pbstrPendingUrl) +{ + CHECK_EXPECT(GetPendingUrl); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_ActiveElementChanged( + IDocObjectService* This, + IHTMLElement *pHTMLElement) +{ + CHECK_EXPECT(ActiveElementChanged); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_GetUrlSearchComponent( + IDocObjectService* This, + BSTR *pbstrSearch) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI DocObjectService_IsErrorUrl( + IDocObjectService* This, + LPCWSTR lpszUrl, + BOOL *pfIsError) +{ + CHECK_EXPECT(IsErrorUrl); + return E_NOTIMPL; +} + +static IDocObjectServiceVtbl DocObjectServiceVtbl = { + DocObjectService_QueryInterface, + DocObjectService_AddRef, + DocObjectService_Release, + DocObjectService_FireBeforeNavigate2, + DocObjectService_FireNavigateComplete2, + DocObjectService_FireDownloadBegin, + DocObjectService_FireDownloadComplete, + DocObjectService_FireDocumentComplete, + DocObjectService_UpdateDesktopComponent, + DocObjectService_GetPendingUrl, + DocObjectService_ActiveElementChanged, + DocObjectService_GetUrlSearchComponent, + DocObjectService_IsErrorUrl +}; + +static IDocObjectService DocObjectService = { &DocObjectServiceVtbl }; + DEFINE_GUID(IID_ITabBrowserService, 0x5E8FA523,0x83D4,0x4DBE,0x81,0x99,0x4C,0x18,0xE4,0x85,0x87,0x25); static HRESULT WINAPI BrowserService_QueryInterface( @@ -2846,8 +2979,10 @@ static HRESULT WINAPI BrowserService_QueryInterface( if(IsEqualGUID(&IID_IShellBrowser, riid)) return E_NOINTERFACE; /* TODO */ - if(IsEqualGUID(&IID_IDocObjectService, riid)) - return E_NOINTERFACE; /* TODO */ + if(IsEqualGUID(&IID_IDocObjectService, riid)) { + *ppvObject = &DocObjectService; + return S_OK; + } if(IsEqualGUID(&IID_ITabBrowserService, riid)) return E_NOINTERFACE; /* TODO */ @@ -3665,9 +3800,11 @@ static void test_Load(IPersistMoniker *persist, IMoniker *mon) SET_EXPECT(Invoke_AMBIENT_SILENT); SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); SET_EXPECT(Exec_ShellDocView_37); + SET_EXPECT(IsErrorUrl); } else SET_EXPECT(GetTravelLog); + SET_EXPECT(GetPendingUrl); load_state = LD_DOLOAD; expect_LockContainer_fLock = TRUE; readystate_set_loading = TRUE; @@ -3709,9 +3846,11 @@ static void test_Load(IPersistMoniker *persist, IMoniker *mon) CHECK_CALLED(Invoke_AMBIENT_SILENT); CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); CHECK_CALLED(Exec_ShellDocView_37); + todo_wine CHECK_CALLED(IsErrorUrl); } else todo_wine CHECK_CALLED(GetTravelLog); + todo_wine CHECK_CALLED(GetPendingUrl); set_clientsite = container_locked = TRUE; @@ -3786,6 +3925,12 @@ static void test_download(DWORD flags) SET_EXPECT(Exec_SETTITLE); SET_EXPECT(UpdateBackForwardState); } + if(!editmode && !(flags & DWL_EMPTY)) + SET_EXPECT(FireNavigateComplete2); + if(!editmode) + SET_EXPECT(FireDocumentComplete); + SET_EXPECT(ActiveElementChanged); + SET_EXPECT(IsErrorUrl); expect_status_text = (LPWSTR)0xdeadbeef; /* TODO */ while(!called_Exec_HTTPEQUIV_DONE && GetMessage(&msg, NULL, 0, 0)) { @@ -3847,6 +3992,12 @@ static void test_download(DWORD flags) SET_CALLED(Exec_SETTITLE); todo_wine CHECK_CALLED(UpdateBackForwardState); } + if(!editmode && !(flags & DWL_EMPTY)) + todo_wine CHECK_CALLED(FireNavigateComplete2); + if(!editmode) + CHECK_CALLED(FireDocumentComplete); + todo_wine CHECK_CALLED(ActiveElementChanged); + todo_wine CHECK_CALLED(IsErrorUrl); load_state = LD_COMPLETE; @@ -4957,6 +5108,7 @@ static void test_StreamLoad(IHTMLDocument2 *doc) SET_EXPECT(Exec_ShellDocView_37); SET_EXPECT(OnChanged_READYSTATE); SET_EXPECT(Read); + SET_EXPECT(GetPendingUrl); readystate_set_loading = TRUE; hres = IPersistStreamInit_Load(init, &Stream); @@ -4967,6 +5119,7 @@ static void test_StreamLoad(IHTMLDocument2 *doc) CHECK_CALLED(Exec_ShellDocView_37); CHECK_CALLED(OnChanged_READYSTATE); CHECK_CALLED(Read); + todo_wine CHECK_CALLED(GetPendingUrl); test_timer(EXPECT_SETTITLE); test_GetCurMoniker((IUnknown*)doc, NULL, "about:blank"); @@ -4988,6 +5141,7 @@ static void test_StreamInitNew(IHTMLDocument2 *doc) SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); SET_EXPECT(Exec_ShellDocView_37); SET_EXPECT(OnChanged_READYSTATE); + SET_EXPECT(GetPendingUrl); readystate_set_loading = TRUE; hres = IPersistStreamInit_InitNew(init); @@ -4997,6 +5151,7 @@ static void test_StreamInitNew(IHTMLDocument2 *doc) CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); CHECK_CALLED(Exec_ShellDocView_37); CHECK_CALLED(OnChanged_READYSTATE); + todo_wine CHECK_CALLED(GetPendingUrl); test_timer(EXPECT_SETTITLE); test_GetCurMoniker((IUnknown*)doc, NULL, "about:blank");

1 0

Piotr Caban : mshtml/tests: Added asynchronous moniker to htmldoc tests.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: f7afa250f80b0c3e78f9c0726d09b8e7c96616f1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f7afa250f80b0c3e78f9c0726… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:36:35 2011 +0200 mshtml/tests: Added asynchronous moniker to htmldoc tests. --- dlls/mshtml/tests/htmldoc.c | 88 ++++++++++++++++++++++++++++--------------- 1 files changed, 57 insertions(+), 31 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index 3dac323..843b9cc 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -177,6 +177,7 @@ static BOOL readystate_set_loading = FALSE, readystate_set_interactive = FALSE, static BOOL editmode = FALSE; static BOOL inplace_deactivated, open_call; static DWORD status_code = HTTP_STATUS_OK; +static BOOL asynchronous_binding = FALSE; static int stream_read, protocol_read; static enum load_state_t { LD_DOLOAD, @@ -204,6 +205,7 @@ static const WCHAR http_urlW[] = static const WCHAR doc_url[] = {'w','i','n','e','t','e','s','t',':','d','o','c',0}; #define DOCHOST_DOCCANNAVIGATE 0 +#define WM_CONTINUE_BINDING (WM_APP+1) static HRESULT QueryInterface(REFIID riid, void **ppv); static void test_MSHTML_QueryStatus(IHTMLDocument2*,DWORD); @@ -1054,6 +1056,11 @@ static IWinInetHttpInfo WinInetHttpInfo = { &WinInetHttpInfoVtbl }; static HRESULT WINAPI Binding_QueryInterface(IBinding *iface, REFIID riid, void **ppv) { + if(IsEqualGUID(&IID_IUnknown, riid)) { + *ppv = iface; + return S_OK; + } + if(IsEqualGUID(&IID_IWinInetInfo, riid) || IsEqualGUID(&IID_IWinInetHttpInfo, riid)) { *ppv = &WinInetHttpInfo; return S_OK; @@ -1076,6 +1083,8 @@ static ULONG WINAPI Binding_Release(IBinding *iface) static HRESULT WINAPI Binding_Abort(IBinding *iface) { CHECK_EXPECT(Abort); + if(asynchronous_binding) + PeekMessage(NULL, container_hwnd, WM_CONTINUE_BINDING, WM_CONTINUE_BINDING, PM_REMOVE); return S_OK; } @@ -1188,18 +1197,53 @@ static HRESULT WINAPI Moniker_BindToObject(IMoniker *iface, IBindCtx *pcb, IMoni return E_NOTIMPL; } +static void continue_binding(IBindStatusCallback *callback) +{ + FORMATETC formatetc = {0xc02d, NULL, 1, -1, TYMED_ISTREAM}; + STGMEDIUM stgmedium; + HRESULT hres; + + static const WCHAR wszTextHtml[] = {'t','e','x','t','/','h','t','m','l',0}; + + hres = IBindStatusCallback_OnProgress(callback, 0, 0, BINDSTATUS_MIMETYPEAVAILABLE, + wszTextHtml); + ok(hres == S_OK, "OnProgress(BINDSTATUS_MIMETYPEAVAILABLE) failed: %08x\n", hres); + + hres = IBindStatusCallback_OnProgress(callback, sizeof(html_page)-1, sizeof(html_page)-1, + BINDSTATUS_BEGINDOWNLOADDATA, doc_url); + ok(hres == S_OK, "OnProgress(BINDSTATUS_BEGINDOWNLOADDATA) failed: %08x\n", hres); + + SET_EXPECT(Read); + stgmedium.tymed = TYMED_ISTREAM; + U(stgmedium).pstm = &Stream; + stgmedium.pUnkForRelease = (IUnknown*)&Moniker; + hres = IBindStatusCallback_OnDataAvailable(callback, + BSCF_FIRSTDATANOTIFICATION|BSCF_LASTDATANOTIFICATION, + sizeof(html_page)-1, &formatetc, &stgmedium); + ok(hres == S_OK, "OnDataAvailable failed: %08x\n", hres); + CHECK_CALLED(Read); + + hres = IBindStatusCallback_OnProgress(callback, sizeof(html_page)-1, sizeof(html_page)-1, + BINDSTATUS_ENDDOWNLOADDATA, NULL); + ok(hres == S_OK, "OnProgress(BINDSTATUS_ENDDOWNLOADDATA) failed: %08x\n", hres); + + SET_EXPECT(GetBindResult); + hres = IBindStatusCallback_OnStopBinding(callback, S_OK, NULL); + ok(hres == S_OK, "OnStopBinding failed: %08x\n", hres); + SET_CALLED(GetBindResult); /* IE7 */ + + IBindStatusCallback_Release(callback); +} + static HRESULT WINAPI Moniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, IMoniker *pmkToLeft, REFIID riid, void **ppv) { IBindStatusCallback *callback = NULL; - FORMATETC formatetc = {0xc02d, NULL, 1, -1, TYMED_ISTREAM}; - STGMEDIUM stgmedium; BINDINFO bindinfo; DWORD bindf; HRESULT hres; static OLECHAR BSCBHolder[] = { '_','B','S','C','B','_','H','o','l','d','e','r','_',0 }; - static const WCHAR wszTextHtml[] = {'t','e','x','t','/','h','t','m','l',0}; CHECK_EXPECT(BindToStorage); @@ -1240,35 +1284,12 @@ static HRESULT WINAPI Moniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, IMon hres = IBindStatusCallback_OnStartBinding(callback, 0, &Binding); ok(hres == S_OK, "OnStartBinding failed: %08x\n", hres); - hres = IBindStatusCallback_OnProgress(callback, 0, 0, BINDSTATUS_MIMETYPEAVAILABLE, - wszTextHtml); - ok(hres == S_OK, "OnProgress(BINDSTATUS_MIMETYPEAVAILABLE) failed: %08x\n", hres); - - hres = IBindStatusCallback_OnProgress(callback, sizeof(html_page)-1, sizeof(html_page)-1, - BINDSTATUS_BEGINDOWNLOADDATA, doc_url); - ok(hres == S_OK, "OnProgress(BINDSTATUS_BEGINDOWNLOADDATA) failed: %08x\n", hres); - - SET_EXPECT(Read); - stgmedium.tymed = TYMED_ISTREAM; - U(stgmedium).pstm = &Stream; - stgmedium.pUnkForRelease = (IUnknown*)iface; - hres = IBindStatusCallback_OnDataAvailable(callback, - BSCF_FIRSTDATANOTIFICATION|BSCF_LASTDATANOTIFICATION, - sizeof(html_page)-1, &formatetc, &stgmedium); - ok(hres == S_OK, "OnDataAvailable failed: %08x\n", hres); - CHECK_CALLED(Read); - - hres = IBindStatusCallback_OnProgress(callback, sizeof(html_page)-1, sizeof(html_page)-1, - BINDSTATUS_ENDDOWNLOADDATA, NULL); - ok(hres == S_OK, "OnProgress(BINDSTATUS_ENDDOWNLOADDATA) failed: %08x\n", hres); - - SET_EXPECT(GetBindResult); - hres = IBindStatusCallback_OnStopBinding(callback, S_OK, NULL); - ok(hres == S_OK, "OnStopBinding failed: %08x\n", hres); - SET_CALLED(GetBindResult); /* IE7 */ - - IBindStatusCallback_Release(callback); + if(asynchronous_binding) { + PostMessageW(container_hwnd, WM_CONTINUE_BINDING, (WPARAM)callback, 0); + return MK_S_ASYNCHRONOUS; + } + continue_binding(callback); return S_OK; } @@ -3533,6 +3554,11 @@ static HRESULT QueryInterface(REFIID riid, void **ppv) static LRESULT WINAPI wnd_proc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { + if(msg == WM_CONTINUE_BINDING) { + IBindStatusCallback *callback = (IBindStatusCallback*)wParam; + continue_binding(callback); + } + return DefWindowProc(hwnd, msg, wParam, lParam); }

1 0

Piotr Caban : mshtml/tests: Added connection error handling tests.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: 2790f363c57e283ad7b4979f52f199bbd466b5af URL: http://source.winehq.org/git/wine.git/?a=commit;h=2790f363c57e283ad7b4979f5… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:36:45 2011 +0200 mshtml/tests: Added connection error handling tests. --- dlls/mshtml/tests/htmldoc.c | 68 +++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 65 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index 843b9cc..2df4e74 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -1212,6 +1212,10 @@ static void continue_binding(IBindStatusCallback *callback) hres = IBindStatusCallback_OnProgress(callback, sizeof(html_page)-1, sizeof(html_page)-1, BINDSTATUS_BEGINDOWNLOADDATA, doc_url); ok(hres == S_OK, "OnProgress(BINDSTATUS_BEGINDOWNLOADDATA) failed: %08x\n", hres); + if(status_code != HTTP_STATUS_OK) { + CHECK_CALLED(IsErrorUrl); + SET_EXPECT(IsErrorUrl); + } SET_EXPECT(Read); stgmedium.tymed = TYMED_ISTREAM; @@ -2752,6 +2756,57 @@ static HRESULT WINAPI OleCommandTarget_Exec(IOleCommandTarget *iface, const GUID ok(V_VT(pvaIn) == VT_UNKNOWN, "V_VT(pvaIn) != VT_UNKNOWN\n"); /* FIXME: test V_UNKNOWN(pvaIn) == window */ return S_OK; + case 1: { + SAFEARRAY *sa; + UINT dim; + LONG ind=0; + VARIANT var; + HRESULT hres; + + ok(pvaIn != NULL, "pvaIn == NULL\n"); + ok(pvaOut != NULL, "pvaOut != NULL\n"); + ok(V_VT(pvaIn) == VT_ARRAY, "V_VT(pvaIn) = %d\n", V_VT(pvaIn)); + ok(V_VT(pvaOut) == VT_BOOL, "V_VT(pvaOut) = %d\n", V_VT(pvaOut)); + sa = V_ARRAY(pvaIn); + + dim = SafeArrayGetDim(sa); + ok(dim == 1, "dim = %d\n", dim); + hres = SafeArrayGetLBound(sa, 1, &ind); + ok(hres == S_OK, "SafeArrayGetLBound failed: %x\n", hres); + ok(ind == 0, "Lower bound = %d\n", ind); + hres = SafeArrayGetUBound(sa, 1, &ind); + ok(hres == S_OK, "SafeArrayGetUBound failed: %x\n", hres); + ok(ind == 7 || broken(ind == 5), "Upper bound = %d\n", ind); + + ind = 0; + SafeArrayGetElement(sa, &ind, &var); + ok(V_VT(&var) == VT_I4, "Incorrect data type: %d\n", V_VT(&var)); + ok(V_I4(&var) == status_code, "Incorrect error code: %d\n", V_I4(&var)); + VariantClear(&var); + ind = 1; + SafeArrayGetElement(sa, &ind, &var); + ok(V_VT(&var) == VT_BSTR, "Incorrect data type: %d\n", V_VT(&var)); + ok(!strcmp_wa(V_BSTR(&var), "winetest:doc"), "Page address: %s\n", wine_dbgstr_w(V_BSTR(&var))); + VariantClear(&var); + ind = 2; + SafeArrayGetElement(sa, &ind, &var); + ok(V_VT(&var) == VT_UNKNOWN, "Incorrect data type: %d\n", V_VT(&var)); + VariantClear(&var); + ind = 3; + SafeArrayGetElement(sa, &ind, &var); + ok(V_VT(&var) == VT_UNKNOWN, "Incorrect data type: %d\n", V_VT(&var)); + VariantClear(&var); + ind = 4; + SafeArrayGetElement(sa, &ind, &var); + ok(V_VT(&var) == VT_BOOL, "Incorrect data type: %d\n", V_VT(&var)); + ok(!V_BOOL(&var), "Unknown value is incorrect\n"); + VariantClear(&var); + ind = 5; + SafeArrayGetElement(sa, &ind, &var); + ok(V_VT(&var) == VT_BOOL, "Incorrect data type: %d\n", V_VT(&var)); + ok(!V_BOOL(&var), "Unknown value is incorrect\n"); + VariantClear(&var); + } default: return E_FAIL; /* TODO */ } @@ -2967,7 +3022,8 @@ static HRESULT WINAPI DocObjectService_IsErrorUrl( BOOL *pfIsError) { CHECK_EXPECT(IsErrorUrl); - return E_NOTIMPL; + *pfIsError = FALSE; + return S_OK; } static IDocObjectServiceVtbl DocObjectServiceVtbl = { @@ -5353,7 +5409,7 @@ static void test_HTMLDocument(BOOL do_load) ok(!IsWindow(hwnd), "hwnd is not destroyed\n"); } -static void test_HTMLDocument_hlink(void) +static void test_HTMLDocument_hlink(DWORD status) { IHTMLDocument2 *doc; @@ -5372,7 +5428,9 @@ static void test_HTMLDocument_hlink(void) test_Persist(doc, &Moniker); test_Navigate(doc); + status_code = status; test_download(DWL_CSS|DWL_TRYCSS); + status_code = HTTP_STATUS_OK; test_IsDirty(doc, S_FALSE); test_MSHTML_QueryStatus(doc, OLECMDF_SUPPORTED); @@ -6000,7 +6058,11 @@ START_TEST(htmldoc) container_hwnd = create_container_window(); register_protocol(); - test_HTMLDocument_hlink(); + asynchronous_binding = TRUE; + test_HTMLDocument_hlink(HTTP_STATUS_NOT_FOUND); + + asynchronous_binding = FALSE; + test_HTMLDocument_hlink(HTTP_STATUS_OK); test_HTMLDocument(FALSE); test_HTMLDocument(TRUE); test_HTMLDocument_StreamLoad();

1 0

Piotr Caban : shdocvw: Report navigation error depending on HTTP status code.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: d55ebe0a4b6c421356aabfee88971473cb729cc5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d55ebe0a4b6c421356aabfee8… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Mar 28 23:37:36 2011 +0200 shdocvw: Report navigation error depending on HTTP status code. --- dlls/shdocvw/navigate.c | 35 ++++++++++++++++++++++++++++++++++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index a6899b0..09135a8 100644 --- a/dlls/shdocvw/navigate.c +++ b/dlls/shdocvw/navigate.c @@ -40,6 +40,7 @@ typedef struct { LONG ref; DocHost *doc_host; + IBinding *binding; LPWSTR url; HGLOBAL post_data; @@ -176,6 +177,8 @@ static ULONG WINAPI BindStatusCallback_Release(IBindStatusCallback *iface) if(!ref) { if(This->doc_host) IOleClientSite_Release(&This->doc_host->IOleClientSite_iface); + if(This->binding) + IBinding_Release(This->binding); if(This->post_data) GlobalFree(This->post_data); SysFreeString(This->headers); @@ -193,6 +196,9 @@ static HRESULT WINAPI BindStatusCallback_OnStartBinding(IBindStatusCallback *ifa TRACE("(%p)->(%d %p)\n", This, dwReserved, pbind); + This->binding = pbind; + IBinding_AddRef(This->binding); + return S_OK; } @@ -212,10 +218,30 @@ static HRESULT WINAPI BindStatusCallback_OnLowResource(IBindStatusCallback *ifac return E_NOTIMPL; } +static DWORD get_http_status_code(IBinding *binding) +{ + IWinInetHttpInfo *http_info; + DWORD status, size = sizeof(DWORD); + HRESULT hres; + + hres = IBinding_QueryInterface(binding, &IID_IWinInetHttpInfo, (void**)&http_info); + if(FAILED(hres)) + return HTTP_STATUS_OK; + + hres = IWinInetHttpInfo_QueryInfo(http_info, HTTP_QUERY_STATUS_CODE|HTTP_QUERY_FLAG_NUMBER, + &status, &size, NULL, NULL); + IWinInetHttpInfo_Release(http_info); + + if(FAILED(hres)) + return HTTP_STATUS_OK; + return status; +} + static HRESULT WINAPI BindStatusCallback_OnProgress(IBindStatusCallback *iface, ULONG ulProgress, ULONG ulProgressMax, ULONG ulStatusCode, LPCWSTR szStatusText) { BindStatusCallback *This = impl_from_IBindStatusCallback(iface); + DWORD status_code; TRACE("(%p)->(%d %d %d %s)\n", This, ulProgress, ulProgressMax, ulStatusCode, debugstr_w(szStatusText)); @@ -225,6 +251,9 @@ static HRESULT WINAPI BindStatusCallback_OnProgress(IBindStatusCallback *iface, return set_dochost_url(This->doc_host, szStatusText); case BINDSTATUS_BEGINDOWNLOADDATA: set_status_text(This, szStatusText); /* FIXME: "Start downloading from site: %s" */ + status_code = get_http_status_code(This->binding); + if(status_code != HTTP_STATUS_OK) + handle_navigation_error(This->doc_host, status_code, This->url, NULL); return S_OK; case BINDSTATUS_ENDDOWNLOADDATA: set_status_text(This, szStatusText); /* FIXME: "Downloading from site: %s" */ @@ -298,13 +327,15 @@ static HRESULT WINAPI BindStatusCallback_OnStopBinding(IBindStatusCallback *ifac if(!This->doc_host) return S_OK; - /* FIXME: Check HTTP status code */ if(FAILED(hresult)) handle_navigation_error(This->doc_host, hresult, This->url, NULL); IOleClientSite_Release(&This->doc_host->IOleClientSite_iface); This->doc_host = NULL; + IBinding_Release(This->binding); + This->binding = NULL; + return S_OK; } @@ -438,6 +469,8 @@ static BindStatusCallback *create_callback(DocHost *doc_host, LPCWSTR url, PBYTE ret->doc_host = doc_host; IOleClientSite_AddRef(&doc_host->IOleClientSite_iface); + ret->binding = NULL; + if(post_data) { ret->post_data = GlobalAlloc(0, post_data_len); memcpy(ret->post_data, post_data, post_data_len);

1 0

David Hedberg : comdlg32: Add stub implementation of the Common Item dialogs.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: ab085d661c901fd18fb4e02354dfbaffcd0d5c6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab085d661c901fd18fb4e0235… Author: David Hedberg <david.hedberg(a)gmail.com> Date: Thu Mar 24 22:38:51 2011 +0100 comdlg32: Add stub implementation of the Common Item dialogs. --- dlls/comdlg32/Makefile.in | 1 + dlls/comdlg32/cdlg.h | 4 + dlls/comdlg32/cdlg32.c | 9 + dlls/comdlg32/itemdlg.c | 845 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 859 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ab085d661c901fd18fb4e…

1 0

André Hentschel : mshtml: Port numbers are unsigned.
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: 3a06c5a54a4fcab661c40d3a8c3071e88d20b448 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3a06c5a54a4fcab661c40d3a8… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Mar 28 21:40:24 2011 +0200 mshtml: Port numbers are unsigned. --- dlls/mshtml/htmllocation.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmllocation.c b/dlls/mshtml/htmllocation.c index 9d61cd1..9c90edc 100644 --- a/dlls/mshtml/htmllocation.c +++ b/dlls/mshtml/htmllocation.c @@ -333,7 +333,7 @@ static HRESULT WINAPI HTMLLocation_get_host(IHTMLLocation *iface, BSTR *p) if(url.nPort) { /* <hostname>:<port> */ - const WCHAR format[] = {'%','d',0}; + const WCHAR format[] = {'%','u',0}; DWORD len = url.dwHostNameLength + 1 + 5 + 1; WCHAR buf[len]; @@ -406,7 +406,7 @@ static HRESULT WINAPI HTMLLocation_get_port(IHTMLLocation *iface, BSTR *p) return hres; if(url.nPort) { - const WCHAR format[] = {'%','d',0}; + const WCHAR format[] = {'%','u',0}; WCHAR buf[6]; snprintfW(buf, 6, format, url.nPort); *p = SysAllocString(buf);

1 0

André Hentschel : winhttp: Port numbers are unsigned ( more).
by Alexandre Julliard 29 Mar '11

29 Mar '11

Module: wine Branch: master Commit: 1c7d45c093b2981a9c31061fe00ee7aef1314fbd URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c7d45c093b2981a9c31061fe… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Mar 28 21:40:43 2011 +0200 winhttp: Port numbers are unsigned (more). --- dlls/winhttp/url.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winhttp/url.c b/dlls/winhttp/url.c index 09835b4..6ead33c 100644 --- a/dlls/winhttp/url.c +++ b/dlls/winhttp/url.c @@ -299,7 +299,7 @@ static DWORD comp_length( DWORD len, DWORD flags, WCHAR *comp ) static BOOL calc_length( URL_COMPONENTS *uc, DWORD flags, LPDWORD len ) { - static const WCHAR formatW[] = {'%','d',0}; + static const WCHAR formatW[] = {'%','u',0}; INTERNET_SCHEME scheme; *len = 0; @@ -360,7 +360,7 @@ static BOOL calc_length( URL_COMPONENTS *uc, DWORD flags, LPDWORD len ) */ BOOL WINAPI WinHttpCreateUrl( LPURL_COMPONENTS uc, DWORD flags, LPWSTR url, LPDWORD required ) { - static const WCHAR formatW[] = {'%','d',0}; + static const WCHAR formatW[] = {'%','u',0}; static const WCHAR twoslashW[] = {'/','/'}; DWORD len;

1 0