March 2011 - Wine-commits - list.winehq.org

Marcus Meissner : kernel32: Added missing break (Coverity).
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: 7cd22f7037514187a97ff18a1a7147c1745d26c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7cd22f7037514187a97ff18a1… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Mar 18 23:21:35 2011 +0100 kernel32: Added missing break (Coverity). --- dlls/kernel32/computername.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/computername.c b/dlls/kernel32/computername.c index dabaae8..8650440 100644 --- a/dlls/kernel32/computername.c +++ b/dlls/kernel32/computername.c @@ -131,8 +131,10 @@ static BOOL dns_fqdn ( char *name, int *size ) { case ENAMETOOLONG: SetLastError ( ERROR_MORE_DATA ); + break; default: SetLastError ( ERROR_INVALID_PARAMETER ); + break; } return FALSE; }

1 0

Marcus Meissner : comctl32: Added missing break (Coverity).
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: e766a132dba7ee8fd20c6b603c01208dc16a8520 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e766a132dba7ee8fd20c6b603… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Mar 18 23:27:04 2011 +0100 comctl32: Added missing break (Coverity). --- dlls/comctl32/tests/treeview.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c index 653807f..71df978 100644 --- a/dlls/comctl32/tests/treeview.c +++ b/dlls/comctl32/tests/treeview.c @@ -999,6 +999,7 @@ static LRESULT CALLBACK parent_wnd_proc(HWND hWnd, UINT message, WPARAM wParam, } } } + break; } case WM_DESTROY:

1 0

Stefan Leichter : ntoskrnl.exe: Add stub for PsSetLoadImageNotifyRoutine.
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: c643aec1759c82ab3c187ff1fe518e2dda1dc8bc URL: http://source.winehq.org/git/wine.git/?a=commit;h=c643aec1759c82ab3c187ff1f… Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Sat Mar 19 10:26:58 2011 +0100 ntoskrnl.exe: Add stub for PsSetLoadImageNotifyRoutine. --- dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- include/ddk/ntddk.h | 22 ++++++++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index a697751..6fc0fb2 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1596,6 +1596,15 @@ NTSTATUS WINAPI IoWMIRegistrationControl(PDEVICE_OBJECT DeviceObject, ULONG Acti } /***************************************************** + * PsSetLoadImageNotifyRoutine (NTOSKRNL.EXE.@) + */ +NTSTATUS WINAPI PsSetLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE routine) +{ + FIXME("(%p) stub\n", routine); + return STATUS_SUCCESS; +} + +/***************************************************** * DllMain */ BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index ed0059e..7e4918f 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -911,7 +911,7 @@ @ stdcall PsSetCreateThreadNotifyRoutine(ptr) @ stub PsSetJobUIRestrictionsClass @ stub PsSetLegoNotifyRoutine -@ stub PsSetLoadImageNotifyRoutine +@ stdcall PsSetLoadImageNotifyRoutine(ptr) @ stub PsSetProcessPriorityByClass @ stub PsSetProcessPriorityClass @ stub PsSetProcessSecurityPort diff --git a/include/ddk/ntddk.h b/include/ddk/ntddk.h index 1ea8d05..df58951 100644 --- a/include/ddk/ntddk.h +++ b/include/ddk/ntddk.h @@ -107,7 +107,28 @@ typedef enum _CONFIGURATION_TYPE MaximunType } CONFIGURATION_TYPE, *PCONFIGURATION_TYPE; +typedef struct _IMAGE_INFO +{ + union + { + ULONG Properties; + struct + { + ULONG ImageAddressingMode : 8; + ULONG SystemModeImage : 1; + ULONG ImageMappedToAllPids : 1; + ULONG ExtendedInfoPresent : 1; + ULONG Reserved : 21; + }; + }; + PVOID ImageBase; + ULONG ImageSelector; + SIZE_T ImageSize; + ULONG ImageSectionNumber; +} IMAGE_INFO, *PIMAGE_INFO; + typedef VOID (WINAPI *PDRIVER_REINITIALIZE)(PDRIVER_OBJECT,PVOID,ULONG); +typedef VOID (WINAPI *PLOAD_IMAGE_NOTIFY_ROUTINE)(PUNICODE_STRING,HANDLE,PIMAGE_INFO); typedef NTSTATUS (WINAPI *PIO_QUERY_DEVICE_ROUTINE)(PVOID,PUNICODE_STRING,INTERFACE_TYPE,ULONG, PKEY_VALUE_FULL_INFORMATION*,CONFIGURATION_TYPE,ULONG,PKEY_VALUE_FULL_INFORMATION*); @@ -115,5 +136,6 @@ NTSTATUS WINAPI IoQueryDeviceDescription(PINTERFACE_TYPE,PULONG,PCONFIGURATION_ PCONFIGURATION_TYPE,PULONG,PIO_QUERY_DEVICE_ROUTINE,PVOID); void WINAPI IoRegisterDriverReinitialization(PDRIVER_OBJECT,PDRIVER_REINITIALIZE,PVOID); NTSTATUS WINAPI IoRegisterShutdownNotification(PDEVICE_OBJECT); +NTSTATUS WINAPI PsSetLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE); #endif

1 0

Austin English : traffic: Add a stub for TcDeregisterClient.
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: 570f446f8c19a9b56b7d26773390d7b426852c9b URL: http://source.winehq.org/git/wine.git/?a=commit;h=570f446f8c19a9b56b7d26773… Author: Austin English <austinenglish(a)gmail.com> Date: Sat Mar 19 16:59:47 2011 -0500 traffic: Add a stub for TcDeregisterClient. --- dlls/traffic/traffic.spec | 2 +- dlls/traffic/traffic_main.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/dlls/traffic/traffic.spec b/dlls/traffic/traffic.spec index 4638af3..ad4bce0 100644 --- a/dlls/traffic/traffic.spec +++ b/dlls/traffic/traffic.spec @@ -4,7 +4,7 @@ @ stub TcCloseInterface @ stub TcDeleteFilter @ stub TcDeleteFlow -@ stub TcDeregisterClient +@ stdcall TcDeregisterClient(ptr) @ stub TcEnumerateFlows @ stub TcEnumerateInterfaces @ stub TcGetFlowNameA diff --git a/dlls/traffic/traffic_main.c b/dlls/traffic/traffic_main.c index 6efea89..6b8a975 100644 --- a/dlls/traffic/traffic_main.c +++ b/dlls/traffic/traffic_main.c @@ -54,3 +54,12 @@ ULONG WINAPI TcRegisterClient(ULONG version, HANDLE context, if(buffer) *buffer = INVALID_HANDLE_VALUE; return ERROR_CALL_NOT_IMPLEMENTED; } + +/***************************************************************************** + * TcDeregisterClient [TRAFFIC.@] + */ +ULONG WINAPI TcDeregisterClient(HANDLE ClientHandle) +{ + FIXME("%p: stub\n", ClientHandle); + return ERROR_CALL_NOT_IMPLEMENTED; +}

1 0

Michael Stefaniuc : oleaut32/tests: Use a proper static COM object.
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: 289005a79f17abdd1c483de53505a829aee6e665 URL: http://source.winehq.org/git/wine.git/?a=commit;h=289005a79f17abdd1c483de53… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Mar 24 13:55:03 2011 +0100 oleaut32/tests: Use a proper static COM object. --- dlls/oleaut32/tests/safearray.c | 58 +++++++++++++++++++------------------- 1 files changed, 29 insertions(+), 29 deletions(-) diff --git a/dlls/oleaut32/tests/safearray.c b/dlls/oleaut32/tests/safearray.c index 0c2b882..411b4bc 100644 --- a/dlls/oleaut32/tests/safearray.c +++ b/dlls/oleaut32/tests/safearray.c @@ -1130,16 +1130,27 @@ static void test_SafeArrayGetPutElement_BSTR(void) SysFreeString(gotvalue); } -static int tunk_xref = 0; -static HRESULT WINAPI tunk_QueryInterface(LPUNKNOWN punk,REFIID riid, LPVOID *x) { - return E_FAIL; +struct xtunk_impl { + IUnknown IUnknown_iface; + LONG ref; +}; +static const IUnknownVtbl xtunk_vtbl; + +static struct xtunk_impl xtunk = {{&xtunk_vtbl}, 0}; + +static HRESULT WINAPI tunk_QueryInterface(IUnknown *punk, REFIID riid, void **x) +{ + return E_FAIL; } -static ULONG WINAPI tunk_AddRef(LPUNKNOWN punk) { - return ++tunk_xref; + +static ULONG WINAPI tunk_AddRef(IUnknown *punk) +{ + return ++xtunk.ref; } -static ULONG WINAPI tunk_Release(LPUNKNOWN punk) { - return --tunk_xref; +static ULONG WINAPI tunk_Release(IUnknown *punk) +{ + return --xtunk.ref; } static const IUnknownVtbl xtunk_vtbl = { @@ -1148,18 +1159,13 @@ static const IUnknownVtbl xtunk_vtbl = { tunk_Release }; -static struct xtunk_iface { - const IUnknownVtbl *lpvtbl; -} xtunk_iface; - - static void test_SafeArrayGetPutElement_IUnknown(void) { SAFEARRAYBOUND sab; LONG indices[1]; SAFEARRAY *sa; HRESULT hres; - LPUNKNOWN value = 0, gotvalue; + IUnknown *gotvalue; sab.lLbound = 1; sab.cElements = 1; @@ -1173,22 +1179,19 @@ static void test_SafeArrayGetPutElement_IUnknown(void) return; indices[0] = sab.lLbound; - xtunk_iface.lpvtbl = &xtunk_vtbl; - value = (LPUNKNOWN)&xtunk_iface; - tunk_xref = 1; - ok (value != NULL, "Expected non-NULL\n"); - hres = SafeArrayPutElement(sa, indices, value); + xtunk.ref = 1; + hres = SafeArrayPutElement(sa, indices, &xtunk.IUnknown_iface); ok(hres == S_OK, "Failed to put bstr element hres 0x%x\n", hres); - ok(tunk_xref == 2,"Failed to increment refcount of iface.\n"); + ok(xtunk.ref == 2,"Failed to increment refcount of iface.\n"); gotvalue = NULL; hres = SafeArrayGetElement(sa, indices, &gotvalue); - ok(tunk_xref == 3,"Failed to increment refcount of iface.\n"); + ok(xtunk.ref == 3,"Failed to increment refcount of iface.\n"); ok(hres == S_OK, "Failed to get bstr element at hres 0x%x\n", hres); if (hres == S_OK) - ok(value == gotvalue, "Got %p instead of %p\n", gotvalue, value); + ok(gotvalue == &xtunk.IUnknown_iface, "Got %p instead of %p\n", gotvalue, &xtunk.IUnknown_iface); hres = SafeArrayDestroy(sa); ok(hres == S_OK, "got 0x%08x\n", hres); - ok(tunk_xref == 2,"Failed to decrement refcount of iface.\n"); + ok(xtunk.ref == 2,"Failed to decrement refcount of iface.\n"); } static void test_SafeArrayRedim_IUnknown(void) @@ -1197,7 +1200,6 @@ static void test_SafeArrayRedim_IUnknown(void) LONG indices[1]; SAFEARRAY *sa; HRESULT hres; - LPUNKNOWN value; sab.lLbound = 1; sab.cElements = 2; @@ -1211,16 +1213,14 @@ static void test_SafeArrayRedim_IUnknown(void) return; indices[0] = 2; - xtunk_iface.lpvtbl = &xtunk_vtbl; - value = (LPUNKNOWN)&xtunk_iface; - tunk_xref = 1; - hres = SafeArrayPutElement(sa, indices, value); + xtunk.ref = 1; + hres = SafeArrayPutElement(sa, indices, &xtunk.IUnknown_iface); ok(hres == S_OK, "Failed to put IUnknown element hres 0x%x\n", hres); - ok(tunk_xref == 2,"Failed to increment refcount of iface.\n"); + ok(xtunk.ref == 2,"Failed to increment refcount of iface.\n"); sab.cElements = 1; hres = SafeArrayRedim(sa, &sab); ok(hres == S_OK, "Failed to shrink array hres 0x%x\n", hres); - ok(tunk_xref == 1, "Failed to decrement refcount\n"); + ok(xtunk.ref == 1, "Failed to decrement refcount\n"); hres = SafeArrayDestroy(sa); ok(hres == S_OK, "got 0x%08x\n", hres); }

1 0

Aric Stewart : usp10: Rewrite ScriptStringCPtoX to make use of ScriptCPtoX.
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: d7ea24d56d692c94179d6796020306be1423dc17 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7ea24d56d692c94179d67960… Author: Aric Stewart <aric(a)codeweavers.com> Date: Fri Mar 18 12:22:31 2011 -0500 usp10: Rewrite ScriptStringCPtoX to make use of ScriptCPtoX. --- dlls/usp10/usp10.c | 50 ++++++++++++++++++++++++++++++-------------------- 1 files changed, 30 insertions(+), 20 deletions(-) diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index 9f1300d..89b7856 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -202,6 +202,7 @@ typedef struct { SCRIPT_VISATTR* psva; GOFFSET* pGoffset; ABC* abc; + int iMaxPosX; } StringGlyphs; typedef struct { @@ -824,6 +825,7 @@ HRESULT WINAPI ScriptStringAnalyse(HDC hdc, const void *pString, int cString, analysis->glyphs[i].psva = psva; analysis->glyphs[i].pGoffset = pGoffset; analysis->glyphs[i].abc = abc; + analysis->glyphs[i].iMaxPosX= -1; } *pssa = analysis; @@ -932,11 +934,9 @@ HRESULT WINAPI ScriptStringOut(SCRIPT_STRING_ANALYSIS ssa, */ HRESULT WINAPI ScriptStringCPtoX(SCRIPT_STRING_ANALYSIS ssa, int icp, BOOL fTrailing, int* pX) { - int i, j; + int i; int runningX = 0; - int runningCp = 0; StringAnalysis* analysis = ssa; - BOOL itemTrailing; TRACE("(%p), %d, %d, (%p)\n", ssa, icp, fTrailing, pX); @@ -951,25 +951,35 @@ HRESULT WINAPI ScriptStringCPtoX(SCRIPT_STRING_ANALYSIS ssa, int icp, BOOL fTrai for(i=0; i<analysis->numItems; i++) { - if (analysis->pItem[i].a.fRTL) - itemTrailing = !fTrailing; - else - itemTrailing = fTrailing; - for(j=0; j<analysis->glyphs[i].numGlyphs; j++) + int CP = analysis->pItem[i+1].iCharPos - analysis->pItem[i].iCharPos; + int offset; + /* initialize max extents for uninitialized runs */ + if (analysis->glyphs[i].iMaxPosX == -1) { - if(runningCp == icp && itemTrailing == FALSE) - { - *pX = runningX; - return S_OK; - } - runningX += analysis->glyphs[i].piAdvance[j]; - if(runningCp == icp && itemTrailing == TRUE) - { - *pX = runningX; - return S_OK; - } - runningCp++; + if (analysis->pItem[i].a.fRTL) + ScriptCPtoX(0, FALSE, CP, analysis->glyphs[i].numGlyphs, analysis->glyphs[i].pwLogClust, + analysis->glyphs[i].psva, analysis->glyphs[i].piAdvance, + &analysis->pItem[i].a, &analysis->glyphs[i].iMaxPosX); + else + ScriptCPtoX(CP, TRUE, CP, analysis->glyphs[i].numGlyphs, analysis->glyphs[i].pwLogClust, + analysis->glyphs[i].psva, analysis->glyphs[i].piAdvance, + &analysis->pItem[i].a, &analysis->glyphs[i].iMaxPosX); + } + + if (icp >= CP) + { + runningX += analysis->glyphs[i].iMaxPosX; + icp -= CP; + continue; } + + ScriptCPtoX(icp, fTrailing, CP, analysis->glyphs[i].numGlyphs, analysis->glyphs[i].pwLogClust, + analysis->glyphs[i].psva, analysis->glyphs[i].piAdvance, + &analysis->pItem[i].a, &offset); + runningX += offset; + + *pX = runningX; + return S_OK; } /* icp out of range */

1 0

Aric Stewart : usp10: Rewrite ScriptStringXtoCP to make use of ScriptXtoCP.
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: f026616c2295ec05d35c9ae245b6b8fcc9a3e3ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=f026616c2295ec05d35c9ae24… Author: Aric Stewart <aric(a)codeweavers.com> Date: Fri Mar 18 12:22:42 2011 -0500 usp10: Rewrite ScriptStringXtoCP to make use of ScriptXtoCP. --- dlls/usp10/usp10.c | 46 ++++++++++++++++++++++++++-------------------- 1 files changed, 26 insertions(+), 20 deletions(-) diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index 89b7856..e177f33 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -991,14 +991,11 @@ HRESULT WINAPI ScriptStringCPtoX(SCRIPT_STRING_ANALYSIS ssa, int icp, BOOL fTrai * ScriptStringXtoCP (USP10.@) * */ -HRESULT WINAPI ScriptStringXtoCP(SCRIPT_STRING_ANALYSIS ssa, int iX, int* piCh, int* piTrailing) +HRESULT WINAPI ScriptStringXtoCP(SCRIPT_STRING_ANALYSIS ssa, int iX, int* piCh, int* piTrailing) { StringAnalysis* analysis = ssa; int i; - int j; - int runningX = 0; int runningCp = 0; - int width; TRACE("(%p), %d, (%p), (%p)\n", ssa, iX, piCh, piTrailing); @@ -1022,24 +1019,33 @@ HRESULT WINAPI ScriptStringXtoCP(SCRIPT_STRING_ANALYSIS ssa, int iX, int* piCh, for(i=0; i<analysis->numItems; i++) { - for(j=0; j<analysis->glyphs[i].numGlyphs; j++) + int CP = analysis->pItem[i+1].iCharPos - analysis->pItem[i].iCharPos; + /* initialize max extents for uninitialized runs */ + if (analysis->glyphs[i].iMaxPosX == -1) { - width = analysis->glyphs[i].piAdvance[j]; - if(iX < (runningX + width)) - { - *piCh = runningCp; - if((iX - runningX) > width/2) - *piTrailing = TRUE; - else - *piTrailing = FALSE; - - if (analysis->pItem[i].a.fRTL) - *piTrailing = !*piTrailing; - return S_OK; - } - runningX += width; - runningCp++; + if (analysis->pItem[i].a.fRTL) + ScriptCPtoX(0, FALSE, CP, analysis->glyphs[i].numGlyphs, analysis->glyphs[i].pwLogClust, + analysis->glyphs[i].psva, analysis->glyphs[i].piAdvance, + &analysis->pItem[i].a, &analysis->glyphs[i].iMaxPosX); + else + ScriptCPtoX(CP, TRUE, CP, analysis->glyphs[i].numGlyphs, analysis->glyphs[i].pwLogClust, + analysis->glyphs[i].psva, analysis->glyphs[i].piAdvance, + &analysis->pItem[i].a, &analysis->glyphs[i].iMaxPosX); } + + if (iX > analysis->glyphs[i].iMaxPosX) + { + iX -= analysis->glyphs[i].iMaxPosX; + runningCp += CP; + continue; + } + + ScriptXtoCP(iX, CP, analysis->glyphs[i].numGlyphs, analysis->glyphs[i].pwLogClust, + analysis->glyphs[i].psva, analysis->glyphs[i].piAdvance, + &analysis->pItem[i].a, piCh, piTrailing); + *piCh += runningCp; + + return S_OK; } /* out of range */

1 0

Marcus Meissner : winedbg: Add missing break (Coverity).
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: d15a04bdce9cc22e200c03cfebf81482720fc0e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d15a04bdce9cc22e200c03cfe… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Mar 18 22:05:22 2011 +0100 winedbg: Add missing break (Coverity). --- programs/winedbg/be_i386.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/programs/winedbg/be_i386.c b/programs/winedbg/be_i386.c index 6f07e06..a602c7e 100644 --- a/programs/winedbg/be_i386.c +++ b/programs/winedbg/be_i386.c @@ -387,6 +387,7 @@ static BOOL fetch_value(const char* addr, unsigned sz, int* value) if (!dbg_read_memory(addr, &value16, sizeof(value16))) return FALSE; *value = value16; + break; case 32: if (!dbg_read_memory(addr, value, sizeof(*value))) return FALSE;

1 0

Marcus Meissner : winecfg: Added missing break (Coverity).
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: fd2fe2be0d6e6ec9387caae3837355e5024e6837 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd2fe2be0d6e6ec9387caae38… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Mar 18 22:07:45 2011 +0100 winecfg: Added missing break (Coverity). --- programs/winecfg/drivedetect.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/winecfg/drivedetect.c b/programs/winecfg/drivedetect.c index b20b97c..c7e2f78 100644 --- a/programs/winecfg/drivedetect.c +++ b/programs/winecfg/drivedetect.c @@ -207,7 +207,7 @@ static void report_error(int code) MessageBox(NULL, "No virtual drive C mapped!\n", "", MB_OK | MB_ICONEXCLAMATION); else fprintf(stderr, "winecfg: no drive_c directory\n"); - + break; case NO_HOME: if (gui_mode) MessageBox(NULL, "Could not ensure that your home directory was mapped.\n\n"

1 0

Marcus Meissner : wininet: Added missing break (Coverity).
by Alexandre Julliard 28 Mar '11

28 Mar '11

Module: wine Branch: master Commit: 6e1f37151c019417426c10031f7a71796c493e4c URL: http://source.winehq.org/git/wine.git/?a=commit;h=6e1f37151c019417426c10031… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Mar 18 22:14:58 2011 +0100 wininet: Added missing break (Coverity). --- dlls/wininet/internet.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index 84d1770..a0db965 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -2839,6 +2839,7 @@ BOOL WINAPI InternetSetOptionA(HINTERNET hInternet, DWORD dwOption, break; case INTERNET_PER_CONN_AUTOCONFIG_LAST_DETECT_TIME: optW->Value.ftValue = optA->Value.ftValue; + break; default: WARN("Unknown PER_CONN dwOption: %d, guessing at conversion to Wide\n", optA->dwOption); optW->Value.dwValue = optA->Value.dwValue;

1 0