March 2011 - Wine-commits - list.winehq.org

Francois Gouget : comctl32/tests: Add a '\n' to a pair of ok() calls.
by Alexandre Julliard 07 Mar '11

07 Mar '11

Module: wine Branch: master Commit: 755648421e8b6c1cff52317865aaa5653281d409 URL: http://source.winehq.org/git/wine.git/?a=commit;h=755648421e8b6c1cff5231786… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Mar 5 11:50:23 2011 +0100 comctl32/tests: Add a '\n' to a pair of ok() calls. --- dlls/comctl32/tests/comboex.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/tests/comboex.c b/dlls/comctl32/tests/comboex.c index ca30482..59c261c 100644 --- a/dlls/comctl32/tests/comboex.c +++ b/dlls/comctl32/tests/comboex.c @@ -405,7 +405,7 @@ static void test_WM_WINDOWPOSCHANGING(void) wp.hwndInsertAfter = NULL; ret = SendMessageA(hCombo, WM_WINDOWPOSCHANGING, 0, (LPARAM)&wp); - ok(ret == 0, "expected 0, got %x", ret); + ok(ret == 0, "expected 0, got %x\n", ret); ok(wp.cy == combo_height, "Expected height %d, got %d\n", combo_height, wp.cy); @@ -419,7 +419,7 @@ static void test_WM_WINDOWPOSCHANGING(void) wp.hwndInsertAfter = NULL; ret = SendMessageA(hCombo, WM_WINDOWPOSCHANGING, 0, (LPARAM)&wp); - ok(ret == 0, "expected 0, got %x", ret); + ok(ret == 0, "expected 0, got %x\n", ret); ok(wp.cy == combo_height, "Expected height %d, got %d\n", combo_height, wp.cy);

1 0

Frédéric Delanoy : French translation for release 1.3.15
by Jeremy Newman 04 Mar '11

04 Mar '11

Module: website Branch: master Commit: 141253564fb438290fd66135f8d20ece60143140 URL: http://source.winehq.org/git/website.git/?a=commit;h=141253564fb438290fd661… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Mar 4 21:00:01 2011 +0100 French translation for release 1.3.15 --- news/fr/2011030401.xml | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/news/fr/2011030401.xml b/news/fr/2011030401.xml new file mode 100644 index 0000000..2a2410a --- /dev/null +++ b/news/fr/2011030401.xml @@ -0,0 +1,19 @@ +<news> +<date>4 mars 2011</date> +<title>Sortie de Wine 1.3.15</title> +<body> + La version de développement 1.3.15 de Wine est disponible. + <a href="{$root}/announce/1.3.15">Nouveautés</a> de cette version : +<ul> + <li>Possibilité de modifier les mots de passe réseau.</li> + <li>Prise en charge de la réflexion dans le compilateur de shaders.</li> + <li>Les tests n'essaient plus s'accommoder du comportement Win9x.</li> + <li>Plusieurs améliorations MSHTML et MSXML.</li> + <li>Diverses corrections de bogues.</li> +</ul> +Le <a +href="http://prdownloads.sourceforge.net/wine/wine-1.3.15.tar.bz2">code +source</a> est disponible dès à présent. +Les paquets binaires sont en cours de construction, et apparaîtront sous peu +sur leurs <a href="{$root}/download">sites de téléchargement</a> respectifs. +</body></news>

1 0

Alexandre Julliard : Wine release 1.3.15
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: website Branch: master Commit: da7a3d4eeabb92d2459e93431f139d9f2f05ac39 URL: http://source.winehq.org/git/website.git/?a=commit;h=da7a3d4eeabb92d2459e93… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 4 19:33:12 2011 +0100 Wine release 1.3.15 --- news/en/2011030401.xml | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/news/en/2011030401.xml b/news/en/2011030401.xml new file mode 100644 index 0000000..28af1b9 --- /dev/null +++ b/news/en/2011030401.xml @@ -0,0 +1,16 @@ +<news> +<date>March 4, 2011</date> +<title>Wine 1.3.15 Released</title> +<body> + The Wine development release 1.3.15 is now available. + <a href="{$root}/announce/1.3.15">What's new</a> in this release: +<ul> + <li>Support for changing network passwords.</li> + <li>Reflection support in shader compiler.</li> + <li>Tests no longer attempt to cope with Win9x behavior.</li> + <li>A number of MSHTML and MSXML improvements.</li> + <li>Various bug fixes.</li> +</ul> +The source is <a href="http://prdownloads.sourceforge.net/wine/wine-1.3.15.tar.bz2">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0

Alexandre Julliard : Release 1.3.15.
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: master Commit: e44875b42d8f72c6a0d49f05655489a5b8fb673a URL: http://source.winehq.org/git/wine.git/?a=commit;h=e44875b42d8f72c6a0d49f056… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 4 19:25:23 2011 +0100 Release 1.3.15. --- ANNOUNCE | 875 ++++++++++++++++++++++++++++++------------------------------- VERSION | 2 +- configure | 18 +- 3 files changed, 446 insertions(+), 449 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e44875b42d8f72c6a0d49…

1 0

Tag wine-1.3.15 : Alexandre Julliard : Release 1.3.15
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: refs/tags/wine-1.3.15 Tag: feb6748c29a0c7cb5752af5461389f17d4c096cc URL: http://source.winehq.org/git/wine.git/?a=tag;h=feb6748c29a0c7cb5752af546138… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 4 19:25:23 2011 +0100 Release 1.3.15

1 0

Marcus Meissner : msvcrt: Move side effect out of assert (Coverity).
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: master Commit: ecb89ba89e63fcbb56e81d1cf7dbb371bdab1a51 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ecb89ba89e63fcbb56e81d1cf… Author: Marcus Meissner <meissner(a)suse.de> Date: Fri Mar 4 14:06:50 2011 +0100 msvcrt: Move side effect out of assert (Coverity). --- dlls/msvcrt/undname.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c index 670873d..920a763 100644 --- a/dlls/msvcrt/undname.c +++ b/dlls/msvcrt/undname.c @@ -1184,7 +1184,8 @@ static BOOL handle_template(struct parsed_symbol* sym) const char* name; const char* args; - assert(*sym->current++ == '$'); + assert(*sym->current == '$'); + sym->current++; if (!(name = get_literal_string(sym))) return FALSE; if (!(args = get_args(sym, NULL, FALSE, '<', '>'))) return FALSE; sym->result = str_printf(sym, "%s%s", name, args);

1 0

Nikolay Sivov : msxml3: Remove child with parent method first before insert with insertBefore().
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: master Commit: 179daa20b99db2173607566c250ec511a6bd280a URL: http://source.winehq.org/git/wine.git/?a=commit;h=179daa20b99db2173607566c2… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Mar 4 01:03:15 2011 +0300 msxml3: Remove child with parent method first before insert with insertBefore(). --- dlls/msxml3/domdoc.c | 5 +--- dlls/msxml3/element.c | 6 +---- dlls/msxml3/node.c | 56 +++++++++++++++++++------------------------ dlls/msxml3/nodemap.c | 5 +--- dlls/msxml3/tests/domdoc.c | 53 +++++++++++++++++++++++++++++++++++++++-- 5 files changed, 78 insertions(+), 47 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=179daa20b99db21736075…

1 0

Nikolay Sivov : msxml3: Test to show namespace definition output for children.
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: master Commit: 14ec98bd1405a5182341c1652c4dea246e662b8c URL: http://source.winehq.org/git/wine.git/?a=commit;h=14ec98bd1405a5182341c1652… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Mar 4 02:04:22 2011 +0300 msxml3: Test to show namespace definition output for children. --- dlls/msxml3/tests/domdoc.c | 88 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 88 insertions(+), 0 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index f84947c..439207f 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -7984,6 +7984,7 @@ static void test_insertBefore(void) IXMLDOMNode *node, *newnode; HRESULT hr; VARIANT v; + BSTR p; doc = create_document(&IID_IXMLDOMDocument); @@ -8161,6 +8162,93 @@ static void test_insertBefore(void) IXMLDOMElement_Release(elem3); IXMLDOMElement_Release(elem4); IXMLDOMElement_Release(elem5); + + /* elements with same default namespace */ + V_VT(&v) = VT_I4; + V_I4(&v) = NODE_ELEMENT; + elem1 = NULL; + hr = IXMLDOMDocument_createNode(doc, v, _bstr_("elem1"), _bstr_("http://winehq.org/default"), (IXMLDOMNode**)&elem1); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(elem1 != NULL, "got %p\n", elem1); + + V_VT(&v) = VT_I4; + V_I4(&v) = NODE_ELEMENT; + elem2 = NULL; + hr = IXMLDOMDocument_createNode(doc, v, _bstr_("elem2"), _bstr_("http://winehq.org/default"), (IXMLDOMNode**)&elem2); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(elem2 != NULL, "got %p\n", elem2); + + /* check contents so far */ + p = NULL; + hr = IXMLDOMElement_get_xml(elem1, &p); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(!lstrcmpW(p, _bstr_("<elem1 xmlns=\"http://winehq.org/default\"/>")), "got %s\n", wine_dbgstr_w(p)); + SysFreeString(p); + + p = NULL; + hr = IXMLDOMElement_get_xml(elem2, &p); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(!lstrcmpW(p, _bstr_("<elem2 xmlns=\"http://winehq.org/default\"/>")), "got %s\n", wine_dbgstr_w(p)); + SysFreeString(p); + + V_VT(&v) = VT_NULL; + hr = IXMLDOMElement_insertBefore(elem1, (IXMLDOMNode*)elem2, v, NULL); + ok(hr == S_OK, "got 0x%08x\n", hr); + + /* get_xml depends on context, for top node it omits child namespace attribute, + but at child level it's still returned */ + p = NULL; + hr = IXMLDOMElement_get_xml(elem1, &p); + ok(hr == S_OK, "got 0x%08x\n", hr); + todo_wine ok(!lstrcmpW(p, _bstr_("<elem1 xmlns=\"http://winehq.org/default\"><elem2/></elem1>")), + "got %s\n", wine_dbgstr_w(p)); + SysFreeString(p); + + p = NULL; + hr = IXMLDOMElement_get_xml(elem2, &p); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(!lstrcmpW(p, _bstr_("<elem2 xmlns=\"http://winehq.org/default\"/>")), "got %s\n", wine_dbgstr_w(p)); + SysFreeString(p); + + IXMLDOMElement_Release(elem1); + IXMLDOMElement_Release(elem2); + + /* child without default namespace added to node with default namespace */ + V_VT(&v) = VT_I4; + V_I4(&v) = NODE_ELEMENT; + elem1 = NULL; + hr = IXMLDOMDocument_createNode(doc, v, _bstr_("elem1"), _bstr_("http://winehq.org/default"), (IXMLDOMNode**)&elem1); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(elem1 != NULL, "got %p\n", elem1); + + V_VT(&v) = VT_I4; + V_I4(&v) = NODE_ELEMENT; + elem2 = NULL; + hr = IXMLDOMDocument_createNode(doc, v, _bstr_("elem2"), NULL, (IXMLDOMNode**)&elem2); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(elem2 != NULL, "got %p\n", elem2); + + EXPECT_REF(elem2, 1); + V_VT(&v) = VT_NULL; + hr = IXMLDOMElement_insertBefore(elem1, (IXMLDOMNode*)elem2, v, NULL); + ok(hr == S_OK, "got 0x%08x\n", hr); + EXPECT_REF(elem2, 1); + + p = NULL; + hr = IXMLDOMElement_get_xml(elem2, &p); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(!lstrcmpW(p, _bstr_("<elem2/>")), "got %s\n", wine_dbgstr_w(p)); + SysFreeString(p); + + hr = IXMLDOMElement_removeChild(elem1, (IXMLDOMNode*)elem2, NULL); + ok(hr == S_OK, "got 0x%08x\n", hr); + + p = NULL; + hr = IXMLDOMElement_get_xml(elem2, &p); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(!lstrcmpW(p, _bstr_("<elem2/>")), "got %s\n", wine_dbgstr_w(p)); + SysFreeString(p); + IXMLDOMDocument_Release(doc); free_bstrs(); }

1 0

Dmitry Timoshkov : user32: Add a test to make sure that SendInput sets a non-zero event time.
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: master Commit: 7fb4e2ae45cff5ce72260c60587c6473e8bbfdf2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7fb4e2ae45cff5ce72260c605… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Mar 4 14:43:31 2011 +0800 user32: Add a test to make sure that SendInput sets a non-zero event time. --- dlls/user32/tests/input.c | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index 22120f0..d45edf1 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -369,6 +369,16 @@ static void test_Input_whitebox(void) DestroyWindow(hWndTest); } +static inline BOOL is_keyboard_message( UINT message ) +{ + return (message >= WM_KEYFIRST && message <= WM_KEYLAST); +} + +static inline BOOL is_mouse_message( UINT message ) +{ + return (message >= WM_MOUSEFIRST && message <= WM_MOUSELAST); +} + /* try to make sure pending X events have been processed before continuing */ static void empty_message_queue(void) { @@ -382,6 +392,9 @@ static void empty_message_queue(void) if (MsgWaitForMultipleObjects(0, NULL, FALSE, min_timeout, QS_ALLINPUT) == WAIT_TIMEOUT) break; while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) { + if (is_keyboard_message(msg.message) || is_mouse_message(msg.message)) + ok(msg.time != 0, "message %#x has time set to 0\n", msg.message); + TranslateMessage(&msg); DispatchMessage(&msg); }

1 0

Marcus Meissner : oleaut32: Local variable goes out of scope via pointer ( Coverity).
by Alexandre Julliard 04 Mar '11

04 Mar '11

Module: wine Branch: master Commit: d9908d2abd12f0f28b2614e23d28d15e1f446b97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d9908d2abd12f0f28b2614e23… Author: Marcus Meissner <meissner(a)suse.de> Date: Fri Mar 4 10:43:42 2011 +0100 oleaut32: Local variable goes out of scope via pointer (Coverity). --- dlls/oleaut32/olefont.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/oleaut32/olefont.c b/dlls/oleaut32/olefont.c index f86ef20..e65504c 100644 --- a/dlls/oleaut32/olefont.c +++ b/dlls/oleaut32/olefont.c @@ -338,6 +338,7 @@ HRESULT WINAPI OleCreateFontIndirect( { OLEFontImpl* newFont = 0; HRESULT hr = S_OK; + FONTDESC fd; TRACE("(%p, %s, %p)\n", lpFontDesc, debugstr_guid(riid), ppvObj); /* @@ -349,8 +350,6 @@ HRESULT WINAPI OleCreateFontIndirect( *ppvObj = 0; if (!lpFontDesc) { - FONTDESC fd; - static WCHAR fname[] = { 'S','y','s','t','e','m',0 }; fd.cbSizeofstruct = sizeof(fd);

1 0