April 2011 - Wine-commits - list.winehq.org

Dmitry Timoshkov : winex11.drv: Associate the real DC transformation with cached font data.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: d25f3221c26a18fa718e2ef1b4dd69f3fdc0274a URL: http://source.winehq.org/git/wine.git/?a=commit;h=d25f3221c26a18fa718e2ef1b… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Mon Jan 24 18:40:13 2011 +0800 winex11.drv: Associate the real DC transformation with cached font data. This matches what WineEngCreateFontInstance() does, and makes applications which set custom axes directions using different window/viewport extents display text correctly. (cherry picked from commit 3e850b5b1439032f0e396a91169442da8e4786c9) --- dlls/winex11.drv/xrender.c | 6 +++++- include/wingdi.h | 1 + 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index f0ec1b1..fde0b91 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -1066,7 +1066,11 @@ BOOL X11DRV_XRender_SelectFont(X11DRV_PDEVICE *physDev, HFONT hfont) lfsz.lf.lfWidth = abs( lfsz.lf.lfWidth ); lfsz.devsize.cx = X11DRV_XWStoDS( physDev, lfsz.lf.lfWidth ); lfsz.devsize.cy = X11DRV_YWStoDS( physDev, lfsz.lf.lfHeight ); - GetWorldTransform( physDev->hdc, &lfsz.xform ); + + GetTransform( physDev->hdc, 0x204, &lfsz.xform ); + TRACE("font transform %f %f %f %f\n", lfsz.xform.eM11, lfsz.xform.eM12, + lfsz.xform.eM21, lfsz.xform.eM22); + /* Not used fields, would break hashing */ lfsz.xform.eDx = lfsz.xform.eDy = 0; diff --git a/include/wingdi.h b/include/wingdi.h index 53db856..d39bd42 100644 --- a/include/wingdi.h +++ b/include/wingdi.h @@ -3588,6 +3588,7 @@ WINGDIAPI INT WINAPI GetTextFaceW(HDC,INT,LPWSTR); WINGDIAPI BOOL WINAPI GetTextMetricsA(HDC,LPTEXTMETRICA); WINGDIAPI BOOL WINAPI GetTextMetricsW(HDC,LPTEXTMETRICW); #define GetTextMetrics WINELIB_NAME_AW(GetTextMetrics) +WINGDIAPI BOOL WINAPI GetTransform(HDC,DWORD,XFORM*); WINGDIAPI BOOL WINAPI GetViewportExtEx(HDC,LPSIZE); WINGDIAPI BOOL WINAPI GetViewportOrgEx(HDC,LPPOINT); WINGDIAPI BOOL WINAPI GetWindowExtEx(HDC,LPSIZE);

1 0

Henri Verbeet : widl: Support forward type declarations.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: cb32de6c1a01efba1145bab7f9cb8b8d5c43a589 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cb32de6c1a01efba1145bab7f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Jan 27 20:11:13 2011 +0100 widl: Support forward type declarations. (cherry picked from commit 7421bb0b61b708108a6005be541e1b1b293ca2de) --- tools/widl/parser.y | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tools/widl/parser.y b/tools/widl/parser.y index db071a7..39ebd7d 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -381,8 +381,11 @@ statement: typedecl: enumdef + | tENUM aIDENTIFIER { $$ = type_new_enum($2, FALSE, NULL); } | structdef + | tSTRUCT aIDENTIFIER { $$ = type_new_struct($2, FALSE, NULL); } | uniondef + | tUNION aIDENTIFIER { $$ = type_new_nonencapsulated_union($2, FALSE, NULL); } | attributes enumdef { $$ = $2; $$->attrs = check_enum_attrs($1); } | attributes structdef { $$ = $2; $$->attrs = check_struct_attrs($1); } | attributes uniondef { $$ = $2; $$->attrs = check_union_attrs($1); }

1 0

Huw Davies : widl: Initialise [out] only parameters if they are user types or interface pointers.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: 4cfa6a46593863098fa68cf34015dc2ceae78ce0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4cfa6a46593863098fa68cf34… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Feb 2 12:16:29 2011 +0000 widl: Initialise [out] only parameters if they are user types or interface pointers. (cherry picked from commit 5ae2b0f219cb5aed2bdf32746a57a699a32767a2) --- tools/widl/typegen.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 8541c5a..e3ea458 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -4038,12 +4038,15 @@ void assign_stub_out_args( FILE *file, int indent, const var_t *func, const char case TGT_ENUM: case TGT_POINTER: case TGT_RANGE: + case TGT_IFACE_POINTER: print_file(file, indent, "%s_W%u = 0;\n", local_var_prefix, i); break; + case TGT_USER_TYPE: + print_file(file, indent, "memset(&%s_W%u, 0, sizeof(%s_W%u));\n", + local_var_prefix, i, local_var_prefix, i); + break; case TGT_STRUCT: case TGT_UNION: - case TGT_USER_TYPE: - case TGT_IFACE_POINTER: case TGT_ARRAY: case TGT_CTXT_HANDLE: case TGT_CTXT_HANDLE_POINTER:

1 0

Huw Davies : widl: Don't dereference if the referenced type is a user type.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: 2238058eda8c85d5240cc51b6abbd492f6e8fc60 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2238058eda8c85d5240cc51b6… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Feb 3 11:53:30 2011 +0000 widl: Don't dereference if the referenced type is a user type. (cherry picked from commit d8d963a9c3701a6a899f4f1f6fd2f8fe3fca63da) --- tools/widl/typegen.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index e3ea458..c4e51cd 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -1485,8 +1485,12 @@ static unsigned int write_nonsimple_pointer(FILE *file, const attr_list_t *attrs if (out_attr && !in_attr && pointer_type == RPC_FC_RP) flags |= RPC_FC_P_ONSTACK; - if (is_ptr(type) && is_declptr(type_pointer_get_ref(type))) - flags |= RPC_FC_P_DEREF; + if (is_ptr(type)) + { + type_t *ref = type_pointer_get_ref(type); + if(is_declptr(ref) && !is_user_type(ref)) + flags |= RPC_FC_P_DEREF; + } print_file(file, 2, "0x%x, 0x%x,\t\t/* %s", pointer_type,

1 0

Nicholas Niro : winex11.drv: Add proper initialization for border_pixel.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: d8a4de2f303c47de6b0134692af14d861a10bf13 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d8a4de2f303c47de6b0134692… Author: Nicholas Niro <nik_89(a)neuroponic.com> Date: Mon Feb 14 23:28:18 2011 -0500 winex11.drv: Add proper initialization for border_pixel. (cherry picked from commit 7aff865e8e1890929c15bc91a39f4fb11a46d9eb) --- dlls/winex11.drv/opengl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index 3869619..fec5cd9 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -311,6 +311,7 @@ static BOOL X11DRV_WineGL_InitOpenglInfo(void) attr.override_redirect = True; attr.colormap = None; + attr.border_pixel = 0; wine_tsx11_lock(); @@ -337,7 +338,7 @@ static BOOL X11DRV_WineGL_InitOpenglInfo(void) if (vis->visual != DefaultVisual( gdi_display, vis->screen )) attr.colormap = XCreateColormap( gdi_display, root, vis->visual, AllocNone ); if ((win = XCreateWindow( gdi_display, root, -1, -1, 1, 1, 0, vis->depth, InputOutput, - vis->visual, CWOverrideRedirect | CWColormap, &attr ))) + vis->visual, CWBorderPixel | CWOverrideRedirect | CWColormap, &attr ))) XMapWindow( gdi_display, win ); else win = root;

1 0

Ken Thomases : iphlpapi: Enable non-privileged ICMP (ping) on Mac OS X.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: 85f3c4cdf8d149cbf617ebada31de523035abdb3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=85f3c4cdf8d149cbf617ebada… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Feb 11 16:02:02 2011 -0600 iphlpapi: Enable non-privileged ICMP (ping) on Mac OS X. (cherry picked from commit d52f95cec83eb9da252df431fd93c4682ff4ec0c) --- dlls/iphlpapi/icmp.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c index d8ee101..2b76041 100644 --- a/dlls/iphlpapi/icmp.c +++ b/dlls/iphlpapi/icmp.c @@ -153,6 +153,11 @@ HANDLE WINAPI IcmpCreateFile(VOID) icmp_t* icp; int sid=socket(AF_INET,SOCK_RAW,IPPROTO_ICMP); + if (sid < 0) + { + /* Mac OS X supports non-privileged ICMP via SOCK_DGRAM type. */ + sid=socket(AF_INET,SOCK_DGRAM,IPPROTO_ICMP); + } if (sid < 0) { ERR_(winediag)("Failed to use ICMP (network ping), this requires special permissions.\n"); SetLastError(ERROR_ACCESS_DENIED);

1 0

Jörg Höhle : msvcrt: sizeof(long double) is 12 with MS, but not necessarily so on UNIX.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: 0dca7f478f1ca3d4f8dc82b5c0aed3668f740264 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0dca7f478f1ca3d4f8dc82b5c… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Wed Dec 1 22:26:26 2010 +0100 msvcrt: sizeof(long double) is 12 with MS, but not necessarily so on UNIX. (cherry picked from commit c6d67fad8f6d0ac199d0945314564e39aa64644f) --- dlls/msvcrt/msvcrt.h | 2 +- dlls/msvcrt/string.c | 20 +++++++++++++++----- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index f68790b..9064fd0 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -80,7 +80,7 @@ typedef unsigned int (__stdcall *MSVCRT__beginthreadex_start_routine_t)(void *); typedef int (*__cdecl MSVCRT__onexit_t)(void); typedef void (__cdecl *MSVCRT_invalid_parameter_handler)(const MSVCRT_wchar_t*, const MSVCRT_wchar_t*, const MSVCRT_wchar_t*, unsigned, MSVCRT_uintptr_t); -typedef struct {long double x;} MSVCRT__LDOUBLE; +typedef struct {ULONG x80[3];} MSVCRT__LDOUBLE; /* Intel 80 bit FP format has sizeof() 12 */ struct MSVCRT_tm { int tm_sec; diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index 8c99399..7086e12 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -381,8 +381,10 @@ int CDECL MSVCRT__atoldbl(MSVCRT__LDOUBLE *value, const char *str) { /* FIXME needs error checking for huge/small values */ #ifdef HAVE_STRTOLD + long double ld; TRACE("str %s value %p\n",str,value); - value->x = strtold(str,0); + ld = strtold(str,0); + memcpy(value, &ld, 10); #else FIXME("stub, str %s value %p\n",str,value); #endif @@ -395,8 +397,10 @@ int CDECL MSVCRT__atoldbl(MSVCRT__LDOUBLE *value, const char *str) int CDECL __STRINGTOLD( MSVCRT__LDOUBLE *value, char **endptr, const char *str, int flags ) { #ifdef HAVE_STRTOLD + long double ld; FIXME("%p %p %s %x partial stub\n", value, endptr, str, flags ); - value->x = strtold(str,endptr); + ld = strtold(str,0); + memcpy(value, &ld, 10); #else FIXME("%p %p %s %x stub\n", value, endptr, str, flags ); #endif @@ -682,7 +686,7 @@ struct _I10_OUTPUT_DATA { /********************************************************************* * $I10_OUTPUT (MSVCRT.@) - * ld - long double to be printed to data + * ld80 - long double (Intel 80 bit FP in 12 bytes) to be printed to data * prec - precision of part, we're interested in * flag - 0 for first prec digits, 1 for fractional part * data - data to be populated @@ -695,16 +699,22 @@ struct _I10_OUTPUT_DATA { * Native sets last byte of data->str to '0' or '9', I don't know what * it means. Current implementation sets it always to '0'. */ -int CDECL MSVCRT_I10_OUTPUT(MSVCRT__LDOUBLE ld, int prec, int flag, struct _I10_OUTPUT_DATA *data) +int CDECL MSVCRT_I10_OUTPUT(MSVCRT__LDOUBLE ld80, int prec, int flag, struct _I10_OUTPUT_DATA *data) { static const char inf_str[] = "1#INF"; static const char nan_str[] = "1#QNAN"; - double d = ld.x; + /* MS' long double type wants 12 bytes for Intel's 80 bit FP format. + * Some UNIX have sizeof(long double) == 16, yet only 80 bit are used. + * Assume long double uses 80 bit FP, never seen 128 bit FP. */ + long double ld = 0; + double d; char format[8]; char buf[I10_OUTPUT_MAX_PREC+9]; /* 9 = strlen("0.e+0000") + '\0' */ char *p; + memcpy(&ld, &ld80, 10); + d = ld; TRACE("(%lf %d %x %p)\n", d, prec, flag, data); if(d<0) {

1 0

Alexander Law : programs/notepad: Correct sharing mode for opening file in notepad.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: a6e083b9d7ecf302b5cc93cc7f8605a8be093c02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6e083b9d7ecf302b5cc93cc7… Author: Alexander Law <exclusion(a)gmail.com> Date: Fri Jan 28 08:34:23 2011 +0300 programs/notepad: Correct sharing mode for opening file in notepad. (cherry picked from commit a8308dd017541e9dd2ceca3d07a9ba8a566d8b3d) --- programs/notepad/dialog.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/notepad/dialog.c b/programs/notepad/dialog.c index ff5df75..0c4b716 100644 --- a/programs/notepad/dialog.c +++ b/programs/notepad/dialog.c @@ -356,7 +356,7 @@ void DoOpenFile(LPCWSTR szFileName, ENCODING enc) if (!DoCloseFile()) return; - hFile = CreateFileW(szFileName, GENERIC_READ, FILE_SHARE_READ, NULL, + hFile = CreateFileW(szFileName, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); if(hFile == INVALID_HANDLE_VALUE) {

1 0

Andrew Nguyen : server: Filter the WOW64 registry access flags before performing the access check.
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: 34450bf32b3e4b410ee2aa6ea3119f21b5c432a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=34450bf32b3e4b410ee2aa6ea… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Mon Jan 24 07:09:41 2011 -0600 server: Filter the WOW64 registry access flags before performing the access check. (cherry picked from commit ed657182ee3a9f39a1093564eecaeb472423bc92) --- dlls/advapi32/tests/registry.c | 173 ++++++++++++++++++++++++++++++++++++++++ server/registry.c | 4 +- 2 files changed, 176 insertions(+), 1 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=34450bf32b3e4b410ee2a…

1 0

Alexandre Julliard : server: Create anonymous file mappings in the config directory if the server directory is mounted noexec .
by Alexandre Julliard 07 Apr '11

07 Apr '11

Module: wine Branch: stable Commit: a4a0226c54ba25c05d94a660bb014fe2e176c3d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a4a0226c54ba25c05d94a660b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 28 17:23:45 2011 +0100 server: Create anonymous file mappings in the config directory if the server directory is mounted noexec. (cherry picked from commit 8dbd06a1f8ab3f89e46be62e05a51f4b15f20b1c) --- server/mapping.c | 43 +++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 41 insertions(+), 2 deletions(-) diff --git a/server/mapping.c b/server/mapping.c index 1cf53b9..ca88ca3 100644 --- a/server/mapping.c +++ b/server/mapping.c @@ -26,6 +26,9 @@ #include <stdio.h> #include <stdlib.h> #include <sys/stat.h> +#ifdef HAVE_SYS_MMAN_H +# include <sys/mman.h> +#endif #include <unistd.h> #include "ntstatus.h" @@ -161,13 +164,47 @@ static int grow_file( int unix_fd, file_pos_t new_size ) return 0; } +/* check if the current directory allows exec mappings */ +static int check_current_dir_for_exec(void) +{ + int fd; + char tmpfn[] = "anonmap.XXXXXX"; + void *ret = MAP_FAILED; + + fd = mkstemps( tmpfn, 0 ); + if (fd == -1) return 0; + if (grow_file( fd, 1 )) + { + ret = mmap( NULL, get_page_size(), PROT_READ | PROT_EXEC, MAP_PRIVATE, fd, 0 ); + if (ret != MAP_FAILED) munmap( ret, get_page_size() ); + } + close( fd ); + unlink( tmpfn ); + return (ret != MAP_FAILED); +} + /* create a temp file for anonymous mappings */ static int create_temp_file( file_pos_t size ) { - char tmpfn[16]; + static int temp_dir_fd = -1; + char tmpfn[] = "anonmap.XXXXXX"; int fd; - sprintf( tmpfn, "anonmap.XXXXXX" ); /* create it in the server directory */ + if (temp_dir_fd == -1) + { + temp_dir_fd = server_dir_fd; + if (!check_current_dir_for_exec()) + { + /* the server dir is noexec, try the config dir instead */ + fchdir( config_dir_fd ); + if (check_current_dir_for_exec()) + temp_dir_fd = config_dir_fd; + else /* neither works, fall back to server dir */ + fchdir( server_dir_fd ); + } + } + else if (temp_dir_fd != server_dir_fd) fchdir( temp_dir_fd ); + fd = mkstemps( tmpfn, 0 ); if (fd != -1) { @@ -179,6 +216,8 @@ static int create_temp_file( file_pos_t size ) unlink( tmpfn ); } else file_set_error(); + + if (temp_dir_fd != server_dir_fd) fchdir( server_dir_fd ); return fd; }

1 0