July 2011 - Wine-commits - list.winehq.org

Frédéric Delanoy : cmd: Avoid printing an excess newline after version is displayed on startup.
by Alexandre Julliard 15 Jul '11

15 Jul '11

1 0

Frédéric Delanoy : cmd: Do not show prompt when echo mode is off.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: f43297f989625496aef799256207650eb657134f URL: http://source.winehq.org/git/wine.git/?a=commit;h=f43297f989625496aef799256… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Jul 14 14:08:09 2011 +0200 cmd: Do not show prompt when echo mode is off. --- programs/cmd/wcmdmain.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index 28394c1..bd572d2 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -2555,7 +2555,7 @@ int wmain (int argc, WCHAR *argvW[]) /* Read until EOF (which for std input is never, but if redirect in place, may occur */ - WCMD_show_prompt (); + if (echo_mode) WCMD_show_prompt(); if (WCMD_ReadAndParseLine(NULL, &toExecute, GetStdHandle(STD_INPUT_HANDLE)) == NULL) break;

1 0

Frédéric Delanoy : cmd: Avoid excess newline after TYPE outputs file contents.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: 4b4dd300f6832be491610943b01b80118f978c27 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b4dd300f6832be491610943b… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Jul 14 20:07:14 2011 +0200 cmd: Avoid excess newline after TYPE outputs file contents. --- programs/cmd/builtins.c | 2 -- programs/cmd/tests/test_builtins.cmd | 10 ++++++++++ programs/cmd/tests/test_builtins.cmd.exp | 9 +++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index 0352e59..86fd54c 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -2532,8 +2532,6 @@ void WCMD_type (WCHAR *command) { WCMD_output_asis (buffer); } CloseHandle (h); - if (!writeHeaders) - WCMD_output_asis (newline); } } } diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index 3011e4d..bcff6e8 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -58,6 +58,16 @@ echo P%ERRORLEVEL% echo %ERRORLEVEL%S echo P%ERRORLEVEL%S +echo ------------ Testing type ------------ +echo bar> foobaz +(a)echo on +type foobaz +echo *** +(a)echo off +type foobaz +echo *** +del foobaz + echo ------------ Testing if/else -------------- echo if/else should work with blocks if 0 == 0 ( diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index 229adc4..eb55151 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -70,6 +70,15 @@ ERRORLEVEL P0 0S P0S +------------ Testing type ------------ + +(a)pwd@>type foobaz(a)space@ +bar + +(a)pwd@>echo ***@space@ +*** +bar +*** ------------ Testing if/else -------------- if/else should work with blocks if seems to work

1 0

Frédéric Delanoy : cmd: Output a empty line before version in VER.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: 123d5d0d600e52c75533ae3e88c7d15d7548d9ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=123d5d0d600e52c75533ae3e8… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Jul 14 13:54:41 2011 +0200 cmd: Output a empty line before version in VER. --- programs/cmd/wcmdmain.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index 5280679..28394c1 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -1519,6 +1519,7 @@ void WCMD_execute (WCHAR *command, WCHAR *redirects, WCMD_type (p); break; case WCMD_VER: + WCMD_output(newline); WCMD_version (); break; case WCMD_VERIFY:

1 0

Jacek Caban : mshtml: Factor out getting style value string from Gecko value.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: 9257ab8a5c1596a7b13a836bf445814b56abb617 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9257ab8a5c1596a7b13a836bf… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 15 15:37:40 2011 +0200 mshtml: Factor out getting style value string from Gecko value. --- dlls/mshtml/htmlstyle.c | 37 ++++++++++++++++++++++++++----------- 1 files changed, 26 insertions(+), 11 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index e34f001..ff12bdd 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -407,18 +407,35 @@ static HRESULT get_nsstyle_attr_nsval(nsIDOMCSSStyleDeclaration *nsstyle, stylei return NS_OK; } +static HRESULT nsstyle_to_bstr(const WCHAR *val, DWORD flags, BSTR *p) +{ + BSTR ret; + + if(!*val) { + *p = NULL; + return S_OK; + } + + ret = SysAllocString(val); + if(!ret) + return E_OUTOFMEMORY; + + *p = ret; + return S_OK; +} + HRESULT get_nsstyle_attr(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, BSTR *p) { nsAString str_value; const PRUnichar *value; + HRESULT hres; nsAString_Init(&str_value, NULL); get_nsstyle_attr_nsval(nsstyle, sid, &str_value); nsAString_GetData(&str_value, &value); - *p = *value ? SysAllocString(value) : NULL; - + hres = nsstyle_to_bstr(value, 0, p); nsAString_Finish(&str_value); TRACE("%s -> %s\n", debugstr_w(style_tbl[sid].name), debugstr_w(*p)); @@ -430,6 +447,7 @@ HRESULT get_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, nsAString str_value; const PRUnichar *value; BOOL set = FALSE; + HRESULT hres = S_OK; nsAString_Init(&str_value, NULL); @@ -458,22 +476,19 @@ HRESULT get_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, } if(!set) { - BSTR str = NULL; + BSTR str; - if(*value) { - str = SysAllocString(value); - if(!str) - return E_OUTOFMEMORY; + hres = nsstyle_to_bstr(value, flags, &str); + if(SUCCEEDED(hres)) { + V_VT(p) = VT_BSTR; + V_BSTR(p) = str; } - - V_VT(p) = VT_BSTR; - V_BSTR(p) = str; } nsAString_Finish(&str_value); TRACE("%s -> %s\n", debugstr_w(style_tbl[sid].name), debugstr_variant(p)); - return S_OK; + return hres; } static inline HRESULT get_style_attr(HTMLStyle *This, styleid_t sid, BSTR *p)

1 0

Jacek Caban : mshtml: Pass flags to get_nsstyle_attr.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: e0631980467d5ed639d64c90e21faef564d1e924 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e0631980467d5ed639d64c90e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 15 15:37:56 2011 +0200 mshtml: Pass flags to get_nsstyle_attr. --- dlls/mshtml/htmlcurstyle.c | 42 +++++++++++++++++++++--------------------- dlls/mshtml/htmlstyle.c | 6 +++--- dlls/mshtml/htmlstyle.h | 2 +- dlls/mshtml/htmlstyle2.c | 2 +- dlls/mshtml/htmlstyle3.c | 2 +- 5 files changed, 27 insertions(+), 27 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e0631980467d5ed639d64…

1 0

Jacek Caban : mshtml: Added IHTMLStyle::clip property implementation.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: b7934f0ad197dc00d2e0c541f17ec9b5949f6b65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b7934f0ad197dc00d2e0c541f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 15 15:38:08 2011 +0200 mshtml: Added IHTMLStyle::clip property implementation. --- dlls/mshtml/htmlstyle.c | 46 +++++++++++++++++++++++++++++++++++++++++----- dlls/mshtml/htmlstyle.h | 10 ++++++---- 2 files changed, 47 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index b9a18c7..cd1f6b5 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -91,6 +91,8 @@ static const WCHAR attrBorderWidth[] = {'b','o','r','d','e','r','-','w','i','d','t','h',0}; static const WCHAR attrBottom[] = {'b','o','t','t','o','m',0}; +static const WCHAR attrClip[] = + {'c','l','i','p',0}; static const WCHAR attrColor[] = {'c','o','l','o','r',0}; static const WCHAR attrCursor[] = @@ -198,6 +200,7 @@ static const struct{ {attrBorderTopWidth, DISPID_IHTMLSTYLE_BORDERTOPWIDTH}, {attrBorderWidth, DISPID_IHTMLSTYLE_BORDERWIDTH}, {attrBottom, DISPID_IHTMLSTYLE2_BOTTOM}, + {attrClip, DISPID_IHTMLSTYLE_CLIP}, {attrColor, DISPID_IHTMLSTYLE_COLOR}, {attrCursor, DISPID_IHTMLSTYLE_CURSOR}, {attrDisplay, DISPID_IHTMLSTYLE_DISPLAY}, @@ -410,6 +413,7 @@ static HRESULT get_nsstyle_attr_nsval(nsIDOMCSSStyleDeclaration *nsstyle, stylei static HRESULT nsstyle_to_bstr(const WCHAR *val, DWORD flags, BSTR *p) { BSTR ret; + DWORD len; if(!*val) { *p = NULL; @@ -420,6 +424,34 @@ static HRESULT nsstyle_to_bstr(const WCHAR *val, DWORD flags, BSTR *p) if(!ret) return E_OUTOFMEMORY; + len = SysStringLen(ret); + + if(flags & ATTR_REMOVE_COMMA) { + DWORD new_len = len; + WCHAR *ptr, *ptr2; + + for(ptr = ret; (ptr = strchrW(ptr, ',')); ptr++) + new_len--; + + if(new_len != len) { + BSTR new_ret; + + new_ret = SysAllocStringLen(NULL, new_len); + if(!new_ret) { + SysFreeString(ret); + return E_OUTOFMEMORY; + } + + for(ptr2 = new_ret, ptr = ret; *ptr; ptr++) { + if(*ptr != ',') + *ptr2++ = *ptr; + } + + SysFreeString(ret); + ret = new_ret; + } + } + *p = ret; return S_OK; } @@ -488,7 +520,7 @@ HRESULT get_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, nsAString_Finish(&str_value); TRACE("%s -> %s\n", debugstr_w(style_tbl[sid].name), debugstr_variant(p)); - return hres; + return S_OK; } static inline HRESULT get_style_attr(HTMLStyle *This, styleid_t sid, BSTR *p) @@ -2549,15 +2581,19 @@ static HRESULT WINAPI HTMLStyle_get_cursor(IHTMLStyle *iface, BSTR *p) static HRESULT WINAPI HTMLStyle_put_clip(IHTMLStyle *iface, BSTR v) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); - return E_NOTIMPL; + + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); + + return set_style_attr(This, STYLEID_CLIP, v, 0); } static HRESULT WINAPI HTMLStyle_get_clip(IHTMLStyle *iface, BSTR *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_nsstyle_attr(This->nsstyle, STYLEID_CLIP, p, ATTR_REMOVE_COMMA); } static void set_opacity(HTMLStyle *This, const WCHAR *val) diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h index f4f36a1..154c391 100644 --- a/dlls/mshtml/htmlstyle.h +++ b/dlls/mshtml/htmlstyle.h @@ -59,6 +59,7 @@ typedef enum { STYLEID_BORDER_TOP_WIDTH, STYLEID_BORDER_WIDTH, STYLEID_BOTTOM, + STYLEID_CLIP, STYLEID_COLOR, STYLEID_CURSOR, STYLEID_DISPLAY, @@ -107,7 +108,8 @@ HRESULT set_nsstyle_attr(nsIDOMCSSStyleDeclaration*,styleid_t,LPCWSTR,DWORD) DEC HRESULT set_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, VARIANT *value, DWORD flags) DECLSPEC_HIDDEN; HRESULT get_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, VARIANT *p, DWORD flags) DECLSPEC_HIDDEN; -#define ATTR_FIX_PX 1 -#define ATTR_FIX_URL 2 -#define ATTR_STR_TO_INT 4 -#define ATTR_HEX_INT 8 +#define ATTR_FIX_PX 0x0001 +#define ATTR_FIX_URL 0x0002 +#define ATTR_STR_TO_INT 0x0004 +#define ATTR_HEX_INT 0x0008 +#define ATTR_REMOVE_COMMA 0x0010

1 0

Jacek Caban : mshtml: Added IHTMLStyle::clip tests.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: d1d2b46d79e6cbdb9723aa815072a9ac715fbb75 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1d2b46d79e6cbdb9723aa815… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 15 15:38:18 2011 +0200 mshtml: Added IHTMLStyle::clip tests. --- dlls/mshtml/tests/dom.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 21f183c..b629071 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5691,6 +5691,21 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_put_borderLeftColor(style, vDefault); ok(hres == S_OK, "put_borderLeftColor: %08x\n", hres); + /* clip */ + hres = IHTMLStyle_get_clip(style, &str); + ok(hres == S_OK, "get_clip failed: %08x\n", hres); + ok(!str, "clip = %s\n", wine_dbgstr_w(str)); + + str = a2bstr("rect(0px 1px 500px 505px)"); + hres = IHTMLStyle_put_clip(style, str); + ok(hres == S_OK, "put_clip failed: %08x\n", hres); + SysFreeString(str); + + hres = IHTMLStyle_get_clip(style, &str); + ok(hres == S_OK, "get_clip failed: %08x\n", hres); + ok(!strcmp_wa(str, "rect(0px 1px 500px 505px)"), "clip = %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, (void**)&style2); ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres); if(SUCCEEDED(hres)) {

1 0

Frédéric Delanoy : po: Update French translation.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: 760c1f1055c4b02d27f84fa9a51bd4af64538ae5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=760c1f1055c4b02d27f84fa9a… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Jul 15 11:47:44 2011 +0200 po: Update French translation. --- po/fr.po | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/po/fr.po b/po/fr.po index da48a0e..3161b35 100644 --- a/po/fr.po +++ b/po/fr.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2011-06-15 21:15+0100\n" +"PO-Revision-Date: 2011-07-14 22:15+0100\n" "Last-Translator: Frédéric Delanoy <frederic.delanoy(a)gmail.com>\n" "Language-Team: none\n" "Language: French\n" @@ -168,7 +168,6 @@ msgid "System Path" msgstr "Chemin système (path)" #: comdlg32.rc:34 shell32.rc:153 winecfg.rc:119 winefile.rc:103 -#, fuzzy msgctxt "display name" msgid "Desktop" msgstr "Bureau" @@ -6385,14 +6384,13 @@ msgid "Properties" msgstr "Propriétés" #: shell32.rc:82 -#, fuzzy msgctxt "recycle bin" msgid "&Restore" msgstr "&Restaurer" #: shell32.rc:83 msgid "&Erase" -msgstr "" +msgstr "&Effacer" #: shell32.rc:95 msgid "E&xplore" @@ -6520,7 +6518,6 @@ msgid "My Videos" msgstr "Mes vidéos" #: shell32.rc:207 -#, fuzzy msgctxt "directory" msgid "Desktop" msgstr "Bureau" @@ -6875,7 +6872,6 @@ msgid " sec" msgstr " s" #: user32.rc:27 user32.rc:40 taskmgr.rc:138 -#, fuzzy msgctxt "window" msgid "&Restore" msgstr "&Restaurer"

1 0

Bernhard Loos : rpcrt4: Create pipes with FLAG_OVERLAPPED.
by Alexandre Julliard 15 Jul '11

15 Jul '11

Module: wine Branch: master Commit: d599813b744bb8933e221d8c2b8356e7ce3a1567 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d599813b744bb8933e221d8c2… Author: Bernhard Loos <bernhardloos(a)googlemail.com> Date: Thu Jul 14 02:19:16 2011 +0200 rpcrt4: Create pipes with FLAG_OVERLAPPED. --- dlls/rpcrt4/rpc_transport.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index 467c305..8f54575 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -163,7 +163,7 @@ static RPC_STATUS rpcrt4_conn_create_pipe(RpcConnection *Connection, LPCSTR pnam RpcConnection_np *npc = (RpcConnection_np *) Connection; TRACE("listening on %s\n", pname); - npc->pipe = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + npc->pipe = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL);

1 0