July 2011 - Wine-commits - list.winehq.org

Andrew Eikum : winmm: Implement waveOut* on top of MMDevAPI.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: be158e48ad8ee556941bd3f1ff94ca7116680d00 URL: http://source.winehq.org/git/wine.git/?a=commit;h=be158e48ad8ee556941bd3f1f… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon Jul 11 08:28:30 2011 -0500 winmm: Implement waveOut* on top of MMDevAPI. --- dlls/winmm/Makefile.in | 2 +- dlls/winmm/waveform.c | 2142 +++++++++++++++++++++++++++++++++++++++++++++--- dlls/winmm/winemm.h | 2 + dlls/winmm/winmm.c | 2 +- 4 files changed, 2042 insertions(+), 106 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=be158e48ad8ee556941bd…

1 0

Frédéric Delanoy : po: Update French translation.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: 16a044c34e651fe37543a3e4a6c389edc5307ccb URL: http://source.winehq.org/git/wine.git/?a=commit;h=16a044c34e651fe37543a3e4a… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Mon Jul 11 21:18:13 2011 +0200 po: Update French translation. --- po/fr.po | 41 +++++++++++++++++------------------------ 1 files changed, 17 insertions(+), 24 deletions(-) diff --git a/po/fr.po b/po/fr.po index 89aa430..8968ace 100644 --- a/po/fr.po +++ b/po/fr.po @@ -6777,44 +6777,38 @@ msgstr "" "Aucun programme Windows n'est configuré pour ouvrir ce type de fichier." #: shell32.rc:255 -#, fuzzy msgid "Are you sure you wish to permanently delete '%1'?" -msgstr "Voulez-vous réellement supprimer « %1 » ?" +msgstr "Voulez-vous réellement supprimer définitivement « %1 » ?" #: shell32.rc:256 -#, fuzzy msgid "Are you sure you wish to permanently delete these %1 items?" -msgstr "Voulez-vous réellement supprimer ces %1 éléments ?" +msgstr "Voulez-vous réellement supprimer définitivement ces %1 éléments ?" #: shell32.rc:257 -#, fuzzy msgid "Confirm deletion" -msgstr "Confirmez la suppression du fichier" +msgstr "Confirmez la suppression" #: shell32.rc:258 -#, fuzzy msgid "" "A file already exists at the path %1.\n" "\n" "Do you want to replace it?" msgstr "" -"Ce fichier existe déjà.\n" +"Un fichier existe déjà dans le chemin %1.\n" "Voulez-vous le remplacer ?" #: shell32.rc:259 -#, fuzzy msgid "" "A folder already exists at the path %1.\n" "\n" "Do you want to replace it?" msgstr "" -"Ce fichier existe déjà.\n" +"Un dossier existe déjà dans le chemin %1.\n" "Voulez-vous le remplacer ?" #: shell32.rc:260 -#, fuzzy msgid "Confirm overwrite" -msgstr "Confirmez l'écrasement du fichier" +msgstr "Confirmez l'écrasement" #: shell32.rc:277 msgid "" @@ -8531,9 +8525,8 @@ msgid "Wine Explorer" msgstr "Explorateur de Wine" #: explorer.rc:29 -#, fuzzy msgid "Location:" -msgstr "Emplacement" +msgstr "Emplacement :" #: hostname.rc:27 msgid "Usage: hostname\n" @@ -9646,7 +9639,6 @@ msgid "Exports selected branch of the registry to a text file" msgstr "Exporte la branche du registre sélectionnée dans un fichier texte" #: start.rc:46 -#, fuzzy msgid "" "Start a program, or open a document in the program normally used for files " "with that suffix.\n" @@ -9670,22 +9662,23 @@ msgid "" "This is free software, and you are welcome to redistribute it\n" "under certain conditions; run 'start /L' for details.\n" msgstr "" -"Lance un programme, ou ouvre un document avec le programme normalement " +"Lancer un programme, ou ouvrir un document avec le programme normalement " "associé à cette extension.\n" "Usage :\n" "start [options] fichier_programme [...]\n" "start [options] fichier_document\n" "\n" "Options :\n" -"/M[inimized] Lance le programme minimisé.\n" -"/MAX[imized] Lance le programme maximisé.\n" -"/R[estored] Lance le programme normalement (ni minimisé ni " +"/M[inimized] Lancer le programme minimisé.\n" +"/MAX[imized] Lancer le programme maximisé.\n" +"/R[estored] Lancer le programme normalement (ni minimisé ni " "maximisé).\n" -"/W[ait] Attend que le programme lancé se termine, et renvoie " -"ensuite son code de sortie.\n" -"/ProgIDOpen progID Ouvre un document en utilisant le programme identifié par " -"progID.\n" -"/L Affiche la licence d'utilisation.\n" +"/W[ait] Attendre que le programme lancé se termine, puis renvoyer " +"son code de sortie.\n" +"/ProgIDOpen progID Ouvrir un document en utilisant le programme identifié " +"par progID.\n" +"/L Afficher la licence d'utilisation.\n" +"/? Afficher cette aide et se terminer.\n" "\n" "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "Start est fourni sans AUCUNE GARANTIE ; pour les détails lancez avec "

1 0

Henri Verbeet : wined3d: Only use state contained in the ffp_frag_settings structure in gen_arbfp_ffp_shader ().
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: 1f6f94675ec190c00e54578fbb0268f3d2be8096 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f6f94675ec190c00e54578fb… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Jul 11 22:04:29 2011 +0200 wined3d: Only use state contained in the ffp_frag_settings structure in gen_arbfp_ffp_shader(). Note that the actual check looks off by one too. --- dlls/wined3d/arb_program_shader.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index b9586d5..66f1695 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -5960,6 +5960,7 @@ static GLuint gen_arbfp_ffp_shader(const struct ffp_frag_settings *settings, str BOOL tex_read[MAX_TEXTURES] = {FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}; BOOL bump_used[MAX_TEXTURES] = {FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}; BOOL luminance_used[MAX_TEXTURES] = {FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}; + UINT lowest_disabled_stage; const char *textype; const char *instr, *sat; char colorcor_dst[8]; @@ -6018,6 +6019,7 @@ static GLuint gen_arbfp_ffp_shader(const struct ffp_frag_settings *settings, str tfactor_used = TRUE; } } + lowest_disabled_stage = stage; /* Shader header */ if (!shader_buffer_init(&buffer)) @@ -6063,7 +6065,7 @@ static GLuint gen_arbfp_ffp_shader(const struct ffp_frag_settings *settings, str srgb_sub_high, 0.0, 0.0, 0.0); } - if (ffp_clip_emul(&stateblock->state) && settings->emul_clipplanes) + if (lowest_disabled_stage < 7 && settings->emul_clipplanes) shader_addline(&buffer, "KIL fragment.texcoord[7];\n"); /* Generate texture sampling instructions) */

1 0

Henri Verbeet : wined3d: Explicitly pass gl_info to gen_arbfp_ffp_shader().
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: d1b650e9595d0d5aa7c1887c139d620d198de7ab URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1b650e9595d0d5aa7c1887c1… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Jul 11 22:04:30 2011 +0200 wined3d: Explicitly pass gl_info to gen_arbfp_ffp_shader(). --- dlls/wined3d/arb_program_shader.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 66f1695..aef4fab 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -5952,9 +5952,8 @@ static void gen_ffp_instr(struct wined3d_shader_buffer *buffer, unsigned int sta } } -static GLuint gen_arbfp_ffp_shader(const struct ffp_frag_settings *settings, struct wined3d_stateblock *stateblock) +static GLuint gen_arbfp_ffp_shader(const struct ffp_frag_settings *settings, const struct wined3d_gl_info *gl_info) { - const struct wined3d_gl_info *gl_info = &stateblock->device->adapter->gl_info; unsigned int stage; struct wined3d_shader_buffer buffer; BOOL tex_read[MAX_TEXTURES] = {FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}; @@ -6280,7 +6279,7 @@ static void fragment_prog_arbfp(DWORD state_id, struct wined3d_stateblock *state } memcpy(&new_desc->parent.settings, &settings, sizeof(settings)); - new_desc->shader = gen_arbfp_ffp_shader(&settings, stateblock); + new_desc->shader = gen_arbfp_ffp_shader(&settings, gl_info); add_ffp_frag_shader(&priv->fragment_shaders, &new_desc->parent); TRACE("Allocated fixed function replacement shader descriptor %p\n", new_desc); desc = new_desc;

1 0

Henri Verbeet : wined3d: Make the swapchain parameter to x11_copy_to_screen () const.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: a86785d06519ffb9338fcee08492e1ed8fab958f URL: http://source.winehq.org/git/wine.git/?a=commit;h=a86785d06519ffb9338fcee08… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Jul 11 22:04:31 2011 +0200 wined3d: Make the swapchain parameter to x11_copy_to_screen() const. --- dlls/wined3d/swapchain.c | 4 ++-- dlls/wined3d/wined3d_private.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 405d89f..4752e39 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -644,9 +644,9 @@ static const struct wined3d_swapchain_ops swapchain_gl_ops = }; /* Helper function that blits the front buffer contents to the target window. */ -void x11_copy_to_screen(struct wined3d_swapchain *swapchain, const RECT *rect) +void x11_copy_to_screen(const struct wined3d_swapchain *swapchain, const RECT *rect) { - struct wined3d_surface *front; + const struct wined3d_surface *front; POINT offset = {0, 0}; HDC src_dc, dst_dc; RECT draw_rect; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index d4c5e9f..f104a19 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2451,7 +2451,7 @@ struct wined3d_swapchain HWND backup_wnd; }; -void x11_copy_to_screen(struct wined3d_swapchain *swapchain, const RECT *rect) DECLSPEC_HIDDEN; +void x11_copy_to_screen(const struct wined3d_swapchain *swapchain, const RECT *rect) DECLSPEC_HIDDEN; struct wined3d_context *swapchain_get_context(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; void swapchain_destroy_contexts(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN;

1 0

Henri Verbeet : wined3d: Make the shader parameter to vshader_get_input() const.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: 48881c0792947618b7f940e1a9f3d5800f752044 URL: http://source.winehq.org/git/wine.git/?a=commit;h=48881c0792947618b7f940e1a… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Jul 11 22:04:32 2011 +0200 wined3d: Make the shader parameter to vshader_get_input() const. --- dlls/wined3d/shader.c | 2 +- dlls/wined3d/wined3d_private.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index 79a2759..d0d8d08 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -1706,7 +1706,7 @@ static BOOL match_usage(BYTE usage1, BYTE usage_idx1, BYTE usage2, BYTE usage_id return FALSE; } -BOOL vshader_get_input(struct wined3d_shader *shader, +BOOL vshader_get_input(const struct wined3d_shader *shader, BYTE usage_req, BYTE usage_idx_req, unsigned int *regnum) { WORD map = shader->reg_maps.input_registers; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index f104a19..b959543 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2558,7 +2558,7 @@ int shader_addline(struct wined3d_shader_buffer *buffer, const char *fmt, ...) P int shader_vaddline(struct wined3d_shader_buffer *buffer, const char *fmt, va_list args) DECLSPEC_HIDDEN; /* Vertex shader utility functions */ -extern BOOL vshader_get_input(struct wined3d_shader *shader, +BOOL vshader_get_input(const struct wined3d_shader *shader, BYTE usage_req, BYTE usage_idx_req, unsigned int *regnum) DECLSPEC_HIDDEN; struct wined3d_vertex_shader

1 0

Henri Verbeet : wined3d: Make the shader parameter to shader_generate_main( ) const.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: d67d7ebbcb3f67838e06da5fa5c97f1880f54b3d URL: http://source.winehq.org/git/wine.git/?a=commit;h=d67d7ebbcb3f67838e06da5fa… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Jul 11 22:04:33 2011 +0200 wined3d: Make the shader parameter to shader_generate_main() const. --- dlls/wined3d/shader.c | 2 +- dlls/wined3d/wined3d_private.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index d0d8d08..bf9cb23 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -1164,7 +1164,7 @@ void shader_dump_src_param(const struct wined3d_shader_src_param *param, /* Shared code in order to generate the bulk of the shader string. * NOTE: A description of how to parse tokens can be found on MSDN. */ -void shader_generate_main(struct wined3d_shader *shader, struct wined3d_shader_buffer *buffer, +void shader_generate_main(const struct wined3d_shader *shader, struct wined3d_shader_buffer *buffer, const struct wined3d_shader_reg_maps *reg_maps, const DWORD *byte_code, void *backend_ctx) { struct wined3d_device *device = shader->device; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index b959543..682c21b 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2633,8 +2633,8 @@ void shader_dump_dst_param(const struct wined3d_shader_dst_param *param, const struct wined3d_shader_version *shader_version) DECLSPEC_HIDDEN; unsigned int shader_find_free_input_register(const struct wined3d_shader_reg_maps *reg_maps, unsigned int max) DECLSPEC_HIDDEN; -void shader_generate_main(struct wined3d_shader *shader, struct wined3d_shader_buffer *buffer, - const struct wined3d_shader_reg_maps *reg_maps, const DWORD *pFunction, void *backend_ctx) DECLSPEC_HIDDEN; +void shader_generate_main(const struct wined3d_shader *shader, struct wined3d_shader_buffer *buffer, + const struct wined3d_shader_reg_maps *reg_maps, const DWORD *byte_code, void *backend_ctx) DECLSPEC_HIDDEN; BOOL shader_match_semantic(const char *semantic_name, WINED3DDECLUSAGE usage) DECLSPEC_HIDDEN; static inline BOOL shader_is_pshader_version(enum wined3d_shader_type type)

1 0

Michael Stefaniuc : d3d10core: Use unsafe_impl_from_ID3D10VertexShader for an app provided iface.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: ec415eaf3c5d2c098e609752b4c8a3e66bb31d7d URL: http://source.winehq.org/git/wine.git/?a=commit;h=ec415eaf3c5d2c098e609752b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jul 12 01:51:41 2011 +0200 d3d10core: Use unsafe_impl_from_ID3D10VertexShader for an app provided iface. --- dlls/d3d10core/d3d10core_private.h | 1 + dlls/d3d10core/device.c | 2 +- dlls/d3d10core/shader.c | 15 +++++++++++++++ 3 files changed, 17 insertions(+), 1 deletions(-) diff --git a/dlls/d3d10core/d3d10core_private.h b/dlls/d3d10core/d3d10core_private.h index 2bee04a..12fd54b 100644 --- a/dlls/d3d10core/d3d10core_private.h +++ b/dlls/d3d10core/d3d10core_private.h @@ -176,6 +176,7 @@ struct d3d10_vertex_shader HRESULT d3d10_vertex_shader_init(struct d3d10_vertex_shader *shader, struct d3d10_device *device, const void *byte_code, SIZE_T byte_code_length) DECLSPEC_HIDDEN; +struct d3d10_vertex_shader *unsafe_impl_from_ID3D10VertexShader(ID3D10VertexShader *iface) DECLSPEC_HIDDEN; /* ID3D10GeometryShader */ struct d3d10_geometry_shader diff --git a/dlls/d3d10core/device.c b/dlls/d3d10core/device.c index 3399b29..302c91e 100644 --- a/dlls/d3d10core/device.c +++ b/dlls/d3d10core/device.c @@ -151,7 +151,7 @@ static void STDMETHODCALLTYPE d3d10_device_VSSetShader(ID3D10Device *iface, ID3D10VertexShader *shader) { struct d3d10_device *This = impl_from_ID3D10Device(iface); - struct d3d10_vertex_shader *vs = (struct d3d10_vertex_shader *)shader; + struct d3d10_vertex_shader *vs = unsafe_impl_from_ID3D10VertexShader(shader); TRACE("iface %p, shader %p\n", iface, shader); diff --git a/dlls/d3d10core/shader.c b/dlls/d3d10core/shader.c index a7a40d5..6720c21 100644 --- a/dlls/d3d10core/shader.c +++ b/dlls/d3d10core/shader.c @@ -19,6 +19,7 @@ #include "config.h" #include "wine/port.h" +#include <assert.h> #include "d3d10core_private.h" @@ -132,6 +133,11 @@ void shader_free_signature(struct wined3d_shader_signature *s) HeapFree(GetProcessHeap(), 0, s->elements); } +static inline struct d3d10_vertex_shader *impl_from_ID3D10VertexShader(ID3D10VertexShader *iface) +{ + return CONTAINING_RECORD(iface, struct d3d10_vertex_shader, vtbl); +} + /* IUnknown methods */ static HRESULT STDMETHODCALLTYPE d3d10_vertex_shader_QueryInterface(ID3D10VertexShader *iface, @@ -267,6 +273,15 @@ HRESULT d3d10_vertex_shader_init(struct d3d10_vertex_shader *shader, struct d3d1 return S_OK; } +struct d3d10_vertex_shader *unsafe_impl_from_ID3D10VertexShader(ID3D10VertexShader *iface) +{ + if (!iface) + return NULL; + assert(iface->lpVtbl == &d3d10_vertex_shader_vtbl); + + return impl_from_ID3D10VertexShader(iface); +} + static inline struct d3d10_geometry_shader *impl_from_ID3D10GeometryShader(ID3D10GeometryShader *iface) { return CONTAINING_RECORD(iface, struct d3d10_geometry_shader, ID3D10GeometryShader_iface);

1 0

Michael Stefaniuc : d3d10core: COM cleanup for the ID3D10VertexShader iface .
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: cc0cc6a80fa69712856ebb328681b70fba90d940 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cc0cc6a80fa69712856ebb328… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jul 12 01:54:04 2011 +0200 d3d10core: COM cleanup for the ID3D10VertexShader iface. --- dlls/d3d10core/d3d10core_private.h | 2 +- dlls/d3d10core/device.c | 2 +- dlls/d3d10core/shader.c | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/d3d10core/d3d10core_private.h b/dlls/d3d10core/d3d10core_private.h index 12fd54b..50d31b0 100644 --- a/dlls/d3d10core/d3d10core_private.h +++ b/dlls/d3d10core/d3d10core_private.h @@ -167,7 +167,7 @@ HRESULT d3d10_input_layout_init(struct d3d10_input_layout *layout, struct d3d10_ /* ID3D10VertexShader */ struct d3d10_vertex_shader { - const struct ID3D10VertexShaderVtbl *vtbl; + ID3D10VertexShader ID3D10VertexShader_iface; LONG refcount; struct wined3d_shader *wined3d_shader; diff --git a/dlls/d3d10core/device.c b/dlls/d3d10core/device.c index 302c91e..0f4b75f 100644 --- a/dlls/d3d10core/device.c +++ b/dlls/d3d10core/device.c @@ -879,7 +879,7 @@ static HRESULT STDMETHODCALLTYPE d3d10_device_CreateVertexShader(ID3D10Device *i } TRACE("Created vertex shader %p.\n", object); - *shader = (ID3D10VertexShader *)object; + *shader = &object->ID3D10VertexShader_iface; return S_OK; } diff --git a/dlls/d3d10core/shader.c b/dlls/d3d10core/shader.c index 6720c21..fe112dc 100644 --- a/dlls/d3d10core/shader.c +++ b/dlls/d3d10core/shader.c @@ -135,7 +135,7 @@ void shader_free_signature(struct wined3d_shader_signature *s) static inline struct d3d10_vertex_shader *impl_from_ID3D10VertexShader(ID3D10VertexShader *iface) { - return CONTAINING_RECORD(iface, struct d3d10_vertex_shader, vtbl); + return CONTAINING_RECORD(iface, struct d3d10_vertex_shader, ID3D10VertexShader_iface); } /* IUnknown methods */ @@ -162,7 +162,7 @@ static HRESULT STDMETHODCALLTYPE d3d10_vertex_shader_QueryInterface(ID3D10Vertex static ULONG STDMETHODCALLTYPE d3d10_vertex_shader_AddRef(ID3D10VertexShader *iface) { - struct d3d10_vertex_shader *This = (struct d3d10_vertex_shader *)iface; + struct d3d10_vertex_shader *This = impl_from_ID3D10VertexShader(iface); ULONG refcount = InterlockedIncrement(&This->refcount); TRACE("%p increasing refcount to %u\n", This, refcount); @@ -175,7 +175,7 @@ static ULONG STDMETHODCALLTYPE d3d10_vertex_shader_AddRef(ID3D10VertexShader *if static ULONG STDMETHODCALLTYPE d3d10_vertex_shader_Release(ID3D10VertexShader *iface) { - struct d3d10_vertex_shader *This = (struct d3d10_vertex_shader *)iface; + struct d3d10_vertex_shader *This = impl_from_ID3D10VertexShader(iface); ULONG refcount = InterlockedDecrement(&This->refcount); TRACE("%p decreasing refcount to %u\n", This, refcount); @@ -250,7 +250,7 @@ HRESULT d3d10_vertex_shader_init(struct d3d10_vertex_shader *shader, struct d3d1 struct d3d10_shader_info shader_info; HRESULT hr; - shader->vtbl = &d3d10_vertex_shader_vtbl; + shader->ID3D10VertexShader_iface.lpVtbl = &d3d10_vertex_shader_vtbl; shader->refcount = 1; shader_info.output_signature = &shader->output_signature;

1 0

Michael Stefaniuc : d3d10core: Use unsafe_impl_from_ID3D10PixelShader for an app provided iface.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Module: wine Branch: master Commit: 887a4ff3cc630e0353c744cac31f48389e0a6afe URL: http://source.winehq.org/git/wine.git/?a=commit;h=887a4ff3cc630e0353c744cac… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jul 12 01:55:11 2011 +0200 d3d10core: Use unsafe_impl_from_ID3D10PixelShader for an app provided iface. --- dlls/d3d10core/d3d10core_private.h | 1 + dlls/d3d10core/device.c | 2 +- dlls/d3d10core/shader.c | 14 ++++++++++++++ 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/dlls/d3d10core/d3d10core_private.h b/dlls/d3d10core/d3d10core_private.h index 50d31b0..17c3bae 100644 --- a/dlls/d3d10core/d3d10core_private.h +++ b/dlls/d3d10core/d3d10core_private.h @@ -203,6 +203,7 @@ struct d3d10_pixel_shader HRESULT d3d10_pixel_shader_init(struct d3d10_pixel_shader *shader, struct d3d10_device *device, const void *byte_code, SIZE_T byte_code_length) DECLSPEC_HIDDEN; +struct d3d10_pixel_shader *unsafe_impl_from_ID3D10PixelShader(ID3D10PixelShader *iface) DECLSPEC_HIDDEN; HRESULT shader_parse_signature(const char *data, DWORD data_size, struct wined3d_shader_signature *s) DECLSPEC_HIDDEN; void shader_free_signature(struct wined3d_shader_signature *s) DECLSPEC_HIDDEN; diff --git a/dlls/d3d10core/device.c b/dlls/d3d10core/device.c index 0f4b75f..149afa9 100644 --- a/dlls/d3d10core/device.c +++ b/dlls/d3d10core/device.c @@ -133,7 +133,7 @@ static void STDMETHODCALLTYPE d3d10_device_PSSetShader(ID3D10Device *iface, ID3D10PixelShader *shader) { struct d3d10_device *This = impl_from_ID3D10Device(iface); - struct d3d10_pixel_shader *ps = (struct d3d10_pixel_shader *)shader; + struct d3d10_pixel_shader *ps = unsafe_impl_from_ID3D10PixelShader(shader); TRACE("iface %p, shader %p\n", iface, shader); diff --git a/dlls/d3d10core/shader.c b/dlls/d3d10core/shader.c index fe112dc..79131e1 100644 --- a/dlls/d3d10core/shader.c +++ b/dlls/d3d10core/shader.c @@ -419,6 +419,11 @@ HRESULT d3d10_geometry_shader_init(struct d3d10_geometry_shader *shader, struct return S_OK; } +static inline struct d3d10_pixel_shader *impl_from_ID3D10PixelShader(ID3D10PixelShader *iface) +{ + return CONTAINING_RECORD(iface, struct d3d10_pixel_shader, vtbl); +} + /* IUnknown methods */ static HRESULT STDMETHODCALLTYPE d3d10_pixel_shader_QueryInterface(ID3D10PixelShader *iface, @@ -553,3 +558,12 @@ HRESULT d3d10_pixel_shader_init(struct d3d10_pixel_shader *shader, struct d3d10_ return S_OK; } + +struct d3d10_pixel_shader *unsafe_impl_from_ID3D10PixelShader(ID3D10PixelShader *iface) +{ + if (!iface) + return NULL; + assert(iface->lpVtbl == &d3d10_pixel_shader_vtbl); + + return impl_from_ID3D10PixelShader(iface); +}

1 0