August 2011 - Wine-commits - list.winehq.org

Michael Stefaniuc : dpnet: COM cleanup for the IDirectPlay8ThreadPool iface .
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 41059e1606a46bd8a52285d7eb24d5b837620b61 URL: http://source.winehq.org/git/wine.git/?a=commit;h=41059e1606a46bd8a52285d7e… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Aug 5 13:12:43 2011 +0200 dpnet: COM cleanup for the IDirectPlay8ThreadPool iface. --- dlls/dpnet/dpnet_private.h | 5 ++--- dlls/dpnet/threadpool.c | 39 +++++++++++++++++++++++++-------------- 2 files changed, 27 insertions(+), 17 deletions(-) diff --git a/dlls/dpnet/dpnet_private.h b/dlls/dpnet/dpnet_private.h index 8207a67..9254295 100644 --- a/dlls/dpnet/dpnet_private.h +++ b/dlls/dpnet/dpnet_private.h @@ -93,9 +93,8 @@ struct IDirectPlay8PeerImpl */ struct IDirectPlay8ThreadPoolImpl { - /* IUnknown fields */ - const IDirectPlay8ThreadPoolVtbl *lpVtbl; - LONG ref; + IDirectPlay8ThreadPool IDirectPlay8ThreadPool_iface; + LONG ref; }; /** diff --git a/dlls/dpnet/threadpool.c b/dlls/dpnet/threadpool.c index f94a3fa..274789d 100644 --- a/dlls/dpnet/threadpool.c +++ b/dlls/dpnet/threadpool.c @@ -37,11 +37,16 @@ WINE_DEFAULT_DEBUG_CHANNEL(dpnet); -/* IUnknown interface follows */ +static inline IDirectPlay8ThreadPoolImpl *impl_from_IDirectPlay8ThreadPool(IDirectPlay8ThreadPool *iface) +{ + return CONTAINING_RECORD(iface, IDirectPlay8ThreadPoolImpl, IDirectPlay8ThreadPool_iface); +} -static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_QueryInterface(PDIRECTPLAY8THREADPOOL iface, REFIID riid, LPVOID *ppobj) +/* IUnknown interface follows */ +static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_QueryInterface(IDirectPlay8ThreadPool *iface, + REFIID riid, void **ppobj) { - IDirectPlay8ThreadPoolImpl *This = (IDirectPlay8ThreadPoolImpl*)iface; + IDirectPlay8ThreadPoolImpl *This = impl_from_IDirectPlay8ThreadPool(iface); if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IDirectPlay8ThreadPool)) @@ -55,17 +60,17 @@ static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_QueryInterface(PDIRECTPLAY8THRE return E_NOINTERFACE; } -static ULONG WINAPI IDirectPlay8ThreadPoolImpl_AddRef(PDIRECTPLAY8THREADPOOL iface) +static ULONG WINAPI IDirectPlay8ThreadPoolImpl_AddRef(IDirectPlay8ThreadPool *iface) { - IDirectPlay8ThreadPoolImpl* This = (IDirectPlay8ThreadPoolImpl*)iface; + IDirectPlay8ThreadPoolImpl* This = impl_from_IDirectPlay8ThreadPool(iface); ULONG RefCount = InterlockedIncrement(&This->ref); return RefCount; } -static ULONG WINAPI IDirectPlay8ThreadPoolImpl_Release(PDIRECTPLAY8THREADPOOL iface) +static ULONG WINAPI IDirectPlay8ThreadPoolImpl_Release(IDirectPlay8ThreadPool *iface) { - IDirectPlay8ThreadPoolImpl* This = (IDirectPlay8ThreadPoolImpl*)iface; + IDirectPlay8ThreadPoolImpl* This = impl_from_IDirectPlay8ThreadPool(iface); ULONG RefCount = InterlockedDecrement(&This->ref); if(!RefCount) @@ -75,31 +80,36 @@ static ULONG WINAPI IDirectPlay8ThreadPoolImpl_Release(PDIRECTPLAY8THREADPOOL if } /* IDirectPlay8ThreadPool interface follows */ -static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_Initialize(PDIRECTPLAY8THREADPOOL iface, PVOID CONST pvUserContext, CONST PFNDPNMESSAGEHANDLER pfn, CONST DWORD dwFlags) +static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_Initialize(IDirectPlay8ThreadPool *iface, + void * const pvUserContext, const PFNDPNMESSAGEHANDLER pfn, const DWORD dwFlags) { FIXME("(%p)->(%p,%p,%x): stub\n", iface, pvUserContext, pfn, dwFlags); return DPN_OK; } -static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_Close(PDIRECTPLAY8THREADPOOL iface, CONST DWORD dwFlags) +static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_Close(IDirectPlay8ThreadPool *iface, + const DWORD dwFlags) { return DPN_OK; } -static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_GetThreadCount(PDIRECTPLAY8THREADPOOL iface, CONST DWORD dwProcessorNum, DWORD* CONST pdwNumThreads, CONST DWORD dwFlags) +static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_GetThreadCount(IDirectPlay8ThreadPool *iface, + const DWORD dwProcessorNum, DWORD * const pdwNumThreads, const DWORD dwFlags) { FIXME("(%p)->(%x,%p,%x): stub\n", iface, dwProcessorNum, pdwNumThreads, dwFlags); *pdwNumThreads = 0; return DPN_OK; } -static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_SetThreadCount(PDIRECTPLAY8THREADPOOL iface, CONST DWORD dwProcessorNum, CONST DWORD dwNumThreads, CONST DWORD dwFlags) +static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_SetThreadCount(IDirectPlay8ThreadPool *iface, + const DWORD dwProcessorNum, const DWORD dwNumThreads, const DWORD dwFlags) { FIXME("(%p)->(%x,%x,%x): stub\n", iface, dwProcessorNum, dwNumThreads, dwFlags); return DPN_OK; } -static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_DoWork(PDIRECTPLAY8THREADPOOL iface, CONST DWORD dwAllowedTimeSlice, CONST DWORD dwFlags) +static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_DoWork(IDirectPlay8ThreadPool *iface, + const DWORD dwAllowedTimeSlice, const DWORD dwFlags) { static BOOL Run = FALSE; @@ -136,8 +146,9 @@ HRESULT DPNET_CreateDirectPlay8ThreadPool(LPCLASSFACTORY iface, LPUNKNOWN punkOu return E_OUTOFMEMORY; } - Client->lpVtbl = &DirectPlay8ThreadPool_Vtbl; + Client->IDirectPlay8ThreadPool_iface.lpVtbl = &DirectPlay8ThreadPool_Vtbl; Client->ref = 0; - return IDirectPlay8ThreadPoolImpl_QueryInterface((PDIRECTPLAY8THREADPOOL)Client, riid, ppobj); + return IDirectPlay8ThreadPoolImpl_QueryInterface(&Client->IDirectPlay8ThreadPool_iface, riid, + ppobj); }

1 0

Michael Stefaniuc : dpnet: COM cleanup for the IDirectPlay8LobbiedApplication iface.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 3a9fa9025701a52fcb5a66a7c22cc0654bffd995 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3a9fa9025701a52fcb5a66a7c… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Aug 5 13:14:21 2011 +0200 dpnet: COM cleanup for the IDirectPlay8LobbiedApplication iface. --- dlls/dpnet/dpnet_private.h | 6 +-- dlls/dpnet/lobbiedapp.c | 117 ++++++++++++++++++++++--------------------- 2 files changed, 62 insertions(+), 61 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3a9fa9025701a52fcb5a6…

1 0

Huw Davies : gdi32: Fix dibdrv_PutImage for the selected bitmap case.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 37423cec7c7d8d651c28485968f3006270f6acb1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=37423cec7c7d8d651c2848596… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Aug 5 13:20:31 2011 +0100 gdi32: Fix dibdrv_PutImage for the selected bitmap case. --- dlls/gdi32/dibdrv/dc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/gdi32/dibdrv/dc.c b/dlls/gdi32/dibdrv/dc.c index b5f4f2b..b0fe47f 100644 --- a/dlls/gdi32/dibdrv/dc.c +++ b/dlls/gdi32/dibdrv/dc.c @@ -542,7 +542,10 @@ static DWORD dibdrv_PutImage( PHYSDEV dev, HBITMAP hbitmap, HRGN clip, BITMAPINF dib = &stand_alone; } else + { + pdev = get_dibdrv_pdev( dev ); dib = &pdev->dib; + } if (info->bmiHeader.biPlanes != 1) goto update_format; if (info->bmiHeader.biBitCount != dib->bit_count) goto update_format;

1 0

Huw Davies : gdi32: Simplify dibdrv_GetImage by merging the stand-alone and selected bitmap cases .
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: c5f484597f4660b5b71c3a84122d9baf69236127 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5f484597f4660b5b71c3a841… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Aug 5 13:20:32 2011 +0100 gdi32: Simplify dibdrv_GetImage by merging the stand-alone and selected bitmap cases. --- dlls/gdi32/dibdrv/dc.c | 74 +++++++++++++++++------------------------------- 1 files changed, 26 insertions(+), 48 deletions(-) diff --git a/dlls/gdi32/dibdrv/dc.c b/dlls/gdi32/dibdrv/dc.c index b0fe47f..6ffb554 100644 --- a/dlls/gdi32/dibdrv/dc.c +++ b/dlls/gdi32/dibdrv/dc.c @@ -380,6 +380,9 @@ static void set_color_info( const dib_info *dib, BITMAPINFO *info ) static DWORD dibdrv_GetImage( PHYSDEV dev, HBITMAP hbitmap, BITMAPINFO *info, struct gdi_image_bits *bits, struct bitblt_coords *src ) { + DWORD ret = ERROR_SUCCESS; + dib_info *dib, stand_alone; + TRACE( "%p %p %p\n", dev, hbitmap, info ); info->bmiHeader.biSize = sizeof(info->bmiHeader); @@ -397,64 +400,39 @@ static DWORD dibdrv_GetImage( PHYSDEV dev, HBITMAP hbitmap, BITMAPINFO *info, if (!bmp) return ERROR_INVALID_HANDLE; assert(bmp->dib); - info->bmiHeader.biWidth = bmp->dib->dsBmih.biWidth; - info->bmiHeader.biHeight = bmp->dib->dsBmih.biHeight; - info->bmiHeader.biBitCount = bmp->dib->dsBmih.biBitCount; - info->bmiHeader.biSizeImage = get_dib_image_size( (BITMAPINFO *)&bmp->dib->dsBmih ); - - switch (info->bmiHeader.biBitCount) - { - case 1: - case 4: - case 8: - if (bmp->color_table) - { - info->bmiHeader.biClrUsed = min( bmp->nb_colors, 1 << info->bmiHeader.biBitCount ); - memcpy( info->bmiColors, bmp->color_table, info->bmiHeader.biClrUsed * sizeof(RGBQUAD) ); - } - break; - case 16: - info->bmiHeader.biCompression = BI_BITFIELDS; - memcpy( info->bmiColors, bmp->dib->dsBitfields, sizeof(bmp->dib->dsBitfields) ); - break; - case 32: - if (bmp->dib->dsBmih.biCompression == BI_BITFIELDS && - memcmp( bmp->dib->dsBitfields, bit_fields_888, sizeof(bmp->dib->dsBitfields) )) - { - info->bmiHeader.biCompression = BI_BITFIELDS; - memcpy( info->bmiColors, bmp->dib->dsBitfields, sizeof(bmp->dib->dsBitfields) ); - } - break; - } - if (bits) + if (!init_dib_info( &stand_alone, &bmp->dib->dsBmih, bmp->dib->dsBitfields, + bmp->color_table, bmp->nb_colors, bmp->dib->dsBm.bmBits, 0 )) { - bits->ptr = bmp->dib->dsBm.bmBits; - bits->is_copy = FALSE; - bits->free = NULL; + ret = ERROR_BAD_FORMAT; + goto done; } - GDI_ReleaseObj( hbitmap ); + dib = &stand_alone; } else { dibdrv_physdev *pdev = get_dibdrv_pdev(dev); + dib = &pdev->dib; + } - info->bmiHeader.biWidth = pdev->dib.width; - info->bmiHeader.biHeight = pdev->dib.stride > 0 ? -pdev->dib.height : pdev->dib.height; - info->bmiHeader.biBitCount = pdev->dib.bit_count; - info->bmiHeader.biSizeImage = pdev->dib.height * abs(pdev->dib.stride); + info->bmiHeader.biWidth = dib->width; + info->bmiHeader.biHeight = dib->stride > 0 ? -dib->height : dib->height; + info->bmiHeader.biBitCount = dib->bit_count; + info->bmiHeader.biSizeImage = dib->height * abs( dib->stride ); - set_color_info( &pdev->dib, info ); + set_color_info( dib, info ); - if (bits) - { - bits->ptr = pdev->dib.bits; - if (pdev->dib.stride < 0) - bits->ptr = (char *)bits->ptr + (pdev->dib.height - 1) * pdev->dib.stride; - bits->is_copy = FALSE; - bits->free = NULL; - } + if (bits) + { + bits->ptr = dib->bits; + if (dib->stride < 0) + bits->ptr = (char *)bits->ptr + (dib->height - 1) * dib->stride; + bits->is_copy = FALSE; + bits->free = NULL; } - return ERROR_SUCCESS; + +done: + if (hbitmap) GDI_ReleaseObj( hbitmap ); + return ret; } static BOOL matching_color_info( const dib_info *dib, const BITMAPINFO *info )

1 0

Hans Leidekker : winhttp: Don't depend on shlwapi for decoding a URL.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 9432b8e796d237e98392f8be14add1fb262079bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=9432b8e796d237e98392f8be1… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Aug 5 15:00:19 2011 +0200 winhttp: Don't depend on shlwapi for decoding a URL. --- dlls/winhttp/Makefile.in | 2 +- dlls/winhttp/url.c | 53 ++++++++++++++++++++++++--------------------- 2 files changed, 29 insertions(+), 26 deletions(-) diff --git a/dlls/winhttp/Makefile.in b/dlls/winhttp/Makefile.in index d64cd70..f89cdab 100644 --- a/dlls/winhttp/Makefile.in +++ b/dlls/winhttp/Makefile.in @@ -1,6 +1,6 @@ MODULE = winhttp.dll IMPORTLIB = winhttp -IMPORTS = uuid shlwapi user32 advapi32 +IMPORTS = uuid user32 advapi32 DELAYIMPORTS = oleaut32 crypt32 EXTRALIBS = @SOCKETLIBS@ diff --git a/dlls/winhttp/url.c b/dlls/winhttp/url.c index 6ead33c..a662855 100644 --- a/dlls/winhttp/url.c +++ b/dlls/winhttp/url.c @@ -61,12 +61,32 @@ static BOOL set_component( WCHAR **str, DWORD *str_len, WCHAR *value, DWORD len, return TRUE; } -static BOOL decode_url( LPCWSTR url, LPWSTR buffer, LPDWORD buflen ) +static WCHAR *decode_url( LPCWSTR url, DWORD *len ) { - HRESULT hr = UrlCanonicalizeW( url, buffer, buflen, URL_WININET_COMPATIBILITY | URL_UNESCAPE ); - if (hr == E_POINTER) set_last_error( ERROR_INSUFFICIENT_BUFFER ); - if (hr == E_INVALIDARG) set_last_error( ERROR_INVALID_PARAMETER ); - return (SUCCEEDED(hr)) ? TRUE : FALSE; + const WCHAR *p = url; + WCHAR hex[3], *q, *ret; + + if (!(ret = heap_alloc( *len * sizeof(WCHAR) ))) return NULL; + q = ret; + while (*len > 0) + { + if (p[0] == '%' && isxdigitW( p[1] ) && isxdigitW( p[2] )) + { + hex[0] = p[1]; + hex[1] = p[2]; + hex[2] = 0; + *q++ = strtolW( hex, NULL, 16 ); + p += 3; + *len -= 3; + } + else + { + *q++ = *p++; + *len -= 1; + } + } + *len = q - ret; + return ret; } /*********************************************************************** @@ -75,8 +95,7 @@ static BOOL decode_url( LPCWSTR url, LPWSTR buffer, LPDWORD buflen ) BOOL WINAPI WinHttpCrackUrl( LPCWSTR url, DWORD len, DWORD flags, LPURL_COMPONENTSW uc ) { BOOL ret = FALSE; - WCHAR *p, *q, *r; - WCHAR *url_decoded = NULL; + WCHAR *p, *q, *r, *url_decoded = NULL; TRACE("%s, %d, %x, %p\n", debugstr_w(url), len, flags, uc); @@ -91,28 +110,12 @@ BOOL WINAPI WinHttpCrackUrl( LPCWSTR url, DWORD len, DWORD flags, LPURL_COMPONEN if (flags & ICU_DECODE) { - WCHAR *url_tmp; - DWORD url_len = len + 1; - - if (!(url_tmp = HeapAlloc( GetProcessHeap(), 0, url_len * sizeof(WCHAR) ))) - { - set_last_error( ERROR_OUTOFMEMORY ); - return FALSE; - } - memcpy( url_tmp, url, len * sizeof(WCHAR) ); - url_tmp[len] = 0; - if (!(url_decoded = HeapAlloc( GetProcessHeap(), 0, url_len * sizeof(WCHAR) ))) + if (!(url_decoded = decode_url( url, &len ))) { - HeapFree( GetProcessHeap(), 0, url_tmp ); set_last_error( ERROR_OUTOFMEMORY ); return FALSE; } - if (decode_url( url_tmp, url_decoded, &url_len )) - { - len = url_len; - url = url_decoded; - } - HeapFree( GetProcessHeap(), 0, url_tmp ); + url = url_decoded; } if (!(p = strchrW( url, ':' ))) {

1 0

Francois Gouget : net: Convert to Unicode.
by Alexandre Julliard 05 Aug '11

05 Aug '11

1 0

Francois Gouget : net: Add a WriteConsole() fall back so things still works on Windows if the output is redirected.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 0b2a67cffbb8995104d13ee6d47ad694b123f68c URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b2a67cffbb8995104d13ee6d… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Aug 3 19:44:16 2011 +0200 net: Add a WriteConsole() fall back so things still works on Windows if the output is redirected. --- programs/net/net.c | 34 +++++++++++++++++++++++++++++----- 1 files changed, 29 insertions(+), 5 deletions(-) diff --git a/programs/net/net.c b/programs/net/net.c index 0761571..559ef5c 100644 --- a/programs/net/net.c +++ b/programs/net/net.c @@ -25,18 +25,44 @@ #define NET_START 0001 #define NET_STOP 0002 +static int output_write(WCHAR* str, int len) +{ + DWORD ret, count; + ret = WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), str, len, &count, NULL); + if (!ret) + { + DWORD lenA; + char* strA; + + /* On Windows WriteConsoleW() fails if the output is redirected. So fall + * back to WriteFile(), assuming the console encoding is still the right + * one in that case. + */ + lenA = WideCharToMultiByte(GetConsoleOutputCP(), 0, str, len, + NULL, 0, NULL, NULL); + strA = HeapAlloc(GetProcessHeap(), 0, lenA); + if (!strA) + return 0; + + WideCharToMultiByte(GetConsoleOutputCP(), 0, str, len, strA, lenA, + NULL, NULL); + WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), strA, len, &count, FALSE); + HeapFree(GetProcessHeap(), 0, strA); + } + return count; +} + static int output_string(int msg, ...) { WCHAR fmt[8192]; WCHAR str[8192]; int len; - DWORD count; va_list arguments; LoadStringW(GetModuleHandleW(NULL), msg, fmt, sizeof(fmt)); va_start(arguments, msg); len = vsprintfW(str, fmt, arguments); - WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), str, len, &count, NULL); + output_write(str, len); va_end(arguments); return 0; } @@ -48,9 +74,7 @@ static BOOL output_error_string(DWORD error) FORMAT_MESSAGE_IGNORE_INSERTS | FORMAT_MESSAGE_ALLOCATE_BUFFER, NULL, error, 0, (LPWSTR)&pBuffer, 0, NULL)) { - DWORD count; - int len = lstrlenW(pBuffer); - WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), pBuffer, len, &count, NULL); + output_write(pBuffer, lstrlenW(pBuffer)); LocalFree(pBuffer); return TRUE; }

1 0

Francois Gouget : shell32: Make SHELL_CreateContextMenu() static.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: a61145f2849857571367dab0359449fe80c09e77 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a61145f2849857571367dab03… Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Aug 5 09:56:41 2011 +0200 shell32: Make SHELL_CreateContextMenu() static. --- dlls/shell32/shlmenu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shlmenu.c b/dlls/shell32/shlmenu.c index b37d526..4006807 100644 --- a/dlls/shell32/shlmenu.c +++ b/dlls/shell32/shlmenu.c @@ -1246,7 +1246,7 @@ static const IContextMenu3Vtbl CompositeCMenuVtbl= CompositeCMenu_HandleMenuMsg2 }; -HRESULT SHELL_CreateContextMenu(HWND hwnd, IContextMenu* system_menu, +static HRESULT SHELL_CreateContextMenu(HWND hwnd, IContextMenu* system_menu, IShellFolder *folder, LPCITEMIDLIST folder_pidl, LPCITEMIDLIST *apidl, UINT cidl, const HKEY *aKeys, UINT cKeys,REFIID riid, void** ppv)

1 0

Jacek Caban : mshtml: Fixed nsAString handling in navigate_anchor.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 88f9fcf1f42c2c03dbf3e5ea9c71ed9ed3f7ea5d URL: http://source.winehq.org/git/wine.git/?a=commit;h=88f9fcf1f42c2c03dbf3e5ea9… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 5 10:20:08 2011 +0200 mshtml: Fixed nsAString handling in navigate_anchor. --- dlls/mshtml/htmlanchor.c | 43 ++++++++++++++++++++++--------------------- 1 files changed, 22 insertions(+), 21 deletions(-) diff --git a/dlls/mshtml/htmlanchor.c b/dlls/mshtml/htmlanchor.c index 9bf74b2..c369ed5 100644 --- a/dlls/mshtml/htmlanchor.c +++ b/dlls/mshtml/htmlanchor.c @@ -44,36 +44,37 @@ typedef struct { static HRESULT navigate_anchor(HTMLAnchorElement *This) { nsAString href_str, target_str; - const PRUnichar *href, *target; nsresult nsres; HRESULT hres; + nsAString_Init(&target_str, NULL); nsres = nsIDOMHTMLAnchorElement_GetTarget(This->nsanchor, &target_str); - if(NS_FAILED(nsres)) - return E_FAIL; - - nsAString_GetData(&target_str, &target); - if(*target) { - FIXME("Navigating to target %s is not implemented\n", debugstr_w(target)); - nsAString_Finish(&target_str); - return S_OK; + if(NS_SUCCEEDED(nsres)) { + const PRUnichar *target; + + nsAString_GetData(&target_str, &target); + if(*target) { + FIXME("Navigating to target %s is not implemented\n", debugstr_w(target)); + nsAString_Finish(&target_str); + return S_OK; + } } - nsAString_Finish(&target_str); + nsAString_Init(&href_str, NULL); nsres = nsIDOMHTMLAnchorElement_GetHref(This->nsanchor, &href_str); - if(NS_FAILED(nsres)) - return E_FAIL; + if(NS_SUCCEEDED(nsres)) { + const PRUnichar *href; - nsAString_GetData(&href_str, &href); - if(*href) { - HTMLWindow *window = This->element.node.doc->basedoc.window; - hres = navigate_url(window, href, window->url); - }else { - TRACE("empty href\n"); - hres = S_OK; + nsAString_GetData(&href_str, &href); + if(*href) { + HTMLWindow *window = This->element.node.doc->basedoc.window; + hres = navigate_url(window, href, window->url); + }else { + TRACE("empty href\n"); + hres = S_OK; + } } - nsAString_Finish(&href_str); return hres; }

1 0

Jörg Höhle : winmm: Replace one HeapAlloc with stack allocation.
by Alexandre Julliard 05 Aug '11

05 Aug '11

Module: wine Branch: master Commit: 710d2004274deecba33b85c6bb4651006f1c54c1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=710d2004274deecba33b85c6b… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Wed Jul 27 23:44:09 2011 +0200 winmm: Replace one HeapAlloc with stack allocation. --- dlls/winmm/waveform.c | 12 ++---------- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c index 918364b..d1c685e 100644 --- a/dlls/winmm/waveform.c +++ b/dlls/winmm/waveform.c @@ -820,7 +820,7 @@ static MMRESULT WINMM_MapDevice(WINMM_OpenInfo *info, BOOL is_out) static LRESULT WINMM_OpenDevice(WINMM_Device *device, WINMM_MMDevice *mmdevice, WINMM_OpenInfo *info) { - WAVEFORMATEX *closer_fmt = NULL, *passed_fmt; + WAVEFORMATEX *closer_fmt = NULL, fmt, *passed_fmt; LRESULT ret = MMSYSERR_ERROR; HRESULT hr; @@ -843,7 +843,7 @@ static LRESULT WINMM_OpenDevice(WINMM_Device *device, WINMM_MMDevice *mmdevice, if(info->format->wFormatTag == WAVE_FORMAT_PCM){ /* we aren't guaranteed that the struct in lpFormat is a full * WAVEFORMATEX struct, which IAC::IsFormatSupported requires */ - passed_fmt = HeapAlloc(GetProcessHeap(), 0, sizeof(WAVEFORMATEX)); + passed_fmt = &fmt; memcpy(passed_fmt, info->format, sizeof(PCMWAVEFORMAT)); passed_fmt->cbSize = 0; }else @@ -854,20 +854,14 @@ static LRESULT WINMM_OpenDevice(WINMM_Device *device, WINMM_MMDevice *mmdevice, if(closer_fmt) CoTaskMemFree(closer_fmt); if(FAILED(hr) && hr != AUDCLNT_E_UNSUPPORTED_FORMAT){ - if(info->format->wFormatTag == WAVE_FORMAT_PCM) - HeapFree(GetProcessHeap(), 0, passed_fmt); ERR("IsFormatSupported failed: %08x\n", hr); goto error; } if(hr == S_FALSE || hr == AUDCLNT_E_UNSUPPORTED_FORMAT){ - if(info->format->wFormatTag == WAVE_FORMAT_PCM) - HeapFree(GetProcessHeap(), 0, passed_fmt); ret = WAVERR_BADFORMAT; goto error; } if(info->flags & WAVE_FORMAT_QUERY){ - if(info->format->wFormatTag == WAVE_FORMAT_PCM) - HeapFree(GetProcessHeap(), 0, passed_fmt); ret = MMSYSERR_NOERROR; goto error; } @@ -876,8 +870,6 @@ static LRESULT WINMM_OpenDevice(WINMM_Device *device, WINMM_MMDevice *mmdevice, hr = IAudioClient_Initialize(device->client, AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_EVENTCALLBACK | AUDCLNT_STREAMFLAGS_NOPERSIST, 10 * 100000, 50000, passed_fmt, &device->parent->session); - if(info->format->wFormatTag == WAVE_FORMAT_PCM) - HeapFree(GetProcessHeap(), 0, passed_fmt); if(FAILED(hr)){ ERR("Initialize failed: %08x\n", hr); goto error;

1 0