September 2011 - Wine-commits

Jacek Caban : vbscript: Added more tests.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 1c1da3e596caaf226e4930e145e21f4e00e416d5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c1da3e596caaf226e4930e14… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Sep 8 14:58:32 2011 +0200 vbscript: Added more tests. --- dlls/vbscript/tests/Makefile.in | 2 + dlls/vbscript/tests/lang.vbs | 21 +++++++++ dlls/vbscript/tests/rsrc.rc | 20 +++++++++ dlls/vbscript/tests/run.c | 88 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 131 insertions(+), 0 deletions(-) diff --git a/dlls/vbscript/tests/Makefile.in b/dlls/vbscript/tests/Makefile.in index a045f9c..3424612 100644 --- a/dlls/vbscript/tests/Makefile.in +++ b/dlls/vbscript/tests/Makefile.in @@ -5,4 +5,6 @@ C_SRCS = \ run.c \ vbscript.c +RC_SRCS = rsrc.rc + @MAKE_TEST_RULES@ diff --git a/dlls/vbscript/tests/lang.vbs b/dlls/vbscript/tests/lang.vbs new file mode 100644 index 0000000..642c2ff --- /dev/null +++ b/dlls/vbscript/tests/lang.vbs @@ -0,0 +1,21 @@ +' +' Copyright 2011 Jacek Caban for CodeWeavers +' +' This library is free software; you can redistribute it and/or +' modify it under the terms of the GNU Lesser General Public +' License as published by the Free Software Foundation; either +' version 2.1 of the License, or (at your option) any later version. +' +' This library is distributed in the hope that it will be useful, +' but WITHOUT ANY WARRANTY; without even the implied warranty of +' MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +' Lesser General Public License for more details. +' +' You should have received a copy of the GNU Lesser General Public +' License along with this library; if not, write to the Free Software +' Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA +' + +call ok(true, "true is not true?") + +reportSuccess() diff --git a/dlls/vbscript/tests/rsrc.rc b/dlls/vbscript/tests/rsrc.rc new file mode 100644 index 0000000..834df1d --- /dev/null +++ b/dlls/vbscript/tests/rsrc.rc @@ -0,0 +1,20 @@ +/* + * Copyright 2011 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +/* @makedep: lang.vbs */ +lang.vbs 40 "lang.vbs" diff --git a/dlls/vbscript/tests/run.c b/dlls/vbscript/tests/run.c index 6f1a967..b8cef40 100644 --- a/dlls/vbscript/tests/run.c +++ b/dlls/vbscript/tests/run.c @@ -60,10 +60,13 @@ DEFINE_EXPECT(global_success_d); DEFINE_EXPECT(global_success_i); #define DISPID_GLOBAL_REPORTSUCCESS 1000 +#define DISPID_GLOBAL_TRACE 1001 +#define DISPID_GLOBAL_OK 1002 static const WCHAR testW[] = {'t','e','s','t',0}; static BOOL strict_dispid_check; +static const char *test_name = "(null)"; static BSTR a2bstr(const char *str) { @@ -183,6 +186,16 @@ static HRESULT WINAPI DispatchEx_GetNameSpaceParent(IDispatchEx *iface, IUnknown static HRESULT WINAPI Global_GetDispID(IDispatchEx *iface, BSTR bstrName, DWORD grfdex, DISPID *pid) { + if(!strcmp_wa(bstrName, "ok")) { + test_grfdex(grfdex, fdexNameCaseInsensitive); + *pid = DISPID_GLOBAL_OK; + return S_OK; + } + if(!strcmp_wa(bstrName, "trace")) { + test_grfdex(grfdex, fdexNameCaseInsensitive); + *pid = DISPID_GLOBAL_TRACE; + return S_OK; + } if(!strcmp_wa(bstrName, "reportSuccess")) { CHECK_EXPECT(global_success_d); test_grfdex(grfdex, fdexNameCaseInsensitive); @@ -199,6 +212,48 @@ static HRESULT WINAPI Global_InvokeEx(IDispatchEx *iface, DISPID id, LCID lcid, VARIANT *pvarRes, EXCEPINFO *pei, IServiceProvider *pspCaller) { switch(id) { + case DISPID_GLOBAL_OK: { + VARIANT *b; + + ok(wFlags == INVOKE_FUNC || wFlags == (INVOKE_FUNC|INVOKE_PROPERTYGET), "wFlags = %x\n", wFlags); + ok(pdp != NULL, "pdp == NULL\n"); + ok(pdp->rgvarg != NULL, "rgvarg == NULL\n"); + ok(!pdp->rgdispidNamedArgs, "rgdispidNamedArgs != NULL\n"); + ok(pdp->cArgs == 2, "cArgs = %d\n", pdp->cArgs); + ok(!pdp->cNamedArgs, "cNamedArgs = %d\n", pdp->cNamedArgs); + if(wFlags & INVOKE_PROPERTYGET) + ok(pvarRes != NULL, "pvarRes == NULL\n"); + else + ok(!pvarRes, "pvarRes != NULL\n"); + ok(pei != NULL, "pei == NULL\n"); + + ok(V_VT(pdp->rgvarg) == VT_BSTR, "V_VT(psp->rgvargs) = %d\n", V_VT(pdp->rgvarg)); + + b = pdp->rgvarg+1; + if(V_VT(b) == (VT_BYREF|VT_VARIANT)) + b = V_BYREF(b); + + ok(V_VT(b) == VT_BOOL, "V_VT(b) = %d\n", V_VT(b)); + + ok(V_BOOL(b), "%s: %s\n", test_name, wine_dbgstr_w(V_BSTR(pdp->rgvarg))); + return S_OK; + } + + case DISPID_GLOBAL_TRACE: + ok(wFlags == INVOKE_FUNC, "wFlags = %x\n", wFlags); + ok(pdp != NULL, "pdp == NULL\n"); + ok(pdp->rgvarg != NULL, "rgvarg == NULL\n"); + ok(!pdp->rgdispidNamedArgs, "rgdispidNamedArgs != NULL\n"); + ok(pdp->cArgs == 1, "cArgs = %d\n", pdp->cArgs); + ok(!pdp->cNamedArgs, "cNamedArgs = %d\n", pdp->cNamedArgs); + ok(!pvarRes, "pvarRes != NULL\n"); + ok(pei != NULL, "pei == NULL\n"); + + ok(V_VT(pdp->rgvarg) == VT_BSTR, "V_VT(psp->rgvargs) = %d\n", V_VT(pdp->rgvarg)); + if(V_VT(pdp->rgvarg) == VT_BSTR) + trace("%s: %s\n", test_name, wine_dbgstr_w(V_BSTR(pdp->rgvarg))); + + return S_OK; case DISPID_GLOBAL_REPORTSUCCESS: CHECK_EXPECT(global_success_i); @@ -457,6 +512,37 @@ static void run_from_file(const char *filename) ok(hres == S_OK, "parse_script failed: %08x\n", hres); } +static void run_from_res(const char *name) +{ + const char *data; + DWORD size, len; + BSTR str; + HRSRC src; + HRESULT hres; + + strict_dispid_check = FALSE; + test_name = name; + + src = FindResourceA(NULL, name, (LPCSTR)40); + ok(src != NULL, "Could not find resource %s\n", name); + + size = SizeofResource(NULL, src); + data = LoadResource(NULL, src); + + len = MultiByteToWideChar(CP_ACP, 0, data, size, NULL, 0); + str = SysAllocStringLen(NULL, len); + MultiByteToWideChar(CP_ACP, 0, data, size, str, len); + + SET_EXPECT(global_success_d); + SET_EXPECT(global_success_i); + hres = parse_script(SCRIPTITEM_GLOBALMEMBERS, str); + CHECK_CALLED(global_success_d); + CHECK_CALLED(global_success_i); + + ok(hres == S_OK, "parse_script failed: %08x\n", hres); + SysFreeString(str); +} + static void run_tests(void) { strict_dispid_check = TRUE; @@ -481,6 +567,8 @@ static void run_tests(void) parse_script_a("Call reportSuccess"); CHECK_CALLED(global_success_d); CHECK_CALLED(global_success_i); + + run_from_res("lang.vbs"); } static BOOL check_vbscript(void)

1 0

Jörg Höhle : mmdevapi: Use UINT32 for a number of frames and UINT64 to sum them.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 08dd823c7c12c4f4a97731c09dae8c9a9c634ac0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=08dd823c7c12c4f4a97731c09… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Tue Aug 16 19:53:35 2011 +0200 mmdevapi: Use UINT32 for a number of frames and UINT64 to sum them. --- dlls/winealsa.drv/mmdevdrv.c | 4 ++-- dlls/winecoreaudio.drv/mmdevdrv.c | 4 ++-- dlls/wineoss.drv/mmdevdrv.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c index e471e2c..836d444 100644 --- a/dlls/winealsa.drv/mmdevdrv.c +++ b/dlls/winealsa.drv/mmdevdrv.c @@ -108,8 +108,8 @@ struct ACImpl { float *vols; BOOL initted, started; - UINT64 written_frames, held_frames, tmp_buffer_frames; - UINT32 bufsize_frames, period_us; + UINT64 written_frames; + UINT32 bufsize_frames, held_frames, tmp_buffer_frames, period_us; UINT32 lcl_offs_frames; /* offs into local_buffer where valid data starts */ HANDLE timer; diff --git a/dlls/winecoreaudio.drv/mmdevdrv.c b/dlls/winecoreaudio.drv/mmdevdrv.c index 78daa8c..c1a3a3a 100644 --- a/dlls/winecoreaudio.drv/mmdevdrv.c +++ b/dlls/winecoreaudio.drv/mmdevdrv.c @@ -124,8 +124,8 @@ struct ACImpl { AudioQueueRef aqueue; AudioObjectPropertyScope scope; HANDLE timer; - UINT32 period_ms, bufsize_frames, inbuf_frames, written_frames; - UINT64 last_time; + UINT32 period_ms, bufsize_frames, inbuf_frames; + UINT64 last_time, written_frames; AudioQueueBufferRef public_buffer; UINT32 getbuf_last; int playing; diff --git a/dlls/wineoss.drv/mmdevdrv.c b/dlls/wineoss.drv/mmdevdrv.c index ed3e2ba..93f71cc 100644 --- a/dlls/wineoss.drv/mmdevdrv.c +++ b/dlls/wineoss.drv/mmdevdrv.c @@ -121,8 +121,8 @@ struct ACImpl { oss_audioinfo ai; BOOL initted, playing; - UINT64 written_frames, held_frames, tmp_buffer_frames, inbuf_frames; - UINT32 period_us, bufsize_frames; + UINT64 written_frames; + UINT32 period_us, bufsize_frames, held_frames, tmp_buffer_frames, inbuf_frames; UINT32 lcl_offs_frames; /* offs into local_buffer where valid data starts */ BYTE *local_buffer, *tmp_buffer;

1 0

Jörg Höhle : winealsa: Recommend Pulse users to upgrade to handle_underrun.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 9c75a6aae5518357df464db7c352b27010dafff4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9c75a6aae5518357df464db7c… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Tue Aug 23 23:07:54 2011 +0200 winealsa: Recommend Pulse users to upgrade to handle_underrun. --- dlls/winealsa.drv/mmdevdrv.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c index 836d444..916c247 100644 --- a/dlls/winealsa.drv/mmdevdrv.c +++ b/dlls/winealsa.drv/mmdevdrv.c @@ -47,6 +47,7 @@ #include <alsa/asoundlib.h> WINE_DEFAULT_DEBUG_CHANNEL(alsa); +WINE_DECLARE_DEBUG_CHANNEL(winediag); #define NULL_PTR_ERR MAKE_HRESULT(SEVERITY_ERROR, FACILITY_WIN32, RPC_X_NULL_REF_POINTER) @@ -540,8 +541,11 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(const char *key, IMMDevice *dev, TRACE("Opening PCM device \"%s\" with handle_underrun: %d\n", key, err); snd_config_delete(lconf); /* Pulse <= 2010 returns EINVAL, it does not know handle_underrun. */ - if(err == -EINVAL) + if(err == -EINVAL){ + ERR_(winediag)("PulseAudio \"%s\" %d without handle_underrun. Audio may hang." + " Please upgrade to alsa_plugins >= 1.0.24\n", key, err); handle_underrun = 0; + } }else err = -EINVAL; if(err == -EINVAL){

1 0

Aurimas Fišeras : po: Update Lithuanian translation.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 0032de57f7e0b4f2d4c437c608330cb81d053abd URL: http://source.winehq.org/git/wine.git/?a=commit;h=0032de57f7e0b4f2d4c437c60… Author: Aurimas Fišeras <aurimas(a)gmail.com> Date: Thu Sep 8 19:21:55 2011 +0300 po: Update Lithuanian translation. --- po/lt.po | 124 ++++++++++++++++++++++++++++++-------------------------------- 1 files changed, 60 insertions(+), 64 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=0032de57f7e0b4f2d4c43…

1 0

Francois Gouget : services: Issue a fixme when a service fails to start.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: d49473335390718e461041ee16a3d9b04302ea0f URL: http://source.winehq.org/git/wine.git/?a=commit;h=d49473335390718e461041ee1… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Sep 1 16:06:20 2011 +0200 services: Issue a fixme when a service fails to start. --- programs/services/services.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/programs/services/services.c b/programs/services/services.c index 742f17d..2aa3683 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -295,7 +295,9 @@ static void scmdatabase_autostart_services(struct scmdatabase *db) argv[0] = service->name; argv[1] = NULL; err = service_start(service, 1, argv); - /* FIXME: do something if the service failed to start */ + if (err != ERROR_SUCCESS) + WINE_FIXME("Auto-start service %s failed to start: %d\n", + wine_dbgstr_w(service->name), err); release_service(service); }

1 0

Louis Lenders : dpnet/tests: Add tests for IDirectPlay8Peer_EnumServiceProviders.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 7844535700a65a2852a7b365e71c3c7a9950cdbe URL: http://source.winehq.org/git/wine.git/?a=commit;h=7844535700a65a2852a7b365e… Author: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Date: Mon Aug 29 22:56:35 2011 +0200 dpnet/tests: Add tests for IDirectPlay8Peer_EnumServiceProviders. --- configure | 1 + configure.ac | 1 + dlls/dpnet/tests/Makefile.in | 7 ++ dlls/dpnet/tests/peer.c | 135 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 144 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0379352..caef433 100755 --- a/configure +++ b/configure @@ -14800,6 +14800,7 @@ wine_fn_config_dll dplayx enable_dplayx implib wine_fn_config_test dlls/dplayx/tests dplayx_test wine_fn_config_dll dpnaddr enable_dpnaddr wine_fn_config_dll dpnet enable_dpnet implib +wine_fn_config_test dlls/dpnet/tests dpnet_test wine_fn_config_dll dpnhpast enable_dpnhpast wine_fn_config_dll dpnlobby enable_dpnlobby wine_fn_config_dll dpwsockx enable_dpwsockx diff --git a/configure.ac b/configure.ac index 40ea431..e12fb37 100644 --- a/configure.ac +++ b/configure.ac @@ -2493,6 +2493,7 @@ WINE_CONFIG_DLL(dplayx,,[implib]) WINE_CONFIG_TEST(dlls/dplayx/tests) WINE_CONFIG_DLL(dpnaddr) WINE_CONFIG_DLL(dpnet,,[implib]) +WINE_CONFIG_TEST(dlls/dpnet/tests) WINE_CONFIG_DLL(dpnhpast) WINE_CONFIG_DLL(dpnlobby) WINE_CONFIG_DLL(dpwsockx) diff --git a/dlls/dpnet/tests/Makefile.in b/dlls/dpnet/tests/Makefile.in new file mode 100644 index 0000000..58d5c94 --- /dev/null +++ b/dlls/dpnet/tests/Makefile.in @@ -0,0 +1,7 @@ +TESTDLL = dpnet.dll +IMPORTS = dpnet ole32 + +C_SRCS = \ + peer.c + +(a)MAKE_TEST_RULES@ diff --git a/dlls/dpnet/tests/peer.c b/dlls/dpnet/tests/peer.c new file mode 100644 index 0000000..afbea42 --- /dev/null +++ b/dlls/dpnet/tests/peer.c @@ -0,0 +1,135 @@ +/* + * Copyright 2011 Louis Lenders + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#define INITGUID +#define WIN32_LEAN_AND_MEAN +#include <stdio.h> + +#include <dplay8.h> +#include "wine/test.h" + +static char *show_guid(const GUID *guid, char *buf) +{ + sprintf(buf, + "{%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}", + guid->Data1, guid->Data2, guid->Data3, + guid->Data4[0], guid->Data4[1], guid->Data4[2], guid->Data4[3], + guid->Data4[4], guid->Data4[5], guid->Data4[6], guid->Data4[7]); + + return buf; +} + +static IDirectPlay8Peer* peer = NULL; + +static HRESULT WINAPI DirectPlayMessageHandler(PVOID context, DWORD message_id, PVOID buffer) +{ + return S_OK; +} + +static void test_init_dp(void) +{ + HRESULT hr; + + hr = CoInitialize(0); + ok(hr == S_OK, "CoInitialize failed with %x\n", hr); + + hr = CoCreateInstance(&CLSID_DirectPlay8Peer, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Peer, (void **)&peer); + ok(hr == S_OK, "CoCreateInstance failed with 0x%x\n", hr); + + hr = IDirectPlay8Peer_Initialize(peer, NULL, DirectPlayMessageHandler, 0); + todo_wine ok(hr == S_OK, "IDirectPlay8Peer_Initialize failed with %x\n", hr); +} + +static void test_enum_service_providers(void) +{ + DPN_SERVICE_PROVIDER_INFO *serv_prov_info; + DWORD items, size; + DWORD i; + HRESULT hr; + char guid[39] ; + + size = 0; + items = 0; + + hr = IDirectPlay8Peer_EnumServiceProviders(peer, NULL, NULL, NULL, &size, &items, 0); + todo_wine ok(hr == DPNERR_BUFFERTOOSMALL, "IDirectPlay8Peer_EnumServiceProviders failed with %x\n", hr); + todo_wine ok(size != 0, "size is unexpectedly 0\n"); + + serv_prov_info = (DPN_SERVICE_PROVIDER_INFO*) HeapAlloc(GetProcessHeap(), 0, size); + + hr = IDirectPlay8Peer_EnumServiceProviders(peer, NULL, NULL, serv_prov_info, &size, &items, 0); + todo_wine ok(hr == S_OK, "IDirectPlay8Peer_EnumServiceProviders failed with %x\n", hr); + todo_wine ok(items != 0, "Found unexpectedly no service providers\n"); + + trace("number of items found: %d\n", items); + + for (i=0;i<items;i++) + { + trace("Found Service Provider: %s\n", wine_dbgstr_w(serv_prov_info->pwszName)); + trace("Found guid: %s\n", show_guid(&serv_prov_info->guid, guid)); + + serv_prov_info++; + } + + serv_prov_info -= items; /* set pointer back */ + ok(HeapFree(GetProcessHeap(), 0, serv_prov_info), "Failed freeing server provider info\n"); + + size = 0; + items = 0; + + hr = IDirectPlay8Peer_EnumServiceProviders(peer, &CLSID_DP8SP_TCPIP, NULL, NULL, &size, &items, 0); + todo_wine ok(hr == DPNERR_BUFFERTOOSMALL, "IDirectPlay8Peer_EnumServiceProviders failed with %x\n", hr); + todo_wine ok(size != 0, "size is unexpectedly 0\n"); + + serv_prov_info = (DPN_SERVICE_PROVIDER_INFO*) HeapAlloc(GetProcessHeap(), 0, size); + + hr = IDirectPlay8Peer_EnumServiceProviders(peer, &CLSID_DP8SP_TCPIP, NULL, serv_prov_info, &size, &items, 0); + todo_wine ok(hr == S_OK, "IDirectPlay8Peer_EnumServiceProviders failed with %x\n", hr); + todo_wine ok(items != 0, "Found unexpectedly no adapter\n"); + + for (i=0;i<items;i++) + { + trace("Found adapter: %s\n", wine_dbgstr_w(serv_prov_info->pwszName)); + trace("Found adapter guid: %s\n", show_guid(&serv_prov_info->guid, guid)); + + serv_prov_info++; + } + + serv_prov_info -= items; /* set pointer back */ + ok(HeapFree(GetProcessHeap(), 0, serv_prov_info), "Failed freeing server provider info\n"); +} + +static void test_cleanup_dp(void) +{ + HRESULT hr; + + hr = IDirectPlay8Peer_Close(peer, 0); + ok(hr == S_OK, "IDirectPlay8Peer_Close failed with %x\n", hr); + + hr = IDirectPlay8Peer_Release(peer); + ok(hr == S_OK, "IDirectPlay8Peer_Release failed with %x\n", hr); + + CoUninitialize(); +} + +START_TEST(peer) +{ + test_init_dp(); + test_enum_service_providers(); + test_cleanup_dp(); +}

1 0

Alexander Morozov : query: Add stub for LoadIFilter.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: ba6f99c239bfd7264f868702875dd9597b022be8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ba6f99c239bfd7264f8687028… Author: Alexander Morozov <amorozov(a)etersoft.ru> Date: Fri Aug 19 15:16:33 2011 +0400 query: Add stub for LoadIFilter. --- dlls/query/query.spec | 2 +- dlls/query/query_main.c | 7 +++++++ dlls/shell32/recyclebin.c | 2 +- include/ntquery.h | 1 + 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/dlls/query/query.spec b/dlls/query/query.spec index 612ea2d..71b9874 100644 --- a/dlls/query/query.spec +++ b/dlls/query/query.spec @@ -33,7 +33,7 @@ @ stub InitializeFILTERPerformanceData @ stub _LoadBHIFilter(a)16 @ stub LoadBinaryFilter -@ stub LoadIFilter +@ stdcall LoadIFilter(wstr ptr ptr) @ stub LoadTextFilter @ stub LocateCatalogs @ stdcall LocateCatalogsA(str long ptr ptr ptr ptr) diff --git a/dlls/query/query_main.c b/dlls/query/query_main.c index 2d4e4ae..3414aec 100644 --- a/dlls/query/query_main.c +++ b/dlls/query/query_main.c @@ -98,3 +98,10 @@ HRESULT WINAPI LocateCatalogsW(WCHAR const *pwszScope, ULONG iBm, iBm, pwszMachine, pcMachine, pwszCat, pcCat); return CI_E_NOT_RUNNING; } + +HRESULT WINAPI LoadIFilter(WCHAR const *pwcsPath, IUnknown *pUnkOuter, void **ppIUnk) +{ + FIXME("%s %p %p\n", debugstr_w(pwcsPath), pUnkOuter, ppIUnk); + *ppIUnk = NULL; + return E_NOTIMPL; +} diff --git a/dlls/shell32/recyclebin.c b/dlls/shell32/recyclebin.c index eec9e00..4a8cec4 100644 --- a/dlls/shell32/recyclebin.c +++ b/dlls/shell32/recyclebin.c @@ -31,8 +31,8 @@ #include "winbase.h" #include "winreg.h" #include "winuser.h" -#include "ntquery.h" #include "shlwapi.h" +#include "ntquery.h" #include "shlobj.h" #include "shresdef.h" #include "shellfolder.h" diff --git a/include/ntquery.h b/include/ntquery.h index fc78c32..928dafc 100644 --- a/include/ntquery.h +++ b/include/ntquery.h @@ -74,6 +74,7 @@ STDAPI CIState(WCHAR const *, WCHAR const *, CI_STATE *); STDAPI LocateCatalogsA(CHAR const *, ULONG, CHAR *, ULONG *, CHAR *, ULONG *); STDAPI LocateCatalogsW(WCHAR const *, ULONG, WCHAR *, ULONG *, WCHAR *, ULONG *); #define LocateCatalogs WINELIB_NAME_AW(LocateCatalogs) +STDAPI LoadIFilter(WCHAR const *, IUnknown *, void **); #ifdef __cplusplus }

1 0

Francois Gouget : ddraw: Remove WINAPI on static functions where not needed .
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 489527fe44e5f61e974d7563892fce8a98e81a11 URL: http://source.winehq.org/git/wine.git/?a=commit;h=489527fe44e5f61e974d75638… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Sep 8 11:01:41 2011 +0200 ddraw: Remove WINAPI on static functions where not needed. --- dlls/ddraw/surface.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 081d4e1..d70e355 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -875,7 +875,7 @@ static HRESULT WINAPI ddraw_surface1_GetAttachedSurface(IDirectDrawSurface *ifac * For more details, see IWineD3DSurface::LockRect * *****************************************************************************/ -static HRESULT WINAPI surface_lock(IDirectDrawSurfaceImpl *This, +static HRESULT surface_lock(IDirectDrawSurfaceImpl *This, RECT *Rect, DDSURFACEDESC2 *DDSD, DWORD Flags, HANDLE h) { WINED3DLOCKED_RECT LockedRect;

1 0

Frédéric Delanoy : cmd: Fix misleading WCMD_parameter documentation.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 40c6ff8abe8e48d59516e83f306b581bbb5121cf URL: http://source.winehq.org/git/wine.git/?a=commit;h=40c6ff8abe8e48d59516e83f3… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Sep 6 19:19:40 2011 +0200 cmd: Fix misleading WCMD_parameter documentation. --- programs/cmd/batch.c | 26 +++++++++++++++++++++----- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/programs/cmd/batch.c b/programs/cmd/batch.c index f010f28..a978ef1 100644 --- a/programs/cmd/batch.c +++ b/programs/cmd/batch.c @@ -113,12 +113,28 @@ void WCMD_batch (WCHAR *file, WCHAR *command, int called, WCHAR *startLabel, HAN } /******************************************************************* - * WCMD_parameter - extract a parameter from a command line. + * WCMD_parameter * - * Returns the 'n'th delimited parameter on the command line (zero-based). - * Parameter is in static storage overwritten on the next call. - * Parameters in quotes (and brackets) are handled. - * Also returns a pointer to the location of the parameter in the command line. + * Extracts a delimited parameter from an input string + * + * PARAMS + * s [I] input string, non NULL + * n [I] # of the (possibly double quotes-delimited) parameter to return + * Starts at 0 + * where [O] if non NULL, pointer to the start of the nth parameter in s, + * potentially a " character + * + * RETURNS + * Success: Returns the nth delimited parameter found in s. + * *where points to the start of the param, possibly a starting + * double quotes character + * Failure: Returns an empty string if the param is not found. + * *where is set to NULL + * + * NOTES + * Return value is stored in static storage, hence is overwritten + * after each call. + * Doesn't include any potentially delimiting double quotes */ WCHAR *WCMD_parameter (WCHAR *s, int n, WCHAR **where) {

1 0

Frédéric Delanoy : cmd: Simplify WCMD_parameter function.
by Alexandre Julliard 08 Sep '11

08 Sep '11

Module: wine Branch: master Commit: 7b9af2268226665252c7c447d5ce47480efe5e65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7b9af2268226665252c7c447d… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Sep 6 19:19:41 2011 +0200 cmd: Simplify WCMD_parameter function. --- programs/cmd/batch.c | 78 ++++++++++++++++++-------------------------------- 1 files changed, 28 insertions(+), 50 deletions(-) diff --git a/programs/cmd/batch.c b/programs/cmd/batch.c index a978ef1..53330ff 100644 --- a/programs/cmd/batch.c +++ b/programs/cmd/batch.c @@ -138,59 +138,37 @@ void WCMD_batch (WCHAR *file, WCHAR *command, int called, WCHAR *startLabel, HAN */ WCHAR *WCMD_parameter (WCHAR *s, int n, WCHAR **where) { - - int i = 0; - static WCHAR param[MAX_PATH]; - WCHAR *p; - - if (where != NULL) *where = NULL; - p = param; - while (TRUE) { - switch (*s) { - case ' ': /* Skip leading spaces */ - case '\t': /* Treat tabs as spaces */ - s++; - break; - case '"': - if (where != NULL && i==n) *where = s; - s++; - while ((*s != '\0') && (*s != '"')) { - *p++ = *s++; - } - if (i == n) { - *p = '\0'; - return param; - } - if (*s == '"') s++; - param[0] = '\0'; - i++; - p = param; - break; - /* The code to handle bracketed parms is removed because it should no longer - be necessary after the multiline support has been added and the for loop - set of data is now parseable individually. */ - case '\0': - return param; - default: - /* Only return where if it is for the right parameter */ - if (where != NULL && i==n) *where = s; - while ((*s != '\0') && (*s != ' ') && (*s != ',') && (*s != '=') && (*s != '\t')) { - *p++ = *s++; - } - if (i == n && (p!=param)) { - *p = '\0'; - return param; - } - /* Skip double delimiters, eg. dir a.a,,,,,b.b */ - if (p != param) { - param[0] = '\0'; - i++; + int curParamNb = 0; + static WCHAR param[MAX_PATH]; + WCHAR *p = s, *q; + BOOL quotesDelimited; + + if (where != NULL) *where = NULL; + param[0] = '\0'; + while (TRUE) { + while (*p && ((*p == ' ') || (*p == ',') || (*p == '=') || (*p == '\t'))) + p++; + if (*p == '\0') return param; + + quotesDelimited = (*p == '"'); + if (where != NULL && curParamNb == n) *where = p; + + if (quotesDelimited) { + q = ++p; + while (*p && *p != '"') p++; } else { - s++; /* Skip delimiter */ + q = p; + while (*p && (*p != ' ') && (*p != ',') && (*p != '=') && (*p != '\t')) + p++; } - p = param; + if (curParamNb == n) { + memcpy(param, q, (p - q) * sizeof(WCHAR)); + param[p-q] = '\0'; + return param; + } + if (quotesDelimited && *p == '"') p++; + curParamNb++; } - } } /****************************************************************************

1 0