January 2012 - Wine-commits

Aric Stewart : strmbase: Do not hold the csReceive lock when calling the transform' s Receive function.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: e2200b31d6d61f83b55e8062c13d7c5c52ed3538 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e2200b31d6d61f83b55e8062c… Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Jan 23 08:33:02 2012 -0600 strmbase: Do not hold the csReceive lock when calling the transform's Receive function. --- dlls/strmbase/transform.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/strmbase/transform.c b/dlls/strmbase/transform.c index b44becf..981a201 100644 --- a/dlls/strmbase/transform.c +++ b/dlls/strmbase/transform.c @@ -81,12 +81,12 @@ static HRESULT WINAPI TransformFilter_Input_Receive(BaseInputPin *This, IMediaSa return S_FALSE; } + LeaveCriticalSection(&pTransform->csReceive); if (pTransform->pFuncsTable->pfnReceive) hr = pTransform->pFuncsTable->pfnReceive(pTransform, pInSample); else hr = S_FALSE; - LeaveCriticalSection(&pTransform->csReceive); return hr; }

1 0

Aric Stewart : quartz: Use the csReceive critical sections in transform filters.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: da0650a20999c75935b44480cf555697d6d50177 URL: http://source.winehq.org/git/wine.git/?a=commit;h=da0650a20999c75935b44480c… Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Jan 23 08:33:22 2012 -0600 quartz: Use the csReceive critical sections in transform filters. --- dlls/quartz/acmwrapper.c | 14 +++++++------- dlls/quartz/avidec.c | 9 ++++----- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/dlls/quartz/acmwrapper.c b/dlls/quartz/acmwrapper.c index 814bf84..1c840b7 100644 --- a/dlls/quartz/acmwrapper.c +++ b/dlls/quartz/acmwrapper.c @@ -69,12 +69,12 @@ static HRESULT WINAPI ACMWrapper_Receive(TransformFilter *tf, IMediaSample *pSam LONGLONG tStart = -1, tStop = -1, tMed; LONGLONG mtStart = -1, mtStop = -1, mtMed; - EnterCriticalSection(&This->tf.filter.csFilter); + EnterCriticalSection(&This->tf.csReceive); hr = IMediaSample_GetPointer(pSample, &pbSrcStream); if (FAILED(hr)) { ERR("Cannot get pointer to sample data (%x)\n", hr); - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); return hr; } @@ -105,7 +105,7 @@ static HRESULT WINAPI ACMWrapper_Receive(TransformFilter *tf, IMediaSample *pSam if (FAILED(hr)) { ERR("Unable to retrieve media type\n"); - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); return hr; } @@ -118,7 +118,7 @@ static HRESULT WINAPI ACMWrapper_Receive(TransformFilter *tf, IMediaSample *pSam if (FAILED(hr)) { ERR("Unable to get delivery buffer (%x)\n", hr); - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); return hr; } IMediaSample_SetPreroll(pOutSample, preroll); @@ -213,9 +213,9 @@ static HRESULT WINAPI ACMWrapper_Receive(TransformFilter *tf, IMediaSample *pSam TRACE("Sample stop time: %u.%03u\n", (DWORD)(tStart/10000000), (DWORD)((tStart/10000)%1000)); - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); hr = BaseOutputPinImpl_Deliver((BaseOutputPin*)This->tf.ppPins[1], pOutSample); - EnterCriticalSection(&This->tf.filter.csFilter); + EnterCriticalSection(&This->tf.csReceive); if (hr != S_OK && hr != VFW_E_NOT_CONNECTED) { if (FAILED(hr)) @@ -238,7 +238,7 @@ error: This->lasttime_real = tStop; This->lasttime_sent = tMed; - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); return hr; } diff --git a/dlls/quartz/avidec.c b/dlls/quartz/avidec.c index e7e1de7..011e5ff 100644 --- a/dlls/quartz/avidec.c +++ b/dlls/quartz/avidec.c @@ -114,7 +114,7 @@ static HRESULT WINAPI AVIDec_Receive(TransformFilter *tf, IMediaSample *pSample) LONGLONG tStart, tStop; DWORD flags = 0; - EnterCriticalSection(&This->tf.filter.csFilter); + EnterCriticalSection(&This->tf.csReceive); hr = IMediaSample_GetPointer(pSample, &pbSrcStream); if (FAILED(hr)) { @@ -192,18 +192,17 @@ static HRESULT WINAPI AVIDec_Receive(TransformFilter *tf, IMediaSample *pSample) else IMediaSample_SetMediaTime(pOutSample, NULL, NULL); - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); hr = BaseOutputPinImpl_Deliver((BaseOutputPin*)This->tf.ppPins[1], pOutSample); + EnterCriticalSection(&This->tf.csReceive); if (hr != S_OK && hr != VFW_E_NOT_CONNECTED) ERR("Error sending sample (%x)\n", hr); - IMediaSample_Release(pOutSample); - return hr; error: if (pOutSample) IMediaSample_Release(pOutSample); - LeaveCriticalSection(&This->tf.filter.csFilter); + LeaveCriticalSection(&This->tf.csReceive); return hr; }

1 0

Aric Stewart : wineqtdecoder: Release the csReceive critical section before delivering a sample.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: 7d9ce823c3d668ca226df3ba9206aaadbf564a88 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7d9ce823c3d668ca226df3ba9… Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Jan 23 08:43:53 2012 -0600 wineqtdecoder: Release the csReceive critical section before delivering a sample. --- dlls/wineqtdecoder/qtvdecoder.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/wineqtdecoder/qtvdecoder.c b/dlls/wineqtdecoder/qtvdecoder.c index 79e06a5..8a41722 100644 --- a/dlls/wineqtdecoder/qtvdecoder.c +++ b/dlls/wineqtdecoder/qtvdecoder.c @@ -230,7 +230,9 @@ static void trackingCallback( IMediaSample_SetTime(pOutSample, &tStart, &tStop); } + LeaveCriticalSection(&This->tf.csReceive); hr = BaseOutputPinImpl_Deliver((BaseOutputPin*)This->tf.ppPins[1], pOutSample); + EnterCriticalSection(&This->tf.csReceive); if (hr != S_OK && hr != VFW_E_NOT_CONNECTED) ERR("Error sending sample (%x)\n", hr);

1 0

Alex Henrie : comdlg32: Correctly handle filters with multiple file extensions in Save As dialogs.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: 7a34094e6e3e8a321148c64b0c9e2b986e63a7d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7a34094e6e3e8a321148c64b0… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Fri Jan 20 14:52:18 2012 -0700 comdlg32: Correctly handle filters with multiple file extensions in Save As dialogs. --- dlls/comdlg32/filedlg.c | 61 ++++++++++++++++++++--------- dlls/comdlg32/tests/filedlg.c | 85 ++++++++++++++++++++++++++++++----------- 2 files changed, 104 insertions(+), 42 deletions(-) diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c index 43df312..c31641b 100644 --- a/dlls/comdlg32/filedlg.c +++ b/dlls/comdlg32/filedlg.c @@ -2533,12 +2533,12 @@ BOOL FILEDLG95_OnOpen(HWND hwnd) /* Attach the file extension with file name*/ ext = PathFindExtensionW(lpstrPathAndFile); - if (! *ext) + if (! *ext && fodInfos->defext) { /* if no extension is specified with file name, then */ /* attach the extension from file filter or default one */ - const WCHAR *filterExt = NULL; + WCHAR *filterExt = NULL; LPWSTR lpstrFilter = NULL; static const WCHAR szwDot[] = {'.',0}; int PathLength = lstrlenW(lpstrPathAndFile); @@ -2548,15 +2548,39 @@ BOOL FILEDLG95_OnOpen(HWND hwnd) fodInfos->ofnInfos->nFilterIndex-1); if (lpstrFilter != (LPWSTR)CB_ERR) /* control is not empty */ - filterExt = PathFindExtensionW(lpstrFilter); + { + WCHAR* filterAtSemicolon; + filterExt = HeapAlloc(GetProcessHeap(), 0, lstrlenW(lpstrFilter) * sizeof(WCHAR) + sizeof(WCHAR)); + strcpyW(filterExt, lpstrFilter); + + /* if a semicolon-separated list of file extensions was given, do not include the + semicolon or anything after it in the extension. + example: if filterExt was "*.abc;*.def", it will become "*.abc" */ + filterAtSemicolon = strchrW(filterExt, ';'); + if (filterAtSemicolon) + { + filterAtSemicolon[0] = '\0'; + } + + /* strip the * or anything else from the extension, "*.abc" becomes "abc" */ + strcpyW(filterExt, PathFindExtensionW(filterExt) + 1); + + /* if the extension contains a glob, ignore it */ + if (strchrW(filterExt, '*') || strchrW(filterExt, '?')) + { + HeapFree(GetProcessHeap(), 0, filterExt); + filterExt = NULL; + } + } - if ( filterExt && *filterExt ) /* attach the file extension from file type filter*/ - filterExt = filterExt + 1; - else if ( fodInfos->defext ) /* attach the default file extension*/ - filterExt = fodInfos->defext; + if (!filterExt) + { + /* use the default file extension */ + filterExt = HeapAlloc(GetProcessHeap(), 0, lstrlenW(fodInfos->defext) * sizeof(WCHAR) + sizeof(WCHAR)); + strcpyW(filterExt, fodInfos->defext); + } - /* If extension contains a glob, ignore it */ - if ( filterExt && !strchrW(filterExt, '*') && !strchrW(filterExt, '?') ) + if (*filterExt) /* ignore filterExt="" */ { /* Attach the dot*/ lstrcatW(lpstrPathAndFile, szwDot); @@ -2564,20 +2588,19 @@ BOOL FILEDLG95_OnOpen(HWND hwnd) lstrcatW(lpstrPathAndFile, filterExt ); } + HeapFree(GetProcessHeap(), 0, filterExt); + /* In Open dialog: if file does not exist try without extension */ if (!(fodInfos->DlgInfos.dwDlgProp & FODPROP_SAVEDLG) && !PathFileExistsW(lpstrPathAndFile)) lpstrPathAndFile[PathLength] = '\0'; - } - if (fodInfos->defext) /* add default extension */ - { - /* Set/clear the output OFN_EXTENSIONDIFFERENT flag */ - if (*ext) - ext++; - if (!lstrcmpiW(fodInfos->defext, ext)) - fodInfos->ofnInfos->Flags &= ~OFN_EXTENSIONDIFFERENT; - else - fodInfos->ofnInfos->Flags |= OFN_EXTENSIONDIFFERENT; + /* Set/clear the output OFN_EXTENSIONDIFFERENT flag */ + if (*ext) + ext++; + if (!lstrcmpiW(fodInfos->defext, ext)) + fodInfos->ofnInfos->Flags &= ~OFN_EXTENSIONDIFFERENT; + else + fodInfos->ofnInfos->Flags |= OFN_EXTENSIONDIFFERENT; } /* In Save dialog: check if the file already exists */ diff --git a/dlls/comdlg32/tests/filedlg.c b/dlls/comdlg32/tests/filedlg.c index 8539d3d..0d1112f 100644 --- a/dlls/comdlg32/tests/filedlg.c +++ b/dlls/comdlg32/tests/filedlg.c @@ -1044,51 +1044,90 @@ static UINT_PTR WINAPI test_extension_wndproc(HWND dlg, UINT msg, WPARAM wParam, return FALSE; } -static const char *defext_filters[] = { - "TestFilter (*.pt*)\0*.pt*\0", - "TestFilter (*.ab?)\0*.ab?\0", - "TestFilter (*.*)\0*.*\0", - NULL /* is a test, not an endmark! */ -}; - #define ARRAY_SIZE(a) (sizeof(a)/sizeof((a)[0])) +static void test_extension_helper(OPENFILENAME* ofn, const char *filter, + const char *expected_filename) +{ + char *filename_ptr; + DWORD ret; + BOOL boolret; + + strcpy(ofn->lpstrFile, "deadbeef"); + ofn->lpstrFilter = filter; + + boolret = GetSaveFileNameA(ofn); + ok(boolret, "%s: expected TRUE\n", filter); + + ret = CommDlgExtendedError(); + ok(!ret, "%s: CommDlgExtendedError returned %#x\n", filter, ret); + + filename_ptr = ofn->lpstrFile + ofn->nFileOffset; + ok(strcmp(filename_ptr, expected_filename) == 0, + "%s: Filename is %s, expected %s\n", filter, filename_ptr, expected_filename); +} + static void test_extension(void) { OPENFILENAME ofn = { sizeof(OPENFILENAME)}; char filename[1024] = {0}; char curdir[MAX_PATH]; - char *filename_ptr; - const char *test_file_name = "deadbeef"; unsigned int i; - DWORD ret; BOOL boolret; + const char *defext_concrete_filters[] = { + "TestFilter (*.abc)\0*.abc\0", + "TestFilter (*.abc;)\0*.abc;\0", + "TestFilter (*.abc;*.def)\0*.abc;*.def\0", + }; + + const char *defext_wildcard_filters[] = { + "TestFilter (*.pt*)\0*.pt*\0", + "TestFilter (*.pt*;*.abc)\0*.pt*;*.abc\0", + "TestFilter (*.ab?)\0*.ab?\0", + "TestFilter (*.*)\0*.*\0", + NULL /* is a test, not an endmark! */ + }; + boolret = GetCurrentDirectoryA(sizeof(curdir), curdir); ok(boolret, "Failed to get current dir err %d\n", GetLastError()); - /* Ignore .* extension */ ofn.lStructSize = sizeof(ofn); ofn.hwndOwner = NULL; ofn.lpstrFile = filename; ofn.nMaxFile = MAX_PATH; ofn.Flags = OFN_EXPLORER | OFN_ENABLEHOOK; - ofn.lpstrDefExt = NULL; ofn.lpstrInitialDir = curdir; ofn.lpfnHook = test_extension_wndproc; ofn.nFileExtension = 0; - for (i = 0; i < ARRAY_SIZE(defext_filters); i++) { - ofn.lpstrFilter = defext_filters[i]; - strcpy(filename, test_file_name); - boolret = GetSaveFileNameA(&ofn); - ok(boolret, "%u: expected true\n", i); - ret = CommDlgExtendedError(); - ok(!ret, "%u: CommDlgExtendedError returned %#x\n", i, ret); - filename_ptr = ofn.lpstrFile + strlen( ofn.lpstrFile ) - strlen( test_file_name ); - ok( strlen(ofn.lpstrFile) >= strlen(test_file_name), "Filename %s is too short\n", ofn.lpstrFile ); - ok( strcmp(filename_ptr, test_file_name) == 0, - "Filename is %s, expected %s\n", filename_ptr, test_file_name ); + ofn.lpstrDefExt = NULL; + + /* Without lpstrDefExt, append no extension */ + test_extension_helper(&ofn, "TestFilter (*.abc) lpstrDefExt=NULL\0*.abc\0", "deadbeef"); + test_extension_helper(&ofn, "TestFilter (*.ab?) lpstrDefExt=NULL\0*.ab?\0", "deadbeef"); + + ofn.lpstrDefExt = ""; + + /* If lpstrDefExt="" and the filter has a concrete extension, append it */ + test_extension_helper(&ofn, "TestFilter (*.abc) lpstrDefExt=\"\"\0*.abc\0", "deadbeef.abc"); + + /* If lpstrDefExt="" and the filter has a wildcard extension, do nothing */ + test_extension_helper(&ofn, "TestFilter (*.ab?) lpstrDefExt=\"\"\0*.ab?\0", "deadbeef"); + + ofn.lpstrDefExt = "xyz"; + + /* Append concrete extensions from filters */ + for (i = 0; i < ARRAY_SIZE(defext_concrete_filters); i++) { + test_extension_helper(&ofn, defext_concrete_filters[i], "deadbeef.abc"); + } + + /* Append nothing from this filter */ + test_extension_helper(&ofn, "TestFilter (*.)\0*.\0", "deadbeef"); + + /* Ignore wildcard extensions in filters */ + for (i = 0; i < ARRAY_SIZE(defext_wildcard_filters); i++) { + test_extension_helper(&ofn, defext_wildcard_filters[i], "deadbeef.xyz"); } }

1 0

Nikolay Sivov : msxml3: Allocate private data when cloning from existing document.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: 916de3998ed5b0f1a3c2f755776d455ae3cbd000 URL: http://source.winehq.org/git/wine.git/?a=commit;h=916de3998ed5b0f1a3c2f7557… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Jan 23 17:36:35 2012 +0300 msxml3: Allocate private data when cloning from existing document. --- dlls/msxml3/domdoc.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 72f9a31..517b581 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -2082,7 +2082,9 @@ static HRESULT WINAPI domdoc_load( if(pNewDoc) { domdoc *newDoc = impl_from_IXMLDOMDocument3( pNewDoc ); + xmldoc = xmlCopyDoc(get_doc(newDoc), 1); + xmldoc->_private = create_priv(); hr = attach_xmldoc(This, xmldoc); if(SUCCEEDED(hr)) @@ -3444,8 +3446,7 @@ HRESULT DOMDocument_create(MSXML_VERSION version, IUnknown *pUnkOuter, void **pp if(!xmldoc) return E_OUTOFMEMORY; - xmldoc->_private = create_priv(); - priv_from_xmlDocPtr(xmldoc)->properties = create_properties(version); + xmldoc_init(xmldoc, version); hr = get_domdoc_from_xmldoc(xmldoc, (IXMLDOMDocument3**)ppObj); if(FAILED(hr))

1 0

Eric Pouech : dbghelp: Rewrote a simple regular expression matcher, and use for implementing SymMatchString[AW].
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: be9a7b9b97b5e3a9223be232dfd52ce49c0ec26c URL: http://source.winehq.org/git/wine.git/?a=commit;h=be9a7b9b97b5e3a9223be232d… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sun Jan 22 12:57:53 2012 +0100 dbghelp: Rewrote a simple regular expression matcher, and use for implementing SymMatchString[AW]. --- dlls/dbghelp/symbol.c | 176 ++++++++++++++++++++++++++++++++++++++++++------- 1 files changed, 152 insertions(+), 24 deletions(-) diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index ac1824b..ed2ce01 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -1873,50 +1873,178 @@ DWORD WINAPI UnDecorateSymbolName(PCSTR DecoratedName, PSTR UnDecoratedName, return strlen(UnDecoratedName); } +#define WILDCHAR(x) (-(x)) + +static int re_fetch_char(const WCHAR** re) +{ + switch (**re) + { + case '\\': (*re)++; return *(*re)++; + case '*': case '[': case '?': case '+': case '#': case ']': return WILDCHAR(*(*re)++); + default: return *(*re)++; + } +} + +static inline int re_match_char(WCHAR ch1, WCHAR ch2, BOOL _case) +{ + return _case ? ch1 - ch2 : toupperW(ch1) - toupperW(ch2); +} + +static const WCHAR* re_match_one(const WCHAR* string, const WCHAR* elt, BOOL _case) +{ + int ch1, prev = 0; + unsigned state = 0; + + switch (ch1 = re_fetch_char(&elt)) + { + default: + return (ch1 >= 0 && re_match_char(*string, ch1, _case) == 0) ? ++string : NULL; + case WILDCHAR('?'): return *string ? ++string : NULL; + case WILDCHAR('*'): assert(0); + case WILDCHAR('['): break; + } + + for (;;) + { + ch1 = re_fetch_char(&elt); + if (ch1 == WILDCHAR(']')) return NULL; + if (state == 1 && ch1 == '-') state = 2; + else + { + if (re_match_char(*string, ch1, _case) == 0) return ++string; + switch (state) + { + case 0: + state = 1; + prev = ch1; + break; + case 1: + state = 0; + break; + case 2: + if (prev >= 0 && ch1 >= 0 && re_match_char(prev, *string, _case) <= 0 && + re_match_char(*string, ch1, _case) <= 0) + return ++string; + state = 0; + break; + } + } + } +} + +/****************************************************************** + * re_match_multi + * + * match a substring of *pstring according to *pre regular expression + * pstring and pre are only updated in case of successful match + */ +static BOOL re_match_multi(const WCHAR** pstring, const WCHAR** pre, BOOL _case) +{ + const WCHAR* re_end = *pre; + const WCHAR* string_end = *pstring; + const WCHAR* re_beg; + const WCHAR* string_beg; + const WCHAR* next; + int ch; + + while (*re_end && *string_end) + { + string_beg = string_end; + re_beg = re_end; + switch (ch = re_fetch_char(&re_end)) + { + case WILDCHAR(']'): case WILDCHAR('+'): case WILDCHAR('#'): return FALSE; + case WILDCHAR('*'): + /* transform '*' into '?#' */ + {static const WCHAR qmW[] = {'?',0}; re_beg = qmW;} + goto closure; + case WILDCHAR('['): + do + { + if (!(ch = re_fetch_char(&re_end))) return FALSE; + } while (ch != WILDCHAR(']')); + /* fall through */ + case WILDCHAR('?'): + default: + break; + } + + switch (*re_end) + { + case '+': + if (!(next = re_match_one(string_end, re_beg, _case))) return FALSE; + string_beg++; + /* fall through */ + case '#': + re_end++; + closure: + while ((next = re_match_one(string_end, re_beg, _case))) string_end = next; + for ( ; string_end >= string_beg; string_end--) + { + if (re_match_multi(&string_end, &re_end, _case)) goto found; + } + return FALSE; + default: + if (!(next = re_match_one(string_end, re_beg, _case))) return FALSE; + string_end = next; + } + re_beg = re_end; + } + + if (*re_end || *string_end) return FALSE; + +found: + *pre = re_end; + *pstring = string_end; + return TRUE; +} + /****************************************************************** * SymMatchStringA (DBGHELP.@) * */ BOOL WINAPI SymMatchStringA(PCSTR string, PCSTR re, BOOL _case) { - regex_t preg; - BOOL ret; + WCHAR* strW; + WCHAR* reW; + BOOL ret = FALSE; + DWORD sz; + if (!string || !re) + { + SetLastError(ERROR_INVALID_HANDLE); + return FALSE; + } TRACE("%s %s %c\n", string, re, _case ? 'Y' : 'N'); - compile_regex(re, -1, &preg, _case); - ret = match_regexp(&preg, string); - regfree(&preg); + sz = MultiByteToWideChar(CP_ACP, 0, string, -1, NULL, 0); + if ((strW = HeapAlloc(GetProcessHeap(), 0, sz * sizeof(WCHAR)))) + MultiByteToWideChar(CP_ACP, 0, string, -1, strW, sz); + sz = MultiByteToWideChar(CP_ACP, 0, re, -1, NULL, 0); + if ((reW = HeapAlloc(GetProcessHeap(), 0, sz * sizeof(WCHAR)))) + MultiByteToWideChar(CP_ACP, 0, re, -1, reW, sz); + + if (strW && reW) + ret = SymMatchStringW(strW, reW, _case); + HeapFree(GetProcessHeap(), 0, strW); + HeapFree(GetProcessHeap(), 0, reW); return ret; } /****************************************************************** * SymMatchStringW (DBGHELP.@) * - * FIXME: SymMatchStringA should convert and pass the strings to SymMatchStringW, - * but that needs a unicode RE library. */ BOOL WINAPI SymMatchStringW(PCWSTR string, PCWSTR re, BOOL _case) { - BOOL ret; - LPSTR s, r; - DWORD len; - TRACE("%s %s %c\n", debugstr_w(string), debugstr_w(re), _case ? 'Y' : 'N'); - len = WideCharToMultiByte( CP_ACP, 0, string, -1, NULL, 0, NULL, NULL ); - s = HeapAlloc( GetProcessHeap(), 0, len ); - WideCharToMultiByte( CP_ACP, 0, string, -1, s, len, NULL, NULL ); - - len = WideCharToMultiByte( CP_ACP, 0, re, -1, NULL, 0, NULL, NULL ); - r = HeapAlloc( GetProcessHeap(), 0, len ); - WideCharToMultiByte( CP_ACP, 0, re, -1, r, len, NULL, NULL ); - - ret = SymMatchStringA(s, r, _case); - - HeapFree( GetProcessHeap(), 0, r ); - HeapFree( GetProcessHeap(), 0, s ); - return ret; + if (!string || !re) + { + SetLastError(ERROR_INVALID_HANDLE); + return FALSE; + } + return re_match_multi(&string, &re, _case); } /******************************************************************

1 0

Eric Pouech : dbghelp: Do all module and symbol names matching using unicode string ( and new regular expression matcher).
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: 026ec7f69072476a738279c4abbfabc298c0aa9a URL: http://source.winehq.org/git/wine.git/?a=commit;h=026ec7f69072476a738279c4a… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sun Jan 22 12:57:59 2012 +0100 dbghelp: Do all module and symbol names matching using unicode string (and new regular expression matcher). --- dlls/dbghelp/dbghelp_private.h | 3 +- dlls/dbghelp/module.c | 3 - dlls/dbghelp/symbol.c | 242 +++++++++++++++++----------------------- dlls/dbghelp/type.c | 13 ++ 4 files changed, 118 insertions(+), 143 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=026ec7f69072476a73827…

1 0

Eric Pouech : dbghelp: Use new regular expression matcher for files.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: f3107df57631dd56d39e90dcdbe12299b584c250 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f3107df57631dd56d39e90dcd… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sun Jan 22 12:58:04 2012 +0100 dbghelp: Use new regular expression matcher for files. --- dlls/dbghelp/symbol.c | 150 ++++++++++++++++++------------------------------ 1 files changed, 56 insertions(+), 94 deletions(-) diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index 96af50c..439b50e 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -30,9 +30,6 @@ #include <limits.h> #include <sys/types.h> #include <assert.h> -#ifdef HAVE_REGEX_H -# include <regex.h> -#endif #include "wine/debug.h" #include "dbghelp_private.h" @@ -138,101 +135,54 @@ static void symt_add_module_ht(struct module* module, struct symt_ht* ht) } } -#ifdef HAVE_REGEX_H - -static BOOL compile_file_regex(regex_t* re, const char* srcfile) +static WCHAR* file_regex(const char* srcfile) { - char *mask, *p; - BOOL ret; - - if (!srcfile || !*srcfile) return regcomp(re, ".*", REG_NOSUB); + WCHAR* mask; + WCHAR* p; - p = mask = HeapAlloc(GetProcessHeap(), 0, 5 * strlen(srcfile) + 4); - *p++ = '^'; - while (*srcfile) + if (!srcfile || !*srcfile) { - switch (*srcfile) - { - case '\\': - case '/': - *p++ = '['; - *p++ = '\\'; - *p++ = '\\'; - *p++ = '/'; - *p++ = ']'; - break; - case '.': - *p++ = '\\'; - *p++ = '.'; - break; - case '*': - *p++ = '.'; - *p++ = '*'; - break; - default: - *p++ = *srcfile; - break; - } - srcfile++; + if (!(p = mask = HeapAlloc(GetProcessHeap(), 0, 3 * sizeof(WCHAR)))) return NULL; + *p++ = '?'; + *p++ = '#'; } - *p++ = '$'; - *p = 0; - ret = !regcomp(re, mask, REG_NOSUB); - HeapFree(GetProcessHeap(), 0, mask); - if (!ret) + else { - FIXME("Couldn't compile %s\n", mask); - SetLastError(ERROR_INVALID_PARAMETER); - } - return ret; -} - -static int match_regexp( const regex_t *re, const char *str ) -{ - return !regexec( re, str, 0, NULL, 0 ); -} - -#else /* HAVE_REGEX_H */ - -/* if we don't have regexp support, fall back to a simple string comparison */ + DWORD sz = MultiByteToWideChar(CP_ACP, 0, srcfile, -1, NULL, 0); + WCHAR* srcfileW; -typedef struct -{ - char *str; - BOOL icase; -} regex_t; - -static void compile_regex(const char* str, int numchar, regex_t* re, BOOL _case) -{ - if (numchar == -1) numchar = strlen( str ); + /* FIXME: we use here the largest conversion for every char... could be optimized */ + p = mask = HeapAlloc(GetProcessHeap(), 0, (5 * strlen(srcfile) + 1 + sz) * sizeof(WCHAR)); + if (!mask) return NULL; + srcfileW = mask + 5 * strlen(srcfile) + 1; + MultiByteToWideChar(CP_ACP, 0, srcfile, -1, srcfileW, sz); - re->str = HeapAlloc( GetProcessHeap(), 0, numchar + 1 ); - memcpy( re->str, str, numchar ); - re->str[numchar] = 0; - re->icase = _case; -} - -static BOOL compile_file_regex(regex_t* re, const char* srcfile) -{ - if (!srcfile || !*srcfile) re->str = NULL; - else compile_regex( srcfile, -1, re, FALSE ); - return TRUE; -} - -static int match_regexp( const regex_t *re, const char *str ) -{ - if (!re->str) return 1; - if (re->icase) return !lstrcmpiA( re->str, str ); - return !strcmp( re->str, str ); -} - -static void regfree( regex_t *re ) -{ - HeapFree( GetProcessHeap(), 0, re->str ); + while (*srcfileW) + { + switch (*srcfileW) + { + case '\\': + case '/': + *p++ = '['; + *p++ = '\\'; + *p++ = '\\'; + *p++ = '/'; + *p++ = ']'; + break; + case '.': + *p++ = '?'; + break; + default: + *p++ = *srcfileW; + break; + } + srcfileW++; + } + } + *p = 0; + return mask; } -#endif /* HAVE_REGEX_H */ - struct symt_compiland* symt_new_compiland(struct module* module, unsigned long address, unsigned src_idx) { @@ -2136,7 +2086,7 @@ BOOL WINAPI SymEnumLines(HANDLE hProcess, ULONG64 base, PCSTR compiland, struct module_pair pair; struct hash_table_iter hti; struct symt_ht* sym; - regex_t re; + WCHAR* srcmask; struct line_info* dli; void* ptr; SRCCODEINFO sci; @@ -2150,7 +2100,7 @@ BOOL WINAPI SymEnumLines(HANDLE hProcess, ULONG64 base, PCSTR compiland, if (compiland) FIXME("Unsupported yet (filtering on compiland %s)\n", compiland); pair.requested = module_find_by_addr(pair.pcs, base, DMT_UNKNOWN); if (!module_get_debug(&pair)) return FALSE; - if (!compile_file_regex(&re, srcfile)) return FALSE; + if (!(srcmask = file_regex(srcfile))) return FALSE; sci.SizeOfStruct = sizeof(sci); sci.ModBase = base; @@ -2170,8 +2120,20 @@ BOOL WINAPI SymEnumLines(HANDLE hProcess, ULONG64 base, PCSTR compiland, if (dli->is_source_file) { file = source_get(pair.effective, dli->u.source_file); - if (!match_regexp(&re, file)) sci.FileName[0] = '\0'; - else strcpy(sci.FileName, file); + if (!file) sci.FileName[0] = '\0'; + else + { + DWORD sz = MultiByteToWideChar(CP_ACP, 0, file, -1, NULL, 0); + WCHAR* fileW; + + if ((fileW = HeapAlloc(GetProcessHeap(), 0, sz * sizeof(WCHAR)))) + MultiByteToWideChar(CP_ACP, 0, file, -1, fileW, sz); + if (SymMatchStringW(fileW, srcmask, FALSE)) + strcpy(sci.FileName, file); + else + sci.FileName[0] = '\0'; + HeapFree(GetProcessHeap(), 0, fileW); + } } else if (sci.FileName[0]) { @@ -2183,7 +2145,7 @@ BOOL WINAPI SymEnumLines(HANDLE hProcess, ULONG64 base, PCSTR compiland, } } } - regfree(&re); + HeapFree(GetProcessHeap(), 0, srcmask); return TRUE; }

1 0

Eric Pouech : configure: Remove regex detection.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: 7c7c56e3bf752f5472e35e1540a75b787c8d2b07 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c7c56e3bf752f5472e35e154… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sun Jan 22 12:58:10 2012 +0100 configure: Remove regex detection. --- configure | 1 - configure.ac | 1 - include/config.h.in | 3 --- 3 files changed, 0 insertions(+), 5 deletions(-) diff --git a/configure b/configure index ae531d0..fa17bcc 100755 --- a/configure +++ b/configure @@ -5810,7 +5810,6 @@ for ac_header in \ process.h \ pthread.h \ pwd.h \ - regex.h \ sched.h \ scsi/scsi.h \ scsi/scsi_ioctl.h \ diff --git a/configure.ac b/configure.ac index c9f6a63..5810111 100644 --- a/configure.ac +++ b/configure.ac @@ -447,7 +447,6 @@ AC_CHECK_HEADERS(\ process.h \ pthread.h \ pwd.h \ - regex.h \ sched.h \ scsi/scsi.h \ scsi/scsi_ioctl.h \ diff --git a/include/config.h.in b/include/config.h.in index 27c2783..dc1c189 100644 --- a/include/config.h.in +++ b/include/config.h.in @@ -656,9 +656,6 @@ /* Define to 1 if you have the `readlink' function. */ #undef HAVE_READLINK -/* Define to 1 if you have the <regex.h> header file. */ -#undef HAVE_REGEX_H - /* Define to 1 if the system has the type `request_sense'. */ #undef HAVE_REQUEST_SENSE

1 0

Alexandre Julliard : oleaut32/tests: Use a better invalid color for the olepicture icon test.
by Alexandre Julliard 23 Jan '12

23 Jan '12

Module: wine Branch: master Commit: 9422c19329c010f9ba07a316f7409bc1b1caafe6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9422c19329c010f9ba07a316f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jan 23 15:14:58 2012 +0100 oleaut32/tests: Use a better invalid color for the olepicture icon test. --- dlls/oleaut32/tests/olepicture.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/oleaut32/tests/olepicture.c b/dlls/oleaut32/tests/olepicture.c index 7f4d647..ecf88f6 100644 --- a/dlls/oleaut32/tests/olepicture.c +++ b/dlls/oleaut32/tests/olepicture.c @@ -675,9 +675,9 @@ static void test_Render(void) IPicture_get_Width(pic, &pWidth); IPicture_get_Height(pic, &pHeight); - SetPixelV(hdc, 0, 0, 0x00F0F0F0); - SetPixelV(hdc, 5, 5, 0x00F0F0F0); - SetPixelV(hdc, 10, 10, 0x00F0F0F0); + SetPixelV(hdc, 0, 0, 0x00223344); + SetPixelV(hdc, 5, 5, 0x00223344); + SetPixelV(hdc, 10, 10, 0x00223344); expected = GetPixel(hdc, 0, 0); hres = IPicture_Render(pic, hdc, 1, 1, 9, 9, 0, 0, pWidth, -pHeight, NULL);

1 0