January 2012 - Wine-commits

Daniel Lehman : msvcp90: Flip num_get<char/wchar_t> do_get_long and do_get_ulong in vtable.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 6f9f27d1bf1e0d6a760aec0dfa8f3c2a3328a944 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6f9f27d1bf1e0d6a760aec0df… Author: Daniel Lehman <dlehman(a)esri.com> Date: Thu Jan 12 19:41:16 2012 -0800 msvcp90: Flip num_get<char/wchar_t> do_get_long and do_get_ulong in vtable. --- dlls/msvcp90/locale.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index a4f42a0..12b4300 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -4235,8 +4235,8 @@ void __asm_dummy_vtables(void) { VTABLE_ADD_FUNC(num_get_char_do_get_float) VTABLE_ADD_FUNC(num_get_char_do_get_uint64) VTABLE_ADD_FUNC(num_get_char_do_get_int64) - VTABLE_ADD_FUNC(num_get_char_do_get_long) VTABLE_ADD_FUNC(num_get_char_do_get_ulong) + VTABLE_ADD_FUNC(num_get_char_do_get_long) VTABLE_ADD_FUNC(num_get_char_do_get_uint) VTABLE_ADD_FUNC(num_get_char_do_get_ushort) VTABLE_ADD_FUNC(num_get_char_do_get_bool)); @@ -4259,8 +4259,8 @@ void __asm_dummy_vtables(void) { VTABLE_ADD_FUNC(num_get_wchar_do_get_float) VTABLE_ADD_FUNC(num_get_wchar_do_get_uint64) VTABLE_ADD_FUNC(num_get_wchar_do_get_int64) - VTABLE_ADD_FUNC(num_get_wchar_do_get_long) VTABLE_ADD_FUNC(num_get_wchar_do_get_ulong) + VTABLE_ADD_FUNC(num_get_wchar_do_get_long) VTABLE_ADD_FUNC(num_get_wchar_do_get_uint) VTABLE_ADD_FUNC(num_get_wchar_do_get_ushort) VTABLE_ADD_FUNC(num_get_wchar_do_get_bool));

1 0

André Hentschel : d3drm: Fix QueryInterface forwarding .
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 59186dd4a0f6e672b24ef424c4250eda595652dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=59186dd4a0f6e672b24ef424c… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:12:14 2012 +0100 d3drm: Fix QueryInterface forwarding. --- dlls/d3drm/meshbuilder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c index ce910a9..d6b1735 100644 --- a/dlls/d3drm/meshbuilder.c +++ b/dlls/d3drm/meshbuilder.c @@ -1159,7 +1159,7 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_QueryInterface(IDirect3DRMMesh REFIID riid, void** ppvObject) { IDirect3DRMMeshBuilderImpl *This = impl_from_IDirect3DRMMeshBuilder3(iface); - return IDirect3DRMMeshBuilder_QueryInterface(&This->IDirect3DRMMeshBuilder3_iface, riid, ppvObject); + return IDirect3DRMMeshBuilder2_QueryInterface(&This->IDirect3DRMMeshBuilder2_iface, riid, ppvObject); } static ULONG WINAPI IDirect3DRMMeshBuilder3Impl_AddRef(IDirect3DRMMeshBuilder3* iface)

1 0

André Hentschel : d3drm: Add more MeshBuilder tests.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 455edb1870fcf3c38ba71def757158deff00d16a URL: http://source.winehq.org/git/wine.git/?a=commit;h=455edb1870fcf3c38ba71def7… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:12:47 2012 +0100 d3drm: Add more MeshBuilder tests. --- dlls/d3drm/tests/Makefile.in | 1 + dlls/d3drm/tests/d3drm.c | 98 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 97 insertions(+), 2 deletions(-) diff --git a/dlls/d3drm/tests/Makefile.in b/dlls/d3drm/tests/Makefile.in index f403d0e..5393742 100644 --- a/dlls/d3drm/tests/Makefile.in +++ b/dlls/d3drm/tests/Makefile.in @@ -1,4 +1,5 @@ TESTDLL = d3drm.dll +IMPORTS = dxguid C_SRCS = \ d3drm.c \ diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c index 267bd2d..b965242 100644 --- a/dlls/d3drm/tests/d3drm.c +++ b/dlls/d3drm/tests/d3drm.c @@ -80,7 +80,7 @@ static char data_ok[] = "3; 3, 1, 2;;\n" "}\n"; -static void MeshBuilderTest(void) +static void test_MeshBuilder(void) { HRESULT hr; LPDIRECT3DRM pD3DRM; @@ -88,6 +88,7 @@ static void MeshBuilderTest(void) D3DRMLOADMEMORY info; int val; DWORD val1, val2, val3; + D3DVALUE valu, valv; hr = pDirect3DRMCreate(&pD3DRM); ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", hr); @@ -122,17 +123,110 @@ static void MeshBuilderTest(void) todo_wine ok(val2 == 4, "Wrong number of normals %d (must be 4)\n", val2); todo_wine ok(val3 == 22, "Wrong number of face data bytes %d (must be 22)\n", val3); + valu = 1.23f; + valv = 3.21f; + hr = IDirect3DRMMeshBuilder_GetTextureCoordinates(pMeshBuilder, 1, &valu, &valv); + todo_wine ok(hr == D3DRM_OK, "Cannot get texture coordinates (hr = %x)\n", hr); + todo_wine ok(valu == 0.0f, "Wrong coordinate %f (must be 0.0)\n", valu); + todo_wine ok(valv == 0.0f, "Wrong coordinate %f (must be 0.0)\n", valv); + + valu = 1.23f; + valv = 3.21f; + hr = IDirect3DRMMeshBuilder_SetTextureCoordinates(pMeshBuilder, 1, valu, valv); + todo_wine ok(hr == D3DRM_OK, "Cannot set texture coordinates (hr = %x)\n", hr); + + valu = 0.0f; + valv = 0.0f; + hr = IDirect3DRMMeshBuilder_GetTextureCoordinates(pMeshBuilder, 1, &valu, &valv); + todo_wine ok(hr == D3DRM_OK, "Cannot get texture coordinates (hr = %x)\n", hr); + todo_wine ok(valu == 1.23f, "Wrong coordinate %f (must be 1.23)\n", valu); + todo_wine ok(valv == 3.21f, "Wrong coordinate %f (must be 3.21)\n", valv); + IDirect3DRMMeshBuilder_Release(pMeshBuilder); IDirect3DRM_Release(pD3DRM); } +static void test_MeshBuilder3(void) +{ + HRESULT hr; + LPDIRECT3DRM pD3DRM; + LPDIRECT3DRM3 pD3DRM3; + LPDIRECT3DRMMESHBUILDER3 pMeshBuilder3; + D3DRMLOADMEMORY info; + int val; + DWORD val1; + D3DVALUE valu, valv; + + hr = pDirect3DRMCreate(&pD3DRM); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", hr); + + hr = IDirect3DRM_QueryInterface(pD3DRM, &IID_IDirect3DRM3, (LPVOID*)&pD3DRM3); + if (FAILED(hr)) + { + win_skip("Cannot get IDirect3DRM3 interface (hr = %x), skipping tests\n", hr); + return; + } + + hr = IDirect3DRM_CreateMeshBuilder(pD3DRM3, &pMeshBuilder3); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMMeshBuilder3 interface (hr = %x)\n", hr); + + info.lpMemory = data_bad_version; + info.dSize = strlen(data_bad_version); + hr = IDirect3DRMMeshBuilder_Load(pMeshBuilder3, &info, NULL, D3DRMLOAD_FROMMEMORY, NULL, NULL); + todo_wine ok(hr == D3DRMERR_BADFILE, "Should have returned D3DRMERR_BADFILE (hr = %x)\n", hr); + + info.lpMemory = data_no_mesh; + info.dSize = strlen(data_no_mesh); + hr = IDirect3DRMMeshBuilder_Load(pMeshBuilder3, &info, NULL, D3DRMLOAD_FROMMEMORY, NULL, NULL); + todo_wine ok(hr == D3DRMERR_NOTFOUND, "Should have returned D3DRMERR_NOTFOUND (hr = %x)\n", hr); + + info.lpMemory = data_ok; + info.dSize = strlen(data_ok); + hr = IDirect3DRMMeshBuilder_Load(pMeshBuilder3, &info, NULL, D3DRMLOAD_FROMMEMORY, NULL, NULL); + todo_wine ok(hr == D3DRM_OK, "Cannot load mesh data (hr = %x)\n", hr); + + val = IDirect3DRMMeshBuilder_GetVertexCount(pMeshBuilder3); + todo_wine ok(val == 4, "Wrong number of vertices %d (must be 4)\n", val); + + val = IDirect3DRMMeshBuilder_GetFaceCount(pMeshBuilder3); + todo_wine ok(val == 3, "Wrong number of faces %d (must be 3)\n", val); + + hr = IDirect3DRMMeshBuilder3_GetVertices(pMeshBuilder3, 0, &val1, NULL); + todo_wine ok(hr == D3DRM_OK, "Cannot get vertices information (hr = %x)\n", hr); + todo_wine ok(val1 == 4, "Wrong number of vertices %d (must be 4)\n", val1); + + valu = 1.23f; + valv = 3.21f; + hr = IDirect3DRMMeshBuilder3_GetTextureCoordinates(pMeshBuilder3, 1, &valu, &valv); + todo_wine ok(hr == D3DRM_OK, "Cannot get texture coordinates (hr = %x)\n", hr); + todo_wine ok(valu == 0.0f, "Wrong coordinate %f (must be 0.0)\n", valu); + todo_wine ok(valv == 0.0f, "Wrong coordinate %f (must be 0.0)\n", valv); + + valu = 1.23f; + valv = 3.21f; + hr = IDirect3DRMMeshBuilder3_SetTextureCoordinates(pMeshBuilder3, 1, valu, valv); + todo_wine ok(hr == D3DRM_OK, "Cannot set texture coordinates (hr = %x)\n", hr); + + valu = 0.0f; + valv = 0.0f; + hr = IDirect3DRMMeshBuilder3_GetTextureCoordinates(pMeshBuilder3, 1, &valu, &valv); + todo_wine ok(hr == D3DRM_OK, "Cannot get texture coordinates (hr = %x)\n", hr); + todo_wine ok(valu == 1.23f, "Wrong coordinate %f (must be 1.23)\n", valu); + todo_wine ok(valv == 3.21f, "Wrong coordinate %f (must be 3.21)\n", valv); + + IDirect3DRMMeshBuilder_Release(pMeshBuilder3); + + IDirect3DRM_Release(pD3DRM3); +} + START_TEST(d3drm) { if (!InitFunctionPtrs()) return; - MeshBuilderTest(); + test_MeshBuilder(); + test_MeshBuilder3(); FreeLibrary(d3drm_handle); }

1 0

André Hentschel : d3drm: Add more Frame tests.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: d16806e3fb34a5da76b452d2efd470ace0cd2835 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d16806e3fb34a5da76b452d2e… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:14:31 2012 +0100 d3drm: Add more Frame tests. --- dlls/d3drm/tests/d3drm.c | 133 ++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 133 insertions(+), 0 deletions(-) diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c index b965242..67c6d8c 100644 --- a/dlls/d3drm/tests/d3drm.c +++ b/dlls/d3drm/tests/d3drm.c @@ -220,6 +220,138 @@ static void test_MeshBuilder3(void) IDirect3DRM_Release(pD3DRM3); } +static void test_Frame(void) +{ + HRESULT hr; + LPDIRECT3DRM pD3DRM; + LPDIRECT3DRMFRAME pFrameC; + LPDIRECT3DRMFRAME pFrameP1; + LPDIRECT3DRMFRAME pFrameP2; + LPDIRECT3DRMFRAME pFrameTmp; + LPDIRECT3DRMFRAMEARRAY pArray; + DWORD count; + + hr = pDirect3DRMCreate(&pD3DRM); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", hr); + + hr = IDirect3DRM_CreateFrame(pD3DRM, NULL, &pFrameC); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame interface (hr = %x)\n", hr); + + pFrameTmp = (void*)0xdeadbeef; + hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); + todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); + todo_wine ok(pFrameTmp == NULL, "pFrameTmp = %p\n", pFrameTmp); + + pArray = NULL; + hr = IDirect3DRMFrame_GetChildren(pFrameC, &pArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); + todo_wine ok(pArray != NULL, "pArray = %p\n", pArray); + if (pArray) + { + count = IDirect3DRMFrameArray_GetSize(pArray); + ok(count == 0, "count = %u\n", count); + IDirect3DRMFrameArray_Release(pArray); + } + + /* Add child to first parent */ + hr = IDirect3DRM_CreateFrame(pD3DRM, NULL, &pFrameP1); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame interface (hr = %x)\n", hr); + + pFrameTmp = (void*)0xdeadbeef; + hr = IDirect3DRMFrame_GetParent(pFrameP1, &pFrameTmp); + todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); + todo_wine ok(pFrameTmp == NULL, "pFrameTmp = %p\n", pFrameTmp); + + hr = IDirect3DRMFrame_AddChild(pFrameP1, pFrameC); + todo_wine ok(hr == D3DRM_OK, "Cannot add child frame (hr = %x)\n", hr); + + pArray = NULL; + hr = IDirect3DRMFrame_GetChildren(pFrameP1, &pArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); + if (pArray) + { + count = IDirect3DRMFrameArray_GetSize(pArray); + ok(count == 1, "count = %u\n", count); + IDirect3DRMFrameArray_Release(pArray); + } + + pFrameTmp = (void*)0xdeadbeef; + hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); + todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); + todo_wine ok(pFrameTmp == pFrameP1, "pFrameTmp = %p\n", pFrameTmp); + + /* Add child to second parent */ + hr = IDirect3DRM_CreateFrame(pD3DRM, NULL, &pFrameP2); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame interface (hr = %x)\n", hr); + + hr = IDirect3DRMFrame_AddChild(pFrameP2, pFrameC); + todo_wine ok(hr == D3DRM_OK, "Cannot add child frame (hr = %x)\n", hr); + + pArray = NULL; + hr = IDirect3DRMFrame_GetChildren(pFrameP2, &pArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); + if (pArray) + { + count = IDirect3DRMFrameArray_GetSize(pArray); + ok(count == 1, "count = %u\n", count); + IDirect3DRMFrameArray_Release(pArray); + } + + pArray = NULL; + hr = IDirect3DRMFrame_GetChildren(pFrameP1, &pArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); + if (pArray) + { + count = IDirect3DRMFrameArray_GetSize(pArray); + ok(count == 0, "count = %u\n", count); + IDirect3DRMFrameArray_Release(pArray); + } + + pFrameTmp = (void*)0xdeadbeef; + hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); + todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); + todo_wine ok(pFrameTmp == pFrameP2, "pFrameTmp = %p\n", pFrameTmp); + + /* Add child again */ + hr = IDirect3DRMFrame_AddChild(pFrameP2, pFrameC); + todo_wine ok(hr == D3DRM_OK, "Cannot add child frame (hr = %x)\n", hr); + + pArray = NULL; + hr = IDirect3DRMFrame_GetChildren(pFrameP2, &pArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); + if (pArray) + { + count = IDirect3DRMFrameArray_GetSize(pArray); + ok(count == 1, "count = %u\n", count); + IDirect3DRMFrameArray_Release(pArray); + } + + /* Delete child */ + hr = IDirect3DRMFrame_DeleteChild(pFrameP2, pFrameC); + todo_wine ok(hr == D3DRM_OK, "Cannot delete child frame (hr = %x)\n", hr); + + pArray = NULL; + hr = IDirect3DRMFrame_GetChildren(pFrameP2, &pArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); + if (pArray) + { + count = IDirect3DRMFrameArray_GetSize(pArray); + ok(count == 0, "count = %u\n", count); + IDirect3DRMFrameArray_Release(pArray); + } + + pFrameTmp = (void*)0xdeadbeef; + hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); + todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); + todo_wine ok(pFrameTmp == NULL, "pFrameTmp = %p\n", pFrameTmp); + + IDirect3DRMMeshBuilder_Release(pFrameC); + IDirect3DRMMeshBuilder_Release(pFrameP1); + IDirect3DRMMeshBuilder_Release(pFrameP2); + + IDirect3DRM_Release(pD3DRM); +} + START_TEST(d3drm) { if (!InitFunctionPtrs()) @@ -227,6 +359,7 @@ START_TEST(d3drm) test_MeshBuilder(); test_MeshBuilder3(); + test_Frame(); FreeLibrary(d3drm_handle); }

1 0

André Hentschel : d3drm: Move Load implementation to IDirect3DRMMeshBuilder3.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 3931338eca81c89e401aa4b084468a8c9e1c223e URL: http://source.winehq.org/git/wine.git/?a=commit;h=3931338eca81c89e401aa4b08… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:15:16 2012 +0100 d3drm: Move Load implementation to IDirect3DRMMeshBuilder3. --- dlls/d3drm/meshbuilder.c | 423 +++++++++++++++++++++++----------------------- dlls/d3drm/tests/d3drm.c | 10 +- 2 files changed, 217 insertions(+), 216 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3931338eca81c89e401aa…

1 0

André Hentschel : d3drm: Add IDirect3DRMDevice2 interface.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: f018a861377edb96fecc7df644e04b0e9499897e URL: http://source.winehq.org/git/wine.git/?a=commit;h=f018a861377edb96fecc7df64… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:16:02 2012 +0100 d3drm: Add IDirect3DRMDevice2 interface. --- dlls/d3drm/Makefile.in | 1 + dlls/d3drm/d3drm.c | 8 +- dlls/d3drm/d3drm_private.h | 1 + dlls/d3drm/device.c | 508 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 514 insertions(+), 4 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=f018a861377edb96fecc7…

1 0

André Hentschel : d3drm: Add IDirect3DRMViewport interface.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 7a96cb4e672b390e646432a40c5f1ade74424138 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7a96cb4e672b390e646432a40… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:17:02 2012 +0100 d3drm: Add IDirect3DRMViewport interface. --- dlls/d3drm/Makefile.in | 3 +- dlls/d3drm/d3drm.c | 5 +- dlls/d3drm/d3drm_private.h | 1 + dlls/d3drm/viewport.c | 508 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 514 insertions(+), 3 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7a96cb4e672b390e64643…

1 0

André Hentschel : d3drm: Add more partial stubs for device creation.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: e27d3c0ea5e8c949fa907efc50a9d7fb208e6046 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e27d3c0ea5e8c949fa907efc5… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:18:59 2012 +0100 d3drm: Add more partial stubs for device creation. --- dlls/d3drm/d3drm.c | 29 ++++++++++++++++------------- 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c index 771ae62..959c1cb 100644 --- a/dlls/d3drm/d3drm.c +++ b/dlls/d3drm/d3drm.c @@ -249,27 +249,29 @@ static HRESULT WINAPI IDirect3DRMImpl_CreateDeviceFromSurface(IDirect3DRM* iface { IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); - FIXME("(%p/%p)->(%s,%p,%p,%p): stub\n", iface, This, debugstr_guid(pGUID), pDD, pDDSBack, ppDevice); + FIXME("(%p/%p)->(%s,%p,%p,%p): partial stub\n", iface, This, debugstr_guid(pGUID), pDD, + pDDSBack, ppDevice); - return E_NOTIMPL; + return Direct3DRMDevice_create((IUnknown**)ppDevice); } static HRESULT WINAPI IDirect3DRMImpl_CreateDeviceFromD3D(IDirect3DRM* iface, LPDIRECT3D pD3D, LPDIRECT3DDEVICE pD3DDev, LPDIRECT3DRMDEVICE * ppDevice) { IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); - FIXME("(%p/%p)->(%p,%p,%p): stub\n", iface, This, pD3D, pD3DDev, ppDevice); + FIXME("(%p/%p)->(%p,%p,%p): partial stub\n", iface, This, pD3D, pD3DDev, ppDevice); - return E_NOTIMPL; + return Direct3DRMDevice_create((IUnknown**)ppDevice); } static HRESULT WINAPI IDirect3DRMImpl_CreateDeviceFromClipper(IDirect3DRM* iface, LPDIRECTDRAWCLIPPER pDDClipper, LPGUID pGUID, int width, int height, LPDIRECT3DRMDEVICE * ppDevice) { IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); - FIXME("(%p/%p)->(%p,%s,%d,%d,%p): stub\n", iface, This, pDDClipper, debugstr_guid(pGUID), width, height, ppDevice); + FIXME("(%p/%p)->(%p,%s,%d,%d,%p): partial stub\n", iface, This, pDDClipper, + debugstr_guid(pGUID), width, height, ppDevice); - return E_NOTIMPL; + return Direct3DRMDevice_create((IUnknown**)ppDevice); } static HRESULT WINAPI IDirect3DRMImpl_CreateTextureFromSurface(IDirect3DRM* iface, LPDIRECTDRAWSURFACE pDDS, LPDIRECT3DRMTEXTURE * ppTexture) @@ -629,9 +631,10 @@ static HRESULT WINAPI IDirect3DRM2Impl_CreateDeviceFromSurface(IDirect3DRM2* ifa { IDirect3DRMImpl *This = impl_from_IDirect3DRM2(iface); - FIXME("(%p/%p)->(%s,%p,%p,%p): stub\n", iface, This, debugstr_guid(pGUID), pDD, pDDSBack, ppDevice); + FIXME("(%p/%p)->(%s,%p,%p,%p): partial stub\n", iface, This, debugstr_guid(pGUID), + pDD, pDDSBack, ppDevice); - return E_NOTIMPL; + return Direct3DRMDevice_create((IUnknown**)ppDevice); } static HRESULT WINAPI IDirect3DRM2Impl_CreateDeviceFromD3D(IDirect3DRM2* iface, LPDIRECT3D2 pD3D, @@ -640,9 +643,9 @@ static HRESULT WINAPI IDirect3DRM2Impl_CreateDeviceFromD3D(IDirect3DRM2* iface, { IDirect3DRMImpl *This = impl_from_IDirect3DRM2(iface); - FIXME("(%p/%p)->(%p,%p,%p): stub\n", iface, This, pD3D, pD3DDev, ppDevice); + FIXME("(%p/%p)->(%p,%p,%p): partial stub\n", iface, This, pD3D, pD3DDev, ppDevice); - return E_NOTIMPL; + return Direct3DRMDevice_create((IUnknown**)ppDevice); } static HRESULT WINAPI IDirect3DRM2Impl_CreateDeviceFromClipper(IDirect3DRM2* iface, @@ -652,10 +655,10 @@ static HRESULT WINAPI IDirect3DRM2Impl_CreateDeviceFromClipper(IDirect3DRM2* ifa { IDirect3DRMImpl *This = impl_from_IDirect3DRM2(iface); - FIXME("(%p/%p)->(%p,%s,%d,%d,%p): stub\n", iface, This, pDDClipper, debugstr_guid(pGUID), width, - height, ppDevice); + FIXME("(%p/%p)->(%p,%s,%d,%d,%p): partial stub\n", iface, This, pDDClipper, + debugstr_guid(pGUID), width, height, ppDevice); - return E_NOTIMPL; + return Direct3DRMDevice_create((IUnknown**)ppDevice); } static HRESULT WINAPI IDirect3DRM2Impl_CreateTextureFromSurface(IDirect3DRM2* iface,

1 0

André Hentschel : d3drm: Move GetTextureCoordinates from IDirect3DRMMeshBuilder2 to IDirect3DRMMeshBuilder3 .
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 5aa43a2bfbad2d25d8669291462d5a292b761394 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5aa43a2bfbad2d25d86692914… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:19:58 2012 +0100 d3drm: Move GetTextureCoordinates from IDirect3DRMMeshBuilder2 to IDirect3DRMMeshBuilder3. --- dlls/d3drm/meshbuilder.c | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c index 62c3149..409e659 100644 --- a/dlls/d3drm/meshbuilder.c +++ b/dlls/d3drm/meshbuilder.c @@ -772,15 +772,10 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder2Impl_GetTextureCoordinates(IDirect3 { IDirect3DRMMeshBuilderImpl *This = impl_from_IDirect3DRMMeshBuilder2(iface); - FIXME("(%p)->(%d,%p,%p): stub\n", This, index, u, v); + TRACE("(%p)->(%d,%p,%p)\n", This, index, u, v); - if (index >= This->nb_coords2d) - return D3DRMERR_NOTFOUND; - - *u = This->pCoords2d[index].u; - *v = This->pCoords2d[index].v; - - return D3DRM_OK; + return IDirect3DRMMeshBuilder2_GetTextureCoordinates(&This->IDirect3DRMMeshBuilder3_iface, + index, u, v); } static int WINAPI IDirect3DRMMeshBuilder2Impl_AddVertex(IDirect3DRMMeshBuilder2* iface, @@ -1579,9 +1574,15 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_GetTextureCoordinates(IDirect3 { IDirect3DRMMeshBuilderImpl *This = impl_from_IDirect3DRMMeshBuilder3(iface); - FIXME("(%p)->(%d,%p,%p): stub\n", This, index, u, v); + TRACE("(%p)->(%d,%p,%p)\n", This, index, u, v); - return E_NOTIMPL; + if (index >= This->nb_coords2d) + return D3DRMERR_NOTFOUND; + + *u = This->pCoords2d[index].u; + *v = This->pCoords2d[index].v; + + return D3DRM_OK; }

1 0

André Hentschel : d3drm/tests: Add refcount testing.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Module: wine Branch: master Commit: 1b3c8aaf069fdaacb3961de1faf3638cf2b42657 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1b3c8aaf069fdaacb3961de1f… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Jan 13 00:21:05 2012 +0100 d3drm/tests: Add refcount testing. --- dlls/d3drm/tests/d3drm.c | 27 ++++++++++++++++++++++++++- 1 files changed, 26 insertions(+), 1 deletions(-) diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c index 8f3c01c..d4bb77d 100644 --- a/dlls/d3drm/tests/d3drm.c +++ b/dlls/d3drm/tests/d3drm.c @@ -16,7 +16,9 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include "d3drm.h" +#define COBJMACROS +#include <d3drm.h> +#include <initguid.h> #include "wine/test.h" @@ -24,6 +26,13 @@ static HMODULE d3drm_handle = 0; static HRESULT (WINAPI * pDirect3DRMCreate)(LPDIRECT3DRM* ppDirect3DRM); +#define CHECK_REFCOUNT(obj,rc) \ + { \ + int rc_new = rc; \ + int count = get_refcount( (IUnknown *)obj ); \ + ok(count == rc_new, "Invalid refcount. Expected %d got %d\n", rc_new, count); \ + } + #define D3DRM_GET_PROC(func) \ p ## func = (void*)GetProcAddress(d3drm_handle, #func); \ if(!p ## func) { \ @@ -47,6 +56,12 @@ static BOOL InitFunctionPtrs(void) return TRUE; } +static int get_refcount(IUnknown *object) +{ + IUnknown_AddRef( object ); + return IUnknown_Release( object ); +} + static char data_bad_version[] = "xof 0302txt 0064\n" "Header Object\n" @@ -236,11 +251,13 @@ static void test_Frame(void) hr = IDirect3DRM_CreateFrame(pD3DRM, NULL, &pFrameC); ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame interface (hr = %x)\n", hr); + CHECK_REFCOUNT(pFrameC, 1); pFrameTmp = (void*)0xdeadbeef; hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); todo_wine ok(pFrameTmp == NULL, "pFrameTmp = %p\n", pFrameTmp); + CHECK_REFCOUNT(pFrameC, 1); pArray = NULL; hr = IDirect3DRMFrame_GetChildren(pFrameC, &pArray); @@ -264,6 +281,8 @@ static void test_Frame(void) hr = IDirect3DRMFrame_AddChild(pFrameP1, pFrameC); todo_wine ok(hr == D3DRM_OK, "Cannot add child frame (hr = %x)\n", hr); + CHECK_REFCOUNT(pFrameP1, 1); + todo_wine CHECK_REFCOUNT(pFrameC, 2); pArray = NULL; hr = IDirect3DRMFrame_GetChildren(pFrameP1, &pArray); @@ -279,6 +298,7 @@ static void test_Frame(void) hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); todo_wine ok(pFrameTmp == pFrameP1, "pFrameTmp = %p\n", pFrameTmp); + todo_wine CHECK_REFCOUNT(pFrameP1, 2); /* Add child to second parent */ hr = IDirect3DRM_CreateFrame(pD3DRM, NULL, &pFrameP2); @@ -286,6 +306,7 @@ static void test_Frame(void) hr = IDirect3DRMFrame_AddChild(pFrameP2, pFrameC); todo_wine ok(hr == D3DRM_OK, "Cannot add child frame (hr = %x)\n", hr); + todo_wine CHECK_REFCOUNT(pFrameC, 2); pArray = NULL; hr = IDirect3DRMFrame_GetChildren(pFrameP2, &pArray); @@ -311,10 +332,13 @@ static void test_Frame(void) hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); todo_wine ok(hr == D3DRM_OK, "Cannot get parent frame (hr = %x)\n", hr); todo_wine ok(pFrameTmp == pFrameP2, "pFrameTmp = %p\n", pFrameTmp); + todo_wine CHECK_REFCOUNT(pFrameP2, 2); + todo_wine CHECK_REFCOUNT(pFrameC, 2); /* Add child again */ hr = IDirect3DRMFrame_AddChild(pFrameP2, pFrameC); todo_wine ok(hr == D3DRM_OK, "Cannot add child frame (hr = %x)\n", hr); + todo_wine CHECK_REFCOUNT(pFrameC, 2); pArray = NULL; hr = IDirect3DRMFrame_GetChildren(pFrameP2, &pArray); @@ -329,6 +353,7 @@ static void test_Frame(void) /* Delete child */ hr = IDirect3DRMFrame_DeleteChild(pFrameP2, pFrameC); todo_wine ok(hr == D3DRM_OK, "Cannot delete child frame (hr = %x)\n", hr); + CHECK_REFCOUNT(pFrameC, 1); pArray = NULL; hr = IDirect3DRMFrame_GetChildren(pFrameP2, &pArray);

1 0