November 2012 - Wine-commits

André Hentschel : d3dx9_36: Return on error (coverity) .
by Alexandre Julliard 05 Nov '12

05 Nov '12

Module: wine Branch: master Commit: e15618a89649db1ee0b91d6120cf77806d0fa59f URL: http://source.winehq.org/git/wine.git/?a=commit;h=e15618a89649db1ee0b91d612… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Nov 3 17:26:26 2012 +0100 d3dx9_36: Return on error (coverity). --- dlls/d3dx9_36/mesh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index 10c3a73..f1ad7c8 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -3582,7 +3582,7 @@ static HRESULT filedata_get_name(IDirectXFileData *filedata, char **name) hr = IDirectXFileObject_GetName(filedata, *name, &name_len); if (FAILED(hr)) HeapFree(GetProcessHeap(), 0, *name); - if (!name_len) + else if (!name_len) (*name)[0] = 0; return hr;

1 0

André Hentschel : dmloader: Fix sizeof statement ( coverity).
by Alexandre Julliard 05 Nov '12

05 Nov '12

Module: wine Branch: master Commit: 295ffdfa964183afeba40fca75d926d3232b98df URL: http://source.winehq.org/git/wine.git/?a=commit;h=295ffdfa964183afeba40fca7… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Nov 3 17:26:13 2012 +0100 dmloader: Fix sizeof statement (coverity). --- dlls/dmloader/loader.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/dmloader/loader.c b/dlls/dmloader/loader.c index f97fad4..cfb3de9 100644 --- a/dlls/dmloader/loader.c +++ b/dlls/dmloader/loader.c @@ -767,7 +767,7 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_IDirectMusicLoader_ReleaseObjectByU TRACE("(%p, %p)\n", This, pObject); - if (IsBadReadPtr (pObject, sizeof(LPUNKNOWN))) { + if (IsBadReadPtr (pObject, sizeof(*pObject))) { ERR(": pObject bad write pointer\n"); return E_POINTER; }

1 0

Alexandre Julliard : urlmon: Add po file support for resource translation.
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: c9e951dfd3dc0048806c0a6916a069f97ccedbf9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c9e951dfd3dc0048806c0a691… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 2 14:35:48 2012 +0100 urlmon: Add po file support for resource translation. --- configure | 2 +- configure.ac | 2 +- dlls/urlmon/Makefile.in | 3 +- dlls/urlmon/{rsrc.rc => urlmon.rc} | 0 po/ar.po | 44 ++++++++++++++++++++++------ po/bg.po | 50 ++++++++++++++++++++++++++------ po/ca.po | 52 ++++++++++++++++++++++++++++----- po/cs.po | 56 +++++++++++++++++++++++++++++------ po/da.po | 52 ++++++++++++++++++++++++++++----- po/de.po | 52 ++++++++++++++++++++++++++++----- po/el.po | 44 ++++++++++++++++++++++------ po/en.po | 44 +++++++++++++++++++++++----- po/en_US.po | 44 +++++++++++++++++++++++----- po/eo.po | 50 +++++++++++++++++++++++++++----- po/es.po | 52 ++++++++++++++++++++++++++++----- po/fa.po | 44 ++++++++++++++++++++++------ po/fi.po | 52 ++++++++++++++++++++++++++++----- po/fr.po | 52 ++++++++++++++++++++++++++++----- po/he.po | 51 +++++++++++++++++++++++++++----- po/hi.po | 42 ++++++++++++++++++++++----- po/hu.po | 52 ++++++++++++++++++++++++++++----- po/it.po | 52 ++++++++++++++++++++++++++++----- po/ja.po | 52 ++++++++++++++++++++++++++++----- po/ko.po | 52 ++++++++++++++++++++++++++++----- po/lt.po | 52 ++++++++++++++++++++++++++++----- po/ml.po | 42 ++++++++++++++++++++++----- po/nb_NO.po | 54 ++++++++++++++++++++++++++++------ po/nl.po | 52 ++++++++++++++++++++++++++++----- po/or.po | 42 ++++++++++++++++++++++----- po/pa.po | 42 ++++++++++++++++++++++----- po/pl.po | 52 ++++++++++++++++++++++++++++----- po/pt_BR.po | 52 ++++++++++++++++++++++++++++----- po/pt_PT.po | 52 ++++++++++++++++++++++++++++----- po/rm.po | 44 +++++++++++++++++++++++----- po/ro.po | 51 +++++++++++++++++++++++++++----- po/ru.po | 52 ++++++++++++++++++++++++++++----- po/sk.po | 50 ++++++++++++++++++++++++++------ po/sl.po | 52 ++++++++++++++++++++++++++++----- po/sr_RS(a)cyrillic.po | 52 +++++++++++++++++++++++++++------ po/sr_RS(a)latin.po | 52 +++++++++++++++++++++++++++------ po/sv.po | 52 ++++++++++++++++++++++++++++----- po/te.po | 42 ++++++++++++++++++++++----- po/th.po | 44 ++++++++++++++++++++++------ po/tr.po | 47 +++++++++++++++++++++++++----- po/uk.po | 52 ++++++++++++++++++++++++++++----- po/wa.po | 44 +++++++++++++++++++++++----- po/wine.pot | 42 ++++++++++++++++++++++----- po/zh_CN.po | 52 ++++++++++++++++++++++++++++----- po/zh_TW.po | 52 ++++++++++++++++++++++++++++----- 49 files changed, 1841 insertions(+), 375 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c9e951dfd3dc0048806c0…

1 0

Jacek Caban : mshtml: Try to install ActiveX if it's not registered.
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: d1f2b8a8093dd7a3917c2aa5e84fd8f72fe30e12 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1f2b8a8093dd7a3917c2aa5e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Nov 2 13:50:09 2012 +0100 mshtml: Try to install ActiveX if it's not registered. --- dlls/mshtml/npplugin.c | 288 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 288 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/npplugin.c b/dlls/mshtml/npplugin.c index 192b8dc..aa74961 100644 --- a/dlls/mshtml/npplugin.c +++ b/dlls/mshtml/npplugin.c @@ -313,6 +313,292 @@ static BOOL get_elem_clsid(nsIDOMElement *elem, CLSID *clsid) return ret; } +typedef struct { + IBindStatusCallback IBindStatusCallback_iface; + IWindowForBindingUI IWindowForBindingUI_iface; + LONG ref; +} InstallCallback; + +static inline InstallCallback *impl_from_IBindStatusCallback(IBindStatusCallback *iface) +{ + return CONTAINING_RECORD(iface, InstallCallback, IBindStatusCallback_iface); +} + +static HRESULT WINAPI InstallCallback_QueryInterface(IBindStatusCallback *iface, + REFIID riid, void **ppv) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + + if(IsEqualGUID(&IID_IUnknown, riid)) { + TRACE("(%p)->(IID_IUnknown %p)\n", This, ppv); + *ppv = &This->IBindStatusCallback_iface; + }else if(IsEqualGUID(&IID_IBindStatusCallback, riid)) { + TRACE("(%p)->(IID_IBindStatusCallback %p)\n", This, ppv); + *ppv = &This->IBindStatusCallback_iface; + }else if(IsEqualGUID(&IID_IWindowForBindingUI, riid)) { + TRACE("(%p)->(IID_IWindowForBindingUI %p)\n", This, ppv); + *ppv = &This->IWindowForBindingUI_iface; + }else { + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), ppv); + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI InstallCallback_AddRef(IBindStatusCallback *iface) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + LONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + return ref; +} + +static ULONG WINAPI InstallCallback_Release(IBindStatusCallback *iface) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + LONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + if(!ref) + heap_free(This); + + return ref; +} + +static HRESULT WINAPI InstallCallback_OnStartBinding(IBindStatusCallback *iface, + DWORD dwReserved, IBinding *pib) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + TRACE("(%p)->(%x %p)\n", This, dwReserved, pib); + return S_OK; +} + +static HRESULT WINAPI InstallCallback_GetPriority(IBindStatusCallback *iface, LONG *pnPriority) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + TRACE("(%p)->(%p)\n", This, pnPriority); + return E_NOTIMPL; +} + +static HRESULT WINAPI InstallCallback_OnLowResource(IBindStatusCallback *iface, DWORD dwReserved) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + TRACE("(%p)->(%x)\n", This, dwReserved); + return S_OK; +} + +static HRESULT WINAPI InstallCallback_OnProgress(IBindStatusCallback *iface, ULONG ulProgress, + ULONG ulProgressMax, ULONG ulStatusCode, LPCWSTR szStatusText) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + TRACE("(%p)->(%u %u %u %s)\n", This, ulProgress, ulProgressMax, ulStatusCode, debugstr_w(szStatusText)); + return S_OK; +} + +static HRESULT WINAPI InstallCallback_OnStopBinding(IBindStatusCallback *iface, + HRESULT hresult, LPCWSTR szError) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + TRACE("(%p)->(%08x %s)\n", This, hresult, debugstr_w(szError)); + return S_OK; +} + +static HRESULT WINAPI InstallCallback_GetBindInfo(IBindStatusCallback *iface, + DWORD* grfBINDF, BINDINFO* pbindinfo) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + + TRACE("(%p)->(%p %p)\n", This, grfBINDF, pbindinfo); + + *grfBINDF = BINDF_ASYNCHRONOUS; + return S_OK; +} + +static HRESULT WINAPI InstallCallback_OnDataAvailable(IBindStatusCallback *iface, DWORD grfBSCF, + DWORD dwSize, FORMATETC* pformatetc, STGMEDIUM* pstgmed) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + ERR("(%p)\n", This); + return E_NOTIMPL; +} + +static HRESULT WINAPI InstallCallback_OnObjectAvailable(IBindStatusCallback *iface, + REFIID riid, IUnknown* punk) +{ + InstallCallback *This = impl_from_IBindStatusCallback(iface); + ERR("(%p)\n", This); + return E_NOTIMPL; +} + +static IBindStatusCallbackVtbl InstallCallbackVtbl = { + InstallCallback_QueryInterface, + InstallCallback_AddRef, + InstallCallback_Release, + InstallCallback_OnStartBinding, + InstallCallback_GetPriority, + InstallCallback_OnLowResource, + InstallCallback_OnProgress, + InstallCallback_OnStopBinding, + InstallCallback_GetBindInfo, + InstallCallback_OnDataAvailable, + InstallCallback_OnObjectAvailable +}; + +static inline InstallCallback *impl_from_IWindowForBindingUI(IWindowForBindingUI *iface) +{ + return CONTAINING_RECORD(iface, InstallCallback, IWindowForBindingUI_iface); +} + +static HRESULT WINAPI WindowForBindingUI_QueryInterface(IWindowForBindingUI *iface, REFIID riid, void **ppv) +{ + InstallCallback *This = impl_from_IWindowForBindingUI(iface); + return IBindStatusCallback_QueryInterface(&This->IBindStatusCallback_iface, riid, ppv); +} + +static ULONG WINAPI WindowForBindingUI_AddRef(IWindowForBindingUI *iface) +{ + InstallCallback *This = impl_from_IWindowForBindingUI(iface); + return IBindStatusCallback_AddRef(&This->IBindStatusCallback_iface); +} + +static ULONG WINAPI WindowForBindingUI_Release(IWindowForBindingUI *iface) +{ + InstallCallback *This = impl_from_IWindowForBindingUI(iface); + return IBindStatusCallback_AddRef(&This->IBindStatusCallback_iface); +} + +static HRESULT WINAPI WindowForBindingUI_GetWindow(IWindowForBindingUI *iface, REFGUID rguidReason, HWND *phwnd) +{ + InstallCallback *This = impl_from_IWindowForBindingUI(iface); + FIXME("(%p)->(%s %p)\n", This, debugstr_guid(rguidReason), phwnd); + *phwnd = NULL; + return S_OK; +} + +static const IWindowForBindingUIVtbl WindowForBindingUIVtbl = { + WindowForBindingUI_QueryInterface, + WindowForBindingUI_AddRef, + WindowForBindingUI_Release, + WindowForBindingUI_GetWindow +}; + +typedef struct { + struct list entry; + IUri *uri; +} install_entry_t; + +static struct list install_list = LIST_INIT(install_list); + +static CRITICAL_SECTION cs_install_list; +static CRITICAL_SECTION_DEBUG cs_install_list_dbg = +{ + 0, 0, &cs_install_list, + { &cs_install_list_dbg.ProcessLocksList, &cs_install_list_dbg.ProcessLocksList }, + 0, 0, { (DWORD_PTR)(__FILE__ ": install_list") } +}; +static CRITICAL_SECTION cs_install_list = { &cs_install_list_dbg, -1, 0, 0, 0, 0 }; + +static void install_codebase(const WCHAR *url) +{ + InstallCallback *callback; + IBindCtx *bctx; + HRESULT hres; + + callback = heap_alloc(sizeof(*callback)); + if(!callback) + return; + + callback->IBindStatusCallback_iface.lpVtbl = &InstallCallbackVtbl; + callback->IWindowForBindingUI_iface.lpVtbl = &WindowForBindingUIVtbl; + callback->ref = 1; + + hres = CreateAsyncBindCtx(0, &callback->IBindStatusCallback_iface, NULL, &bctx); + IBindStatusCallback_Release(&callback->IBindStatusCallback_iface); + if(FAILED(hres)) + return; + + hres = AsyncInstallDistributionUnit(NULL, NULL, NULL, 0, 0, url, bctx, NULL, 0); + IBindCtx_Release(bctx); + if(FAILED(hres)) + WARN("FAILED: %08x\n", hres); +} + +static void check_codebase(HTMLInnerWindow *window, nsIDOMElement *nselem) +{ + nsAString attr_str, val_str; + BOOL is_on_list = FALSE; + install_entry_t *iter; + IUri *uri = NULL; + nsresult nsres; + HRESULT hres; + + static const PRUnichar codebaseW[] = {'c','o','d','e','b','a','s','e',0}; + + nsAString_InitDepend(&attr_str, codebaseW); + nsAString_Init(&val_str, NULL); + nsres = nsIDOMElement_GetAttribute(nselem, &attr_str, &val_str); + nsAString_Finish(&attr_str); + if(NS_SUCCEEDED(nsres)) { + const PRUnichar *val; + + nsAString_GetData(&val_str, &val); + if(*val) { + hres = CoInternetCombineUrlEx(window->base.outer_window->uri, val, 0, &uri, 0); + if(FAILED(hres)) + uri = NULL; + } + }else { + ERR("GetAttribute failed: %08x\n", nsres); + } + + nsAString_Finish(&attr_str); + if(!uri) + return; + + EnterCriticalSection(&cs_install_list); + + LIST_FOR_EACH_ENTRY(iter, &install_list, install_entry_t, entry) { + BOOL eq; + + hres = IUri_IsEqual(uri, iter->uri, &eq); + if(SUCCEEDED(hres) && eq) { + TRACE("already proceeded\n"); + is_on_list = TRUE; + break; + } + } + + if(!is_on_list) { + iter = heap_alloc(sizeof(*iter)); + if(iter) { + IUri_AddRef(uri); + iter->uri = uri; + + list_add_tail(&install_list, &iter->entry); + } + } + + LeaveCriticalSection(&cs_install_list); + + if(!is_on_list) { + BSTR display_uri; + + hres = IUri_GetDisplayUri(uri, &display_uri); + if(SUCCEEDED(hres)) { + install_codebase(display_uri); + SysFreeString(display_uri); + } + } + + IUri_Release(uri); +} + static IUnknown *create_activex_object(HTMLInnerWindow *window, nsIDOMElement *nselem, CLSID *clsid) { IClassFactoryEx *cfex; @@ -337,6 +623,8 @@ static IUnknown *create_activex_object(HTMLInnerWindow *window, nsIDOMElement *n } hres = CoGetClassObject(clsid, CLSCTX_INPROC_SERVER|CLSCTX_LOCAL_SERVER, NULL, &IID_IClassFactory, (void**)&cf); + if(hres == REGDB_E_CLASSNOTREG) + check_codebase(window, nselem); if(FAILED(hres)) return NULL;

1 0

Michael Stefaniuc : localspl: Avoid using sizeof on structs with variable length array.
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: e67deeb8a139f51e63d5f7142c259ca6cd235a40 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e67deeb8a139f51e63d5f7142… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Nov 2 15:11:26 2012 +0100 localspl: Avoid using sizeof on structs with variable length array. --- dlls/localspl/localmon.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/dlls/localspl/localmon.c b/dlls/localspl/localmon.c index f4e1739..8737a06 100644 --- a/dlls/localspl/localmon.c +++ b/dlls/localspl/localmon.c @@ -513,7 +513,6 @@ cleanup: static BOOL WINAPI localmon_OpenPortW(LPWSTR pName, PHANDLE phPort) { port_t * port; - DWORD len; DWORD type; TRACE("%s, %p)\n", debugstr_w(pName), phPort); @@ -525,12 +524,11 @@ static BOOL WINAPI localmon_OpenPortW(LPWSTR pName, PHANDLE phPort) type = get_type_from_local_name(pName); if (!type) return FALSE; - len = (lstrlenW(pName) + 1) * sizeof(WCHAR); - port = heap_alloc(sizeof(port_t) + len); + port = heap_alloc(FIELD_OFFSET(port_t, nameW[lstrlenW(pName) + 1])); if (!port) return FALSE; port->type = type; - memcpy(port->nameW, pName, len); + lstrcpyW(port->nameW, pName); *phPort = port; EnterCriticalSection(&port_handles_cs); @@ -734,16 +732,14 @@ static DWORD WINAPI localmon_XcvDataPort(HANDLE hXcv, LPCWSTR pszDataName, PBYTE */ static BOOL WINAPI localmon_XcvOpenPort(LPCWSTR pName, ACCESS_MASK GrantedAccess, PHANDLE phXcv) { - DWORD len; xcv_t * xcv; TRACE("%s, 0x%x, %p)\n", debugstr_w(pName), GrantedAccess, phXcv); /* No checks for any field is done in Windows */ - len = (lstrlenW(pName) + 1) * sizeof(WCHAR); - xcv = heap_alloc( sizeof(xcv_t) + len); + xcv = heap_alloc(FIELD_OFFSET(xcv_t, nameW[lstrlenW(pName) + 1])); if (xcv) { xcv->GrantedAccess = GrantedAccess; - memcpy(xcv->nameW, pName, len); + lstrcpyW(xcv->nameW, pName); *phXcv = xcv; EnterCriticalSection(&xcv_handles_cs); list_add_tail(&xcv_handles, &xcv->entry);

1 0

Michael Stefaniuc : gdi.exe16: Use FIELD_OFFSET to calculate the size of structs with variable length array .
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: fb724cfd7be65905eadcb832794f83a9bb1ff383 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fb724cfd7be65905eadcb8327… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Nov 2 15:13:55 2012 +0100 gdi.exe16: Use FIELD_OFFSET to calculate the size of structs with variable length array. --- dlls/gdi.exe16/gdi.c | 2 +- dlls/gdi.exe16/metafile.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/gdi.exe16/gdi.c b/dlls/gdi.exe16/gdi.c index ef460b3..2bd070b 100644 --- a/dlls/gdi.exe16/gdi.c +++ b/dlls/gdi.exe16/gdi.c @@ -1982,7 +1982,7 @@ void WINAPI SetRectRgn16( HRGN16 hrgn, INT16 left, INT16 top, INT16 right, INT16 */ void WINAPI PlayMetaFileRecord16( HDC16 hdc, HANDLETABLE16 *ht, METARECORD *mr, UINT16 handles ) { - HANDLETABLE *ht32 = HeapAlloc( GetProcessHeap(), 0, handles * sizeof(*ht32) ); + HANDLETABLE *ht32 = HeapAlloc( GetProcessHeap(), 0, FIELD_OFFSET(HANDLETABLE, objectHandle[handles] )); unsigned int i; for (i = 0; i < handles; i++) ht32->objectHandle[i] = HGDIOBJ_32(ht->objectHandle[i]); diff --git a/dlls/gdi.exe16/metafile.c b/dlls/gdi.exe16/metafile.c index dfde8f7..2f0ccfe 100644 --- a/dlls/gdi.exe16/metafile.c +++ b/dlls/gdi.exe16/metafile.c @@ -213,7 +213,7 @@ BOOL16 WINAPI EnumMetaFile16( HDC16 hdc16, HMETAFILE16 hmf, /* create the handle table */ hHT = GlobalAlloc16(GMEM_MOVEABLE | GMEM_ZEROINIT, - sizeof(HANDLETABLE16) * mh->mtNoObjects); + FIELD_OFFSET(HANDLETABLE16, objectHandle[mh->mtNoObjects])); spht = WOWGlobalLock16(hHT); seg = hmf | 7;

1 0

Michael Stefaniuc : itss: Use FIELD_OFFSET to calculate the size of a struct with variable length array .
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: 815031d8325482cd09d3387564df1587f14d60f6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=815031d8325482cd09d338756… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Nov 2 15:17:06 2012 +0100 itss: Use FIELD_OFFSET to calculate the size of a struct with variable length array. --- dlls/itss/moniker.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/itss/moniker.c b/dlls/itss/moniker.c index dedf4e5..0509c9e 100644 --- a/dlls/itss/moniker.c +++ b/dlls/itss/moniker.c @@ -354,7 +354,7 @@ static HRESULT ITS_IMoniker_create( IMoniker **ppObj, LPCWSTR name, DWORD n ) DWORD sz; /* szFile[1] has space for one character already */ - sz = sizeof(ITS_IMonikerImpl) + strlenW( name )*sizeof(WCHAR); + sz = FIELD_OFFSET( ITS_IMonikerImpl, szFile[strlenW( name ) + 1] ); itsmon = HeapAlloc( GetProcessHeap(), 0, sz ); itsmon->IMoniker_iface.lpVtbl = &ITS_IMonikerImpl_Vtbl;

1 0

Hans Leidekker : wbemprox: Avoid a crash when serializing object text.
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: 6955b09023a0c74af01ecd6a9434ccd58429ecb2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6955b09023a0c74af01ecd6a9… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Nov 2 15:34:27 2012 +0100 wbemprox: Avoid a crash when serializing object text. --- dlls/wbemprox/class.c | 20 ++++++++++++-------- dlls/wbemprox/table.c | 1 + 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/dlls/wbemprox/class.c b/dlls/wbemprox/class.c index 75bd612..994e76b 100644 --- a/dlls/wbemprox/class.c +++ b/dlls/wbemprox/class.c @@ -568,19 +568,23 @@ static BSTR get_body_text( const struct table *table, UINT row, UINT *len ) *len = 0; for (i = 0; i < table->num_cols; i++) { - *len += sizeof(fmtW) / sizeof(fmtW[0]); - *len += strlenW( table->columns[i].name ); - value = get_value_bstr( table, row, i ); - *len += SysStringLen( value ); - SysFreeString( value ); + if ((value = get_value_bstr( table, row, i ))) + { + *len += sizeof(fmtW) / sizeof(fmtW[0]); + *len += strlenW( table->columns[i].name ); + *len += SysStringLen( value ); + SysFreeString( value ); + } } if (!(ret = SysAllocStringLen( NULL, *len ))) return NULL; p = ret; for (i = 0; i < table->num_cols; i++) { - value = get_value_bstr( table, row, i ); - p += sprintfW( p, fmtW, table->columns[i].name, value ); - SysFreeString( value ); + if ((value = get_value_bstr( table, row, i ))) + { + p += sprintfW( p, fmtW, table->columns[i].name, value ); + SysFreeString( value ); + } } return ret; } diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c index 43ab91d..c114e53 100644 --- a/dlls/wbemprox/table.c +++ b/dlls/wbemprox/table.c @@ -166,6 +166,7 @@ BSTR get_value_bstr( const struct table *table, UINT row, UINT column ) case CIM_DATETIME: case CIM_STRING: + if (!val) return NULL; len = strlenW( (const WCHAR *)(INT_PTR)val ) + 2; if (!(ret = SysAllocStringLen( NULL, len ))) return NULL; sprintfW( ret, fmt_strW, (const WCHAR *)(INT_PTR)val );

1 0

Hans Leidekker : msi: Return length for the empty string in msi_string_lookup.
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: 31ea3f44ddd5f964e7479f1f10c53392f06f18e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=31ea3f44ddd5f964e7479f1f1… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Nov 2 15:35:34 2012 +0100 msi: Return length for the empty string in msi_string_lookup. --- dlls/msi/string.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/msi/string.c b/dlls/msi/string.c index 5e2c574..486cdf9 100644 --- a/dlls/msi/string.c +++ b/dlls/msi/string.c @@ -352,8 +352,10 @@ int msi_addstringW( string_table *st, const WCHAR *data, int len, USHORT refcoun const WCHAR *msi_string_lookup( const string_table *st, UINT id, int *len ) { if( id == 0 ) + { + if (len) *len = 0; return szEmpty; - + } if( id >= st->maxcount ) return NULL;

1 0

Piotr Caban : msvcp71: Ignore prot argument in Fiopen_wchar function.
by Alexandre Julliard 02 Nov '12

02 Nov '12

Module: wine Branch: master Commit: 79f314c31a2659ca820a49a843ed1771d98fdecb URL: http://source.winehq.org/git/wine.git/?a=commit;h=79f314c31a2659ca820a49a84… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 2 17:18:07 2012 +0100 msvcp71: Ignore prot argument in Fiopen_wchar function. --- dlls/msvcp71/ios.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/msvcp71/ios.c b/dlls/msvcp71/ios.c index c538cf7..12e217f 100644 --- a/dlls/msvcp71/ios.c +++ b/dlls/msvcp71/ios.c @@ -2587,8 +2587,9 @@ static FILE* _Fiopen_wchar(const wchar_t *name, int mode, int prot) return NULL; } + /* msvcp60 - msvcp71 are ignoring prot argument */ f = _wfsopen(name, (mode & OPENMODE_binary) ? str_mode[mode_idx].str_bin - : str_mode[mode_idx].str, prot); + : str_mode[mode_idx].str, SH_DENYNO); if(!f) return NULL;

1 0