December 2012 - Wine-commits

Jason Edmeades : cmd: Convert the set /a tests to validate better.
by Alexandre Julliard 21 Dec '12

21 Dec '12

Module: wine Branch: master Commit: 836f3e4c2945c318ed93bfbe0ef3e0e8309c6416 URL: http://source.winehq.org/git/wine.git/?a=commit;h=836f3e4c2945c318ed93bfbe0… Author: Jason Edmeades <jason(a)edmeades.me.uk> Date: Wed Dec 12 00:30:45 2012 +0000 cmd: Convert the set /a tests to validate better. --- programs/cmd/tests/test_builtins.cmd | 167 +++++++++++++++++------------- programs/cmd/tests/test_builtins.cmd.exp | 147 ++++++++++++++------------ 2 files changed, 176 insertions(+), 138 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=836f3e4c2945c318ed93b…

1 0

Jason Edmeades : cmd: Add more tests for set /a.
by Alexandre Julliard 21 Dec '12

21 Dec '12

Module: wine Branch: master Commit: 51c4411a158d44cfee56487a37fc066503f2c431 URL: http://source.winehq.org/git/wine.git/?a=commit;h=51c4411a158d44cfee56487a3… Author: Jason Edmeades <jason(a)edmeades.me.uk> Date: Thu Dec 13 20:47:16 2012 +0000 cmd: Add more tests for set /a. --- programs/cmd/tests/test_builtins.cmd | 135 ++++++++++++++++++++++++++++++ programs/cmd/tests/test_builtins.cmd.exp | 83 ++++++++++++++++++ 2 files changed, 218 insertions(+), 0 deletions(-) diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index 6cf2ecb..508691e 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -1131,6 +1131,141 @@ set /a WINE_foo=WINE_bar=5, WINE_bar ^|= 2 & call :checkenvvars WINE_foo 5 WINE_ set /a WINE_foo=WINE_bar=5, WINE_bar ^^= 2 & call :checkenvvars WINE_foo 5 WINE_bar 7 set WINE_baz=4 set /a WINE_foo=WINE_bar=19, WINE_bar %%= 4 + (WINE_baz %%= 7) & call :checkenvvars WINE_foo 19 WINE_bar 3 WINE_baz 4 +echo --- quotes +set /a WINE_foo=1 +call :checkenvvars WINE_foo 1 +set /a "WINE_foo=1" +call :checkenvvars WINE_foo 1 +set /a WINE_foo=1,WINE_bar=2 +call :checkenvvars WINE_foo 1 WINE_bar 2 +set /a "WINE_foo=1,WINE_bar=2" +call :checkenvvars WINE_foo 1 WINE_bar 2 +set /a "WINE_foo=1","WINE_bar=2" +call :checkenvvars WINE_foo 1 WINE_bar 2 +set /a ""WINE_foo=1","WINE_bar=2"" +call :checkenvvars WINE_foo 1 WINE_bar 2 +set /a WINE_foo=1,WINE_bar=2,WINE_baz=3 +call :checkenvvars WINE_foo 1 WINE_bar 2 WINE_baz 3 +set /a "WINE_foo=1,WINE_bar=2,WINE_baz=3" +call :checkenvvars WINE_foo 1 WINE_bar 2 WINE_baz 3 +set /a "WINE_foo=1","WINE_bar=2","WINE_baz=3" +call :checkenvvars WINE_foo 1 WINE_bar 2 WINE_baz 3 +set /a ""WINE_foo=1","WINE_bar=2","WINE_baz=3"" +call :checkenvvars WINE_foo 1 WINE_bar 2 WINE_baz 3 +set /a ""WINE_foo=1","WINE_bar=2"","WINE_baz=3" +call :checkenvvars WINE_foo 1 WINE_bar 2 WINE_baz 3 +set /a """"""WINE_foo=1"""""" +call :checkenvvars WINE_foo 1 +set /a """"""WINE_foo=1","WINE_bar=5""","WINE_baz=2"" +call :checkenvvars WINE_foo 1 WINE_bar 5 WINE_baz 2 +set /a WINE_foo="3"+"4"+"5+6" +call :checkenvvars WINE_foo 18 +set WINE_foo=3 +set /a WINE_bar="WINE_""foo"+4 +call :checkenvvars WINE_foo 3 WINE_bar 7 +echo --- whitespace are ignored between double char operators +set WINE_foo=4 +set WINE_bar=5 +set /a WINE_foo + = 6 +set /a WINE_bar * = WINE_foo +call :checkenvvars WINE_foo 10 WINE_bar 50 +set WINE_foo=4 +set WINE_bar=5 +set /a WINE_foo + = "6 < < 7" +set /a WINE_bar * = WINE_foo + WINE_foo +call :checkenvvars WINE_foo 772 WINE_bar 7720 +set /a WINE_foo=6 7 +set /a WINE_ var1=8 +set WINE_foo= +echo --- invalid operator sequence +set WINE_foo=4 +set /a =4 +set /a *=4 +set /a ^>=4" +set /a ^<=4" +set /a WINE_foo^>^<=4 +echo %WINE_foo% +set /a WINE_foo^>^>^>=4 +echo %WINE_foo% +echo ----- negative prefix +set /a WINE_foo=-1 +call :checkenvvars WINE_foo -1 +set /a WINE_foo=--1 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=3--3 +call :checkenvvars WINE_foo 6 +set /a WINE_foo=3---3 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=3----3 +call :checkenvvars WINE_foo 6 +set /a WINE_foo=-~1 +call :checkenvvars WINE_foo 2 +set /a WINE_foo=~-1 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=3+-~1 +call :checkenvvars WINE_foo 5 +set /a WINE_foo=3+~-1 +call :checkenvvars WINE_foo 3 +echo ----- assignment tests involving the end destination +set WINE_foo=3 +set /a WINE_foo+=3+(WINE_foo=4) +call :checkenvvars WINE_foo 11 +set WINE_foo=2 +set /a WINE_bar=3+(WINE_foo=6) +call :checkenvvars WINE_foo 6 WINE_bar 9 +set WINE_foo=2 +set /a WINE_bar=3+(WINE_foo=6,WINE_baz=7) +call :checkenvvars WINE_foo 6 WINE_bar 10 WINE_baz 7 +set WINE_foo=2 +set /a WINE_bar=WINE_foo=7 +call :checkenvvars WINE_foo 7 WINE_bar 7 +echo ----- equal precedence on stack +rem Unary - dont reduce if precedence is equal +set /a WINE_foo=!!1 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=!!0 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=~~1 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=~~0 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=--1 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=+-1 +call :checkenvvars WINE_foo -1 +set /a WINE_foo=-+1 +call :checkenvvars WINE_foo -1 +set /a WINE_foo=++1 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=!~1 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=~!1 +call :checkenvvars WINE_foo -1 +set /a WINE_foo=!-1 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=-!1 +call :checkenvvars WINE_foo 0 +set /a WINE_foo=!-0 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=-!0 +call :checkenvvars WINE_foo -1 +rem Aritmatic - Reduce if precedence is equal +set /a WINE_foo=10*5/2 +call :checkenvvars WINE_foo 25 +set /a WINE_foo=5/2*10 +call :checkenvvars WINE_foo 20 +set /a WINE_foo=10/5/2 +call :checkenvvars WINE_foo 1 +set /a WINE_foo=5%%2*4 +call :checkenvvars WINE_foo 4 +set /a WINE_foo=10-5+2 +call :checkenvvars WINE_foo 7 +set /a WINE_foo=1^<^<4^>^>1 +call :checkenvvars WINE_foo 8 +rem Assignment - dont reduce if precedence is equal +set /a WINE_foo=5 +set /a WINE_bar=WINE_foo=6 +call :checkenvvars WINE_foo 6 WINE_bar 6 echo --- for /F mkdir foobar & cd foobar diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index fd59c31..9e7f30b 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -800,6 +800,89 @@ WINE_bar correctly 4 @todo_wine(a)WINE_foo correctly 19(a)or_broken@ERROR: WINE_foo incorrectly 0 [19] @todo_wine(a)WINE_bar correctly 3(a)or_broken@ERROR: WINE_bar incorrectly [3] WINE_baz correctly 4 +--- quotes +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_baz correctly 3 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_baz correctly 3 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_baz correctly 3 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_baz correctly 3 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 2 +(a)todo_wine@WINE_baz correctly 3 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_bar correctly 5 +(a)todo_wine@WINE_baz correctly 2 +(a)todo_wine@WINE_foo correctly 18 +WINE_foo correctly 3 +(a)todo_wine@WINE_bar correctly 7(a)or_broken@ERROR: WINE_bar incorrectly 4 [7] +--- whitespace are ignored between double char operators +(a)todo_wine@WINE_foo correctly 10(a)or_broken@ERROR: WINE_foo incorrectly 4 [10] +(a)todo_wine@WINE_bar correctly 50(a)or_broken@ERROR: WINE_bar incorrectly 5 [50] +(a)todo_wine@WINE_foo correctly 772(a)or_broken@ERROR: WINE_foo incorrectly 4 [772] +(a)todo_wine@WINE_bar correctly 7720(a)or_broken@ERROR: WINE_bar incorrectly 5 [7720] +--- invalid operator sequence +4 +4 +----- negative prefix +(a)todo_wine@WINE_foo correctly -1 +(a)todo_wine@WINE_foo correctly 1(a)or_broken@ERROR: WINE_foo incorrectly [1] +(a)todo_wine@WINE_foo correctly 6 +(a)todo_wine@WINE_foo correctly 0 +(a)todo_wine@WINE_foo correctly 6 +(a)todo_wine@WINE_foo correctly 2 +(a)todo_wine@WINE_foo correctly 0(a)or_broken@ERROR: WINE_foo incorrectly [0] +(a)todo_wine@WINE_foo correctly 5 +(a)todo_wine@WINE_foo correctly 3(a)or_broken@ERROR: WINE_foo incorrectly -5 [3] +----- assignment tests involving the end destination +(a)todo_wine@WINE_foo correctly 11(a)or_broken@ERROR: WINE_foo incorrectly 3 [11] +(a)todo_wine@WINE_foo correctly 6(a)or_broken@ERROR: WINE_foo incorrectly 2 [6] +(a)todo_wine@WINE_bar correctly 9(a)or_broken@ERROR: WINE_bar incorrectly [9] +(a)todo_wine@WINE_foo correctly 6(a)or_broken@ERROR: WINE_foo incorrectly 2 [6] +(a)todo_wine@WINE_bar correctly 10(a)or_broken@ERROR: WINE_bar incorrectly [10] +(a)todo_wine@WINE_baz correctly 7(a)or_broken@ERROR: WINE_baz incorrectly [7] +(a)todo_wine@WINE_foo correctly 7(a)or_broken@ERROR: WINE_foo incorrectly 2 [7] +(a)todo_wine@WINE_bar correctly 7(a)or_broken@ERROR: WINE_bar incorrectly 2 [7] +----- equal precedence on stack +(a)todo_wine@WINE_foo correctly 1(a)or_broken@ERROR: WINE_foo incorrectly 0 [1] +(a)todo_wine@WINE_foo correctly 0 +(a)todo_wine@WINE_foo correctly 1(a)or_broken@ERROR: WINE_foo incorrectly [1] +(a)todo_wine@WINE_foo correctly 0(a)or_broken@ERROR: WINE_foo incorrectly [0] +(a)todo_wine@WINE_foo correctly 1(a)or_broken@ERROR: WINE_foo incorrectly [1] +(a)todo_wine@WINE_foo correctly -1(a)or_broken@ERROR: WINE_foo incorrectly [-1] +(a)todo_wine@WINE_foo correctly -1(a)or_broken@ERROR: WINE_foo incorrectly [-1] +(a)todo_wine@WINE_foo correctly 1(a)or_broken@ERROR: WINE_foo incorrectly [1] +(a)todo_wine@WINE_foo correctly 0(a)or_broken@ERROR: WINE_foo incorrectly [0] +(a)todo_wine@WINE_foo correctly -1 +(a)todo_wine@WINE_foo correctly 0(a)or_broken@ERROR: WINE_foo incorrectly -1 [0] +(a)todo_wine@WINE_foo correctly 0 +(a)todo_wine@WINE_foo correctly 1(a)or_broken@ERROR: WINE_foo incorrectly 0 [1] +(a)todo_wine@WINE_foo correctly -1(a)or_broken@ERROR: WINE_foo incorrectly 0 [-1] +(a)todo_wine@WINE_foo correctly 25(a)or_broken@ERROR: WINE_foo incorrectly 20 [25] +(a)todo_wine@WINE_foo correctly 20 +(a)todo_wine@WINE_foo correctly 1 +(a)todo_wine@WINE_foo correctly 4 +(a)todo_wine@WINE_foo correctly 7 +(a)todo_wine@WINE_foo correctly 8(a)or_broken@ERROR: WINE_foo incorrectly 4 [8] +(a)todo_wine@WINE_foo correctly 6(a)or_broken@ERROR: WINE_foo incorrectly 5 [6] +(a)todo_wine@WINE_bar correctly 6(a)or_broken@ERROR: WINE_bar incorrectly 5 [6] --- for /F ------ string argument a

1 0

Ann and Jason Edmeades : cmd: Add set /a support.
by Alexandre Julliard 21 Dec '12

21 Dec '12

1 0

Andrew Talbot : oleaut32: Indentation fix.
by Alexandre Julliard 21 Dec '12

21 Dec '12

Module: wine Branch: master Commit: b2b4bb9a1279e16e1a87f6f78dc9496583838ca2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b2b4bb9a1279e16e1a87f6f78… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Thu Dec 20 19:35:35 2012 +0000 oleaut32: Indentation fix. --- dlls/oleaut32/tmarshal.c | 4 ++-- dlls/oleaut32/variant.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/oleaut32/tmarshal.c b/dlls/oleaut32/tmarshal.c index 8b47eed..2324fbb 100644 --- a/dlls/oleaut32/tmarshal.c +++ b/dlls/oleaut32/tmarshal.c @@ -1208,7 +1208,7 @@ deserialize_param( ); return S_OK; } - case VT_SAFEARRAY: { + case VT_SAFEARRAY: { if (readit) { ULONG flags = MAKELONG(MSHCTX_DIFFERENTMACHINE, NDR_LOCAL_DATA_REPRESENTATION); @@ -1630,7 +1630,7 @@ static ULONG WINAPI TMarshalDispatchChannel_Release(LPRPCCHANNELBUFFER iface) if (ref) return ref; - IRpcChannelBuffer_Release(This->pDelegateChannel); + IRpcChannelBuffer_Release(This->pDelegateChannel); HeapFree(GetProcessHeap(), 0, This); return 0; } diff --git a/dlls/oleaut32/variant.c b/dlls/oleaut32/variant.c index 21a2758..c343578 100644 --- a/dlls/oleaut32/variant.c +++ b/dlls/oleaut32/variant.c @@ -3131,9 +3131,9 @@ HRESULT WINAPI VarAnd(LPVARIANT left, LPVARIANT right, LPVARIANT result) LOCALE_USER_DEFAULT, 0, &d))) hres = VariantChangeType(&varLeft,&varLeft, VARIANT_LOCALBOOL, VT_BOOL); - if (SUCCEEDED(hres) && V_VT(&varLeft) != resvt) - hres = VariantChangeType(&varLeft,&varLeft,0,resvt); - if (FAILED(hres)) goto VarAnd_Exit; + if (SUCCEEDED(hres) && V_VT(&varLeft) != resvt) + hres = VariantChangeType(&varLeft,&varLeft,0,resvt); + if (FAILED(hres)) goto VarAnd_Exit; } if (resvt == VT_I4 && V_VT(&varRight) == VT_UI4)

1 0

Andrew Talbot : rsaenh: Indentation fix.
by Alexandre Julliard 21 Dec '12

21 Dec '12

Module: wine Branch: master Commit: d7d1e402403632a4b75b8056b88ef7b6573be926 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7d1e402403632a4b75b8056b… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Thu Dec 20 19:41:46 2012 +0000 rsaenh: Indentation fix. --- dlls/rsaenh/mpi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/rsaenh/mpi.c b/dlls/rsaenh/mpi.c index 055da3d..6662527 100644 --- a/dlls/rsaenh/mpi.c +++ b/dlls/rsaenh/mpi.c @@ -3519,8 +3519,8 @@ mp_read_unsigned_bin (mp_int * a, const unsigned char *b, int c) return res; } - a->dp[0] |= *b++; - a->used += 1; + a->dp[0] |= *b++; + a->used += 1; } mp_clamp (a); return MP_OKAY;

1 0

Andrew Talbot : shell32: Indentation fix.
by Alexandre Julliard 21 Dec '12

21 Dec '12

Module: wine Branch: master Commit: 1d7a407f6d2b90f661ca1da3e544930d3c913e70 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d7a407f6d2b90f661ca1da3e… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Thu Dec 20 21:55:34 2012 +0000 shell32: Indentation fix. --- dlls/shell32/classes.c | 14 ++++++------ dlls/shell32/control.c | 2 +- dlls/shell32/debughlp.c | 48 ++++++++++++++++++++++---------------------- dlls/shell32/enumidlist.c | 4 +- dlls/shell32/shlview.c | 26 ++++++++++++------------ 5 files changed, 47 insertions(+), 47 deletions(-) diff --git a/dlls/shell32/classes.c b/dlls/shell32/classes.c index a56af62..10ff970 100644 --- a/dlls/shell32/classes.c +++ b/dlls/shell32/classes.c @@ -56,9 +56,9 @@ BOOL HCR_MapTypeToValueW(LPCWSTR szExtension, LPWSTR szFileType, LONG len, BOOL TRACE("%s %p\n", debugstr_w(szExtension), szFileType); - /* added because we do not want to have double dots */ - if (szExtension[0] == '.') - bPrependDot = 0; + /* added because we do not want to have double dots */ + if (szExtension[0] == '.') + bPrependDot = 0; if (bPrependDot) szTemp[0] = '.'; @@ -90,9 +90,9 @@ BOOL HCR_MapTypeToValueA(LPCSTR szExtension, LPSTR szFileType, LONG len, BOOL bP TRACE("%s %p\n", szExtension, szFileType); - /* added because we do not want to have double dots */ - if (szExtension[0] == '.') - bPrependDot = 0; + /* added because we do not want to have double dots */ + if (szExtension[0] == '.') + bPrependDot = 0; if (bPrependDot) szTemp[0] = '.'; @@ -252,7 +252,7 @@ static BOOL HCR_RegGetDefaultIconA(HKEY hkey, LPSTR szDest, DWORD len, int* pico if (!RegQueryValueExA(hkey, NULL, 0, &dwType, (LPBYTE)szDest, &len)) { - if (dwType == REG_EXPAND_SZ) + if (dwType == REG_EXPAND_SZ) { ExpandEnvironmentStringsA(szDest, sTemp, MAX_PATH); lstrcpynA(szDest, sTemp, len); diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c index 505aff5..659a871 100644 --- a/dlls/shell32/control.c +++ b/dlls/shell32/control.c @@ -759,7 +759,7 @@ static void Control_DoLaunch(CPanel* panel, HWND hWnd, LPCWSTR wszCmd) } } if (ch == '\0') break; - beg = end + 1; + beg = end + 1; if (ch == ' ') while (end[1] == ' ') end++; } end++; diff --git a/dlls/shell32/debughlp.c b/dlls/shell32/debughlp.c index f5d64c3..3d417f8 100644 --- a/dlls/shell32/debughlp.c +++ b/dlls/shell32/debughlp.c @@ -259,21 +259,21 @@ void _dbg_ILSimpleGetText (LPCITEMIDLIST pidl, LPSTR szOut, UINT uOutSize) void pdump (LPCITEMIDLIST pidl) { - LPCITEMIDLIST pidltemp = pidl; + LPCITEMIDLIST pidltemp = pidl; - if (!TRACE_ON(pidl)) return; + if (!TRACE_ON(pidl)) return; - if (! pidltemp) - { - MESSAGE ("-------- pidl=NULL (Desktop)\n"); - } - else - { - MESSAGE ("-------- pidl=%p\n", pidl); - if (pidltemp->mkid.cb) - { - do - { + if (! pidltemp) + { + MESSAGE ("-------- pidl=NULL (Desktop)\n"); + } + else + { + MESSAGE ("-------- pidl=%p\n", pidl); + if (pidltemp->mkid.cb) + { + do + { if (_ILIsUnicode(pidltemp)) { DWORD dwAttrib = 0; @@ -309,16 +309,16 @@ void pdump (LPCITEMIDLIST pidl) debugstr_a(szName), debugstr_a(szLongName), debugstr_a(szShortName)); } - pidltemp = _dbg_ILGetNext(pidltemp); + pidltemp = _dbg_ILGetNext(pidltemp); - } while (pidltemp && pidltemp->mkid.cb); - } - else - { - MESSAGE ("empty pidl (Desktop)\n"); - } - pcheck(pidl); - } + } while (pidltemp && pidltemp->mkid.cb); + } + else + { + MESSAGE ("empty pidl (Desktop)\n"); + } + pcheck(pidl); + } } static void dump_pidl_hex( LPCITEMIDLIST pidl ) diff --git a/dlls/shell32/enumidlist.c b/dlls/shell32/enumidlist.c index 8ee789b..6c705af 100644 --- a/dlls/shell32/enumidlist.c +++ b/dlls/shell32/enumidlist.c @@ -45,8 +45,8 @@ BOOL AddToEnumList(IEnumIDListImpl *This, LPITEMIDLIST pidl) TRACE("(%p)->(pidl=%p)\n",This,pidl); - if (!This || !pidl) - return FALSE; + if (!This || !pidl) + return FALSE; pNew = SHAlloc(sizeof(*pNew)); if(pNew) diff --git a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c index 4f488ca..7738694 100644 --- a/dlls/shell32/shlview.c +++ b/dlls/shell32/shlview.c @@ -380,19 +380,19 @@ static BOOL ShellView_CreateList (IShellViewImpl * This) This->ListViewSortInfo.nHeaderID = -1; This->ListViewSortInfo.nLastHeaderID = -1; - if (This->FolderSettings.fFlags & FWF_DESKTOP) { - /* - * FIXME: look at the registry value - * HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\ListviewShadow - * and activate drop shadows if necessary - */ - if (0) - SendMessageW(This->hWndList, LVM_SETTEXTBKCOLOR, 0, CLR_NONE); - else - SendMessageW(This->hWndList, LVM_SETTEXTBKCOLOR, 0, GetSysColor(COLOR_DESKTOP)); - - SendMessageW(This->hWndList, LVM_SETTEXTCOLOR, 0, RGB(255,255,255)); - } + if (This->FolderSettings.fFlags & FWF_DESKTOP) { + /* + * FIXME: look at the registry value + * HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\ListviewShadow + * and activate drop shadows if necessary + */ + if (0) + SendMessageW(This->hWndList, LVM_SETTEXTBKCOLOR, 0, CLR_NONE); + else + SendMessageW(This->hWndList, LVM_SETTEXTBKCOLOR, 0, GetSysColor(COLOR_DESKTOP)); + + SendMessageW(This->hWndList, LVM_SETTEXTCOLOR, 0, RGB(255,255,255)); + } /* UpdateShellSettings(); */ return TRUE;

1 0

Christian Costa : dmloader: Use dump_DMUS_OBJECTDESC to dump data to avoid truncation in TRACE.
by Alexandre Julliard 20 Dec '12

20 Dec '12

Module: wine Branch: master Commit: cdf727ebd10e15f92f3578410b43498fbd0b8118 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdf727ebd10e15f92f3578410… Author: Christian Costa <titan.costa(a)gmail.com> Date: Wed Dec 19 09:57:38 2012 +0100 dmloader: Use dump_DMUS_OBJECTDESC to dump data to avoid truncation in TRACE. --- dlls/dmloader/container.c | 6 ++++-- dlls/dmloader/debug.c | 40 ++++++++++++++++++---------------------- dlls/dmloader/debug.h | 2 +- dlls/dmloader/loader.c | 25 +++++++++++++++++++------ 4 files changed, 42 insertions(+), 31 deletions(-) diff --git a/dlls/dmloader/container.c b/dlls/dmloader/container.c index 1c8bf31..68ee573 100644 --- a/dlls/dmloader/container.c +++ b/dlls/dmloader/container.c @@ -420,8 +420,10 @@ static HRESULT WINAPI IDirectMusicContainerImpl_IDirectMusicObject_ParseDescript } } - TRACE(": returning descriptor:\n%s\n", debugstr_DMUS_OBJECTDESC(pDesc)); - return S_OK; + TRACE(": returning descriptor:\n"); + if (TRACE_ON(dmloader)) + dump_DMUS_OBJECTDESC(pDesc); + return S_OK; } static const IDirectMusicObjectVtbl DirectMusicContainer_Object_Vtbl = { diff --git a/dlls/dmloader/debug.c b/dlls/dmloader/debug.c index 95c5df2..9e5c576 100644 --- a/dlls/dmloader/debug.c +++ b/dlls/dmloader/debug.c @@ -22,6 +22,8 @@ #include "dmloader_private.h" +WINE_DEFAULT_DEBUG_CHANNEL(dmloader); + /* figures out whether given FOURCC is valid DirectMusic form ID */ BOOL IS_VALID_DMFORM (FOURCC chunkID) { if ((chunkID == DMUS_FOURCC_AUDIOPATH_FORM) || (chunkID == DMUS_FOURCC_BAND_FORM) || (chunkID == DMUS_FOURCC_CHORDMAP_FORM) @@ -479,28 +481,22 @@ static const char *debugstr_DMUS_CONTAINED_OBJF_FLAGS (DWORD flagmask) { return debugstr_flags (flagmask, flags, sizeof(flags)/sizeof(flags[0])); } -const char *debugstr_DMUS_OBJECTDESC (LPDMUS_OBJECTDESC pDesc) { - if (pDesc) { - char buffer[1024], *ptr = buffer; - - ptr += sprintf(ptr, "DMUS_OBJECTDESC (%p):", pDesc); - ptr += sprintf(ptr, "\n - dwSize = 0x%08X", pDesc->dwSize); - ptr += sprintf(ptr, "\n - dwValidData = 0x%08X (%s)", pDesc->dwValidData, debugstr_DMUS_OBJ_FLAGS (pDesc->dwValidData)); - if (pDesc->dwValidData & DMUS_OBJ_CLASS) ptr += sprintf(ptr, "\n - guidClass = %s", debugstr_dmguid(&pDesc->guidClass)); - if (pDesc->dwValidData & DMUS_OBJ_OBJECT) ptr += sprintf(ptr, "\n - guidObject = %s", debugstr_guid(&pDesc->guidObject)); - if (pDesc->dwValidData & DMUS_OBJ_DATE) ptr += sprintf(ptr, "\n - ftDate = %s", debugstr_filetime (&pDesc->ftDate)); - if (pDesc->dwValidData & DMUS_OBJ_VERSION) ptr += sprintf(ptr, " - vVersion = %s", debugstr_dmversion(&pDesc->vVersion)); - if (pDesc->dwValidData & DMUS_OBJ_NAME) ptr += sprintf(ptr, "\n - wszName = %s", debugstr_w(pDesc->wszName)); - if (pDesc->dwValidData & DMUS_OBJ_CATEGORY) ptr += sprintf(ptr, "\n - wszCategory = %s", debugstr_w(pDesc->wszCategory)); - if (pDesc->dwValidData & DMUS_OBJ_FILENAME) ptr += sprintf(ptr, "\n - wszFileName = %s", debugstr_w(pDesc->wszFileName)); - if (pDesc->dwValidData & DMUS_OBJ_MEMORY) ptr += sprintf(ptr, "\n - llMemLength = 0x%s\n - pbMemData = %p", - wine_dbgstr_longlong(pDesc->llMemLength), pDesc->pbMemData); - if (pDesc->dwValidData & DMUS_OBJ_STREAM) ptr += sprintf(ptr, "\n - pStream = %p", pDesc->pStream); - - return wine_dbg_sprintf("%s", buffer); - } else { - return wine_dbg_sprintf("(NULL)"); - } +/* Dump whole DMUS_OBJECTDESC struct */ +void dump_DMUS_OBJECTDESC(LPDMUS_OBJECTDESC desc) +{ + TRACE("DMUS_OBJECTDESC (%p):\n", desc); + TRACE(" - dwSize = %d\n", desc->dwSize); + TRACE(" - dwValidData = %s\n", debugstr_DMUS_OBJ_FLAGS (desc->dwValidData)); + if (desc->dwValidData & DMUS_OBJ_CLASS) TRACE(" - guidClass = %s\n", debugstr_dmguid(&desc->guidClass)); + if (desc->dwValidData & DMUS_OBJ_OBJECT) TRACE(" - guidObject = %s\n", debugstr_guid(&desc->guidObject)); + if (desc->dwValidData & DMUS_OBJ_DATE) TRACE(" - ftDate = %s\n", debugstr_filetime (&desc->ftDate)); + if (desc->dwValidData & DMUS_OBJ_VERSION) TRACE(" - vVersion = %s\n", debugstr_dmversion(&desc->vVersion)); + if (desc->dwValidData & DMUS_OBJ_NAME) TRACE(" - wszName = %s\n", debugstr_w(desc->wszName)); + if (desc->dwValidData & DMUS_OBJ_CATEGORY) TRACE(" - wszCategory = %s\n", debugstr_w(desc->wszCategory)); + if (desc->dwValidData & DMUS_OBJ_FILENAME) TRACE(" - wszFileName = %s\n", debugstr_w(desc->wszFileName)); + if (desc->dwValidData & DMUS_OBJ_MEMORY) TRACE(" - llMemLength = 0x%s\n - pbMemData = %p\n", + wine_dbgstr_longlong(desc->llMemLength), desc->pbMemData); + if (desc->dwValidData & DMUS_OBJ_STREAM) TRACE(" - pStream = %p\n", desc->pStream); } const char *debugstr_DMUS_IO_CONTAINER_HEADER (LPDMUS_IO_CONTAINER_HEADER pHeader) { diff --git a/dlls/dmloader/debug.h b/dlls/dmloader/debug.h index 546d643..40af340 100644 --- a/dlls/dmloader/debug.h +++ b/dlls/dmloader/debug.h @@ -57,7 +57,7 @@ extern const char *debugstr_dmguid (const GUID *id) DECLSPEC_HIDDEN; extern const char *debugstr_dmreturn (DWORD code) DECLSPEC_HIDDEN; /* dump whole DMUS_OBJECTDESC struct */ -extern const char *debugstr_DMUS_OBJECTDESC (LPDMUS_OBJECTDESC pDesc) DECLSPEC_HIDDEN; +extern void dump_DMUS_OBJECTDESC(DMUS_OBJECTDESC *desc) DECLSPEC_HIDDEN; extern const char *debugstr_DMUS_IO_CONTAINER_HEADER (LPDMUS_IO_CONTAINER_HEADER pHeader) DECLSPEC_HIDDEN; extern const char *debugstr_DMUS_IO_CONTAINED_OBJECT_HEADER (LPDMUS_IO_CONTAINED_OBJECT_HEADER pHeader) DECLSPEC_HIDDEN; diff --git a/dlls/dmloader/loader.c b/dlls/dmloader/loader.c index ffffd6a..9a4bddc 100644 --- a/dlls/dmloader/loader.c +++ b/dlls/dmloader/loader.c @@ -1,4 +1,5 @@ -/* IDirectMusicLoaderImpl +/* + * IDirectMusicLoaderImpl * * Copyright (C) 2003-2004 Rok Mandeljc * @@ -32,7 +33,9 @@ static HRESULT DMUSIC_SetLoaderSettings(IDirectMusicLoader8 *iface, REFGUID clas static HRESULT DMUSIC_CopyDescriptor(DMUS_OBJECTDESC *pDst, DMUS_OBJECTDESC *pSrc) { - TRACE(": copy\n%s\n", debugstr_DMUS_OBJECTDESC(pSrc)); + if (TRACE_ON(dmloader)) + dump_DMUS_OBJECTDESC(pSrc); + /* copy field by field */ if (pSrc->dwValidData & DMUS_OBJ_CLASS) pDst->guidClass = pSrc->guidClass; if (pSrc->dwValidData & DMUS_OBJ_OBJECT) pDst->guidObject = pSrc->guidObject; @@ -135,7 +138,10 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_GetObject(IDirectMusicLoader8 *ifac DMUS_OBJECTDESC GotDesc; BOOL bCache; - TRACE("(%p, %p, %s, %p): pDesc:\n%s\n", This, pDesc, debugstr_dmguid(riid), ppv, debugstr_DMUS_OBJECTDESC(pDesc)); + TRACE("(%p)->(%p, %s, %p)\n", This, pDesc, debugstr_dmguid(riid), ppv); + + if (TRACE_ON(dmloader)) + dump_DMUS_OBJECTDESC(pDesc); /* sometimes it happens that guidClass is missing... which is a BadThingTM */ if (!(pDesc->dwValidData & DMUS_OBJ_CLASS)) { @@ -385,7 +391,10 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_SetObject(IDirectMusicLoader8 *ifac LPWINE_LOADER_ENTRY pObjectEntry, pNewEntry; HRESULT hr; - TRACE("(%p, %p): pDesc:\n%s\n", This, pDesc, debugstr_DMUS_OBJECTDESC(pDesc)); + TRACE("(%p)->(%p)\n", This, pDesc); + + if (TRACE_ON(dmloader)) + dump_DMUS_OBJECTDESC(pDesc); /* create stream and load additional info from it */ if (pDesc->dwValidData & DMUS_OBJ_FILENAME) { @@ -488,7 +497,9 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_SetObject(IDirectMusicLoader8 *ifac } /* add new entry */ - TRACE(": adding alias entry with following info:\n%s\n", debugstr_DMUS_OBJECTDESC(pDesc)); + TRACE(": adding alias entry with following info:\n"); + if (TRACE_ON(dmloader)) + dump_DMUS_OBJECTDESC(pDesc); pNewEntry = HeapAlloc (GetProcessHeap (), HEAP_ZERO_MEMORY, sizeof(WINE_LOADER_ENTRY)); /* use this function instead of pure memcpy due to streams (memcpy just copies pointer), which is basically used further by app that called SetDescriptor... better safety than exception */ @@ -671,7 +682,9 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_ReleaseObject(IDirectMusicLoader8 * if ((Desc.dwValidData & DMUS_OBJ_OBJECT) && (pObjectEntry->Desc.dwValidData & (DMUS_OBJ_OBJECT | DMUS_OBJ_LOADED)) && IsEqualGUID (&Desc.guidObject, &pObjectEntry->Desc.guidObject)) { - TRACE(": found it by object GUID\n%s\n", debugstr_DMUS_OBJECTDESC(&pObjectEntry->Desc)); + TRACE(": found it by object GUID\n"); + if (TRACE_ON(dmloader)) + dump_DMUS_OBJECTDESC(&pObjectEntry->Desc); result = S_OK; break; }

1 0

Christian Costa : dmusic: Set instrument stream position where the instrument begins, not at the beginning of the instruments list. Simplify CustomLoad accordingly.
by Alexandre Julliard 20 Dec '12

20 Dec '12

Module: wine Branch: master Commit: f30c18f3d245f40a0aca8708b30431f9949ed6ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=f30c18f3d245f40a0aca8708b… Author: Christian Costa <titan.costa(a)gmail.com> Date: Wed Dec 19 09:58:03 2012 +0100 dmusic: Set instrument stream position where the instrument begins, not at the beginning of the instruments list. Simplify CustomLoad accordingly. --- dlls/dmusic/collection.c | 7 +- dlls/dmusic/dmusic_private.h | 3 +- dlls/dmusic/instrument.c | 158 +++++++++++------------------------------ 3 files changed, 49 insertions(+), 119 deletions(-) diff --git a/dlls/dmusic/collection.c b/dlls/dmusic/collection.c index e4ac798..5002c9e 100644 --- a/dlls/dmusic/collection.c +++ b/dlls/dmusic/collection.c @@ -118,7 +118,7 @@ static HRESULT WINAPI IDirectMusicCollectionImpl_IDirectMusicCollection_GetInstr if (patch == inst_patch) { *instrument = inst_entry->pInstrument; IDirectMusicInstrument_AddRef(inst_entry->pInstrument); - IDirectMusicInstrumentImpl_Custom_Load(inst_entry->pInstrument, This->pStm); + IDirectMusicInstrumentImpl_CustomLoad(inst_entry->pInstrument, This->pStm); TRACE(": returning instrument %p\n", *instrument); return S_OK; } @@ -665,10 +665,11 @@ static HRESULT WINAPI IDirectMusicCollectionImpl_IPersistStream_Load(LPPERSISTST DMUSIC_CreateDirectMusicInstrumentImpl(&IID_IDirectMusicInstrument, (LPVOID*)&new_instrument->pInstrument, NULL); { IDirectMusicInstrumentImpl *instrument = impl_from_IDirectMusicInstrument(new_instrument->pInstrument); + /* Store offset and length, they will be needed when loading the instrument */ liMove.QuadPart = 0; IStream_Seek(stream, liMove, STREAM_SEEK_CUR, &dlibInstrumentPosition); - /* Store offset, it'll be needed later */ - instrument->liInstrumentPosition.QuadPart = dlibInstrumentPosition.QuadPart - (2 * sizeof(FOURCC) + sizeof(DWORD)); + instrument->liInstrumentPosition.QuadPart = dlibInstrumentPosition.QuadPart; + instrument->length = ListSize[1]; do { IStream_Read(stream, &chunk, sizeof(FOURCC) + sizeof(DWORD), NULL); ListCount[1] += sizeof(FOURCC) + sizeof(DWORD) + chunk.dwSize; diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h index 3e625d6..3c05ceb 100644 --- a/dlls/dmusic/dmusic_private.h +++ b/dlls/dmusic/dmusic_private.h @@ -230,6 +230,7 @@ struct IDirectMusicInstrumentImpl { /* IDirectMusicInstrumentImpl fields */ LARGE_INTEGER liInstrumentPosition; /* offset in a stream where instrument chunk can be found */ + ULONG length; /* Length of the instrument in the stream */ LPGUID pInstrumentID; LPINSTHEADER pHeader; WCHAR wszName[DMUS_MAX_NAME]; @@ -242,7 +243,7 @@ static inline IDirectMusicInstrumentImpl *impl_from_IDirectMusicInstrument(IDire } /* custom :) */ -extern HRESULT IDirectMusicInstrumentImpl_Custom_Load (LPDIRECTMUSICINSTRUMENT iface, LPSTREAM pStm) DECLSPEC_HIDDEN; +extern HRESULT IDirectMusicInstrumentImpl_CustomLoad(IDirectMusicInstrument *iface, IStream *stream) DECLSPEC_HIDDEN; /********************************************************************** * Dll lifetime tracking declaration for dmusic.dll diff --git a/dlls/dmusic/instrument.c b/dlls/dmusic/instrument.c index 9c3d3d6..cc57313 100644 --- a/dlls/dmusic/instrument.c +++ b/dlls/dmusic/instrument.c @@ -156,140 +156,68 @@ static inline DWORD subtract_bytes(DWORD len, DWORD bytes) return len - bytes; } -static HRESULT load_instrument(IDirectMusicInstrumentImpl *This, IStream *stream, DWORD length) +static inline HRESULT advance_stream(IStream *stream, ULONG bytes) { - HRESULT hr; - FOURCC fourcc; - DWORD bytes; LARGE_INTEGER move; + HRESULT ret; - while(length){ - hr = read_from_stream(stream, &fourcc, sizeof(fourcc)); - if(FAILED(hr)) - return hr; - - hr = read_from_stream(stream, &bytes, sizeof(bytes)); - if(FAILED(hr)) - return hr; - - length = subtract_bytes(length, sizeof(fourcc) + sizeof(bytes)); - - switch(fourcc){ - case FOURCC_INSH: - TRACE("INSH chunk: %u bytes\n", bytes); - hr = read_from_stream(stream, This->pHeader, sizeof(*This->pHeader)); - if(FAILED(hr)) - return hr; - - move.QuadPart = bytes - sizeof(*This->pHeader); - hr = IStream_Seek(stream, move, STREAM_SEEK_CUR, NULL); - if(FAILED(hr)){ - WARN("IStream_Seek failed: %08x\n", hr); - return hr; - } - - length = subtract_bytes(length, bytes); - break; - - case FOURCC_DLID: - TRACE("DLID chunk: %u bytes\n", bytes); - hr = read_from_stream(stream, This->pInstrumentID, sizeof(*This->pInstrumentID)); - if(FAILED(hr)) - return hr; - - move.QuadPart = bytes - sizeof(*This->pInstrumentID); - hr = IStream_Seek(stream, move, STREAM_SEEK_CUR, NULL); - if(FAILED(hr)){ - WARN("IStream_Seek failed: %08x\n", hr); - return hr; - } - - length = subtract_bytes(length, bytes); - break; - - default: - TRACE("Unknown chunk %s: %u bytes\n", debugstr_fourcc(fourcc), bytes); - - move.QuadPart = bytes; - hr = IStream_Seek(stream, move, STREAM_SEEK_CUR, NULL); - if(FAILED(hr)){ - WARN("IStream_Seek failed: %08x\n", hr); - return hr; - } - - length = subtract_bytes(length, bytes); - break; - } - } + move.QuadPart = bytes; - return S_OK; + ret = IStream_Seek(stream, move, STREAM_SEEK_CUR, NULL); + if (FAILED(ret)) + WARN("IStream_Seek failed: %08x\n", ret); + + return ret; } -/* aux. function that completely loads instrument; my tests indicate that it's - called somewhere around IDirectMusicCollection_GetInstrument */ -HRESULT IDirectMusicInstrumentImpl_Custom_Load(LPDIRECTMUSICINSTRUMENT iface, LPSTREAM stream) +/* Function that loads all instrument data and which is called from IDirectMusicCollection_GetInstrument as in native */ +HRESULT IDirectMusicInstrumentImpl_CustomLoad(IDirectMusicInstrument *iface, IStream *stream) { IDirectMusicInstrumentImpl *This = impl_from_IDirectMusicInstrument(iface); - LARGE_INTEGER move; - FOURCC fourcc; - DWORD bytes; HRESULT hr; + DMUS_PRIVATE_CHUNK chunk; + ULONG length = This->length; - TRACE("(%p, %p, offset = %s)\n", This, stream, wine_dbgstr_longlong(This->liInstrumentPosition.QuadPart)); + TRACE("(%p, %p): offset = 0x%s, length = %u)\n", This, stream, wine_dbgstr_longlong(This->liInstrumentPosition.QuadPart), This->length); hr = IStream_Seek(stream, This->liInstrumentPosition, STREAM_SEEK_SET, NULL); - if(FAILED(hr)){ + if (FAILED(hr)) + { WARN("IStream_Seek failed: %08x\n", hr); - goto load_failure; + return DMUS_E_UNSUPPORTED_STREAM; } - hr = read_from_stream(stream, &fourcc, sizeof(fourcc)); - if(FAILED(hr)) - goto load_failure; + while (length) + { + hr = read_from_stream(stream, &chunk, sizeof(chunk)); + if (FAILED(hr)) + return DMUS_E_UNSUPPORTED_STREAM; - if(fourcc != FOURCC_LIST){ - WARN("Loading failed: Expected LIST chunk, got: %s\n", debugstr_fourcc(fourcc)); - goto load_failure; - } + length = subtract_bytes(length, sizeof(chunk) + chunk.dwSize); + + switch (chunk.fccID) + { + case FOURCC_INSH: + case FOURCC_DLID: + TRACE("Chunk %s: %u bytes\n", debugstr_fourcc(chunk.fccID), chunk.dwSize); + + /* Instrument header and id are already set so just skip */ + hr = advance_stream(stream, chunk.dwSize); + if (FAILED(hr)) + return DMUS_E_UNSUPPORTED_STREAM; - hr = read_from_stream(stream, &bytes, sizeof(bytes)); - if(FAILED(hr)) - goto load_failure; - - TRACE("LIST chunk: %u bytes\n", bytes); - while(1){ - hr = read_from_stream(stream, &fourcc, sizeof(fourcc)); - if(FAILED(hr)) - goto load_failure; - - switch(fourcc){ - case FOURCC_INS: - TRACE("INS chunk: (no byte count)\n"); - hr = load_instrument(This, stream, bytes - sizeof(FOURCC)); - if(FAILED(hr)) - goto load_failure; - break; - - default: - hr = read_from_stream(stream, &bytes, sizeof(bytes)); - if(FAILED(hr)) - goto load_failure; - - TRACE("Unknown chunk %s: %u bytes\n", debugstr_fourcc(fourcc), bytes); - - move.QuadPart = bytes; - hr = IStream_Seek(stream, move, STREAM_SEEK_CUR, NULL); - if(FAILED(hr)){ - WARN("IStream_Seek failed: %08x\n", hr); - return hr; - } - - break; + break; + + default: + TRACE("Unknown chunk %s: %u bytes\n", debugstr_fourcc(chunk.fccID), chunk.dwSize); + + hr = advance_stream(stream, chunk.dwSize); + if (FAILED(hr)) + return DMUS_E_UNSUPPORTED_STREAM; + + break; } } return S_OK; - -load_failure: - return DMUS_E_UNSUPPORTED_STREAM; }

1 0

André Hentschel : msvcrt/tests: Don' t test function directly when reporting errno.
by Alexandre Julliard 20 Dec '12

20 Dec '12

Module: wine Branch: master Commit: 61a12130788569e91913808d58d5e5b32ae83add URL: http://source.winehq.org/git/wine.git/?a=commit;h=61a12130788569e91913808d5… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Dec 19 20:33:23 2012 +0100 msvcrt/tests: Don't test function directly when reporting errno. --- dlls/msvcrt/tests/data.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/msvcrt/tests/data.c b/dlls/msvcrt/tests/data.c index 0723093..cdd65a7 100644 --- a/dlls/msvcrt/tests/data.c +++ b/dlls/msvcrt/tests/data.c @@ -197,12 +197,14 @@ static void test___getmainargs_parent(char *name) STARTUPINFO startup; PROCESS_INFORMATION proc; FILE *f; + int ret; ok(GetTempPathA(MAX_PATH, tmppath) != 0, "GetTempPath failed\n"); sprintf(cmdline, "%s data %s*\\* %swine_test/*", name, tmppath, tmppath); sprintf(filepath, "%swine_test", tmppath); - ok(!_mkdir(filepath), "_mkdir failed: %d\n", errno); + ret = _mkdir(filepath); + ok(!ret, "_mkdir failed: %d\n", errno); sprintf(filepath, "%swine_test\\a", tmppath); f = fopen(filepath, "w"); ok(f != NULL, "fopen(%s) failed: %d\n", filepath, errno);

1 0

André Hentschel : kernel32/tests: Don' t test function directly when reporting GetLastError().
by Alexandre Julliard 20 Dec '12

20 Dec '12

Module: wine Branch: master Commit: e431d89ed2811496e3917523cda6c13083c3afb7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e431d89ed2811496e3917523c… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Dec 19 20:34:03 2012 +0100 kernel32/tests: Don't test function directly when reporting GetLastError(). --- dlls/kernel32/tests/file.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 3d29b28..0166fff 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -3296,7 +3296,8 @@ static void test_GetFileInformationByHandleEx(void) /* ensure the existence of a file in the temp folder */ ret2 = GetTempFileNameA(tempPath, "abc", 0, tempFileName); ok(ret2, "GetFileInformationByHandleEx: GetTempFileNameA failed, got error %u.\n", GetLastError()); - ok(GetFileAttributesA(tempFileName) != INVALID_FILE_ATTRIBUTES, "GetFileInformationByHandleEx: " + ret2 = GetFileAttributesA(tempFileName); + ok(ret2 != INVALID_FILE_ATTRIBUTES, "GetFileInformationByHandleEx: " "GetFileAttributesA failed to find the temp file, got error %u.\n", GetLastError()); directory = CreateFileA(tempPath, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, @@ -3359,7 +3360,8 @@ static void test_OpenFileById(void) /* ensure the existence of a file in the temp folder */ ret2 = GetTempFileNameA(tempPath, "abc", 0, tempFileName); ok(ret2, "OpenFileById: GetTempFileNameA failed, got error %u.\n", GetLastError()); - ok(GetFileAttributesA(tempFileName) != INVALID_FILE_ATTRIBUTES, + ret2 = GetFileAttributesA(tempFileName); + ok(ret2 != INVALID_FILE_ATTRIBUTES, "OpenFileById: GetFileAttributesA failed to find the temp file, got error %u\n", GetLastError()); ret2 = MultiByteToWideChar(CP_ACP, 0, tempFileName + strlen(tempPath), -1, tempFileNameW, sizeof(tempFileNameW)/sizeof(tempFileNameW[0]));

1 0