April 2012 - Wine-commits - list.winehq.org

Jacek Caban : mshtml: Added IHTMLWindow2::onerror semi-stub implementation.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: e370f4bf3a113d253b9fc85e3bac72975b9a6bb7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e370f4bf3a113d253b9fc85e3… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Apr 4 15:08:38 2012 +0200 mshtml: Added IHTMLWindow2::onerror semi-stub implementation. --- dlls/mshtml/htmlevent.c | 5 +++++ dlls/mshtml/htmlevent.h | 1 + dlls/mshtml/htmlwindow.c | 12 ++++++++---- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index cf2d808..cfba560 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -68,6 +68,9 @@ static const WCHAR ondragW[] = {'o','n','d','r','a','g',0}; static const WCHAR dragstartW[] = {'d','r','a','g','s','t','a','r','t',0}; static const WCHAR ondragstartW[] = {'o','n','d','r','a','g','s','t','a','r','t',0}; +static const WCHAR errorW[] = {'e','r','r','o','r',0}; +static const WCHAR onerrorW[] = {'o','n','e','r','r','o','r',0}; + static const WCHAR focusW[] = {'f','o','c','u','s',0}; static const WCHAR onfocusW[] = {'o','n','f','o','c','u','s',0}; @@ -160,6 +163,8 @@ static const event_info_t event_info[] = { EVENT_CANCELABLE}, {dragstartW, ondragstartW, EVENTT_MOUSE, DISPID_EVMETH_ONDRAGSTART, EVENT_CANCELABLE}, + {errorW, onerrorW, EVENTT_NONE, DISPID_EVMETH_ONERROR, + 0}, {focusW, onfocusW, EVENTT_HTML, DISPID_EVMETH_ONFOCUS, EVENT_DEFAULTLISTENER}, {keydownW, onkeydownW, EVENTT_KEY, DISPID_EVMETH_ONKEYDOWN, diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index b3ff251..70056b3 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -25,6 +25,7 @@ typedef enum { EVENTID_DBLCLICK, EVENTID_DRAG, EVENTID_DRAGSTART, + EVENTID_ERROR, EVENTID_FOCUS, EVENTID_KEYDOWN, EVENTID_KEYUP, diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 2bd5d7e..294f551 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -971,15 +971,19 @@ static HRESULT WINAPI HTMLWindow2_get_onhelp(IHTMLWindow2 *iface, VARIANT *p) static HRESULT WINAPI HTMLWindow2_put_onerror(IHTMLWindow2 *iface, VARIANT v) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); - return E_NOTIMPL; + + FIXME("(%p)->(%s) semi-stub\n", This, debugstr_variant(&v)); + + return set_window_event(This, EVENTID_ERROR, &v); } static HRESULT WINAPI HTMLWindow2_get_onerror(IHTMLWindow2 *iface, VARIANT *p) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_window_event(This, EVENTID_ERROR, p); } static HRESULT WINAPI HTMLWindow2_put_onresize(IHTMLWindow2 *iface, VARIANT v)

1 0

Huw Davies : wineps: Move some allocations to the process heap.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: e31cfb0be18a33cb6b3b33c47cabb33f9659e3f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e31cfb0be18a33cb6b3b33c47… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Apr 4 15:03:29 2012 +0100 wineps: Move some allocations to the process heap. --- dlls/wineps.drv/ps.c | 63 +++++++++++++++++++++++++------------------------ 1 files changed, 32 insertions(+), 31 deletions(-) diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 8b0d576..27a2cc1 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -221,7 +221,7 @@ DWORD PSDRV_WriteSpool(PHYSDEV dev, LPCSTR lpData, DWORD cch) static INT PSDRV_WriteFeature(PHYSDEV dev, LPCSTR feature, LPCSTR value, LPCSTR invocation) { - char *buf = HeapAlloc( PSDRV_Heap, 0, sizeof(psbeginfeature) + + char *buf = HeapAlloc( GetProcessHeap(), 0, sizeof(psbeginfeature) + strlen(feature) + strlen(value)); sprintf(buf, psbeginfeature, feature, value); @@ -229,7 +229,7 @@ static INT PSDRV_WriteFeature(PHYSDEV dev, LPCSTR feature, LPCSTR value, LPCSTR write_spool( dev, invocation, strlen(invocation) ); write_spool( dev, psendfeature, strlen(psendfeature) ); - HeapFree( PSDRV_Heap, 0, buf ); + HeapFree( GetProcessHeap(), 0, buf ); return 1; } @@ -306,11 +306,12 @@ INT PSDRV_WriteHeader( PHYSDEV dev, LPCWSTR title ) DUPLEX *duplex; int win_duplex; int llx, lly, urx, ury; + int ret, len; TRACE("%s\n", debugstr_w(title)); escaped_title = escape_title(title); - buf = HeapAlloc( PSDRV_Heap, 0, sizeof(psheader) + + buf = HeapAlloc( GetProcessHeap(), 0, sizeof(psheader) + strlen(escaped_title) + 30 ); if(!buf) { WARN("HeapAlloc failed\n"); @@ -328,12 +329,15 @@ INT PSDRV_WriteHeader( PHYSDEV dev, LPCWSTR title ) sprintf(buf, psheader, escaped_title, llx, lly, urx, ury); HeapFree(GetProcessHeap(), 0, escaped_title); - if( write_spool( dev, buf, strlen(buf) ) != strlen(buf) ) { + + len = strlen( buf ); + ret = write_spool( dev, buf, len ); + HeapFree( GetProcessHeap(), 0, buf ); + if (ret != len) + { WARN("WriteSpool error\n"); - HeapFree( PSDRV_Heap, 0, buf ); - return 0; + return 0; } - HeapFree( PSDRV_Heap, 0, buf ); write_spool( dev, psbeginprolog, strlen(psbeginprolog) ); write_spool( dev, psprolog, strlen(psprolog) ); @@ -389,8 +393,9 @@ INT PSDRV_WriteFooter( PHYSDEV dev ) { PSDRV_PDEVICE *physDev = get_psdrv_dev( dev ); char *buf; + int ret = 1; - buf = HeapAlloc( PSDRV_Heap, 0, sizeof(psfooter) + 100 ); + buf = HeapAlloc( GetProcessHeap(), 0, sizeof(psfooter) + 100 ); if(!buf) { WARN("HeapAlloc failed\n"); return 0; @@ -400,11 +405,10 @@ INT PSDRV_WriteFooter( PHYSDEV dev ) if( write_spool( dev, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); - HeapFree( PSDRV_Heap, 0, buf ); - return 0; + ret = 0; } - HeapFree( PSDRV_Heap, 0, buf ); - return 1; + HeapFree( GetProcessHeap(), 0, buf ); + return ret; } @@ -427,10 +431,11 @@ INT PSDRV_WriteNewPage( PHYSDEV dev ) char *buf; char name[100]; signed int xtrans, ytrans, rotation; + int ret = 1; sprintf(name, "%d", physDev->job.PageNo); - buf = HeapAlloc( PSDRV_Heap, 0, sizeof(psnewpage) + 200 ); + buf = HeapAlloc( GetProcessHeap(), 0, sizeof(psnewpage) + 200 ); if(!buf) { WARN("HeapAlloc failed\n"); return 0; @@ -458,11 +463,10 @@ INT PSDRV_WriteNewPage( PHYSDEV dev ) if( write_spool( dev, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); - HeapFree( PSDRV_Heap, 0, buf ); - return 0; + ret = 0; } - HeapFree( PSDRV_Heap, 0, buf ); - return 1; + HeapFree( GetProcessHeap(), 0, buf ); + return ret; } @@ -525,8 +529,7 @@ BOOL PSDRV_WriteSetFont(PHYSDEV dev, const char *name, matrix size, INT escapeme { char *buf; - buf = HeapAlloc( PSDRV_Heap, 0, sizeof(pssetfont) + - strlen(name) + 40); + buf = HeapAlloc( GetProcessHeap(), 0, sizeof(pssetfont) + strlen(name) + 40 ); if(!buf) { WARN("HeapAlloc failed\n"); @@ -536,7 +539,7 @@ BOOL PSDRV_WriteSetFont(PHYSDEV dev, const char *name, matrix size, INT escapeme sprintf(buf, pssetfont, name, size.xx, size.xy, size.yx, size.yy, -escapement); PSDRV_WriteSpool(dev, buf, strlen(buf)); - HeapFree(PSDRV_Heap, 0, buf); + HeapFree( GetProcessHeap(), 0, buf ); return TRUE; } @@ -678,7 +681,7 @@ BOOL PSDRV_WriteIndexColorSpaceEnd(PHYSDEV dev) static BOOL PSDRV_WriteRGB(PHYSDEV dev, COLORREF *map, int number) { - char *buf = HeapAlloc(PSDRV_Heap, 0, number * 7 + 1), *ptr; + char *buf = HeapAlloc( GetProcessHeap(), 0, number * 7 + 1 ), *ptr; int i; ptr = buf; @@ -689,13 +692,13 @@ static BOOL PSDRV_WriteRGB(PHYSDEV dev, COLORREF *map, int number) ptr += 7; } PSDRV_WriteSpool(dev, buf, number * 7); - HeapFree(PSDRV_Heap, 0, buf); + HeapFree( GetProcessHeap(), 0, buf ); return TRUE; } BOOL PSDRV_WriteRGBQUAD(PHYSDEV dev, const RGBQUAD *rgb, int number) { - char *buf = HeapAlloc(PSDRV_Heap, 0, number * 7 + 1), *ptr; + char *buf = HeapAlloc( GetProcessHeap(), 0, number * 7 + 1 ), *ptr; int i; ptr = buf; @@ -704,7 +707,7 @@ BOOL PSDRV_WriteRGBQUAD(PHYSDEV dev, const RGBQUAD *rgb, int number) ((i & 0x7) == 0x7) || (i == number - 1) ? '\n' : ' '); PSDRV_WriteSpool(dev, buf, ptr - buf); - HeapFree(PSDRV_Heap, 0, buf); + HeapFree( GetProcessHeap(), 0, buf ); return TRUE; } @@ -720,8 +723,7 @@ static BOOL PSDRV_WriteImageDict(PHYSDEV dev, WORD depth, static const char end[] = " /DataSource currentfile /ASCII85Decode filter /RunLengthDecode filter\n>>\n"; static const char endbits[] = " /DataSource <%s>\n>>\n"; - - char *buf = HeapAlloc(PSDRV_Heap, 0, 1000); + char buf[1000]; if (top_down) sprintf(buf, start, widthSrc, heightSrc, @@ -759,7 +761,6 @@ static BOOL PSDRV_WriteImageDict(PHYSDEV dev, WORD depth, PSDRV_WriteSpool(dev, buf, strlen(buf)); } - HeapFree(PSDRV_Heap, 0, buf); return TRUE; } @@ -785,7 +786,7 @@ BOOL PSDRV_WriteImage(PHYSDEV dev, WORD depth, INT xDst, INT yDst, BOOL PSDRV_WriteBytes(PHYSDEV dev, const BYTE *bytes, DWORD number) { - char *buf = HeapAlloc(PSDRV_Heap, 0, number * 3 + 1); + char *buf = HeapAlloc( GetProcessHeap(), 0, number * 3 + 1 ); char *ptr; unsigned int i; @@ -800,7 +801,7 @@ BOOL PSDRV_WriteBytes(PHYSDEV dev, const BYTE *bytes, DWORD number) } } PSDRV_WriteSpool(dev, buf, ptr - buf); - HeapFree(PSDRV_Heap, 0, buf); + HeapFree( GetProcessHeap(), 0, buf ); return TRUE; } @@ -873,7 +874,7 @@ BOOL PSDRV_WriteDIBPatternDict(PHYSDEV dev, const BITMAPINFO *bmi, BYTE *bits, U w = bmi->bmiHeader.biWidth & ~0x7; h = bmi->bmiHeader.biHeight & ~0x7; - buf = HeapAlloc(PSDRV_Heap, 0, sizeof(do_pattern) + 100); + buf = HeapAlloc( GetProcessHeap(), 0, sizeof(do_pattern) + 100 ); ptr = buf; for(y = h-1; y >= 0; y--) { for(x = 0; x < w/8; x++) { @@ -897,6 +898,6 @@ BOOL PSDRV_WriteDIBPatternDict(PHYSDEV dev, const BITMAPINFO *bmi, BYTE *bits, U h_mult = (physDev->logPixelsY + 150) / 300; sprintf(buf, do_pattern, w * w_mult, h * h_mult, w * w_mult, h * h_mult, w * w_mult, h * h_mult); PSDRV_WriteSpool(dev, buf, strlen(buf)); - HeapFree(PSDRV_Heap, 0, buf); + HeapFree( GetProcessHeap(), 0, buf ); return TRUE; }

1 0

Huw Davies : wineps: Fix a memory leak.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: a37ee1e2e9fd3bce298134da58b6ff945629d383 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a37ee1e2e9fd3bce298134da5… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Apr 4 15:03:30 2012 +0100 wineps: Fix a memory leak. --- dlls/wineps.drv/driver.c | 20 ++++++++++++-------- dlls/wineps.drv/psdrv.h | 5 ----- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index 5ad3b6a..50fb59f 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -179,6 +179,12 @@ void PSDRV_MergeDevmodes(PSDRV_DEVMODEA *dm1, PSDRV_DEVMODEA *dm2, } +typedef struct +{ + PRINTERINFO *pi; + PSDRV_DEVMODEA *dlgdm; +} PSDRV_DLGINFO; + /**************************************************************** * PSDRV_PaperDlgProc * @@ -360,8 +366,8 @@ INT PSDRV_ExtDeviceMode(LPSTR lpszDriver, HWND hwnd, LPDEVMODEA lpdmOutput, HPROPSHEETPAGE hpsp[1]; PROPSHEETPAGEW psp; PROPSHEETHEADERW psh; - PSDRV_DLGINFO *di; - PSDRV_DEVMODEA *dlgdm; + PSDRV_DLGINFO di; + PSDRV_DEVMODEA dlgdm; static const WCHAR PAPERW[] = {'P','A','P','E','R','\0'}; static const WCHAR SetupW[] = {'S','e','t','u','p','\0'}; @@ -372,17 +378,15 @@ INT PSDRV_ExtDeviceMode(LPSTR lpszDriver, HWND hwnd, LPDEVMODEA lpdmOutput, "CreatePropertySheetPageW"); pPropertySheet = (void*)GetProcAddress(hinstComctl32, "PropertySheetW"); memset(&psp,0,sizeof(psp)); - dlgdm = HeapAlloc( PSDRV_Heap, 0, sizeof(*dlgdm) ); - *dlgdm = *pi->Devmode; - di = HeapAlloc( PSDRV_Heap, 0, sizeof(*di) ); - di->pi = pi; - di->dlgdm = dlgdm; + dlgdm = *pi->Devmode; + di.pi = pi; + di.dlgdm = &dlgdm; psp.dwSize = sizeof(psp); psp.hInstance = PSDRV_hInstance; psp.u.pszTemplate = PAPERW; psp.u2.pszIcon = NULL; psp.pfnDlgProc = PSDRV_PaperDlgProc; - psp.lParam = (LPARAM)di; + psp.lParam = (LPARAM)&di; hpsp[0] = pCreatePropertySheetPage(&psp); memset(&psh, 0, sizeof(psh)); diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index 093a543..53186c7 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -385,11 +385,6 @@ typedef struct int pathdepth; } PSDRV_PDEVICE; -typedef struct { - PRINTERINFO *pi; - PSDRV_DEVMODEA *dlgdm; -} PSDRV_DLGINFO; - static inline PSDRV_PDEVICE *get_psdrv_dev( PHYSDEV dev ) { return (PSDRV_PDEVICE *)dev;

1 0

Huw Davies : wineps: Change the printer info list into a standard list.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: a2e6c7340d6059d394dcbeff3859384054a3513f URL: http://source.winehq.org/git/wine.git/?a=commit;h=a2e6c7340d6059d394dcbeff3… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Apr 4 15:03:31 2012 +0100 wineps: Change the printer info list into a standard list. --- dlls/wineps.drv/init.c | 24 ++++++++++-------------- dlls/wineps.drv/psdrv.h | 5 +++-- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c index 84e4086..7e4ca51 100644 --- a/dlls/wineps.drv/init.c +++ b/dlls/wineps.drv/init.c @@ -530,15 +530,15 @@ static INT PSDRV_GetDeviceCaps( PHYSDEV dev, INT cap ) } } +static struct list printer_list = LIST_INIT( printer_list ); /********************************************************************** * PSDRV_FindPrinterInfo */ PRINTERINFO *PSDRV_FindPrinterInfo(LPCWSTR name) { - static PRINTERINFO *PSDRV_PrinterList; DWORD type = REG_BINARY, needed, res, dwPaperSize; - PRINTERINFO *pi = PSDRV_PrinterList, **last = &PSDRV_PrinterList; + PRINTERINFO *pi; FONTNAME *font; const AFM *afm; HANDLE hPrinter = 0; @@ -551,17 +551,14 @@ PRINTERINFO *PSDRV_FindPrinterInfo(LPCWSTR name) TRACE("'%s'\n", debugstr_w(name)); - /* - * If this loop completes, last will point to the 'next' element of the - * final PRINTERINFO in the list - */ - for( ; pi; last = &pi->next, pi = pi->next) - if(!strcmpW(pi->friendly_name, name)) - return pi; + LIST_FOR_EACH_ENTRY( pi, &printer_list, PRINTERINFO, entry ) + { + if (!strcmpW( pi->friendly_name, name )) + return pi; + } - pi = *last = HeapAlloc( PSDRV_Heap, HEAP_ZERO_MEMORY, sizeof(*pi) ); - if (pi == NULL) - return NULL; + pi = HeapAlloc( PSDRV_Heap, HEAP_ZERO_MEMORY, sizeof(*pi) ); + if (pi == NULL) return NULL; if (!(pi->friendly_name = HeapAlloc( PSDRV_Heap, 0, (strlenW(name)+1)*sizeof(WCHAR) ))) goto fail; strcpyW( pi->friendly_name, name ); @@ -775,7 +772,6 @@ PRINTERINFO *PSDRV_FindPrinterInfo(LPCWSTR name) goto cleanup; } - pi->next = NULL; pi->Fonts = NULL; for(font = pi->ppd->InstalledFonts; font; font = font->next) { @@ -795,6 +791,7 @@ PRINTERINFO *PSDRV_FindPrinterInfo(LPCWSTR name) } HeapFree( GetProcessHeap(), 0, nameA ); if (ppd) unlink(ppd); + list_add_head( &printer_list, &pi->entry ); return pi; closeprinter: @@ -808,7 +805,6 @@ fail: HeapFree(PSDRV_Heap, 0, pi); HeapFree( GetProcessHeap(), 0, nameA ); if (ppd) unlink(ppd); - *last = NULL; return NULL; } diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index 53186c7..df86c70 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -241,14 +241,15 @@ numInstalledOptions of OPTIONs } PSDRV_DEVMODEA; -typedef struct _tagPI { +typedef struct +{ + struct list entry; WCHAR *friendly_name; PPD *ppd; PSDRV_DEVMODEA *Devmode; FONTFAMILY *Fonts; PPRINTER_ENUM_VALUESA FontSubTable; DWORD FontSubTableSize; - struct _tagPI *next; } PRINTERINFO; typedef struct {

1 0

Huw Davies : wineps: Add a helper to retrieve the font substitution table.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: 28bf93561ddb3778b1b6b1dc35b5e8416a7bce19 URL: http://source.winehq.org/git/wine.git/?a=commit;h=28bf93561ddb3778b1b6b1dc3… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Apr 4 15:03:32 2012 +0100 wineps: Add a helper to retrieve the font substitution table. --- dlls/wineps.drv/init.c | 55 +++++++++++++++++++++++------------------------ 1 files changed, 27 insertions(+), 28 deletions(-) diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c index 7e4ca51..0c06ecb 100644 --- a/dlls/wineps.drv/init.c +++ b/dlls/wineps.drv/init.c @@ -530,6 +530,31 @@ static INT PSDRV_GetDeviceCaps( PHYSDEV dev, INT cap ) } } +static PRINTER_ENUM_VALUESA *load_font_sub_table( HANDLE printer, DWORD *num_entries ) +{ + DWORD res, needed, num; + PRINTER_ENUM_VALUESA *table = NULL; + static const char fontsubkey[] = "PrinterDriverData\\FontSubTable"; + + *num_entries = 0; + + res = EnumPrinterDataExA( printer, fontsubkey, NULL, 0, &needed, &num ); + if (res != ERROR_MORE_DATA) return NULL; + + table = HeapAlloc( PSDRV_Heap, 0, needed ); + if (!table) return NULL; + + res = EnumPrinterDataExA( printer, fontsubkey, (LPBYTE)table, needed, &needed, &num ); + if (res != ERROR_SUCCESS) + { + HeapFree( PSDRV_Heap, 0, table ); + return NULL; + } + + *num_entries = num; + return table; +} + static struct list printer_list = LIST_INIT( printer_list ); /********************************************************************** @@ -742,35 +767,9 @@ PRINTERINFO *PSDRV_FindPrinterInfo(LPCWSTR name) pi->Devmode->dmPublic.dmDuplex = DMDUP_SIMPLEX; } - res = EnumPrinterDataExA (hPrinter, "PrinterDriverData\\FontSubTable", NULL, - 0, &needed, &pi->FontSubTableSize); - if (res == ERROR_SUCCESS || res == ERROR_FILE_NOT_FOUND) { - TRACE ("No 'FontSubTable' for printer '%s'\n", debugstr_w(name)); - } - else if (res == ERROR_MORE_DATA) { - pi->FontSubTable = HeapAlloc (PSDRV_Heap, 0, needed); - if (pi->FontSubTable == NULL) { - ERR ("Failed to allocate %i bytes from heap\n", needed); - goto closeprinter; - } - - res = EnumPrinterDataExA (hPrinter, "PrinterDriverData\\FontSubTable", - (LPBYTE) pi->FontSubTable, needed, &needed, - &pi->FontSubTableSize); - if (res != ERROR_SUCCESS) { - ERR ("EnumPrinterDataExA returned %i\n", res); - goto closeprinter; - } - } - else { - ERR("EnumPrinterDataExA returned %i\n", res); - goto closeprinter; - } + pi->FontSubTable = load_font_sub_table( hPrinter, &pi->FontSubTableSize ); - if (ClosePrinter (hPrinter) == 0) { - ERR ("ClosePrinter failed with code %i\n", GetLastError ()); - goto cleanup; - } + ClosePrinter( hPrinter ); pi->Fonts = NULL;

1 0

Vincent Povirk : gdiplus: Default path gradient center color depends on the constructor.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: b228426d8e147ea22ee9f7232066ef4a9c861993 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b228426d8e147ea22ee9f7232… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Sat Mar 31 13:14:07 2012 -0500 gdiplus: Default path gradient center color depends on the constructor. --- dlls/gdiplus/brush.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c index 4bf4928..41b38a0 100644 --- a/dlls/gdiplus/brush.c +++ b/dlls/gdiplus/brush.c @@ -509,7 +509,7 @@ GpStatus WINGDIPAPI GdipCreateLineBrushFromRectWithAngleI(GDIPCONST GpRect* rect wrap, line); } -static GpStatus create_path_gradient(GpPath *path, GpPathGradient **grad) +static GpStatus create_path_gradient(GpPath *path, ARGB centercolor, GpPathGradient **grad) { GpRectF bounds; GpStatus stat; @@ -554,7 +554,7 @@ static GpStatus create_path_gradient(GpPath *path, GpPathGradient **grad) (*grad)->path = path; (*grad)->brush.bt = BrushTypePathGradient; - (*grad)->centercolor = 0xffffffff; + (*grad)->centercolor = centercolor; (*grad)->wrap = WrapModeClamp; (*grad)->gamma = FALSE; /* FIXME: this should be set to the "centroid" of the path by default */ @@ -591,7 +591,7 @@ GpStatus WINGDIPAPI GdipCreatePathGradient(GDIPCONST GpPointF* points, stat = GdipAddPathLine2(path, points, count); if (stat == Ok) - stat = create_path_gradient(path, grad); + stat = create_path_gradient(path, 0xff000000, grad); if (stat != Ok) GdipDeletePath(path); @@ -621,7 +621,7 @@ GpStatus WINGDIPAPI GdipCreatePathGradientI(GDIPCONST GpPoint* points, stat = GdipAddPathLine2I(path, points, count); if (stat == Ok) - stat = create_path_gradient(path, grad); + stat = create_path_gradient(path, 0xff000000, grad); if (stat != Ok) GdipDeletePath(path); @@ -648,7 +648,7 @@ GpStatus WINGDIPAPI GdipCreatePathGradientFromPath(GDIPCONST GpPath* path, if (stat == Ok) { - stat = create_path_gradient(new_path, grad); + stat = create_path_gradient(new_path, 0xffffffff, grad); if (stat != Ok) GdipDeletePath(new_path);

1 0

Vincent Povirk : gdiplus: Set the wrap mode in the path gradient constructor.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: 09b7aed7a23a43fc2bf3a453730181dd1a64f4ff URL: http://source.winehq.org/git/wine.git/?a=commit;h=09b7aed7a23a43fc2bf3a4537… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Sat Mar 31 13:19:40 2012 -0500 gdiplus: Set the wrap mode in the path gradient constructor. --- dlls/gdiplus/brush.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c index 41b38a0..359f4973 100644 --- a/dlls/gdiplus/brush.c +++ b/dlls/gdiplus/brush.c @@ -597,6 +597,9 @@ GpStatus WINGDIPAPI GdipCreatePathGradient(GDIPCONST GpPointF* points, GdipDeletePath(path); } + if (stat == Ok) + (*grad)->wrap = wrap; + return stat; } @@ -627,6 +630,9 @@ GpStatus WINGDIPAPI GdipCreatePathGradientI(GDIPCONST GpPoint* points, GdipDeletePath(path); } + if (stat == Ok) + (*grad)->wrap = wrap; + return stat; }

1 0

Jacek Caban : mshtml: Use helper for IHTMLStyle::get_height implementation.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: 9529fdb94f28004fc3f026d0e7e181ea7619f01f URL: http://source.winehq.org/git/wine.git/?a=commit;h=9529fdb94f28004fc3f026d0e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Apr 4 10:30:59 2012 +0200 mshtml: Use helper for IHTMLStyle::get_height implementation. --- dlls/mshtml/htmlstyle.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index 68a2c6b..e23cd65 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -2001,18 +2001,10 @@ static HRESULT WINAPI HTMLStyle_put_height(IHTMLStyle *iface, VARIANT v) static HRESULT WINAPI HTMLStyle_get_height(IHTMLStyle *iface, VARIANT *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - BSTR ret; - HRESULT hres; TRACE("(%p)->(%p)\n", This, p); - hres = get_style_attr(This, STYLEID_HEIGHT, &ret); - if(FAILED(hres)) - return hres; - - V_VT(p) = VT_BSTR; - V_BSTR(p) = ret; - return S_OK; + return get_nsstyle_attr_var(This->nsstyle, STYLEID_HEIGHT, p, 0); } static HRESULT WINAPI HTMLStyle_put_styleFloat(IHTMLStyle *iface, BSTR v)

1 0

Jacek Caban : mshtml: Use helper for IHTMLStyle::get_top implementation.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: 73ed5b388afa75b7b7960a1d7524856bf46fe4a5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=73ed5b388afa75b7b7960a1d7… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Apr 4 10:31:07 2012 +0200 mshtml: Use helper for IHTMLStyle::get_top implementation. --- dlls/mshtml/htmlstyle.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index e23cd65..8688549 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -2153,18 +2153,10 @@ static HRESULT WINAPI HTMLStyle_put_top(IHTMLStyle *iface, VARIANT v) static HRESULT WINAPI HTMLStyle_get_top(IHTMLStyle *iface, VARIANT *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - BSTR ret; - HRESULT hres; TRACE("(%p)->(%p)\n", This, p); - hres = get_style_attr(This, STYLEID_TOP, &ret); - if(FAILED(hres)) - return hres; - - V_VT(p) = VT_BSTR; - V_BSTR(p) = ret; - return S_OK; + return get_nsstyle_attr_var(This->nsstyle, STYLEID_TOP, p, 0); } static HRESULT WINAPI HTMLStyle_put_left(IHTMLStyle *iface, VARIANT v)

1 0

Jacek Caban : mshtml: Use helper for IHTMLStyle::get_left implementation.
by Alexandre Julliard 04 Apr '12

04 Apr '12

Module: wine Branch: master Commit: 6e97e7e24cdb69d268ef6253a823cd2ba08046d3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6e97e7e24cdb69d268ef6253a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Apr 4 10:31:20 2012 +0200 mshtml: Use helper for IHTMLStyle::get_left implementation. --- dlls/mshtml/htmlstyle.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index 8688549..7cbf895 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -2171,18 +2171,10 @@ static HRESULT WINAPI HTMLStyle_put_left(IHTMLStyle *iface, VARIANT v) static HRESULT WINAPI HTMLStyle_get_left(IHTMLStyle *iface, VARIANT *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - BSTR ret; - HRESULT hres; TRACE("(%p)->(%p)\n", This, p); - hres = get_style_attr(This, STYLEID_LEFT, &ret); - if(FAILED(hres)) - return hres; - - V_VT(p) = VT_BSTR; - V_BSTR(p) = ret; - return S_OK; + return get_nsstyle_attr_var(This->nsstyle, STYLEID_LEFT, p, 0); } static HRESULT WINAPI HTMLStyle_get_position(IHTMLStyle *iface, BSTR *p)

1 0