May 2012 - Wine-commits - list.winehq.org

André Hentschel : d3drm/tests: Add tests for handling Visuals.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: 782c543abb600e5525d531c4c2960f49d659dc86 URL: http://source.winehq.org/git/wine.git/?a=commit;h=782c543abb600e5525d531c4c… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Apr 30 17:11:12 2012 +0200 d3drm/tests: Add tests for handling Visuals. --- dlls/d3drm/tests/d3drm.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c index 36ae19d..e5ab519 100644 --- a/dlls/d3drm/tests/d3drm.c +++ b/dlls/d3drm/tests/d3drm.c @@ -407,6 +407,10 @@ static void test_Frame(void) LPDIRECT3DRMFRAME pFrameP2; LPDIRECT3DRMFRAME pFrameTmp; LPDIRECT3DRMFRAMEARRAY pArray; + LPDIRECT3DRMMESHBUILDER pMeshBuilder; + LPDIRECT3DRMVISUAL pVisual1; + LPDIRECT3DRMVISUAL pVisualTmp; + LPDIRECT3DRMVISUALARRAY pVisualArray; DWORD count; hr = pDirect3DRMCreate(&pD3DRM); @@ -595,6 +599,47 @@ static void test_Frame(void) IDirect3DRMFrameArray_Release(pArray); } + /* [Add/Delete]Visual with NULL pointer */ + hr = IDirect3DRMFrame_AddVisual(pFrameP1, NULL); + ok(hr == D3DRMERR_BADOBJECT, "Should have returned D3DRMERR_BADOBJECT (hr = %x)\n", hr); + todo_wine CHECK_REFCOUNT(pFrameP1, 3); + + hr = IDirect3DRMFrame_DeleteVisual(pFrameP1, NULL); + ok(hr == D3DRMERR_BADOBJECT, "Should have returned D3DRMERR_BADOBJECT (hr = %x)\n", hr); + todo_wine CHECK_REFCOUNT(pFrameP1, 3); + + /* Create Visual */ + hr = IDirect3DRM_CreateMeshBuilder(pD3DRM, &pMeshBuilder); + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMMeshBuilder interface (hr = %x)\n", hr); + pVisual1 = (LPDIRECT3DRMVISUAL)pMeshBuilder; + + /* Add Visual to first parent */ + hr = IDirect3DRMFrame_AddVisual(pFrameP1, pVisual1); + ok(hr == D3DRM_OK, "Cannot add visual (hr = %x)\n", hr); + todo_wine CHECK_REFCOUNT(pFrameP1, 3); + CHECK_REFCOUNT(pVisual1, 2); + + pVisualArray = NULL; + hr = IDirect3DRMFrame_GetVisuals(pFrameP1, &pVisualArray); + todo_wine ok(hr == D3DRM_OK, "Cannot get visuals (hr = %x)\n", hr); + if (pVisualArray) + { + count = IDirect3DRMVisualArray_GetSize(pVisualArray); + ok(count == 1, "count = %u\n", count); + hr = IDirect3DRMVisualArray_GetElement(pVisualArray, 0, &pVisualTmp); + ok(hr == D3DRM_OK, "Cannot get element (hr = %x)\n", hr); + ok(pVisualTmp == pVisual1, "pVisualTmp = %p\n", pVisualTmp); + IDirect3DRMVisual_Release(pVisualTmp); + IDirect3DRMVisualArray_Release(pVisualArray); + } + + /* Delete Visual */ + hr = IDirect3DRMFrame_DeleteVisual(pFrameP1, pVisual1); + ok(hr == D3DRM_OK, "Cannot delete visual (hr = %x)\n", hr); + todo_wine CHECK_REFCOUNT(pFrameP1, 3); + IDirect3DRMMeshBuilder_Release(pMeshBuilder); + + /* Cleanup */ IDirect3DRMMeshBuilder_Release(pFrameP2); CHECK_REFCOUNT(pFrameC, 2); todo_wine CHECK_REFCOUNT(pFrameP1, 3);

1 0

Dmitry Timoshkov : gdiplus: Add more traces to font APIs.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: 542e30b5319c43a32034861f67b1b7dc4371c9b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=542e30b5319c43a32034861f6… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue May 1 15:47:51 2012 +0900 gdiplus: Add more traces to font APIs. --- dlls/gdiplus/font.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c index 8e61aba..7cc5910 100644 --- a/dlls/gdiplus/font.c +++ b/dlls/gdiplus/font.c @@ -316,6 +316,7 @@ GpStatus WINGDIPAPI GdipGetFontSize(GpFont *font, REAL *size) if (!(font && size)) return InvalidParameter; *size = font->emSize; + TRACE("%s,%d => %f\n", debugstr_w(font->lfw.lfFaceName), font->lfw.lfHeight, *size); return Ok; } @@ -372,6 +373,7 @@ GpStatus WINGDIPAPI GdipGetFontUnit(GpFont *font, Unit *unit) if (!(font && unit)) return InvalidParameter; *unit = font->unit; + TRACE("%s,%d => %d\n", debugstr_w(font->lfw.lfFaceName), font->lfw.lfHeight, *unit); return Ok; } @@ -412,6 +414,7 @@ GpStatus WINGDIPAPI GdipGetLogFontW(GpFont *font, GpGraphics *graphics, return InvalidParameter; *lfw = font->lfw; + TRACE("=> %s,%d\n", debugstr_w(font->lfw.lfFaceName), font->lfw.lfHeight); return Ok; } @@ -512,6 +515,9 @@ GpStatus WINGDIPAPI GdipGetFontHeightGivenDPI(GDIPCONST GpFont *font, REAL dpi, return NotImplemented; } + TRACE("%s,%d(unit %d) => %f\n", + debugstr_w(font->lfw.lfFaceName), font->lfw.lfHeight, font->unit, *height); + return Ok; } @@ -705,6 +711,7 @@ GpStatus WINGDIPAPI GdipGetCellAscent(GDIPCONST GpFontFamily *family, if (!(family && CellAscent)) return InvalidParameter; *CellAscent = family->otm.otmTextMetrics.tmAscent; + TRACE("%d => %u\n", family->otm.otmTextMetrics.tmHeight, *CellAscent); return Ok; } @@ -717,6 +724,7 @@ GpStatus WINGDIPAPI GdipGetCellDescent(GDIPCONST GpFontFamily *family, if (!(family && CellDescent)) return InvalidParameter; *CellDescent = family->otm.otmTextMetrics.tmDescent; + TRACE("%d => %u\n", family->otm.otmTextMetrics.tmHeight, *CellDescent); return Ok; } @@ -742,6 +750,7 @@ GpStatus WINGDIPAPI GdipGetEmHeight(GDIPCONST GpFontFamily *family, INT style, U TRACE("%p (%s), %d, %p\n", family, debugstr_w(family->FamilyName), style, EmHeight); *EmHeight = family->otm.otmEMSquare; + TRACE("%d => %u\n", family->otm.otmTextMetrics.tmHeight, *EmHeight); return Ok; } @@ -772,6 +781,7 @@ GpStatus WINGDIPAPI GdipGetLineSpacing(GDIPCONST GpFontFamily *family, if (style) FIXME("ignoring style\n"); *LineSpacing = family->otm.otmTextMetrics.tmAscent + family->otm.otmTextMetrics.tmDescent + family->otm.otmTextMetrics.tmExternalLeading; + TRACE("%d => %u\n", family->otm.otmTextMetrics.tmHeight, *LineSpacing); return Ok; }

1 0

Józef Kucia : d3dx9: Add partial DDS support implementation for D3DXGetImageInfo functions.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: 4618e388e69400084dd84c2d6972f2950142ff0f URL: http://source.winehq.org/git/wine.git/?a=commit;h=4618e388e69400084dd84c2d6… Author: Józef Kucia <joseph.kucia(a)gmail.com> Date: Sun Apr 29 21:43:08 2012 +0200 d3dx9: Add partial DDS support implementation for D3DXGetImageInfo functions. --- dlls/d3dx9_36/surface.c | 133 +++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 129 insertions(+), 4 deletions(-) diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c index 5874c52..e361c80 100644 --- a/dlls/d3dx9_36/surface.c +++ b/dlls/d3dx9_36/surface.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2009-2010 Tony Wasserka + * Copyright (C) 2012 Józef Kucia * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -28,9 +29,132 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3dx); /* Wine-specific WIC GUIDs */ - DEFINE_GUID(GUID_WineContainerFormatTga, 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47,0x3f,0xc1,0x7c,0xd3,0x22); +/* dds_header.flags */ +#define DDS_CAPS 0x1 +#define DDS_HEIGHT 0x2 +#define DDS_WIDTH 0x2 +#define DDS_PITCH 0x8 +#define DDS_PIXELFORMAT 0x1000 +#define DDS_MIPMAPCOUNT 0x20000 +#define DDS_LINEARSIZE 0x80000 +#define DDS_DEPTH 0x800000 + +/* dds_header.caps */ +#define DDS_CAPS_COMPLEX 0x8 +#define DDS_CAPS_TEXTURE 0x1000 +#define DDS_CAPS_MIPMAP 0x400000 + +/* dds_header.caps2 */ +#define DDS_CAPS2_CUBEMAP 0x200 +#define DDS_CAPS2_CUBEMAP_POSITIVEX 0x400 +#define DDS_CAPS2_CUBEMAP_NEGATIVEX 0x800 +#define DDS_CAPS2_CUBEMAP_POSITIVEY 0x1000 +#define DDS_CAPS2_CUBEMAP_NEGATIVEY 0x2000 +#define DDS_CAPS2_CUBEMAP_POSITIVEZ 0x4000 +#define DDS_CAPS2_CUBEMAP_NEGATIVEZ 0x8000 +#define DDS_CAPS2_VOLUME 0x200000 + +/* dds_pixel_format.flags */ +#define DDS_PF_ALPHA 0x1 +#define DDS_PF_ALPHA_ONLY 0x2 +#define DDS_PF_FOURCC 0x4 +#define DDS_PF_RGB 0x40 +#define DDS_PF_YUV 0x200 +#define DDS_PF_LUMINANCE 0x20000 + +struct dds_pixel_format +{ + DWORD size; + DWORD flags; + DWORD fourcc; + DWORD bpp; + DWORD rmask; + DWORD gmask; + DWORD bmask; + DWORD amask; +}; + +struct dds_header +{ + DWORD signature; + DWORD size; + DWORD flags; + DWORD height; + DWORD width; + DWORD pitch_or_linear_size; + DWORD depth; + DWORD miplevels; + DWORD reserved[11]; + struct dds_pixel_format pixel_format; + DWORD caps; + DWORD caps2; + DWORD caps3; + DWORD caps4; + DWORD reserved2; +}; + +static D3DFORMAT dds_pixel_format_to_d3dformat(const struct dds_pixel_format *pixel_format) +{ + FIXME("Pixel format conversion not implemented.\n"); + return D3DFMT_UNKNOWN; +} + +/************************************************************ +* get_image_info_from_dds +* +* Fills a D3DXIMAGE_INFO structure with information +* about a DDS file stored in the memory. +* +* PARAMS +* buffer [I] pointer to DDS data +* length [I] size of DDS data +* info [O] pointer to D3DXIMAGE_INFO structure +* +* RETURNS +* Success: D3D_OK +* Failure: D3DXERR_INVALIDDATA +* +*/ +static HRESULT get_image_info_from_dds(const void *buffer, DWORD length, D3DXIMAGE_INFO *info) +{ + const struct dds_header *header = buffer; + + if (length < sizeof(*header) || !info) + return D3DXERR_INVALIDDATA; + + if (header->pixel_format.size != sizeof(header->pixel_format)) + return D3DXERR_INVALIDDATA; + + info->Width = header->width; + info->Height = header->height; + info->Depth = 1; + info->MipLevels = (header->flags & DDS_MIPMAPCOUNT) ? header->miplevels : 1; + + info->Format = dds_pixel_format_to_d3dformat(&header->pixel_format); + if (info->Format == D3DFMT_UNKNOWN) + return D3DXERR_INVALIDDATA; + + if (header->caps2 & DDS_CAPS2_VOLUME) + { + info->Depth = header->depth; + info->ResourceType = D3DRTYPE_VOLUMETEXTURE; + } + else if (header->caps2 & DDS_CAPS2_CUBEMAP) + { + info->ResourceType = D3DRTYPE_CUBETEXTURE; + } + else + { + info->ResourceType = D3DRTYPE_TEXTURE; + } + + info->ImageFileFormat = D3DXIFF_DDS; + + return D3D_OK; +} + /************************************************************ * D3DXGetImageInfoFromFileInMemory * @@ -68,6 +192,9 @@ HRESULT WINAPI D3DXGetImageInfoFromFileInMemory(LPCVOID data, UINT datasize, D3D if (!info) return D3D_OK; + if ((datasize >= 4) && !strncmp(data, "DDS ", 4)) + return get_image_info_from_dds(data, datasize, info); + initresult = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); hr = CoCreateInstance(&CLSID_WICImagingFactory, NULL, CLSCTX_INPROC_SERVER, &IID_IWICImagingFactory, (void**)&factory); @@ -81,9 +208,7 @@ HRESULT WINAPI D3DXGetImageInfoFromFileInMemory(LPCVOID data, UINT datasize, D3D } if (FAILED(hr)) { - if ((datasize >= 4) && !strncmp(data, "DDS ", 4)) - FIXME("File type DDS is not supported yet\n"); - else if ((datasize >= 2) && (!strncmp(data, "P3", 2) || !strncmp(data, "P6", 2))) + if ((datasize >= 2) && (!strncmp(data, "P3", 2) || !strncmp(data, "P6", 2))) FIXME("File type PPM is not supported yet\n"); else if ((datasize >= 2) && !strncmp(data, "BM", 2)) FIXME("File type DIB is not supported yet\n");

1 0

Józef Kucia : d3dx9: Implement conversion from DDS pixel format to D3DFORMAT.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: d3068976e5c9199f76aaec8f07a213457e448035 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d3068976e5c9199f76aaec8f0… Author: Józef Kucia <joseph.kucia(a)gmail.com> Date: Sun Apr 29 21:43:10 2012 +0200 d3dx9: Implement conversion from DDS pixel format to D3DFORMAT. --- dlls/d3dx9_36/surface.c | 112 ++++++++++++++++++++++++++++++- dlls/d3dx9_36/tests/surface.c | 149 +++++++++++++++++++++-------------------- 2 files changed, 186 insertions(+), 75 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d3068976e5c9199f76aae…

1 0

Stefan Leichter : wsnmp32: New stub dll.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: 0c1bd482b58b0e86c7f7b5a6b67e2f9788291075 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0c1bd482b58b0e86c7f7b5a6b… Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Tue May 1 08:07:57 2012 +0200 wsnmp32: New stub dll. --- configure | 1 + configure.ac | 1 + dlls/wsnmp32/Makefile.in | 5 ++++ dlls/wsnmp32/wsnmp32.c | 41 ++++++++++++++++++++++++++++++++++++++ dlls/wsnmp32/wsnmp32.spec | 48 +++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 96 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 5b8c648..fbe00c6 100755 --- a/configure +++ b/configure @@ -15462,6 +15462,7 @@ wine_fn_config_dll ws2_32 enable_ws2_32 implib wine_fn_config_test dlls/ws2_32/tests ws2_32_test wine_fn_config_dll wshom.ocx enable_wshom_ocx wine_fn_config_test dlls/wshom.ocx/tests wshom.ocx_test +wine_fn_config_dll wsnmp32 enable_wsnmp32 wine_fn_config_dll wsock32 enable_wsock32 implib wine_fn_config_dll wtsapi32 enable_wtsapi32 implib wine_fn_config_dll wuapi enable_wuapi diff --git a/configure.ac b/configure.ac index 18da8c5..849508c 100644 --- a/configure.ac +++ b/configure.ac @@ -2950,6 +2950,7 @@ WINE_CONFIG_DLL(ws2_32,,[implib]) WINE_CONFIG_TEST(dlls/ws2_32/tests) WINE_CONFIG_DLL(wshom.ocx) WINE_CONFIG_TEST(dlls/wshom.ocx/tests) +WINE_CONFIG_DLL(wsnmp32) WINE_CONFIG_DLL(wsock32,,[implib]) WINE_CONFIG_DLL(wtsapi32,,[implib]) WINE_CONFIG_DLL(wuapi) diff --git a/dlls/wsnmp32/Makefile.in b/dlls/wsnmp32/Makefile.in new file mode 100644 index 0000000..0fe0da2 --- /dev/null +++ b/dlls/wsnmp32/Makefile.in @@ -0,0 +1,5 @@ +MODULE = wsnmp32.dll + +C_SRCS = wsnmp32.c + +(a)MAKE_DLL_RULES@ diff --git a/dlls/wsnmp32/wsnmp32.c b/dlls/wsnmp32/wsnmp32.c new file mode 100644 index 0000000..6ace895 --- /dev/null +++ b/dlls/wsnmp32/wsnmp32.c @@ -0,0 +1,41 @@ +/* + * Copyright 2012 Stefan Leichter + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdarg.h> +#include "windef.h" +#include "winbase.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(wsnmp32); + +BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) +{ + TRACE("%p, %u, %p\n", hinst, reason, reserved); + + switch (reason) + { + case DLL_WINE_PREATTACH: + return FALSE; /* prefer native version */ + case DLL_PROCESS_ATTACH: + DisableThreadLibraryCalls( hinst ); + break; + case DLL_PROCESS_DETACH: + break; + } + return TRUE; +} diff --git a/dlls/wsnmp32/wsnmp32.spec b/dlls/wsnmp32/wsnmp32.spec new file mode 100644 index 0000000..fedf760 --- /dev/null +++ b/dlls/wsnmp32/wsnmp32.spec @@ -0,0 +1,48 @@ +100 stub SnmpGetTranslateMode +101 stub SnmpSetTranslateMode +102 stub SnmpGetRetransmitMode +103 stub SnmpSetRetransmitMode +104 stub SnmpGetTimeout +105 stub SnmpSetTimeout +106 stub SnmpSetRetry +107 stub SnmpGetRetry +108 stub _SnmpConveyAgentAddress(a)4 +109 stub _SnmpSetAgentAddress(a)4 +120 stub SnmpGetVendorInfo +200 stub SnmpStartup +201 stub SnmpCleanup +202 stub SnmpOpen +203 stub SnmpClose +204 stub SnmpSendMsg +205 stub SnmpRecvMsg +206 stub SnmpRegister +220 stub SnmpCreateSession +221 stub SnmpListen +222 stub SnmpCancelMsg +300 stub SnmpStrToEntity +301 stub SnmpEntityToStr +302 stub SnmpFreeEntity +320 stub SnmpSetPort +400 stub SnmpStrToContext +401 stub SnmpContextToStr +402 stub SnmpFreeContext +500 stub SnmpCreatePdu +501 stub SnmpGetPduData +502 stub SnmpSetPduData +503 stub SnmpDuplicatePdu +504 stub SnmpFreePdu +600 stub SnmpCreateVbl +601 stub SnmpDuplicateVbl +602 stub SnmpFreeVbl +603 stub SnmpCountVbl +604 stub SnmpGetVb +605 stub SnmpSetVb +606 stub SnmpDeleteVb +900 stub SnmpFreeDescriptor +901 stub SnmpEncodeMsg +902 stub SnmpDecodeMsg +903 stub SnmpStrToOid +904 stub SnmpOidToStr +905 stub SnmpOidCopy +906 stub SnmpOidCompare +999 stub SnmpGetLastError

1 0

Hans Leidekker : msi: Remove a workaround for missing Windows Script interfaces.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: 52738e4f93314d1ae17c992a0d08bdfc6beea844 URL: http://source.winehq.org/git/wine.git/?a=commit;h=52738e4f93314d1ae17c992a0… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue May 1 12:38:27 2012 +0200 msi: Remove a workaround for missing Windows Script interfaces. --- dlls/msi/script.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/dlls/msi/script.c b/dlls/msi/script.c index 27bbee1..e157c6d 100644 --- a/dlls/msi/script.c +++ b/dlls/msi/script.c @@ -88,10 +88,7 @@ DWORD call_script(MSIHANDLE hPackage, INT type, LPCWSTR script, LPCWSTR function DISPID dispid; CLSID clsid; VARIANT var; - - /* Return success by default (if Windows Script not installed) - not native behavior. This - * should be here until we implement wine scripting. */ - DWORD ret = ERROR_SUCCESS; + DWORD ret = ERROR_INSTALL_FAILURE; CoInitialize(NULL); @@ -126,9 +123,6 @@ DWORD call_script(MSIHANDLE hPackage, INT type, LPCWSTR script, LPCWSTR function goto done; } - /* If we got this far, Windows Script is installed, so don't return success by default anymore */ - ret = ERROR_INSTALL_FAILURE; - /* Get the IActiveScriptParse engine interface */ hr = IActiveScript_QueryInterface(pActiveScript, &IID_IActiveScriptParse, (void **)&pActiveScriptParse); if (FAILED(hr)) goto done;

1 0

Hans Leidekker : msi: Add the Session object as a global member to custom action scripts.
by Alexandre Julliard 01 May '12

01 May '12

Module: wine Branch: master Commit: c3e3c81bfb661e02f497667d91bfa9867683e491 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c3e3c81bfb661e02f497667d9… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue May 1 12:38:52 2012 +0200 msi: Add the Session object as a global member to custom action scripts. --- dlls/msi/script.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/script.c b/dlls/msi/script.c index e157c6d..236b60b 100644 --- a/dlls/msi/script.c +++ b/dlls/msi/script.c @@ -136,7 +136,7 @@ DWORD call_script(MSIHANDLE hPackage, INT type, LPCWSTR script, LPCWSTR function if (FAILED(hr)) goto done; /* Add the session object */ - hr = IActiveScript_AddNamedItem(pActiveScript, szSession, SCRIPTITEM_ISVISIBLE); + hr = IActiveScript_AddNamedItem(pActiveScript, szSession, SCRIPTITEM_GLOBALMEMBERS); if (FAILED(hr)) goto done; /* Pass the script to the engine */

1 0