August 2012 - Wine-commits - list.winehq.org

Alistair Leslie-Hughes : scrrun: Add missing id value.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: f40bad4ce53ff17fe6602ef225b970182082817c URL: http://source.winehq.org/git/wine.git/?a=commit;h=f40bad4ce53ff17fe6602ef22… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Mon Aug 6 11:23:16 2012 +1000 scrrun: Add missing id value. --- dlls/scrrun/scrrun.idl | 1 + dlls/scrrun/tests/scrrun.idl | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/scrrun/scrrun.idl b/dlls/scrrun/scrrun.idl index f1e8984..4b18af1 100644 --- a/dlls/scrrun/scrrun.idl +++ b/dlls/scrrun/scrrun.idl @@ -526,6 +526,7 @@ library Scripting [id(0x00002713), propget] HRESULT AtEndOfLine([out, retval] VARIANT_BOOL* EOL); + [id(0x00002714)] HRESULT Read([in] long Characters, [out, retval] BSTR* Text); [id(0x00002715)] diff --git a/dlls/scrrun/tests/scrrun.idl b/dlls/scrrun/tests/scrrun.idl index f1e8984..4b18af1 100644 --- a/dlls/scrrun/tests/scrrun.idl +++ b/dlls/scrrun/tests/scrrun.idl @@ -526,6 +526,7 @@ library Scripting [id(0x00002713), propget] HRESULT AtEndOfLine([out, retval] VARIANT_BOOL* EOL); + [id(0x00002714)] HRESULT Read([in] long Characters, [out, retval] BSTR* Text); [id(0x00002715)]

1 0

Jacek Caban : rpcrt4: Added cancelling support for all HTTP requests.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: cbdb58476a4b966a6303cc35bcc588b9851ecfb4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cbdb58476a4b966a6303cc35b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 15 10:22:39 2012 +0200 rpcrt4: Added cancelling support for all HTTP requests. --- dlls/rpcrt4/rpc_transport.c | 30 ++++++++++++++++-------------- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index 76a9714..b44198f 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -1877,6 +1877,9 @@ static void prepare_async_request(RpcHttpAsyncData *async_data) static RPC_STATUS wait_async_request(RpcHttpAsyncData *async_data, BOOL call_ret, HANDLE cancel_event) { + HANDLE handles[2] = { async_data->completion_event, cancel_event }; + DWORD res; + if(call_ret) { RpcHttpAsyncData_Release(async_data); return RPC_S_OK; @@ -1888,16 +1891,12 @@ static RPC_STATUS wait_async_request(RpcHttpAsyncData *async_data, BOOL call_ret return RPC_S_SERVER_UNAVAILABLE; } - if(cancel_event) { - HANDLE handles[2] = { async_data->completion_event, cancel_event }; - DWORD res; - - res = WaitForMultipleObjects(2, handles, FALSE, DEFAULT_NCACN_HTTP_TIMEOUT); - if(res != WAIT_OBJECT_0) - return RPC_S_CALL_CANCELLED; - }else { - WaitForSingleObject(async_data->completion_event, INFINITE); + res = WaitForMultipleObjects(2, handles, FALSE, DEFAULT_NCACN_HTTP_TIMEOUT); + if(res != WAIT_OBJECT_0) { + TRACE("Cancelled\n"); + return RPC_S_CALL_CANCELLED; } + if(async_data->async_result) { ERR("Async request failed with error %d\n", async_data->async_result); return RPC_S_SERVER_UNAVAILABLE; @@ -2176,7 +2175,7 @@ static RPC_STATUS rpcrt4_http_internet_connect(RpcConnection_http *httpc) } /* prepare the in pipe for use by RPC packets */ -static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsyncData *async_data, +static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsyncData *async_data, HANDLE cancel_event, const UUID *connection_uuid, const UUID *in_pipe_uuid, const UUID *association_uuid) @@ -2191,7 +2190,7 @@ static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsync /* prepare in pipe */ prepare_async_request(async_data); ret = HttpSendRequestW(in_request, NULL, 0, NULL, 0); - status = wait_async_request(async_data, ret, NULL); + status = wait_async_request(async_data, ret, cancel_event); if(status != RPC_S_OK) return status; status = rpcrt4_http_check_response(in_request); @@ -2206,7 +2205,7 @@ static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsync buffers_in.dwBufferTotal = 1024 * 1024 * 1024; /* 1Gb */ prepare_async_request(async_data); ret = HttpSendRequestExW(in_request, &buffers_in, NULL, 0, 0); - status = wait_async_request(async_data, ret, NULL); + status = wait_async_request(async_data, ret, cancel_event); if (status != RPC_S_OK) return status; TRACE("sending HTTP connect header to server\n"); @@ -2271,6 +2270,7 @@ static RPC_STATUS rpcrt4_http_read_http_packet(HINTERNET request, RpcPktHdr *hdr /* prepare the out pipe for use by RPC packets */ static RPC_STATUS rpcrt4_http_prepare_out_pipe(HINTERNET out_request, RpcHttpAsyncData *async_data, + HANDLE cancel_event, const UUID *connection_uuid, const UUID *out_pipe_uuid, ULONG *flow_control_increment) @@ -2286,7 +2286,7 @@ static RPC_STATUS rpcrt4_http_prepare_out_pipe(HINTERNET out_request, prepare_async_request(async_data); ret = HttpSendRequestW(out_request, NULL, 0, NULL, 0); - status = wait_async_request(async_data, ret, NULL); + status = wait_async_request(async_data, ret, cancel_event); if (status != RPC_S_OK) return status; status = rpcrt4_http_check_response(out_request); @@ -2300,7 +2300,7 @@ static RPC_STATUS rpcrt4_http_prepare_out_pipe(HINTERNET out_request, prepare_async_request(async_data); ret = HttpSendRequestW(out_request, NULL, 0, hdr, hdr->common.frag_len); - status = wait_async_request(async_data, ret, NULL); + status = wait_async_request(async_data, ret, cancel_event); RPCRT4_FreeHeader(hdr); if (status != RPC_S_OK) return status; @@ -2398,6 +2398,7 @@ static RPC_STATUS rpcrt4_ncacn_http_open(RpcConnection* Connection) status = rpcrt4_http_prepare_in_pipe(httpc->in_request, httpc->async_data, + httpc->cancel_event, &httpc->connection_uuid, &httpc->in_pipe_uuid, &Connection->assoc->http_uuid); @@ -2406,6 +2407,7 @@ static RPC_STATUS rpcrt4_ncacn_http_open(RpcConnection* Connection) status = rpcrt4_http_prepare_out_pipe(httpc->out_request, httpc->async_data, + httpc->cancel_event, &httpc->connection_uuid, &httpc->out_pipe_uuid, &httpc->flow_control_increment);

1 0

Jacek Caban : rpcrt4: Fixed memory leak.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: 07cb28c64132b8323d715a1bebd53b5a0844463f URL: http://source.winehq.org/git/wine.git/?a=commit;h=07cb28c64132b8323d715a1be… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 15 10:22:56 2012 +0200 rpcrt4: Fixed memory leak. --- dlls/rpcrt4/rpc_transport.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index b44198f..347bb41 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -2384,12 +2384,14 @@ static RPC_STATUS rpcrt4_ncacn_http_open(RpcConnection* Connection) if (!httpc->in_request) { ERR("HttpOpenRequestW failed with error %d\n", GetLastError()); + HeapFree(GetProcessHeap(), 0, url); return RPC_S_SERVER_UNAVAILABLE; } httpc->out_request = HttpOpenRequestW(httpc->session, wszVerbOut, url, NULL, NULL, wszAcceptTypes, (secure ? INTERNET_FLAG_SECURE : 0)|INTERNET_FLAG_KEEP_CONNECTION|INTERNET_FLAG_PRAGMA_NOCACHE, (DWORD_PTR)httpc->async_data); + HeapFree(GetProcessHeap(), 0, url); if (!httpc->out_request) { ERR("HttpOpenRequestW failed with error %d\n", GetLastError());

1 0

Jacek Caban : rpcrt4: Moved sending echo request to separated function.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: ee40973b2b71980b669470b5b250decc606ed4cd URL: http://source.winehq.org/git/wine.git/?a=commit;h=ee40973b2b71980b669470b5b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 15 10:23:07 2012 +0200 rpcrt4: Moved sending echo request to separated function. --- dlls/rpcrt4/rpc_transport.c | 46 ++++++++++++++++++++++-------------------- 1 files changed, 24 insertions(+), 22 deletions(-) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index 347bb41..686ce68 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -2174,31 +2174,43 @@ static RPC_STATUS rpcrt4_http_internet_connect(RpcConnection_http *httpc) return RPC_S_OK; } +static RPC_STATUS send_echo_request(HINTERNET req, RpcHttpAsyncData *async_data, HANDLE cancel_event) +{ + DWORD bytes_read; + BYTE buf[20]; + BOOL ret; + RPC_STATUS status; + + prepare_async_request(async_data); + ret = HttpSendRequestW(req, NULL, 0, NULL, 0); + status = wait_async_request(async_data, ret, cancel_event); + if (status != RPC_S_OK) return status; + + status = rpcrt4_http_check_response(req); + if (status != RPC_S_OK) return status; + + InternetReadFile(req, buf, sizeof(buf), &bytes_read); + /* FIXME: do something with retrieved data */ + + return RPC_S_OK; +} + /* prepare the in pipe for use by RPC packets */ static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsyncData *async_data, HANDLE cancel_event, const UUID *connection_uuid, const UUID *in_pipe_uuid, const UUID *association_uuid) { - BYTE packet[44]; BOOL ret; RPC_STATUS status; RpcPktHdr *hdr; INTERNET_BUFFERSW buffers_in; - DWORD bytes_read, bytes_written; + DWORD bytes_written; /* prepare in pipe */ - prepare_async_request(async_data); - ret = HttpSendRequestW(in_request, NULL, 0, NULL, 0); - status = wait_async_request(async_data, ret, cancel_event); - if(status != RPC_S_OK) return status; - - status = rpcrt4_http_check_response(in_request); + status = send_echo_request(in_request, async_data, cancel_event); if (status != RPC_S_OK) return status; - InternetReadFile(in_request, packet, 20, &bytes_read); - /* FIXME: do something with retrieved data */ - memset(&buffers_in, 0, sizeof(buffers_in)); buffers_in.dwStructSize = sizeof(buffers_in); /* FIXME: get this from the registry */ @@ -2275,26 +2287,16 @@ static RPC_STATUS rpcrt4_http_prepare_out_pipe(HINTERNET out_request, const UUID *out_pipe_uuid, ULONG *flow_control_increment) { - BYTE packet[20]; BOOL ret; RPC_STATUS status; RpcPktHdr *hdr; - DWORD bytes_read; BYTE *data_from_server; RpcPktHdr pkt_from_server; ULONG field1, field3; - prepare_async_request(async_data); - ret = HttpSendRequestW(out_request, NULL, 0, NULL, 0); - status = wait_async_request(async_data, ret, cancel_event); + status = send_echo_request(out_request, async_data, cancel_event); if (status != RPC_S_OK) return status; - status = rpcrt4_http_check_response(out_request); - if (status != RPC_S_OK) return status; - - InternetReadFile(out_request, packet, 20, &bytes_read); - /* FIXME: do something with retrieved data */ - hdr = RPCRT4_BuildHttpConnectHeader(0, TRUE, connection_uuid, out_pipe_uuid, NULL); if (!hdr) return RPC_S_OUT_OF_RESOURCES;

1 0

Jacek Caban : mmdevapi: Use proper helpers for iface calls.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: 223105b9b37cb20926ff0a9975a818c754e9ec4e URL: http://source.winehq.org/git/wine.git/?a=commit;h=223105b9b37cb20926ff0a997… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 15 11:45:03 2012 +0200 mmdevapi: Use proper helpers for iface calls. --- dlls/mmdevapi/devenum.c | 2 +- dlls/mmdevapi/main.c | 6 ++-- dlls/mmdevapi/tests/capture.c | 2 +- dlls/mmdevapi/tests/dependency.c | 8 +++--- dlls/mmdevapi/tests/mmdevenum.c | 40 ++++++++++++++++++------------------ dlls/mmdevapi/tests/propstore.c | 2 +- dlls/mmdevapi/tests/render.c | 42 +++++++++++++++++++------------------- 7 files changed, 51 insertions(+), 51 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=223105b9b37cb20926ff0…

1 0

Jacek Caban : strmbase: Use proper helpers for iface calls.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: db82997560b753c3c30e29c85ef1e7bfb609509b URL: http://source.winehq.org/git/wine.git/?a=commit;h=db82997560b753c3c30e29c85… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 15 11:45:21 2012 +0200 strmbase: Use proper helpers for iface calls. --- dlls/strmbase/outputqueue.c | 2 +- dlls/strmbase/qualitycontrol.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/strmbase/outputqueue.c b/dlls/strmbase/outputqueue.c index 3656d49..cbcd964 100644 --- a/dlls/strmbase/outputqueue.c +++ b/dlls/strmbase/outputqueue.c @@ -275,7 +275,7 @@ DWORD WINAPI OutputQueueImpl_ThreadProc(OutputQueue *pOutputQueue) IMemInputPin_Release(pOutputQueue->pInputPin->pMemInputPin); } for (i = 0; i < nSamples; i++) - IUnknown_Release(ppSamples[i]); + IMediaSample_Release(ppSamples[i]); HeapFree(GetProcessHeap(),0,ppSamples); /* Process Non-Samples */ diff --git a/dlls/strmbase/qualitycontrol.c b/dlls/strmbase/qualitycontrol.c index f6c9ea7..f96ed64 100644 --- a/dlls/strmbase/qualitycontrol.c +++ b/dlls/strmbase/qualitycontrol.c @@ -56,17 +56,17 @@ HRESULT QualityControlImpl_Destroy(QualityControlImpl *This) HRESULT WINAPI QualityControlImpl_QueryInterface(IQualityControl *iface, REFIID riid, void **ppv) { QualityControlImpl *This = (QualityControlImpl*)iface; - return IUnknown_QueryInterface(This->self, riid, ppv); + return IBaseFilter_QueryInterface(This->self, riid, ppv); } ULONG WINAPI QualityControlImpl_AddRef(IQualityControl *iface) { QualityControlImpl *This = (QualityControlImpl*)iface; - return IUnknown_AddRef(This->self); + return IBaseFilter_AddRef(This->self); } ULONG WINAPI QualityControlImpl_Release(IQualityControl *iface) { QualityControlImpl *This = (QualityControlImpl*)iface; - return IUnknown_Release(This->self); + return IBaseFilter_Release(This->self); } HRESULT WINAPI QualityControlImpl_Notify(IQualityControl *iface, IBaseFilter *sender, Quality qm) { @@ -79,7 +79,7 @@ HRESULT WINAPI QualityControlImpl_Notify(IQualityControl *iface, IBaseFilter *se IPin_ConnectedTo(This->input, &to); if (to) { IQualityControl *qc = NULL; - IUnknown_QueryInterface(to, &IID_IQualityControl, (void**)&qc); + IPin_QueryInterface(to, &IID_IQualityControl, (void**)&qc); if (qc) { hr = IQualityControl_Notify(qc, This->self, qm); IQualityControl_Release(qc);

1 0

Jacek Caban : shlwapi: Use proper helpers for iface calls.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: 4d5bebb32180945d4c3bd28408b4dd48a3c7c672 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4d5bebb32180945d4c3bd2840… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 15 11:54:42 2012 +0200 shlwapi: Use proper helpers for iface calls. --- dlls/shlwapi/ordinal.c | 12 ++++++------ dlls/shlwapi/tests/ordinal.c | 22 +++++++++++----------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/dlls/shlwapi/ordinal.c b/dlls/shlwapi/ordinal.c index 0c64ed0..88f415b 100644 --- a/dlls/shlwapi/ordinal.c +++ b/dlls/shlwapi/ordinal.c @@ -446,7 +446,7 @@ HRESULT WINAPI RegisterDefaultAcceptHeaders(LPBC lpBC, IUnknown *lpUnknown) IEnumFORMATETC_Release(pClone); } - IEnumFORMATETC_Release(pIUnknown); + IUnknown_Release(pIUnknown); } IUnknown_Release(V_UNKNOWN(&var)); } @@ -1202,7 +1202,7 @@ HRESULT WINAPI ConnectToConnectionPoint(IUnknown* lpUnkSink, REFIID riid, BOOL f IConnectionPoint_Release(lpCP); /* Release it */ } - IUnknown_Release(lpContainer); + IConnectionPointContainer_Release(lpContainer); } return hRet; } @@ -1400,7 +1400,7 @@ HRESULT WINAPI IUnknown_SetSite( { hr = IObjectWithSite_SetSite(iobjwithsite, site); TRACE("done IObjectWithSite_SetSite ret=%08x\n", hr); - IUnknown_Release(iobjwithsite); + IObjectWithSite_Release(iobjwithsite); } else { @@ -1410,7 +1410,7 @@ HRESULT WINAPI IUnknown_SetSite( hr = IInternetSecurityManager_SetSecuritySite(isecmgr, (IInternetSecurityMgrSite *)site); TRACE("done IInternetSecurityManager_SetSecuritySite ret=%08x\n", hr); - IUnknown_Release(isecmgr); + IInternetSecurityManager_Release(isecmgr); } return hr; } @@ -1493,7 +1493,7 @@ HRESULT WINAPI IUnknown_QueryService(IUnknown* lpUnknown, REFGUID sid, REFIID ri TRACE("(IServiceProvider*)%p returned (IUnknown*)%p\n", pService, *lppOut); - IUnknown_Release(pService); + IServiceProvider_Release(pService); } return hRet; } @@ -1613,7 +1613,7 @@ HRESULT WINAPI IUnknown_UIActivateIO(IUnknown *unknown, BOOL activate, LPMSG msg if (ret == S_OK) { ret = IInputObject_UIActivateIO(object, activate, msg); - IUnknown_Release(object); + IInputObject_Release(object); } return ret; diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c index e787daa..1229ae2 100644 --- a/dlls/shlwapi/tests/ordinal.c +++ b/dlls/shlwapi/tests/ordinal.c @@ -833,7 +833,7 @@ static HRESULT WINAPI Disp_QueryInterface( if (*ppvObject) { - IUnknown_AddRef(This); + IDispatch_AddRef(This); return S_OK; } @@ -948,7 +948,7 @@ static HRESULT WINAPI Enum_QueryInterface( if (*ppvObject) { - IUnknown_AddRef(This); + IEnumConnections_AddRef(This); return S_OK; } @@ -1040,7 +1040,7 @@ static HRESULT WINAPI ConPt_QueryInterface( if (*ppvObject) { - IUnknown_AddRef(This); + IConnectionPoint_AddRef(This); return S_OK; } @@ -1181,7 +1181,7 @@ static HRESULT WINAPI EnumPt_QueryInterface( if (*ppvObject) { - IUnknown_AddRef(This); + IEnumConnectionPoints_AddRef(This); return S_OK; } @@ -1217,7 +1217,7 @@ static HRESULT WINAPI EnumPt_Next( if (cConnections > 0 && iface->idx < iface->container->ptCount) { *rgcd = iface->container->pt[iface->idx]; - IUnknown_AddRef(iface->container->pt[iface->idx]); + IConnectionPoint_AddRef(iface->container->pt[iface->idx]); if (pcFetched) *pcFetched = 1; iface->idx++; @@ -1272,7 +1272,7 @@ static HRESULT WINAPI Contain_QueryInterface( if (*ppvObject) { - IUnknown_AddRef(This); + IConnectionPointContainer_AddRef(This); return S_OK; } @@ -1300,7 +1300,7 @@ static ULONG WINAPI Contain_Release( { int i; for (i = 0; i < iface->ptCount; i++) - IUnknown_Release(iface->pt[i]); + IConnectionPoint_Release(iface->pt[i]); HeapFree(GetProcessHeap(),0,iface->pt); } HeapFree(GetProcessHeap(),0,This); @@ -1456,7 +1456,7 @@ static HRESULT WINAPI Prop_QueryInterface( if (*ppvObject) { - IUnknown_AddRef(This); + IPropertyBag_AddRef(This); return S_OK; } @@ -2104,7 +2104,7 @@ static HRESULT WINAPI IOleCommandTargetImpl_QueryInterface(IOleCommandTarget *if if(*ppvObj) { - IUnknown_AddRef(iface); + IOleCommandTarget_AddRef(iface); return S_OK; } @@ -2215,7 +2215,7 @@ static HRESULT WINAPI IServiceProviderImpl_QueryInterface(IServiceProvider *ifac if(*ppvObj) { - IUnknown_AddRef(iface); + IServiceProvider_AddRef(iface); /* native uses redefined IID_IServiceProvider symbol, so we can't compare pointers */ if (IsEqualIID(riid, &IID_IServiceProvider)) add_call(&trace_got, 1, iface, &IID_IServiceProvider, 0, 0, 0); @@ -2333,7 +2333,7 @@ static HRESULT WINAPI IProfferServiceImpl_QueryInterface(IProfferService *iface, if(*ppvObj) { - IUnknown_AddRef(iface); + IProfferService_AddRef(iface); return S_OK; }

1 0

Michael Stefaniuc : wineps.drv: Drop a superfluous TRUE: FALSE conditional expression.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: c1223611af034b6553ee7caf3cf14f5bbd46838d URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1223611af034b6553ee7caf3… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:04:03 2012 +0200 wineps.drv: Drop a superfluous TRUE:FALSE conditional expression. --- dlls/wineps.drv/driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index 9443c66..358f088 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -740,7 +740,7 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP /* Printer supports colour printing - 1 if yes, 0 if no (Win2k/XP only) */ case DC_COLORDEVICE: - ret = (pi->ppd->ColorDevice != CD_False) ? TRUE : FALSE; + ret = pi->ppd->ColorDevice != CD_False; break; /* Identification number of the printer manufacturer for use with ICM (Win9x only) */

1 0

Michael Stefaniuc : explorerframe/tests: Avoid a TRUE: FALSE conditional expression.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: 25b0efa5bbd44f91ff7eab810bb866e150888136 URL: http://source.winehq.org/git/wine.git/?a=commit;h=25b0efa5bbd44f91ff7eab810… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:04:59 2012 +0200 explorerframe/tests: Avoid a TRUE:FALSE conditional expression. --- dlls/explorerframe/tests/nstc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/explorerframe/tests/nstc.c b/dlls/explorerframe/tests/nstc.c index 3ea408f..59654ac 100644 --- a/dlls/explorerframe/tests/nstc.c +++ b/dlls/explorerframe/tests/nstc.c @@ -558,7 +558,7 @@ static BOOL subclass_treeview(INameSpaceTreeControl *pnstc) ok(oldproc != NULL, "Failed to subclass.\n"); } - return oldproc?TRUE:FALSE; + return oldproc != 0; } static UINT get_msg_count(struct msg_sequence **seq, int sequence_index, UINT message)

1 0

Michael Stefaniuc : dbghelp: Remove a superfluous TRUE: FALSE conditional expression.
by Alexandre Julliard 15 Aug '12

15 Aug '12

Module: wine Branch: master Commit: 31fdb976328d5740d6bfd9b836f87d925350e4bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=31fdb976328d5740d6bfd9b83… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:08:03 2012 +0200 dbghelp: Remove a superfluous TRUE:FALSE conditional expression. --- dlls/dbghelp/module.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 136ec4e..6bea436 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -206,7 +206,7 @@ struct module* module_new(struct process* pcs, const WCHAR* name, module->reloc_delta = 0; module->type = type; - module->is_virtual = virtual ? TRUE : FALSE; + module->is_virtual = virtual; for (i = 0; i < DFI_LAST; i++) module->format_info[i] = NULL; module->sortlist_valid = FALSE; module->sorttab_size = 0;

1 0