October 2013 - Wine-commits

Hans Leidekker : iphlpapi: Set the mask for gateway entries in GetAdaptersInfo.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: a873fdc66f57b13490606a1abfb6131b72753899 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a873fdc66f57b13490606a1ab… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 7 12:24:17 2013 +0200 iphlpapi: Set the mask for gateway entries in GetAdaptersInfo. --- dlls/iphlpapi/iphlpapi_main.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index 9d23c82..141dbd8 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -564,8 +564,12 @@ DWORD WINAPI GetAdaptersInfo(PIP_ADAPTER_INFO pAdapterInfo, PULONG pOutBufLen) if (routeTable->table[i].dwForwardIfIndex == ptr->Index && routeTable->table[i].u1.ForwardType == MIB_IPROUTE_TYPE_INDIRECT) + { toIPAddressString(routeTable->table[i].dwForwardNextHop, ptr->GatewayList.IpAddress.String); + toIPAddressString(routeTable->table[i].dwForwardMask, + ptr->GatewayList.IpMask.String); + } if (winsEnabled) { ptr->HaveWins = TRUE; memcpy(ptr->PrimaryWinsServer.IpAddress.String,

1 0

Piotr Caban : msvcrt: Don' t try to demangle template after function or variable name.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: d13436e048894e0a57cfe5a7cc89100c48956d76 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d13436e048894e0a57cfe5a7c… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Oct 7 13:00:54 2013 +0200 msvcrt: Don't try to demangle template after function or variable name. --- dlls/msvcrt/undname.c | 19 ------------------- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c index 057d40a..dfcf2ab 100644 --- a/dlls/msvcrt/undname.c +++ b/dlls/msvcrt/undname.c @@ -1219,23 +1219,6 @@ done: return ret; } -/****************************************************************** - * handle_template - * Does the final parsing and handling for a name with templates - */ -static BOOL handle_template(struct parsed_symbol* sym) -{ - const char* name; - const char* args; - - assert(*sym->current == '$'); - sym->current++; - if (!(name = get_literal_string(sym))) return FALSE; - if (!(args = get_args(sym, NULL, FALSE, '<', '>'))) return FALSE; - sym->result = str_printf(sym, "%s%s", name, args); - return TRUE; -} - /******************************************************************* * symbol_demangle * Demangle a C++ linker symbol @@ -1469,8 +1452,6 @@ static BOOL symbol_demangle(struct parsed_symbol* sym) /* Function/Data type and access level */ if (*sym->current >= '0' && *sym->current <= '9') ret = handle_data(sym); - else if (sym->current[0] == '$' && (sym->current[1] < '0' || sym->current[1] > '9')) - ret = handle_template(sym); else if ((*sym->current >= 'A' && *sym->current <= 'Z') || *sym->current == '$') ret = handle_method(sym, do_after == 3); else ret = FALSE;

1 0

Piotr Caban : msvcrt: Add support for vcall thunks demangling.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: 501d60b020ee626f145dad601cd3fe8fa1f68eb8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=501d60b020ee626f145dad601… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Oct 7 13:01:10 2013 +0200 msvcrt: Add support for vcall thunks demangling. --- dlls/msvcrt/tests/cpp.c | 3 ++ dlls/msvcrt/undname.c | 93 ++++++++++++++++++++++++++--------------------- 2 files changed, 54 insertions(+), 42 deletions(-) diff --git a/dlls/msvcrt/tests/cpp.c b/dlls/msvcrt/tests/cpp.c index 92301ff..f36641e 100644 --- a/dlls/msvcrt/tests/cpp.c +++ b/dlls/msvcrt/tests/cpp.c @@ -1312,6 +1312,9 @@ static void test_demangle(void) /* 123 */ {"?vtordisp_thunk(a)std@@$4PPPPPPPM(a)3EAA_NXZ", "[thunk]:public: virtual bool __cdecl std::vtordisp_thunk`vtordisp{4294967292,4}' (void) __ptr64", "[thunk]:public: virtual bool __cdecl std::vtordisp_thunk`vtordisp{-4,4}' (void) __ptr64"}, +/* 124 */ {"??_9CView@@$BBII(a)AE", + "[thunk]: __thiscall CView::`vcall'{392,{flat}}' }'", + "[thunk]: __thiscall CView::`vcall'{392,{flat}}' "}, }; int i, num_test = (sizeof(test)/sizeof(test[0])); char* name; diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c index dfcf2ab..bc2a6fb 100644 --- a/dlls/msvcrt/undname.c +++ b/dlls/msvcrt/undname.c @@ -1067,6 +1067,7 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) { char accmem; const char* access = NULL; + int access_id = -1; const char* member_type = NULL; struct datatype_t ct_ret; const char* call_conv; @@ -1074,7 +1075,7 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) const char* exported; const char* args_str = NULL; const char* name = NULL; - BOOL ret = FALSE; + BOOL ret = FALSE, has_args = TRUE, has_ret = TRUE; unsigned mark; struct array array_pmt; @@ -1111,48 +1112,58 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) * "$3" protected: thunk vtordisp * "$4" public: thunk vtordisp * "$5" public: thunk vtordisp + * "$B" vcall thunk */ accmem = *sym->current++; if (accmem == '$') { - accmem = *sym->current++; - if (accmem < '0' || accmem > '5') goto done; + if (*sym->current >= '0' && *sym->current <= '5') + access_id = (*sym->current - '0') / 2; + else if (*sym->current != 'B') + goto done; } - else if (accmem < 'A' || accmem > 'Z') goto done; + else if (accmem >= 'A' && accmem <= 'Z') + access_id = (accmem - 'A') / 8; + else + goto done; - if (!(sym->flags & UNDNAME_NO_ACCESS_SPECIFIERS)) + switch (access_id) { - switch (accmem >= '0' && accmem <= '5' ? (accmem - '0') / 2 : (accmem - 'A') / 8) - { - case 0: access = "private: "; break; - case 1: access = "protected: "; break; - case 2: access = "public: "; break; - } + case 0: access = "private: "; break; + case 1: access = "protected: "; break; + case 2: access = "public: "; break; } - if (!(sym->flags & UNDNAME_NO_MEMBER_TYPE)) + if (accmem == '$' || (accmem - 'A') % 8 == 6 || (accmem - 'A') % 8 == 7) + access = str_printf(sym, "[thunk]:%s", access ? access : " "); + + if (accmem == '$' && *sym->current >= '0' && *sym->current <= '5') + member_type = "virtual "; + else if (accmem <= 'X') { - if (accmem >= '0' && accmem <= '5') + switch ((accmem - 'A') % 8) { - access = str_printf(sym, "[thunk]:%s", access); - member_type = "virtual "; - } - else if (accmem <= 'X') - { - switch ((accmem - 'A') % 8) - { - case 2: case 3: member_type = "static "; break; - case 4: case 5: member_type = "virtual "; break; - case 6: case 7: - access = str_printf(sym, "[thunk]:%s", access); - member_type = "virtual "; - break; - } + case 2: case 3: member_type = "static "; break; + case 4: case 5: case 6: case 7: member_type = "virtual "; break; } } + if (sym->flags & UNDNAME_NO_ACCESS_SPECIFIERS) + access = NULL; + if (sym->flags & UNDNAME_NO_MEMBER_TYPE) + member_type = NULL; + name = get_class_string(sym, 0); - if (accmem >= '0' && accmem <='5') /* vtordisp thunk */ + if (accmem == '$' && *sym->current++ == 'B') /* vcall thunk */ + { + const char *n = get_number(sym); + + if(!n || *sym->current++ != 'A') goto done; + name = str_printf(sym, "%s{%s,{flat}}' }'", name, n); + has_args = FALSE; + has_ret = FALSE; + } + else if (accmem == '$') /* vtordisp thunk */ { const char *n1 = get_number(sym); const char *n2 = get_number(sym); @@ -1163,16 +1174,14 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) else if ((accmem - 'A') % 8 == 6 || (accmem - 'A') % 8 == 7) /* a thunk */ name = str_printf(sym, "%s`adjustor{%s}' ", name, get_number(sym)); - if (accmem <= 'X') + if (has_args && (accmem == '$' || + (accmem <= 'X' && (accmem - 'A') % 8 != 2 && (accmem - 'A') % 8 != 3))) { - if (((accmem - 'A') % 8) != 2 && ((accmem - 'A') % 8) != 3) - { - const char *ptr_modif; - /* Implicit 'this' pointer */ - /* If there is an implicit this pointer, const modifier follows */ - if (!get_modifier(sym, &modifier, &ptr_modif)) goto done; - if (modifier || ptr_modif) modifier = str_printf(sym, "%s %s", modifier, ptr_modif); - } + const char *ptr_modif; + /* Implicit 'this' pointer */ + /* If there is an implicit this pointer, const modifier follows */ + if (!get_modifier(sym, &modifier, &ptr_modif)) goto done; + if (modifier || ptr_modif) modifier = str_printf(sym, "%s %s", modifier, ptr_modif); } if (!get_calling_convention(*sym->current++, &call_conv, &exported, @@ -1182,18 +1191,18 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) str_array_init(&array_pmt); /* Return type, or @ if 'void' */ - if (*sym->current == '@') + if (has_ret && *sym->current == '@') { ct_ret.left = "void"; ct_ret.right = NULL; sym->current++; } - else + else if (has_ret) { if (!demangle_datatype(sym, &ct_ret, &array_pmt, FALSE)) goto done; } - if (sym->flags & UNDNAME_NO_FUNCTION_RETURNS) + if (!has_ret || sym->flags & UNDNAME_NO_FUNCTION_RETURNS) ct_ret.left = ct_ret.right = NULL; if (cast_op) { @@ -1202,7 +1211,7 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) } mark = sym->stack.num; - if (!(args_str = get_args(sym, &array_pmt, TRUE, '(', ')'))) goto done; + if (has_args && !(args_str = get_args(sym, &array_pmt, TRUE, '(', ')'))) goto done; if (sym->flags & UNDNAME_NAME_ONLY) args_str = modifier = NULL; sym->stack.num = mark; @@ -1210,7 +1219,7 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) * Yet!!! FIXME */ sym->result = str_printf(sym, "%s%s%s%s%s%s%s%s%s%s%s", - access, member_type, ct_ret.left, + access, member_type, ct_ret.left, (ct_ret.left && !ct_ret.right) ? " " : NULL, call_conv, call_conv ? " " : NULL, exported, name, args_str, modifier, ct_ret.right);

1 0

Piotr Caban : msvcrt: Add support for vtordispex demangling.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: 0aa72d880a9d6a3a72252f4e0d75cab4608185dd URL: http://source.winehq.org/git/wine.git/?a=commit;h=0aa72d880a9d6a3a72252f4e0… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Oct 7 13:01:24 2013 +0200 msvcrt: Add support for vtordispex demangling. --- dlls/msvcrt/tests/cpp.c | 3 +++ dlls/msvcrt/undname.c | 32 +++++++++++++++++++++++++++----- 2 files changed, 30 insertions(+), 5 deletions(-) diff --git a/dlls/msvcrt/tests/cpp.c b/dlls/msvcrt/tests/cpp.c index f36641e..e545a5f 100644 --- a/dlls/msvcrt/tests/cpp.c +++ b/dlls/msvcrt/tests/cpp.c @@ -1315,6 +1315,9 @@ static void test_demangle(void) /* 124 */ {"??_9CView@@$BBII(a)AE", "[thunk]: __thiscall CView::`vcall'{392,{flat}}' }'", "[thunk]: __thiscall CView::`vcall'{392,{flat}}' "}, +/* 125 */ {"?_dispatch(a)_impl_Engine@SalomeApp@@$R4CE(a)BA@PPPPPPPM(a)7AE_NAAVomniCallHandle@@@Z", + "[thunk]:public: virtual bool __thiscall SalomeApp::_impl_Engine::_dispatch`vtordispex{36,16,4294967292,8}' (class omniCallHandle &)", + "?_dispatch(a)_impl_Engine@SalomeApp@@$R4CE(a)BA@PPPPPPPM(a)7AE_NAAVomniCallHandle@@@Z"}, }; int i, num_test = (sizeof(test)/sizeof(test[0])); char* name; diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c index bc2a6fb..396a003 100644 --- a/dlls/msvcrt/undname.c +++ b/dlls/msvcrt/undname.c @@ -1113,12 +1113,15 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) * "$4" public: thunk vtordisp * "$5" public: thunk vtordisp * "$B" vcall thunk + * "$R" thunk vtordispex */ accmem = *sym->current++; if (accmem == '$') { if (*sym->current >= '0' && *sym->current <= '5') access_id = (*sym->current - '0') / 2; + else if (*sym->current == 'R') + access_id = (sym->current[1] - '0') / 2; else if (*sym->current != 'B') goto done; } @@ -1136,7 +1139,7 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) if (accmem == '$' || (accmem - 'A') % 8 == 6 || (accmem - 'A') % 8 == 7) access = str_printf(sym, "[thunk]:%s", access ? access : " "); - if (accmem == '$' && *sym->current >= '0' && *sym->current <= '5') + if (accmem == '$' && *sym->current != 'B') member_type = "virtual "; else if (accmem <= 'X') { @@ -1154,19 +1157,38 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op) name = get_class_string(sym, 0); - if (accmem == '$' && *sym->current++ == 'B') /* vcall thunk */ + if (accmem == '$' && *sym->current == 'B') /* vcall thunk */ { - const char *n = get_number(sym); + const char *n; + + sym->current++; + n = get_number(sym); if(!n || *sym->current++ != 'A') goto done; name = str_printf(sym, "%s{%s,{flat}}' }'", name, n); has_args = FALSE; has_ret = FALSE; } + else if (accmem == '$' && *sym->current == 'R') /* vtordispex thunk */ + { + const char *n1, *n2, *n3, *n4; + + sym->current += 2; + n1 = get_number(sym); + n2 = get_number(sym); + n3 = get_number(sym); + n4 = get_number(sym); + + if(!n1 || !n2 || !n3 || !n4) goto done; + name = str_printf(sym, "%s`vtordispex{%s,%s,%s,%s}' ", name, n1, n2, n3, n4); + } else if (accmem == '$') /* vtordisp thunk */ { - const char *n1 = get_number(sym); - const char *n2 = get_number(sym); + const char *n1, *n2; + + sym->current++; + n1 = get_number(sym); + n2 = get_number(sym); if (!n1 || !n2) goto done; name = str_printf(sym, "%s`vtordisp{%s,%s}' ", name, n1, n2);

1 0

Piotr Caban : riched20: Set control content in WM_CREATE message.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: e660bf676c111ce20d9e868280094f1c5bb81c79 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e660bf676c111ce20d9e86828… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Oct 7 15:28:00 2013 +0200 riched20: Set control content in WM_CREATE message. --- dlls/riched20/editor.c | 24 ++++++++++++++++++++++++ dlls/riched20/tests/editor.c | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+), 0 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 42f5770..6e7ffae 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -3999,6 +3999,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, } case WM_CREATE: { + void *text = NULL; INT max; ME_SetDefaultFormatRect(editor); @@ -4024,6 +4025,29 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, } } + if (lParam) + { + text = (unicode ? (void*)((CREATESTRUCTW*)lParam)->lpszName + : (void*)((CREATESTRUCTA*)lParam)->lpszName); + } + if (text) + { + WCHAR *textW; + int len; + + textW = ME_ToUnicode(unicode, text, &len); + if (!(editor->styleFlags & ES_MULTILINE)) + { + len = 0; + while(textW[len] != '0' && textW[len] != '\r' && textW[len] != '\n') + len++; + } + ME_InsertTextFromCursor(editor, 0, textW, len, editor->pBuffer->pDefaultStyle); + ME_EndToUnicode(unicode, textW); + ME_SetCursorToStart(editor, &editor->pCursors[0]); + ME_SetCursorToStart(editor, &editor->pCursors[1]); + } + ME_CommitUndo(editor); ME_WrapMarkedParagraphs(editor); ME_MoveCaret(editor); diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c index 35684e6..4d9fde6 100644 --- a/dlls/riched20/tests/editor.c +++ b/dlls/riched20/tests/editor.c @@ -7410,6 +7410,43 @@ static void test_enter(void) DestroyWindow(hwndRichEdit); } +static void test_WM_CREATE(void) +{ + static const WCHAR titleW[] = {'l','i','n','e','1','\n','l','i','n','e','2',0}; + static const char title[] = "line1\nline2"; + + HWND rich_edit; + LRESULT res; + char buf[64]; + int len; + + rich_edit = CreateWindowA(RICHEDIT_CLASS20A, title, WS_POPUP|WS_VISIBLE, + 0, 0, 200, 80, NULL, NULL, NULL, NULL); + ok(rich_edit != NULL, "class: %s, error: %d\n", RICHEDIT_CLASS20A, (int) GetLastError()); + + len = GetWindowText(rich_edit, buf, sizeof(buf)); + ok(len == 5, "GetWindowText returned %d\n", len); + ok(!strcmp(buf, "line1"), "buf = %s\n", buf); + + res = SendMessage(rich_edit, EM_GETSEL, 0, 0); + ok(res == 0, "SendMessage(EM_GETSEL) returned %lx\n", res); + + DestroyWindow(rich_edit); + + rich_edit = CreateWindowW(RICHEDIT_CLASS20W, titleW, WS_POPUP|WS_VISIBLE|ES_MULTILINE, + 0, 0, 200, 80, NULL, NULL, NULL, NULL); + ok(rich_edit != NULL, "class: %s, error: %d\n", wine_dbgstr_w(RICHEDIT_CLASS20W), (int) GetLastError()); + + len = GetWindowText(rich_edit, buf, sizeof(buf)); + ok(len == 12, "GetWindowText returned %d\n", len); + ok(!strcmp(buf, "line1\r\nline2"), "buf = %s\n", buf); + + res = SendMessage(rich_edit, EM_GETSEL, 0, 0); + ok(res == 0, "SendMessage(EM_GETSEL) returned %lx\n", res); + + DestroyWindow(rich_edit); +} + START_TEST( editor ) { BOOL ret; @@ -7470,6 +7507,7 @@ START_TEST( editor ) test_EM_FINDWORDBREAK_W(); test_EM_FINDWORDBREAK_A(); test_enter(); + test_WM_CREATE(); /* Set the environment variable WINETEST_RICHED20 to keep windows * responsive and open for 30 seconds. This is useful for debugging.

1 0

Vincent Povirk : gdiplus: Properly set the gdi+ format to match the wic encoder's format.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: b14a4ca0064a675b7f0c86a22e7fc39238080fc8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b14a4ca0064a675b7f0c86a22… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Oct 4 14:30:48 2013 -0500 gdiplus: Properly set the gdi+ format to match the wic encoder's format. --- dlls/gdiplus/image.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 0f97fd7..2e9191e 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -4078,7 +4078,7 @@ static GpStatus encode_image_WIC(GpImage *image, IStream* stream, { if (IsEqualGUID(&wicformat, pixel_formats[i].wic_format)) { - gdipformat = bitmap->format; + gdipformat = pixel_formats[i].gdip_format; break; } }

1 0

Frédéric Delanoy : comdlg32/tests: Use BOOL type where appropriate.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: 2bbe7a330ca0a74af8393002557addb90fabdc00 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2bbe7a330ca0a74af83930025… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 23:32:11 2013 +0200 comdlg32/tests: Use BOOL type where appropriate. --- dlls/comdlg32/tests/filedlg.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comdlg32/tests/filedlg.c b/dlls/comdlg32/tests/filedlg.c index 9ae4e66..8e7dd27 100644 --- a/dlls/comdlg32/tests/filedlg.c +++ b/dlls/comdlg32/tests/filedlg.c @@ -28,7 +28,7 @@ /* ##### */ -static int resizesupported = TRUE; +static BOOL resizesupported = TRUE; static void toolbarcheck( HWND hDlg) {

1 0

Frédéric Delanoy : inetcomm: Use BOOL type where appropriate.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: da2a97fc0678029ed4a045703fbc787db2542d49 URL: http://source.winehq.org/git/wine.git/?a=commit;h=da2a97fc0678029ed4a045703… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 23:32:12 2013 +0200 inetcomm: Use BOOL type where appropriate. --- dlls/inetcomm/mimeole.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c index 38acd49..6a6cbd8 100644 --- a/dlls/inetcomm/mimeole.c +++ b/dlls/inetcomm/mimeole.c @@ -137,7 +137,7 @@ static HRESULT copy_headers_to_buf(IStream *stm, char **ptr) char *buf = NULL; DWORD size = PARSER_BUF_SIZE, offset = 0, last_end = 0; HRESULT hr; - int done = 0; + BOOL done = FALSE; *ptr = NULL; @@ -165,7 +165,7 @@ static HRESULT copy_headers_to_buf(IStream *stm, char **ptr) offset += read; buf[offset] = '\0'; - if(read == 0) done = 1; + if(read == 0) done = TRUE; while(!done && (end = strstr(buf + last_end, "\r\n"))) { @@ -176,7 +176,7 @@ static HRESULT copy_headers_to_buf(IStream *stm, char **ptr) off.QuadPart = new_end; IStream_Seek(stm, off, STREAM_SEEK_SET, NULL); buf[new_end] = '\0'; - done = 1; + done = TRUE; } else last_end = new_end; @@ -271,14 +271,14 @@ static void unfold_header(char *header, int len) static char *unquote_string(const char *str) { - int quoted = 0; + BOOL quoted = FALSE; char *ret, *cp; while(*str == ' ' || *str == '\t') str++; if(*str == '"') { - quoted = 1; + quoted = TRUE; str++; } ret = strdupA(str); @@ -334,20 +334,19 @@ static void add_param(header_t *header, const char *p) static void split_params(header_t *header, char *value) { char *cp = value, *start = value; - int in_quote = 0; - int done_value = 0; + BOOL in_quotes = FALSE, done_value = FALSE; while(*cp) { - if(!in_quote && *cp == ';') + if(!in_quotes && *cp == ';') { *cp = '\0'; if(done_value) add_param(header, start); - done_value = 1; + done_value = TRUE; start = cp + 1; } else if(*cp == '"') - in_quote = !in_quote; + in_quotes = !in_quotes; cp++; } if(done_value) add_param(header, start);

1 0

Frédéric Delanoy : rsaenh: Use BOOL type where appropriate.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: 7af5360c4e07b4f7820cc01740e45eb98c169839 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7af5360c4e07b4f7820cc0174… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 23:32:13 2013 +0200 rsaenh: Use BOOL type where appropriate. --- dlls/rsaenh/mpi.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/rsaenh/mpi.c b/dlls/rsaenh/mpi.c index 6662527..ff00d58 100644 --- a/dlls/rsaenh/mpi.c +++ b/dlls/rsaenh/mpi.c @@ -1745,17 +1745,17 @@ __Q:mp_clear (&q); return res; } -static int s_is_power_of_two(mp_digit b, int *p) +static BOOL s_is_power_of_two(mp_digit b, int *p) { int x; for (x = 1; x < DIGIT_BIT; x++) { if (b == (((mp_digit)1)<<x)) { *p = x; - return 1; + return TRUE; } } - return 0; + return FALSE; } /* single digit division (based on routine from MPI) */

1 0

Frédéric Delanoy : mlang: Use BOOL type where appropriate.
by Alexandre Julliard 07 Oct '13

07 Oct '13

Module: wine Branch: master Commit: 2042a6598c264e6994f3c4824d5db665814a8a2a URL: http://source.winehq.org/git/wine.git/?a=commit;h=2042a6598c264e6994f3c4824… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 23:32:14 2013 +0200 mlang: Use BOOL type where appropriate. --- dlls/mlang/mlang.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/mlang/mlang.c b/dlls/mlang/mlang.c index d28f811..96ccbf7 100644 --- a/dlls/mlang/mlang.c +++ b/dlls/mlang/mlang.c @@ -574,8 +574,8 @@ static inline void sjis2jis(unsigned char *p1, unsigned char *p2) static int han2zen(unsigned char *p1, unsigned char *p2) { - int maru = FALSE; - int nigori = FALSE; + BOOL maru = FALSE; + BOOL nigori = FALSE; static const unsigned char char1[] = {129,129,129,129,129,131,131,131,131, 131,131,131,131,131,131,129,131,131,131,131,131,131,131,131,131,131, 131,131,131,131,131,131,131,131,131,131,131,131,131,131,131,131,131, @@ -622,7 +622,7 @@ static UINT ConvertJIS2SJIS(LPCSTR input, DWORD count, LPSTR output) DWORD i = 0; int j = 0; unsigned char p2,p; - int shifted = FALSE; + BOOL shifted = FALSE; while (i < count) { @@ -690,7 +690,7 @@ static UINT ConvertSJIS2JIS(LPCSTR input, DWORD count, LPSTR output) DWORD i = 0; int j = 0; unsigned char p2,p; - int shifted = FALSE; + BOOL shifted = FALSE; while (i < count) {

1 0