October 2013 - Wine-commits

Henri Verbeet : wined3d: Send geometry shader binding updates through the command stream.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 819e9dda28abb33a09b9ffcf0a23760539e2f3a5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=819e9dda28abb33a09b9ffcf0… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Oct 3 23:31:45 2013 +0200 wined3d: Send geometry shader binding updates through the command stream. --- dlls/wined3d/cs.c | 21 +++++++++++++++++++++ dlls/wined3d/device.c | 11 ++++------- dlls/wined3d/wined3d_private.h | 1 + 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/dlls/wined3d/cs.c b/dlls/wined3d/cs.c index 44a8285d..e49ce3a 100644 --- a/dlls/wined3d/cs.c +++ b/dlls/wined3d/cs.c @@ -39,6 +39,7 @@ enum wined3d_cs_op WINED3D_CS_OP_SET_INDEX_BUFFER, WINED3D_CS_OP_SET_TEXTURE, WINED3D_CS_OP_SET_VERTEX_SHADER, + WINED3D_CS_OP_SET_GEOMETRY_SHADER, }; struct wined3d_cs_present @@ -531,6 +532,25 @@ void wined3d_cs_emit_set_vertex_shader(struct wined3d_cs *cs, struct wined3d_sha cs->ops->submit(cs); } +static void wined3d_cs_exec_set_geometry_shader(struct wined3d_cs *cs, const void *data) +{ + const struct wined3d_cs_set_shader *op = data; + + cs->state.geometry_shader = op->shader; + device_invalidate_state(cs->device, STATE_GEOMETRY_SHADER); +} + +void wined3d_cs_emit_set_geometry_shader(struct wined3d_cs *cs, struct wined3d_shader *shader) +{ + struct wined3d_cs_set_shader *op; + + op = cs->ops->require_space(cs, sizeof(*op)); + op->opcode = WINED3D_CS_OP_SET_GEOMETRY_SHADER; + op->shader = shader; + + cs->ops->submit(cs); +} + static void (* const wined3d_cs_op_handlers[])(struct wined3d_cs *cs, const void *data) = { /* WINED3D_CS_OP_PRESENT */ wined3d_cs_exec_present, @@ -546,6 +566,7 @@ static void (* const wined3d_cs_op_handlers[])(struct wined3d_cs *cs, const void /* WINED3D_CS_OP_SET_INDEX_BUFFER */ wined3d_cs_exec_set_index_buffer, /* WINED3D_CS_OP_SET_TEXTURE */ wined3d_cs_exec_set_texture, /* WINED3D_CS_OP_SET_VERTEX_SHADER */ wined3d_cs_exec_set_vertex_shader, + /* WINED3D_CS_OP_SET_GEOMETRY_SHADER */ wined3d_cs_exec_set_geometry_shader, }; static void *wined3d_cs_st_require_space(struct wined3d_cs *cs, size_t size) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 77bd452..b2f10cf 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2611,17 +2611,14 @@ void CDECL wined3d_device_set_geometry_shader(struct wined3d_device *device, str TRACE("device %p, shader %p.\n", device, shader); + if (device->recording || shader == prev) + return; if (shader) wined3d_shader_incref(shader); + device->update_state->geometry_shader = shader; + wined3d_cs_emit_set_geometry_shader(device->cs, shader); if (prev) wined3d_shader_decref(prev); - - device->update_state->geometry_shader = shader; - - if (device->recording || shader == prev) - return; - - device_invalidate_state(device, STATE_GEOMETRY_SHADER); } struct wined3d_shader * CDECL wined3d_device_get_geometry_shader(const struct wined3d_device *device) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 13a3aa2..545c8d3 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2487,6 +2487,7 @@ void wined3d_cs_emit_present(struct wined3d_cs *cs, struct wined3d_swapchain *sw const RECT *src_rect, const RECT *dst_rect, HWND dst_window_override, const RGNDATA *dirty_region, DWORD flags) DECLSPEC_HIDDEN; void wined3d_cs_emit_set_depth_stencil(struct wined3d_cs *cs, struct wined3d_surface *depth_stencil) DECLSPEC_HIDDEN; +void wined3d_cs_emit_set_geometry_shader(struct wined3d_cs *cs, struct wined3d_shader *shader) DECLSPEC_HIDDEN; void wined3d_cs_emit_set_index_buffer(struct wined3d_cs *cs, struct wined3d_buffer *buffer, enum wined3d_format_id format_id) DECLSPEC_HIDDEN; void wined3d_cs_emit_set_render_target(struct wined3d_cs *cs, UINT render_target_idx,

1 0

Henri Verbeet : wined3d: Send pixel shader binding updates through the command stream.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 82cf8b2066f1e1eef1603fa35895c29570b0f0ae URL: http://source.winehq.org/git/wine.git/?a=commit;h=82cf8b2066f1e1eef1603fa35… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Oct 3 23:31:46 2013 +0200 wined3d: Send pixel shader binding updates through the command stream. --- dlls/wined3d/cs.c | 21 +++++++++++++++++++++ dlls/wined3d/device.c | 22 +++++++--------------- dlls/wined3d/wined3d_private.h | 1 + 3 files changed, 29 insertions(+), 15 deletions(-) diff --git a/dlls/wined3d/cs.c b/dlls/wined3d/cs.c index e49ce3a..7f54ac9 100644 --- a/dlls/wined3d/cs.c +++ b/dlls/wined3d/cs.c @@ -40,6 +40,7 @@ enum wined3d_cs_op WINED3D_CS_OP_SET_TEXTURE, WINED3D_CS_OP_SET_VERTEX_SHADER, WINED3D_CS_OP_SET_GEOMETRY_SHADER, + WINED3D_CS_OP_SET_PIXEL_SHADER, }; struct wined3d_cs_present @@ -551,6 +552,25 @@ void wined3d_cs_emit_set_geometry_shader(struct wined3d_cs *cs, struct wined3d_s cs->ops->submit(cs); } +static void wined3d_cs_exec_set_pixel_shader(struct wined3d_cs *cs, const void *data) +{ + const struct wined3d_cs_set_shader *op = data; + + cs->state.pixel_shader = op->shader; + device_invalidate_state(cs->device, STATE_PIXELSHADER); +} + +void wined3d_cs_emit_set_pixel_shader(struct wined3d_cs *cs, struct wined3d_shader *shader) +{ + struct wined3d_cs_set_shader *op; + + op = cs->ops->require_space(cs, sizeof(*op)); + op->opcode = WINED3D_CS_OP_SET_PIXEL_SHADER; + op->shader = shader; + + cs->ops->submit(cs); +} + static void (* const wined3d_cs_op_handlers[])(struct wined3d_cs *cs, const void *data) = { /* WINED3D_CS_OP_PRESENT */ wined3d_cs_exec_present, @@ -567,6 +587,7 @@ static void (* const wined3d_cs_op_handlers[])(struct wined3d_cs *cs, const void /* WINED3D_CS_OP_SET_TEXTURE */ wined3d_cs_exec_set_texture, /* WINED3D_CS_OP_SET_VERTEX_SHADER */ wined3d_cs_exec_set_vertex_shader, /* WINED3D_CS_OP_SET_GEOMETRY_SHADER */ wined3d_cs_exec_set_geometry_shader, + /* WINED3D_CS_OP_SET_PIXEL_SHADER */ wined3d_cs_exec_set_pixel_shader, }; static void *wined3d_cs_st_require_space(struct wined3d_cs *cs, size_t size) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index b2f10cf..49f39d7 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2345,27 +2345,19 @@ void CDECL wined3d_device_set_pixel_shader(struct wined3d_device *device, struct TRACE("device %p, shader %p.\n", device, shader); - if (shader) - wined3d_shader_incref(shader); - if (prev) - wined3d_shader_decref(prev); - - device->update_state->pixel_shader = shader; - if (device->recording) - { - TRACE("Recording... not performing anything.\n"); device->recording->changed.pixelShader = TRUE; - return; - } if (shader == prev) - { - TRACE("Application is setting the old shader over, nothing to do.\n"); return; - } - device_invalidate_state(device, STATE_PIXELSHADER); + if (shader) + wined3d_shader_incref(shader); + device->update_state->pixel_shader = shader; + if (!device->recording) + wined3d_cs_emit_set_pixel_shader(device->cs, shader); + if (prev) + wined3d_shader_decref(prev); } struct wined3d_shader * CDECL wined3d_device_get_pixel_shader(const struct wined3d_device *device) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 545c8d3..a1112ef 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2490,6 +2490,7 @@ void wined3d_cs_emit_set_depth_stencil(struct wined3d_cs *cs, struct wined3d_sur void wined3d_cs_emit_set_geometry_shader(struct wined3d_cs *cs, struct wined3d_shader *shader) DECLSPEC_HIDDEN; void wined3d_cs_emit_set_index_buffer(struct wined3d_cs *cs, struct wined3d_buffer *buffer, enum wined3d_format_id format_id) DECLSPEC_HIDDEN; +void wined3d_cs_emit_set_pixel_shader(struct wined3d_cs *cs, struct wined3d_shader *shader) DECLSPEC_HIDDEN; void wined3d_cs_emit_set_render_target(struct wined3d_cs *cs, UINT render_target_idx, struct wined3d_surface *render_target) DECLSPEC_HIDDEN; void wined3d_cs_emit_set_scissor_rect(struct wined3d_cs *cs, const RECT *rect) DECLSPEC_HIDDEN;

1 0

Henri Verbeet : d3dcompiler: Get rid of the BWRITERDECLUSAGE typedef.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: cc3cde5124bd4ebdced8ae2c849cf71db4adda57 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cc3cde5124bd4ebdced8ae2c8… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Oct 3 23:31:47 2013 +0200 d3dcompiler: Get rid of the BWRITERDECLUSAGE typedef. --- dlls/d3dcompiler_43/d3dcompiler_private.h | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/d3dcompiler_43/d3dcompiler_private.h b/dlls/d3dcompiler_43/d3dcompiler_private.h index 7900858..1be52bc 100644 --- a/dlls/d3dcompiler_43/d3dcompiler_private.h +++ b/dlls/d3dcompiler_43/d3dcompiler_private.h @@ -568,7 +568,8 @@ enum bwritershader_param_srcmod_type #define BWRITERVS_SWIZZLE_Z (BWRITERVS_X_Z | BWRITERVS_Y_Z | BWRITERVS_Z_Z | BWRITERVS_W_Z) #define BWRITERVS_SWIZZLE_W (BWRITERVS_X_W | BWRITERVS_Y_W | BWRITERVS_Z_W | BWRITERVS_W_W) -typedef enum _BWRITERDECLUSAGE { +enum bwriterdeclusage +{ BWRITERDECLUSAGE_POSITION, BWRITERDECLUSAGE_BLENDWEIGHT, BWRITERDECLUSAGE_BLENDINDICES, @@ -583,7 +584,7 @@ typedef enum _BWRITERDECLUSAGE { BWRITERDECLUSAGE_FOG, BWRITERDECLUSAGE_DEPTH, BWRITERDECLUSAGE_SAMPLE -} BWRITERDECLUSAGE; +}; /* ps 1.x texture registers mappings */ #define T0_REG 2

1 0

Henri Verbeet : d3drm: Get rid of the Header typedef.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 13e3219c2f5df4efbd035bc1466a254ef5d2d95e URL: http://source.winehq.org/git/wine.git/?a=commit;h=13e3219c2f5df4efbd035bc14… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Oct 3 23:31:48 2013 +0200 d3drm: Get rid of the Header typedef. --- dlls/d3drm/d3drm.c | 10 +++++----- dlls/d3drm/d3drm_private.h | 5 +++-- dlls/d3drm/meshbuilder.c | 9 +++++---- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c index e1aa368..0ab62de 100644 --- a/dlls/d3drm/d3drm.c +++ b/dlls/d3drm/d3drm.c @@ -1326,7 +1326,7 @@ static HRESULT WINAPI IDirect3DRM3Impl_Load(IDirect3DRM3 *iface, void *source, v HRESULT hr; const GUID* pGuid; DWORD size; - Header* pHeader; + struct d3drm_file_header *header; HRESULT ret = D3DRMERR_BADOBJECT; DWORD i; @@ -1382,14 +1382,14 @@ static HRESULT WINAPI IDirect3DRM3Impl_Load(IDirect3DRM3 *iface, void *source, v goto end; } - hr = IDirectXFileData_GetData(data, NULL, &size, (void **)&pHeader); - if ((hr != DXFILE_OK) || (size != sizeof(Header))) + hr = IDirectXFileData_GetData(data, NULL, &size, (void **)&header); + if ((hr != DXFILE_OK) || (size != sizeof(*header))) goto end; - TRACE("Version is %d %d %d\n", pHeader->major, pHeader->minor, pHeader->flags); + TRACE("Version is %u.%u, flags %#x.\n", header->major, header->minor, header->flags); /* Version must be 1.0.x */ - if ((pHeader->major != 1) || (pHeader->minor != 0)) + if ((header->major != 1) || (header->minor != 0)) { ret = D3DRMERR_BADFILE; goto end; diff --git a/dlls/d3drm/d3drm_private.h b/dlls/d3drm/d3drm_private.h index d1f30be..3daf96a 100644 --- a/dlls/d3drm/d3drm_private.h +++ b/dlls/d3drm/d3drm_private.h @@ -37,11 +37,12 @@ HRESULT Direct3DRMTexture_create(REFIID riid, IUnknown** ret_iface) DECLSPEC_HID HRESULT load_mesh_data(IDirect3DRMMeshBuilder3 *iface, IDirectXFileData *data, D3DRMLOADTEXTURECALLBACK load_texture_proc, void *arg) DECLSPEC_HIDDEN; -typedef struct { +struct d3drm_file_header +{ WORD major; WORD minor; DWORD flags; -} Header; +}; extern char templates[]; diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c index c198531..0262284 100644 --- a/dlls/d3drm/meshbuilder.c +++ b/dlls/d3drm/meshbuilder.c @@ -1521,11 +1521,12 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_Load(IDirect3DRMMeshBuilder3* IDirectXFileData *data = NULL; const GUID* guid; DWORD size; - Header* header; + struct d3drm_file_header *header; HRESULT hr; HRESULT ret = D3DRMERR_BADOBJECT; - TRACE("(%p)->(%p,%p,%x,%p,%p)\n", This, filename, name, loadflags, cb, arg); + TRACE("iface %p, filename %p, name %p, loadflags %#x, cb %p, arg %p.\n", + iface, filename, name, loadflags, cb, arg); clean_mesh_builder_data(This); @@ -1573,10 +1574,10 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_Load(IDirect3DRMMeshBuilder3* } hr = IDirectXFileData_GetData(data, NULL, &size, (void**)&header); - if ((hr != DXFILE_OK) || (size != sizeof(Header))) + if ((hr != DXFILE_OK) || (size != sizeof(*header))) goto end; - TRACE("Version is %d %d %d\n", header->major, header->minor, header->flags); + TRACE("Version is %u.%u, flags %#x.\n", header->major, header->minor, header->flags); /* Version must be 1.0.x */ if ((header->major != 1) || (header->minor != 0))

1 0

Ken Thomases : winemac: Allow zero-sized windows to be selected from the Mac Window menu.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 63fe00eae7b3388d10a98ed0e99718fcbcb2905c URL: http://source.winehq.org/git/wine.git/?a=commit;h=63fe00eae7b3388d10a98ed0e… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Oct 4 00:17:17 2013 -0500 winemac: Allow zero-sized windows to be selected from the Mac Window menu. They show up in the taskbar on Windows 7. Selecting them from there is meaningful and useful, as is selecting them from the Window menu. In addition to just switching among windows from that menu, this is also important to recovering a minimized window if the user has configured their system preferences to minimize windows into the process's dock icon (rather than as separate dock icons). --- dlls/winemac.drv/window.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c index 98d8695..2c71a1e 100644 --- a/dlls/winemac.drv/window.c +++ b/dlls/winemac.drv/window.c @@ -89,13 +89,11 @@ static void get_cocoa_window_features(struct macdrv_win_data *data, static inline BOOL can_activate_window(HWND hwnd) { LONG style = GetWindowLongW(hwnd, GWL_STYLE); - RECT rect; if (!(style & WS_VISIBLE)) return FALSE; if ((style & (WS_POPUP|WS_CHILD)) == WS_CHILD) return FALSE; if (GetWindowLongW(hwnd, GWL_EXSTYLE) & WS_EX_NOACTIVATE) return FALSE; if (hwnd == GetDesktopWindow()) return FALSE; - if (GetWindowRect(hwnd, &rect) && IsRectEmpty(&rect)) return FALSE; return !(style & WS_DISABLED); } @@ -112,9 +110,10 @@ static void get_cocoa_window_state(struct macdrv_win_data *data, state->no_activate = !can_activate_window(data->hwnd); state->floating = (ex_style & WS_EX_TOPMOST) != 0; state->excluded_by_expose = state->excluded_by_cycle = - IsRectEmpty(&data->window_rect) || (!(ex_style & WS_EX_APPWINDOW) && (GetWindow(data->hwnd, GW_OWNER) || (ex_style & (WS_EX_TOOLWINDOW | WS_EX_NOACTIVATE)))); + if (IsRectEmpty(&data->window_rect)) + state->excluded_by_expose = TRUE; state->minimized = (style & WS_MINIMIZE) != 0; }

1 0

Ken Thomases : winemac: Make clicking on the app' s dock icon unminimize a window if there are only minimized windows.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 1186c36c89c74066d127ca52512c1196b1802ec9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1186c36c89c74066d127ca525… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Oct 4 00:17:24 2013 -0500 winemac: Make clicking on the app's dock icon unminimize a window if there are only minimized windows. Cocoa would automatically do this for a normal app. However, the Mac driver makes all of its windows inherit from NSPanel and Cocoa ignores panels for this feature. --- dlls/winemac.drv/cocoa_app.m | 36 +++++++++++++++++++++++++----------- 1 files changed, 25 insertions(+), 11 deletions(-) diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m index 632a1bb..9d33e7f 100644 --- a/dlls/winemac.drv/cocoa_app.m +++ b/dlls/winemac.drv/cocoa_app.m @@ -1915,6 +1915,21 @@ int macdrv_err_on; } } + - (void) unminimizeWindowIfNoneVisible + { + if (![self frontWineWindow]) + { + for (WineWindow* window in [NSApp windows]) + { + if ([window isKindOfClass:[WineWindow class]] && [window isMiniaturized]) + { + [window deminiaturize:self]; + break; + } + } + } + } + /* * ---------- NSApplicationDelegate methods ---------- @@ -1935,17 +1950,8 @@ int macdrv_err_on; [self updateFullscreenWindows]; [self adjustWindowLevels:YES]; - if (beenActive && ![self frontWineWindow]) - { - for (WineWindow* window in [NSApp windows]) - { - if ([window isKindOfClass:[WineWindow class]] && [window isMiniaturized]) - { - [window deminiaturize:self]; - break; - } - } - } + if (beenActive) + [self unminimizeWindowIfNoneVisible]; beenActive = TRUE; // If a Wine process terminates abruptly while it has the display captured @@ -1997,6 +2003,14 @@ int macdrv_err_on; [self releaseMouseCapture]; } + - (BOOL) applicationShouldHandleReopen:(NSApplication*)theApplication hasVisibleWindows:(BOOL)flag + { + // Note that "flag" is often wrong. WineWindows are NSPanels and NSPanels + // don't count as "visible windows" for this purpose. + [self unminimizeWindowIfNoneVisible]; + return YES; + } + - (NSApplicationTerminateReply) applicationShouldTerminate:(NSApplication *)sender { NSApplicationTerminateReply ret = NSTerminateNow;

1 0

Frédéric Delanoy : advapi32: Use BOOL type where appropriate.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 6b6495e3cafc402bdf1231f6975966c0816366d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6b6495e3cafc402bdf1231f69… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 11:43:20 2013 +0200 advapi32: Use BOOL type where appropriate. --- dlls/advapi32/registry.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c index e999ce6..11e7500 100644 --- a/dlls/advapi32/registry.c +++ b/dlls/advapi32/registry.c @@ -82,13 +82,13 @@ static BOOL hkcu_cache_disabled; static const BOOL is_win64 = (sizeof(void *) > sizeof(int)); /* check if value type needs string conversion (Ansi<->Unicode) */ -static inline int is_string( DWORD type ) +static inline BOOL is_string( DWORD type ) { return (type == REG_SZ) || (type == REG_EXPAND_SZ) || (type == REG_MULTI_SZ); } /* check if current version is NT or Win95 */ -static inline int is_version_nt(void) +static inline BOOL is_version_nt(void) { return !(GetVersion() & 0x80000000); }

1 0

Frédéric Delanoy : comctl32: Use BOOL type where appropriate.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: cf8efbd252d761551f3c0b91346c11d0ae1a59d5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cf8efbd252d761551f3c0b913… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 11:43:21 2013 +0200 comctl32: Use BOOL type where appropriate. --- dlls/comctl32/imagelist.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c index ec8d08a..6461df6 100644 --- a/dlls/comctl32/imagelist.c +++ b/dlls/comctl32/imagelist.c @@ -209,7 +209,7 @@ static void add_dib_bits( HIMAGELIST himl, int pos, int count, int width, int he for (n = 0; n < count; n++) { - int has_alpha = 0; + BOOL has_alpha = FALSE; imagelist_point_from_index( himl, pos + n, &pt );

1 0

Frédéric Delanoy : dbghelp: Use BOOL type where appropriate.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: c00219769275c7aeb8db341c9dcc1a566335d11f URL: http://source.winehq.org/git/wine.git/?a=commit;h=c00219769275c7aeb8db341c9… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 11:43:22 2013 +0200 dbghelp: Use BOOL type where appropriate. --- dlls/dbghelp/module.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 521cdb3f..38d4a58 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -105,7 +105,7 @@ void module_set_module(struct module* module, const WCHAR* name) const WCHAR *get_wine_loader_name(void) { - static const int is_win64 = sizeof(void *) > sizeof(int); /* FIXME: should depend on target process */ + static const BOOL is_win64 = sizeof(void *) > sizeof(int); /* FIXME: should depend on target process */ static const WCHAR wineW[] = {'w','i','n','e',0}; static const WCHAR suffixW[] = {'6','4',0}; static const WCHAR *loader;

1 0

Frédéric Delanoy : dinput: Use BOOL type where appropriate.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Module: wine Branch: master Commit: 25f3356906239efce1e482d9738a2dd3fe2074ed URL: http://source.winehq.org/git/wine.git/?a=commit;h=25f3356906239efce1e482d97… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 4 11:43:23 2013 +0200 dinput: Use BOOL type where appropriate. --- dlls/dinput/device.c | 6 +++--- dlls/dinput/joystick.c | 4 ++-- dlls/dinput/joystick_linuxinput.c | 4 ++-- dlls/dinput/joystick_osx.c | 9 +++++---- 4 files changed, 12 insertions(+), 11 deletions(-) diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index 2ca26fb..fc5ad5d 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -719,8 +719,8 @@ HRESULT _build_action_map(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, IDirectInputDeviceImpl *This = impl_from_IDirectInputDevice8W(iface); WCHAR username[MAX_PATH]; DWORD username_size = MAX_PATH; - int i, has_actions = 0; - BOOL load_success = FALSE; + int i; + BOOL load_success = FALSE, has_actions = FALSE; /* Unless asked the contrary by these flags, try to load a previous mapping */ if (!(dwFlags & DIDBAM_HWDEFAULTS)) @@ -760,7 +760,7 @@ HRESULT _build_action_map(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, lpdiaf->rgoAction[i].dwObjID = obj_id; lpdiaf->rgoAction[i].guidInstance = This->guid; lpdiaf->rgoAction[i].dwHow = DIAH_DEFAULT; - has_actions = 1; + has_actions = TRUE; } } else if (!(dwFlags & DIDBAM_PRESERVE)) diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c index ce267e6..4eddd89 100644 --- a/dlls/dinput/joystick.c +++ b/dlls/dinput/joystick.c @@ -708,7 +708,7 @@ HRESULT WINAPI JoystickWGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8W iface, { JoystickGenericImpl *This = impl_from_IDirectInputDevice8W(iface); unsigned int i, j; - int has_actions = 0; + BOOL has_actions = FALSE; DWORD object_types[] = { DIDFT_AXIS, DIDFT_BUTTON }; DWORD type_map[] = { DIDFT_RELAXIS, DIDFT_PSHBUTTON }; @@ -739,7 +739,7 @@ HRESULT WINAPI JoystickWGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8W iface, lpdiaf->rgoAction[i].guidInstance = This->base.guid; lpdiaf->rgoAction[i].dwHow = DIAH_DEFAULT; - has_actions = 1; + has_actions = TRUE; /* No need to try other types if the action was already mapped */ break; diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c index 5d1cacc..559f181 100644 --- a/dlls/dinput/joystick_linuxinput.c +++ b/dlls/dinput/joystick_linuxinput.c @@ -97,7 +97,7 @@ struct JoyDev { char *name; GUID guid; - int has_ff; + BOOL has_ff; int num_effects; /* data returned by EVIOCGBIT for caps, EV_ABS, EV_KEY, and EV_FF */ @@ -275,7 +275,7 @@ static void find_joydevs(void) joydev.num_effects > 0) { TRACE(" ... with force feedback\n"); - joydev.has_ff = 1; + joydev.has_ff = TRUE; } #endif diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c index 66b020e..622b054 100644 --- a/dlls/dinput/joystick_osx.c +++ b/dlls/dinput/joystick_osx.c @@ -841,13 +841,13 @@ static const char *osx_ff_axis_name(UInt8 axis) return ret; } -static int osx_axis_has_ff(FFCAPABILITIES *ffcaps, UInt8 axis) +static BOOL osx_axis_has_ff(FFCAPABILITIES *ffcaps, UInt8 axis) { int i; for(i = 0; i < ffcaps->numFfAxes; ++i) if(ffcaps->ffAxes[i] == axis) - return 1; - return 0; + return TRUE; + return FALSE; } static HRESULT alloc_device(REFGUID rguid, IDirectInputImpl *dinput, @@ -948,7 +948,8 @@ static HRESULT alloc_device(REFGUID rguid, IDirectInputImpl *dinput, for (i = 0; i < newDevice->generic.devcaps.dwAxes; i++) { - int wine_obj = -1, has_ff = 0; + int wine_obj = -1; + BOOL has_ff = FALSE; switch (axis_map[i]) { case kHIDUsage_GD_X:

1 0