August 2013 - Wine-commits - list.winehq.org

Vincent Povirk : gdiplus: Copy custom dashes in GdipClonePen.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: 2c3142f0ee4a5fa3aff658b9b46a9f91aea030d4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2c3142f0ee4a5fa3aff658b9b… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Aug 14 16:35:11 2013 -0500 gdiplus: Copy custom dashes in GdipClonePen. --- dlls/gdiplus/pen.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/pen.c b/dlls/gdiplus/pen.c index 80ede40..9b63db9 100644 --- a/dlls/gdiplus/pen.c +++ b/dlls/gdiplus/pen.c @@ -102,6 +102,7 @@ GpStatus WINGDIPAPI GdipClonePen(GpPen *pen, GpPen **clonepen) (*clonepen)->customstart = NULL; (*clonepen)->customend = NULL; (*clonepen)->brush = NULL; + (*clonepen)->dashes = NULL; stat = GdipCloneBrush(pen->brush, &(*clonepen)->brush); @@ -111,6 +112,15 @@ GpStatus WINGDIPAPI GdipClonePen(GpPen *pen, GpPen **clonepen) if (stat == Ok && pen->customend) stat = GdipCloneCustomLineCap(pen->customend, &(*clonepen)->customend); + if (stat == Ok && pen->dashes) + { + (*clonepen)->dashes = GdipAlloc(pen->numdashes * sizeof(REAL)); + if ((*clonepen)->dashes) + memcpy((*clonepen)->dashes, pen->dashes, pen->numdashes * sizeof(REAL)); + else + stat = OutOfMemory; + } + if (stat != Ok) { GdipDeletePen(*clonepen);

1 0

Charles Davis : configure: Use a real header guard for config.h.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: 7fcb736d511084bff60e73e4e803ef3b5590594b URL: http://source.winehq.org/git/wine.git/?a=commit;h=7fcb736d511084bff60e73e4e… Author: Charles Davis <cdavis5x(a)gmail.com> Date: Mon Aug 12 15:07:06 2013 -0600 configure: Use a real header guard for config.h. --- configure.ac | 8 +++++--- include/config.h.in | 4 +++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index ca3d038..07ee2f0 100644 --- a/configure.ac +++ b/configure.ac @@ -2527,9 +2527,11 @@ esac dnl **** Generate output files **** -AH_TOP([#ifndef WINE_CROSSTEST -#define __WINE_CONFIG_H]) -AH_BOTTOM([#endif /* WINE_CROSSTEST */]) +AH_TOP([#ifndef __WINE_CONFIG_H +#define __WINE_CONFIG_H +#ifndef WINE_CROSSTEST]) +AH_BOTTOM([#endif /* WINE_CROSSTEST */ +#endif /* __WINE_CONFIG_H */]) AC_CONFIG_COMMANDS([include/stamp-h], [echo timestamp > include/stamp-h]) diff --git a/include/config.h.in b/include/config.h.in index e7b1898..014c78a 100644 --- a/include/config.h.in +++ b/include/config.h.in @@ -1,7 +1,8 @@ /* include/config.h.in. Generated from configure.ac by autoheader. */ -#ifndef WINE_CROSSTEST +#ifndef __WINE_CONFIG_H #define __WINE_CONFIG_H +#ifndef WINE_CROSSTEST /* Define to a function attribute for Microsoft hotpatch assembly prefix. */ #undef DECLSPEC_HOTPATCH @@ -1366,3 +1367,4 @@ #endif #endif /* WINE_CROSSTEST */ +#endif /* __WINE_CONFIG_H */

1 0

Dmitry Timoshkov : kernel32/tests: Fix some typos.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: ab7dac6886c2946848635185b4903f7d5ee28ab6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab7dac6886c2946848635185b… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 15 16:37:28 2013 +0900 kernel32/tests: Fix some typos. --- dlls/kernel32/tests/comm.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index bdc1cc1..e9a8690 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -682,7 +682,7 @@ static HANDLE test_OpenComm(BOOL doOverlap) if(!shown) { if (hcom == INVALID_HANDLE_VALUE) - trace("Could not find a valid COM port. Skipping test_ReadTimeOut\n"); + trace("Could not find a valid COM port.\n"); else trace("Found Com port %s. Connected devices may disturb results\n", port_name); /*shown = TRUE; */ @@ -1126,7 +1126,7 @@ static void test_WaitRx(HANDLE hcom) after = GetTickCount(); trace("Success 0x%08x err %d evtmask 0x%08x\n", success_wait, err_wait, evtmask); ok(success_wait || err_wait == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); success_write= WriteFile(hcom, "X", 1, &written, &overlapped_w); err_write = GetLastError(); @@ -1242,7 +1242,7 @@ static void test_WaitCts(HANDLE hcom) trace("Success 0x%08x err %d evtmask 0x%08x\n", success, err, evtmask); ok(success || err == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); if (!success && (err == ERROR_IO_PENDING)) ok(WaitForSingleObjectEx(hComPortEvent, TIMEOUT, TRUE) == 0, "WaitCts hComPortEvent failed\n"); @@ -1330,7 +1330,7 @@ static void test_AbortWaitCts(HANDLE hcom) trace("Success 0x%08x err %d evtmask 0x%08x\n", success, err, evtmask); ok(success || err == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); if (!success && (err == ERROR_IO_PENDING)) ok(WaitForSingleObjectEx(hComPortEvent, TIMEOUT, TRUE) == 0, "AbortWaitCts hComPortEvent failed\n"); @@ -1393,7 +1393,7 @@ static void test_WaitDsr(HANDLE hcom) trace("Success 0x%08x err %d evtmask 0x%08x\n", success, err, evtmask); ok(success || err == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); if (!success && (err == ERROR_IO_PENDING)) ok(WaitForSingleObjectEx(hComPortEvent, TIMEOUT, TRUE) == 0, "wait hComPortEvent failed\n"); @@ -1471,7 +1471,7 @@ static void test_WaitRing(HANDLE hcom) trace("Success 0x%08x err %d evtmask 0x%08x\n", success, err, evtmask); ok(success || err == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); if (!success && (err == ERROR_IO_PENDING)) ok(WaitForSingleObjectEx(hComPortEvent, TIMEOUT, TRUE) == 0, "wait hComPortEvent failed\n"); @@ -1482,7 +1482,7 @@ static void test_WaitRing(HANDLE hcom) success, err, evtmask, after-before, after1-before); ok(evtmask & EV_RING, "Failed to detect EV_RING: 0x%08x, expected 0x%08x\n", - evtmask, EV_CTS); + evtmask, EV_RING); ok(GetCommModemStatus(hcom, &evtmask), "GetCommModemStatus failed\n"); if(defaultStat & MS_RING_ON) ok((evtmask & MS_RING_ON) == 0,"DTR didn't change state!\n"); @@ -1543,7 +1543,7 @@ static void test_WaitDcd(HANDLE hcom) trace("Success 0x%08x err %d evtmask 0x%08x\n", success, err, evtmask); ok(success || err == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); if (!success && (err == ERROR_IO_PENDING)) ok(WaitForSingleObjectEx(hComPortEvent, TIMEOUT, TRUE) == 0, "wait hComPortEvent failed\n"); @@ -1554,7 +1554,7 @@ static void test_WaitDcd(HANDLE hcom) success, err, evtmask, after-before, after1-before); ok(evtmask & EV_RLSD, "Failed to detect EV_RLSD: 0x%08x, expected 0x%08x\n", - evtmask, EV_CTS); + evtmask, EV_RLSD); ok(GetCommModemStatus(hcom, &evtmask), "GetCommModemStatus failed\n"); if(defaultStat & MS_RLSD_ON) ok((evtmask & MS_RLSD_ON) == 0,"DTR didn't change state!\n"); @@ -1623,7 +1623,7 @@ static void test_WaitBreak(HANDLE hcom) trace("Success 0x%08x err %d evtmask 0x%08x\n", success, err, evtmask); ok(success || err == ERROR_IO_PENDING, "overlapped WaitCommEvent failed\n"); - trace("overlapped WriteCommEvent returned.\n"); + trace("overlapped WaitCommEvent returned.\n"); if (!success && (err == ERROR_IO_PENDING)) {

1 0

Dmitry Timoshkov : kernel32/tests: Make ClearCommError very first test since it depends on device queue being empty .
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: b288f0a8790dbcb79332de4e2af9f6674c5d3484 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b288f0a8790dbcb79332de4e2… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 15 16:38:15 2013 +0900 kernel32/tests: Make ClearCommError very first test since it depends on device queue being empty. --- dlls/kernel32/tests/comm.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index e9a8690..38a8bbc 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -1671,6 +1671,7 @@ START_TEST(comm) hcom = test_OpenComm(FALSE); if (hcom != INVALID_HANDLE_VALUE) { + test_ClearCommErrors(hcom); /* keep it the very first test */ test_GetModemStatus(hcom); test_ReadTimeOut(hcom); test_waittxempty(hcom); @@ -1679,13 +1680,6 @@ START_TEST(comm) hcom = test_OpenComm(FALSE); if (hcom != INVALID_HANDLE_VALUE) { - Sleep(200); /* Give the laster character of test_waittxempty to drop into the receiver */ - test_ClearCommErrors(hcom); - CloseHandle(hcom); - } - hcom = test_OpenComm(FALSE); - if (hcom != INVALID_HANDLE_VALUE) - { test_non_pending_errors(hcom); CloseHandle(hcom); }

1 0

Dmitry Timoshkov : kernel32/tests: Constify test data.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: a1b08f39a68499770d8c9b72bac8d75bd46be10c URL: http://source.winehq.org/git/wine.git/?a=commit;h=a1b08f39a68499770d8c9b72b… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 15 16:39:01 2013 +0900 kernel32/tests: Constify test data. --- dlls/kernel32/tests/comm.c | 46 +++++++++++++++++++++++-------------------- 1 files changed, 25 insertions(+), 21 deletions(-) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index 38a8bbc..765b54f 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -51,7 +51,7 @@ typedef struct COMMTIMEOUTS timeouts1, timeouts2; } TEST; -static TEST test[] = +static const TEST test[] = { { "baud=9600 parity=e data=5 stop=1 xon=on odsr=off octs=off dtr=on rts=on idsr=on", @@ -428,7 +428,7 @@ static TEST test[] = pdcb->wReserved1 & 0xffff ); } */ -static void check_result(const char *function, TEST *ptest, int initial_value, BOOL result) +static void check_result(const char *function, const TEST *ptest, int initial_value, BOOL result) { DWORD LastError = GetLastError(); DWORD CorrectError = (ptest->result ? 0xdeadbeef : ERROR_INVALID_PARAMETER); @@ -440,7 +440,7 @@ static void check_result(const char *function, TEST *ptest, int initial_value, B #define check_dcb_member(a,b) ok(pdcb1->a == pdcb2->a, "%s(\"%s\"), 0x%02x: "#a" is "b", should be "b"\n", function, ptest->string, initial_value, pdcb1->a, pdcb2->a) #define check_dcb_member2(a,c,b) if(pdcb2->a == c) { check_dcb_member(a,b); } else { ok(pdcb1->a == pdcb2->a || pdcb1->a == c, "%s(\"%s\"), 0x%02x: "#a" is "b", should be "b" or "b"\n", function, ptest->string, initial_value, pdcb1->a, pdcb2->a, c); } -static void check_dcb(const char *function, TEST *ptest, int initial_value, DCB *pdcb1, DCB *pdcb2) +static void check_dcb(const char *function, const TEST *ptest, int initial_value, const DCB *pdcb1, const DCB *pdcb2) { /* DCBlength is a special case since Win 9x sets it but NT does not. We will accept either as correct. */ @@ -512,7 +512,7 @@ static void check_dcb(const char *function, TEST *ptest, int initial_value, DCB #define check_timeouts_member(a) ok(ptimeouts1->a == ptimeouts2->a, "%s(\"%s\"), 0x%02x: "#a" is %u, should be %u\n", function, ptest->string, initial_value, ptimeouts1->a, ptimeouts2->a); -static void check_timeouts(const char *function, TEST *ptest, int initial_value, COMMTIMEOUTS *ptimeouts1, COMMTIMEOUTS *ptimeouts2) +static void check_timeouts(const char *function, const TEST *ptest, int initial_value, const COMMTIMEOUTS *ptimeouts1, const COMMTIMEOUTS *ptimeouts2) { check_timeouts_member(ReadIntervalTimeout); check_timeouts_member(ReadTotalTimeoutMultiplier); @@ -521,7 +521,7 @@ static void check_timeouts(const char *function, TEST *ptest, int initial_value, check_timeouts_member(WriteTotalTimeoutConstant); } -static void test_BuildCommDCBA(TEST *ptest, int initial_value, DCB *pexpected_dcb) +static void test_BuildCommDCBA(const char *string, const TEST *ptest, int initial_value, const DCB *pexpected_dcb) { BOOL result; DCB dcb; @@ -530,14 +530,14 @@ static void test_BuildCommDCBA(TEST *ptest, int initial_value, DCB *pexpected_dc memset(&dcb, initial_value, sizeof(DCB)); SetLastError(0xdeadbeef); - result = BuildCommDCBA(ptest->string, &dcb); + result = BuildCommDCBA(string, &dcb); /* check results */ check_result("BuildCommDCBA", ptest, initial_value, result); check_dcb("BuildCommDCBA", ptest, initial_value, &dcb, pexpected_dcb); } -static void test_BuildCommDCBAndTimeoutsA(TEST *ptest, int initial_value, DCB *pexpected_dcb, COMMTIMEOUTS *pexpected_timeouts) +static void test_BuildCommDCBAndTimeoutsA(const char *string, const TEST *ptest, int initial_value, const DCB *pexpected_dcb, const COMMTIMEOUTS *pexpected_timeouts) { BOOL result; DCB dcb; @@ -548,7 +548,7 @@ static void test_BuildCommDCBAndTimeoutsA(TEST *ptest, int initial_value, DCB *p memset(&timeouts, initial_value, sizeof(COMMTIMEOUTS)); SetLastError(0xdeadbeef); - result = BuildCommDCBAndTimeoutsA(ptest->string, &dcb, &timeouts); + result = BuildCommDCBAndTimeoutsA(string, &dcb, &timeouts); /* check results */ check_result("BuildCommDCBAndTimeoutsA", ptest, initial_value, result); @@ -556,14 +556,14 @@ static void test_BuildCommDCBAndTimeoutsA(TEST *ptest, int initial_value, DCB *p check_timeouts("BuildCommDCBAndTimeoutsA", ptest, initial_value, &timeouts, pexpected_timeouts); } -static void test_BuildCommDCBW(TEST *ptest, int initial_value, DCB *pexpected_dcb) +static void test_BuildCommDCBW(const char *string, const TEST *ptest, int initial_value, const DCB *pexpected_dcb) { BOOL result; DCB dcb; WCHAR wide_string[sizeof(ptest->string)]; static int reportedDCBW = 0; - MultiByteToWideChar(CP_ACP, 0, ptest->string, -1, wide_string, sizeof(wide_string) / sizeof(WCHAR)); + MultiByteToWideChar(CP_ACP, 0, string, -1, wide_string, sizeof(wide_string) / sizeof(WCHAR)); /* set initial conditions */ memset(&dcb, initial_value, sizeof(DCB)); @@ -583,7 +583,7 @@ static void test_BuildCommDCBW(TEST *ptest, int initial_value, DCB *pexpected_dc check_dcb("BuildCommDCBW", ptest, initial_value, &dcb, pexpected_dcb); } -static void test_BuildCommDCBAndTimeoutsW(TEST *ptest, int initial_value, DCB *pexpected_dcb, COMMTIMEOUTS *pexpected_timeouts) +static void test_BuildCommDCBAndTimeoutsW(const char *string, const TEST *ptest, int initial_value, const DCB *pexpected_dcb, const COMMTIMEOUTS *pexpected_timeouts) { BOOL result; DCB dcb; @@ -591,7 +591,7 @@ static void test_BuildCommDCBAndTimeoutsW(TEST *ptest, int initial_value, DCB *p WCHAR wide_string[sizeof(ptest->string)]; static int reportedDCBAndTW = 0; - MultiByteToWideChar(CP_ACP, 0, ptest->string, -1, wide_string, sizeof(wide_string) / sizeof(WCHAR)); + MultiByteToWideChar(CP_ACP, 0, string, -1, wide_string, sizeof(wide_string) / sizeof(WCHAR)); /* set initial conditions */ memset(&dcb, initial_value, sizeof(DCB)); @@ -639,8 +639,12 @@ static void test_BuildCommDCB(void) for(i = 0; i < TEST_COUNT; i++) { + char string[sizeof(test[i].string)]; + + strcpy(string, test[i].string); + /* Check if this test case needs a valid COM port. */ - ptr = strstr(test[i].string, "COMx"); + ptr = strstr(string, "COMx"); /* If required, substitute valid port number into device control string. */ if(ptr) @@ -651,15 +655,15 @@ static void test_BuildCommDCB(void) continue; } - test_BuildCommDCBA(&test[i], 0x00, &test[i].dcb1); - test_BuildCommDCBA(&test[i], 0xff, &test[i].dcb2); - test_BuildCommDCBAndTimeoutsA(&test[i], 0x00, &test[i].dcb1, &test[i].timeouts1); - test_BuildCommDCBAndTimeoutsA(&test[i], 0xff, &test[i].dcb2, &test[i].timeouts2); + test_BuildCommDCBA(string, &test[i], 0x00, &test[i].dcb1); + test_BuildCommDCBA(string, &test[i], 0xff, &test[i].dcb2); + test_BuildCommDCBAndTimeoutsA(string, &test[i], 0x00, &test[i].dcb1, &test[i].timeouts1); + test_BuildCommDCBAndTimeoutsA(string, &test[i], 0xff, &test[i].dcb2, &test[i].timeouts2); - test_BuildCommDCBW(&test[i], 0x00, &test[i].dcb1); - test_BuildCommDCBW(&test[i], 0xff, &test[i].dcb2); - test_BuildCommDCBAndTimeoutsW(&test[i], 0x00, &test[i].dcb1, &test[i].timeouts1); - test_BuildCommDCBAndTimeoutsW(&test[i], 0xff, &test[i].dcb2, &test[i].timeouts2); + test_BuildCommDCBW(string, &test[i], 0x00, &test[i].dcb1); + test_BuildCommDCBW(string, &test[i], 0xff, &test[i].dcb2); + test_BuildCommDCBAndTimeoutsW(string, &test[i], 0x00, &test[i].dcb1, &test[i].timeouts1); + test_BuildCommDCBAndTimeoutsW(string, &test[i], 0xff, &test[i].dcb2, &test[i].timeouts2); } }

1 0

Dmitry Timoshkov : kernel32/tests: Make serial tests self-contained.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: 4654e7977690f27ebd2323342306bf00ac98df24 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4654e7977690f27ebd2323342… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 15 16:39:45 2013 +0900 kernel32/tests: Make serial tests self-contained. --- dlls/kernel32/tests/comm.c | 284 ++++++++++++++++++++++++++------------------ 1 files changed, 167 insertions(+), 117 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4654e7977690f27ebd232…

1 0

Dmitry Timoshkov : kernel32/tests: Make test_waittxempty() use overlapped IO to avoid waiting forever when a kernel driver doesn' t support TIOCGICOUNT/TIOCSERGETLSR ioctl.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: 507449ee783ceb670ae12ec54b8f7e542a3034d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=507449ee783ceb670ae12ec54… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 15 16:40:29 2013 +0900 kernel32/tests: Make test_waittxempty() use overlapped IO to avoid waiting forever when a kernel driver doesn't support TIOCGICOUNT/TIOCSERGETLSR ioctl. Most of Linux USB-serial drivers don't support these ioctls. --- dlls/kernel32/tests/comm.c | 102 ++++++++++++++++++++++++++++++------------- 1 files changed, 71 insertions(+), 31 deletions(-) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index 81953cb..b393db4 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -780,59 +780,99 @@ static void test_waittxempty(void) DCB dcb; COMMTIMEOUTS timeouts; char tbuf[]="test_waittxempty"; - DWORD before, after, written, timediff, evtmask = 0; - BOOL res_write, res; + DWORD before, after, bytes, timediff, evtmask; + BOOL res; DWORD baud = SLOWBAUD; + OVERLAPPED ovl_write, ovl_wait; - hcom = test_OpenComm(FALSE); + hcom = test_OpenComm(TRUE); if (hcom == INVALID_HANDLE_VALUE) return; /* set a low baud rate to have ample time*/ - ok(GetCommState(hcom, &dcb), "GetCommState failed\n"); + res = GetCommState(hcom, &dcb); + ok(res, "GetCommState error %d\n", GetLastError()); dcb.BaudRate = baud; dcb.ByteSize = 8; dcb.Parity = NOPARITY; dcb.fRtsControl=RTS_CONTROL_ENABLE; dcb.fDtrControl=DTR_CONTROL_ENABLE; dcb.StopBits = ONESTOPBIT; - ok(SetCommState(hcom, &dcb), "SetCommState failed\n"); + res = SetCommState(hcom, &dcb); + ok(res, "SetCommState error %d\n", GetLastError()); ZeroMemory( &timeouts, sizeof(timeouts)); timeouts.ReadTotalTimeoutConstant = TIMEOUT; - ok(SetCommTimeouts(hcom, &timeouts),"SetCommTimeouts failed\n"); + res = SetCommTimeouts(hcom, &timeouts); + ok(res,"SetCommTimeouts error %d\n", GetLastError()); - ok(SetupComm(hcom,1024,1024),"SetUpComm failed\n"); - ok(SetCommMask(hcom, EV_TXEMPTY), "SetCommMask failed\n"); + res = SetupComm(hcom, 1024, 1024); + ok(res, "SetUpComm error %d\n", GetLastError()); + + /* calling SetCommMask after WriteFile leads to WaitCommEvent failures + * due to timeout (no events) under testbot VMs and VirtualBox + */ + res = SetCommMask(hcom, EV_TXEMPTY); + ok(res, "SetCommMask error %d\n", GetLastError()); + SetLastError(0xdeadbeef); + res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, NULL); +todo_wine + ok(!res, "WriteFile on an overlapped handle without ovl structure should fail\n"); +todo_wine + ok(GetLastError() == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); + + S(U(ovl_write)).Offset = 0; + S(U(ovl_write)).OffsetHigh = 0; + ovl_write.hEvent = CreateEvent(NULL, TRUE, FALSE, NULL); before = GetTickCount(); - res_write=WriteFile(hcom, tbuf, sizeof(tbuf), &written, NULL); + SetLastError(0xdeadbeef); + res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, &ovl_write); after = GetTickCount(); - ok(res_write == TRUE, "WriteFile failed\n"); - ok(written == sizeof(tbuf), - "WriteFile: Unexpected write_size %d\n", written); - - trace("WriteFile succeeded, took %d ms to write %d Bytes at %d Baud\n", - after - before, written, baud); - +todo_wine + ok(!res && GetLastError() == ERROR_IO_PENDING, "WriteFile returned %d, error %d\n", res, GetLastError()); +todo_wine + ok(!bytes, "expected 0, got %u\n", bytes); + ok(after - before == 0, "WriteFile took %d ms to write %d Bytes at %d Baud\n", + after - before, bytes, baud); + /* don't wait for WriteFile completion */ + + S(U(ovl_wait)).Offset = 0; + S(U(ovl_wait)).OffsetHigh = 0; + ovl_wait.hEvent = CreateEvent(NULL, TRUE, FALSE, NULL); + evtmask = 0; before = GetTickCount(); - res = WaitCommEvent(hcom, &evtmask, NULL); + SetLastError(0xdeadbeef); + res = WaitCommEvent(hcom, &evtmask, &ovl_wait); + ok(!res && GetLastError() == ERROR_IO_PENDING, "WaitCommEvent error %d\n", GetLastError()); + res = WaitForSingleObject(ovl_wait.hEvent, TIMEOUT); +todo_wine + ok(res == WAIT_OBJECT_0, "WaitCommEvent failed with a timeout\n"); + if (res == WAIT_OBJECT_0) + { + res = GetOverlappedResult(hcom, &ovl_wait, &bytes, FALSE); + ok(res, "GetOverlappedResult reported error %d\n", GetLastError()); + ok(bytes == sizeof(evtmask), "expected %u, written %u\n", (UINT)sizeof(evtmask), bytes); + res = TRUE; + } + else res = FALSE; after = GetTickCount(); - - ok(res == TRUE, "WaitCommEvent failed\n"); - ok((evtmask & EV_TXEMPTY), - "WaitCommEvent: Unexpected EvtMask 0x%08x, expected 0x%08x\n", - evtmask, EV_TXEMPTY); +todo_wine + ok(res, "WaitCommEvent error %d\n", GetLastError()); +todo_wine + ok(evtmask & EV_TXEMPTY, "WaitCommEvent: expected EV_TXEMPTY, got %#x\n", evtmask); + CloseHandle(ovl_wait.hEvent); timediff = after - before; - - trace("WaitCommEvent for EV_TXEMPTY took %d ms\n", timediff); - /* 050604: This shows a difference between XP (tested with mingw compiled crosstest): - XP returns Writefile only after everything went out of the Serial port, - while wine returns immediately. - Thus on XP, WaintCommEvent after setting the CommMask for EV_TXEMPTY - nearly return immediate, - while on wine the most time is spent here - */ + trace("WaitCommEvent for EV_TXEMPTY took %d ms (timeout %d)\n", timediff, TIMEOUT); +todo_wine + ok(timediff < 900, "WaitCommEvent used %d ms for waiting\n", timediff); + + res = WaitForSingleObject(ovl_write.hEvent, 0); + ok(res == WAIT_OBJECT_0, "WriteFile failed with a timeout\n"); + res = GetOverlappedResult(hcom, &ovl_write, &bytes, FALSE); + ok(res, "GetOverlappedResult reported error %d\n", GetLastError()); + ok(bytes == sizeof(tbuf), "expected %u, written %u\n", (UINT)sizeof(tbuf), bytes); + CloseHandle(ovl_write.hEvent); CloseHandle(hcom); }

1 0

Dmitry Timoshkov : kernel32/tests: Add interactive WaitCommEvent tests.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: fc2309b84bee9e2f895f6ae60b72a28c9c18e0f1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc2309b84bee9e2f895f6ae60… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 15 16:41:13 2013 +0900 kernel32/tests: Add interactive WaitCommEvent tests. --- dlls/kernel32/tests/comm.c | 62 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index b393db4..12a808d 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -1818,6 +1818,60 @@ static void test_stdio(void) "got error %u\n", GetLastError() ); } +static void test_WaitCommEvent(void) +{ + HANDLE hcom; + DWORD evtmask, ret, bytes, before, after, last_event_time; + OVERLAPPED ovl_wait; + + hcom = test_OpenComm(TRUE); + if (hcom == INVALID_HANDLE_VALUE) return; + + test_GetModemStatus(hcom); + + ret = SetCommMask(hcom, 0x1fff); + ok(ret, "SetCommMask error %d\n", GetLastError()); + + S(U(ovl_wait)).Offset = 0; + S(U(ovl_wait)).OffsetHigh = 0; + ovl_wait.hEvent = CreateEvent(NULL, TRUE, FALSE, NULL); + + trace("waiting 10 secs for com port events (turn on/off the device)...\n"); + last_event_time = 0; + before = GetTickCount(); + do + { + evtmask = 0; + SetLastError(0xdeadbeef); + ret = WaitCommEvent(hcom, &evtmask, &ovl_wait); + ok(!ret && GetLastError() == ERROR_IO_PENDING, "WaitCommEvent returned %d, error %d\n", ret, GetLastError()); + if (GetLastError() != ERROR_IO_PENDING) goto done; /* no point in further testing */ + for (;;) + { + ret = WaitForSingleObject(ovl_wait.hEvent, 500); + after = GetTickCount(); + if (ret == WAIT_OBJECT_0) + { + last_event_time = after; + ret = GetOverlappedResult(hcom, &ovl_wait, &bytes, FALSE); + ok(ret, "GetOverlappedResult reported error %d\n", GetLastError()); + ok(bytes == sizeof(evtmask), "expected %u, written %u\n", (UINT)sizeof(evtmask), bytes); + trace("WaitCommEvent: got events %#x\n", evtmask); + test_GetModemStatus(hcom); + break; + } + else + { + if (last_event_time || after - before >= 10000) goto done; + } + } + } while (after - before < 10000); + +done: + CloseHandle(ovl_wait.hEvent); + CloseHandle(hcom); +} + START_TEST(comm) { test_ClearCommError(); /* keep it the very first test */ @@ -1838,4 +1892,12 @@ START_TEST(comm) test_WaitDcd(); test_WaitBreak(); test_stdio(); + + if (!winetest_interactive) + { + skip("interactive tests (set WINETEST_INTERACTIVE=1)\n"); + return; + } + + test_WaitCommEvent(); }

1 0

Daniel Jelinski : shell32: Fix context menu creation.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: c687b4adf4d6c0232270f8845c5314bcca538b29 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c687b4adf4d6c0232270f8845… Author: Daniel Jelinski <djelinski1(a)gmail.com> Date: Sat Aug 10 18:53:29 2013 +0200 shell32: Fix context menu creation. --- dlls/shell32/shlview_cmenu.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/shlview_cmenu.c b/dlls/shell32/shlview_cmenu.c index 92f671a..07c33d0 100644 --- a/dlls/shell32/shlview_cmenu.c +++ b/dlls/shell32/shlview_cmenu.c @@ -160,10 +160,10 @@ static HRESULT WINAPI ItemMenu_QueryContextMenu( mi.dwTypeData = str; mi.cch = 255; GetMenuItemInfoW(hmenu, FCIDM_SHVIEW_EXPLORE, MF_BYCOMMAND, &mi); - RemoveMenu(hmenu, FCIDM_SHVIEW_EXPLORE, MF_BYCOMMAND); + RemoveMenu(hmenu, FCIDM_SHVIEW_EXPLORE + idCmdFirst, MF_BYCOMMAND); mi.cbSize = sizeof(mi); - mi.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE; + mi.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE | MIIM_STRING; mi.dwTypeData = str; mi.fState = MFS_ENABLED; mi.wID = FCIDM_SHVIEW_EXPLORE;

1 0

Daniel Jelinski : shell32: Context menu offset is handled by client.
by Alexandre Julliard 15 Aug '13

15 Aug '13

Module: wine Branch: master Commit: 6509499fc91d8aa453f9f81299c47699f8afabe4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6509499fc91d8aa453f9f8129… Author: Daniel Jelinski <djelinski1(a)gmail.com> Date: Sat Aug 10 19:06:33 2013 +0200 shell32: Context menu offset is handled by client. --- dlls/shell32/shlview_cmenu.c | 17 +++++------------ 1 files changed, 5 insertions(+), 12 deletions(-) diff --git a/dlls/shell32/shlview_cmenu.c b/dlls/shell32/shlview_cmenu.c index 07c33d0..b7dc994 100644 --- a/dlls/shell32/shlview_cmenu.c +++ b/dlls/shell32/shlview_cmenu.c @@ -49,7 +49,6 @@ typedef struct LONG ref; IShellFolder* parent; - UINT verb_offset; /* item menu data */ LPITEMIDLIST pidl; /* root pidl */ @@ -138,8 +137,6 @@ static HRESULT WINAPI ItemMenu_QueryContextMenu( TRACE("(%p)->(%p %d 0x%x 0x%x 0x%x )\n", This, hmenu, indexMenu, idCmdFirst, idCmdLast, uFlags); - This->verb_offset = idCmdFirst; - if(!(CMF_DEFAULTONLY & uFlags) && This->cidl > 0) { HMENU hmenures = LoadMenuW(shell32_hInstance, MAKEINTRESOURCEW(MENU_SHV_FILE)); @@ -419,7 +416,7 @@ static HRESULT WINAPI ItemMenu_InvokeCommand( if (HIWORD(lpcmi->lpVerb) == 0) { - switch(LOWORD(lpcmi->lpVerb - This->verb_offset)) + switch(LOWORD(lpcmi->lpVerb)) { case FCIDM_SHVIEW_EXPLORE: TRACE("Verb FCIDM_SHVIEW_EXPLORE\n"); @@ -466,7 +463,7 @@ static HRESULT WINAPI ItemMenu_InvokeCommand( DoOpenProperties(This, lpcmi->hwnd); break; default: - FIXME("Unhandled Verb %xl\n",LOWORD(lpcmi->lpVerb)-This->verb_offset); + FIXME("Unhandled Verb %xl\n",LOWORD(lpcmi->lpVerb)); return E_INVALIDARG; } } @@ -506,7 +503,7 @@ static HRESULT WINAPI ItemMenu_GetCommandString( break; case GCS_VERBA: - switch(idCommand-This->verb_offset) + switch(idCommand) { case FCIDM_SHVIEW_RENAME: strcpy(lpszName, "rename"); @@ -518,7 +515,7 @@ static HRESULT WINAPI ItemMenu_GetCommandString( /* NT 4.0 with IE 3.0x or no IE will always call This with GCS_VERBW. In This case, you need to do the lstrcpyW to the pointer passed.*/ case GCS_VERBW: - switch(idCommand-This->verb_offset) + switch(idCommand) { case FCIDM_SHVIEW_RENAME: MultiByteToWideChar( CP_ACP, 0, "rename", -1, (LPWSTR)lpszName, uMaxNameLen ); @@ -581,7 +578,6 @@ HRESULT ItemMenu_Constructor(IShellFolder *parent, LPCITEMIDLIST pidl, const LPC This->IContextMenu3_iface.lpVtbl = &ItemContextMenuVtbl; This->ref = 1; - This->verb_offset = 0; This->parent = parent; if (parent) IShellFolder_AddRef(parent); @@ -618,8 +614,6 @@ static HRESULT WINAPI BackgroundMenu_QueryContextMenu( TRACE("(%p)->(hmenu=%p indexmenu=%x cmdfirst=%x cmdlast=%x flags=%x )\n", This, hMenu, indexMenu, idCmdFirst, idCmdLast, uFlags); - This->verb_offset = idCmdFirst; - hMyMenu = LoadMenuA(shell32_hInstance, "MENU_002"); if (uFlags & CMF_DEFAULTONLY) { @@ -804,7 +798,7 @@ static HRESULT WINAPI BackgroundMenu_InvokeCommand( } else { - switch (LOWORD(lpcmi->lpVerb) - This->verb_offset) + switch (LOWORD(lpcmi->lpVerb)) { case FCIDM_SHVIEW_REFRESH: if (view) IShellView_Refresh(view); @@ -893,7 +887,6 @@ HRESULT BackgroundMenu_Constructor(IShellFolder *parent, BOOL desktop, REFIID ri This->IContextMenu3_iface.lpVtbl = &BackgroundContextMenuVtbl; This->ref = 1; This->parent = parent; - This->verb_offset = 0; This->pidl = NULL; This->apidl = NULL;

1 0