November 2014 - Wine-commits

Michael Stefaniuc : urlmon/tests: Visually separate two if statements ( PVS-Studio).
by Alexandre Julliard 03 Nov '14

03 Nov '14

Module: wine Branch: master Commit: 0ef0477f9ec7b632fb21c87d64e7ad08171e3cf2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0ef0477f9ec7b632fb21c87d6… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Oct 31 10:59:25 2014 +0100 urlmon/tests: Visually separate two if statements (PVS-Studio). --- dlls/urlmon/tests/protocol.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/urlmon/tests/protocol.c b/dlls/urlmon/tests/protocol.c index 9ffa04d..df3c364 100644 --- a/dlls/urlmon/tests/protocol.c +++ b/dlls/urlmon/tests/protocol.c @@ -1991,7 +1991,9 @@ static HRESULT WINAPI ProtocolEmul_Read(IInternetProtocolEx *iface, void *pv, memcpy(pv, "gif87a", 6); prot_read += *pcbRead = cb; return S_OK; - }if(prot_state == 4) { + } + + if(prot_state == 4) { *pcbRead = 0; return S_FALSE; }

1 0

Huw Davies : comctl32/tests: Post a key-down message rather than use keybd_event.
by Alexandre Julliard 03 Nov '14

03 Nov '14

Module: wine Branch: master Commit: dd856be316f7aac99bd70400e6d5b927177d1343 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd856be316f7aac99bd70400e… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Oct 31 11:55:18 2014 +0000 comctl32/tests: Post a key-down message rather than use keybd_event. --- dlls/comctl32/tests/propsheet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/tests/propsheet.c b/dlls/comctl32/tests/propsheet.c index 2797e94..815b8ad 100644 --- a/dlls/comctl32/tests/propsheet.c +++ b/dlls/comctl32/tests/propsheet.c @@ -524,7 +524,7 @@ page_with_custom_default_button_dlg_proc(HWND hdlg, UINT msg, WPARAM wparam, LPA static void test_custom_default_button(void) { - HWND hdlg; + HWND hdlg, page; PROPSHEETPAGEA psp[1]; PROPSHEETHEADERA psh; MSG msg; @@ -568,7 +568,8 @@ static void test_custom_default_button(void) /* At this point, the combobox should have keyboard focus, so we press ENTER. * Pull the lever, Kronk! */ - keybd_event(VK_RETURN, 0, 0, 0); + page = (HWND)SendMessageW(hdlg, PSM_GETCURRENTPAGEHWND, 0, 0); + PostMessageW(GetDlgItem(page, IDC_PS_COMBO1), WM_KEYDOWN, VK_RETURN, 0); /* Process all the messages in the queue for this thread. */ while (PeekMessageA(&msg, NULL, 0, 0, PM_REMOVE))

1 0

Bruno Jesus : comctl32/tests: Remove dead assignments in treeview.c ( Cppcheck).
by Alexandre Julliard 03 Nov '14

03 Nov '14

Module: wine Branch: master Commit: f4a13b9f1bf691aa85b6d968d51c4f764cb7a822 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f4a13b9f1bf691aa85b6d968d… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Fri Oct 31 23:44:07 2014 -0200 comctl32/tests: Remove dead assignments in treeview.c (Cppcheck). --- dlls/comctl32/tests/treeview.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c index ce65f06..eb7d7e5 100644 --- a/dlls/comctl32/tests/treeview.c +++ b/dlls/comctl32/tests/treeview.c @@ -663,7 +663,7 @@ static void test_focus(void) static void test_get_set_bkcolor(void) { - COLORREF crColor = RGB(0,0,0); + COLORREF crColor; HWND hTree; hTree = create_treeview_control(0); @@ -719,9 +719,9 @@ static void test_get_set_imagelist(void) static void test_get_set_indent(void) { - int ulIndent = -1; - int ulMinIndent = -1; - int ulMoreThanTwiceMin = -1; + int ulIndent; + int ulMinIndent; + int ulMoreThanTwiceMin; HWND hTree; hTree = create_treeview_control(0); @@ -914,7 +914,7 @@ static void test_get_set_scrolltime(void) static void test_get_set_textcolor(void) { /* If the value is -1, the control is using the system color for the text color. */ - COLORREF crColor = RGB(0,0,0); + COLORREF crColor; HWND hTree; hTree = create_treeview_control(0); @@ -974,8 +974,8 @@ static void test_get_set_tooltips(void) static void test_get_set_unicodeformat(void) { - BOOL bPreviousSetting = FALSE; - BOOL bNewSetting = FALSE; + BOOL bPreviousSetting; + BOOL bNewSetting; HWND hTree; hTree = create_treeview_control(0);

1 0

Jacek Caban : winegecko.php: Added 2.34 release.
by Alexandre Julliard 03 Nov '14

03 Nov '14

Module: tools Branch: master Commit: f3bcf0e6c98932f06dfcfd3eef03f306fe51d11b URL: http://source.winehq.org/git/tools.git/?a=commit;h=f3bcf0e6c98932f06dfcfd3e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Nov 3 12:39:00 2014 +0100 winegecko.php: Added 2.34 release. --- winegecko.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/winegecko.php b/winegecko.php index cba6bbf..eaa1f22 100644 --- a/winegecko.php +++ b/winegecko.php @@ -82,7 +82,9 @@ $aFileSizes = array( '2.34-beta1-x86'=>28131328, '2.34-beta1-x86_64'=>29696000, '2.34-beta2-x86'=>28270080, - '2.34-beta2-x86_64'=>29807616 + '2.34-beta2-x86_64'=>29807616, + '2.34-x86'=>28269568, + '2.34-x86_64'=>29802496 ); // Exact size of the file:

1 0