February 2014 - Wine-commits

Piotr Caban : kernel32: Handle STD_*_HANDLE in GetFileType.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: afadda8ff72a67279c61c0c6aac3c3b4391a2531 URL: http://source.winehq.org/git/wine.git/?a=commit;h=afadda8ff72a67279c61c0c6a… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Feb 7 15:40:06 2014 +0100 kernel32: Handle STD_*_HANDLE in GetFileType. --- dlls/kernel32/file.c | 4 ++++ dlls/kernel32/tests/file.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/file.c b/dlls/kernel32/file.c index bdae8f4..2f5dee2 100644 --- a/dlls/kernel32/file.c +++ b/dlls/kernel32/file.c @@ -817,6 +817,10 @@ DWORD WINAPI GetFileType( HANDLE hFile ) IO_STATUS_BLOCK io; NTSTATUS status; + if (hFile == (HANDLE)STD_INPUT_HANDLE || hFile == (HANDLE)STD_OUTPUT_HANDLE + || hFile == (HANDLE)STD_ERROR_HANDLE) + hFile = GetStdHandle((DWORD_PTR)hFile); + if (is_console_handle( hFile )) return FILE_TYPE_CHAR; status = NtQueryVolumeInformationFile( hFile, &io, &info, sizeof(info), FileFsDeviceInformation ); diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index f89e5af..b1b36bb 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -2686,7 +2686,7 @@ static void test_MapFile(void) static void test_GetFileType(void) { - DWORD type; + DWORD type, type2; HANDLE h = CreateFileA( filename, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0 ); ok( h != INVALID_HANDLE_VALUE, "open %s failed\n", filename ); type = GetFileType(h); @@ -2698,6 +2698,11 @@ static void test_GetFileType(void) ok( type == FILE_TYPE_CHAR, "expected type char for nul got %d\n", type ); CloseHandle( h ); DeleteFileA( filename ); + h = GetStdHandle( STD_OUTPUT_HANDLE ); + ok( h != INVALID_HANDLE_VALUE, "GetStdHandle failed\n" ); + type = GetFileType( (HANDLE)STD_OUTPUT_HANDLE ); + type2 = GetFileType( h ); + ok(type == type2, "expected type %d for STD_OUTPUT_HANDLE got %d\n", type2, type); } static int completion_count;

1 0

Nikolay Sivov : ole32: Implement CoGetInstanceFromIStorage().
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 62d9b5a0e079b6db8c16444d92fe85cfa8e10f41 URL: http://source.winehq.org/git/wine.git/?a=commit;h=62d9b5a0e079b6db8c16444d9… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Feb 7 08:55:13 2014 +0400 ole32: Implement CoGetInstanceFromIStorage(). --- dlls/ole32/compobj.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++ dlls/ole32/ole32.spec | 2 +- 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index 4149ecb..3e99097 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -3330,6 +3330,69 @@ HRESULT WINAPI CoGetInstanceFromFile( } /*********************************************************************** + * CoGetInstanceFromIStorage [OLE32.@] + */ +HRESULT WINAPI CoGetInstanceFromIStorage( + COSERVERINFO *server_info, + CLSID *rclsid, + IUnknown *outer, + DWORD cls_context, + IStorage *storage, + DWORD count, + MULTI_QI *results +) +{ + IPersistStorage *ps = NULL; + IUnknown* unk = NULL; + STATSTG stat; + HRESULT hr; + + if (count == 0 || !results || !storage) + return E_INVALIDARG; + + if (server_info) + FIXME("() non-NULL server_info not supported\n"); + + init_multi_qi(count, results); + + /* optionaly get CLSID from a file */ + if (!rclsid) + { + memset(&stat.clsid, 0, sizeof(stat.clsid)); + hr = IStorage_Stat(storage, &stat, STATFLAG_NONAME); + if (FAILED(hr)) + { + ERR("failed to get CLSID from a file\n"); + return hr; + } + + rclsid = &stat.clsid; + } + + hr = CoCreateInstance(rclsid, + outer, + cls_context, + &IID_IUnknown, + (void**)&unk); + + if (hr != S_OK) + return hr; + + /* init from IStorage */ + hr = IUnknown_QueryInterface(unk, &IID_IPersistStorage, (void**)&ps); + if (FAILED(hr)) + ERR("failed to get IPersistStorage\n"); + + if (ps) + { + IPersistStorage_Load(ps, storage); + IPersistStorage_Release(ps); + } + + return return_multi_qi(unk, count, results); +} + +/*********************************************************************** * CoLoadLibrary (OLE32.@) * * Loads a library. diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec index 28a84a1..00d5696 100644 --- a/dlls/ole32/ole32.spec +++ b/dlls/ole32/ole32.spec @@ -30,7 +30,7 @@ @ stdcall CoGetCurrentProcess() @ stdcall CoGetDefaultContext(long ptr ptr) @ stdcall CoGetInstanceFromFile(ptr ptr ptr long long wstr long ptr) -@ stub CoGetInstanceFromIStorage #@ stdcall (ptr ptr ptr long ptr long ptr) return 0,ERR_NOTIMPLEMENTED +@ stdcall CoGetInstanceFromIStorage(ptr ptr ptr long ptr long ptr) @ stdcall CoGetInterfaceAndReleaseStream(ptr ptr ptr) @ stdcall CoGetMalloc(long ptr) @ stdcall CoGetMarshalSizeMax(ptr ptr ptr long ptr long)

1 0

Nikolay Sivov : inetmib1/tests: Cleanup tests a bit, fix a crash on Win8 64bit.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 1faa3d4e5214124cfc327a6693473e2298c6c7ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=1faa3d4e5214124cfc327a669… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Feb 7 08:55:33 2014 +0400 inetmib1/tests: Cleanup tests a bit, fix a crash on Win8 64bit. --- dlls/inetmib1/tests/main.c | 94 +++++++++++++++++++++++++++++--------------- 1 file changed, 62 insertions(+), 32 deletions(-) diff --git a/dlls/inetmib1/tests/main.c b/dlls/inetmib1/tests/main.c index 80b3618..29876b1 100644 --- a/dlls/inetmib1/tests/main.c +++ b/dlls/inetmib1/tests/main.c @@ -23,38 +23,63 @@ #include "wine/test.h" -static HMODULE inetmib1; +static BOOL (WINAPI *pSnmpExtensionInit)(DWORD, HANDLE*, AsnObjectIdentifier*); +static BOOL (WINAPI *pSnmpExtensionQuery)(BYTE, SnmpVarBindList*, AsnInteger32*, AsnInteger32*); + +static HMODULE init_test_functions(void) +{ + HMODULE mod = LoadLibraryA("inetmib1"); + + ok(mod != NULL, "failed to load inetmib1.dll"); + + if (!mod) return NULL; + + pSnmpExtensionInit = (void *)GetProcAddress(mod, "SnmpExtensionInit"); + pSnmpExtensionQuery = (void *)GetProcAddress(mod, "SnmpExtensionQuery"); + + return mod; +} + +static void uninit_test_functions(HMODULE mod) +{ + FreeLibrary(mod); +} static void testInit(void) { - BOOL (WINAPI *pInit)(DWORD, HANDLE *, AsnObjectIdentifier *); BOOL ret; HANDLE event; AsnObjectIdentifier oid; - pInit = (void *)GetProcAddress(inetmib1, "SnmpExtensionInit"); - if (!pInit) + if (!pSnmpExtensionInit) { win_skip("no SnmpExtensionInit\n"); return; } - /* Crash - ret = pInit(0, NULL, NULL); - ret = pInit(0, NULL, &oid); - ret = pInit(0, &event, NULL); - */ - ret = pInit(0, &event, &oid); + +if (0) /* crashes on native */ +{ + ret = pSnmpExtensionInit(0, NULL, NULL); + ret = pSnmpExtensionInit(0, NULL, &oid); + ret = pSnmpExtensionInit(0, &event, NULL); +} + + ret = pSnmpExtensionInit(0, &event, &oid); ok(ret, "SnmpExtensionInit failed: %d\n", GetLastError()); ok(!strcmp("1.3.6.1.2.1.1", SnmpUtilOidToA(&oid)), "Expected 1.3.6.1.2.1.1, got %s\n", SnmpUtilOidToA(&oid)); + +if (0) +{ + /* Fails when called on win8, documentation suggests that + extension itself is resposible of freeing this oid */ SnmpUtilOidFree(&oid); } +} static void testQuery(void) { - BOOL (WINAPI *pQuery)(BYTE, SnmpVarBindList *, AsnInteger32 *, - AsnInteger32 *); BOOL ret, moreData, noChange; SnmpVarBindList list; AsnInteger32 error, index; @@ -71,25 +96,25 @@ static void testQuery(void) SnmpVarBind vars[3], vars2[3], vars3[3]; UINT entry; - pQuery = (void *)GetProcAddress(inetmib1, "SnmpExtensionQuery"); - if (!pQuery) + if (!pSnmpExtensionQuery) { win_skip("couldn't find SnmpExtensionQuery\n"); return; } - /* Crash - ret = pQuery(0, NULL, NULL, NULL); - ret = pQuery(0, NULL, &error, NULL); - ret = pQuery(0, NULL, NULL, &index); - ret = pQuery(0, &list, NULL, NULL); - ret = pQuery(0, &list, &error, NULL); - */ +if (0) /* crashes on native */ +{ + ret = pSnmpExtensionQuery(0, NULL, NULL, NULL); + ret = pSnmpExtensionQuery(0, NULL, &error, NULL); + ret = pSnmpExtensionQuery(0, NULL, NULL, &index); + ret = pSnmpExtensionQuery(0, &list, NULL, NULL); + ret = pSnmpExtensionQuery(0, &list, &error, NULL); +} /* An empty list succeeds */ list.len = 0; error = 0xdeadbeef; index = 0xdeadbeef; - ret = pQuery(SNMP_PDU_GET, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GET, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOERROR, "expected SNMP_ERRORSTATUS_NOERROR, got %d\n", error); @@ -106,7 +131,7 @@ static void testQuery(void) SetLastError(0xdeadbeef); error = 0xdeadbeef; index = 0xdeadbeef; - ret = pQuery(SNMP_PDU_GET, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GET, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOERROR || broken(error == ERROR_FILE_NOT_FOUND) /* NT4 */, @@ -126,7 +151,7 @@ static void testQuery(void) SetLastError(0xdeadbeef); error = 0xdeadbeef; index = 0xdeadbeef; - ret = pQuery(SNMP_PDU_GET, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GET, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOSUCHNAME, "expected SNMP_ERRORSTATUS_NOSUCHNAME, got %d\n", error); @@ -148,7 +173,7 @@ static void testQuery(void) SetLastError(0xdeadbeef); error = 0xdeadbeef; index = 0xdeadbeef; - ret = pQuery(SNMP_PDU_GET, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GET, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOSUCHNAME, "expected SNMP_ERRORSTATUS_NOSUCHNAME, got %d\n", error); @@ -170,7 +195,7 @@ static void testQuery(void) SetLastError(0xdeadbeef); error = 0xdeadbeef; index = 0xdeadbeef; - ret = pQuery(SNMP_PDU_GETNEXT, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GETNEXT, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOERROR, "expected SNMP_ERRORSTATUS_NOERROR, got %d\n", error); @@ -252,7 +277,7 @@ static void testQuery(void) list.len = 1; list.list = vars2; noChange = FALSE; - ret = pQuery(SNMP_PDU_GETNEXT, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GETNEXT, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOERROR, "expected SNMP_ERRORSTATUS_NOERROR, got %d\n", error); @@ -274,7 +299,7 @@ static void testQuery(void) list.list = vars2; moreData = TRUE; do { - ret = pQuery(SNMP_PDU_GETNEXT, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GETNEXT, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOERROR, "expected SNMP_ERRORSTATUS_NOERROR, got %d\n", error); @@ -340,7 +365,7 @@ static void testQuery(void) moreData = TRUE; noChange = FALSE; do { - ret = pQuery(SNMP_PDU_GETNEXT, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GETNEXT, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); ok(error == SNMP_ERRORSTATUS_NOERROR, "expected SNMP_ERRORSTATUS_NOERROR, got %d\n", error); @@ -406,7 +431,7 @@ static void testQuery(void) moreData = TRUE; noChange = FALSE; do { - ret = pQuery(SNMP_PDU_GETNEXT, &list, &error, &index); + ret = pSnmpExtensionQuery(SNMP_PDU_GETNEXT, &list, &error, &index); ok(ret, "SnmpExtensionQuery failed: %d, %d\n", error, index); /* FIXME: error and index aren't checked here because the UDP table is * the last OID currently supported by Wine, so the last GetNext fails. @@ -471,8 +496,13 @@ static void testQuery(void) START_TEST(main) { - inetmib1 = LoadLibraryA("inetmib1"); + HMODULE mod; + + if (!(mod = init_test_functions())) + return; + testInit(); testQuery(); - FreeLibrary(inetmib1); + + uninit_test_functions(mod); }

1 0

Dmitry Timoshkov : taskschd/tests: Add some tests for IRegisteredTask interface.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: ae8683953636cae518417a4ff07c453ba3da6e3d URL: http://source.winehq.org/git/wine.git/?a=commit;h=ae8683953636cae518417a4ff… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Feb 7 18:28:39 2014 +0900 taskschd/tests: Add some tests for IRegisteredTask interface. --- dlls/taskschd/tests/scheduler.c | 195 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 195 insertions(+) diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c index df00eb2..ac1eb98 100644 --- a/dlls/taskschd/tests/scheduler.c +++ b/dlls/taskschd/tests/scheduler.c @@ -659,6 +659,200 @@ static void test_FolderCollection(void) ITaskService_Release(service); } +static void test_GetTask(void) +{ + static WCHAR Wine[] = { '\\','W','i','n','e',0 }; + static WCHAR Wine_Task1[] = { '\\','W','i','n','e','\\','T','a','s','k','1',0 }; + static WCHAR Wine_Task2[] = { '\\','W','i','n','e','\\','T','a','s','k','2',0 }; + static WCHAR Task1[] = { 'T','a','s','k','1',0 }; + static WCHAR Task2[] = { 'T','a','s','k','2',0 }; + static const char xml1[] = + "<?xml version=\"1.0\"?>\n" + "<Task xmlns=\"http://schemas.microsoft.com/windows/2004/02/mit/task\">\n" + " <RegistrationInfo>\n" + " <Description>\"Task1\"</Description>\n" + " </RegistrationInfo>\n" + " <Settings>\n" + " <Enabled>false</Enabled>\n" + " <Hidden>false</Hidden>\n" + " </Settings>\n" + " <Actions>\n" + " <Exec>\n" + " <Command>\"task1.exe\"</Command>\n" + " </Exec>\n" + " </Actions>\n" + "</Task>\n"; + static const char xml2[] = + "<?xml version=\"1.0\"?>\n" + "<Task xmlns=\"http://schemas.microsoft.com/windows/2004/02/mit/task\">\n" + " <RegistrationInfo>\n" + " <Description>\"Task2\"</Description>\n" + " </RegistrationInfo>\n" + " <Settings>\n" + " <Enabled>true</Enabled>\n" + " <Hidden>true</Hidden>\n" + " </Settings>\n" + " <Actions>\n" + " <Exec>\n" + " <Command>\"task2.exe\"</Command>\n" + " </Exec>\n" + " </Actions>\n" + "</Task>\n"; + WCHAR xmlW[sizeof(xml1)]; + HRESULT hr; + BSTR bstr; + TASK_STATE state; + VARIANT_BOOL vbool; + VARIANT v_null; + ITaskService *service; + ITaskFolder *root, *folder; + IRegisteredTask *task1, *task2; + + hr = CoCreateInstance(&CLSID_TaskScheduler, NULL, CLSCTX_INPROC_SERVER, &IID_ITaskService, (void **)&service); + if (hr != S_OK) + { + win_skip("CoCreateInstance(CLSID_TaskScheduler) error %#x\n", hr); + return; + } + + V_VT(&v_null) = VT_NULL; + + hr = ITaskService_Connect(service, v_null, v_null, v_null, v_null); + ok(hr == S_OK, "Connect error %#x\n", hr); + + hr = ITaskService_GetFolder(service, NULL, &root); + ok(hr == S_OK, "GetFolder error %#x\n", hr); + + /* Just in case something was left from previous runs */ + ITaskFolder_DeleteTask(root, Wine_Task1, 0); + ITaskFolder_DeleteTask(root, Wine_Task2, 0); + ITaskFolder_DeleteFolder(root, Wine, 0); + + hr = ITaskFolder_CreateFolder(root, Wine, v_null, &folder); + ok(hr == S_OK, "CreateFolder error %#x\n", hr); + + MultiByteToWideChar(CP_ACP, 0, xml1, -1, xmlW, sizeof(xmlW)/sizeof(xmlW[0])); + + hr = ITaskFolder_RegisterTask(root, Wine_Task1, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, NULL); +todo_wine + ok(hr == S_OK, "RegisterTask error %#x\n", hr); + + hr = ITaskFolder_RegisterTask(root, Wine_Task1, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task1); +todo_wine + ok(hr == HRESULT_FROM_WIN32(ERROR_ALREADY_EXISTS), "expected ERROR_ALREADY_EXISTS, got %#x\n", hr); + + hr = ITaskFolder_RegisterTask(root, Wine_Task1, xmlW, TASK_CREATE_OR_UPDATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task1); +todo_wine + ok(hr == S_OK, "RegisterTask error %#x\n", hr); + /* FIXME: Remove once implemented */ + if (hr != S_OK) goto failed; + + hr = IRegisteredTask_get_Name(task1, NULL); + ok(hr == E_POINTER, "expected E_POINTER, got %#x\n", hr); + + hr = IRegisteredTask_get_Name(task1, &bstr); + ok(hr == S_OK, "get_Name error %#x\n", hr); + ok(!lstrcmpW(bstr, Task1), "expected Task1, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_Path(task1, &bstr); + ok(hr == S_OK, "get_Path error %#x\n", hr); + ok(!lstrcmpW(bstr, Wine_Task1), "expected \\Wine\\Task1, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_State(task1, &state); + ok(hr == S_OK, "get_State error %#x\n", hr); + ok(state == TASK_STATE_DISABLED, "expected TASK_STATE_DISABLED, got %d\n", state); + hr = IRegisteredTask_get_Enabled(task1, &vbool); + ok(hr == S_OK, "get_Enabled error %#x\n", hr); + ok(vbool == VARIANT_FALSE, "expected VARIANT_FALSE, got %d\n", vbool); + + IRegisteredTask_Release(task1); + + hr = ITaskFolder_RegisterTask(folder, Task1, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task2); + ok(hr == HRESULT_FROM_WIN32(ERROR_ALREADY_EXISTS), "expected ERROR_ALREADY_EXISTS, got %#x\n", hr); + + MultiByteToWideChar(CP_ACP, 0, xml2, -1, xmlW, sizeof(xmlW)/sizeof(xmlW[0])); + + hr = ITaskFolder_RegisterTask(folder, Task2, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task2); + ok(hr == S_OK, "RegisterTask error %#x\n", hr); + + hr = IRegisteredTask_get_Name(task2, &bstr); + ok(hr == S_OK, "get_Name error %#x\n", hr); + ok(!lstrcmpW(bstr, Task2), "expected Task2, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_Path(task2, &bstr); + ok(hr == S_OK, "get_Path error %#x\n", hr); + ok(!lstrcmpW(bstr, Wine_Task2), "expected \\Wine\\Task2, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_State(task2, &state); + ok(hr == S_OK, "get_State error %#x\n", hr); + ok(state == TASK_STATE_READY, "expected TASK_STATE_READY, got %d\n", state); + hr = IRegisteredTask_get_Enabled(task2, &vbool); + ok(hr == S_OK, "get_Enabled error %#x\n", hr); + ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool); + + IRegisteredTask_Release(task2); + + hr = ITaskFolder_GetTask(root, NULL, &task1); + ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr); + + hr = ITaskFolder_GetTask(root, Wine_Task1, NULL); + ok(hr == E_POINTER, "expected E_POINTER, got %#x\n", hr); + + hr = ITaskFolder_GetTask(root, Wine_Task1, &task1); + ok(hr == S_OK, "GetTask error %#x\n", hr); + + hr = IRegisteredTask_get_Name(task1, &bstr); + ok(hr == S_OK, "get_Name error %#x\n", hr); + ok(!lstrcmpW(bstr, Task1), "expected Task1, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_Path(task1, &bstr); + ok(hr == S_OK, "get_Path error %#x\n", hr); + ok(!lstrcmpW(bstr, Wine_Task1), "expected \\Wine\\Task1, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_State(task1, &state); + ok(hr == S_OK, "get_State error %#x\n", hr); + ok(state == TASK_STATE_DISABLED, "expected TASK_STATE_DISABLED, got %d\n", state); + hr = IRegisteredTask_get_Enabled(task1, &vbool); + ok(hr == S_OK, "get_Enabled error %#x\n", hr); + ok(vbool == VARIANT_FALSE, "expected VARIANT_FALSE, got %d\n", vbool); + + IRegisteredTask_Release(task1); + + hr = ITaskFolder_GetTask(folder, Task2, &task2); + ok(hr == S_OK, "GetTask error %#x\n", hr); + + hr = IRegisteredTask_get_Name(task2, &bstr); + ok(hr == S_OK, "get_Name error %#x\n", hr); + ok(!lstrcmpW(bstr, Task2), "expected Task2, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_Path(task2, &bstr); + ok(hr == S_OK, "get_Path error %#x\n", hr); + ok(!lstrcmpW(bstr, Wine_Task2), "expected \\Wine\\Task2, got %s\n", wine_dbgstr_w(bstr)); + SysFreeString(bstr); + hr = IRegisteredTask_get_State(task2, &state); + ok(hr == S_OK, "get_State error %#x\n", hr); + ok(state == TASK_STATE_READY, "expected TASK_STATE_READY, got %d\n", state); + hr = IRegisteredTask_get_Enabled(task2, &vbool); + ok(hr == S_OK, "get_Enabled error %#x\n", hr); + ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool); + + IRegisteredTask_Release(task2); + + hr = ITaskFolder_DeleteTask(root, Wine_Task1, 0); + ok(hr == S_OK, "DeleteTask error %#x\n", hr); + hr = ITaskFolder_DeleteTask(folder, Task2, 0); + ok(hr == S_OK, "DeleteTask error %#x\n", hr); + +failed: + ITaskFolder_Release(folder); + + hr = ITaskFolder_DeleteFolder(root, Wine, 0); + ok(hr == S_OK, "DeleteFolder error %#x\n", hr); + + ITaskFolder_Release(root); + ITaskService_Release(service); +} + START_TEST(scheduler) { OleInitialize(NULL); @@ -666,6 +860,7 @@ START_TEST(scheduler) test_Connect(); test_GetFolder(); test_FolderCollection(); + test_GetTask(); OleUninitialize(); }

1 0

Piotr Caban : msvcp70: Share the source code with msvcp90.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 40a6749ffdefcdfa7c2edb88c08f45d488a72a41 URL: http://source.winehq.org/git/wine.git/?a=commit;h=40a6749ffdefcdfa7c2edb88c… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Feb 6 14:33:37 2014 +0100 msvcp70: Share the source code with msvcp90. --- dlls/msvcp70/Makefile.in | 13 +- dlls/msvcp70/msvcp70.c | 37 - dlls/msvcp70/msvcp70.spec | 7433 ++++++++++++++++++++++----------------------- 3 files changed, 3728 insertions(+), 3755 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=40a6749ffdefcdfa7c2ed…

1 0

Piotr Caban : msvcp70: Don't forward bad_alloc implementation to msvcrt.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 2b1e2e64da244969748148fe31f66569cd307316 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2b1e2e64da244969748148fe3… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Feb 7 10:35:10 2014 +0100 msvcp70: Don't forward bad_alloc implementation to msvcrt. --- dlls/msvcp70/msvcp70.spec | 20 ++++++------ dlls/msvcp90/exception.c | 75 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+), 10 deletions(-) diff --git a/dlls/msvcp70/msvcp70.spec b/dlls/msvcp70/msvcp70.spec index fbff36a..88c6328 100644 --- a/dlls/msvcp70/msvcp70.spec +++ b/dlls/msvcp70/msvcp70.spec @@ -446,10 +446,10 @@ @ stub -arch=win64 ??0__non_rtti_object(a)std@@QEAA(a)AEBV01@@Z @ stub -arch=win32 ??0__non_rtti_object(a)std@@QAE(a)PBD@Z @ stub -arch=win64 ??0__non_rtti_object(a)std@@QEAA(a)PEBD@Z -@ thiscall -arch=i386 ??0bad_cast(a)std@@QAE(a)ABV01@@Z(ptr ptr) msvcrt.??0bad_cast@@QAE(a)ABV0@@Z -@ cdecl -arch=win64 ??0bad_cast(a)std@@QEAA(a)AEBV01@@Z(ptr ptr) msvcrt.??0bad_cast@@QEAA(a)AEBV0@@Z -@ thiscall -arch=i386 ??0bad_cast(a)std@@QAE(a)PBD@Z(ptr str) msvcrt.??0bad_cast@@QAE(a)PBD@Z -@ cdecl -arch=win64 ??0bad_cast(a)std@@QEAA(a)PEBD@Z(ptr str) msvcrt.??0bad_cast@@QEAA(a)PEBD@Z +@ thiscall -arch=i386 ??0bad_cast(a)std@@QAE(a)ABV01@@Z(ptr ptr) MSVCP_bad_cast_copy_ctor +@ cdecl -arch=win64 ??0bad_cast(a)std@@QEAA(a)AEBV01@@Z(ptr ptr) MSVCP_bad_cast_copy_ctor +@ thiscall -arch=i386 ??0bad_cast(a)std@@QAE(a)PBD@Z(ptr str) MSVCP_bad_cast_ctor +@ cdecl -arch=win64 ??0bad_cast(a)std@@QEAA(a)PEBD@Z(ptr str) MSVCP_bad_cast_ctor @ stub -arch=win32 ??0bad_typeid(a)std@@QAE(a)ABV01@@Z @ stub -arch=win64 ??0bad_typeid(a)std@@QEAA(a)AEBV01@@Z @ stub -arch=win32 ??0bad_typeid(a)std@@QAE(a)PBD@Z @@ -672,8 +672,8 @@ @ cdecl -arch=win64 ??1_Winit(a)std@@QEAA(a)XZ(ptr) _Winit_dtor @ stub -arch=win32 ??1__non_rtti_object(a)std@@UAE(a)XZ @ stub -arch=win64 ??1__non_rtti_object(a)std@@UEAA(a)XZ -@ thiscall -arch=i386 ??1bad_cast(a)std@@UAE(a)XZ(ptr) msvcrt.??1bad_cast@@UAE(a)XZ -@ cdecl -arch=win64 ??1bad_cast(a)std@@UEAA(a)XZ(ptr) msvcrt.??1bad_cast@@UEAA(a)XZ +@ thiscall -arch=i386 ??1bad_cast(a)std@@UAE(a)XZ(ptr) MSVCP_bad_cast_dtor +@ cdecl -arch=win64 ??1bad_cast(a)std@@UEAA(a)XZ(ptr) MSVCP_bad_cast_dtor @ stub -arch=win32 ??1bad_typeid(a)std@@UAE(a)XZ @ stub -arch=win64 ??1bad_typeid(a)std@@UEAA(a)XZ @ thiscall -arch=i386 ??1codecvt_base(a)std@@UAE(a)XZ(ptr) codecvt_base_dtor @@ -812,8 +812,8 @@ @ cdecl -arch=win64 ??4_Winit(a)std@@QEAAAEAV01(a)AEBV01@@Z(ptr ptr) _Winit_op_assign @ stub -arch=win32 ??4__non_rtti_object(a)std@@QAEAAV01(a)ABV01@@Z @ stub -arch=win64 ??4__non_rtti_object(a)std@@QEAAAEAV01(a)AEBV01@@Z -@ thiscall -arch=i386 ??4bad_cast(a)std@@QAEAAV01(a)ABV01@@Z(ptr ptr) msvcrt.??4bad_cast@@QAEAAV0(a)ABV0@@Z -@ cdecl -arch=win64 ??4bad_cast(a)std@@QEAAAEAV01(a)AEBV01@@Z(ptr ptr) msvcrt.??4bad_cast@@QEAAAEAV0(a)AEBV0@@Z +@ thiscall -arch=i386 ??4bad_cast(a)std@@QAEAAV01(a)ABV01@@Z(ptr ptr) MSVCP_bad_cast_opequals +@ cdecl -arch=win64 ??4bad_cast(a)std@@QEAAAEAV01(a)AEBV01@@Z(ptr ptr) MSVCP_bad_cast_opequals @ stub -arch=win32 ??4bad_typeid(a)std@@QAEAAV01(a)ABV01@@Z @ stub -arch=win64 ??4bad_typeid(a)std@@QEAAAEAV01(a)AEBV01@@Z @ thiscall -arch=win32 ??4ios_base(a)std@@QAEAAV01(a)ABV01@@Z(ptr ptr) ios_base_assign @@ -1726,8 +1726,8 @@ @ cdecl -arch=win64 ??_F_Locinfo(a)std@@QEAAXXZ(ptr) _Locinfo_ctor @ thiscall -arch=i386 ??_F_Timevec(a)std@@QAEXXZ(ptr) _Timevec_ctor @ cdecl -arch=win64 ??_F_Timevec(a)std@@QEAAXXZ(ptr) _Timevec_ctor -@ thiscall -arch=i386 ??_Fbad_cast(a)std@@QAEXXZ(ptr) msvcrt.??_Fbad_cast@@QAEXXZ -@ cdecl -arch=win64 ??_Fbad_cast(a)std@@QEAAXXZ(ptr) msvcrt.??_Fbad_cast@@QEAAXXZ +@ thiscall -arch=i386 ??_Fbad_cast(a)std@@QAEXXZ(ptr) MSVCP_bad_cast_default_ctor +@ cdecl -arch=win64 ??_Fbad_cast(a)std@@QEAAXXZ(ptr) MSVCP_bad_cast_default_ctor @ stub -arch=win32 ??_Fbad_typeid(a)std@@QAEXXZ @ stub -arch=win64 ??_Fbad_typeid(a)std@@QEAAXXZ @ thiscall -arch=i386 ??_Fcodecvt_base(a)std@@QAEXXZ(ptr) codecvt_base_ctor diff --git a/dlls/msvcp90/exception.c b/dlls/msvcp90/exception.c index dfd35d9..da3a4bf 100644 --- a/dlls/msvcp90/exception.c +++ b/dlls/msvcp90/exception.c @@ -41,6 +41,7 @@ extern const vtable_ptr MSVCP_out_of_range_vtable; extern const vtable_ptr MSVCP_invalid_argument_vtable; extern const vtable_ptr MSVCP_runtime_error_vtable; extern const vtable_ptr MSVCP_failure_vtable; +extern const vtable_ptr MSVCP_bad_cast_vtable; static void MSVCP_type_info_dtor(type_info * _this) { @@ -447,6 +448,75 @@ const char* __thiscall MSVCP_failure_what(failure *this) DEFINE_RTTI_DATA2(failure, 0, &runtime_error_rtti_base_descriptor, &exception_rtti_base_descriptor, ".?AVfailure(a)std@@") DEFINE_CXX_DATA2(failure, &runtime_error_cxx_type_info, &exception_cxx_type_info, MSVCP_runtime_error_dtor) +/* bad_cast class data */ +typedef exception bad_cast; + +DEFINE_THISCALL_WRAPPER(MSVCP_bad_cast_ctor, 8) +bad_cast* __thiscall MSVCP_bad_cast_ctor(bad_cast *this, const char *name) +{ + TRACE("%p %s\n", this, name); + MSVCP_exception_ctor(this, &name); + this->vtable = &MSVCP_bad_cast_vtable; + return this; +} + +DEFINE_THISCALL_WRAPPER(MSVCP_bad_cast_default_ctor,4) +bad_cast* __thiscall MSVCP_bad_cast_default_ctor(bad_cast *this) +{ + return MSVCP_bad_cast_ctor(this, "bad cast"); +} + +DEFINE_THISCALL_WRAPPER(MSVCP_bad_cast_copy_ctor, 8) +bad_cast* __thiscall MSVCP_bad_cast_copy_ctor(bad_cast *this, const bad_cast *rhs) +{ + TRACE("%p %p\n", this, rhs); + MSVCP_exception_copy_ctor(this, rhs); + this->vtable = &MSVCP_bad_cast_vtable; + return this; +} + +DEFINE_THISCALL_WRAPPER(MSVCP_bad_cast_dtor, 4) +void __thiscall MSVCP_bad_cast_dtor(bad_cast *this) +{ + TRACE("%p\n", this); + MSVCP_exception_dtor(this); +} + +DEFINE_THISCALL_WRAPPER(MSVCP_bad_cast_vector_dtor, 8) +void * __thiscall MSVCP_bad_cast_vector_dtor(bad_cast *this, unsigned int flags) +{ + TRACE("%p %x\n", this, flags); + if(flags & 2) { + /* we have an array, with the number of elements stored before the first object */ + INT_PTR i, *ptr = (INT_PTR *)this-1; + + for(i=*ptr-1; i>=0; i--) + MSVCP_bad_cast_dtor(this+i); + MSVCRT_operator_delete(ptr); + } else { + MSVCP_bad_cast_dtor(this); + if(flags & 1) + MSVCRT_operator_delete(this); + } + + return this; +} + +DEFINE_THISCALL_WRAPPER(MSVCP_bad_cast_opequals, 8) +bad_cast* __thiscall MSVCP_bad_cast_opequals(bad_cast *this, const bad_cast *rhs) +{ + TRACE("(%p %p)\n", this, rhs); + + if(this != rhs) { + MSVCP_exception_dtor(this); + MSVCP_exception_copy_ctor(this, rhs); + } + return this; +} + +DEFINE_RTTI_DATA1(bad_cast, 0, &exception_rtti_base_descriptor, ".?AVbad_cast(a)std@@") +DEFINE_CXX_DATA1(bad_cast, &exception_cxx_type_info, MSVCP_bad_cast_dtor) + /* ?_Nomemory(a)std@@YAXXZ */ void __cdecl _Nomemory(void) { @@ -528,6 +598,9 @@ void __asm_dummy_vtables(void) { __ASM_VTABLE(failure, VTABLE_ADD_FUNC(MSVCP_failure_vector_dtor) VTABLE_ADD_FUNC(MSVCP_failure_what)); + __ASM_VTABLE(bad_cast, + VTABLE_ADD_FUNC(MSVCP_bad_cast_vector_dtor) + VTABLE_ADD_FUNC(MSVCP_what_exception)); #ifndef __GNUC__ } #endif @@ -595,6 +668,7 @@ void init_exception(void *base) init_invalid_argument_rtti(base); init_runtime_error_rtti(base); init_failure_rtti(base); + init_bad_cast_rtti(base); init_exception_cxx(base); init_bad_alloc_cxx(base); @@ -604,5 +678,6 @@ void init_exception(void *base) init_invalid_argument_cxx(base); init_runtime_error_cxx(base); init_failure_cxx(base); + init_bad_cast_cxx(base); #endif }

1 0

Alexandre Julliard : msvcp90: Export _Xmem.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 01efe3f48f4dcdffa17ace07d8610b1092de31b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=01efe3f48f4dcdffa17ace07d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 7 11:39:53 2014 +0100 msvcp90: Export _Xmem. --- dlls/msvcp90/msvcp90.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msvcp90/msvcp90.spec b/dlls/msvcp90/msvcp90.spec index 8017819..a5116fa 100644 --- a/dlls/msvcp90/msvcp90.spec +++ b/dlls/msvcp90/msvcp90.spec @@ -3192,7 +3192,7 @@ @ stub -arch=win64 ?_Xinvalid(a)tr1@std@@YAXPEBD(a)Z @ cdecl ?_Xinvarg(a)_String_base@std@@SAXXZ() MSVCP__String_base_Xinvarg @ cdecl ?_Xlen(a)_String_base@std@@SAXXZ() MSVCP__String_base_Xlen -@ stub ?_Xmem(a)tr1@std@@YAXXZ +@ cdecl ?_Xmem(a)tr1@std@@YAXXZ() _Xmem @ stub ?_Xoutrange(a)tr1@std@@YAXXZ @ cdecl ?_Xran(a)_String_base@std@@SAXXZ() MSVCP__String_base_Xran @ cdecl ?_Xran(a)ctype_base@std@@KAXXZ() ctype_base__Xran

1 0

Alexandre Julliard : msvcp71: Fix argument types for some fstream constructors.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 8d963b3e19e8626a8400e9c7f7282e3fdb7c7c2a URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d963b3e19e8626a8400e9c7f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 7 11:44:45 2014 +0100 msvcp71: Fix argument types for some fstream constructors. --- dlls/msvcp71/msvcp71.spec | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/msvcp71/msvcp71.spec b/dlls/msvcp71/msvcp71.spec index 8e21fb7..13fb5fe 100644 --- a/dlls/msvcp71/msvcp71.spec +++ b/dlls/msvcp71/msvcp71.spec @@ -548,14 +548,14 @@ @ cdecl -arch=win64 ??0?$basic_fstream(a)DU?$char_traits(a)D@std@@@std@@QEAA(a)XZ(ptr long) basic_fstream_char_ctor @ thiscall -arch=win32 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QAE(a)PAU_iobuf@@@Z(ptr ptr long) basic_fstream_short_ctor_file @ cdecl -arch=win64 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QEAA(a)PEAU_iobuf@@@Z(ptr ptr long) basic_fstream_short_ctor_file -@ thiscall -arch=win32 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QAE(a)PBDHH@Z(ptr wstr long long long) basic_fstream_short_ctor_name -@ cdecl -arch=win64 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QEAA(a)PEBDHH@Z(ptr wstr long long long) basic_fstream_short_ctor_name +@ thiscall -arch=win32 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QAE(a)PBDHH@Z(ptr str long long long) basic_fstream_short_ctor_name +@ cdecl -arch=win64 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QEAA(a)PEBDHH@Z(ptr str long long long) basic_fstream_short_ctor_name @ thiscall -arch=win32 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QAE(a)XZ(ptr long) basic_fstream_short_ctor @ cdecl -arch=win64 ??0?$basic_fstream(a)GU?$char_traits(a)G@std@@@std@@QEAA(a)XZ(ptr long) basic_fstream_short_ctor @ thiscall -arch=win32 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QAE(a)PAU_iobuf@@@Z(ptr ptr long) basic_fstream_wchar_ctor_file @ cdecl -arch=win64 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QEAA(a)PEAU_iobuf@@@Z(ptr ptr long) basic_fstream_wchar_ctor_file -@ thiscall -arch=win32 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QAE(a)PBDHH@Z(ptr wstr long long long) basic_fstream_wchar_ctor_name -@ cdecl -arch=win64 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QEAA(a)PEBDHH@Z(ptr wstr long long long) basic_fstream_wchar_ctor_name +@ thiscall -arch=win32 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QAE(a)PBDHH@Z(ptr str long long long) basic_fstream_wchar_ctor_name +@ cdecl -arch=win64 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QEAA(a)PEBDHH@Z(ptr str long long long) basic_fstream_wchar_ctor_name @ thiscall -arch=win32 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QAE(a)XZ(ptr long) basic_fstream_wchar_ctor @ cdecl -arch=win64 ??0?$basic_fstream(a)_WU?$char_traits(a)_W@std@@@std@@QEAA(a)XZ(ptr long) basic_fstream_wchar_ctor @ thiscall -arch=win32 ??0?$basic_ifstream(a)DU?$char_traits(a)D@std@@@std@@QAE(a)PAU_iobuf@@@Z(ptr ptr long) basic_ifstream_char_ctor_file

1 0

Alexandre Julliard : msvcp71: Export some already implemented Getcat functions.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Module: wine Branch: master Commit: 21920f9f9c793b7c3e3a8201426b3352da628395 URL: http://source.winehq.org/git/wine.git/?a=commit;h=21920f9f9c793b7c3e3a82014… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 7 11:45:17 2014 +0100 msvcp71: Export some already implemented Getcat functions. --- dlls/msvcp71/msvcp71.spec | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/dlls/msvcp71/msvcp71.spec b/dlls/msvcp71/msvcp71.spec index 13fb5fe..3dc82a7 100644 --- a/dlls/msvcp71/msvcp71.spec +++ b/dlls/msvcp71/msvcp71.spec @@ -2049,18 +2049,18 @@ @ stub -arch=win64 ?_Getcat@?$moneypunct(a)_W$00(a)std@@SA_KPEAPEBVfacet(a)locale@2@@Z @ stub -arch=win32 ?_Getcat@?$moneypunct(a)_W$0A@@std@@SAIPAPBVfacet(a)locale@2@@Z @ stub -arch=win64 ?_Getcat@?$moneypunct(a)_W$0A@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$num_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$num_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$num_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$num_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$num_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$num_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$num_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$num_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$num_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$num_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z +@ cdecl -arch=win32 ?_Getcat@?$num_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) num_get_char__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$num_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) num_get_char__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$num_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) num_get_short__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$num_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) num_get_short__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) num_get_wchar__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) num_get_wchar__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$num_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) num_put_char__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$num_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) num_put_char__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$num_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) num_put_short__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$num_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) num_put_short__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$num_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) num_put_wchar__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$num_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) num_put_wchar__Getcat_old @ cdecl -arch=win32 ?_Getcat@?$numpunct(a)D@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) numpunct_char__Getcat_old @ cdecl -arch=win64 ?_Getcat@?$numpunct(a)D@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) numpunct_char__Getcat_old @ cdecl -arch=win32 ?_Getcat@?$numpunct(a)G@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) numpunct_short__Getcat_old @@ -2073,12 +2073,12 @@ @ stub -arch=win64 ?_Getcat@?$time_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z @ stub -arch=win32 ?_Getcat@?$time_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z @ stub -arch=win64 ?_Getcat@?$time_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$time_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$time_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$time_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$time_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z -@ stub -arch=win32 ?_Getcat@?$time_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z -@ stub -arch=win64 ?_Getcat@?$time_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z +@ cdecl -arch=win32 ?_Getcat@?$time_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) time_put_char__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$time_put(a)DV?$ostreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) time_put_char__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$time_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) time_put_short__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$time_put(a)GV?$ostreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) time_put_short__Getcat_old +@ cdecl -arch=win32 ?_Getcat@?$time_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SAIPAPBVfacet(a)locale@2@@Z(ptr) time_put_wchar__Getcat_old +@ cdecl -arch=win64 ?_Getcat@?$time_put(a)_WV?$ostreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@SA_KPEAPEBVfacet(a)locale@2@@Z(ptr) time_put_wchar__Getcat_old @ stub -arch=win32 ?_Getcat(a)facet@locale(a)std@@SAIPAPBV123@@Z @ stub -arch=win64 ?_Getcat(a)facet@locale(a)std@@SA_KPEAPEBV123@@Z @ thiscall -arch=win32 ?_Getcoll(a)_Locinfo@std@@QBE?AU_Collvec@@XZ(ptr ptr) _Locinfo__Getcoll

1 0

Dmitry Timoshkov : server: Add PROCESS_QUERY_LIMITED_INFORMATION to GENERIC_EXECUTE access mapping and appropriately change PROCESS_ALL_ACCESS.
by Alexandre Julliard 06 Feb '14

06 Feb '14

Module: wine Branch: master Commit: a0b08adbe40aaaaed0868af00f094123f7ab8b5d URL: http://source.winehq.org/git/wine.git/?a=commit;h=a0b08adbe40aaaaed0868af00… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Feb 6 20:48:13 2014 +0900 server: Add PROCESS_QUERY_LIMITED_INFORMATION to GENERIC_EXECUTE access mapping and appropriately change PROCESS_ALL_ACCESS. --- dlls/advapi32/tests/security.c | 1 - include/winnt.h | 2 +- server/process.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index 6225529..f3cc85d 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -5061,7 +5061,6 @@ static void test_process_access(void) "%d: expected %#x, got %#x\n", i, map[i].mapped, access); break; case GENERIC_EXECUTE: -todo_wine ok(access == map[i].mapped || access == (map[i].mapped | PROCESS_QUERY_LIMITED_INFORMATION | PROCESS_TERMINATE) /* Vista+ */, "%d: expected %#x, got %#x\n", i, map[i].mapped, access); break; diff --git a/include/winnt.h b/include/winnt.h index dd4ef63..ded7600 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -4542,7 +4542,7 @@ typedef enum tagSID_NAME_USE { #define PROCESS_QUERY_INFORMATION 0x0400 #define PROCESS_SUSPEND_RESUME 0x0800 #define PROCESS_QUERY_LIMITED_INFORMATION 0x1000 -#define PROCESS_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0xfff) +#define PROCESS_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0xffff) #define THREAD_TERMINATE 0x0001 #define THREAD_SUSPEND_RESUME 0x0002 diff --git a/server/process.c b/server/process.c index 41b5eca..ceaef64 100644 --- a/server/process.c +++ b/server/process.c @@ -451,7 +451,7 @@ static unsigned int process_map_access( struct object *obj, unsigned int access if (access & GENERIC_READ) access |= STANDARD_RIGHTS_READ | PROCESS_QUERY_INFORMATION | PROCESS_VM_READ; if (access & GENERIC_WRITE) access |= STANDARD_RIGHTS_WRITE | PROCESS_SET_QUOTA | PROCESS_SET_INFORMATION | PROCESS_SUSPEND_RESUME | PROCESS_VM_WRITE | PROCESS_DUP_HANDLE | PROCESS_CREATE_PROCESS | PROCESS_CREATE_THREAD | PROCESS_VM_OPERATION; - if (access & GENERIC_EXECUTE) access |= STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE | PROCESS_TERMINATE; + if (access & GENERIC_EXECUTE) access |= STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE | PROCESS_QUERY_LIMITED_INFORMATION | PROCESS_TERMINATE; if (access & GENERIC_ALL) access |= PROCESS_ALL_ACCESS; return access & ~(GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE | GENERIC_ALL); }

1 0