February 2014 - Wine-commits

Nikolay Sivov : oleaut32: Fix RecordCopy()/RecordClear() behavior.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: 60252ea65bbdf991938d919cd4c734809fb899bf URL: http://source.winehq.org/git/wine.git/?a=commit;h=60252ea65bbdf991938d919cd… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jan 30 22:53:13 2014 +0400 oleaut32: Fix RecordCopy()/RecordClear() behavior. --- dlls/oleaut32/recinfo.c | 75 +++++++++++++++++++++- dlls/oleaut32/tests/test_tlb.idl | 6 +- dlls/oleaut32/tests/typelib.c | 3 +- dlls/oleaut32/tests/vartype.c | 130 ++++++++++++++++++++++++++++++++++++++ dlls/oleaut32/usrmarshal.c | 3 +- dlls/oleaut32/variant.h | 2 +- 6 files changed, 212 insertions(+), 7 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=60252ea65bbdf991938d9…

1 0

Marcus Meissner : kernel32: Thread pool definitions and prototypes.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: cef12abd4f7496ee6c21e80b6bf58b981876135f URL: http://source.winehq.org/git/wine.git/?a=commit;h=cef12abd4f7496ee6c21e80b6… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Jan 29 20:13:27 2014 +0100 kernel32: Thread pool definitions and prototypes. --- include/winbase.h | 5 +++++ include/winnt.h | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 70 insertions(+) diff --git a/include/winbase.h b/include/winbase.h index 2d01c45..889f018 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -1572,6 +1572,8 @@ WINADVAPI BOOL WINAPI ClearEventLogW(HANDLE,LPCWSTR); #define ClearEventLog WINELIB_NAME_AW(ClearEventLog) WINADVAPI BOOL WINAPI CloseEventLog(HANDLE); WINBASEAPI BOOL WINAPI CloseHandle(HANDLE); +WINBASEAPI VOID WINAPI CloseThreadpool(PTP_POOL); +WINBASEAPI VOID WINAPI CloseThreadpoolWork(PTP_WORK); WINBASEAPI BOOL WINAPI CommConfigDialogA(LPCSTR,HWND,LPCOMMCONFIG); WINBASEAPI BOOL WINAPI CommConfigDialogW(LPCWSTR,HWND,LPCOMMCONFIG); #define CommConfigDialog WINELIB_NAME_AW(CommConfigDialog) @@ -1633,6 +1635,8 @@ WINBASEAPI HANDLE WINAPI CreateNamedPipeW(LPCWSTR,DWORD,DWORD,DWORD,DWORD,D #define CreateNamedPipe WINELIB_NAME_AW(CreateNamedPipe) WINBASEAPI BOOL WINAPI CreatePipe(PHANDLE,PHANDLE,LPSECURITY_ATTRIBUTES,DWORD); WINADVAPI BOOL WINAPI CreatePrivateObjectSecurity(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,BOOL,HANDLE,PGENERIC_MAPPING); +WINBASEAPI PTP_POOL WINAPI CreateThreadpool(PVOID); +WINBASEAPI PTP_WORK WINAPI CreateThreadpoolWork(PTP_WORK_CALLBACK,PVOID,PTP_CALLBACK_ENVIRON); WINBASEAPI BOOL WINAPI CreateProcessA(LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCSTR,LPSTARTUPINFOA,LPPROCESS_INFORMATION); WINBASEAPI BOOL WINAPI CreateProcessW(LPCWSTR,LPWSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION); #define CreateProcess WINELIB_NAME_AW(CreateProcess) @@ -2365,6 +2369,7 @@ WINBASEAPI VOID WINAPI Sleep(DWORD); WINBASEAPI BOOL WINAPI SleepConditionVariableCS(PCONDITION_VARIABLE,PCRITICAL_SECTION,DWORD); WINBASEAPI BOOL WINAPI SleepConditionVariableSRW(PCONDITION_VARIABLE,PSRWLOCK,DWORD,ULONG); WINBASEAPI DWORD WINAPI SleepEx(DWORD,BOOL); +WINBASEAPI VOID WINAPI SubmitThreadpoolWork(PTP_WORK); WINBASEAPI DWORD WINAPI SuspendThread(HANDLE); WINBASEAPI void WINAPI SwitchToFiber(LPVOID); WINBASEAPI BOOL WINAPI SwitchToThread(void); diff --git a/include/winnt.h b/include/winnt.h index f55f2fe..dd4ef63 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -5699,6 +5699,71 @@ typedef struct _SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX } DUMMYUNIONNAME; } SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX, *PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX; +/* Threadpool things */ +typedef DWORD TP_VERSION,*PTP_VERSION; + +typedef struct _TP_CALLBACK_INSTANCE TP_CALLBACK_INSTANCE,*PTP_CALLBACK_INSTANCE; + +typedef VOID (CALLBACK *PTP_SIMPLE_CALLBACK)(PTP_CALLBACK_INSTANCE,PVOID); + +typedef struct _TP_POOL TP_POOL,*PTP_POOL; + +typedef enum _TP_CALLBACK_PRIORITY +{ + TP_CALLBACK_PRIORITY_HIGH, + TP_CALLBACK_PRIORITY_NORMAL, + TP_CALLBACK_PRIORITY_LOW, + TP_CALLBACK_PRIORITY_INVALID, + TP_CALLBACK_PRIORITY_COUNT = TP_CALLBACK_PRIORITY_INVALID +} TP_CALLBACK_PRIORITY; + +typedef struct _TP_POOL_STACK_INFORMATION +{ + SIZE_T StackReserve; + SIZE_T StackCommit; +} TP_POOL_STACK_INFORMATION,*PTP_POOL_STACK_INFORMATION; + +typedef struct _TP_CLEANUP_GROUP TP_CLEANUP_GROUP,*PTP_CLEANUP_GROUP; + +typedef VOID (CALLBACK *PTP_CLEANUP_GROUP_CANCEL_CALLBACK)(PVOID,PVOID); + +typedef struct _TP_CALLBACK_ENVIRON_V1 +{ + TP_VERSION Version; + PTP_POOL Pool; + PTP_CLEANUP_GROUP CleanupGroup; + PTP_CLEANUP_GROUP_CANCEL_CALLBACK CleanupGroupCancelCallback; + PVOID RaceDll; + struct _ACTIVATION_CONTEXT* ActivationContext; + PTP_SIMPLE_CALLBACK FinalizationCallback; + union + { + DWORD Flags; + struct + { + DWORD LongFunction:1; + DWORD Persistent:1; + DWORD Private:30; + } s; + } u; +} TP_CALLBACK_ENVIRON_V1; + +typedef struct _TP_WORK TP_WORK, *PTP_WORK; +typedef struct _TP_TIMER TP_TIMER, *PTP_TIMER; + +typedef DWORD TP_WAIT_RESULT; +typedef struct _TP_WAIT TP_WAIT, *PTP_WAIT; + +typedef struct _TP_IO TP_IO, *PTP_IO; + +typedef TP_CALLBACK_ENVIRON_V1 TP_CALLBACK_ENVIRON, *PTP_CALLBACK_ENVIRON; + +typedef VOID (CALLBACK *PTP_WORK_CALLBACK)(PTP_CALLBACK_INSTANCE,PVOID,PTP_WORK); +typedef VOID (CALLBACK *PTP_TIMER_CALLBACK)(PTP_CALLBACK_INSTANCE,PVOID,PTP_TIMER); +typedef VOID (CALLBACK *PTP_WAIT_CALLBACK)(PTP_CALLBACK_INSTANCE,PVOID,PTP_WAIT,TP_WAIT_RESULT); +typedef VOID (CALLBACK *PTP_WIN32_IO_CALLBACK)(PTP_CALLBACK_INSTANCE,PVOID,PVOID,ULONG,ULONG_PTR,PTP_IO); + + NTSYSAPI BOOLEAN NTAPI RtlGetProductInfo(DWORD,DWORD,DWORD,DWORD,PDWORD); #ifdef __cplusplus

1 0

Marcus Meissner : kernel32/tests: Initial threadpool test.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: 5d58b92b73129459c82532d4d582bfc547d24e96 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5d58b92b73129459c82532d4d… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Jan 29 20:13:28 2014 +0100 kernel32/tests: Initial threadpool test. --- dlls/kernel32/tests/thread.c | 46 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c index 964ad02..6cbf383 100644 --- a/dlls/kernel32/tests/thread.c +++ b/dlls/kernel32/tests/thread.c @@ -19,7 +19,7 @@ */ /* Define _WIN32_WINNT to get SetThreadIdealProcessor on Windows */ -#define _WIN32_WINNT 0x0500 +#define _WIN32_WINNT 0x0600 #include <assert.h> #include <stdarg.h> @@ -82,6 +82,11 @@ static HANDLE (WINAPI *pCreateActCtxW)(PCACTCTXW); static BOOL (WINAPI *pDeactivateActCtx)(DWORD,ULONG_PTR); static BOOL (WINAPI *pGetCurrentActCtx)(HANDLE *); static void (WINAPI *pReleaseActCtx)(HANDLE); +static PTP_POOL (WINAPI *pCreateThreadpool)(PVOID); +static PTP_WORK (WINAPI *pCreateThreadpoolWork)(PTP_WORK_CALLBACK,PVOID,PTP_CALLBACK_ENVIRON); +static void (WINAPI *pSubmitThreadpoolWork)(PTP_WORK); +static void (WINAPI *pWaitForThreadpoolWorkCallbacks)(PTP_WORK,BOOL); +static void (WINAPI *pCloseThreadpoolWork)(PTP_WORK); static HANDLE create_target_process(const char *arg) { @@ -1599,6 +1604,37 @@ static void test_thread_actctx(void) pReleaseActCtx(context); } + +static void WINAPI threadpool_workcallback(PTP_CALLBACK_INSTANCE instance, void *context, PTP_WORK work) { + int *foo = (int*)context; + + (*foo)++; +} + + +static void test_threadpool(void) +{ + PTP_POOL pool; + PTP_WORK work; + int workcalled = 0; + + if (!pCreateThreadpool) { + todo_wine win_skip("thread pool apis not supported.\n"); + return; + } + + work = pCreateThreadpoolWork(threadpool_workcallback, &workcalled, NULL); + ok (work != NULL, "Error %d in CreateThreadpoolWork\n", GetLastError()); + pSubmitThreadpoolWork(work); + pWaitForThreadpoolWorkCallbacks(work, FALSE); + pCloseThreadpoolWork(work); + + ok (workcalled == 1, "expected work to be called once, got %d\n", workcalled); + + pool = pCreateThreadpool(NULL); + todo_wine ok (pool != NULL, "CreateThreadpool failed\n"); +} + static void init_funcs(void) { HMODULE hKernel32 = GetModuleHandleA("kernel32.dll"); @@ -1622,6 +1658,12 @@ static void init_funcs(void) X(DeactivateActCtx); X(GetCurrentActCtx); X(ReleaseActCtx); + + X(CreateThreadpool); + X(CreateThreadpoolWork); + X(SubmitThreadpoolWork); + X(WaitForThreadpoolWorkCallbacks); + X(CloseThreadpoolWork); #undef X } @@ -1687,4 +1729,6 @@ START_TEST(thread) test_thread_fpu_cw(); #endif test_thread_actctx(); + + test_threadpool(); }

1 0

André Hentschel : taskmgr: Avoid return type when the return value is not used.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: 810fbdd222a87022436b6eb8cebee627b9d00248 URL: http://source.winehq.org/git/wine.git/?a=commit;h=810fbdd222a87022436b6eb8c… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:25:09 2014 +0100 taskmgr: Avoid return type when the return value is not used. --- programs/taskmgr/graphctl.c | 3 +-- programs/taskmgr/graphctl.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/programs/taskmgr/graphctl.c b/programs/taskmgr/graphctl.c index 25632f8..6e83412 100644 --- a/programs/taskmgr/graphctl.c +++ b/programs/taskmgr/graphctl.c @@ -153,13 +153,12 @@ static void GraphCtrl_Resize(TGraphCtrl* this) this->m_dVerticalFactor = (double)this->m_nPlotHeight / this->m_dRange; } -BOOL GraphCtrl_Create(TGraphCtrl* this, HWND hWnd, HWND hParentWnd, UINT nID) +void GraphCtrl_Create(TGraphCtrl* this, HWND hWnd, HWND hParentWnd, UINT nID) { GraphCtrl_Init(this); this->m_hParentWnd = hParentWnd; this->m_hWnd = hWnd; GraphCtrl_Resize(this); - return 0; } static void GraphCtrl_InvalidateCtrl(TGraphCtrl* this) diff --git a/programs/taskmgr/graphctl.h b/programs/taskmgr/graphctl.h index cd7cec4..2adb494 100644 --- a/programs/taskmgr/graphctl.h +++ b/programs/taskmgr/graphctl.h @@ -89,8 +89,7 @@ extern WNDPROC OldGraphCtrlWndProc; double GraphCtrl_AppendPoint(TGraphCtrl* this, double dNewPoint0, double dNewPoint1, double dNewPoint2, double dNewPoint3); -BOOL GraphCtrl_Create(TGraphCtrl* this, HWND hWnd, HWND hParentWnd, -UINT nID); +void GraphCtrl_Create(TGraphCtrl* this, HWND hWnd, HWND hParentWnd, UINT nID); void GraphCtrl_Reset(TGraphCtrl* this); void GraphCtrl_SetBackgroundColor(TGraphCtrl* this, COLORREF color);

1 0

André Hentschel : advapi32: Use boolean return values in boolean functions.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: 929d9fb9f79b9ba0b7392215e51a152ec709d62c URL: http://source.winehq.org/git/wine.git/?a=commit;h=929d9fb9f79b9ba0b7392215e… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:25:44 2014 +0100 advapi32: Use boolean return values in boolean functions. --- dlls/advapi32/advapi.c | 2 +- dlls/advapi32/security.c | 2 +- dlls/advapi32/service.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/advapi32/advapi.c b/dlls/advapi32/advapi.c index 884b5d1..01ee4de 100644 --- a/dlls/advapi32/advapi.c +++ b/dlls/advapi32/advapi.c @@ -136,7 +136,7 @@ BOOL WINAPI GetCurrentHwProfileA(LPHW_PROFILE_INFOA pInfo) pInfo->dwDockInfo = DOCKINFO_DOCKED; strcpy(pInfo->szHwProfileGuid,"{12340001-1234-1234-1234-123456789012}"); strcpy(pInfo->szHwProfileName,"Wine Profile"); - return 1; + return TRUE; } /****************************************************************************** diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index ac0a941..3dc40dc 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -2399,7 +2399,7 @@ BOOL WINAPI NotifyBootConfigStatus( BOOL x1 ) { FIXME("(0x%08d):stub\n",x1); - return 1; + return TRUE; } /****************************************************************************** diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 5f3f15f..0047031 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -1858,7 +1858,7 @@ BOOL WINAPI GetServiceKeyNameW( SC_HANDLE hSCManager, LPCWSTR lpDisplayName, if (!hSCManager) { SetLastError( ERROR_INVALID_HANDLE ); - return 0; + return FALSE; } /* provide a buffer if the caller didn't */ @@ -1982,7 +1982,7 @@ BOOL WINAPI GetServiceDisplayNameW( SC_HANDLE hSCManager, LPCWSTR lpServiceName, if (!hSCManager) { SetLastError( ERROR_INVALID_HANDLE ); - return 0; + return FALSE; } /* provide a buffer if the caller didn't */

1 0

André Hentschel : comctl32: Use boolean return values in boolean functions.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: 1776ded8e68f48546337705d30392d8ace7dd053 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1776ded8e68f48546337705d3… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:26:05 2014 +0100 comctl32: Use boolean return values in boolean functions. --- dlls/comctl32/datetime.c | 2 +- dlls/comctl32/updown.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c index d13b50c..9f91fd3 100644 --- a/dlls/comctl32/datetime.c +++ b/dlls/comctl32/datetime.c @@ -198,7 +198,7 @@ static BOOL DATETIME_IsDateInValidRange(const DATETIME_INFO *infoPtr, const SYST static BOOL DATETIME_SetSystemTime (DATETIME_INFO *infoPtr, DWORD flag, const SYSTEMTIME *systime) { - if (!systime) return 0; + if (!systime) return FALSE; TRACE("%04d/%02d/%02d %02d:%02d:%02d\n", systime->wYear, systime->wMonth, systime->wDay, diff --git a/dlls/comctl32/updown.c b/dlls/comctl32/updown.c index 23a633e..28dd5e3 100644 --- a/dlls/comctl32/updown.c +++ b/dlls/comctl32/updown.c @@ -354,7 +354,7 @@ static BOOL UPDOWN_SetBuddyInt (const UPDOWN_INFO *infoPtr) /* if nothing changed exit earlier */ GetWindowTextW(infoPtr->Buddy, txt_old, sizeof(txt_old)/sizeof(WCHAR)); - if (lstrcmpiW(txt_old, txt) == 0) return 0; + if (lstrcmpiW(txt_old, txt) == 0) return FALSE; return SetWindowTextW(infoPtr->Buddy, txt); }

1 0

André Hentschel : wininet: Use boolean return value in boolean function.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: c8426495fcf9db0d5cfb73d7d8080d1a82c36e6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=c8426495fcf9db0d5cfb73d7d… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:28:25 2014 +0100 wininet: Use boolean return value in boolean function. --- dlls/wininet/internet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index 3cf3ea6..a37606a 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -1765,7 +1765,7 @@ BOOL WINAPI InternetCrackUrlW(LPCWSTR lpszUrl_orig, DWORD dwUrlLength_orig, DWOR if(!found_colon){ SetLastError(ERROR_INTERNET_UNRECOGNIZED_SCHEME); - return 0; + return FALSE; } lpUC->nScheme = INTERNET_SCHEME_UNKNOWN;

1 0

André Hentschel : user32: Use boolean return values in boolean functions.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: bdc9b147b948b3476815c52f7fc53f4c29494800 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bdc9b147b948b3476815c52f7… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:28:27 2014 +0100 user32: Use boolean return values in boolean functions. --- dlls/user32/input.c | 2 +- dlls/user32/nonclient.c | 2 +- dlls/user32/painting.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/user32/input.c b/dlls/user32/input.c index 078fa49..457e67c 100644 --- a/dlls/user32/input.c +++ b/dlls/user32/input.c @@ -266,7 +266,7 @@ BOOL WINAPI GetCursorInfo( PCURSORINFO pci ) { BOOL ret; - if (!pci) return 0; + if (!pci) return FALSE; SERVER_START_REQ( get_thread_input ) { diff --git a/dlls/user32/nonclient.c b/dlls/user32/nonclient.c index d8d0807..5ea26dc 100644 --- a/dlls/user32/nonclient.c +++ b/dlls/user32/nonclient.c @@ -360,7 +360,7 @@ BOOL WINAPI DrawCaptionTempW (HWND hwnd, HDC hdc, const RECT *rect, HFONT hFont, if (uFlags & 0x2000) FIXME("undocumented flag (0x2000)!\n"); - return 0; + return FALSE; } diff --git a/dlls/user32/painting.c b/dlls/user32/painting.c index 11447da..63e09c5 100644 --- a/dlls/user32/painting.c +++ b/dlls/user32/painting.c @@ -486,7 +486,7 @@ static BOOL CALLBACK dc_hook( HDC hDC, WORD code, DWORD_PTR data, LPARAM lParam TRACE("hDC = %p, %u\n", hDC, code); - if (!dce) return 0; + if (!dce) return FALSE; assert( dce->hdc == hDC ); switch( code )

1 0

André Hentschel : gdi16: Use boolean return value in boolean function.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: f43234289dda0b547cd083e7aa88c380b4742ab4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f43234289dda0b547cd083e7a… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:28:31 2014 +0100 gdi16: Use boolean return value in boolean function. --- dlls/gdi.exe16/gdi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/gdi.exe16/gdi.c b/dlls/gdi.exe16/gdi.c index c2193a9..8ee37d7 100644 --- a/dlls/gdi.exe16/gdi.c +++ b/dlls/gdi.exe16/gdi.c @@ -2907,7 +2907,7 @@ BOOL16 WINAPI IsGDIObject16( HGDIOBJ16 handle16 ) UINT type = GetObjectType( HGDIOBJ_32( handle16 )); - if (type >= sizeof(type_map)/sizeof(type_map[0])) return 0; + if (type >= sizeof(type_map)/sizeof(type_map[0])) return FALSE; return type_map[type]; }

1 0

André Hentschel : msi: Use boolean return value in boolean function.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Module: wine Branch: master Commit: 3c1ca4e548a5249060515fda9e241f4643fedc3b URL: http://source.winehq.org/git/wine.git/?a=commit;h=3c1ca4e548a5249060515fda9… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Jan 29 22:28:29 2014 +0100 msi: Use boolean return value in boolean function. --- dlls/msi/record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msi/record.c b/dlls/msi/record.c index 3c1cf00..88d94a9 100644 --- a/dlls/msi/record.c +++ b/dlls/msi/record.c @@ -378,7 +378,7 @@ BOOL WINAPI MsiRecordIsNull( MSIHANDLE handle, UINT iField ) rec = msihandle2msiinfo( handle, MSIHANDLETYPE_RECORD ); if( !rec ) - return 0; + return FALSE; msiobj_lock( &rec->hdr ); ret = MSI_RecordIsNull( rec, iField ); msiobj_unlock( &rec->hdr );

1 0