April 2014 - Wine-commits - list.winehq.org

Hans Leidekker : wbemprox: Implement more properties of Win32_OperatingSystem.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: b67bfbb8b491fdce8b1cdea1619f152bc10a6388 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b67bfbb8b491fdce8b1cdea16… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Apr 3 12:34:47 2014 +0200 wbemprox: Implement more properties of Win32_OperatingSystem. --- dlls/wbemprox/builtin.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 7138154..54f44c5 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -107,6 +107,8 @@ static const WCHAR prop_bootableW[] = {'B','o','o','t','a','b','l','e',0}; static const WCHAR prop_bootpartitionW[] = {'B','o','o','t','P','a','r','t','i','t','i','o','n',0}; +static const WCHAR prop_buildnumberW[] = + {'B','u','i','l','d','N','u','m','b','e','r',0}; static const WCHAR prop_capacityW[] = {'C','a','p','a','c','i','t','y',0}; static const WCHAR prop_captionW[] = @@ -165,6 +167,8 @@ static const WCHAR prop_identificationcodeW[] = {'I','d','e','n','t','i','f','i','c','a','t','i','o','n','C','o','d','e',0}; static const WCHAR prop_indexW[] = {'I','n','d','e','x',0}; +static const WCHAR prop_installdateW[] = + {'I','n','s','t','a','l','l','D','a','t','e',0}; static const WCHAR prop_interfaceindexW[] = {'I','n','t','e','r','f','a','c','e','I','n','d','e','x',0}; static const WCHAR prop_intvalueW[] = @@ -372,10 +376,12 @@ static const struct column col_networkadapterconfig[] = }; static const struct column col_os[] = { + { prop_buildnumberW, CIM_STRING }, { prop_captionW, CIM_STRING }, { prop_codesetW, CIM_STRING|COL_FLAG_DYNAMIC }, { prop_countrycodeW, CIM_STRING|COL_FLAG_DYNAMIC }, { prop_csdversionW, CIM_STRING }, + { prop_installdateW, CIM_DATETIME }, { prop_lastbootuptimeW, CIM_DATETIME|COL_FLAG_DYNAMIC }, { prop_localdatetimeW, CIM_DATETIME|COL_FLAG_DYNAMIC }, { prop_localeW, CIM_STRING|COL_FLAG_DYNAMIC }, @@ -384,6 +390,7 @@ static const struct column col_os[] = { prop_oslanguageW, CIM_UINT32, VT_I4 }, { prop_osproductsuiteW, CIM_UINT32, VT_I4 }, { prop_ostypeW, CIM_UINT16, VT_I4 }, + { prop_serialnumberW, CIM_STRING }, { prop_servicepackmajorW, CIM_UINT16, VT_I4 }, { prop_servicepackminorW, CIM_UINT16, VT_I4 }, { prop_suitemaskW, CIM_UINT32, VT_I4 }, @@ -534,20 +541,26 @@ static const WCHAR networkadapter_pnpdeviceidW[]= {'P','C','I','\\','V','E','N','_','8','0','8','6','&','D','E','V','_','1','0','0','E','&', 'S','U','B','S','Y','S','_','0','0','1','E','8','0','8','6','&','R','E','V','_','0','2','\\', '3','&','2','6','7','A','6','1','6','A','&','1','&','1','8',0}; +static const WCHAR os_32bitW[] = + {'3','2','-','b','i','t',0}; +static const WCHAR os_64bitW[] = + {'6','4','-','b','i','t',0}; +static const WCHAR os_buildnumberW[] = + {'2','6','0','0',0}; static const WCHAR os_captionW[] = {'M','i','c','r','o','s','o','f','t',' ','W','i','n','d','o','w','s',' ','X','P',' ', 'V','e','r','s','i','o','n',' ','=',' ','5','.','1','.','2','6','0','0',0}; static const WCHAR os_csdversionW[] = {'S','e','r','v','i','c','e',' ','P','a','c','k',' ','3',0}; -static const WCHAR os_32bitW[] = - {'3','2','-','b','i','t',0}; -static const WCHAR os_64bitW[] = - {'6','4','-','b','i','t',0}; +static const WCHAR os_installdateW[] = + {'2','0','1','4','0','1','0','1','0','0','0','0','0','0','.','0','0','0','0','0','0','+','0','0','0',0}; static const WCHAR os_nameW[] = {'M','i','c','r','o','s','o','f','t',' ','W','i','n','d','o','w','s',' ','X','P',' ', 'P','r','o','f','e','s','s','i','o','n','a','l','|','C',':','\\','W','I','N','D','O','W','S', '|','\\','D','e','v','i','c','e','\\','H','a','r','d','d','i','s','k','0', '\\','P','a','r','t','i','t','i','o','n','1',0}; +static const WCHAR os_serialnumberW[] = + {'1','2','3','4','5','-','O','E','M','-','1','2','3','4','5','6','7','-','1','2','3','4','5',0}; static const WCHAR os_versionW[] = {'5','.','1','.','2','6','0','0',0}; static const WCHAR physicalmedia_tagW[] = @@ -661,10 +674,12 @@ struct record_networkadapterconfig }; struct record_operatingsystem { + const WCHAR *buildnumber; const WCHAR *caption; const WCHAR *codeset; const WCHAR *countrycode; const WCHAR *csdversion; + const WCHAR *installdate; const WCHAR *lastbootuptime; const WCHAR *localdatetime; const WCHAR *locale; @@ -673,6 +688,7 @@ struct record_operatingsystem UINT32 oslanguage; UINT32 osproductsuite; UINT16 ostype; + const WCHAR *serialnumber; UINT16 servicepackmajor; UINT16 servicepackminor; UINT32 suitemask; @@ -2027,10 +2043,12 @@ static enum fill_status fill_os( struct table *table, const struct expr *cond ) if (!resize_table( table, 1, sizeof(*rec) )) return FILL_STATUS_FAILED; rec = (struct record_operatingsystem *)table->data; + rec->buildnumber = os_buildnumberW; rec->caption = os_captionW; rec->codeset = get_codeset(); rec->countrycode = get_countrycode(); rec->csdversion = os_csdversionW; + rec->installdate = os_installdateW; rec->lastbootuptime = get_lastbootuptime(); rec->localdatetime = get_localdatetime(); rec->locale = get_locale(); @@ -2039,6 +2057,7 @@ static enum fill_status fill_os( struct table *table, const struct expr *cond ) rec->oslanguage = GetSystemDefaultLangID(); rec->osproductsuite = 2461140; /* Windows XP Professional */ rec->ostype = 18; /* WINNT */ + rec->serialnumber = os_serialnumberW; rec->servicepackmajor = 3; rec->servicepackminor = 0; rec->suitemask = 272; /* Single User + Terminal */

1 0

Hans Leidekker : wbemprox: Implement more properties of Win32_DiskDrive.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: c4309a50775bccb8e2d89f96019c65f519743751 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4309a50775bccb8e2d89f960… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Apr 3 12:35:25 2014 +0200 wbemprox: Implement more properties of Win32_DiskDrive. --- dlls/wbemprox/builtin.c | 108 +++++++++++++++++++++++++++++++++++------------ 1 file changed, 82 insertions(+), 26 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 54f44c5..51c3261 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -171,6 +171,8 @@ static const WCHAR prop_installdateW[] = {'I','n','s','t','a','l','l','D','a','t','e',0}; static const WCHAR prop_interfaceindexW[] = {'I','n','t','e','r','f','a','c','e','I','n','d','e','x',0}; +static const WCHAR prop_interfacetypeW[] = + {'I','n','t','e','r','f','a','c','e','T','y','p','e',0}; static const WCHAR prop_intvalueW[] = {'I','n','t','e','g','e','r','V','a','l','u','e',0}; static const WCHAR prop_ipconnectionmetricW[] = @@ -324,12 +326,14 @@ static const struct column col_directory[] = }; static const struct column col_diskdrive[] = { - { prop_deviceidW, CIM_STRING|COL_FLAG_KEY }, - { prop_indexW, CIM_UINT32, VT_I4 }, - { prop_manufacturerW, CIM_STRING }, - { prop_mediatypeW, CIM_STRING }, - { prop_modelW, CIM_STRING }, - { prop_serialnumberW, CIM_STRING } + { prop_deviceidW, CIM_STRING|COL_FLAG_DYNAMIC|COL_FLAG_KEY }, + { prop_indexW, CIM_UINT32, VT_I4 }, + { prop_interfacetypeW, CIM_STRING }, + { prop_manufacturerW, CIM_STRING }, + { prop_mediatypeW, CIM_STRING }, + { prop_modelW, CIM_STRING }, + { prop_serialnumberW, CIM_STRING }, + { prop_sizeW, CIM_UINT64 } }; static const struct column col_diskpartition[] = { @@ -527,12 +531,14 @@ static const WCHAR compsys_manufacturerW[] = {'T','h','e',' ','W','i','n','e',' ','P','r','o','j','e','c','t',0}; static const WCHAR compsys_modelW[] = {'W','i','n','e',0}; -static const WCHAR diskdrive_deviceidW[] = - {'\\','\\','\\','\\','.','\\','\\','P','H','Y','S','I','C','A','L','D','R','I','V','E','0',0}; +static const WCHAR diskdrive_interfacetypeW[] = + {'I','D','E',0}; static const WCHAR diskdrive_manufacturerW[] = {'(','S','t','a','n','d','a','r','d',' ','d','i','s','k',' ','d','r','i','v','e','s',')',0}; -static const WCHAR diskdrive_mediatypeW[] = +static const WCHAR diskdrive_mediatype_fixedW[] = {'F','i','x','e','d',' ','h','a','r','d',' ','d','i','s','k',0}; +static const WCHAR diskdrive_mediatype_removableW[] = + {'R','e','m','o','v','a','b','l','e',' ','m','e','d','i','a',0}; static const WCHAR diskdrive_modelW[] = {'W','i','n','e',' ','D','i','s','k',' ','D','r','i','v','e',0}; static const WCHAR diskdrive_serialW[] = @@ -624,10 +630,12 @@ struct record_diskdrive { const WCHAR *device_id; UINT32 index; + const WCHAR *interfacetype; const WCHAR *manufacturer; const WCHAR *mediatype; - const WCHAR *name; + const WCHAR *model; const WCHAR *serialnumber; + UINT64 size; }; struct record_diskpartition { @@ -802,11 +810,6 @@ static const struct record_bios data_bios[] = { bios_descriptionW, bios_descriptionW, bios_manufacturerW, bios_releasedateW, bios_serialnumberW, bios_smbiosbiosversionW, bios_versionW } }; -static const struct record_diskdrive data_diskdrive[] = -{ - { diskdrive_deviceidW, 0, diskdrive_manufacturerW, diskdrive_mediatypeW, diskdrive_modelW, - diskdrive_serialW } -}; static const struct record_param data_param[] = { { class_processW, method_getownerW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, @@ -1474,16 +1477,6 @@ done: return status; } -static WCHAR *get_filesystem( const WCHAR *root ) -{ - static const WCHAR ntfsW[] = {'N','T','F','S',0}; - WCHAR buffer[MAX_PATH + 1]; - - if (GetVolumeInformationW( root, NULL, 0, NULL, NULL, NULL, buffer, MAX_PATH + 1 )) - return heap_strdupW( buffer ); - return heap_strdupW( ntfsW ); -} - static UINT64 get_freespace( const WCHAR *dir, UINT64 *disksize ) { WCHAR root[] = {'\\','\\','.','\\','A',':',0}; @@ -1505,6 +1498,69 @@ static UINT64 get_freespace( const WCHAR *dir, UINT64 *disksize ) return free.QuadPart; } +static enum fill_status fill_diskdrive( struct table *table, const struct expr *cond ) +{ + static const WCHAR fmtW[] = + {'\\','\\','\\','\\','.','\\','\\','P','H','Y','S','I','C','A','L','D','R','I','V','E','%','u',0}; + WCHAR device_id[sizeof(fmtW)/sizeof(fmtW[0]) + 10], root[] = {'A',':','\\',0}; + struct record_diskdrive *rec; + UINT i, row = 0, offset = 0, index = 0, type; + UINT64 size = 1024 * 1024 * 1024; + DWORD drives = GetLogicalDrives(); + enum fill_status status = FILL_STATUS_UNFILTERED; + + if (!resize_table( table, 2, sizeof(*rec) )) return FILL_STATUS_FAILED; + + for (i = 0; i < sizeof(drives); i++) + { + if (drives & (1 << i)) + { + root[0] = 'A' + i; + type = GetDriveTypeW( root ); + if (type != DRIVE_FIXED && type != DRIVE_REMOVABLE) + continue; + + if (!resize_table( table, row + 1, sizeof(*rec) )) return FILL_STATUS_FAILED; + + rec = (struct record_diskdrive *)(table->data + offset); + sprintfW( device_id, fmtW, index ); + rec->device_id = heap_strdupW( device_id ); + rec->index = index; + rec->interfacetype = diskdrive_interfacetypeW; + rec->manufacturer = diskdrive_manufacturerW; + if (type == DRIVE_FIXED) + rec->mediatype = diskdrive_mediatype_fixedW; + else + rec->mediatype = diskdrive_mediatype_removableW; + rec->model = diskdrive_modelW; + rec->serialnumber = diskdrive_serialW; + get_freespace( root, &size ); + rec->size = size; + if (!match_row( table, row, cond, &status )) + { + free_row_values( table, row ); + continue; + } + offset += sizeof(*rec); + index++; + row++; + } + } + TRACE("created %u rows\n", row); + table->num_rows = row; + return status; +} + +static WCHAR *get_filesystem( const WCHAR *root ) +{ + static const WCHAR ntfsW[] = {'N','T','F','S',0}; + WCHAR buffer[MAX_PATH + 1]; + + if (GetVolumeInformationW( root, NULL, 0, NULL, NULL, NULL, buffer, MAX_PATH + 1 )) + return heap_strdupW( buffer ); + return heap_strdupW( ntfsW ); +} + static enum fill_status fill_diskpartition( struct table *table, const struct expr *cond ) { static const WCHAR fmtW[] = @@ -2311,7 +2367,7 @@ static struct table builtin_classes[] = { class_compsysW, SIZEOF(col_compsys), col_compsys, 0, 0, NULL, fill_compsys }, { class_datafileW, SIZEOF(col_datafile), col_datafile, 0, 0, NULL, fill_datafile }, { class_directoryW, SIZEOF(col_directory), col_directory, 0, 0, NULL, fill_directory }, - { class_diskdriveW, SIZEOF(col_diskdrive), col_diskdrive, SIZEOF(data_diskdrive), 0, (BYTE *)data_diskdrive }, + { class_diskdriveW, SIZEOF(col_diskdrive), col_diskdrive, 0, 0, NULL, fill_diskdrive }, { class_diskpartitionW, SIZEOF(col_diskpartition), col_diskpartition, 0, 0, NULL, fill_diskpartition }, { class_logicaldiskW, SIZEOF(col_logicaldisk), col_logicaldisk, 0, 0, NULL, fill_logicaldisk }, { class_logicaldisk2W, SIZEOF(col_logicaldisk), col_logicaldisk, 0, 0, NULL, fill_logicaldisk },

1 0

Hans Leidekker : wbemprox: Implement Win32_CDROMDrive.MediaType.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: 90c7893e0e1727c449ac0df924d70f0a16cbe606 URL: http://source.winehq.org/git/wine.git/?a=commit;h=90c7893e0e1727c449ac0df92… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Apr 3 12:35:53 2014 +0200 wbemprox: Implement Win32_CDROMDrive.MediaType. --- dlls/wbemprox/builtin.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 51c3261..87511be 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -299,6 +299,7 @@ static const struct column col_cdromdrive[] = { { prop_deviceidW, CIM_STRING|COL_FLAG_KEY }, { prop_driveW, CIM_STRING|COL_FLAG_DYNAMIC }, + { prop_mediatypeW, CIM_STRING }, { prop_nameW, CIM_STRING }, { prop_pnpdeviceidW, CIM_STRING } }; @@ -516,6 +517,8 @@ static const WCHAR bios_smbiosbiosversionW[] = {'W','i','n','e',0}; static const WCHAR bios_versionW[] = {'W','I','N','E',' ',' ',' ','-',' ','1',0}; +static const WCHAR cdromdrive_mediatypeW[] = + {'C','D','-','R','O','M',0}; static const WCHAR cdromdrive_nameW[] = {'W','i','n','e',' ','C','D','-','R','O','M',' ','A','T','A',' ','D','e','v','i','c','e',0}; static const WCHAR cdromdrive_pnpdeviceidW[]= @@ -601,6 +604,7 @@ struct record_cdromdrive { const WCHAR *device_id; const WCHAR *drive; + const WCHAR *mediatype; const WCHAR *name; const WCHAR *pnpdevice_id; }; @@ -920,6 +924,7 @@ static enum fill_status fill_cdromdrive( struct table *table, const struct expr rec->device_id = cdromdrive_pnpdeviceidW; sprintfW( drive, fmtW, 'A' + i ); rec->drive = heap_strdupW( drive ); + rec->mediatype = cdromdrive_mediatypeW; rec->name = cdromdrive_nameW; rec->pnpdevice_id = cdromdrive_pnpdeviceidW; if (!match_row( table, row, cond, &status ))

1 0

Hans Leidekker : wbemprox: Implement Win32_VideoController.Availability.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: ec3417e290e59c9cf2d3ef70fec3ad852c0866f8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ec3417e290e59c9cf2d3ef70f… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Apr 3 12:36:33 2014 +0200 wbemprox: Implement Win32_VideoController.Availability. --- dlls/wbemprox/builtin.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 87511be..8f4b362 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -103,6 +103,8 @@ static const WCHAR prop_adaptertypeW[] = {'A','d','a','p','t','e','r','T','y','p','e',0}; static const WCHAR prop_addresswidthW[] = {'A','d','d','r','e','s','s','W','i','d','t','h',0}; +static const WCHAR prop_availabilityW[] = + {'A','v','a','i','l','a','b','i','l','i','t','y',0}; static const WCHAR prop_bootableW[] = {'B','o','o','t','a','b','l','e',0}; static const WCHAR prop_bootpartitionW[] = @@ -490,6 +492,7 @@ static const struct column col_videocontroller[] = { { prop_adapterdactypeW, CIM_STRING }, { prop_adapterramW, CIM_UINT32, VT_I4 }, + { prop_availabilityW, CIM_UINT16 }, { prop_currentbitsperpixelW, CIM_UINT32 }, { prop_currenthorizontalresW, CIM_UINT32 }, { prop_currentverticalresW, CIM_UINT32 }, @@ -795,6 +798,7 @@ struct record_videocontroller { const WCHAR *adapter_dactype; UINT32 adapter_ram; + UINT16 availability; UINT32 current_bitsperpixel; UINT32 current_horizontalres; UINT32 current_verticalres; @@ -2346,6 +2350,7 @@ done: rec = (struct record_videocontroller *)table->data; rec->adapter_dactype = videocontroller_dactypeW; rec->adapter_ram = vidmem; + rec->availability = 3; /* Running or Full Power */ rec->current_bitsperpixel = get_bits_per_pixel( &hres, &vres ); rec->current_horizontalres = hres; rec->current_verticalres = vres;

1 0

Nikolay Sivov : scrrun: Implement ReadAll().
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: c927336c5a5da95efe6159c689b91b71ac5b6457 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c927336c5a5da95efe6159c68… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Apr 3 17:34:25 2014 +0400 scrrun: Implement ReadAll(). --- dlls/scrrun/filesystem.c | 119 ++++++++++++++++++++++++++++---- dlls/scrrun/scrrun.idl | 1 + dlls/scrrun/tests/filesystem.c | 149 +++++++++++++++++++++++++++++++++++++++- dlls/scrrun/tests/scrrun.idl | 1 + 4 files changed, 256 insertions(+), 14 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c927336c5a5da95efe615…

1 0

Nikolay Sivov : scrrun: Implement Read().
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: cc8ceb51777ace14855e69db01b93f1c5ba34647 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cc8ceb51777ace14855e69db0… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Apr 3 17:34:52 2014 +0400 scrrun: Implement Read(). --- dlls/scrrun/filesystem.c | 148 ++++++++++++++++++++++++++------------- dlls/scrrun/tests/filesystem.c | 149 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 248 insertions(+), 49 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=cc8ceb51777ace14855e6…

1 0

Nikolay Sivov : scrrun: Implement FreeSpace() for a drive.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: ba232c8f699aa2f41f35d557e787a595f1d22810 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ba232c8f699aa2f41f35d557e… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Apr 3 17:35:08 2014 +0400 scrrun: Implement FreeSpace() for a drive. --- dlls/scrrun/filesystem.c | 14 ++++++++++++-- dlls/scrrun/tests/filesystem.c | 9 +++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/scrrun/filesystem.c b/dlls/scrrun/filesystem.c index 35fd3a2..b04637c 100644 --- a/dlls/scrrun/filesystem.c +++ b/dlls/scrrun/filesystem.c @@ -908,8 +908,18 @@ static HRESULT WINAPI drive_get_AvailableSpace(IDrive *iface, VARIANT *v) static HRESULT WINAPI drive_get_FreeSpace(IDrive *iface, VARIANT *v) { struct drive *This = impl_from_IDrive(iface); - FIXME("(%p)->(%p): stub\n", This, v); - return E_NOTIMPL; + ULARGE_INTEGER freespace; + + TRACE("(%p)->(%p)\n", This, v); + + if (!v) + return E_POINTER; + + if (!GetDiskFreeSpaceExW(This->root, &freespace, NULL, NULL)) + return E_FAIL; + + V_VT(v) = VT_R8; + return VarR8FromUI8(freespace.QuadPart, &V_R8(v)); } static HRESULT WINAPI drive_get_TotalSize(IDrive *iface, VARIANT *v) diff --git a/dlls/scrrun/tests/filesystem.c b/dlls/scrrun/tests/filesystem.c index a53aa9d..c258a0f 100644 --- a/dlls/scrrun/tests/filesystem.c +++ b/dlls/scrrun/tests/filesystem.c @@ -1264,6 +1264,9 @@ static void test_DriveCollection(void) hr = IDrive_get_AvailableSpace(drive, NULL); ok(hr == E_POINTER, "got 0x%08x\n", hr); + hr = IDrive_get_FreeSpace(drive, NULL); + ok(hr == E_POINTER, "got 0x%08x\n", hr); + if (type == Fixed) { VARIANT_BOOL ready = VARIANT_FALSE; VARIANT size; @@ -1283,6 +1286,12 @@ static void test_DriveCollection(void) ok(hr == S_OK, "got 0x%08x\n", hr); ok(V_VT(&size) == VT_R8, "got %d\n", V_VT(&size)); ok(V_R8(&size) > 0, "got %f\n", V_R8(&size)); + + V_VT(&size) = VT_EMPTY; + hr = IDrive_get_FreeSpace(drive, &size); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(V_VT(&size) == VT_R8, "got %d\n", V_VT(&size)); + ok(V_R8(&size) > 0, "got %f\n", V_R8(&size)); } VariantClear(&var); }

1 0

Sebastian Lackner : kernel32: Silence SetWaitableTimerEx fixme message.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: 0e1b381503751294c6e6925b9ba1eeb0aa770179 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0e1b381503751294c6e6925b9… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Apr 3 05:25:38 2014 +0200 kernel32: Silence SetWaitableTimerEx fixme message. --- dlls/kernel32/sync.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c index 6c452a4..d363e1f 100644 --- a/dlls/kernel32/sync.c +++ b/dlls/kernel32/sync.c @@ -1183,8 +1183,12 @@ BOOL WINAPI SetWaitableTimer( HANDLE handle, const LARGE_INTEGER *when, LONG per BOOL WINAPI SetWaitableTimerEx( HANDLE handle, const LARGE_INTEGER *when, LONG period, PTIMERAPCROUTINE callback, LPVOID arg, REASON_CONTEXT *context, ULONG tolerabledelay ) { - FIXME("(%p, %p, %d, %p, %p, %p, %d) semi-stub\n", - handle, when, period, callback, arg, context, tolerabledelay); + static int once; + if (!once++) + { + FIXME("(%p, %p, %d, %p, %p, %p, %d) semi-stub\n", + handle, when, period, callback, arg, context, tolerabledelay); + } return SetWaitableTimer(handle, when, period, callback, arg, FALSE); }

1 0

Dmitry Timoshkov : widl: Correct the condition when to use new code path which avoids writing negative offsets in the pointer description.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: 1b6b04e3a8286d4baff3a90598b2158389b52bf4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1b6b04e3a8286d4baff3a9059… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Apr 3 13:57:13 2014 +0900 widl: Correct the condition when to use new code path which avoids writing negative offsets in the pointer description. --- tools/widl/typegen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index d85b5e0..4bb4cc4 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -3596,7 +3596,7 @@ static unsigned int write_type_tfs(FILE *file, int indent, else ref_context = context; - if (is_string_type(attrs, type) && is_conformant_array(ref)) + if (is_string_type(attrs, ref)) { if (context != TYPE_CONTEXT_CONTAINER_NO_POINTERS) write_pointer_tfs(file, attrs, type, *typeformat_offset + 4, context, typeformat_offset);

1 0

Dmitry Timoshkov : schrpc.idl: Add missing [string] attribute to an array of strings being returned by SchRpcEnumFolders/ SchRpcEnumTasks.
by Alexandre Julliard 03 Apr '14

03 Apr '14

Module: wine Branch: master Commit: c22cdeea29dee4212f44f19075dcb87f7465feea URL: http://source.winehq.org/git/wine.git/?a=commit;h=c22cdeea29dee4212f44f1907… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Apr 3 13:57:22 2014 +0900 schrpc.idl: Add missing [string] attribute to an array of strings being returned by SchRpcEnumFolders/SchRpcEnumTasks. --- include/wine/schrpc.idl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/wine/schrpc.idl b/include/wine/schrpc.idl index c451082..55acb38 100644 --- a/include/wine/schrpc.idl +++ b/include/wine/schrpc.idl @@ -67,11 +67,11 @@ interface ITaskSchedulerService HRESULT SchRpcEnumFolders([in, string] const WCHAR *path, [in] DWORD flags, [in, out] DWORD *start_index, [in] DWORD n_requested, [out] DWORD *n_names, - [out, size_is(,*n_names)] TASK_NAMES *names); + [out, string, size_is(,*n_names)] TASK_NAMES *names); HRESULT SchRpcEnumTasks([in, string] const WCHAR *path, [in] DWORD flags, [in, out] DWORD *start_index, [in] DWORD n_requested, [out] DWORD *n_names, - [out, size_is(,*n_names)] TASK_NAMES *names); + [out, string, size_is(,*n_names)] TASK_NAMES *names); HRESULT SchRpcEnumInstances([in, string, unique] const WCHAR *path, [in] DWORD flags, [out] DWORD *n_guids, [out, size_is(,*n_guids)] GUID **guids);

1 0