May 2014 - Wine-commits - list.winehq.org

Francois Gouget : testbot/lib: Fix the call to ValuesDiffer() in Item:: AUTOLOAD.
by Alexandre Julliard 01 May '14

01 May '14

Module: tools Branch: master Commit: 9fee4992ceafb7c547b9bd7d7bc3c30d2e9ff4e6 URL: http://source.winehq.org/git/tools.git/?a=commit;h=9fee4992ceafb7c547b9bd7d… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 1 14:36:25 2014 +0200 testbot/lib: Fix the call to ValuesDiffer() in Item::AUTOLOAD. ValuesDiffer() is a method, not a function! --- testbot/lib/ObjectModel/Item.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testbot/lib/ObjectModel/Item.pm b/testbot/lib/ObjectModel/Item.pm index 48864f4..f988a46 100644 --- a/testbot/lib/ObjectModel/Item.pm +++ b/testbot/lib/ObjectModel/Item.pm @@ -1,5 +1,5 @@ # Copyright 2009 Ge van Geldorp -# Copyright 2012 Francois Gouget +# Copyright 2012, 2014 Francois Gouget # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -218,8 +218,8 @@ sub AUTOLOAD if (@_) { $self->{Itemrefs}{$PropertyName} = shift; - if (ValuesDiffer($self->{ColValues}{@{$ColNames}[0]}, - $self->{Itemrefs}{$PropertyName}->GetKey())) + if ($self->ValuesDiffer($self->{ColValues}{@{$ColNames}[0]}, + $self->{Itemrefs}{$PropertyName}->GetKey())) { $self->{IsModified} = 1; $self->{ColValues}{@{$ColNames}[0]} = $self->{Itemrefs}{$PropertyName}->GetKey();

1 0

Francois Gouget : testbot/lib: Remove Roles::HasRole(), it' s unused and does not make sense.
by Alexandre Julliard 01 May '14

01 May '14

Module: tools Branch: master Commit: b524951e9c26955e3f2d0c3416f4d8a8e8860469 URL: http://source.winehq.org/git/tools.git/?a=commit;h=b524951e9c26955e3f2d0c34… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 1 14:36:56 2014 +0200 testbot/lib: Remove Roles::HasRole(), it's unused and does not make sense. See WineTestBot::User::HasRole() instead. --- testbot/lib/WineTestBot/Roles.pm | 5 ----- 1 file changed, 5 deletions(-) diff --git a/testbot/lib/WineTestBot/Roles.pm b/testbot/lib/WineTestBot/Roles.pm index 620566a..2d74016 100644 --- a/testbot/lib/WineTestBot/Roles.pm +++ b/testbot/lib/WineTestBot/Roles.pm @@ -35,11 +35,6 @@ use vars qw (@ISA @EXPORT); require Exporter; @ISA = qw(WineTestBot::WineTestBotItem Exporter); -sub HasRole -{ - my $self = shift; - my $RoleName = shift; -} package WineTestBot::Roles;

1 0

Francois Gouget : testbot/lib: Add calls to the parent InitializeNew() method.
by Alexandre Julliard 01 May '14

01 May '14

Module: tools Branch: master Commit: c05902e1f83cb191f5707346fc3f760cd5e03b10 URL: http://source.winehq.org/git/tools.git/?a=commit;h=c05902e1f83cb191f5707346… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 1 14:37:23 2014 +0200 testbot/lib: Add calls to the parent InitializeNew() method. --- testbot/lib/WineTestBot/Branches.pm | 1 + testbot/lib/WineTestBot/Users.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/testbot/lib/WineTestBot/Branches.pm b/testbot/lib/WineTestBot/Branches.pm index 56f9965..ce975f1 100644 --- a/testbot/lib/WineTestBot/Branches.pm +++ b/testbot/lib/WineTestBot/Branches.pm @@ -38,6 +38,7 @@ sub InitializeNew my $self = shift; $self->IsDefault(!1); + $self->SUPER::InitializeNew(); } package WineTestBot::Branches; diff --git a/testbot/lib/WineTestBot/Users.pm b/testbot/lib/WineTestBot/Users.pm index a0034ee..1f09446 100644 --- a/testbot/lib/WineTestBot/Users.pm +++ b/testbot/lib/WineTestBot/Users.pm @@ -44,6 +44,7 @@ sub InitializeNew $self->Status('active'); $self->Password("*"); + $self->SUPER::InitializeNew(); } sub GeneratePasswordHash

1 0

Francois Gouget : testbot/lib: Remove an unused variable from ObjectModel: :Item::ValidateProperty().
by Alexandre Julliard 01 May '14

01 May '14

Module: tools Branch: master Commit: f3c254d85a74e053758ba6f6b27e7071c3ab8081 URL: http://source.winehq.org/git/tools.git/?a=commit;h=f3c254d85a74e053758ba6f6… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 1 14:37:37 2014 +0200 testbot/lib: Remove an unused variable from ObjectModel::Item::ValidateProperty(). --- testbot/lib/ObjectModel/Item.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/testbot/lib/ObjectModel/Item.pm b/testbot/lib/ObjectModel/Item.pm index f988a46..c718783 100644 --- a/testbot/lib/ObjectModel/Item.pm +++ b/testbot/lib/ObjectModel/Item.pm @@ -345,10 +345,8 @@ sub ValidateProperty my $PropertyDescriptor = shift; my $PropertyName = $PropertyDescriptor->GetName(); - my $Value = $self->$PropertyName; - return $PropertyDescriptor->ValidateValue($self->$PropertyName, - $self->GetIsNew()); + $self->GetIsNew()); } sub Validate

1 0