August 2014 - Wine-commits - list.winehq.org

Gerald Pfeifer : gdi32: Remove unused constant bit_fields_565.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: ff05f2dec69d9b1c28b710c425c4e1eff3c7a9ff URL: http://source.winehq.org/git/wine.git/?a=commit;h=ff05f2dec69d9b1c28b710c42… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sun Aug 10 20:11:19 2014 -0500 gdi32: Remove unused constant bit_fields_565. --- dlls/gdi32/dib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c index dd7a7f1..708a9a8 100644 --- a/dlls/gdi32/dib.c +++ b/dlls/gdi32/dib.c @@ -961,7 +961,6 @@ UINT WINAPI GetDIBColorTable( HDC hdc, UINT startpos, UINT entries, RGBQUAD *col } static const DWORD bit_fields_888[3] = {0xff0000, 0x00ff00, 0x0000ff}; -static const DWORD bit_fields_565[3] = {0xf800, 0x07e0, 0x001f}; static const DWORD bit_fields_555[3] = {0x7c00, 0x03e0, 0x001f}; static int fill_query_info( BITMAPINFO *info, BITMAPOBJ *bmp )

1 0

Gerald Pfeifer : winedbg: Add explicit return in the error case of print_typed_basic.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: c24bd744867771b9f047c4e664bcea5120255810 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c24bd744867771b9f047c4e66… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Aug 9 20:38:49 2014 -0500 winedbg: Add explicit return in the error case of print_typed_basic. --- programs/winedbg/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/programs/winedbg/memory.c b/programs/winedbg/memory.c index af99229..78a0493 100644 --- a/programs/winedbg/memory.c +++ b/programs/winedbg/memory.c @@ -367,6 +367,7 @@ static void print_typed_basic(const struct dbg_lvalue* lvalue) { WINE_ERR("Couldn't get information\n"); RaiseException(DEBUG_STATUS_INTERNAL_ERROR, 0, 0, NULL); + return; } size = (DWORD)size64; switch (bt)

1 0

Thomas Faber : rpcrt4: Correctly check for in-buffer memory in PointerFree.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: 6a30cde7b04c3b8a28e93557ce5ce18d1e45931f URL: http://source.winehq.org/git/wine.git/?a=commit;h=6a30cde7b04c3b8a28e93557c… Author: Thomas Faber <thomas.faber(a)reactos.org> Date: Mon Aug 11 10:59:20 2014 +0200 rpcrt4: Correctly check for in-buffer memory in PointerFree. --- dlls/rpcrt4/ndr_marshall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c index 481b426..3f1762a 100644 --- a/dlls/rpcrt4/ndr_marshall.c +++ b/dlls/rpcrt4/ndr_marshall.c @@ -1138,7 +1138,7 @@ static void PointerFree(PMIDL_STUB_MESSAGE pStubMsg, * BufferStart and BufferEnd won't be reset when allocating memory for * sending the response. we don't have to check for the new buffer here as * it won't be used a type memory, only for buffer memory */ - if (Pointer >= pStubMsg->BufferStart && Pointer < pStubMsg->BufferEnd) + if (Pointer >= pStubMsg->BufferStart && Pointer <= pStubMsg->BufferEnd) goto notfree; if (attr & RPC_FC_P_ONSTACK) {

1 0

André Hentschel : wpcap: Implement pcap_major_version and pcap_minor_version.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: 0cbd82f6298ad9f953dad17a3be92bccff30c1c3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0cbd82f6298ad9f953dad17a3… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Aug 10 23:08:20 2014 +0200 wpcap: Implement pcap_major_version and pcap_minor_version. --- dlls/wpcap/wpcap.c | 12 ++++++++++++ dlls/wpcap/wpcap.spec | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/dlls/wpcap/wpcap.c b/dlls/wpcap/wpcap.c index e143294..a317e5f 100644 --- a/dlls/wpcap/wpcap.c +++ b/dlls/wpcap/wpcap.c @@ -29,3 +29,15 @@ const char* CDECL wine_pcap_lib_version(void) TRACE("%s\n", debugstr_a(ret)); return ret; } + +int CDECL wine_pcap_major_version(pcap_t *p) +{ + TRACE("(%p)\n", p); + return pcap_major_version(p); +} + +int CDECL wine_pcap_minor_version(pcap_t *p) +{ + TRACE("(%p)\n", p); + return pcap_minor_version(p); +} diff --git a/dlls/wpcap/wpcap.spec b/dlls/wpcap/wpcap.spec index 1b36f33..bcf8ea4 100644 --- a/dlls/wpcap/wpcap.spec +++ b/dlls/wpcap/wpcap.spec @@ -40,8 +40,8 @@ @ stub pcap_lookupdev @ stub pcap_lookupnet @ stub pcap_loop -@ stub pcap_major_version -@ stub pcap_minor_version +@ cdecl pcap_major_version(ptr) wine_pcap_major_version +@ cdecl pcap_minor_version(ptr) wine_pcap_minor_version @ stub pcap_next @ stub pcap_next_etherent @ stub pcap_next_ex

1 0

André Hentschel : wpcap: Implement pcap_findalldevs.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: ca1aa1cfa21e71c20ecf91cfe2d981752886b654 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ca1aa1cfa21e71c20ecf91cfe… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Aug 10 23:08:40 2014 +0200 wpcap: Implement pcap_findalldevs. --- dlls/wpcap/wpcap.c | 13 +++++++++++++ dlls/wpcap/wpcap.spec | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/dlls/wpcap/wpcap.c b/dlls/wpcap/wpcap.c index a317e5f..c08bbf8 100644 --- a/dlls/wpcap/wpcap.c +++ b/dlls/wpcap/wpcap.c @@ -22,6 +22,19 @@ #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(wpcap); +WINE_DECLARE_DEBUG_CHANNEL(winediag); + +int CDECL wine_pcap_findalldevs(pcap_if_t **alldevsp, char *errbuf) +{ + int ret; + + TRACE("(%p %p)\n", alldevsp, errbuf); + ret = pcap_findalldevs(alldevsp, errbuf); + if(alldevsp && !*alldevsp) + ERR_(winediag)("Failed to access raw network (pcap), this requires special permissions.\n"); + + return ret; +} const char* CDECL wine_pcap_lib_version(void) { diff --git a/dlls/wpcap/wpcap.spec b/dlls/wpcap/wpcap.spec index bcf8ea4..6e4606e 100644 --- a/dlls/wpcap/wpcap.spec +++ b/dlls/wpcap/wpcap.spec @@ -24,7 +24,7 @@ @ stub pcap_dump_open @ stub pcap_file @ stub pcap_fileno -@ stub pcap_findalldevs +@ cdecl pcap_findalldevs(ptr str) wine_pcap_findalldevs @ stub pcap_findalldevs_ex @ stub pcap_freealldevs @ stub pcap_freecode

1 0

André Hentschel : wpcap: Implement pcap_freealldevs.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: b1c54557d7deba339f943fa5a23673d556eb7d8c URL: http://source.winehq.org/git/wine.git/?a=commit;h=b1c54557d7deba339f943fa5a… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Aug 10 23:09:22 2014 +0200 wpcap: Implement pcap_freealldevs. --- dlls/wpcap/wpcap.c | 6 ++++++ dlls/wpcap/wpcap.spec | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/dlls/wpcap/wpcap.c b/dlls/wpcap/wpcap.c index c08bbf8..b3ce425 100644 --- a/dlls/wpcap/wpcap.c +++ b/dlls/wpcap/wpcap.c @@ -36,6 +36,12 @@ int CDECL wine_pcap_findalldevs(pcap_if_t **alldevsp, char *errbuf) return ret; } +void CDECL wine_pcap_freealldevs(pcap_if_t *alldevs) +{ + TRACE("(%p)\n", alldevs); + pcap_freealldevs(alldevs); +} + const char* CDECL wine_pcap_lib_version(void) { const char* ret = pcap_lib_version(); diff --git a/dlls/wpcap/wpcap.spec b/dlls/wpcap/wpcap.spec index 6e4606e..ad90d1f 100644 --- a/dlls/wpcap/wpcap.spec +++ b/dlls/wpcap/wpcap.spec @@ -26,7 +26,7 @@ @ stub pcap_fileno @ cdecl pcap_findalldevs(ptr str) wine_pcap_findalldevs @ stub pcap_findalldevs_ex -@ stub pcap_freealldevs +@ cdecl pcap_freealldevs(ptr) wine_pcap_freealldevs @ stub pcap_freecode @ stub pcap_get_airpcap_handle @ stub pcap_geterr

1 0

Zhenbo Li : mshtml: Added IHTMLStyle::textIndent property implementation.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: aa41321f49ceee98a6f038a3fff714bd7ba9fa77 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa41321f49ceee98a6f038a3f… Author: Zhenbo Li <litimetal(a)gmail.com> Date: Sat Aug 9 08:31:31 2014 +0800 mshtml: Added IHTMLStyle::textIndent property implementation. --- dlls/mshtml/htmlstyle.c | 12 ++++++++---- dlls/mshtml/tests/style.c | 17 +++++++++++++++++ 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index 580b73c..6731149 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -1489,15 +1489,19 @@ static HRESULT WINAPI HTMLStyle_get_textAlign(IHTMLStyle *iface, BSTR *p) static HRESULT WINAPI HTMLStyle_put_textIndent(IHTMLStyle *iface, VARIANT v) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); - return E_NOTIMPL; + + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); + + return set_nsstyle_attr_var(This->nsstyle, STYLEID_TEXT_INDENT, &v, ATTR_FIX_PX); } static HRESULT WINAPI HTMLStyle_get_textIndent(IHTMLStyle *iface, VARIANT *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_nsstyle_attr_var(This->nsstyle, STYLEID_TEXT_INDENT, p, 0); } static HRESULT WINAPI HTMLStyle_put_lineHeight(IHTMLStyle *iface, VARIANT v) diff --git a/dlls/mshtml/tests/style.c b/dlls/mshtml/tests/style.c index 62a6336..bd4b200 100644 --- a/dlls/mshtml/tests/style.c +++ b/dlls/mshtml/tests/style.c @@ -1248,6 +1248,23 @@ static void test_body_style(IHTMLStyle *style) ok(!strcmp_wa(str, "center"), "textAlign = %s\n", wine_dbgstr_w(V_BSTR(&v))); SysFreeString(str); + V_VT(&v) = VT_NULL; + hres = IHTMLStyle_get_textIndent(style, &v); + ok(hres == S_OK, "get_textIndent failed: %08x\n", hres); + ok(V_VT(&v) == VT_BSTR, "V_VT(textIndent) = %d\n", V_VT(&v)); + ok(!V_BSTR(&v), "V_BSTR(textIndent) = %s\n", wine_dbgstr_w(V_BSTR(&v))); + + V_VT(&v) = VT_I4; + V_I4(&v) = 6; + hres = IHTMLStyle_put_textIndent(style, v); + ok(hres == S_OK, "put_textIndent failed: %08x\n", hres); + + V_VT(&v) = VT_NULL; + hres = IHTMLStyle_get_textIndent(style, &v); + ok(hres == S_OK, "get_textIndent failed: %08x\n", hres); + ok(V_VT(&v) == VT_BSTR, "V_VT(textIndent) = %d\n", V_VT(&v)); + ok(!strcmp_wa(V_BSTR(&v), "6px"), "V_BSTR(textIndent) = %s\n", wine_dbgstr_w(V_BSTR(&v))); + str = (void*)0xdeadbeef; hres = IHTMLStyle_get_textTransform(style, &str); ok(hres == S_OK, "get_textTransform failed: %08x\n", hres);

1 0

Zhenbo Li : mshtml: Added IHTMLStyleElement::lineHeight property.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: ed9b0f758ae6bdde28b87109eee4fdd120689f07 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ed9b0f758ae6bdde28b87109e… Author: Zhenbo Li <litimetal(a)gmail.com> Date: Mon Aug 11 11:08:04 2014 +0800 mshtml: Added IHTMLStyleElement::lineHeight property. --- dlls/mshtml/htmlstyle.c | 12 ++++++++---- dlls/mshtml/tests/style.c | 22 ++++++++++++++++++++++ 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index 6731149..2635c8b 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -1507,15 +1507,19 @@ static HRESULT WINAPI HTMLStyle_get_textIndent(IHTMLStyle *iface, VARIANT *p) static HRESULT WINAPI HTMLStyle_put_lineHeight(IHTMLStyle *iface, VARIANT v) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); - return E_NOTIMPL; + + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); + + return set_nsstyle_attr_var(This->nsstyle, STYLEID_LINE_HEIGHT, &v, 0); } static HRESULT WINAPI HTMLStyle_get_lineHeight(IHTMLStyle *iface, VARIANT *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_nsstyle_attr_var(This->nsstyle, STYLEID_LINE_HEIGHT, p, 0); } static HRESULT WINAPI HTMLStyle_put_marginTop(IHTMLStyle *iface, VARIANT v) diff --git a/dlls/mshtml/tests/style.c b/dlls/mshtml/tests/style.c index bd4b200..9327f28 100644 --- a/dlls/mshtml/tests/style.c +++ b/dlls/mshtml/tests/style.c @@ -742,6 +742,28 @@ static void test_body_style(IHTMLStyle *style) todo_wine ok(!strcmp_wa(V_BSTR(&v), "#00fdfd"), "V_BSTR(color) = %s\n", wine_dbgstr_w(V_BSTR(&v))); + V_VT(&v) = VT_I4; + V_I4(&v) = 3; + hres = IHTMLStyle_put_lineHeight(style, v); + ok(hres == S_OK, "put_lineHeight failed: %08x\n", hres); + + hres = IHTMLStyle_get_lineHeight(style, &v); + ok(hres == S_OK, "get_lineHeight failed: %08x\n", hres); + ok(V_VT(&v) == VT_BSTR, "V_VT(lineHeight) = %d, expect VT_BSTR\n", V_VT(&v)); + ok(!strcmp_wa(V_BSTR(&v), "3"), "V_BSTR(lineHeight) = %s\n", wine_dbgstr_w(V_BSTR(&v))); + + V_VT(&v) = VT_BSTR; + V_BSTR(&v) = a2bstr("300%"); + hres = IHTMLStyle_put_lineHeight(style, v); + ok(hres == S_OK, "put_lineHeight failed: %08x\n", hres); + VariantClear(&v); + + hres = IHTMLStyle_get_lineHeight(style, &v); + ok(hres == S_OK, "get_lineHeight failed: %08x\n", hres); + ok(V_VT(&v) == VT_BSTR, "V_VT(lineHeight) = %d, expect VT_BSTR\n", V_VT(&v)); + ok(!strcmp_wa(V_BSTR(&v), "300%"), "V_BSTR(lineHeight) = %s\n", wine_dbgstr_w(V_BSTR(&v))); + VariantClear(&v); + b = 0xfefe; hres = IHTMLStyle_get_textDecorationUnderline(style, &b); ok(hres == S_OK, "get_textDecorationUnderline failed: %08x\n", hres);

1 0

Zhenbo Li : mshtml: Added IHTMLStyle:: listStylePosition property implementation.
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: bf463eae053f9cd12ac1c0b59b1bdc3e6b66585e URL: http://source.winehq.org/git/wine.git/?a=commit;h=bf463eae053f9cd12ac1c0b59… Author: Zhenbo Li <litimetal(a)gmail.com> Date: Sun Aug 10 21:14:37 2014 +0800 mshtml: Added IHTMLStyle::listStylePosition property implementation. --- dlls/mshtml/htmlstyle.c | 15 +++++++++++---- dlls/mshtml/htmlstyle.h | 1 + dlls/mshtml/tests/style.c | 9 +++++++++ 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index 2635c8b..1dca647 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -128,6 +128,8 @@ static const WCHAR attrLineHeight[] = {'l','i','n','e','-','h','e','i','g','h','t',0}; static const WCHAR attrListStyleType[] = {'l','i','s','t','-','s','t','y','l','e','-','t','y','p','e',0}; +static const WCHAR attrListStylePosition[] = + {'l','i','s','t','-','s','t','y','l','e','-','p','o','s','i','t','i','o','n',0}; static const WCHAR attrMargin[] = {'m','a','r','g','i','n',0}; static const WCHAR attrMarginBottom[] = @@ -245,6 +247,7 @@ static const style_tbl_entry_t style_tbl[] = { {attrLeft, DISPID_IHTMLSTYLE_LEFT}, {attrLetterSpacing, DISPID_IHTMLSTYLE_LETTERSPACING}, {attrLineHeight, DISPID_IHTMLSTYLE_LINEHEIGHT}, + {attrListStylePosition, DISPID_IHTMLSTYLE_LISTSTYLEPOSITION}, {attrListStyleType, DISPID_IHTMLSTYLE_LISTSTYLETYPE}, {attrMargin, DISPID_IHTMLSTYLE_MARGIN}, {attrMarginBottom, DISPID_IHTMLSTYLE_MARGINBOTTOM}, @@ -2196,15 +2199,19 @@ static HRESULT WINAPI HTMLStyle_get_listStyleType(IHTMLStyle *iface, BSTR *p) static HRESULT WINAPI HTMLStyle_put_listStylePosition(IHTMLStyle *iface, BSTR v) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); - return E_NOTIMPL; + + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); + + return set_style_attr(This, STYLEID_LISTSTYLEPOSITION, v, 0); } static HRESULT WINAPI HTMLStyle_get_listStylePosition(IHTMLStyle *iface, BSTR *p) { HTMLStyle *This = impl_from_IHTMLStyle(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_style_attr(This, STYLEID_LISTSTYLEPOSITION, p); } static HRESULT WINAPI HTMLStyle_put_listStyleImage(IHTMLStyle *iface, BSTR v) diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h index 6edde7b..813c782 100644 --- a/dlls/mshtml/htmlstyle.h +++ b/dlls/mshtml/htmlstyle.h @@ -78,6 +78,7 @@ typedef enum { STYLEID_LEFT, STYLEID_LETTER_SPACING, STYLEID_LINE_HEIGHT, + STYLEID_LISTSTYLEPOSITION, STYLEID_LISTSTYLETYPE, STYLEID_MARGIN, STYLEID_MARGIN_BOTTOM, diff --git a/dlls/mshtml/tests/style.c b/dlls/mshtml/tests/style.c index 9327f28..a454eff 100644 --- a/dlls/mshtml/tests/style.c +++ b/dlls/mshtml/tests/style.c @@ -2161,6 +2161,15 @@ static void test_body_style(IHTMLStyle *style) hres = IHTMLStyle_get_listStyleType(style, &str); ok(hres == S_OK, "get_listStyleType failed: %08x\n", hres); ok(!strcmp_wa(str, "square"), "listStyleType = %s\n", wine_dbgstr_w(str)); + + str = a2bstr("inside"); + hres = IHTMLStyle_put_listStylePosition(style, str); + ok(hres == S_OK, "put_listStylePosition failed: %08x\n", hres); + SysFreeString(str); + + hres = IHTMLStyle_get_listStylePosition(style, &str); + ok(hres == S_OK, "get_listStylePosition failed: %08x\n", hres); + ok(!strcmp_wa(str, "inside"), "listStyleType = %s\n", wine_dbgstr_w(str)); SysFreeString(str); hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, (void**)&style2);

1 0

Marcus Meissner : dwrite: Fixed paste error (Coverity).
by Alexandre Julliard 11 Aug '14

11 Aug '14

Module: wine Branch: master Commit: d1749b548b95a4888a2c8157d574d11aea7e2866 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1749b548b95a4888a2c8157d… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Mon Aug 11 09:00:31 2014 +0200 dwrite: Fixed paste error (Coverity). --- dlls/dwrite/tests/layout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dwrite/tests/layout.c b/dlls/dwrite/tests/layout.c index f4cd903..dc5f477 100644 --- a/dlls/dwrite/tests/layout.c +++ b/dlls/dwrite/tests/layout.c @@ -613,7 +613,7 @@ static void test_SetInlineObject(void) hr = IDWriteTextLayout_GetInlineObject(layout, 0, &inlinetest, NULL); todo_wine { ok(hr == S_OK, "got 0x%08x\n", hr); - ok(inlinetest == NULL, "got %p\n", inlineobj); + ok(inlinetest == NULL, "got %p\n", inlinetest); } range.startPosition = 0; range.length = 2;

1 0