December 2015 - Wine-commits

Jacek Caban : ieframe: Fixed tests on some VMs.
by Alexandre Julliard 02 Dec '15

02 Dec '15

Module: wine Branch: master Commit: a4fb95d7b5e005184d0b1d82fd010d41069023f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a4fb95d7b5e005184d0b1d82f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Dec 1 18:24:28 2015 +0100 ieframe: Fixed tests on some VMs. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ieframe/tests/webbrowser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c index 3584647..1cd8f75 100644 --- a/dlls/ieframe/tests/webbrowser.c +++ b/dlls/ieframe/tests/webbrowser.c @@ -1024,6 +1024,9 @@ static HRESULT WINAPI WebBrowserEvents2_Invoke(IDispatch *iface, DISPID dispIdMe case DISPID_BEFORESCRIPTEXECUTE: /* FIXME: IE10 */ break; + case DISPID_PRIVACYIMPACTEDSTATECHANGE: + break; + default: ok(0, "unexpected dispIdMember %d\n", dispIdMember); }

1 0

Piotr Caban : comctl32: Set listview focus in WM_LBUTTONDOWN.
by Alexandre Julliard 02 Dec '15

02 Dec '15

Module: wine Branch: master Commit: ddcab8aceada5ee7df8bbd3d9c04de4ce5a25725 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ddcab8aceada5ee7df8bbd3d9… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Dec 1 19:12:41 2015 +0100 comctl32: Set listview focus in WM_LBUTTONDOWN. This patch reverts commit 098dc7b3302f39c5500d644615a6f4c37d328ce0 and moves focus setting after LVN_ITEMCHANGED notification is sent. Writing tests for it is tricky because native blocks inside WM_LBUTTONDOWN message. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/listview.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index e479dca..68a5515 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -10266,6 +10266,9 @@ static LRESULT LISTVIEW_LButtonDown(LISTVIEW_INFO *infoPtr, WORD wKey, INT x, IN } } + if (!infoPtr->bFocus) + SetFocus(infoPtr->hwndSelf); + if (infoPtr->dwLvExStyle & LVS_EX_ONECLICKACTIVATE) if(lvHitTestInfo.iItem != -1) notify_itemactivate(infoPtr,&lvHitTestInfo); } @@ -10352,9 +10355,6 @@ static LRESULT LISTVIEW_LButtonUp(LISTVIEW_INFO *infoPtr, WORD wKey, INT x, INT LISTVIEW_DelayedEditItem); } - if (!infoPtr->bFocus) - SetFocus(infoPtr->hwndSelf); - return 0; }

1 0

Francois Gouget : Assorted spelling fixes.
by Alexandre Julliard 02 Dec '15

02 Dec '15

Module: wine Branch: master Commit: 413c6f60cf89cd04ecfde0b3f26f239129cb5b39 URL: http://source.winehq.org/git/wine.git/?a=commit;h=413c6f60cf89cd04ecfde0b3f… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Dec 2 01:42:31 2015 +0100 Assorted spelling fixes. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 2 +- dlls/d3d11/tests/d3d11.c | 2 +- dlls/dsound/duplex.c | 2 +- dlls/dxgi/tests/device.c | 2 +- dlls/mshtml/htmlwindow.c | 2 +- dlls/msrle32/tests/msrle.c | 2 +- dlls/shell32/shfldr_unixfs.c | 2 +- dlls/shell32/shlfileop.c | 2 +- dlls/winepulse.drv/mmdevdrv.c | 10 +++++----- dlls/winspool.drv/info.c | 2 +- dlls/xaudio2_7/xaudio_dll.c | 2 +- programs/cmd/tests/test_builtins.cmd | 2 +- 12 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index d25600e..c13af50 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -1474,7 +1474,7 @@ static void test_create_sampler_state(void) ok(d3d11_desc.Filter == expected_desc.Filter, "Test %u: Got unexpected filter %#x.\n", i, d3d11_desc.Filter); ok(d3d11_desc.AddressU == expected_desc.AddressU, - "Test %u: Got unexpected adress u %u.\n", i, d3d11_desc.AddressU); + "Test %u: Got unexpected address u %u.\n", i, d3d11_desc.AddressU); ok(d3d11_desc.AddressV == expected_desc.AddressV, "Test %u: Got unexpected address v %u.\n", i, d3d11_desc.AddressV); ok(d3d11_desc.AddressW == expected_desc.AddressW, diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 7021c6f..6c8f0f7 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -1917,7 +1917,7 @@ static void test_create_sampler_state(void) ok(d3d10_desc.Filter == expected_desc.Filter, "Test %u: Got unexpected filter %#x.\n", i, d3d10_desc.Filter); ok(d3d10_desc.AddressU == expected_desc.AddressU, - "Test %u: Got unexpected adress u %u.\n", i, d3d10_desc.AddressU); + "Test %u: Got unexpected address u %u.\n", i, d3d10_desc.AddressU); ok(d3d10_desc.AddressV == expected_desc.AddressV, "Test %u: Got unexpected address v %u.\n", i, d3d10_desc.AddressV); ok(d3d10_desc.AddressW == expected_desc.AddressW, diff --git a/dlls/dsound/duplex.c b/dlls/dsound/duplex.c index b18972e..153c7b6 100644 --- a/dlls/dsound/duplex.c +++ b/dlls/dsound/duplex.c @@ -67,7 +67,7 @@ static void fullduplex_destroy(IDirectSoundFullDuplexImpl *This) } /******************************************************************************* - * IUnknown implemetation for DirectSoundFullDuplex + * IUnknown implementation for DirectSoundFullDuplex */ static inline IDirectSoundFullDuplexImpl *impl_from_IUnknown(IUnknown *iface) { diff --git a/dlls/dxgi/tests/device.c b/dlls/dxgi/tests/device.c index 4e54f4f..dd5da83 100644 --- a/dlls/dxgi/tests/device.c +++ b/dlls/dxgi/tests/device.c @@ -1193,7 +1193,7 @@ static void test_swapchain_parameters(void) /* Buffers > 0 are supposed to be read only. This is the case except that in * fullscreen mode on Windows <= 8 the last backbuffer (BufferCount - 1) is - * writeable. This is not the case if an unsupported refresh rate is passed + * writable. This is not the case if an unsupported refresh rate is passed * for some reason, probably because the invalid refresh rate triggers a * kinda-sorta windowed mode. * diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 5ed22c0..fbb558e 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -2653,7 +2653,7 @@ static HRESULT WINAPI WindowDispEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID DISPPARAMS dp = {args, NULL, 2, 0}; /* - * setTimeout calls shoud use default value 0 for the second argument if only one is provided, + * setTimeout calls should use default value 0 for the second argument if only one is provided, * but IDL file does not reflect that. We fixup arguments here instead. */ if(!(wFlags & DISPATCH_METHOD) || pdp->cArgs != 1 || pdp->cNamedArgs) diff --git a/dlls/msrle32/tests/msrle.c b/dlls/msrle32/tests/msrle.c index 38e74a6..14ddddb 100644 --- a/dlls/msrle32/tests/msrle.c +++ b/dlls/msrle32/tests/msrle.c @@ -137,7 +137,7 @@ static void test_raw_decompress(void) hic = ICLocate(FCC('V', 'I', 'D', 'C'), codecs[i], bih, NULL, ICMODE_DECOMPRESS); ok(hic != NULL, "Test[%d]: Expected non-NULL return\n", i); - /* Now wich is this codec? Windows returns MRLE for uncompressed cases */ + /* Now which is this codec? Windows returns MRLE for uncompressed cases */ memset(&codec_info, 0, sizeof(codec_info)); hr = ICGetInfo(hic, &codec_info, sizeof(codec_info)); ok(hr == sizeof(codec_info), "Test[%d]: Incorrect amount of data returned\n", i); diff --git a/dlls/shell32/shfldr_unixfs.c b/dlls/shell32/shfldr_unixfs.c index b3b0214..85383e8 100644 --- a/dlls/shell32/shfldr_unixfs.c +++ b/dlls/shell32/shfldr_unixfs.c @@ -776,7 +776,7 @@ static HRESULT UNIXFS_initialize_target_folder(UnixFolder *This, const char *szB current = ILGetNext(current); }; - /* Build the path and compute the attributes*/ + /* Build the path and compute the attributes */ This->m_dwAttributes = dwAttributes|SFGAO_FOLDER|SFGAO_HASSUBFOLDER|SFGAO_FILESYSANCESTOR|SFGAO_CANRENAME; This->m_pszPath = pNextDir = SHAlloc(dwPathLen); diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c index c843dd7..234a141 100644 --- a/dlls/shell32/shlfileop.c +++ b/dlls/shell32/shlfileop.c @@ -572,7 +572,7 @@ DWORD WINAPI Win32DeleteFileAW(LPCVOID path) * dest [I] path to target file to move to * * RETURNS - * ERORR_SUCCESS if successful + * ERROR_SUCCESS if successful */ static DWORD SHNotifyMoveFileW(LPCWSTR src, LPCWSTR dest) { diff --git a/dlls/winepulse.drv/mmdevdrv.c b/dlls/winepulse.drv/mmdevdrv.c index 24972ab..0e6cf9f 100644 --- a/dlls/winepulse.drv/mmdevdrv.c +++ b/dlls/winepulse.drv/mmdevdrv.c @@ -506,7 +506,7 @@ fail: return E_FAIL; } -/* For default Pulseaudio render device, OR together all of the +/* For default PulseAudio render device, OR together all of the * PKEY_AudioEndpoint_PhysicalSpeakers values of the sinks. */ static void pulse_phys_speakers_cb(pa_context *c, const pa_sink_info *i, int eol, void *userdata) { @@ -801,7 +801,7 @@ static HRESULT pulse_stream_connect(ACImpl *This, UINT32 period_bytes) { pa_stream_set_buffer_attr_callback(This->stream, pulse_attr_update, This); pa_stream_set_moved_callback(This->stream, pulse_attr_update, This); - /* Pulseaudio will fill in correct values */ + /* PulseAudio will fill in correct values */ attr.minreq = attr.fragsize = period_bytes; attr.maxlength = attr.tlength = This->bufsize_bytes; attr.prebuf = pa_frame_size(&This->ss); @@ -2991,7 +2991,7 @@ static HRESULT WINAPI SimpleAudioVolume_SetMasterVolume( if (context) FIXME("Notifications not supported yet\n"); - TRACE("Pulseaudio does not support session volume control\n"); + TRACE("PulseAudio does not support session volume control\n"); pthread_mutex_lock(&pulse_lock); session->master_vol = level; @@ -3127,7 +3127,7 @@ static HRESULT WINAPI ChannelAudioVolume_SetChannelVolume( if (context) FIXME("Notifications not supported yet\n"); - TRACE("Pulseaudio does not support session volume control\n"); + TRACE("PulseAudio does not support session volume control\n"); pthread_mutex_lock(&pulse_lock); session->channel_vols[index] = level; @@ -3175,7 +3175,7 @@ static HRESULT WINAPI ChannelAudioVolume_SetAllVolumes( if (context) FIXME("Notifications not supported yet\n"); - TRACE("Pulseaudio does not support session volume control\n"); + TRACE("PulseAudio does not support session volume control\n"); pthread_mutex_lock(&pulse_lock); for(i = 0; i < count; ++i) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index ca2c34d..04def86 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -317,7 +317,7 @@ static const printenv_t * const all_printenv[] = {&env_x86, &env_x64, &env_win40 * * NOTES * An empty string is handled the same way as NULL. - * SetLastEror(ERROR_INVALID_ENVIRONMENT) is called on Failure + * SetLastError(ERROR_INVALID_ENVIRONMENT) is called on Failure * */ diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c index 73cf63d..04f975c 100644 --- a/dlls/xaudio2_7/xaudio_dll.c +++ b/dlls/xaudio2_7/xaudio_dll.c @@ -2091,7 +2091,7 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, void **ppv) return IClassFactory_QueryInterface(factory, riid, ppv); } -/* returns TRUE if there is more data avilable in the buffer, FALSE if the +/* returns TRUE if there is more data available in the buffer, FALSE if the * buffer's data has all been queued */ static BOOL xa2buffer_queue_period(XA2SourceImpl *src, XA2Buffer *buf, ALuint al_buf) { diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index 52c549e..cf2559a 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -973,7 +973,7 @@ del temp.bat 2>nul goto :eof :TestForR -rem %CD% does not tork on NT4 so use the following workaround +rem %CD% does not work on NT4 so use the following workaround for /d %%i in (.) do set WINE_CURDIR=%%~dpnxi echo --- for /R

1 0

Alexandre Julliard : winex11: Include raw motion events in the QS_MOUSEMOVE event filter.
by Alexandre Julliard 02 Dec '15

02 Dec '15

Module: wine Branch: master Commit: 197f708be448719bf5938d1ff282811439e7c224 URL: http://source.winehq.org/git/wine.git/?a=commit;h=197f708be448719bf5938d1ff… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 2 15:31:34 2015 +0900 winex11: Include raw motion events in the QS_MOUSEMOVE event filter. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/winex11.drv/event.c b/dlls/winex11.drv/event.c index ee30259..51ef24b 100644 --- a/dlls/winex11.drv/event.c +++ b/dlls/winex11.drv/event.c @@ -240,6 +240,9 @@ static Bool filter_event( Display *display, XEvent *event, char *arg ) case ButtonPress: case ButtonRelease: return (mask & QS_MOUSEBUTTON) != 0; +#ifdef GenericEvent + case GenericEvent: +#endif case MotionNotify: case EnterNotify: case LeaveNotify:

1 0

Alexandre Julliard : ntdll/tests: Use more reasonable timeouts and avoid long long constants.
by Alexandre Julliard 02 Dec '15

02 Dec '15

Module: wine Branch: master Commit: 9cad1cc84762137a20caa53b5d7724c7fd03c686 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9cad1cc84762137a20caa53b5… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 2 17:09:08 2015 +0900 ntdll/tests: Use more reasonable timeouts and avoid long long constants. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/pipe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/tests/pipe.c b/dlls/ntdll/tests/pipe.c index 20d82f4..7c30408 100644 --- a/dlls/ntdll/tests/pipe.c +++ b/dlls/ntdll/tests/pipe.c @@ -126,7 +126,7 @@ static NTSTATUS create_pipe(PHANDLE handle, ULONG sharing, ULONG options) attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - timeout.QuadPart = -100000000000ll; + timeout.QuadPart = -100000000; res = pNtCreateNamedPipeFile(handle, FILE_READ_ATTRIBUTES | SYNCHRONIZE, &attr, &iosb, sharing, 2 /*FILE_CREATE*/, options, 1, 0, 0, 0xFFFFFFFF, 500, 500, &timeout); @@ -152,7 +152,7 @@ static void test_create_invalid(void) attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - timeout.QuadPart = -100000000000ll; + timeout.QuadPart = -100000000; /* create a pipe with FILE_OVERWRITE */ res = pNtCreateNamedPipeFile(&handle, FILE_READ_ATTRIBUTES | SYNCHRONIZE, &attr, &iosb, FILE_SHARE_READ, 4 /*FILE_OVERWRITE*/, @@ -521,7 +521,7 @@ static void test_filepipeinfo(void) attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - timeout.QuadPart = -100000000000ll; + timeout.QuadPart = -100000000; /* test with INVALID_HANDLE_VALUE */ res = pNtQueryInformationFile(INVALID_HANDLE_VALUE, &iosb, &fpi, sizeof(fpi), (FILE_INFORMATION_CLASS)23);

1 0

Bruno Jesus : msacm32/tests: Add more acmStreamPrepareHeader tests.
by Alexandre Julliard 01 Dec '15

01 Dec '15

Module: wine Branch: master Commit: 395b9c321b6788463d2e2f03b603600f8bb78454 URL: http://source.winehq.org/git/wine.git/?a=commit;h=395b9c321b6788463d2e2f03b… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Fri Nov 27 21:10:04 2015 +0800 msacm32/tests: Add more acmStreamPrepareHeader tests. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msacm32/tests/msacm.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/dlls/msacm32/tests/msacm.c b/dlls/msacm32/tests/msacm.c index bb4ccc5..812a1bb 100644 --- a/dlls/msacm32/tests/msacm.c +++ b/dlls/msacm32/tests/msacm.c @@ -586,6 +586,33 @@ static void test_prepareheader(void) memset(&hdr, 0, sizeof(hdr)); hdr.cbStruct = sizeof(hdr); hdr.pbSrc = input; + hdr.cbSrcLength = 0; /* invalid source length */ + hdr.pbDst = pcm; + hdr.cbDstLength = sizeof(pcm); + + mr = acmStreamPrepareHeader(has, &hdr, 0); +todo_wine + ok(mr == MMSYSERR_INVALPARAM, "expected 0x0b, got 0x%x\n", mr); + + hdr.cbSrcLength = src->wfx.nBlockAlign - 1; /* less than block align */ + mr = acmStreamPrepareHeader(has, &hdr, 0); +todo_wine + ok(mr == ACMERR_NOTPOSSIBLE, "expected 0x200, got 0x%x\n", mr); + + hdr.cbSrcLength = src->wfx.nBlockAlign; + mr = acmStreamPrepareHeader(has, &hdr, 1); /* invalid use of reserved parameter */ +todo_wine + ok(mr == MMSYSERR_INVALFLAG, "expected 0x0a, got 0x%x\n", mr); + + mr = acmStreamPrepareHeader(has, &hdr, 0); + ok(mr == MMSYSERR_NOERROR, "prepare failed: 0x%x\n", mr); + + mr = acmStreamUnprepareHeader(has, &hdr, 0); + ok(mr == MMSYSERR_NOERROR, "unprepare failed: 0x%x\n", mr); + + memset(&hdr, 0, sizeof(hdr)); + hdr.cbStruct = sizeof(hdr); + hdr.pbSrc = input; hdr.cbSrcLength = sizeof(input); hdr.pbDst = pcm; hdr.cbDstLength = sizeof(pcm); @@ -638,7 +665,8 @@ todo_wine ok(hdr.fdwStatus == ACMSTREAMHEADER_STATUSF_DONE, "header wasn't unprepared: 0x%x\n", hdr.fdwStatus); } else - ok(mr == MMSYSERR_INVALPARAM, "expected 11, got %d\n", mr); +todo_wine + ok(mr == MMSYSERR_INVALPARAM, "expected 0x0b, got 0x%x\n", mr); memset(&hdr, 0, sizeof(hdr)); hdr.cbStruct = sizeof(hdr);

1 0

Nikolay Sivov : oleaut32/tests: Some tests for SafeArrayDestroyData().
by Alexandre Julliard 01 Dec '15

01 Dec '15

Module: wine Branch: master Commit: b07ebe6815acbd14afc1dcf9b1335689667fc529 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b07ebe6815acbd14afc1dcf9b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Nov 30 23:28:44 2015 +0300 oleaut32/tests: Some tests for SafeArrayDestroyData(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oleaut32/tests/safearray.c | 75 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 67 insertions(+), 8 deletions(-) diff --git a/dlls/oleaut32/tests/safearray.c b/dlls/oleaut32/tests/safearray.c index 12e1f54..f57b886 100644 --- a/dlls/oleaut32/tests/safearray.c +++ b/dlls/oleaut32/tests/safearray.c @@ -1965,40 +1965,99 @@ static void test_SafeArrayChangeTypeEx(void) static void test_SafeArrayDestroyData (void) { - SAFEARRAYBOUND sab; + SAFEARRAYBOUND sab[2]; SAFEARRAY *sa; HRESULT hres; int value = 0xdeadbeef; LONG index[1]; void *temp_pvData; + USHORT features; - sab.lLbound = 0; - sab.cElements = 10; - sa = SafeArrayCreate(VT_INT, 1, &sab); + sab[0].lLbound = 0; + sab[0].cElements = 10; + sa = SafeArrayCreate(VT_INT, 1, sab); ok(sa != NULL, "Create() failed.\n"); - if (!sa) - return; + ok(sa->fFeatures == FADF_HAVEVARTYPE, "got 0x%x\n", sa->fFeatures); + index[0] = 1; SafeArrayPutElement (sa, index, &value); /* SafeArrayDestroyData shouldn't free pvData if FADF_STATIC is set. */ - sa->fFeatures |= FADF_STATIC; + features = (sa->fFeatures |= FADF_STATIC); temp_pvData = sa->pvData; hres = SafeArrayDestroyData(sa); ok(hres == S_OK, "SADData FADF_STATIC failed, error code %x.\n",hres); + ok(features == sa->fFeatures, "got 0x%x\n", sa->fFeatures); ok(sa->pvData == temp_pvData, "SADData FADF_STATIC: pvData=%p, expected %p (fFeatures = %d).\n", sa->pvData, temp_pvData, sa->fFeatures); SafeArrayGetElement (sa, index, &value); ok(value == 0, "Data not cleared after SADData\n"); /* Clear FADF_STATIC, now really destroy the data. */ - sa->fFeatures ^= FADF_STATIC; + features = (sa->fFeatures ^= FADF_STATIC); hres = SafeArrayDestroyData(sa); ok(hres == S_OK, "SADData !FADF_STATIC failed, error code %x.\n",hres); + ok(features == sa->fFeatures, "got 0x%x\n", sa->fFeatures); ok(sa->pvData == NULL, "SADData !FADF_STATIC: pvData=%p, expected NULL.\n", sa->pvData); hres = SafeArrayDestroy(sa); ok(hres == S_OK, "SAD failed, error code %x.\n", hres); + + /* two dimensions */ + sab[0].lLbound = 0; + sab[0].cElements = 10; + sab[1].lLbound = 0; + sab[1].cElements = 10; + + sa = SafeArrayCreate(VT_INT, 2, sab); + ok(sa != NULL, "Create() failed.\n"); + ok(sa->fFeatures == FADF_HAVEVARTYPE, "got 0x%x\n", sa->fFeatures); + + features = sa->fFeatures; + hres = SafeArrayDestroyData(sa); + ok(hres == S_OK, "got 0x%08x\n",hres); + ok(features == sa->fFeatures, "got 0x%x\n", sa->fFeatures); + + SafeArrayDestroy(sa); + + /* try to destroy data from descriptor */ + hres = SafeArrayAllocDescriptor(1, &sa); + ok(hres == S_OK, "got 0x%08x\n", hres); + ok(sa->fFeatures == 0, "got 0x%x\n", sa->fFeatures); + + hres = SafeArrayDestroyData(sa); + ok(hres == S_OK, "got 0x%08x\n", hres); + ok(sa->fFeatures == 0, "got 0x%x\n", sa->fFeatures); + + hres = SafeArrayDestroyDescriptor(sa); + ok(hres == S_OK, "got 0x%08x\n", hres); + + hres = SafeArrayAllocDescriptor(2, &sa); + ok(hres == S_OK, "got 0x%08x\n", hres); + ok(sa->fFeatures == 0, "got 0x%x\n", sa->fFeatures); + + hres = SafeArrayDestroyData(sa); + ok(hres == S_OK, "got 0x%08x\n", hres); + ok(sa->fFeatures == 0, "got 0x%x\n", sa->fFeatures); + + hres = SafeArrayDestroyDescriptor(sa); + ok(hres == S_OK, "got 0x%08x\n", hres); + + /* vector case */ + sa = SafeArrayCreateVector(VT_I4, 0, 10); + ok(sa != NULL, "got %p\n", sa); + ok(sa->fFeatures == (FADF_CREATEVECTOR|FADF_HAVEVARTYPE), "got 0x%x\n", sa->fFeatures); + + ok(sa->pvData != NULL, "got %p\n", sa->pvData); + hres = SafeArrayDestroyData(sa); + ok(hres == S_OK, "got 0x%08x\n", hres); +todo_wine + ok(sa->fFeatures == FADF_HAVEVARTYPE, "got 0x%x\n", sa->fFeatures); + ok(sa->pvData != NULL, "got %p\n", sa->pvData); + /* There seems to be a bug on windows, especially visible on 64bit systems, + probably double-free of similar issue. */ + sa->pvData = NULL; + SafeArrayDestroy(sa); } static void test_safearray_layout(void)

1 0

Ken Thomases : winemac: Remove a window from the NSWorkspace notification center when it' s deallocated.
by Alexandre Julliard 01 Dec '15

01 Dec '15

Module: wine Branch: master Commit: ebcf8aadc54a12aa9359da109ea89608e417210c URL: http://source.winehq.org/git/wine.git/?a=commit;h=ebcf8aadc54a12aa9359da109… Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Nov 30 14:34:59 2015 -0600 winemac: Remove a window from the NSWorkspace notification center when it's deallocated. It was added as an observer in commit 3beec95a0. Failing to remove it caused the notification center to have a dangling pointer and caused crashes and hangs. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/cocoa_window.m | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index 75f5605..bcc1cf5 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -777,6 +777,7 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi - (void) dealloc { + [[[NSWorkspace sharedWorkspace] notificationCenter] removeObserver:self]; [[NSNotificationCenter defaultCenter] removeObserver:self]; [queue release]; [latentChildWindows release];

1 0

Ken Thomases : winemac: Don' t post a WINDOW_BROUGHT_FORWARD event for a click on a window which is already frontmost in its level.
by Alexandre Julliard 01 Dec '15

01 Dec '15

Module: wine Branch: master Commit: 5c992f965335ccb02a90ebcb10a881649cbab859 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c992f965335ccb02a90ebcb1… Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Nov 30 20:10:32 2015 -0600 winemac: Don't post a WINDOW_BROUGHT_FORWARD event for a click on a window which is already frontmost in its level. Commit 793ab7d45 fixed a bug where WINDOW_BROUGHT_FORWARD events weren't being posted when they should, but it caused a regression in Scribblenauts Unlimited. Every click caused a window ordering operation that generated messages and Scribblenauts would move the mouse cursor to the upper-left corner of the window in response. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/cocoa_app.m | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m index 3a80f1d..fb9edc2 100644 --- a/dlls/winemac.drv/cocoa_app.m +++ b/dlls/winemac.drv/cocoa_app.m @@ -1745,7 +1745,23 @@ static NSString* WineLocalizedString(unsigned int stringID) if (windowBroughtForward) { - [[windowBroughtForward ancestorWineWindow] postBroughtForwardEvent]; + WineWindow* ancestor = [windowBroughtForward ancestorWineWindow]; + NSInteger ancestorNumber = [ancestor windowNumber]; + NSInteger ancestorLevel = [ancestor level]; + + for (NSNumber* windowNumberObject in [NSWindow windowNumbersWithOptions:0]) + { + NSInteger windowNumber = [windowNumberObject integerValue]; + if (windowNumber == ancestorNumber) + break; + WineWindow* otherWindow = (WineWindow*)[NSApp windowWithWindowNumber:windowNumber]; + if ([otherWindow isKindOfClass:[WineWindow class]] && [otherWindow screen] && + [otherWindow level] <= ancestorLevel && otherWindow == [otherWindow ancestorWineWindow]) + { + [ancestor postBroughtForwardEvent]; + break; + } + } if (!process && ![windowBroughtForward isKeyWindow] && !windowBroughtForward.disabled && !windowBroughtForward.noActivate) [self windowGotFocus:windowBroughtForward]; }

1 0

Nikolay Sivov : oledlg: Replace existing menu item in case of empty object too.
by Alexandre Julliard 01 Dec '15

01 Dec '15

Module: wine Branch: master Commit: 93ff3fde8a7f04f7a363c4ee71d020ff2a51e911 URL: http://source.winehq.org/git/wine.git/?a=commit;h=93ff3fde8a7f04f7a363c4ee7… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Dec 1 04:13:38 2015 +0300 oledlg: Replace existing menu item in case of empty object too. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oledlg/oledlg_main.c | 1 + dlls/oledlg/tests/main.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+) diff --git a/dlls/oledlg/oledlg_main.c b/dlls/oledlg/oledlg_main.c index 87df968..8ba9f17 100644 --- a/dlls/oledlg/oledlg_main.c +++ b/dlls/oledlg/oledlg_main.c @@ -184,6 +184,7 @@ BOOL WINAPI OleUIAddVerbMenuW(IOleObject *object, LPCWSTR shorttype, LoadStringW(OLEDLG_hInstance, IDS_VERBMENU_OBJECT, resstrW, sizeof(resstrW)/sizeof(WCHAR)); /* no object, or object without enumeration support */ if (!object || !enumverbs) { + RemoveMenu(hMenu, uPos, MF_BYPOSITION); InsertMenuW(hMenu, uPos, MF_BYPOSITION|MF_STRING|MF_GRAYED, idmin, resstrW); return FALSE; } diff --git a/dlls/oledlg/tests/main.c b/dlls/oledlg/tests/main.c index 9c5e4bd..5d452f1 100644 --- a/dlls/oledlg/tests/main.c +++ b/dlls/oledlg/tests/main.c @@ -303,6 +303,7 @@ static IOleObject oleobject = { &oleobjectvtbl }; static void test_OleUIAddVerbMenu(void) { + static const WCHAR cadabraW[] = {'c','a','d','a','b','r','a',0}; HMENU hMenu, verbmenu; MENUITEMINFOW info; WCHAR buffW[50]; @@ -418,6 +419,72 @@ static void test_OleUIAddVerbMenu(void) ok(count == 5, "got %d\n", count); DestroyMenu(hMenu); + + /* try to add verb menu repeatedly, with same id */ + hMenu = CreatePopupMenu(); + + count = GetMenuItemCount(hMenu); + ok(count == 0, "got %d\n", count); + + verbmenu = NULL; + ret = OleUIAddVerbMenuW(NULL, NULL, hMenu, 0, 5, 10, TRUE, 3, &verbmenu); + ok(!ret, "got %d\n", ret); + ok(verbmenu == NULL, "got %p\n", verbmenu); + + count = GetMenuItemCount(hMenu); + ok(count == 1, "got %d\n", count); + + verbmenu = NULL; + ret = OleUIAddVerbMenuW(NULL, NULL, hMenu, 0, 5, 10, TRUE, 3, &verbmenu); + ok(!ret, "got %d\n", ret); + ok(verbmenu == NULL, "got %p\n", verbmenu); + + count = GetMenuItemCount(hMenu); + ok(count == 1, "got %d\n", count); + + /* same position, different id */ + verbmenu = NULL; + ret = OleUIAddVerbMenuW(NULL, NULL, hMenu, 0, 6, 10, TRUE, 3, &verbmenu); + ok(!ret, "got %d\n", ret); + ok(verbmenu == NULL, "got %p\n", verbmenu); + + count = GetMenuItemCount(hMenu); + ok(count == 1, "got %d\n", count); + + /* change added item string and state */ + memset(&info, 0, sizeof(info)); + info.cbSize = sizeof(info); + info.fMask = MIIM_STRING|MIIM_STATE; + info.fState = MFS_ENABLED; + info.dwTypeData = buffW; + lstrcpyW(buffW, cadabraW); + ret = SetMenuItemInfoW(hMenu, 0, TRUE, &info); + ok(ret, "got %d\n", ret); + + buffW[0] = 0; + GetMenuStringW(hMenu, 0, buffW, sizeof(buffW)/sizeof(buffW[0]), MF_BYPOSITION); + ok(!lstrcmpW(buffW, cadabraW), "got %s\n", wine_dbgstr_w(buffW)); + + verbmenu = NULL; + ret = OleUIAddVerbMenuW(NULL, NULL, hMenu, 0, 5, 10, TRUE, 3, &verbmenu); + ok(!ret, "got %d\n", ret); + ok(verbmenu == NULL, "got %p\n", verbmenu); + + memset(&info, 0, sizeof(info)); + info.cbSize = sizeof(info); + info.fMask = MIIM_STRING|MIIM_STATE; + buffW[0] = 0; + info.dwTypeData = buffW; + info.cch = sizeof(buffW)/sizeof(WCHAR); + ret = GetMenuItemInfoW(hMenu, 0, TRUE, &info); + ok(ret, "got %d\n", ret); + ok(lstrcmpW(buffW, cadabraW), "got %s\n", wine_dbgstr_w(buffW)); + ok(info.fState == MF_GRAYED, "got state 0x%08x\n", info.fState); + + count = GetMenuItemCount(hMenu); + ok(count == 1, "got %d\n", count); + + DestroyMenu(hMenu); } START_TEST(main)

1 0