March 2015 - Wine-commits - list.winehq.org

Alexandre Julliard : Release 1.7.38.
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: d1578d8f1911b3248fc9bcfe4b4dc0ce3304e509 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1578d8f1911b3248fc9bcfe4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 6 22:27:36 2015 +0900 Release 1.7.38. --- ANNOUNCE | 728 +++++++++++++++++++++++++++++++++++++------------------------- VERSION | 2 +- configure | 18 +- 3 files changed, 446 insertions(+), 302 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d1578d8f1911b3248fc9b…

1 0

Tag wine-1.7.38 : Alexandre Julliard : Release 1.7.38
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: refs/tags/wine-1.7.38 Tag: a6ed54068259111cda554cc7773770334e7bf569 URL: http://source.winehq.org/git/wine.git/?a=tag;h=a6ed54068259111cda554cc77737… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 6 22:27:36 2015 +0900 Release 1.7.38

1 0

Michael Stefaniuc : msxml3/tests: Merge two adjacent if blocks with identical condition (PVS-Studio).
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: 7c4d45c00b362913501ec081fbd06b1f94e18117 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c4d45c00b362913501ec081f… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Mar 6 10:23:15 2015 +0100 msxml3/tests: Merge two adjacent if blocks with identical condition (PVS-Studio). --- dlls/msxml3/tests/domdoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index e669de4..f7f57ac 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -2235,10 +2235,9 @@ static void test_domnode( void ) ok( tag != NULL, "tag was null\n"); ok( !lstrcmpW( tag, szSSearch ), "incorrect tag name\n"); SysFreeString( tag ); - } - if (element) IXMLDOMElement_Release( element ); + } ok(IXMLDOMDocument_Release( doc ) == 0, "document is not destroyed\n"); free_bstrs();

1 0

Michael Stefaniuc : d3d9/tests: Remove no-op binary & with all 1's ( PVS-Studio).
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: 3730c99c2895dbe7ce23f99aa09a95ac3eb45f4d URL: http://source.winehq.org/git/wine.git/?a=commit;h=3730c99c2895dbe7ce23f99aa… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Mar 6 10:24:36 2015 +0100 d3d9/tests: Remove no-op binary & with all 1's (PVS-Studio). --- dlls/d3d9/tests/visual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index fcafb37..e7fdc94 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -99,7 +99,7 @@ static DWORD getPixelColorFromSurface(IDirect3DSurface9 *surface, UINT x, UINT y switch(desc.Format) { case D3DFMT_A8R8G8B8: { - color = ((DWORD *) lockedRect.pBits)[0] & 0xffffffff; + color = ((DWORD *) lockedRect.pBits)[0]; break; } default:

1 0

Nikolay Sivov : rpcrt4: Added inline helper to test for Oicf stub descriptions.
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: ecda8fd501854b12acb52f757070ae1c20c76192 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ecda8fd501854b12acb52f757… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Mar 6 14:35:42 2015 +0300 rpcrt4: Added inline helper to test for Oicf stub descriptions. --- dlls/rpcrt4/ndr_stubless.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/dlls/rpcrt4/ndr_stubless.c b/dlls/rpcrt4/ndr_stubless.c index cce0840..030bfb3 100644 --- a/dlls/rpcrt4/ndr_stubless.c +++ b/dlls/rpcrt4/ndr_stubless.c @@ -50,6 +50,11 @@ WINE_DEFAULT_DEBUG_CHANNEL(rpc); #define NDR_TABLE_MASK 127 +static inline BOOL is_oicf_stubdesc(const PMIDL_STUB_DESC pStubDesc) +{ + return pStubDesc->Version >= 0x20000; +} + static inline void call_buffer_sizer(PMIDL_STUB_MESSAGE pStubMsg, unsigned char *pMemory, const NDR_PARAM_OIF *param) { @@ -670,7 +675,7 @@ LONG_PTR CDECL ndr_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pForma if (!pFormat) goto done; } - if (pStubDesc->Version >= 0x20000) /* -Oicf format */ + if (is_oicf_stubdesc(pStubDesc)) /* -Oicf format */ { const NDR_PROC_PARTIAL_OIF_HEADER *pOIFHeader = (const NDR_PROC_PARTIAL_OIF_HEADER *)pFormat; @@ -1311,7 +1316,7 @@ LONG WINAPI NdrStubCall2( if (pThis) *(void **)args = ((CStdStubBuffer *)pThis)->pvServerObject; - if (pStubDesc->Version >= 0x20000) /* -Oicf format */ + if (is_oicf_stubdesc(pStubDesc)) { const NDR_PROC_PARTIAL_OIF_HEADER *pOIFHeader = (const NDR_PROC_PARTIAL_OIF_HEADER *)pFormat; @@ -1502,8 +1507,6 @@ LONG_PTR CDECL ndr_async_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING INTERPRETER_OPT_FLAGS2 ext_flags = { 0 }; /* header for procedure string */ const NDR_PROC_HEADER * pProcHeader = (const NDR_PROC_HEADER *)&pFormat[0]; - /* -Oif or -Oicf generated format */ - BOOL bV2Format = FALSE; RPC_STATUS status; TRACE("pStubDesc %p, pFormat %p, ...\n", pStubDesc, pFormat); @@ -1565,9 +1568,7 @@ LONG_PTR CDECL ndr_async_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pFormat = client_get_handle(pStubMsg, pProcHeader, async_call_data->pHandleFormat, &async_call_data->hBinding); if (!pFormat) goto done; - bV2Format = (pStubDesc->Version >= 0x20000); - - if (bV2Format) + if (is_oicf_stubdesc(pStubDesc)) { const NDR_PROC_PARTIAL_OIF_HEADER *pOIFHeader = (const NDR_PROC_PARTIAL_OIF_HEADER *)pFormat;

1 0

Sebastian Lackner : ws2_32: Avoid kernel32 functions in system APC calls.
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: 49cdebad4bc3373f2a5723fd5868e3c35e606d6e URL: http://source.winehq.org/git/wine.git/?a=commit;h=49cdebad4bc3373f2a5723fd5… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Fri Mar 6 07:12:11 2015 +0100 ws2_32: Avoid kernel32 functions in system APC calls. kernel32 functions might modify the last error, which should be avoided here. --- dlls/ws2_32/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 7e875e7..760e184 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -2079,7 +2079,7 @@ static NTSTATUS WS2_async_accept_recv( void *user, IO_STATUS_BLOCK *iosb, return status; if (wsa->user_overlapped->hEvent) - SetEvent(wsa->user_overlapped->hEvent); + NtSetEvent(wsa->user_overlapped->hEvent, NULL); if (wsa->cvalue) WS_AddCompletion( HANDLE2SOCKET(wsa->listen_socket), wsa->cvalue, iosb->u.Status, iosb->Information ); @@ -2165,7 +2165,7 @@ finish: iosb->Information = 0; if (wsa->user_overlapped->hEvent) - SetEvent(wsa->user_overlapped->hEvent); + NtSetEvent(wsa->user_overlapped->hEvent, NULL); if (wsa->read) release_async_io( &wsa->read->io ); release_async_io( &wsa->io );

1 0

Jacek Caban : mshtml: Return S_OK in IHTMLPluginsCollection::refresh.
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: 10fba143f797b493cbd9b8f87df0f4422892e53c URL: http://source.winehq.org/git/wine.git/?a=commit;h=10fba143f797b493cbd9b8f87… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Mar 6 13:01:29 2015 +0100 mshtml: Return S_OK in IHTMLPluginsCollection::refresh. --- dlls/mshtml/omnavigator.c | 7 +++++-- dlls/mshtml/tests/dom.c | 6 ++++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c index e943b70..c70fac6 100644 --- a/dlls/mshtml/omnavigator.c +++ b/dlls/mshtml/omnavigator.c @@ -459,8 +459,11 @@ static HRESULT WINAPI HTMLPluginsCollection_get_length(IHTMLPluginsCollection *i static HRESULT WINAPI HTMLPluginsCollection_refresh(IHTMLPluginsCollection *iface, VARIANT_BOOL reload) { HTMLPluginsCollection *This = impl_from_IHTMLPluginsCollection(iface); - FIXME("(%p)->(%x)\n", This, reload); - return E_NOTIMPL; + + TRACE("(%p)->(%x)\n", This, reload); + + /* Nothing to do here. */ + return S_OK; } static const IHTMLPluginsCollectionVtbl HTMLPluginsCollectionVtbl = { diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index d164f1b..37749a0 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5295,6 +5295,12 @@ static void test_plugins_col(IHTMLDocument2 *doc) ok(hres == S_OK, "get_length failed: %08x\n", hres); ok(!len, "length = %d\n", len); + hres = IHTMLPluginsCollection_refresh(col, VARIANT_FALSE); + ok(hres == S_OK, "refresh failed: %08x\n", hres); + + hres = IHTMLPluginsCollection_refresh(col, VARIANT_TRUE); + ok(hres == S_OK, "refresh failed: %08x\n", hres); + ref = IHTMLPluginsCollection_Release(col); ok(!ref, "ref=%d\n", ref);

1 0

Francois Gouget : hal: Remove unneeded NONAMELESSXXX directives.
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: 0cd192230252492ffee94822c81dca66f3c9a609 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0cd192230252492ffee94822c… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 5 17:31:39 2015 +0100 hal: Remove unneeded NONAMELESSXXX directives. --- dlls/hal/hal.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/hal/hal.c b/dlls/hal/hal.c index add9028..96bc895 100644 --- a/dlls/hal/hal.c +++ b/dlls/hal/hal.c @@ -23,9 +23,6 @@ #include <stdarg.h> -#define NONAMELESSUNION -#define NONAMELESSSTRUCT - #include "ntstatus.h" #define WIN32_NO_STATUS #include "windef.h"

1 0

Daniel Lehman : wininet: Eat terminator on last chunk.
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: c921deebf1c97a07a2c8424306e559693f1d1cf3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c921deebf1c97a07a2c842430… Author: Daniel Lehman <dlehman(a)esri.com> Date: Thu Mar 5 12:45:26 2015 -0800 wininet: Eat terminator on last chunk. --- dlls/wininet/http.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 328882e..04cd281 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -2763,8 +2763,19 @@ static DWORD start_next_chunk(chunked_stream_t *stream, http_request_t *req) if (req->contentLength == ~0u) req->contentLength = chunk_size; else req->contentLength += chunk_size; - if (!chunk_size) stream->end_of_data = TRUE; - return discard_chunked_eol(stream, req); + /* eat the rest of this line */ + if ((res = discard_chunked_eol(stream, req)) != ERROR_SUCCESS) + return res; + + /* if there's chunk data, return now */ + if (chunk_size) return ERROR_SUCCESS; + + /* otherwise, eat the terminator for this chunk */ + if ((res = discard_chunked_eol(stream, req)) != ERROR_SUCCESS) + return res; + + stream->end_of_data = TRUE; + return ERROR_SUCCESS; } remove_chunked_data(stream, 1); }

1 0

Nikolay Sivov : rpcrt4: Implement RPC_FC_CALLBACK_HANDLE handle type for NdrClientCall2().
by Alexandre Julliard 06 Mar '15

06 Mar '15

Module: wine Branch: master Commit: 2b40f9b01e45eed3c802062bba8369061a91003d URL: http://source.winehq.org/git/wine.git/?a=commit;h=2b40f9b01e45eed3c802062bb… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Mar 6 01:19:29 2015 +0300 rpcrt4: Implement RPC_FC_CALLBACK_HANDLE handle type for NdrClientCall2(). --- dlls/rpcrt4/ndr_stubless.c | 6 +++++- dlls/rpcrt4/ndr_stubless.h | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/rpcrt4/ndr_stubless.c b/dlls/rpcrt4/ndr_stubless.c index 346cc59..cce0840 100644 --- a/dlls/rpcrt4/ndr_stubless.c +++ b/dlls/rpcrt4/ndr_stubless.c @@ -344,7 +344,11 @@ static PFORMAT_STRING client_get_handle( *phBinding = *pStubMsg->StubDesc->IMPLICIT_HANDLE_INFO.pPrimitiveHandle; break; case RPC_FC_CALLBACK_HANDLE: /* implicit callback */ - FIXME("RPC_FC_CALLBACK_HANDLE\n"); + TRACE("RPC_FC_CALLBACK_HANDLE\n"); + /* server calls callback procedures only in response to remote call, and most recent + binding handle is used. Calling back to a client can potentially result in another + callback with different current handle. */ + *phBinding = I_RpcGetCurrentCallHandle(); break; case RPC_FC_AUTO_HANDLE: /* implicit auto handle */ /* strictly speaking, it isn't necessary to set hBinding here diff --git a/dlls/rpcrt4/ndr_stubless.h b/dlls/rpcrt4/ndr_stubless.h index 61bc606..5b0add0 100644 --- a/dlls/rpcrt4/ndr_stubless.h +++ b/dlls/rpcrt4/ndr_stubless.h @@ -35,7 +35,8 @@ typedef struct _NDR_PROC_HEADER * RPC_FC_BIND_PRIMITIVE = 32 - Implicit handle using handle_t created by * calling application * RPC_FC_AUTO_HANDLE = 33 - Automatic handle - * RPC_FC_CALLBACK_HANDLE = 34 - undocumented + * RPC_FC_CALLBACK_HANDLE = 34 - Implicit handle used for a callback: current handle + * from last remote call */ unsigned char handle_type;

1 0