June 2015 - Wine-commits - list.winehq.org

Nikolay Sivov : ole32/tests: Test if user memory routines are called, remove some useless traces.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: ff6201c61fde8c08b3eb8cf5217064a6779749a8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ff6201c61fde8c08b3eb8cf52… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 4 10:34:43 2015 +0300 ole32/tests: Test if user memory routines are called, remove some useless traces. --- dlls/ole32/tests/usrmarshal.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/ole32/tests/usrmarshal.c b/dlls/ole32/tests/usrmarshal.c index 51ccc59..83dedc7 100644 --- a/dlls/ole32/tests/usrmarshal.c +++ b/dlls/ole32/tests/usrmarshal.c @@ -44,13 +44,17 @@ unsigned char * __RPC_USER HMETAFILEPICT_UserMarshal (ULONG *, unsigned char *, unsigned char * __RPC_USER HMETAFILEPICT_UserUnmarshal(ULONG *, unsigned char *, HMETAFILEPICT *); void __RPC_USER HMETAFILEPICT_UserFree(ULONG *, HMETAFILEPICT *); +static BOOL g_expect_user_alloc; static void * WINAPI user_allocate(SIZE_T size) { + ok(g_expect_user_alloc, "unexpected user_allocate call\n"); return CoTaskMemAlloc(size); } +static BOOL g_expect_user_free; static void WINAPI user_free(void *p) { + ok(g_expect_user_free, "unexpected user_free call\n"); CoTaskMemFree(p); } @@ -201,7 +205,6 @@ static void test_marshal_HGLOBAL(void) GlobalUnlock(hglobal); actual_size = GlobalSize(hglobal); expected_size = actual_size + 5 * sizeof(DWORD); - trace("%d: actual size %d\n", block_size, actual_size); init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, NULL, 0, MSHCTX_LOCAL); size = HGLOBAL_UserSize(&umcb.Flags, 0, &hglobal); /* native is poorly programmed and allocates 4/8 bytes more than it needs to @@ -404,7 +407,6 @@ static void test_marshal_HMETAFILEPICT(void) init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, NULL, 0, MSHCTX_DIFFERENTMACHINE); size = HMETAFILEPICT_UserSize(&umcb.Flags, 0, &hmfp); ok(size > 20, "size should be at least 20 bytes, not %d\n", size); - trace("size is %d\n", size); buffer = HeapAlloc(GetProcessHeap(), 0, size); init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, buffer, size, MSHCTX_DIFFERENTMACHINE); buffer_end = HMETAFILEPICT_UserMarshal(&umcb.Flags, buffer, &hmfp); @@ -604,14 +606,12 @@ static void marshal_WdtpInterfacePointer(DWORD umcb_ctx, DWORD ctx) IStream_Seek(stm, zero, STREAM_SEEK_CUR, &pos); marshal_size = pos.u.LowPart; marshal_data = GlobalLock(h); - trace("marshal_size %x\n", marshal_size); todo_wine ok(Test_Unknown.refs == 2, "got %d\n", Test_Unknown.refs); init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, NULL, 0, umcb_ctx); size = WdtpInterfacePointer_UserSize(&umcb.Flags, ctx, 0, unk, &IID_IUnknown); ok(size >= marshal_size + 2 * sizeof(DWORD), "marshal size %x got %x\n", marshal_size, size); - trace("WdtpInterfacePointer_UserSize returned %x\n", size); buffer = HeapAlloc(GetProcessHeap(), 0, size); init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, buffer, size, umcb_ctx); buffer_end = WdtpInterfacePointer_UserMarshal(&umcb.Flags, ctx, buffer, unk, &IID_IUnknown); @@ -846,8 +846,10 @@ static void test_marshal_SNB(void) init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, buffer, size, MSHCTX_LOCAL); + g_expect_user_alloc = TRUE; snb2 = NULL; SNB_UserUnmarshal(&umcb.Flags, buffer, &snb2); + g_expect_user_alloc = FALSE; ptrW = snb2; ok(!lstrcmpW(*ptrW, str1W), "unmarshalled string 0: %s\n", wine_dbgstr_w(*ptrW)); @@ -858,7 +860,10 @@ static void test_marshal_SNB(void) HeapFree(GetProcessHeap(), 0, buffer); init_user_marshal_cb(&umcb, &stub_msg, &rpc_msg, NULL, 0, MSHCTX_LOCAL); + + g_expect_user_free = TRUE; SNB_UserFree(&umcb.Flags, &snb2); + g_expect_user_free = FALSE; } START_TEST(usrmarshal)

1 0

Nikolay Sivov : dwrite/tests: Test actual strings being reported to a renderer.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: 72dcc4d437d7bc4c3bdef9eee1acc2dfb45487b9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=72dcc4d437d7bc4c3bdef9eee… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 4 12:32:38 2015 +0300 dwrite/tests: Test actual strings being reported to a renderer. --- dlls/dwrite/tests/layout.c | 66 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 55 insertions(+), 11 deletions(-) diff --git a/dlls/dwrite/tests/layout.c b/dlls/dwrite/tests/layout.c index 77fa85c..472e01f 100644 --- a/dlls/dwrite/tests/layout.c +++ b/dlls/dwrite/tests/layout.c @@ -231,6 +231,7 @@ static const char *get_draw_kind_name(enum drawcall_kind kind) struct drawcall_entry { enum drawcall_kind kind; + WCHAR string[10]; /* only meaningful for DrawGlyphRun() */ }; struct drawcall_sequence @@ -326,6 +327,18 @@ static void ok_sequence_(struct drawcall_sequence **seq, int sequence_index, ok_(file, line) (0, "%s: call %s was expected, but got call %s instead\n", context, get_draw_kind_name(expected->kind), get_draw_kind_name(actual->kind)); } + else if (expected->kind == DRAW_GLYPHRUN) { + int cmp = lstrcmpW(expected->string, actual->string); + if (cmp != 0 && todo) { + failcount++; + todo_wine + ok_(file, line) (0, "%s: glyphrun string %s was expected, but got %s instead\n", + context, wine_dbgstr_w(expected->string), wine_dbgstr_w(actual->string)); + } + else + ok_(file, line) (cmp == 0, "%s: glyphrun string %s was expected, but got %s instead\n", + context, wine_dbgstr_w(expected->string), wine_dbgstr_w(actual->string)); + } expected++; actual++; } @@ -421,6 +434,14 @@ static HRESULT WINAPI testrenderer_DrawGlyphRun(IDWriteTextRenderer *iface, struct drawcall_entry entry; DWRITE_SCRIPT_ANALYSIS sa; + ok(descr->stringLength < sizeof(entry.string)/sizeof(WCHAR), "string is too long\n"); + if (descr->stringLength && descr->stringLength < sizeof(entry.string)/sizeof(WCHAR)) { + memcpy(entry.string, descr->string, descr->stringLength*sizeof(WCHAR)); + entry.string[descr->stringLength] = 0; + } + else + entry.string[0] = 0; + /* see what's reported for control codes runs */ get_script_analysis(descr->string, descr->stringLength, &sa); if (sa.script == g_control_sa.script) { @@ -1102,10 +1123,10 @@ static void test_SetInlineObject(void) /* drawing calls sequence doesn't depend on run order, instead all runs are drawn first, inline objects next and then underline/strikes */ static const struct drawcall_entry draw_seq[] = { - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, + { DRAW_GLYPHRUN, {'s',0} }, + { DRAW_GLYPHRUN, {'r','i',0} }, + { DRAW_GLYPHRUN, {'n',0} }, + { DRAW_GLYPHRUN, {'g',0} }, { DRAW_INLINE }, { DRAW_UNDERLINE }, { DRAW_STRIKETHROUGH }, @@ -1113,18 +1134,25 @@ static const struct drawcall_entry draw_seq[] = { }; static const struct drawcall_entry draw_seq2[] = { - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, + { DRAW_GLYPHRUN, {'s',0} }, + { DRAW_GLYPHRUN, {'t',0} }, + { DRAW_GLYPHRUN, {'r',0} }, + { DRAW_GLYPHRUN, {'i',0} }, + { DRAW_GLYPHRUN, {'n',0} }, + { DRAW_GLYPHRUN, {'g',0} }, { DRAW_LAST_KIND } }; static const struct drawcall_entry draw_seq3[] = { { DRAW_GLYPHRUN }, - { DRAW_GLYPHRUN }, + { DRAW_GLYPHRUN, {'a','b',0} }, + { DRAW_LAST_KIND } +}; + +static const struct drawcall_entry draw_seq4[] = { + { DRAW_GLYPHRUN, {'s','t','r',0} }, + { DRAW_GLYPHRUN, {'i','n','g',0} }, + { DRAW_STRIKETHROUGH }, { DRAW_LAST_KIND } }; @@ -1197,6 +1225,22 @@ static void test_Draw(void) ok_sequence(sequences, RENDERER_ID, draw_seq3, "draw test 3", TRUE); IDWriteTextLayout_Release(layout); + /* strikethrough splits ranges from renderer point of view, but doesn't break + shaping */ + hr = IDWriteFactory_CreateTextLayout(factory, strW, 6, format, 500.0, 100.0, &layout); + ok(hr == S_OK, "got 0x%08x\n", hr); + flush_sequence(sequences, RENDERER_ID); + + range.startPosition = 0; + range.length = 3; + hr = IDWriteTextLayout_SetStrikethrough(layout, TRUE, range); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = IDWriteTextLayout_Draw(layout, NULL, &testrenderer, 0.0, 0.0); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok_sequence(sequences, RENDERER_ID, draw_seq4, "draw test 4", TRUE); + IDWriteTextLayout_Release(layout); + IDWriteTextFormat_Release(format); IDWriteFactory_Release(factory); }

1 0

Nikolay Sivov : dwrite: Added a range data header to distinguish range kinds.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: 6d87a451a2942aada61f933b3f9a621589bbbb24 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6d87a451a2942aada61f933b3… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 4 13:37:01 2015 +0300 dwrite: Added a range data header to distinguish range kinds. --- dlls/dwrite/layout.c | 44 +++++++++++++++++++++++++++----------------- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/dlls/dwrite/layout.c b/dlls/dwrite/layout.c index 8f42433..1e70cf1 100644 --- a/dlls/dwrite/layout.c +++ b/dlls/dwrite/layout.c @@ -93,8 +93,17 @@ struct layout_range_attr_value { } u; }; -struct layout_range { +enum layout_range_kind { + LAYOUT_RANGE_REGULAR +}; + +struct layout_range_header { struct list entry; + enum layout_range_kind kind; +}; + +struct layout_range { + struct layout_range_header h; DWRITE_TEXT_RANGE range; DWRITE_FONT_WEIGHT weight; DWRITE_FONT_STYLE style; @@ -545,7 +554,7 @@ static HRESULT layout_compute_runs(struct dwrite_textlayout *layout) if (FAILED(hr)) return hr; - LIST_FOR_EACH_ENTRY(range, &layout->ranges, struct layout_range, entry) { + LIST_FOR_EACH_ENTRY(range, &layout->ranges, struct layout_range, h.entry) { /* inline objects override actual text in a range */ if (range->object) { hr = layout_update_breakpoints_range(layout, range); @@ -1056,6 +1065,7 @@ static struct layout_range *alloc_layout_range(struct dwrite_textlayout *layout, range = heap_alloc(sizeof(*range)); if (!range) return NULL; + range->h.kind = LAYOUT_RANGE_REGULAR; range->range = *r; range->weight = layout->format.weight; range->style = layout->format.style; @@ -1125,8 +1135,8 @@ static void free_layout_range(struct layout_range *range) static void free_layout_ranges_list(struct dwrite_textlayout *layout) { struct layout_range *cur, *cur2; - LIST_FOR_EACH_ENTRY_SAFE(cur, cur2, &layout->ranges, struct layout_range, entry) { - list_remove(&cur->entry); + LIST_FOR_EACH_ENTRY_SAFE(cur, cur2, &layout->ranges, struct layout_range, h.entry) { + list_remove(&cur->h.entry); free_layout_range(cur); } } @@ -1135,7 +1145,7 @@ static struct layout_range *find_outer_range(struct dwrite_textlayout *layout, c { struct layout_range *cur; - LIST_FOR_EACH_ENTRY(cur, &layout->ranges, struct layout_range, entry) { + LIST_FOR_EACH_ENTRY(cur, &layout->ranges, struct layout_range, h.entry) { if (cur->range.startPosition > range->startPosition) return NULL; @@ -1154,7 +1164,7 @@ static struct layout_range *get_layout_range_by_pos(struct dwrite_textlayout *la { struct layout_range *cur; - LIST_FOR_EACH_ENTRY(cur, &layout->ranges, struct layout_range, entry) { + LIST_FOR_EACH_ENTRY(cur, &layout->ranges, struct layout_range, h.entry) { DWRITE_TEXT_RANGE *r = &cur->range; if (r->startPosition <= pos && pos < r->startPosition + r->length) return cur; @@ -1279,7 +1289,7 @@ static HRESULT set_layout_range_attr(struct dwrite_textlayout *layout, enum layo if (!left) return E_OUTOFMEMORY; changed = set_layout_range_attrval(left, attr, value); - list_add_before(&outer->entry, &left->entry); + list_add_before(&outer->h.entry, &left->h.entry); outer->range.startPosition += value->range.length; outer->range.length -= value->range.length; goto done; @@ -1291,7 +1301,7 @@ static HRESULT set_layout_range_attr(struct dwrite_textlayout *layout, enum layo if (!right) return E_OUTOFMEMORY; changed = set_layout_range_attrval(right, attr, value); - list_add_after(&outer->entry, &right->entry); + list_add_after(&outer->h.entry, &right->h.entry); outer->range.length -= value->range.length; goto done; } @@ -1315,8 +1325,8 @@ static HRESULT set_layout_range_attr(struct dwrite_textlayout *layout, enum layo /* new part */ set_layout_range_attrval(cur, attr, value); - list_add_after(&outer->entry, &cur->entry); - list_add_after(&cur->entry, &right->entry); + list_add_after(&outer->h.entry, &cur->h.entry); + list_add_after(&cur->h.entry, &right->h.entry); return S_OK; } @@ -1332,14 +1342,14 @@ static HRESULT set_layout_range_attr(struct dwrite_textlayout *layout, enum layo left->range.length -= r.length; cur = alloc_layout_range_from(left, &r); changed = set_layout_range_attrval(cur, attr, value); - list_add_after(&left->entry, &cur->entry); + list_add_after(&left->h.entry, &cur->h.entry); } - cur = LIST_ENTRY(list_next(ranges, &left->entry), struct layout_range, entry); + cur = LIST_ENTRY(list_next(ranges, &left->h.entry), struct layout_range, h.entry); /* for all existing ranges covered by new one update value */ while (is_in_layout_range(&value->range, &cur->range)) { changed = set_layout_range_attrval(cur, attr, value); - cur = LIST_ENTRY(list_next(ranges, &cur->entry), struct layout_range, entry); + cur = LIST_ENTRY(list_next(ranges, &cur->h.entry), struct layout_range, h.entry); } /* it's possible rightmost range intersects */ @@ -1350,7 +1360,7 @@ static HRESULT set_layout_range_attr(struct dwrite_textlayout *layout, enum layo changed = set_layout_range_attrval(left, attr, value); cur->range.startPosition += left->range.length; cur->range.length -= left->range.length; - list_add_before(&cur->entry, &left->entry); + list_add_before(&cur->h.entry, &left->h.entry); } done: @@ -1360,9 +1370,9 @@ done: layout->recompute = RECOMPUTE_EVERYTHING; i = list_head(ranges); while ((next = list_next(ranges, i))) { - struct layout_range *next_range = LIST_ENTRY(next, struct layout_range, entry); + struct layout_range *next_range = LIST_ENTRY(next, struct layout_range, h.entry); - cur = LIST_ENTRY(i, struct layout_range, entry); + cur = LIST_ENTRY(i, struct layout_range, h.entry); if (is_same_layout_attributes(cur, next_range)) { /* remove similar range */ cur->range.length += next_range->range.length; @@ -3098,7 +3108,7 @@ static HRESULT init_textlayout(const WCHAR *str, UINT32 len, IDWriteTextFormat * goto fail; } - list_add_head(&layout->ranges, &range->entry); + list_add_head(&layout->ranges, &range->h.entry); return S_OK; fail:

1 0

Nikolay Sivov : dwrite: Store strikethrough settings in a separate list.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: e31881a6c9f7f01ec4534ae84cae5493901870aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=e31881a6c9f7f01ec4534ae84… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 4 17:55:26 2015 +0300 dwrite: Store strikethrough settings in a separate list. --- dlls/dwrite/layout.c | 372 ++++++++++++++++++++++++++++++++++----------------- 1 file changed, 250 insertions(+), 122 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e31881a6c9f7f01ec4534…

1 0

Nikolay Sivov : dwrite: Report strikethrough ranges to renderer.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: b8e3fbe0c1c9f94bee6d6ec5447a20f565106129 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b8e3fbe0c1c9f94bee6d6ec54… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 4 23:32:30 2015 +0300 dwrite: Report strikethrough ranges to renderer. --- dlls/dwrite/layout.c | 131 +++++++++++++++++++++++++++++++++++---------- dlls/dwrite/tests/layout.c | 25 ++++++++- 2 files changed, 127 insertions(+), 29 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=b8e3fbe0c1c9f94bee6d6…

1 0

Nikolay Sivov : dwrite/tests: Some tests for setting per-range layout properties.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: fc3ec1440482ad306a93746036694078807b059c URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc3ec1440482ad306a9374603… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Jun 5 11:24:54 2015 +0300 dwrite/tests: Some tests for setting per-range layout properties. --- dlls/dwrite/layout.c | 2 +- dlls/dwrite/tests/layout.c | 225 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 226 insertions(+), 1 deletion(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=fc3ec1440482ad306a937…

1 0

Ken Thomases : winemac: Remove extraneous CDECL attribute.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: 0c395c24e3f7a5849b92e9d479ce574e7ab27df4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0c395c24e3f7a5849b92e9d47… Author: Ken Thomases <ken(a)codeweavers.com> Date: Thu Jun 4 13:57:32 2015 -0500 winemac: Remove extraneous CDECL attribute. --- dlls/winemac.drv/macdrv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h index a874dfb..a31d7e3 100644 --- a/dlls/winemac.drv/macdrv.h +++ b/dlls/winemac.drv/macdrv.h @@ -197,7 +197,7 @@ extern void macdrv_clipboard_process_attach(void) DECLSPEC_HIDDEN; extern BOOL query_pasteboard_data(HWND hwnd, CFStringRef type) DECLSPEC_HIDDEN; extern const char *debugstr_format(UINT id) DECLSPEC_HIDDEN; extern HANDLE macdrv_get_pasteboard_data(CFTypeRef pasteboard, UINT desired_format) DECLSPEC_HIDDEN; -extern BOOL CDECL macdrv_pasteboard_has_format(CFTypeRef pasteboard, UINT desired_format) DECLSPEC_HIDDEN; +extern BOOL macdrv_pasteboard_has_format(CFTypeRef pasteboard, UINT desired_format) DECLSPEC_HIDDEN; extern CFArrayRef macdrv_copy_pasteboard_formats(CFTypeRef pasteboard) DECLSPEC_HIDDEN; extern BOOL query_drag_operation(macdrv_query* query) DECLSPEC_HIDDEN;

1 0

Ken Thomases : configure: Warn for a 64-bit build without CFI directive support.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: 8c60dc0706c8f7674b2bf0106555bc44ac971ae0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8c60dc0706c8f7674b2bf0106… Author: Ken Thomases <ken(a)codeweavers.com> Date: Thu Jun 4 13:57:59 2015 -0500 configure: Warn for a 64-bit build without CFI directive support. --- configure | 4 ++++ configure.ac | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/configure b/configure index f47c09e..279c3bc 100755 --- a/configure +++ b/configure @@ -14649,6 +14649,10 @@ $as_echo "#define __ASM_CFI(str) str" >>confdefs.h else $as_echo "#define __ASM_CFI(str) \"\"" >>confdefs.h + if test "x$enable_win64" = "xyes" + then + as_fn_append wine_warnings "|building 64-bit Wine without support for CFI directives; exception handling will not work properly." + fi fi asm_func_code="$asm_func_header\" code \"$asm_func_trailer" diff --git a/configure.ac b/configure.ac index c61a975..9b25196 100644 --- a/configure.ac +++ b/configure.ac @@ -1987,6 +1987,10 @@ then AC_SUBST([UNWINDFLAGS],[-fasynchronous-unwind-tables]) else AC_DEFINE([__ASM_CFI(str)],[""]) + if test "x$enable_win64" = "xyes" + then + WINE_WARNING([building 64-bit Wine without support for CFI directives; exception handling will not work properly.]) + fi fi asm_func_code="$asm_func_header\" code \"$asm_func_trailer"

1 0

Nikolay Sivov : shell32/tests: Fix tests failures on win2k.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: d5d49464d30582c904c199be21975562be3366c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d5d49464d30582c904c199be2… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 4 20:28:50 2015 +0300 shell32/tests: Fix tests failures on win2k. --- dlls/shell32/tests/shelldispatch.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/shell32/tests/shelldispatch.c b/dlls/shell32/tests/shelldispatch.c index 22eabf5..1f27cfa 100644 --- a/dlls/shell32/tests/shelldispatch.c +++ b/dlls/shell32/tests/shelldispatch.c @@ -451,7 +451,7 @@ if (0) /* crashes on pre-vista */ { disp = (void*)0xdeadbeef; hr = IShellView_GetItemObject(view, SVGIO_BACKGROUND, &IID_IShellFolderViewDual, (void**)&disp); - ok(hr == E_NOINTERFACE, "got 0x%08x\n", hr); + ok(hr == E_NOINTERFACE || broken(hr == E_NOTIMPL) /* win2k */, "got 0x%08x\n", hr); ok(disp == NULL, "got %p\n", disp); IShellView_Release(view); @@ -704,14 +704,14 @@ static void test_ParseName(void) item = (void*)0xdeadbeef; hr = Folder_ParseName(folder, NULL, &item); - ok(hr == S_FALSE, "got 0x%08x\n", hr); + ok(hr == S_FALSE || broken(hr == E_INVALIDARG) /* win2k */, "got 0x%08x\n", hr); ok(item == NULL, "got %p\n", item); /* empty name */ str = SysAllocStringLen(NULL, 0); item = (void*)0xdeadbeef; hr = Folder_ParseName(folder, str, &item); - ok(hr == S_FALSE, "got 0x%08x\n", hr); + ok(hr == S_FALSE || broken(hr == E_INVALIDARG) /* win2k */, "got 0x%08x\n", hr); ok(item == NULL, "got %p\n", item); SysFreeString(str); @@ -719,7 +719,7 @@ static void test_ParseName(void) str = SysAllocString(cadabraW); item = (void*)0xdeadbeef; hr = Folder_ParseName(folder, str, &item); - ok(hr == S_FALSE, "got 0x%08x\n", hr); + ok(hr == S_FALSE || broken(hr == E_INVALIDARG) /* win2k */, "got 0x%08x\n", hr); ok(item == NULL, "got %p\n", item); SysFreeString(str);

1 0

Sebastian Lackner : ntdll/tests: Don' t call lstrlenW on non-null-terminated buffer.
by Alexandre Julliard 05 Jun '15

05 Jun '15

Module: wine Branch: master Commit: d6a044c86a2977376341b6ac3a151366ec11d0a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6a044c86a2977376341b6ac3… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Jun 4 16:12:58 2015 +0200 ntdll/tests: Don't call lstrlenW on non-null-terminated buffer. --- dlls/ntdll/tests/directory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/tests/directory.c b/dlls/ntdll/tests/directory.c index 21aa31f..730b0f1 100644 --- a/dlls/ntdll/tests/directory.c +++ b/dlls/ntdll/tests/directory.c @@ -350,7 +350,7 @@ static void test_NtQueryDirectoryFile_case(void) } mask.Buffer = testmask; - mask.Length = mask.MaximumLength = lstrlenW(testmask) * sizeof(WCHAR); + mask.Length = mask.MaximumLength = sizeof(testmask); pNtQueryDirectoryFile(dirh, NULL, NULL, NULL, &io, data, data_size, FileBothDirectoryInformation, TRUE, &mask, FALSE); ok(U(io).Status == STATUS_SUCCESS, "failed to query directory; status %x\n", U(io).Status);

1 0