October 2016 - Wine-commits

Andrew Eikum : d2d1: Implement d2d_transformed_geometry_FillContainsPoint( ).
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: 930dd951b3e0325f05a6e28c0ff37480b04c0aeb URL: http://source.winehq.org/git/wine.git/?a=commit;h=930dd951b3e0325f05a6e28c0… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Oct 26 15:20:21 2016 +0200 d2d1: Implement d2d_transformed_geometry_FillContainsPoint(). Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/geometry.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/dlls/d2d1/geometry.c b/dlls/d2d1/geometry.c index 9fa1783..57dcce2 100644 --- a/dlls/d2d1/geometry.c +++ b/dlls/d2d1/geometry.c @@ -2627,10 +2627,17 @@ static HRESULT STDMETHODCALLTYPE d2d_transformed_geometry_StrokeContainsPoint(ID static HRESULT STDMETHODCALLTYPE d2d_transformed_geometry_FillContainsPoint(ID2D1TransformedGeometry *iface, D2D1_POINT_2F point, const D2D1_MATRIX_3X2_F *transform, float tolerance, BOOL *contains) { - FIXME("iface %p, point {%.8e, %.8e}, transform %p, tolerance %.8e, contains %p stub!\n", + struct d2d_geometry *geometry = impl_from_ID2D1TransformedGeometry(iface); + D2D1_MATRIX_3X2_F g; + + TRACE("iface %p, point {%.8e, %.8e}, transform %p, tolerance %.8e, contains %p.\n", iface, point.x, point.y, transform, tolerance, contains); - return E_NOTIMPL; + g = geometry->transform; + if (transform) + d2d_matrix_multiply(&g, transform); + + return ID2D1Geometry_FillContainsPoint(geometry->u.transformed.src_geometry, point, &g, tolerance, contains); } static HRESULT STDMETHODCALLTYPE d2d_transformed_geometry_CompareWithGeometry(ID2D1TransformedGeometry *iface,

1 0

Andrew Eikum : d2d1: Implement d2d_path_geometry_FillContainsPoint().
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: 2e08bc0ffca7ca425caf7c38afbe4503fad272dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=2e08bc0ffca7ca425caf7c38a… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Oct 26 15:20:22 2016 +0200 d2d1: Implement d2d_path_geometry_FillContainsPoint(). Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/d2d1_private.h | 23 +++++++++++++++++++++++ dlls/d2d1/geometry.c | 22 +++++++++++++++++++--- dlls/d2d1/render_target.c | 6 ------ 3 files changed, 42 insertions(+), 9 deletions(-) diff --git a/dlls/d2d1/d2d1_private.h b/dlls/d2d1/d2d1_private.h index b49fce4..8497ea8 100644 --- a/dlls/d2d1/d2d1_private.h +++ b/dlls/d2d1/d2d1_private.h @@ -357,4 +357,27 @@ static inline void d2d_matrix_multiply(D2D_MATRIX_3X2_F *a, const D2D_MATRIX_3X2 a->_32 = tmp._31 * b->_12 + tmp._32 * b->_22 + b->_32; } +/* Dst must be different from src. */ +static inline BOOL d2d_matrix_invert(D2D_MATRIX_3X2_F *dst, const D2D_MATRIX_3X2_F *src) +{ + float d = src->_11 * src->_22 - src->_21 * src->_12; + + if (d == 0.0f) + return FALSE; + dst->_11 = src->_22 / d; + dst->_21 = -src->_21 / d; + dst->_31 = (src->_21 * src->_32 - src->_31 * src->_22) / d; + dst->_12 = -src->_12 / d; + dst->_22 = src->_11 / d; + dst->_32 = -(src->_11 * src->_32 - src->_31 * src->_12) / d; + + return TRUE; +} + +static inline void d2d_point_transform(D2D1_POINT_2F *dst, const D2D1_MATRIX_3X2_F *matrix, float x, float y) +{ + dst->x = x * matrix->_11 + y * matrix->_21 + matrix->_31; + dst->y = x * matrix->_12 + y * matrix->_22 + matrix->_32; +} + #endif /* __WINE_D2D1_PRIVATE_H */ diff --git a/dlls/d2d1/geometry.c b/dlls/d2d1/geometry.c index 57dcce2..385e171 100644 --- a/dlls/d2d1/geometry.c +++ b/dlls/d2d1/geometry.c @@ -1924,9 +1924,11 @@ static HRESULT STDMETHODCALLTYPE d2d_geometry_sink_Close(ID2D1GeometrySink *ifac } done: - d2d_path_geometry_free_figures(geometry); if (FAILED(hr)) + { + d2d_path_geometry_free_figures(geometry); geometry->u.path.state = D2D_GEOMETRY_STATE_ERROR; + } return hr; } @@ -2112,10 +2114,24 @@ static HRESULT STDMETHODCALLTYPE d2d_path_geometry_StrokeContainsPoint(ID2D1Path static HRESULT STDMETHODCALLTYPE d2d_path_geometry_FillContainsPoint(ID2D1PathGeometry *iface, D2D1_POINT_2F point, const D2D1_MATRIX_3X2_F *transform, float tolerance, BOOL *contains) { - FIXME("iface %p, point {%.8e, %.8e}, transform %p, tolerance %.8e, contains %p stub!\n", + struct d2d_geometry *geometry = impl_from_ID2D1PathGeometry(iface); + D2D1_MATRIX_3X2_F g_i; + + TRACE("iface %p, point {%.8e, %.8e}, transform %p, tolerance %.8e, contains %p.\n", iface, point.x, point.y, transform, tolerance, contains); - return E_NOTIMPL; + if (transform) + { + if (!d2d_matrix_invert(&g_i, transform)) + return D2DERR_UNSUPPORTED_OPERATION; + d2d_point_transform(&point, &g_i, point.x, point.y); + } + + *contains = !!d2d_path_geometry_point_inside(geometry, &point); + + TRACE("-> %#x.\n", *contains); + + return S_OK; } static HRESULT STDMETHODCALLTYPE d2d_path_geometry_CompareWithGeometry(ID2D1PathGeometry *iface, diff --git a/dlls/d2d1/render_target.c b/dlls/d2d1/render_target.c index bc31f4d..798dd0d 100644 --- a/dlls/d2d1/render_target.c +++ b/dlls/d2d1/render_target.c @@ -48,12 +48,6 @@ static void d2d_point_set(D2D1_POINT_2F *dst, float x, float y) dst->y = y; } -static void d2d_point_transform(D2D1_POINT_2F *dst, const D2D1_MATRIX_3X2_F *matrix, float x, float y) -{ - dst->x = x * matrix->_11 + y * matrix->_21 + matrix->_31; - dst->y = x * matrix->_12 + y * matrix->_22 + matrix->_32; -} - static void d2d_rect_expand(D2D1_RECT_F *dst, const D2D1_POINT_2F *point) { if (point->x < dst->left)

1 0

Andrew Eikum : d2d1/tests: Add FillContainsPoint() tests.
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: aea8f9d6107621e2436b93acb2158405e2a75343 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aea8f9d6107621e2436b93acb… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Oct 26 15:20:23 2016 +0200 d2d1/tests: Add FillContainsPoint() tests. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/tests/d2d1.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c index d9d240c..b49ed7d 100644 --- a/dlls/d2d1/tests/d2d1.c +++ b/dlls/d2d1/tests/d2d1.c @@ -1313,12 +1313,12 @@ static void test_path_geometry(void) ID3D10Device1 *device; IDXGISurface *surface; ID2D1Factory *factory; + BOOL match, contains; D2D1_COLOR_F color; ULONG refcount; UINT32 count; HWND window; HRESULT hr; - BOOL match; if (!(device = create_device())) { @@ -1537,6 +1537,29 @@ static void test_path_geometry(void) ok(SUCCEEDED(hr), "Failed to end draw, hr %#x.\n", hr); match = compare_surface(surface, "3aace1b22aae111cb577614fed16e4eb1650dba5"); ok(match, "Surface does not match.\n"); + + /* Edge test. */ + set_point(&point, 94.0f, 620.0f); + contains = TRUE; + hr = ID2D1TransformedGeometry_FillContainsPoint(transformed_geometry, point, NULL, 0.0f, &contains); + ok(hr == S_OK, "FillContainsPoint failed, hr %#x.\n", hr); + ok(!contains, "Got unexpected contains %#x.\n", contains); + + set_point(&point, 95.0f, 620.0f); + contains = FALSE; + hr = ID2D1TransformedGeometry_FillContainsPoint(transformed_geometry, point, NULL, 0.0f, &contains); + ok(hr == S_OK, "FillContainsPoint failed, hr %#x.\n", hr); + ok(contains == TRUE, "Got unexpected contains %#x.\n", contains); + + /* With transformation matrix. */ + set_matrix_identity(&matrix); + translate_matrix(&matrix, -10.0f, 0.0f); + set_point(&point, 85.0f, 620.0f); + contains = FALSE; + hr = ID2D1TransformedGeometry_FillContainsPoint(transformed_geometry, point, &matrix, 0.0f, &contains); + ok(hr == S_OK, "FillContainsPoint failed, hr %#x.\n", hr); + ok(contains == TRUE, "Got unexpected contains %#x.\n", contains); + ID2D1TransformedGeometry_Release(transformed_geometry); ID2D1PathGeometry_Release(geometry);

1 0

Henri Verbeet : wined3d: Get rid of WINED3DFMT_FLAG_GETDC.
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: 6196e944a281f9e387535a8d070ab2a7ba605400 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6196e944a281f9e387535a8d0… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Oct 26 15:20:24 2016 +0200 wined3d: Get rid of WINED3DFMT_FLAG_GETDC. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/wined3d_private.h | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 4e7bb88..c56558d 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -3637,7 +3637,6 @@ extern enum wined3d_format_id pixelformat_for_depth(DWORD depth) DECLSPEC_HIDDEN #define WINED3DFMT_FLAG_RENDERTARGET 0x00000010 #define WINED3DFMT_FLAG_FBO_ATTACHABLE 0x00000040 #define WINED3DFMT_FLAG_FBO_ATTACHABLE_SRGB 0x00000080 -#define WINED3DFMT_FLAG_GETDC 0x00000100 #define WINED3DFMT_FLAG_FLOAT 0x00000200 #define WINED3DFMT_FLAG_BUMPMAP 0x00000400 #define WINED3DFMT_FLAG_SRGB_READ 0x00000800

1 0

Ken Thomases : winemac: Use min() rather than MIN(), which is not reliably defined.
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: 2a09548b5925f09e5709c13c005c6ca9a7d2e86b URL: http://source.winehq.org/git/wine.git/?a=commit;h=2a09548b5925f09e5709c13c0… Author: Ken Thomases <ken(a)codeweavers.com> Date: Wed Oct 26 10:58:35 2016 -0500 winemac: Use min() rather than MIN(), which is not reliably defined. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/clipboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winemac.drv/clipboard.c b/dlls/winemac.drv/clipboard.c index fc0d60c..d6a8c1f 100644 --- a/dlls/winemac.drv/clipboard.c +++ b/dlls/winemac.drv/clipboard.c @@ -439,7 +439,7 @@ static int bitmap_info_size(const BITMAPINFO *info, WORD coloruse) } else /* assume BITMAPINFOHEADER */ { - colors = MIN(info->bmiHeader.biClrUsed, 256); + colors = min(info->bmiHeader.biClrUsed, 256); if (!colors && (info->bmiHeader.biBitCount <= 8)) colors = 1 << info->bmiHeader.biBitCount; if (info->bmiHeader.biCompression == BI_BITFIELDS) masks = 3;

1 0

Aric Stewart : winebus.sys: Handle device reports for hidraw devices.
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: 1a81022f4e6359f4d6009057db1636041eabada9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1a81022f4e6359f4d6009057d… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Oct 26 10:49:41 2016 -0500 winebus.sys: Handle device reports for hidraw devices. Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus.h | 2 + dlls/winebus.sys/bus_udev.c | 75 +++++++++++++++++++ dlls/winebus.sys/main.c | 173 +++++++++++++++++++++++++++++++++++++++++--- 3 files changed, 238 insertions(+), 12 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1a81022f4e6359f4d6009…

1 0

Aric Stewart : hid: Implement HidD_SetOutputReport.
by Alexandre Julliard 26 Oct '16

26 Oct '16

Module: wine Branch: master Commit: fc1485b86b8554cacb0066162feee094de799583 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc1485b86b8554cacb0066162… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Oct 26 12:46:12 2016 -0500 hid: Implement HidD_SetOutputReport. Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hid/hid.spec | 2 +- dlls/hid/hidd.c | 6 ++++++ dlls/hidclass.sys/device.c | 12 ++++++------ include/ddk/hidsdi.h | 1 + 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/dlls/hid/hid.spec b/dlls/hid/hid.spec index 2131af2..91a83f6 100644 --- a/dlls/hid/hid.spec +++ b/dlls/hid/hid.spec @@ -17,7 +17,7 @@ @ stub HidD_SetConfiguration @ stdcall HidD_SetFeature(long ptr long) @ stdcall HidD_SetNumInputBuffers(long long) -@ stub HidD_SetOutputReport +@ stdcall HidD_SetOutputReport(long ptr long) @ stdcall HidP_GetButtonCaps(long ptr ptr ptr) @ stdcall HidP_GetCaps(ptr ptr) @ stub HidP_GetData diff --git a/dlls/hid/hidd.c b/dlls/hid/hidd.c index 31220ec..99665dd 100644 --- a/dlls/hid/hidd.c +++ b/dlls/hid/hidd.c @@ -133,3 +133,9 @@ BOOLEAN WINAPI HidD_GetPreparsedData(HANDLE HidDeviceObject, PHIDP_PREPARSED_DAT *PreparsedData = data; return TRUE; } + +BOOLEAN WINAPI HidD_SetOutputReport(HANDLE HidDeviceObject, void *ReportBuffer, ULONG ReportBufferLength) +{ + TRACE("(%p %p %u)\n", HidDeviceObject, ReportBuffer, ReportBufferLength); + return DeviceIoControl(HidDeviceObject, IOCTL_HID_SET_OUTPUT_REPORT, ReportBuffer, ReportBufferLength, NULL, 0, NULL, NULL); +} diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c index 45f88eb..bc871b9 100644 --- a/dlls/hidclass.sys/device.c +++ b/dlls/hidclass.sys/device.c @@ -463,21 +463,20 @@ static NTSTATUS HID_get_feature(DEVICE_OBJECT *device, IRP *irp) return rc; } -static NTSTATUS HID_set_feature(DEVICE_OBJECT *device, IRP *irp) +static NTSTATUS HID_set_to_device(DEVICE_OBJECT *device, IRP *irp) { - IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation( irp ); + IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation(irp); HID_XFER_PACKET packet; NTSTATUS rc; - irp->IoStatus.Information = 0; - TRACE_(hid_report)("Device %p Buffer length %i Buffer %p\n", device, irpsp->Parameters.DeviceIoControl.InputBufferLength, irp->AssociatedIrp.SystemBuffer); packet.reportBuffer = irp->AssociatedIrp.SystemBuffer; packet.reportId = ((char*)irp->AssociatedIrp.SystemBuffer)[0]; packet.reportBufferLen = irpsp->Parameters.DeviceIoControl.InputBufferLength; TRACE_(hid_report)("(id %i, len %i buffer %p)\n", packet.reportId, packet.reportBufferLen, packet.reportBuffer); - rc = call_minidriver(IOCTL_HID_SET_FEATURE, device, &packet, sizeof(packet), NULL, 0); + rc = call_minidriver(irpsp->Parameters.DeviceIoControl.IoControlCode, + device, NULL, 0, &packet, sizeof(packet)); irp->IoStatus.u.Status = rc; if (irp->IoStatus.u.Status == STATUS_SUCCESS) @@ -609,7 +608,8 @@ NTSTATUS WINAPI HID_Device_ioctl(DEVICE_OBJECT *device, IRP *irp) rc = HID_get_feature(device, irp); break; case IOCTL_HID_SET_FEATURE: - rc = HID_set_feature(device, irp); + case IOCTL_HID_SET_OUTPUT_REPORT: + rc = HID_set_to_device(device, irp); break; default: { diff --git a/include/ddk/hidsdi.h b/include/ddk/hidsdi.h index 75f2e3b..8b3b5a2 100644 --- a/include/ddk/hidsdi.h +++ b/include/ddk/hidsdi.h @@ -45,5 +45,6 @@ BOOLEAN WINAPI HidD_SetNumInputBuffers(HANDLE HidDeviceObject, ULONG NumberBuffe BOOLEAN WINAPI HidD_GetPreparsedData( HANDLE HidDeviceObject, PHIDP_PREPARSED_DATA *PreparsedData); BOOLEAN WINAPI HidD_FreePreparsedData(PHIDP_PREPARSED_DATA PreparsedData); BOOLEAN WINAPI HidD_GetAttributes(HANDLE HidDeviceObject, PHIDD_ATTRIBUTES Attr); +BOOLEAN WINAPI HidD_SetOutputReport(HANDLE HidDeviceObject, void *ReportBuffer, ULONG ReportBufferLength); #endif /* __WINE_HIDSDI_H */

1 0

Nikolay Sivov : uxtheme: Remove stub message for implemented functions.
by Alexandre Julliard 25 Oct '16

25 Oct '16

Module: wine Branch: master Commit: 456211e30735b02be37046bbd51a3c754409401a URL: http://source.winehq.org/git/wine.git/?a=commit;h=456211e30735b02be37046bbd… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Oct 25 08:21:27 2016 +0300 uxtheme: Remove stub message for implemented functions. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/draw.c | 2 +- dlls/uxtheme/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/uxtheme/draw.c b/dlls/uxtheme/draw.c index 8f0eabe..2a37a56 100644 --- a/dlls/uxtheme/draw.c +++ b/dlls/uxtheme/draw.c @@ -2016,7 +2016,7 @@ HRESULT WINAPI GetThemeTextExtent(HTHEME hTheme, HDC hdc, int iPartId, LOGFONTW logfont; RECT rt = {0,0,0xFFFF,0xFFFF}; - TRACE("%d %d: stub\n", iPartId, iStateId); + TRACE("%d %d\n", iPartId, iStateId); if(!hTheme) return E_HANDLE; diff --git a/dlls/uxtheme/main.c b/dlls/uxtheme/main.c index 5c0acf1..73894e8 100644 --- a/dlls/uxtheme/main.c +++ b/dlls/uxtheme/main.c @@ -35,7 +35,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(uxtheme); /* For the moment, do nothing here. */ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) { - TRACE("%p 0x%x %p: stub\n", hInstDLL, fdwReason, lpv); + TRACE("%p 0x%x %p\n", hInstDLL, fdwReason, lpv); switch(fdwReason) { case DLL_PROCESS_ATTACH: DisableThreadLibraryCalls(hInstDLL);

1 0

Nikolay Sivov : quartz: Remove stub messages for implemented methods.
by Alexandre Julliard 25 Oct '16

25 Oct '16

Module: wine Branch: master Commit: 1fbbd154fd6670a94f624b51a8442b9a3635f104 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1fbbd154fd6670a94f624b51a… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Oct 25 08:26:30 2016 +0300 quartz: Remove stub messages for implemented methods. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtermapper.c | 2 +- dlls/quartz/vmr9.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c index 8a1fc3a..4e4cb37 100644 --- a/dlls/quartz/filtermapper.c +++ b/dlls/quartz/filtermapper.c @@ -1157,7 +1157,7 @@ static HRESULT WINAPI FilterMapper_EnumMatchingFilters( REGFILTER* regfilters; HRESULT hr; - TRACE("(%p/%p)->(%p, %x, %s, %s, %s, %s, %s, %s, %s) stub!\n", + TRACE("(%p/%p)->(%p, %x, %s, %s, %s, %s, %s, %s, %s)\n", This, iface, ppEnum, diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index fb6745d..3c8393f 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -1256,7 +1256,7 @@ static HRESULT WINAPI VMR7FilterConfig_GetRenderingMode(IVMRFilterConfig *iface, { struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - TRACE("(%p/%p)->(%p) stub\n", iface, This, mode); + TRACE("(%p/%p)->(%p)\n", iface, This, mode); if (!mode) return E_POINTER; if (This->mode) @@ -1679,7 +1679,7 @@ static HRESULT WINAPI VMR9FilterConfig_GetRenderingMode(IVMRFilterConfig9 *iface { struct quartz_vmr *This = impl_from_IVMRFilterConfig9(iface); - TRACE("(%p/%p)->(%p) stub\n", iface, This, mode); + TRACE("(%p/%p)->(%p)\n", iface, This, mode); if (!mode) return E_POINTER;

1 0

Nikolay Sivov : advapi32: Remove stub message from implemented function.
by Alexandre Julliard 25 Oct '16

25 Oct '16

Module: wine Branch: master Commit: 8aed9e9074e489747d765165d5a479fbb223ba23 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8aed9e9074e489747d765165d… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Oct 25 08:37:39 2016 +0300 advapi32: Remove stub message from implemented function. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index 92a1789..28331df 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -791,7 +791,7 @@ BOOL WINAPI SetTokenInformation( HANDLE token, TOKEN_INFORMATION_CLASS tokeninfoclass, LPVOID tokeninfo, DWORD tokeninfolength ) { - TRACE("(%p, %s, %p, %d): stub\n", + TRACE("(%p, %s, %p, %d)\n", token, (tokeninfoclass == TokenUser) ? "TokenUser" : (tokeninfoclass == TokenGroups) ? "TokenGroups" :

1 0