July 2016 - Wine-commits - list.winehq.org

Michael Müller : ntdll: Do not sort InMemoryOrderModuleList by memory address.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: 77be592845591c05a574b720b15c49e7cd1720c7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=77be592845591c05a574b720b… Author: Michael Müller <michael(a)fds-team.de> Date: Thu Jul 7 06:43:25 2016 +0200 ntdll: Do not sort InMemoryOrderModuleList by memory address. Signed-off-by: Michael Müller <michael(a)fds-team.de> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index a0049fe..d9176d7 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -355,7 +355,6 @@ static WINE_MODREF *get_modref( HMODULE hmod ) mod = CONTAINING_RECORD(entry, LDR_MODULE, InMemoryOrderModuleList); if (mod->BaseAddress == hmod) return cached_modref = CONTAINING_RECORD(mod, WINE_MODREF, ldr); - if (mod->BaseAddress > (void*)hmod) break; } return NULL; } @@ -932,7 +931,6 @@ static WINE_MODREF *alloc_module( HMODULE hModule, LPCWSTR filename ) WINE_MODREF *wm; const WCHAR *p; const IMAGE_NT_HEADERS *nt = RtlImageNtHeader(hModule); - PLIST_ENTRY entry, mark; if (!(wm = RtlAllocateHeap( GetProcessHeap(), 0, sizeof(*wm) ))) return NULL; @@ -965,18 +963,8 @@ static WINE_MODREF *alloc_module( HMODULE hModule, LPCWSTR filename ) InsertTailList(&NtCurrentTeb()->Peb->LdrData->InLoadOrderModuleList, &wm->ldr.InLoadOrderModuleList); - - /* insert module in MemoryList, sorted in increasing base addresses */ - mark = &NtCurrentTeb()->Peb->LdrData->InMemoryOrderModuleList; - for (entry = mark->Flink; entry != mark; entry = entry->Flink) - { - if (CONTAINING_RECORD(entry, LDR_MODULE, InMemoryOrderModuleList)->BaseAddress > wm->ldr.BaseAddress) - break; - } - entry->Blink->Flink = &wm->ldr.InMemoryOrderModuleList; - wm->ldr.InMemoryOrderModuleList.Blink = entry->Blink; - wm->ldr.InMemoryOrderModuleList.Flink = entry; - entry->Blink = &wm->ldr.InMemoryOrderModuleList; + InsertTailList(&NtCurrentTeb()->Peb->LdrData->InMemoryOrderModuleList, + &wm->ldr.InMemoryOrderModuleList); /* wait until init is called for inserting into this list */ wm->ldr.InInitializationOrderModuleList.Flink = NULL; @@ -1386,7 +1374,6 @@ NTSTATUS WINAPI LdrFindEntryForAddress(const void* addr, PLDR_MODULE* pmod) *pmod = mod; return STATUS_SUCCESS; } - if (mod->BaseAddress > addr) break; } return STATUS_NO_MORE_ENTRIES; } @@ -3088,6 +3075,8 @@ void WINAPI LdrInitializeThunk( void *kernel_start, ULONG_PTR unknown2, /* the main exe needs to be the first in the load order list */ RemoveEntryList( &wm->ldr.InLoadOrderModuleList ); InsertHeadList( &peb->LdrData->InLoadOrderModuleList, &wm->ldr.InLoadOrderModuleList ); + RemoveEntryList( &wm->ldr.InMemoryOrderModuleList ); + InsertHeadList( &peb->LdrData->InMemoryOrderModuleList, &wm->ldr.InMemoryOrderModuleList ); if ((status = virtual_alloc_thread_stack( NtCurrentTeb(), 0, 0 )) != STATUS_SUCCESS) goto error; if ((status = server_init_process_done()) != STATUS_SUCCESS) goto error;

1 0

Sebastian Lackner : kernel32/tests: Add a test for sorting of InMemoryOrderModuleList.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: 648cbf63c003e0230352f91ddb7602c44d570706 URL: http://source.winehq.org/git/wine.git/?a=commit;h=648cbf63c003e0230352f91dd… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Jul 7 06:44:15 2016 +0200 kernel32/tests: Add a test for sorting of InMemoryOrderModuleList. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/loader.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c index c35cf25..921abb1 100644 --- a/dlls/kernel32/tests/loader.c +++ b/dlls/kernel32/tests/loader.c @@ -2750,6 +2750,24 @@ static void test_ResolveDelayLoadedAPI(void) DeleteFileA(dll_name); } +static void test_InMemoryOrderModuleList(void) +{ + LIST_ENTRY *entry1, *mark1 = &NtCurrentTeb()->Peb->LdrData->InLoadOrderModuleList; + LIST_ENTRY *entry2, *mark2 = &NtCurrentTeb()->Peb->LdrData->InMemoryOrderModuleList; + LDR_MODULE *module1, *module2; + + for (entry1 = mark1->Flink, entry2 = mark2->Flink; + entry1 != mark1 && entry2 != mark2; + entry1 = entry1->Flink, entry2 = entry2->Flink) + { + module1 = CONTAINING_RECORD(entry1, LDR_MODULE, InLoadOrderModuleList); + module2 = CONTAINING_RECORD(entry2, LDR_MODULE, InMemoryOrderModuleList); + ok(module1 == module2, "expected module1 == module2, got %p and %p\n", module1, module2); + } + ok(entry1 == mark1, "expected entry1 == mark1, got %p and %p\n", entry1, mark1); + ok(entry2 == mark2, "expected entry2 == mark2, got %p and %p\n", entry2, mark2); +} + START_TEST(loader) { int argc; @@ -2804,4 +2822,5 @@ START_TEST(loader) test_section_access(); test_import_resolution(); test_ExitProcess(); + test_InMemoryOrderModuleList(); }

1 0

Hadrien Boizard : winex11.drv: Use wine_dbgstr_point in TRACES.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: 81538ebb6dd4bed43006084a1514c1c96095a712 URL: http://source.winehq.org/git/wine.git/?a=commit;h=81538ebb6dd4bed43006084a1… Author: Hadrien Boizard <h.boizard(a)gmail.com> Date: Wed Jul 6 00:54:09 2016 +0200 winex11.drv: Use wine_dbgstr_point in TRACES. Signed-off-by: Hadrien Boizard <h.boizard(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/mouse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/mouse.c b/dlls/winex11.drv/mouse.c index 677acfa..7287753 100644 --- a/dlls/winex11.drv/mouse.c +++ b/dlls/winex11.drv/mouse.c @@ -1388,7 +1388,7 @@ BOOL CDECL X11DRV_GetCursorPos(LPPOINT pos) { POINT old = *pos; *pos = root_to_virtual_screen( winX, winY ); - TRACE( "pointer at (%d,%d) server pos %d,%d\n", pos->x, pos->y, old.x, old.y ); + TRACE( "pointer at %s server pos %s\n", wine_dbgstr_point(pos), wine_dbgstr_point(&old) ); } return ret; } @@ -1458,7 +1458,7 @@ void move_resize_window( HWND hwnd, int dir ) else if (GetKeyState( VK_MBUTTON ) & 0x8000) button = 2; else if (GetKeyState( VK_RBUTTON ) & 0x8000) button = 3; - TRACE( "hwnd %p/%lx, x %d, y %d, dir %d, button %d\n", hwnd, win, pos.x, pos.y, dir, button ); + TRACE( "hwnd %p/%lx, pos %s, dir %d, button %d\n", hwnd, win, wine_dbgstr_point(&pos), dir, button ); xev.xclient.type = ClientMessage; xev.xclient.window = win;

1 0

Nikolay Sivov : mmdevapi: Use regular list iterator.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: c5b6e31438df20b8ab6edb543a16e22ae4607522 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5b6e31438df20b8ab6edb543… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Jul 6 23:42:42 2016 +0300 mmdevapi: Use regular list iterator. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mmdevapi/devenum.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c index 1694bee..9e8d8a5 100644 --- a/dlls/mmdevapi/devenum.c +++ b/dlls/mmdevapi/devenum.c @@ -1281,7 +1281,7 @@ static HRESULT WINAPI MMDevEnum_RegisterEndpointNotificationCallback(IMMDeviceEn static HRESULT WINAPI MMDevEnum_UnregisterEndpointNotificationCallback(IMMDeviceEnumerator *iface, IMMNotificationClient *client) { MMDevEnumImpl *This = impl_from_IMMDeviceEnumerator(iface); - struct NotificationClientWrapper *wrapper, *wrapper2; + struct NotificationClientWrapper *wrapper; TRACE("(%p)->(%p)\n", This, client); @@ -1290,8 +1290,7 @@ static HRESULT WINAPI MMDevEnum_UnregisterEndpointNotificationCallback(IMMDevice EnterCriticalSection(&g_notif_lock); - LIST_FOR_EACH_ENTRY_SAFE(wrapper, wrapper2, &g_notif_clients, - struct NotificationClientWrapper, entry){ + LIST_FOR_EACH_ENTRY(wrapper, &g_notif_clients, struct NotificationClientWrapper, entry){ if(wrapper->client == client){ list_remove(&wrapper->entry); HeapFree(GetProcessHeap(), 0, wrapper);

1 0

Nikolay Sivov : crypt32: Use regular list iterator when there' s no need for safe one.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: 94b6a885a880728f5e0a865fc17a82532723e756 URL: http://source.winehq.org/git/wine.git/?a=commit;h=94b6a885a880728f5e0a865fc… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Jul 6 23:34:20 2016 +0300 crypt32: Use regular list iterator when there's no need for safe one. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/collectionstore.c | 9 ++++----- dlls/crypt32/proplist.c | 5 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/dlls/crypt32/collectionstore.c b/dlls/crypt32/collectionstore.c index f565745..8b90270 100644 --- a/dlls/crypt32/collectionstore.c +++ b/dlls/crypt32/collectionstore.c @@ -114,10 +114,10 @@ static BOOL CRYPT_CollectionAddContext(WINE_COLLECTIONSTORE *store, } else { - WINE_STORE_LIST_ENTRY *entry, *next; + WINE_STORE_LIST_ENTRY *entry; EnterCriticalSection(&store->cs); - LIST_FOR_EACH_ENTRY_SAFE(entry, next, &store->stores, WINE_STORE_LIST_ENTRY, entry) + LIST_FOR_EACH_ENTRY(entry, &store->stores, WINE_STORE_LIST_ENTRY, entry) { if (entry->dwUpdateFlags & CERT_PHYSICAL_STORE_ADD_ENABLE_FLAG) { @@ -559,7 +559,7 @@ void WINAPI CertRemoveStoreFromCollection(HCERTSTORE hCollectionStore, { WINE_COLLECTIONSTORE *collection = hCollectionStore; WINECRYPT_CERTSTORE *sibling = hSiblingStore; - WINE_STORE_LIST_ENTRY *store, *next; + WINE_STORE_LIST_ENTRY *store; TRACE("(%p, %p)\n", hCollectionStore, hSiblingStore); @@ -578,8 +578,7 @@ void WINAPI CertRemoveStoreFromCollection(HCERTSTORE hCollectionStore, return; } EnterCriticalSection(&collection->cs); - LIST_FOR_EACH_ENTRY_SAFE(store, next, &collection->stores, - WINE_STORE_LIST_ENTRY, entry) + LIST_FOR_EACH_ENTRY(store, &collection->stores, WINE_STORE_LIST_ENTRY, entry) { if (store->store == sibling) { diff --git a/dlls/crypt32/proplist.c b/dlls/crypt32/proplist.c index d849fd6..f5ae221 100644 --- a/dlls/crypt32/proplist.c +++ b/dlls/crypt32/proplist.c @@ -148,11 +148,10 @@ BOOL ContextPropertyList_SetProperty(CONTEXT_PROPERTY_LIST *list, DWORD id, void ContextPropertyList_RemoveProperty(CONTEXT_PROPERTY_LIST *list, DWORD id) { - CONTEXT_PROPERTY *prop, *next; + CONTEXT_PROPERTY *prop; EnterCriticalSection(&list->cs); - LIST_FOR_EACH_ENTRY_SAFE(prop, next, &list->properties, CONTEXT_PROPERTY, - entry) + LIST_FOR_EACH_ENTRY(prop, &list->properties, CONTEXT_PROPERTY, entry) { if (prop->propID == id) {

1 0

Michael Stefaniuc : riched20/tests: Use wine_dbgstr_rect() to print RECTs.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: f18f44c505bb4b36eeb690f95410dda484844aa8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f18f44c505bb4b36eeb690f95… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Jul 6 08:51:06 2016 +0200 riched20/tests: Use wine_dbgstr_rect() to print RECTs. Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/riched20/tests/editor.c | 72 +++++++++++++++++--------------------------- 1 file changed, 28 insertions(+), 44 deletions(-) diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c index fd5bcc4..76e2c97 100644 --- a/dlls/riched20/tests/editor.c +++ b/dlls/riched20/tests/editor.c @@ -7050,9 +7050,8 @@ static void test_format_rect(void) expected.left += 1; expected.right -= 1; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); for (n = -3; n <= 3; n++) { @@ -7066,19 +7065,16 @@ static void test_format_rect(void) expected.bottom = min(clientRect.bottom, rc.bottom); expected.right = min(clientRect.right, rc.right); SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), - "[n=%d] rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - n, rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "[n=%d] rect %s != %s\n", n, wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); } rc = clientRect; SendMessageA(hwnd, EM_SETRECT, 0, (LPARAM)&rc); expected = clientRect; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); /* Adding the selectionbar adds the selectionbar width to the left side. */ SendMessageA(hwnd, EM_SETOPTIONS, ECOOP_OR, ECO_SELECTIONBAR); @@ -7086,17 +7082,15 @@ static void test_format_rect(void) ok(options & ECO_SELECTIONBAR, "EM_SETOPTIONS failed to add selectionbar.\n"); expected.left += 8; /* selection bar width */ SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); rc = clientRect; SendMessageA(hwnd, EM_SETRECT, 0, (LPARAM)&rc); expected = clientRect; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); /* Removing the selectionbar subtracts the selectionbar width from the left side, * even if the left side is already 0. */ @@ -7105,19 +7099,16 @@ static void test_format_rect(void) ok(!(options & ECO_SELECTIONBAR), "EM_SETOPTIONS failed to remove selectionbar.\n"); expected.left -= 8; /* selection bar width */ SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); /* Set the absolute value of the formatting rectangle. */ rc = clientRect; SendMessageA(hwnd, EM_SETRECT, 0, (LPARAM)&rc); expected = clientRect; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), - "[n=%d] rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - n, rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "[n=%d] rect %s != %s\n", n, wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); /* MSDN documents the EM_SETRECT message as using the rectangle provided in * LPARAM as being a relative offset when the WPARAM value is 1, but these @@ -7129,9 +7120,8 @@ static void test_format_rect(void) expected = rc; SendMessageA(hwnd, EM_SETRECT, 1, (LPARAM)&rc); SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); /* For some reason it does not limit the values to the client rect with * a WPARAM value of 1. */ @@ -7142,9 +7132,8 @@ static void test_format_rect(void) expected = rc; SendMessageA(hwnd, EM_SETRECT, 1, (LPARAM)&rc); SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); /* Reset to default rect and check how the format rect adjusts to window * resize and how it copes with very small windows */ @@ -7157,9 +7146,8 @@ static void test_format_rect(void) expected.left += 1; expected.right -= 1; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); MoveWindow(hwnd, 0, 0, 0, 30, FALSE); GetClientRect(hwnd, &clientRect); @@ -7168,9 +7156,8 @@ static void test_format_rect(void) expected.left += 1; expected.right -= 1; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); MoveWindow(hwnd, 0, 0, 100, 0, FALSE); GetClientRect(hwnd, &clientRect); @@ -7179,9 +7166,8 @@ static void test_format_rect(void) expected.left += 1; expected.right -= 1; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); DestroyWindow(hwnd); @@ -7198,9 +7184,8 @@ static void test_format_rect(void) expected.top += 1; expected.right -= 1; SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); rc = clientRect; InflateRect(&rc, -5, -5); @@ -7210,9 +7195,8 @@ static void test_format_rect(void) expected.right += 1; SendMessageA(hwnd, EM_SETRECT, 0, (LPARAM)&rc); SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rc); - ok(EqualRect(&rc, &expected), "rect a(t=%d, l=%d, b=%d, r=%d) != e(t=%d, l=%d, b=%d, r=%d)\n", - rc.top, rc.left, rc.bottom, rc.right, - expected.top, expected.left, expected.bottom, expected.right); + ok(EqualRect(&rc, &expected), "rect %s != %s\n", wine_dbgstr_rect(&rc), + wine_dbgstr_rect(&expected)); DestroyWindow(hwnd); }

1 0

Michael Stefaniuc : wineps.drv: Use wine_dbgstr_rect() to print a RECT.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: b06b96595ba51e1dbf152c9d663b02f6346fa002 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b06b96595ba51e1dbf152c9d6… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Jul 6 08:59:27 2016 +0200 wineps.drv: Use wine_dbgstr_rect() to print a RECT. Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wineps.drv/escape.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/dlls/wineps.drv/escape.c b/dlls/wineps.drv/escape.c index 00a4a6c..435376c 100644 --- a/dlls/wineps.drv/escape.c +++ b/dlls/wineps.drv/escape.c @@ -129,14 +129,8 @@ INT PSDRV_ExtEscape( PHYSDEV dev, INT nEscape, INT cbInput, LPCVOID in_data, BANDINFOSTRUCT *ibi = (BANDINFOSTRUCT*)in_data; BANDINFOSTRUCT *obi = (BANDINFOSTRUCT*)out_data; - FIXME("BANDINFO(graphics %d, text %d, rect [%dx%d-%dx%d]), stub!\n", - ibi->GraphicsFlag, - ibi->TextFlag, - ibi->GraphicsRect.top, - ibi->GraphicsRect.bottom, - ibi->GraphicsRect.left, - ibi->GraphicsRect.right - ); + FIXME("BANDINFO(graphics %d, text %d, rect %s), stub!\n", ibi->GraphicsFlag, + ibi->TextFlag, wine_dbgstr_rect(&ibi->GraphicsRect)); *obi = *ibi; return 1; }

1 0

Francois Gouget : regedit: Make GetwideString() static.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: f099d0b19772c91829986a298d97f70ac3c1cd4b URL: http://source.winehq.org/git/wine.git/?a=commit;h=f099d0b19772c91829986a298… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jul 6 17:05:17 2016 +0200 regedit: Make GetwideString() static. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/regedit/regproc.c | 2 +- programs/regedit/regproc.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c index fee4030..353d5f9 100644 --- a/programs/regedit/regproc.c +++ b/programs/regedit/regproc.c @@ -68,7 +68,7 @@ if (!(p)) \ * Allocates memory and converts input from multibyte to wide chars * Returned string must be freed by the caller */ -WCHAR* GetWideString(const char* strA) +static WCHAR* GetWideString(const char* strA) { if(strA) { diff --git a/programs/regedit/regproc.h b/programs/regedit/regproc.h index 81223e0..2104e5f 100644 --- a/programs/regedit/regproc.h +++ b/programs/regedit/regproc.h @@ -25,5 +25,4 @@ BOOL export_registry_key(WCHAR *file_name, WCHAR *reg_key_name, DWORD format); BOOL import_registry_file(FILE *in); void delete_registry_key(WCHAR *reg_key_name); -WCHAR* GetWideString(const char* strA); CHAR* GetMultiByteString(const WCHAR* strW);

1 0

Kim Malmo : po: Update Norwegian translation.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: 7bfefeacbc0d4c0431a7b5a3490d26d2045d4320 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7bfefeacbc0d4c0431a7b5a34… Author: Kim Malmo <berencamlost(a)msn.com> Date: Wed Jul 6 17:57:11 2016 +0000 po: Update Norwegian translation. Signed-off-by: Kim Malmo <berencamlost(a)msn.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/nb_NO.po | 59 +++++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/po/nb_NO.po b/po/nb_NO.po index ff37757..9c167c3 100644 --- a/po/nb_NO.po +++ b/po/nb_NO.po @@ -11916,48 +11916,63 @@ msgid "" " regedit /E \"export.reg\" \"HKEY_CURRENT_USER\\Console\"\n" " regedit /D \"HKEY_LOCAL_MACHINE\\Error\\Path\"\n" msgstr "" +"Bruk:\n" +" regedit [alternativer] [filnavn] [reg_key]\n" +"\n" +"Alternativer:\n" +" [Ingen alt.] Kjør den grafiske versjonen av dette programmet.\n" +" /L:system.dat Plasseringen til system.dat filen som skal modifiseres.\n" +" Kompatibel med hvilken som helst annen bryter. Ignorert.\n" +" /R:user.dat Plasseringen til user.dat filen som skal modifiseres.\n" +" Kompatibel med hvilken som helst annen bryter. Ignorert.\n" +" /C Importér innholdet av en registerfil.\n" +" /D Slett en spesifikk registernøkkel.\n" +" /E Eksportér innholdet av en spesifikk registernøkkel til en " +"fil.\n" +" Hvis ingen nøkkel er spesifisert, er hele registeret " +"eksportert.\n" +" /S Stille modus. Ingen beskjeder vil bli vist.\n" +" /V Kjør GUI'et i avansert modus. Ignorert.\n" +" /? Vis denne informasjonen og avslutt.\n" +" [filnavn] Plasseringen til filen som inneholder registerinformasjonen " +"som\n" +" skal importeres. Når brukt med [/E], spesifiserer dette \n" +" alternativet plasseringen hvor registerinformasjonen vil \n" +" bli eksportert.\n" +" [reg_key] Registernøkkelen som skal modifiseres.\n" +"\n" +"Brukseksempler:\n" +" regedit \"import.reg\"\n" +" regedit /E \"export.reg\" \"HKEY_CURRENT_USER\\Console\"\n" +" regedit /D \"HKEY_LOCAL_MACHINE\\Error\\Path\"\n" #: regedit.rc:360 -#, fuzzy -#| msgid "" -#| "regsvr32: Invalid or unrecognized switch [%1]\n" -#| "\n" msgid "regedit: Invalid or unrecognized switch [%1]\n" -msgstr "regsvr32: Ugyldig eller ukjent bryter [%1]\n" +msgstr "regedit: Ugyldig eller ukjent bryter [%1]\n" #: regedit.rc:361 -#, fuzzy -#| msgid "Type \"REG /?\" for help.\n" msgid "Type \"regedit /?\" for help.\n" -msgstr "Skriv \"REG /?\" for hjelp.\n" +msgstr "Skriv \"regedit /?\" for hjelp.\n" #: regedit.rc:362 -#, fuzzy -#| msgid "No command was specified." msgid "regedit: No filename was specified.\n" -msgstr "Ingen kommando ble oppgitt." +msgstr "regedit: Intet filnavn ble oppgitt.\n" #: regedit.rc:363 msgid "regedit: No registry key was specified for removal.\n" -msgstr "" +msgstr "regedit: Ingen registernøkkel ble oppgitt for fjerning.\n" #: regedit.rc:364 -#, fuzzy -#| msgid "uninstaller: The application with GUID '%1' was not found\n" msgid "regedit: The file '%1' was not found.\n" -msgstr "uninstaller: Programmet med GUID %1 ble ikke funnet\n" +msgstr "regedit: Filen \"%1\" ble ikke funnet.\n" #: regedit.rc:365 -#, fuzzy -#| msgid "reg: Unable to access remote machine\n" msgid "regedit: Unable to open the file '%1'.\n" -msgstr "reg: Ingen tilgang til ekstern maskin\n" +msgstr "regedit: Kan ikke åpne filen \"%1\".\n" #: regedit.rc:366 -#, fuzzy -#| msgid "Invalid handle operation.\n" msgid "regedit: Unhandled action.\n" -msgstr "Ugyldig operasjon på referanse.\n" +msgstr "regedit: Uhåndtert handling.\n" #: regedit.rc:163 msgid "Quits the registry editor" @@ -13005,7 +13020,7 @@ msgid "" "WARNING: Debugging this process may result in loss of data.\n" "Are you sure you wish to attach the debugger?" msgstr "" -"ADVERSEL: Å feilsøke denne prosessen kan føre til tap av data.\n" +"ADVARSEL: Å feilsøke denne prosessen kan føre til tap av data.\n" "Er du sikker på at du vil koble til feilsøkeren?" #: taskmgr.rc:314

1 0

Lauri Kenttä : po: Update Finnish translation.
by Alexandre Julliard 07 Jul '16

07 Jul '16

Module: wine Branch: master Commit: fc1563591f1e201cd95330a8a1015d9401b8674a URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc1563591f1e201cd95330a8a… Author: Lauri Kenttä <lauri.kentta(a)gmail.com> Date: Wed Jul 6 23:01:01 2016 +0300 po: Update Finnish translation. Signed-off-by: Lauri Kenttä <lauri.kentta(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/fi.po | 55 ++++++++++++++++++++++++++++++++----------------------- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/po/fi.po b/po/fi.po index dd6a63b..752b050 100644 --- a/po/fi.po +++ b/po/fi.po @@ -11900,50 +11900,59 @@ msgid "" " regedit /E \"export.reg\" \"HKEY_CURRENT_USER\\Console\"\n" " regedit /D \"HKEY_LOCAL_MACHINE\\Error\\Path\"\n" msgstr "" +"Käyttö:\n" +" regedit [valitsimet] [tiedosto] [rek. avain]\n" +"\n" +"Valitsimet:\n" +" [ei mitään] Käynnistä tämän ohjelman graafinen versio.\n" +" /L:system.dat Muokattavan system.dat-tiedoston sijainti.\n" +" Sopii yhteen muiden valitsinten kanssa. Ei huomioida.\n" +" /R:user.dat Muokattavan user.dat-tiedoston sijainti.\n" +" Sopii yhteen muiden valitsinten kanssa. Ei huomioida.\n" +" /C Tuo rekisteritiedoston sisältö.\n" +" /D Poista määritelty rekisteriavain.\n" +" /E Vie valitun rekisteriavaimen sisältö tiedostoon.\n" +" Jos avainta ei määritellä, koko rekisteri viedään.\n" +" /S Hiljainen tila. Mitään viestejä ei näytetä.\n" +" /V Käynnistä tämä ohjelma edistyneessä tilassa. Ei huomioida.\n" +" /? Näytä nämä tiedot ja lopeta.\n" +" [tiedosto] Sen tiedoston polku, josta rekisteritietoja tuodaan.\n" +" Valitsimen [/E] yhteydessä sen tiedoston polku, johon\n" +" rekisteritiedot viedään.\n" +" [rek. avain] Rekisteriavain, jota muokataan.\n" +"\n" +"Käyttöesimerkkejä:\n" +" regedit \"tuotava.reg\"\n" +" regedit /E \"vietävä.reg\" \"HKEY_CURRENT_USER\\Console\"\n" +" regedit /D \"HKEY_LOCAL_MACHINE\\Error\\Path\"\n" #: regedit.rc:360 -#, fuzzy -#| msgid "" -#| "regsvr32: Invalid or unrecognized switch [%1]\n" -#| "\n" msgid "regedit: Invalid or unrecognized switch [%1]\n" -msgstr "" -"regsvr32: Virheellinen tai tuntematon valitsin [%1]\n" -"\n" +msgstr "regedit: Virheellinen tai tuntematon valitsin [%1]\n" #: regedit.rc:361 -#, fuzzy -#| msgid "Type \"REG /?\" for help.\n" msgid "Type \"regedit /?\" for help.\n" -msgstr "Komennolla \"REG /?\" saat apua.\n" +msgstr "Komennolla \"regedit /?\" saat apua.\n" #: regedit.rc:362 -#, fuzzy -#| msgid "No command was specified." msgid "regedit: No filename was specified.\n" -msgstr "Komentoa ei määritelty." +msgstr "regedit: Tiedostonimeä ei määritelty.\n" #: regedit.rc:363 msgid "regedit: No registry key was specified for removal.\n" -msgstr "" +msgstr "regedit: Poistettavaa rekisteriavainta ei määritelty.\n" #: regedit.rc:364 -#, fuzzy -#| msgid "uninstaller: The application with GUID '%1' was not found\n" msgid "regedit: The file '%1' was not found.\n" -msgstr "uninstaller: Ei löydy ohjelmaa, jonka GUID olisi '%1'\n" +msgstr "regedit: Tiedostoa '%1' ei löydy.\n" #: regedit.rc:365 -#, fuzzy -#| msgid "reg: Unable to access remote machine\n" msgid "regedit: Unable to open the file '%1'.\n" -msgstr "reg: Ei pääsyä etäkoneelle\n" +msgstr "regedit: Tiedostoa '%1' ei voida avata.\n" #: regedit.rc:366 -#, fuzzy -#| msgid "Invalid handle operation.\n" msgid "regedit: Unhandled action.\n" -msgstr "Kahvaoperaatio ei kelpaa.\n" +msgstr "regedit: Käsittelemätön toiminto.\n" #: regedit.rc:163 msgid "Quits the registry editor"

1 0