August 2016 - Wine-commits - list.winehq.org

Józef Kucia : wined3d: Add few missing formats.
by Alexandre Julliard 12 Aug '16

12 Aug '16

Module: wine Branch: master Commit: 4323924b2de57d1c04cf8ecdd2957519fbd7a551 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4323924b2de57d1c04cf8ecdd… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 11 12:57:24 2016 +0200 wined3d: Add few missing formats. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/utils.c | 12 ++++++++++++ dlls/dxgi/utils.c | 12 ++++++++++++ dlls/wined3d/utils.c | 4 ++++ include/wine/wined3d.h | 4 ++++ 4 files changed, 32 insertions(+) diff --git a/dlls/d3d11/utils.c b/dlls/d3d11/utils.c index 36cad41..370858e 100644 --- a/dlls/d3d11/utils.c +++ b/dlls/d3d11/utils.c @@ -139,10 +139,14 @@ const char *debug_dxgi_format(DXGI_FORMAT format) WINE_D3D_TO_STR(DXGI_FORMAT_B5G5R5A1_UNORM); WINE_D3D_TO_STR(DXGI_FORMAT_B8G8R8A8_UNORM); WINE_D3D_TO_STR(DXGI_FORMAT_B8G8R8X8_UNORM); + WINE_D3D_TO_STR(DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM); WINE_D3D_TO_STR(DXGI_FORMAT_B8G8R8A8_TYPELESS); WINE_D3D_TO_STR(DXGI_FORMAT_B8G8R8A8_UNORM_SRGB); WINE_D3D_TO_STR(DXGI_FORMAT_B8G8R8X8_TYPELESS); WINE_D3D_TO_STR(DXGI_FORMAT_B8G8R8X8_UNORM_SRGB); + WINE_D3D_TO_STR(DXGI_FORMAT_BC6H_TYPELESS); + WINE_D3D_TO_STR(DXGI_FORMAT_BC6H_UF16); + WINE_D3D_TO_STR(DXGI_FORMAT_BC6H_SF16); WINE_D3D_TO_STR(DXGI_FORMAT_BC7_TYPELESS); WINE_D3D_TO_STR(DXGI_FORMAT_BC7_UNORM); WINE_D3D_TO_STR(DXGI_FORMAT_BC7_UNORM_SRGB); @@ -255,10 +259,14 @@ DXGI_FORMAT dxgi_format_from_wined3dformat(enum wined3d_format_id format) case WINED3DFMT_B5G5R5A1_UNORM: return DXGI_FORMAT_B5G5R5A1_UNORM; case WINED3DFMT_B8G8R8A8_UNORM: return DXGI_FORMAT_B8G8R8A8_UNORM; case WINED3DFMT_B8G8R8X8_UNORM: return DXGI_FORMAT_B8G8R8X8_UNORM; + case WINED3DFMT_R10G10B10_XR_BIAS_A2_UNORM: return DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM; case WINED3DFMT_B8G8R8A8_TYPELESS: return DXGI_FORMAT_B8G8R8A8_TYPELESS; case WINED3DFMT_B8G8R8A8_UNORM_SRGB: return DXGI_FORMAT_B8G8R8A8_UNORM_SRGB; case WINED3DFMT_B8G8R8X8_TYPELESS: return DXGI_FORMAT_B8G8R8X8_TYPELESS; case WINED3DFMT_B8G8R8X8_UNORM_SRGB: return DXGI_FORMAT_B8G8R8X8_UNORM_SRGB; + case WINED3DFMT_BC6H_TYPELESS: return DXGI_FORMAT_BC6H_TYPELESS; + case WINED3DFMT_BC6H_UF16: return DXGI_FORMAT_BC6H_UF16; + case WINED3DFMT_BC6H_SF16: return DXGI_FORMAT_BC6H_SF16; case WINED3DFMT_BC7_TYPELESS: return DXGI_FORMAT_BC7_TYPELESS; case WINED3DFMT_BC7_UNORM: return DXGI_FORMAT_BC7_UNORM; case WINED3DFMT_BC7_UNORM_SRGB: return DXGI_FORMAT_BC7_UNORM_SRGB; @@ -361,10 +369,14 @@ enum wined3d_format_id wined3dformat_from_dxgi_format(DXGI_FORMAT format) case DXGI_FORMAT_B5G5R5A1_UNORM: return WINED3DFMT_B5G5R5A1_UNORM; case DXGI_FORMAT_B8G8R8A8_UNORM: return WINED3DFMT_B8G8R8A8_UNORM; case DXGI_FORMAT_B8G8R8X8_UNORM: return WINED3DFMT_B8G8R8X8_UNORM; + case DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM: return WINED3DFMT_R10G10B10_XR_BIAS_A2_UNORM; case DXGI_FORMAT_B8G8R8A8_TYPELESS: return WINED3DFMT_B8G8R8A8_TYPELESS; case DXGI_FORMAT_B8G8R8A8_UNORM_SRGB: return WINED3DFMT_B8G8R8A8_UNORM_SRGB; case DXGI_FORMAT_B8G8R8X8_TYPELESS: return WINED3DFMT_B8G8R8X8_TYPELESS; case DXGI_FORMAT_B8G8R8X8_UNORM_SRGB: return WINED3DFMT_B8G8R8X8_UNORM_SRGB; + case DXGI_FORMAT_BC6H_TYPELESS: return WINED3DFMT_BC6H_TYPELESS; + case DXGI_FORMAT_BC6H_UF16: return WINED3DFMT_BC6H_UF16; + case DXGI_FORMAT_BC6H_SF16: return WINED3DFMT_BC6H_SF16; case DXGI_FORMAT_BC7_TYPELESS: return WINED3DFMT_BC7_TYPELESS; case DXGI_FORMAT_BC7_UNORM: return WINED3DFMT_BC7_UNORM; case DXGI_FORMAT_BC7_UNORM_SRGB: return WINED3DFMT_BC7_UNORM_SRGB; diff --git a/dlls/dxgi/utils.c b/dlls/dxgi/utils.c index 9371de1..b9be4a5 100644 --- a/dlls/dxgi/utils.c +++ b/dlls/dxgi/utils.c @@ -137,10 +137,14 @@ const char *debug_dxgi_format(DXGI_FORMAT format) WINE_DXGI_TO_STR(DXGI_FORMAT_B5G5R5A1_UNORM); WINE_DXGI_TO_STR(DXGI_FORMAT_B8G8R8A8_UNORM); WINE_DXGI_TO_STR(DXGI_FORMAT_B8G8R8X8_UNORM); + WINE_DXGI_TO_STR(DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM); WINE_DXGI_TO_STR(DXGI_FORMAT_B8G8R8A8_TYPELESS); WINE_DXGI_TO_STR(DXGI_FORMAT_B8G8R8A8_UNORM_SRGB); WINE_DXGI_TO_STR(DXGI_FORMAT_B8G8R8X8_TYPELESS); WINE_DXGI_TO_STR(DXGI_FORMAT_B8G8R8X8_UNORM_SRGB); + WINE_DXGI_TO_STR(DXGI_FORMAT_BC6H_TYPELESS); + WINE_DXGI_TO_STR(DXGI_FORMAT_BC6H_UF16); + WINE_DXGI_TO_STR(DXGI_FORMAT_BC6H_SF16); WINE_DXGI_TO_STR(DXGI_FORMAT_BC7_TYPELESS); WINE_DXGI_TO_STR(DXGI_FORMAT_BC7_UNORM); WINE_DXGI_TO_STR(DXGI_FORMAT_BC7_UNORM_SRGB); @@ -245,10 +249,14 @@ DXGI_FORMAT dxgi_format_from_wined3dformat(enum wined3d_format_id format) case WINED3DFMT_B5G5R5A1_UNORM: return DXGI_FORMAT_B5G5R5A1_UNORM; case WINED3DFMT_B8G8R8A8_UNORM: return DXGI_FORMAT_B8G8R8A8_UNORM; case WINED3DFMT_B8G8R8X8_UNORM: return DXGI_FORMAT_B8G8R8X8_UNORM; + case WINED3DFMT_R10G10B10_XR_BIAS_A2_UNORM: return DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM; case WINED3DFMT_B8G8R8A8_TYPELESS: return DXGI_FORMAT_B8G8R8A8_TYPELESS; case WINED3DFMT_B8G8R8A8_UNORM_SRGB: return DXGI_FORMAT_B8G8R8A8_UNORM_SRGB; case WINED3DFMT_B8G8R8X8_TYPELESS: return DXGI_FORMAT_B8G8R8X8_TYPELESS; case WINED3DFMT_B8G8R8X8_UNORM_SRGB: return DXGI_FORMAT_B8G8R8X8_UNORM_SRGB; + case WINED3DFMT_BC6H_TYPELESS: return DXGI_FORMAT_BC6H_TYPELESS; + case WINED3DFMT_BC6H_UF16: return DXGI_FORMAT_BC6H_UF16; + case WINED3DFMT_BC6H_SF16: return DXGI_FORMAT_BC6H_SF16; case WINED3DFMT_BC7_TYPELESS: return DXGI_FORMAT_BC7_TYPELESS; case WINED3DFMT_BC7_UNORM: return DXGI_FORMAT_BC7_UNORM; case WINED3DFMT_BC7_UNORM_SRGB: return DXGI_FORMAT_BC7_UNORM_SRGB; @@ -351,10 +359,14 @@ enum wined3d_format_id wined3dformat_from_dxgi_format(DXGI_FORMAT format) case DXGI_FORMAT_B5G5R5A1_UNORM: return WINED3DFMT_B5G5R5A1_UNORM; case DXGI_FORMAT_B8G8R8A8_UNORM: return WINED3DFMT_B8G8R8A8_UNORM; case DXGI_FORMAT_B8G8R8X8_UNORM: return WINED3DFMT_B8G8R8X8_UNORM; + case DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM: return WINED3DFMT_R10G10B10_XR_BIAS_A2_UNORM; case DXGI_FORMAT_B8G8R8A8_TYPELESS: return WINED3DFMT_B8G8R8A8_TYPELESS; case DXGI_FORMAT_B8G8R8A8_UNORM_SRGB: return WINED3DFMT_B8G8R8A8_UNORM_SRGB; case DXGI_FORMAT_B8G8R8X8_TYPELESS: return WINED3DFMT_B8G8R8X8_TYPELESS; case DXGI_FORMAT_B8G8R8X8_UNORM_SRGB: return WINED3DFMT_B8G8R8X8_UNORM_SRGB; + case DXGI_FORMAT_BC6H_TYPELESS: return WINED3DFMT_BC6H_TYPELESS; + case DXGI_FORMAT_BC6H_UF16: return WINED3DFMT_BC6H_UF16; + case DXGI_FORMAT_BC6H_SF16: return WINED3DFMT_BC6H_SF16; case DXGI_FORMAT_BC7_TYPELESS: return WINED3DFMT_BC7_TYPELESS; case DXGI_FORMAT_BC7_UNORM: return WINED3DFMT_BC7_UNORM; case DXGI_FORMAT_BC7_UNORM_SRGB: return WINED3DFMT_BC7_UNORM_SRGB; diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 31d5014..f02220c 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -3671,6 +3671,7 @@ const char *debug_d3dformat(enum wined3d_format_id format_id) FMT_TO_STR(WINED3DFMT_R10G10B10A2_UNORM); FMT_TO_STR(WINED3DFMT_R10G10B10A2_UINT); FMT_TO_STR(WINED3DFMT_R10G10B10A2_SNORM); + FMT_TO_STR(WINED3DFMT_R10G10B10_XR_BIAS_A2_UNORM); FMT_TO_STR(WINED3DFMT_R11G11B10_FLOAT); FMT_TO_STR(WINED3DFMT_R8G8B8A8_TYPELESS); FMT_TO_STR(WINED3DFMT_R8G8B8A8_UNORM); @@ -3738,6 +3739,9 @@ const char *debug_d3dformat(enum wined3d_format_id format_id) FMT_TO_STR(WINED3DFMT_B8G8R8A8_UNORM_SRGB); FMT_TO_STR(WINED3DFMT_B8G8R8X8_TYPELESS); FMT_TO_STR(WINED3DFMT_B8G8R8X8_UNORM_SRGB); + FMT_TO_STR(WINED3DFMT_BC6H_TYPELESS); + FMT_TO_STR(WINED3DFMT_BC6H_UF16); + FMT_TO_STR(WINED3DFMT_BC6H_SF16); FMT_TO_STR(WINED3DFMT_BC7_TYPELESS); FMT_TO_STR(WINED3DFMT_BC7_UNORM); FMT_TO_STR(WINED3DFMT_BC7_UNORM_SRGB); diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 1e50020..1c9b262 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -151,6 +151,7 @@ enum wined3d_format_id WINED3DFMT_R10G10B10A2_UNORM, WINED3DFMT_R10G10B10A2_UINT, WINED3DFMT_R10G10B10A2_SNORM, + WINED3DFMT_R10G10B10_XR_BIAS_A2_UNORM, WINED3DFMT_R11G11B10_FLOAT, WINED3DFMT_R8G8B8A8_TYPELESS, WINED3DFMT_R8G8B8A8_UNORM, @@ -218,6 +219,9 @@ enum wined3d_format_id WINED3DFMT_B8G8R8A8_UNORM_SRGB, WINED3DFMT_B8G8R8X8_TYPELESS, WINED3DFMT_B8G8R8X8_UNORM_SRGB, + WINED3DFMT_BC6H_TYPELESS, + WINED3DFMT_BC6H_UF16, + WINED3DFMT_BC6H_SF16, WINED3DFMT_BC7_TYPELESS, WINED3DFMT_BC7_UNORM, WINED3DFMT_BC7_UNORM_SRGB,

1 0

Józef Kucia : d3d11/tests: Add initial test for required formats.
by Alexandre Julliard 12 Aug '16

12 Aug '16

Module: wine Branch: master Commit: ea8dd85ba9a1f6ac5be1e90efa455fabcb5907d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea8dd85ba9a1f6ac5be1e90ef… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 11 12:57:25 2016 +0200 d3d11/tests: Add initial test for required formats. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 101 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 0760917..e412c634 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -10247,6 +10247,106 @@ static void test_line_antialiasing_blending(void) release_test_context(&test_context); } +struct format_support +{ + DXGI_FORMAT format; + D3D_FEATURE_LEVEL fl_required; + D3D_FEATURE_LEVEL fl_optional; +}; + +static void check_format_support(const unsigned int *format_support, D3D_FEATURE_LEVEL feature_level, + const struct format_support *formats, unsigned int format_count, unsigned int feature_flag, + const char *feature_name) +{ + unsigned int i; + + for (i = 0; i < format_count; ++i) + { + DXGI_FORMAT format = formats[i].format; + unsigned int supported = format_support[format] & feature_flag; + + if (formats[i].fl_required <= feature_level) + { + ok(supported, "Format %#x - %s not supported, feature_level %#x, format support %#x.\n", + format, feature_name, feature_level, format_support[format]); + continue; + } + + if (formats[i].fl_optional <= feature_level) + continue; + + ok(!supported, "Format %#x - %s supported, feature level %#x, format support %#x.\n", + format, feature_name, feature_level, format_support[format]); + } +} + +static void test_required_format_support(void) +{ + unsigned int format_support[DXGI_FORMAT_B4G4R4A4_UNORM + 1]; + ID3D11Device *device; + DXGI_FORMAT format; + unsigned int i; + ULONG refcount; + HRESULT hr; + + static const struct format_support index_buffers[] = + { + {DXGI_FORMAT_R32_UINT, D3D_FEATURE_LEVEL_9_2}, + {DXGI_FORMAT_R16_UINT, D3D_FEATURE_LEVEL_9_1}, + }; + + static const struct format_support display[] = + { + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D_FEATURE_LEVEL_9_1}, + {DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, D3D_FEATURE_LEVEL_9_1}, + {DXGI_FORMAT_B8G8R8A8_UNORM, D3D_FEATURE_LEVEL_9_1}, + {DXGI_FORMAT_B8G8R8A8_UNORM_SRGB, D3D_FEATURE_LEVEL_9_1}, + {DXGI_FORMAT_R16G16B16A16_FLOAT, D3D_FEATURE_LEVEL_10_0}, + {DXGI_FORMAT_R10G10B10A2_UNORM, D3D_FEATURE_LEVEL_10_0}, + {DXGI_FORMAT_R10G10B10_XR_BIAS_A2_UNORM, D3D_FEATURE_LEVEL_11_0, D3D_FEATURE_LEVEL_10_0}, + }; + + for (i = 0; i < sizeof(d3d11_feature_levels) / sizeof(*d3d11_feature_levels); ++i) + { + D3D_FEATURE_LEVEL feature_level = d3d11_feature_levels[i]; + struct device_desc device_desc; + + device_desc.feature_level = &feature_level; + device_desc.flags = 0; + if (!(device = create_device(&device_desc))) + { + skip("Failed to create device for feature level %#x.\n", feature_level); + continue; + } + + memset(format_support, 0, sizeof(format_support)); + for (format = DXGI_FORMAT_UNKNOWN; format <= DXGI_FORMAT_B4G4R4A4_UNORM; ++format) + { + hr = ID3D11Device_CheckFormatSupport(device, format, &format_support[format]); + todo_wine ok(hr == S_OK || (hr == E_FAIL && !format_support[format]), + "Got unexpected result for format %#x: hr %#x, format_support %#x.\n", + format, hr, format_support[format]); + } + if (hr == E_NOTIMPL) + { + skip("CheckFormatSupport not implemented.\n"); + ID3D11Device_Release(device); + continue; + } + + check_format_support(format_support, feature_level, + index_buffers, sizeof(index_buffers) / sizeof(*index_buffers), + D3D11_FORMAT_SUPPORT_IA_INDEX_BUFFER, "index buffer"); + + check_format_support(format_support, feature_level, + display, sizeof(display) / sizeof(*display), + D3D11_FORMAT_SUPPORT_DISPLAY, "display"); + + refcount = ID3D11Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + } +} + START_TEST(d3d11) { test_create_device(); @@ -10303,4 +10403,5 @@ START_TEST(d3d11) test_index_buffer_offset(); test_face_culling(); test_line_antialiasing_blending(); + test_required_format_support(); }

1 0

Józef Kucia : d3d11/tests: Add test for swapchain views.
by Alexandre Julliard 12 Aug '16

12 Aug '16

Module: wine Branch: master Commit: 98adaffc55dab371c94f3fdbf276d85432f7a0b6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=98adaffc55dab371c94f3fdbf… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 11 12:57:26 2016 +0200 d3d11/tests: Add test for swapchain views. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index e412c634..05f7917 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -7481,6 +7481,49 @@ done: ok(!refcount, "Device has %u references left.\n", refcount); } +static void test_swapchain_views(void) +{ + D3D11_SHADER_RESOURCE_VIEW_DESC srv_desc; + struct d3d11_test_context test_context; + D3D11_RENDER_TARGET_VIEW_DESC rtv_desc; + ID3D11ShaderResourceView *srv; + ID3D11DeviceContext *context; + ID3D11RenderTargetView *rtv; + ID3D11Device *device; + HRESULT hr; + + static const struct vec4 color = {0.2f, 0.3f, 0.5f, 1.0f}; + + if (!init_test_context(&test_context, NULL)) + return; + + device = test_context.device; + context = test_context.immediate_context; + + draw_color_quad(&test_context, &color); + check_texture_color(test_context.backbuffer, 0xff7f4c33, 1); + + rtv_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM_SRGB; + rtv_desc.ViewDimension = D3D11_RTV_DIMENSION_TEXTURE2D; + U(rtv_desc).Texture2D.MipSlice = 0; + hr = ID3D11Device_CreateRenderTargetView(device, (ID3D11Resource *)test_context.backbuffer, &rtv_desc, &rtv); + ok(SUCCEEDED(hr), "Failed to create render target view, hr %#x.\n", hr); + ID3D11DeviceContext_OMSetRenderTargets(context, 1, &rtv, NULL); + + draw_color_quad(&test_context, &color); + todo_wine check_texture_color(test_context.backbuffer, 0xffbc957c, 1); + + srv_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM_SRGB; + rtv_desc.ViewDimension = D3D11_SRV_DIMENSION_TEXTURE2D; + U(srv_desc).Texture2D.MostDetailedMip = 0; + U(srv_desc).Texture2D.MipLevels = 1; + hr = ID3D11Device_CreateShaderResourceView(device, (ID3D11Resource *)test_context.backbuffer, &srv_desc, &srv); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + + ID3D11RenderTargetView_Release(rtv); + release_test_context(&test_context); +} + static void test_swapchain_flip(void) { ID3D11Texture2D *backbuffer_0, *backbuffer_1, *backbuffer_2, *offscreen; @@ -10383,6 +10426,7 @@ START_TEST(d3d11) test_buffer_data_init(); test_texture_data_init(); test_check_multisample_quality_levels(); + test_swapchain_views(); test_swapchain_flip(); test_clear_render_target_view(); test_clear_depth_stencil_view();

1 0

Józef Kucia : d3d11: Add support for feature level 9 shaders.
by Alexandre Julliard 12 Aug '16

12 Aug '16

Module: wine Branch: master Commit: 74eace2a379da2f80df51af12bcc5d77404ff192 URL: http://source.winehq.org/git/wine.git/?a=commit;h=74eace2a379da2f80df51af12… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 11 12:57:28 2016 +0200 d3d11: Add support for feature level 9 shaders. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/d3d11_private.h | 1 + dlls/d3d11/shader.c | 90 +++++++++++++++++++++++++++++++++++++++------- dlls/d3d11/tests/d3d11.c | 10 ++---- 3 files changed, 82 insertions(+), 19 deletions(-) diff --git a/dlls/d3d11/d3d11_private.h b/dlls/d3d11/d3d11_private.h index e9837cc..4af0faa 100644 --- a/dlls/d3d11/d3d11_private.h +++ b/dlls/d3d11/d3d11_private.h @@ -45,6 +45,7 @@ #define TAG_OSGN MAKE_TAG('O', 'S', 'G', 'N') #define TAG_SHDR MAKE_TAG('S', 'H', 'D', 'R') #define TAG_SHEX MAKE_TAG('S', 'H', 'E', 'X') +#define TAG_AON9 MAKE_TAG('A', 'o', 'n', '9') struct d3d_device; diff --git a/dlls/d3d11/shader.c b/dlls/d3d11/shader.c index 9f618e4..dab2b9b 100644 --- a/dlls/d3d11/shader.c +++ b/dlls/d3d11/shader.c @@ -24,47 +24,113 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d11); -static HRESULT shdr_handler(const char *data, DWORD data_size, DWORD tag, void *ctx) +struct aon9_header { - struct wined3d_shader_desc *desc = ctx; + DWORD chunk_size; + DWORD shader_version; + DWORD unknown; + DWORD byte_code_offset; +}; + +struct shader_handler_context +{ + D3D_FEATURE_LEVEL feature_level; + struct wined3d_shader_desc *desc; +}; + +static HRESULT shdr_handler(const char *data, DWORD data_size, DWORD tag, void *context) +{ + const struct shader_handler_context *ctx = context; + struct wined3d_shader_desc *desc = ctx->desc; HRESULT hr; switch (tag) { case TAG_ISGN: + if (ctx->feature_level <= D3D_FEATURE_LEVEL_9_3) + { + TRACE("Skipping shader input signature on feature level %#x.\n", ctx->feature_level); + break; + } if (FAILED(hr = shader_parse_signature(data, data_size, &desc->input_signature))) return hr; break; case TAG_OSGN: + if (ctx->feature_level <= D3D_FEATURE_LEVEL_9_3) + { + TRACE("Skipping shader output signature on feature level %#x.\n", ctx->feature_level); + break; + } if (FAILED(hr = shader_parse_signature(data, data_size, &desc->output_signature))) return hr; break; case TAG_SHDR: case TAG_SHEX: + if (ctx->feature_level <= D3D_FEATURE_LEVEL_9_3) + { + TRACE("Skipping SM4+ shader code on feature level %#x.\n", ctx->feature_level); + break; + } if (desc->byte_code) - FIXME("Multiple SHDR/SHEX chunks.\n"); + FIXME("Multiple shader code chunks.\n"); desc->byte_code = (const DWORD *)data; break; + case TAG_AON9: + if (ctx->feature_level <= D3D_FEATURE_LEVEL_9_3) + { + const struct aon9_header *header = (const struct aon9_header *)data; + unsigned int unknown_dword_count; + const char *byte_code; + + if (data_size < sizeof(*header)) + { + WARN("Invalid Aon9 data size %#x.\n", data_size); + return E_FAIL; + } + byte_code = data + header->byte_code_offset; + unknown_dword_count = (header->byte_code_offset - sizeof(*header)) / sizeof(DWORD); + + if (data_size - 2 * sizeof(DWORD) < header->byte_code_offset) + { + WARN("Invalid byte code offset %#x (size %#x).\n", header->byte_code_offset, data_size); + return E_FAIL; + } + FIXME("Skipping %u unknown DWORDs.\n", unknown_dword_count); + + if (desc->byte_code) + FIXME("Multiple shader code chunks.\n"); + desc->byte_code = (const DWORD *)byte_code; + TRACE("Feature level 9 shader version 0%08x, 0%08x.\n", header->shader_version, *desc->byte_code); + } + else + { + TRACE("Skipping feature level 9 shader code on feature level %#x.\n", ctx->feature_level); + break; + } + break; + default: - FIXME("Unhandled chunk %s\n", debugstr_an((const char *)&tag, 4)); + FIXME("Unhandled chunk %s.\n", debugstr_an((const char *)&tag, 4)); break; } return S_OK; } -static HRESULT shader_extract_from_dxbc(const void *dxbc, SIZE_T dxbc_length, struct wined3d_shader_desc *desc) +static HRESULT shader_extract_from_dxbc(const void *dxbc, SIZE_T dxbc_length, struct wined3d_shader_desc *desc, + D3D_FEATURE_LEVEL feature_level) { + struct shader_handler_context ctx = {feature_level, desc}; HRESULT hr; desc->byte_code = NULL; memset(&desc->input_signature, 0, sizeof(desc->input_signature)); memset(&desc->output_signature, 0, sizeof(desc->output_signature)); - hr = parse_dxbc(dxbc, dxbc_length, shdr_handler, desc); + hr = parse_dxbc(dxbc, dxbc_length, shdr_handler, &ctx); if (!desc->byte_code) hr = E_INVALIDARG; @@ -431,7 +497,7 @@ static HRESULT d3d_vertex_shader_init(struct d3d_vertex_shader *shader, struct d wined3d_mutex_lock(); wined3d_private_store_init(&shader->private_store); - if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc))) + if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc, device->feature_level))) { WARN("Failed to extract shader, hr %#x.\n", hr); wined3d_private_store_cleanup(&shader->private_store); @@ -637,7 +703,7 @@ static HRESULT d3d11_hull_shader_init(struct d3d11_hull_shader *shader, struct d wined3d_mutex_lock(); wined3d_private_store_init(&shader->private_store); - if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc))) + if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc, device->feature_level))) { WARN("Failed to extract shader, hr %#x.\n", hr); wined3d_private_store_cleanup(&shader->private_store); @@ -824,7 +890,7 @@ static HRESULT d3d11_domain_shader_init(struct d3d11_domain_shader *shader, stru wined3d_mutex_lock(); wined3d_private_store_init(&shader->private_store); - if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc))) + if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc, device->feature_level))) { WARN("Failed to extract shader, hr %#x.\n", hr); wined3d_private_store_cleanup(&shader->private_store); @@ -1115,7 +1181,7 @@ static HRESULT d3d_geometry_shader_init(struct d3d_geometry_shader *shader, stru wined3d_mutex_lock(); wined3d_private_store_init(&shader->private_store); - if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc))) + if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc, device->feature_level))) { WARN("Failed to extract shader, hr %#x.\n", hr); wined3d_private_store_cleanup(&shader->private_store); @@ -1432,7 +1498,7 @@ static HRESULT d3d_pixel_shader_init(struct d3d_pixel_shader *shader, struct d3d wined3d_mutex_lock(); wined3d_private_store_init(&shader->private_store); - if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc))) + if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc, device->feature_level))) { WARN("Failed to extract shader, hr %#x.\n", hr); wined3d_private_store_cleanup(&shader->private_store); @@ -1636,7 +1702,7 @@ static HRESULT d3d11_compute_shader_init(struct d3d11_compute_shader *shader, st wined3d_mutex_lock(); wined3d_private_store_init(&shader->private_store); - if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc))) + if (FAILED(hr = shader_extract_from_dxbc(byte_code, byte_code_length, &desc, device->feature_level))) { WARN("Failed to extract shader, hr %#x.\n", hr); wined3d_private_store_cleanup(&shader->private_store); diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 05f7917..07a3066 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -3717,7 +3717,6 @@ static void test_create_shader(void) for (i = 0; i < sizeof(d3d11_feature_levels) / sizeof(*d3d11_feature_levels); ++i) { D3D_FEATURE_LEVEL feature_level = d3d11_feature_levels[i]; - BOOL todo = feature_level <= D3D_FEATURE_LEVEL_9_3; struct device_desc device_desc; device_desc.feature_level = &feature_level; @@ -3730,20 +3729,17 @@ static void test_create_shader(void) /* level_9 shaders */ hr = ID3D11Device_CreatePixelShader(device, ps_4_0_level_9_0, sizeof(ps_4_0_level_9_0), NULL, &ps); - todo_wine_if(todo) - ok(SUCCEEDED(hr), "Failed to create ps_4_0_level_9_0 shader, hr %#x, feature level %#x.\n", hr, feature_level); + ok(SUCCEEDED(hr), "Failed to create ps_4_0_level_9_0 shader, hr %#x, feature level %#x.\n", hr, feature_level); if (SUCCEEDED(hr)) ID3D11PixelShader_Release(ps); hr = ID3D11Device_CreatePixelShader(device, ps_4_0_level_9_1, sizeof(ps_4_0_level_9_1), NULL, &ps); - todo_wine_if(todo) - ok(SUCCEEDED(hr), "Failed to create ps_4_0_level_9_1 shader, hr %#x, feature level %#x.\n", hr, feature_level); + ok(SUCCEEDED(hr), "Failed to create ps_4_0_level_9_1 shader, hr %#x, feature level %#x.\n", hr, feature_level); if (SUCCEEDED(hr)) ID3D11PixelShader_Release(ps); hr = ID3D11Device_CreatePixelShader(device, ps_4_0_level_9_3, sizeof(ps_4_0_level_9_3), NULL, &ps); - todo_wine_if(todo) - ok(SUCCEEDED(hr), "Failed to create ps_4_0_level_9_3 shader, hr %#x, feature level %#x.\n", hr, feature_level); + ok(SUCCEEDED(hr), "Failed to create ps_4_0_level_9_3 shader, hr %#x, feature level %#x.\n", hr, feature_level); if (SUCCEEDED(hr)) ID3D11PixelShader_Release(ps);

1 0

Hugh McMaster : server: Get and set the console pop-up color attributes.
by Alexandre Julliard 11 Aug '16

11 Aug '16

Module: wine Branch: master Commit: f592f931b2fe0eead1e136f7a087babc7efe23ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=f592f931b2fe0eead1e136f7a… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Wed Aug 10 10:01:57 2016 +0000 server: Get and set the console pop-up color attributes. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/wine/server_protocol.h | 24 +++++++++++++----------- programs/wineconsole/wineconsole.c | 3 ++- server/console.c | 9 ++++++++- server/protocol.def | 23 +++++++++++++---------- server/request.h | 34 ++++++++++++++++++---------------- server/trace.c | 2 ++ 6 files changed, 56 insertions(+), 39 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=f592f931b2fe0eead1e13…

1 0

Michael Stefaniuc : mmdevapi: Another use case for todo_wine_if().
by Alexandre Julliard 11 Aug '16

11 Aug '16

Module: wine Branch: master Commit: 4f06fd1490a759824ee27456df07b8103d7d72a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f06fd1490a759824ee27456d… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 9 22:28:37 2016 +0200 mmdevapi: Another use case for todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mmdevapi/tests/capture.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c index 749272a..99da296 100644 --- a/dlls/mmdevapi/tests/capture.c +++ b/dlls/mmdevapi/tests/capture.c @@ -309,19 +309,13 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) if(hr == S_OK){ /* The discontinuity is reported here, but is this an old or new packet? */ - if(!(flags & AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY)){ + todo_wine_if(!(flags & AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY)) { /* FIXME: Some drivers fail */ - todo_wine ok(flags & AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY, "expect DISCONTINUITY %x\n", flags); - todo_wine ok(pos == sum + frames, "Position %u gap %d\n", - (UINT)pos, (UINT)pos - sum); - }else{ ok(flags & AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY, "expect DISCONTINUITY %x\n", flags); - /* Native's position is one period further than what we read. * Perhaps that's precisely the meaning of DATA_DISCONTINUITY: * signal when the position jump left a gap. */ - ok(pos == sum + frames, "Position %u gap %d\n", - (UINT)pos, (UINT)pos - sum); + ok(pos == sum + frames, "Position %u gap %d\n", (UINT)pos, (UINT)pos - sum); } ok(pad == next, "GCP %u vs. BufferSize %u\n", (UINT32)pad, next);

1 0

Bruno Jesus : odbc32: Upgrade a WARN into ERR when the library is not found.
by Alexandre Julliard 11 Aug '16

11 Aug '16

Module: wine Branch: master Commit: dca0e38d82c737cd8aeab63e08cf1990d05d9671 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dca0e38d82c737cd8aeab63e0… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Tue Aug 9 18:06:47 2016 -0300 odbc32: Upgrade a WARN into ERR when the library is not found. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/odbc32/proxyodbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/odbc32/proxyodbc.c b/dlls/odbc32/proxyodbc.c index d7ebf10..aca0792 100644 --- a/dlls/odbc32/proxyodbc.c +++ b/dlls/odbc32/proxyodbc.c @@ -520,7 +520,7 @@ static BOOL ODBC_LoadDriverManager(void) return TRUE; } failed: - WARN("failed to open library %s: %s\n", debugstr_a(s), error); + ERR_(winediag)("failed to open library %s: %s\n", debugstr_a(s), error); nErrorType = ERROR_LIBRARY_NOT_FOUND; return FALSE; }

1 0

Nikolay Sivov : setupapi: Added CM_Get_Version().
by Alexandre Julliard 11 Aug '16

11 Aug '16

Module: wine Branch: master Commit: af533d1eebd382d7ee72eaaef1cf7461356da9e5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=af533d1eebd382d7ee72eaaef… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Aug 11 00:30:51 2016 +0300 setupapi: Added CM_Get_Version(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/cfgmgr32/cfgmgr32.spec | 2 +- dlls/setupapi/misc.c | 9 +++++++++ dlls/setupapi/setupapi.spec | 2 +- dlls/setupapi/tests/misc.c | 10 ++++++++++ include/cfgmgr32.h | 1 + 5 files changed, 22 insertions(+), 2 deletions(-) diff --git a/dlls/cfgmgr32/cfgmgr32.spec b/dlls/cfgmgr32/cfgmgr32.spec index 90a05ab..116180c 100644 --- a/dlls/cfgmgr32/cfgmgr32.spec +++ b/dlls/cfgmgr32/cfgmgr32.spec @@ -114,7 +114,7 @@ @ stub CM_Get_Res_Des_Data_Size_Ex @ stub CM_Get_Sibling @ stub CM_Get_Sibling_Ex -@ stub CM_Get_Version +@ stdcall CM_Get_Version() setupapi.CM_Get_Version @ stub CM_Get_Version_Ex @ stub CM_Intersect_Range_List @ stub CM_Invert_Range_List diff --git a/dlls/setupapi/misc.c b/dlls/setupapi/misc.c index de73966..98a6ed7 100644 --- a/dlls/setupapi/misc.c +++ b/dlls/setupapi/misc.c @@ -1751,3 +1751,12 @@ BOOL WINAPI SetupLogErrorW(LPCWSTR message, LogSeverity severity) HeapFree(GetProcessHeap(), 0, msg); return ret; } + +/*********************************************************************** + * CM_Get_Version (SETUPAPI.@) + */ +WORD WINAPI CM_Get_Version(void) +{ + TRACE("()\n"); + return 0x0400; +} diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec index 897572d..cc873ae 100644 --- a/dlls/setupapi/setupapi.spec +++ b/dlls/setupapi/setupapi.spec @@ -125,7 +125,7 @@ @ stub CM_Get_Res_Des_Data_Size_Ex @ stub CM_Get_Sibling @ stub CM_Get_Sibling_Ex -@ stub CM_Get_Version +@ stdcall CM_Get_Version() @ stub CM_Get_Version_Ex @ stub CM_Intersect_Range_List @ stub CM_Invert_Range_List diff --git a/dlls/setupapi/tests/misc.c b/dlls/setupapi/tests/misc.c index 09e0fb8..04b2171 100644 --- a/dlls/setupapi/tests/misc.c +++ b/dlls/setupapi/tests/misc.c @@ -29,6 +29,7 @@ #include "winuser.h" #include "winreg.h" #include "setupapi.h" +#include "cfgmgr32.h" #include "wine/test.h" @@ -816,6 +817,14 @@ static void test_SetupLogError(void) SetupCloseLog(); } +static void test_CM_Get_Version(void) +{ + WORD ret; + + ret = CM_Get_Version(); + ok(ret == 0x0400, "got version %#x\n", ret); +} + START_TEST(misc) { HMODULE hsetupapi = GetModuleHandleA("setupapi.dll"); @@ -849,4 +858,5 @@ START_TEST(misc) test_defaultcallback(); test_SetupLogError(); + test_CM_Get_Version(); } diff --git a/include/cfgmgr32.h b/include/cfgmgr32.h index e3966f9..7dc31e1 100644 --- a/include/cfgmgr32.h +++ b/include/cfgmgr32.h @@ -192,6 +192,7 @@ CMAPI CONFIGRET WINAPI CM_Get_Device_ID_List_ExW(PCWSTR,PWCHAR,ULONG,ULONG,HMACH #define CM_Get_Device_ID_List_Ex WINELIB_NAME_AW(CM_Get_Device_ID_List_Ex) CMAPI CONFIGRET WINAPI CM_Get_Device_ID_Size(PULONG,DEVINST,ULONG); CMAPI CONFIGRET WINAPI CM_Get_Device_ID_Size_Ex(PULONG,DEVINST,ULONG,HMACHINE); +CMAPI WORD WINAPI CM_Get_Version(void); CMAPI CONFIGRET WINAPI CM_Locate_DevNodeA(PDEVINST,DEVINSTID_A,ULONG); CMAPI CONFIGRET WINAPI CM_Locate_DevNodeW(PDEVINST,DEVINSTID_W,ULONG); #define CM_Locate_DevNode WINELIB_NAME_AW(CM_Locate_DevNode)

1 0

Alexandre Julliard : regedit: Don' t die if we fail to open a key during exporting.
by Alexandre Julliard 11 Aug '16

11 Aug '16

Module: wine Branch: master Commit: b90628c15e20694f3cc1add8c28e487bac00c2b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b90628c15e20694f3cc1add8c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Aug 11 13:48:42 2016 +0900 regedit: Don't die if we fail to open a key during exporting. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/regedit/regproc.c | 56 ++++++++-------------------------------------- 1 file changed, 9 insertions(+), 47 deletions(-) diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c index bc5c09c..e3e26c0 100644 --- a/programs/regedit/regproc.c +++ b/programs/regedit/regproc.c @@ -34,8 +34,6 @@ #include <wine/debug.h> #include "regproc.h" -WINE_DEFAULT_DEBUG_CHANNEL(regedit); - #define REG_VAL_BUF_SIZE 4096 /* maximal number of characters in hexadecimal data line, @@ -870,29 +868,6 @@ static void processRegLinesW(FILE *in) HeapFree(GetProcessHeap(), 0, buf); } -/**************************************************************************** - * REGPROC_print_error - * - * Print the message for GetLastError - */ - -static void REGPROC_print_error(void) -{ - WCHAR *str; - DWORD error_code, len; - - error_code = GetLastError(); - len = FormatMessageW(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, - NULL, error_code, 0, (WCHAR *)&str, 0, NULL); - if (len == 0 && GetLastError() != NO_ERROR) { - WINE_FIXME("FormatMessage failed: le=%u, previous=%u\n", GetLastError(), error_code); - exit(1); - } - output_writeconsole(str, len); - LocalFree(str); - exit(1); -} - /****************************************************************************** * Checks whether the buffer has enough room for the string or required size. * Resizes the buffer if necessary. @@ -1097,7 +1072,6 @@ static void export_hkey(FILE *file, HKEY key, DWORD max_val_size; DWORD curr_len; DWORD i; - BOOL more_data; LONG ret; WCHAR key_format[] = {'\r','\n','[','%','s',']','\r','\n',0}; @@ -1105,9 +1079,8 @@ static void export_hkey(FILE *file, HKEY key, if (RegQueryInfoKeyW(key, NULL, NULL, NULL, NULL, &max_sub_key_len, NULL, NULL, &max_val_name_len, &max_val_size, NULL, NULL - ) != ERROR_SUCCESS) { - REGPROC_print_error(); - } + ) != ERROR_SUCCESS) + return; curr_len = strlenW(*reg_key_name_buf); REGPROC_resize_char_buffer(reg_key_name_buf, reg_key_name_size, max_sub_key_len + curr_len + 1); @@ -1121,8 +1094,7 @@ static void export_hkey(FILE *file, HKEY key, /* print all the values */ i = 0; - more_data = TRUE; - while(more_data) { + for (;;) { DWORD value_type; DWORD val_name_size1 = *val_name_size; DWORD val_size1 = *val_size; @@ -1132,12 +1104,7 @@ static void export_hkey(FILE *file, HKEY key, /* Increase the size of the buffers and retry */ REGPROC_resize_char_buffer(val_name_buf, val_name_size, val_name_size1); REGPROC_resize_binary_buffer(val_buf, val_size, val_size1); - } else if (ret != ERROR_SUCCESS) { - more_data = FALSE; - if (ret != ERROR_NO_MORE_ITEMS) { - REGPROC_print_error(); - } - } else { + } else if (ret == ERROR_SUCCESS) { DWORD line_len; i++; @@ -1208,12 +1175,12 @@ static void export_hkey(FILE *file, HKEY key, } REGPROC_write_line(file, *line_buf, unicode); } + else break; } i = 0; - more_data = TRUE; (*reg_key_name_buf)[curr_len] = '\\'; - while(more_data) { + for (;;) { DWORD buf_size = *reg_key_name_size - curr_len - 1; ret = RegEnumKeyExW(key, i, *reg_key_name_buf + curr_len + 1, &buf_size, @@ -1221,12 +1188,7 @@ static void export_hkey(FILE *file, HKEY key, if (ret == ERROR_MORE_DATA) { /* Increase the size of the buffer and retry */ REGPROC_resize_char_buffer(reg_key_name_buf, reg_key_name_size, curr_len + 1 + buf_size); - } else if (ret != ERROR_SUCCESS) { - more_data = FALSE; - if (ret != ERROR_NO_MORE_ITEMS) { - REGPROC_print_error(); - } - } else { + } else if (ret == ERROR_SUCCESS) { HKEY subkey; i++; @@ -1236,10 +1198,10 @@ static void export_hkey(FILE *file, HKEY key, val_name_buf, val_name_size, val_buf, val_size, line_buf, line_buf_size, unicode); RegCloseKey(subkey); - } else { - REGPROC_print_error(); } + else break; } + else break; } (*reg_key_name_buf)[curr_len] = '\0'; }

1 0

Joerg Schiermeier : loader/wine.inf: Correct wrong symlink.
by Alexandre Julliard 11 Aug '16

11 Aug '16

Module: wine Branch: master Commit: 989bb04495ba6069552727995b333abc15f0e62f URL: http://source.winehq.org/git/wine.git/?a=commit;h=989bb04495ba6069552727995… Author: Joerg Schiermeier <mywine(a)Schiermeier-IT.de> Date: Wed Aug 10 15:07:05 2016 +0200 loader/wine.inf: Correct wrong symlink. Signed-off-by: Joerg Schiermeier <mywine(a)Schiermeier-IT.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- loader/wine.inf.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index 589a1ff..48fcb09 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -3313,7 +3313,7 @@ HKLM,Software\Wow6432Node\Microsoft\Notepad\DefaultFonts,"SymbolicLinkValue",0x6 HKLM,Software\Wow6432Node\Microsoft\OLE,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\OLE" HKLM,Software\Wow6432Node\Microsoft\RAS,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\RAS" HKLM,Software\Wow6432Node\Microsoft\RPC,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\RPC" -HKLM,Software\Wow6432Node\Microsoft\Software\Microsoft\Shared Tools\MSInfo,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\Software\Microsoft\Shared Tools\MSInfo" +HKLM,Software\Wow6432Node\Microsoft\Software\Microsoft\Shared Tools\MSInfo,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\Shared Tools\MSInfo" HKLM,Software\Wow6432Node\Microsoft\SystemCertificates,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\SystemCertificates" HKLM,Software\Wow6432Node\Microsoft\TermServLicensing,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\TermServLicensing" HKLM,Software\Wow6432Node\Microsoft\Transaction Server,"SymbolicLinkValue",0x60000,"\Registry\Machine\Software\Microsoft\Transaction Server"

1 0