August 2016 - Wine-commits - list.winehq.org

Józef Kucia : dxgi: Implement dxgi_swapchain_GetFullscreenState().
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: f586cc98a02b140678ceb59a3021bacdd90a36d6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f586cc98a02b140678ceb59a3… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:40 2016 +0200 dxgi: Implement dxgi_swapchain_GetFullscreenState(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/dxgi_private.h | 3 +++ dlls/dxgi/swapchain.c | 18 ++++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/dlls/dxgi/dxgi_private.h b/dlls/dxgi/dxgi_private.h index 680f835..7148811 100644 --- a/dlls/dxgi/dxgi_private.h +++ b/dlls/dxgi/dxgi_private.h @@ -160,6 +160,9 @@ struct dxgi_swapchain struct wined3d_swapchain *wined3d_swapchain; IWineDXGIDevice *device; IDXGIFactory *factory; + + BOOL fullscreen; + IDXGIOutput *target; }; HRESULT dxgi_swapchain_init(struct dxgi_swapchain *swapchain, struct dxgi_device *device, diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index 54bd52d..6b80ead 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -212,9 +212,21 @@ static HRESULT STDMETHODCALLTYPE DECLSPEC_HOTPATCH dxgi_swapchain_SetFullscreenS static HRESULT STDMETHODCALLTYPE dxgi_swapchain_GetFullscreenState(IDXGISwapChain *iface, BOOL *fullscreen, IDXGIOutput **target) { - FIXME("iface %p, fullscreen %p, target %p stub!\n", iface, fullscreen, target); + struct dxgi_swapchain *swapchain = impl_from_IDXGISwapChain(iface); - return E_NOTIMPL; + TRACE("iface %p, fullscreen %p, target %p.\n", iface, fullscreen, target); + + if (fullscreen) + *fullscreen = swapchain->fullscreen; + + if (target) + { + *target = swapchain->target; + if (*target) + IDXGIOutput_AddRef(*target); + } + + return S_OK; } static HRESULT STDMETHODCALLTYPE dxgi_swapchain_GetDesc(IDXGISwapChain *iface, DXGI_SWAP_CHAIN_DESC *desc) @@ -408,6 +420,8 @@ HRESULT dxgi_swapchain_init(struct dxgi_swapchain *swapchain, struct dxgi_device swapchain->IDXGISwapChain_iface.lpVtbl = &dxgi_swapchain_vtbl; swapchain->refcount = 1; + swapchain->fullscreen = FALSE; + swapchain->target = NULL; wined3d_mutex_lock(); wined3d_private_store_init(&swapchain->private_store);

1 0

Józef Kucia : dxgi: Implement dxgi_swapchain_SetFullscreenState().
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: bbc2d604ce156da4947d00f4cc64b9bd5e917138 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bbc2d604ce156da4947d00f4c… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:41 2016 +0200 dxgi: Implement dxgi_swapchain_SetFullscreenState(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/swapchain.c | 38 ++++++++++++++++++++++++++++++++++++-- dlls/dxgi/tests/device.c | 6 +++--- 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index 6b80ead..cdb28e4 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -204,9 +204,43 @@ static HRESULT STDMETHODCALLTYPE dxgi_swapchain_GetBuffer(IDXGISwapChain *iface, static HRESULT STDMETHODCALLTYPE DECLSPEC_HOTPATCH dxgi_swapchain_SetFullscreenState(IDXGISwapChain *iface, BOOL fullscreen, IDXGIOutput *target) { - FIXME("iface %p, fullscreen %#x, target %p stub!\n", iface, fullscreen, target); + struct dxgi_swapchain *swapchain = impl_from_IDXGISwapChain(iface); + struct wined3d_swapchain_desc swapchain_desc; + HRESULT hr; - return E_NOTIMPL; + TRACE("iface %p, fullscreen %#x, target %p.\n", iface, fullscreen, target); + + if (!fullscreen && target) + { + WARN("Invalid call.\n"); + return DXGI_ERROR_INVALID_CALL; + } + + if (fullscreen) + { + if (target) + { + IDXGIOutput_AddRef(target); + } + else if (FAILED(hr = IDXGISwapChain_GetContainingOutput(iface, &target))) + { + WARN("Failed to get default target output for swapchain, hr %#x.\n", hr); + return hr; + } + } + + swapchain->fullscreen = fullscreen; + if (swapchain->target) + IDXGIOutput_Release(swapchain->target); + swapchain->target = target; + + wined3d_mutex_lock(); + wined3d_swapchain_get_desc(swapchain->wined3d_swapchain, &swapchain_desc); + swapchain_desc.windowed = !fullscreen; + hr = wined3d_swapchain_set_fullscreen(swapchain->wined3d_swapchain, &swapchain_desc, NULL); + wined3d_mutex_unlock(); + + return hr; } static HRESULT STDMETHODCALLTYPE dxgi_swapchain_GetFullscreenState(IDXGISwapChain *iface, diff --git a/dlls/dxgi/tests/device.c b/dlls/dxgi/tests/device.c index 3c43895..9c0aa9d 100644 --- a/dlls/dxgi/tests/device.c +++ b/dlls/dxgi/tests/device.c @@ -545,7 +545,7 @@ static void test_create_swapchain(void) "Denominator %u is %u.\n", i ,result_desc.BufferDesc.RefreshRate.Denominator); hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); - todo_wine ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); IDXGISwapChain_Release(swapchain); } @@ -1301,7 +1301,7 @@ static void test_swapchain_parameters(void) if (FAILED(hr)) { hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); - todo_wine ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); IDXGISwapChain_Release(swapchain); continue; @@ -1357,7 +1357,7 @@ static void test_swapchain_parameters(void) ok(hr == DXGI_ERROR_INVALID_CALL, "GetBuffer(%u) returned unexpected hr %#x, test %u.\n", j, hr, i); hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); - todo_wine ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); IDXGISwapChain_Release(swapchain); }

1 0

Józef Kucia : dxgi: Switch display mode when creating fullscreen swapchains.
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 005a6c6396c7db6a61e534290ce56454b3412de0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=005a6c6396c7db6a61e534290… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:42 2016 +0200 dxgi: Switch display mode when creating fullscreen swapchains. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/swapchain.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index cdb28e4..3ea7d57 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -443,8 +443,7 @@ HRESULT dxgi_swapchain_init(struct dxgi_swapchain *swapchain, struct dxgi_device WARN("Failed to get adapter parent, hr %#x.\n", hr); return hr; } - swapchain->device = &device->IWineDXGIDevice_iface; - IWineDXGIDevice_AddRef(swapchain->device); + IWineDXGIDevice_AddRef(swapchain->device = &device->IWineDXGIDevice_iface); } else { @@ -454,8 +453,6 @@ HRESULT dxgi_swapchain_init(struct dxgi_swapchain *swapchain, struct dxgi_device swapchain->IDXGISwapChain_iface.lpVtbl = &dxgi_swapchain_vtbl; swapchain->refcount = 1; - swapchain->fullscreen = FALSE; - swapchain->target = NULL; wined3d_mutex_lock(); wined3d_private_store_init(&swapchain->private_store); @@ -463,15 +460,39 @@ HRESULT dxgi_swapchain_init(struct dxgi_swapchain *swapchain, struct dxgi_device &dxgi_swapchain_wined3d_parent_ops, &swapchain->wined3d_swapchain))) { WARN("Failed to create wined3d swapchain, hr %#x.\n", hr); - wined3d_private_store_cleanup(&swapchain->private_store); - wined3d_mutex_unlock(); - if (swapchain->factory) - IDXGIFactory_Release(swapchain->factory); - if (swapchain->device) - IWineDXGIDevice_Release(swapchain->device); - return hr; + goto cleanup; + } + + swapchain->fullscreen = !desc->windowed; + swapchain->target = NULL; + if (swapchain->fullscreen) + { + if (FAILED(hr = wined3d_swapchain_set_fullscreen(swapchain->wined3d_swapchain, + desc, NULL))) + { + WARN("Failed to set fullscreen state, hr %#x.\n", hr); + wined3d_swapchain_decref(swapchain->wined3d_swapchain); + goto cleanup; + } + + if (FAILED(hr = IDXGISwapChain_GetContainingOutput(&swapchain->IDXGISwapChain_iface, + &swapchain->target))) + { + WARN("Failed to get target output for fullscreen swapchain, hr %#x.\n", hr); + wined3d_swapchain_decref(swapchain->wined3d_swapchain); + goto cleanup; + } } wined3d_mutex_unlock(); return S_OK; + +cleanup: + wined3d_private_store_cleanup(&swapchain->private_store); + wined3d_mutex_unlock(); + if (swapchain->factory) + IDXGIFactory_Release(swapchain->factory); + if (swapchain->device) + IWineDXGIDevice_Release(swapchain->device); + return hr; }

1 0

Józef Kucia : dxgi: Return swapchain target output when available in dxgi_swapchain_GetContainingOutput ().
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 8b646aef63fda5916f4c14bef3d12be585d87b26 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b646aef63fda5916f4c14bef… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:43 2016 +0200 dxgi: Return swapchain target output when available in dxgi_swapchain_GetContainingOutput(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/swapchain.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index 3ea7d57..869c799 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -344,12 +344,19 @@ static HRESULT STDMETHODCALLTYPE dxgi_swapchain_ResizeTarget(IDXGISwapChain *ifa static HRESULT STDMETHODCALLTYPE dxgi_swapchain_GetContainingOutput(IDXGISwapChain *iface, IDXGIOutput **output) { + struct dxgi_swapchain *swapchain = impl_from_IDXGISwapChain(iface); IDXGIAdapter *adapter; IDXGIDevice *device; HRESULT hr; TRACE("iface %p, output %p.\n", iface, output); + if (swapchain->target) + { + IDXGIOutput_AddRef(*output = swapchain->target); + return S_OK; + } + if (FAILED(hr = dxgi_swapchain_GetDevice(iface, &IID_IDXGIDevice, (void **)&device))) return hr;

1 0

Józef Kucia : dxgi/tests: Add tests for IDXGISwapChain_GetFullscreenState() to test_create_swapchain().
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 587a4d9810764db22b9c547dd89c016b32bfb1a5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=587a4d9810764db22b9c547dd… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:44 2016 +0200 dxgi/tests: Add tests for IDXGISwapChain_GetFullscreenState() to test_create_swapchain(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 141 ++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 120 insertions(+), 21 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=587a4d9810764db22b9c5…

1 0

Józef Kucia : dxgi/tests: Add test for IDXGISwapChain_SetFullscreenState().
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 476cbd2f8ab9922459392b0656337a22daacb28c URL: http://source.winehq.org/git/wine.git/?a=commit;h=476cbd2f8ab9922459392b065… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:45 2016 +0200 dxgi/tests: Add test for IDXGISwapChain_SetFullscreenState(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 432 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 424 insertions(+), 8 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=476cbd2f8ab9922459392…

1 0

Józef Kucia : dxgi/tests: Add multi-monitor test for IDXGISwapChain_GetContainingOutput().
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 47430b92645d584f6277baab6788e99d8f131e4b URL: http://source.winehq.org/git/wine.git/?a=commit;h=47430b92645d584f6277baab6… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:46 2016 +0200 dxgi/tests: Add multi-monitor test for IDXGISwapChain_GetContainingOutput(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 163 +++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 137 insertions(+), 26 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=47430b92645d584f6277b…

1 0

Józef Kucia : dxgi/tests: Add test for default fullscreen target output.
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 709ca356cd032eec3724d9dbfb8d33ed71fa9acb URL: http://source.winehq.org/git/wine.git/?a=commit;h=709ca356cd032eec3724d9dbf… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Aug 3 09:41:47 2016 +0200 dxgi/tests: Add test for default fullscreen target output. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 124 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 123 insertions(+), 1 deletion(-) diff --git a/dlls/dxgi/tests/device.c b/dlls/dxgi/tests/device.c index 2946aa7..85e17a4 100644 --- a/dlls/dxgi/tests/device.c +++ b/dlls/dxgi/tests/device.c @@ -386,7 +386,7 @@ static void test_output(void) "Failed to list modes, hr %#x.\n", hr); if (hr == DXGI_ERROR_NOT_CURRENTLY_AVAILABLE) { - skip("GetDisplayModeList() not supported, skipping tests.\n"); + win_skip("GetDisplayModeList() not supported.\n"); IDXGIOutput_Release(output); IDXGIAdapter_Release(adapter); IDXGIDevice_Release(device); @@ -750,6 +750,7 @@ static void test_get_containing_output(void) "GetContainingOutput failed, hr %#x.\n", hr); if (hr == DXGI_ERROR_UNSUPPORTED) { + win_skip("GetContainingOutput() not supported.\n"); IDXGISwapChain_Release(swapchain); goto done; } @@ -1296,6 +1297,126 @@ done: ok(!refcount, "Factory has %u references left.\n", refcount); } +static void test_default_fullscreen_target_output(void) +{ + IDXGIOutput *output, *containing_output, *target; + DXGI_SWAP_CHAIN_DESC swapchain_desc; + DXGI_OUTPUT_DESC output_desc; + IDXGISwapChain *swapchain; + unsigned int output_idx; + IDXGIFactory *factory; + IDXGIAdapter *adapter; + IDXGIDevice *device; + ULONG refcount; + HRESULT hr; + BOOL ret; + + if (!(device = create_device())) + { + skip("Failed to create device.\n"); + return; + } + + hr = IDXGIDevice_GetAdapter(device, &adapter); + ok(SUCCEEDED(hr), "GetAdapter failed, hr %#x.\n", hr); + + hr = IDXGIAdapter_GetParent(adapter, &IID_IDXGIFactory, (void **)&factory); + ok(SUCCEEDED(hr), "GetParent failed, hr %#x.\n", hr); + + swapchain_desc.BufferDesc.Width = 100; + swapchain_desc.BufferDesc.Height = 100; + swapchain_desc.BufferDesc.RefreshRate.Numerator = 60; + swapchain_desc.BufferDesc.RefreshRate.Denominator = 60; + swapchain_desc.BufferDesc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; + swapchain_desc.BufferDesc.ScanlineOrdering = DXGI_MODE_SCANLINE_ORDER_UNSPECIFIED; + swapchain_desc.BufferDesc.Scaling = DXGI_MODE_SCALING_UNSPECIFIED; + swapchain_desc.SampleDesc.Count = 1; + swapchain_desc.SampleDesc.Quality = 0; + swapchain_desc.BufferUsage = DXGI_USAGE_RENDER_TARGET_OUTPUT; + swapchain_desc.BufferCount = 1; + swapchain_desc.OutputWindow = CreateWindowA("static", "dxgi_test", + WS_OVERLAPPEDWINDOW | WS_VISIBLE, 0, 0, 100, 100, 0, 0, 0, 0); + swapchain_desc.Windowed = TRUE; + swapchain_desc.SwapEffect = DXGI_SWAP_EFFECT_DISCARD; + swapchain_desc.Flags = 0; + + hr = IDXGIFactory_CreateSwapChain(factory, (IUnknown *)device, &swapchain_desc, &swapchain); + ok(SUCCEEDED(hr), "CreateSwapChain failed, hr %#x.\n", hr); + + output_idx = 0; + while ((hr = IDXGIAdapter_EnumOutputs(adapter, output_idx, &output)) != DXGI_ERROR_NOT_FOUND) + { + ok(SUCCEEDED(hr), "Failed to enumarate output %u, hr %#x.\n", output_idx, hr); + + hr = IDXGIOutput_GetDesc(output, &output_desc); + ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); + + /* Move the OutputWindow to the current output. */ + ret = SetWindowPos(swapchain_desc.OutputWindow, 0, + output_desc.DesktopCoordinates.left, output_desc.DesktopCoordinates.top, + 0, 0, SWP_NOSIZE | SWP_NOZORDER); + ok(ret, "SetWindowPos failed.\n"); + + hr = IDXGISwapChain_GetContainingOutput(swapchain, &containing_output); + ok(SUCCEEDED(hr) || broken(hr == DXGI_ERROR_UNSUPPORTED) /* Win 7 testbot */, + "GetContainingOutput failed, hr %#x.\n", hr); + if (hr == DXGI_ERROR_UNSUPPORTED) + { + win_skip("GetContainingOutput() not supported.\n"); + IDXGIOutput_Release(output); + goto done; + } + + hr = IDXGISwapChain_SetFullscreenState(swapchain, TRUE, NULL); + ok(SUCCEEDED(hr) || hr == DXGI_ERROR_NOT_CURRENTLY_AVAILABLE, + "SetFullscreenState failed, hr %#x.\n", hr); + if (hr == DXGI_ERROR_NOT_CURRENTLY_AVAILABLE) + { + skip("Could not change fullscreen state.\n"); + IDXGIOutput_Release(containing_output); + IDXGIOutput_Release(output); + goto done; + } + + target = NULL; + hr = IDXGISwapChain_GetFullscreenState(swapchain, NULL, &target); + ok(SUCCEEDED(hr), "GetFullscreenState failed, hr %#x.\n", hr); + ok(target != containing_output, "Got unexpected output pointers %p, %p.\n", + target, containing_output); + check_output_equal(target, containing_output); + + refcount = IDXGIOutput_Release(containing_output); + ok(!refcount, "IDXGIOutput has %u references left.\n", refcount); + + hr = IDXGISwapChain_GetContainingOutput(swapchain, &containing_output); + ok(SUCCEEDED(hr), "GetContainingOutput failed, hr %#x.\n", hr); + ok(containing_output == target, "Got unexpected containing output %p, expected %p.\n", + containing_output, target); + refcount = IDXGIOutput_Release(containing_output); + ok(refcount >= 2, "Got unexpected refcount %u.\n", refcount); + refcount = IDXGIOutput_Release(target); + ok(refcount >= 1, "Got unexpected refcount %u.\n", refcount); + + hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + + IDXGIOutput_Release(output); + ++output_idx; + } + +done: + refcount = IDXGISwapChain_Release(swapchain); + ok(!refcount, "IDXGISwapChain has %u references left.\n", refcount); + + refcount = IDXGIDevice_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + refcount = IDXGIAdapter_Release(adapter); + ok(!refcount, "Adapter has %u references left.\n", refcount); + refcount = IDXGIFactory_Release(factory); + ok(!refcount, "Factory has %u references left.\n", refcount); + DestroyWindow(swapchain_desc.OutputWindow); +} + static void test_create_factory(void) { IDXGIFactory1 *factory; @@ -2146,6 +2267,7 @@ START_TEST(device) test_create_swapchain(); test_get_containing_output(); test_set_fullscreen(); + test_default_fullscreen_target_output(); test_create_factory(); test_private_data(); test_swapchain_resize();

1 0

Jacek Caban : mshtml: Forward nsIHttpChannel:: SetReferrer to SetReferrerWithPolicy.
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: ed7dc73ca5825812542439708498b2e5addc4173 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ed7dc73ca5825812542439708… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 3 15:52:51 2016 +0200 mshtml: Forward nsIHttpChannel::SetReferrer to SetReferrerWithPolicy. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/nsio.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index cc59d0c..2d6b5d7 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -1288,12 +1288,7 @@ static nsresult NSAPI nsChannel_SetReferrer(nsIHttpChannel *iface, nsIURI *aRefe TRACE("(%p)->(%p)\n", This, aReferrer); - if(aReferrer) - nsIURI_AddRef(aReferrer); - if(This->referrer) - nsIURI_Release(This->referrer); - This->referrer = aReferrer; - return NS_OK; + return nsIHttpChannel_SetReferrerWithPolicy(&This->nsIHttpChannel_iface, aReferrer, 0); } static nsresult NSAPI nsChannel_GetReferrerPolicy(nsIHttpChannel *iface, UINT32 *aReferrerPolicy) @@ -1306,8 +1301,18 @@ static nsresult NSAPI nsChannel_GetReferrerPolicy(nsIHttpChannel *iface, UINT32 static nsresult NSAPI nsChannel_SetReferrerWithPolicy(nsIHttpChannel *iface, nsIURI *aReferrer, UINT32 aReferrerPolicy) { nsChannel *This = impl_from_nsIHttpChannel(iface); - FIXME("(%p)->(%p %x)\n", This, aReferrer, aReferrerPolicy); - return NS_ERROR_NOT_IMPLEMENTED; + + TRACE("(%p)->(%p %d)\n", This, aReferrer, aReferrerPolicy); + + if(aReferrerPolicy) + FIXME("refferer policy %d not implemented\n", aReferrerPolicy); + + if(aReferrer) + nsIURI_AddRef(aReferrer); + if(This->referrer) + nsIURI_Release(This->referrer); + This->referrer = aReferrer; + return NS_OK; } static nsresult NSAPI nsHttpChannel_GetProtocolVersion(nsIHttpChannel *iface, nsACString *aProtocolVersion)

1 0

Jacek Caban : mshtml: Don't send https referrer to non-https channel.
by Alexandre Julliard 03 Aug '16

03 Aug '16

Module: wine Branch: master Commit: 3cb45c4c8dd18fbade48b86d4f2657043b85e119 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3cb45c4c8dd18fbade48b86d4… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 3 15:53:13 2016 +0200 mshtml: Don't send https referrer to non-https channel. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/nsio.c | 35 +++++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index 2d6b5d7..cd6c21f 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -1301,17 +1301,44 @@ static nsresult NSAPI nsChannel_GetReferrerPolicy(nsIHttpChannel *iface, UINT32 static nsresult NSAPI nsChannel_SetReferrerWithPolicy(nsIHttpChannel *iface, nsIURI *aReferrer, UINT32 aReferrerPolicy) { nsChannel *This = impl_from_nsIHttpChannel(iface); + DWORD channel_scheme, referrer_scheme; + nsWineURI *referrer; + nsresult nsres; TRACE("(%p)->(%p %d)\n", This, aReferrer, aReferrerPolicy); if(aReferrerPolicy) FIXME("refferer policy %d not implemented\n", aReferrerPolicy); - if(aReferrer) - nsIURI_AddRef(aReferrer); - if(This->referrer) + if(This->referrer) { nsIURI_Release(This->referrer); - This->referrer = aReferrer; + This->referrer = NULL; + } + if(!aReferrer) + return NS_OK; + + nsres = nsIURI_QueryInterface(aReferrer, &IID_nsWineURI, (void**)&referrer); + if(NS_FAILED(nsres)) + return NS_OK; + + if(!ensure_uri(referrer)) { + nsIFileURL_Release(&referrer->nsIFileURL_iface); + return NS_ERROR_UNEXPECTED; + } + + if(!ensure_uri(This->uri) || FAILED(IUri_GetScheme(This->uri->uri, &channel_scheme))) + channel_scheme = INTERNET_SCHEME_UNKNOWN; + + if(FAILED(IUri_GetScheme(referrer->uri, &referrer_scheme))) + referrer_scheme = INTERNET_SCHEME_UNKNOWN; + + if(referrer_scheme == INTERNET_SCHEME_HTTPS && channel_scheme != INTERNET_SCHEME_HTTPS) { + TRACE("Ignoring https referrer on non-https channel\n"); + nsIFileURL_Release(&referrer->nsIFileURL_iface); + return NS_OK; + } + + This->referrer = (nsIURI*)&referrer->nsIFileURL_iface; return NS_OK; }

1 0