October 2017 - Wine-commits

Alexandre Julliard : server: Use the correct process when looking for a mapped dll.
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: c583953b95cddcb8d2712b9d2312681b9c371ab3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c583953b95cddcb8d2712b9d2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 3 11:59:20 2017 +0200 server: Use the correct process when looking for a mapped dll. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/debugger.c | 18 ++++++++++++++---- server/file.h | 4 ++-- server/mapping.c | 15 +++++---------- 3 files changed, 21 insertions(+), 16 deletions(-) diff --git a/server/debugger.c b/server/debugger.c index 37f1934..79b7e52 100644 --- a/server/debugger.c +++ b/server/debugger.c @@ -147,6 +147,7 @@ static int fill_create_process_event( struct debug_event *event, const void *arg struct process *process = thread->process; struct process_dll *exe_module = get_process_exe_module( process ); const client_ptr_t *entry = arg; + struct file *file; obj_handle_t handle; /* documented: PROCESS_VM_READ | PROCESS_VM_WRITE */ @@ -170,8 +171,12 @@ static int fill_create_process_event( struct debug_event *event, const void *arg event->data.create_process.unicode = 1; /* the doc says write access too, but this doesn't seem a good idea */ - event->data.create_process.file = open_mapping_file( debugger, exe_module->base, GENERIC_READ, - FILE_SHARE_READ | FILE_SHARE_WRITE ); + if ((file = get_mapping_file( process, exe_module->base, GENERIC_READ, + FILE_SHARE_READ | FILE_SHARE_WRITE ))) + { + event->data.create_process.file = alloc_handle( debugger, file, GENERIC_READ, 0 ); + release_object( file ); + } return 1; } @@ -191,8 +196,10 @@ static int fill_exit_process_event( struct debug_event *event, const void *arg ) static int fill_load_dll_event( struct debug_event *event, const void *arg ) { + struct process *process = event->sender->process; struct process *debugger = event->debugger->process; const struct process_dll *dll = arg; + struct file *file; event->data.load_dll.handle = 0; event->data.load_dll.base = dll->base; @@ -200,8 +207,11 @@ static int fill_load_dll_event( struct debug_event *event, const void *arg ) event->data.load_dll.dbg_size = dll->dbg_size; event->data.load_dll.name = dll->name; event->data.load_dll.unicode = 1; - event->data.load_dll.handle = open_mapping_file( debugger, dll->base, GENERIC_READ, - FILE_SHARE_READ | FILE_SHARE_WRITE ); + if ((file = get_mapping_file( process, dll->base, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE ))) + { + event->data.load_dll.handle = alloc_handle( debugger, file, GENERIC_READ, 0 ); + release_object( file ); + } return 1; } diff --git a/server/file.h b/server/file.h index 403da65..31946cc 100644 --- a/server/file.h +++ b/server/file.h @@ -149,8 +149,8 @@ extern mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner extern struct mapping *get_mapping_obj( struct process *process, obj_handle_t handle, unsigned int access ); -extern obj_handle_t open_mapping_file( struct process *process, client_ptr_t base, - unsigned int access, unsigned int sharing ); +extern struct file *get_mapping_file( struct process *process, client_ptr_t base, + unsigned int access, unsigned int sharing ); extern void free_mapped_views( struct process *process ); extern int get_page_size(void); diff --git a/server/mapping.c b/server/mapping.c index 0e4143f..096c15e 100644 --- a/server/mapping.c +++ b/server/mapping.c @@ -733,19 +733,14 @@ struct mapping *get_mapping_obj( struct process *process, obj_handle_t handle, u return (struct mapping *)get_handle_obj( process, handle, access, &mapping_ops ); } -/* open a new file handle to the file backing the mapping */ -obj_handle_t open_mapping_file( struct process *process, client_ptr_t base, - unsigned int access, unsigned int sharing ) +/* open a new file for the file descriptor backing the mapping */ +struct file *get_mapping_file( struct process *process, client_ptr_t base, + unsigned int access, unsigned int sharing ) { - obj_handle_t handle; struct memory_view *view = find_mapped_view( process, base ); - struct file *file; - if (!view || !view->fd) return 0; - if (!(file = create_file_for_fd_obj( view->fd, access, sharing ))) return 0; - handle = alloc_handle( process, file, access, 0 ); - release_object( file ); - return handle; + if (!view || !view->fd) return NULL; + return create_file_for_fd_obj( view->fd, access, sharing ); } static void mapping_dump( struct object *obj, int verbose )

1 0

Alexandre Julliard : ws2_32: Lock the user output buffer during receives.
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: dc203dd83318b0addda1e09ac596005ba00ca6ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=dc203dd83318b0addda1e09ac… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 3 13:36:40 2017 +0200 ws2_32: Lock the user output buffer during receives. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/ntdll.spec | 3 +++ dlls/ntdll/virtual.c | 33 +++++++++++++++++++++++++++++++++ dlls/ws2_32/socket.c | 4 +++- dlls/ws2_32/tests/sock.c | 5 ----- 4 files changed, 39 insertions(+), 6 deletions(-) diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index 5e27f0a..ab801ac 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -1480,6 +1480,9 @@ @ cdecl wine_server_send_fd(long) @ cdecl __wine_make_process_system() +# Virtual memory +@ cdecl __wine_locked_recvmsg(long ptr long) + # Version @ cdecl wine_get_version() NTDLL_wine_get_version @ cdecl wine_get_build_id() NTDLL_wine_get_build_id diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c index d0d25c7..7bb4eb4 100644 --- a/dlls/ntdll/virtual.c +++ b/dlls/ntdll/virtual.c @@ -32,6 +32,9 @@ #include <stdio.h> #include <string.h> #include <sys/types.h> +#ifdef HAVE_SYS_SOCKET_H +# include <sys/socket.h> +#endif #ifdef HAVE_SYS_STAT_H # include <sys/stat.h> #endif @@ -1904,6 +1907,36 @@ ssize_t virtual_locked_pread( int fd, void *addr, size_t size, off_t offset ) } +/*********************************************************************** + * __wine_locked_recvmsg + */ +ssize_t CDECL __wine_locked_recvmsg( int fd, struct msghdr *hdr, int flags ) +{ + sigset_t sigset; + size_t i; + BOOL has_write_watch = FALSE; + int err = EFAULT; + + ssize_t ret = recvmsg( fd, hdr, flags ); + if (ret != -1 || errno != EFAULT) return ret; + + server_enter_uninterrupted_section( &csVirtual, &sigset ); + for (i = 0; i < hdr->msg_iovlen; i++) + if (check_write_access( hdr->msg_iov[i].iov_base, hdr->msg_iov[i].iov_len, &has_write_watch )) + break; + if (i == hdr->msg_iovlen) + { + ret = recvmsg( fd, hdr, flags ); + err = errno; + } + if (has_write_watch) + while (i--) update_write_watches( hdr->msg_iov[i].iov_base, hdr->msg_iov[i].iov_len, 0 ); + + server_leave_uninterrupted_section( &csVirtual, &sigset ); + errno = err; + return ret; +} + /*********************************************************************** * virtual_is_valid_code_address diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 681f340..79b9333 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -241,6 +241,8 @@ static struct interface_filter generic_interface_filter = { }; #endif /* LINUX_BOUND_IF */ +extern ssize_t CDECL __wine_locked_recvmsg( int fd, struct msghdr *hdr, int flags ); + /* * The actual definition of WSASendTo, wrapped in a different function name * so that internal calls from ws2_32 itself will not trigger programs like @@ -2356,7 +2358,7 @@ static int WS2_recv( int fd, struct ws2_async *wsa, int flags ) hdr.msg_flags = 0; #endif - while ((n = recvmsg(fd, &hdr, flags)) == -1) + while ((n = __wine_locked_recvmsg( fd, &hdr, flags )) == -1) { if (errno != EINTR) return -1; diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 02f7473..91305f9 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -6962,13 +6962,10 @@ static void test_write_watch(void) send(src, "test message", sizeof("test message"), 0); ret = GetOverlappedResult( (HANDLE)dest, &ov, &bytesReturned, TRUE ); - todo_wine - { ok( ret, "GetOverlappedResult failed %u\n", GetLastError() ); ok( bytesReturned == sizeof("test message"), "wrong size %u\n", bytesReturned ); ok( !memcmp( base, "test ", 5 ), "wrong data %s\n", base ); ok( !memcmp( base + 0x4000, "message", 8 ), "wrong data %s\n", base + 0x4000 ); - } count = 64; ret = pGetWriteWatch( WRITE_WATCH_FLAG_RESET, base, size, results, &count, &pagesize ); @@ -6984,7 +6981,6 @@ static void test_write_watch(void) bufs[1].len = 0x4000; bufs[1].buf = base + 0x2000; ret = WSARecvFrom( dest, bufs, 2, NULL, &flags, &addr, &addr_len, &ov, NULL); - todo_wine ok(ret == SOCKET_ERROR && GetLastError() == ERROR_IO_PENDING, "WSARecv failed - %d error %d\n", ret, GetLastError()); @@ -6992,7 +6988,6 @@ static void test_write_watch(void) ret = pGetWriteWatch( WRITE_WATCH_FLAG_RESET, base, size, results, &count, &pagesize ); ok( !ret, "GetWriteWatch failed %u\n", GetLastError() ); ok( count == 5, "wrong count %lu\n", count ); - todo_wine ok( !base[0], "data set\n" ); send(src, "test message", sizeof("test message"), 0);

1 0

Nikolay Sivov : wbemprox/tests: Fix some leaks (Valgrind).
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: 5773203afd0636b942078fd37b94be779bb6af5d URL: http://source.winehq.org/git/wine.git/?a=commit;h=5773203afd0636b942078fd37… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Oct 2 21:35:05 2017 +0300 wbemprox/tests: Fix some leaks (Valgrind). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/tests/query.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wbemprox/tests/query.c b/dlls/wbemprox/tests/query.c index 8ff9803..083a717 100644 --- a/dlls/wbemprox/tests/query.c +++ b/dlls/wbemprox/tests/query.c @@ -1012,6 +1012,7 @@ static void test_SystemSecurity( IWbemServices *services ) win_skip( "__SystemSecurity not available\n" ); return; } + IWbemClassObject_Release( reg ); sid_size = sizeof(sid_admin_buffer); ret = CreateWellKnownSid( WinBuiltinAdministratorsSid, NULL, sid_admin, &sid_size ); @@ -1297,6 +1298,7 @@ static void test_PhysicalMemory( IWbemServices *services ) VariantClear( &val ); IWbemClassObject_Release( obj ); + IEnumWbemClassObject_Release( result ); SysFreeString( query ); SysFreeString( wql ); }

1 0

Nikolay Sivov : shell32: Improve error handling in ParseName() (Coverity).
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: 4c160b6f8cb74de09c32c9dba4f35eca6dc97131 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c160b6f8cb74de09c32c9dba… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Oct 3 11:41:10 2017 +0300 shell32: Improve error handling in ParseName() (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shelldispatch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c index 0baab6b..11890f1 100644 --- a/dlls/shell32/shelldispatch.c +++ b/dlls/shell32/shelldispatch.c @@ -1536,10 +1536,10 @@ static HRESULT WINAPI FolderImpl_ParseName(Folder3 *iface, BSTR name, FolderItem return S_FALSE; if ((hr = IShellFolder2_GetDisplayNameOf(This->folder, pidl, SHGDN_FORPARSING, &strret)) == S_OK) - StrRetToBSTR(&strret, pidl, &path); + hr = StrRetToBSTR(&strret, pidl, &path); ILFree(pidl); - if (FAILED(hr)) + if (hr != S_OK) return S_FALSE; hr = FolderItem_Constructor(This, path, item);

1 0

Nikolay Sivov : ws2_32/tests: Initialize address length argument before calling recvfrom()/WSARecvFrom( ) (Coverity).
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: 4f8c3d4750ea8f87d19adb706478b0ee3c6fbb78 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f8c3d4750ea8f87d19adb706… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Oct 3 11:56:41 2017 +0300 ws2_32/tests: Initialize address length argument before calling recvfrom()/WSARecvFrom() (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/tests/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 91305f9..137c0f6 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -6862,7 +6862,7 @@ static DWORD CALLBACK write_watch_thread( void *arg ) { struct write_watch_thread_args *args = arg; struct sockaddr addr; - int addr_len, ret; + int addr_len = sizeof(addr), ret; DWORD bytes, flags = 0; WSABUF buf[1];

1 0

Andrey Gusev : api-ms-win-appmodel-runtime-l1-1-2: Add dll.
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: d56c576bc1fe5be78e98c9972343b5093e141935 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d56c576bc1fe5be78e98c9972… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Tue Oct 3 12:01:11 2017 +0300 api-ms-win-appmodel-runtime-l1-1-2: Add dll. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 ++ configure.ac | 1 + dlls/api-ms-win-appmodel-runtime-l1-1-2/Makefile.in | 1 + .../api-ms-win-appmodel-runtime-l1-1-2.spec | 17 +++++++++++++++++ tools/make_specfiles | 1 + 5 files changed, 22 insertions(+) diff --git a/configure b/configure index cc49fa4..74fd4d4 100755 --- a/configure +++ b/configure @@ -881,6 +881,7 @@ enable_advpack enable_amstream enable_api_ms_win_appmodel_identity_l1_1_0 enable_api_ms_win_appmodel_runtime_l1_1_1 +enable_api_ms_win_appmodel_runtime_l1_1_2 enable_api_ms_win_core_apiquery_l1_1_0 enable_api_ms_win_core_appcompat_l1_1_1 enable_api_ms_win_core_appinit_l1_1_0 @@ -17953,6 +17954,7 @@ wine_fn_config_dll amstream enable_amstream clean wine_fn_config_test dlls/amstream/tests amstream_test wine_fn_config_dll api-ms-win-appmodel-identity-l1-1-0 enable_api_ms_win_appmodel_identity_l1_1_0 wine_fn_config_dll api-ms-win-appmodel-runtime-l1-1-1 enable_api_ms_win_appmodel_runtime_l1_1_1 +wine_fn_config_dll api-ms-win-appmodel-runtime-l1-1-2 enable_api_ms_win_appmodel_runtime_l1_1_2 wine_fn_config_dll api-ms-win-core-apiquery-l1-1-0 enable_api_ms_win_core_apiquery_l1_1_0 wine_fn_config_dll api-ms-win-core-appcompat-l1-1-1 enable_api_ms_win_core_appcompat_l1_1_1 wine_fn_config_dll api-ms-win-core-appinit-l1-1-0 enable_api_ms_win_core_appinit_l1_1_0 diff --git a/configure.ac b/configure.ac index b958ff3..2f6922f 100644 --- a/configure.ac +++ b/configure.ac @@ -2734,6 +2734,7 @@ WINE_CONFIG_DLL(amstream,,[clean]) WINE_CONFIG_TEST(dlls/amstream/tests) WINE_CONFIG_DLL(api-ms-win-appmodel-identity-l1-1-0) WINE_CONFIG_DLL(api-ms-win-appmodel-runtime-l1-1-1) +WINE_CONFIG_DLL(api-ms-win-appmodel-runtime-l1-1-2) WINE_CONFIG_DLL(api-ms-win-core-apiquery-l1-1-0) WINE_CONFIG_DLL(api-ms-win-core-appcompat-l1-1-1) WINE_CONFIG_DLL(api-ms-win-core-appinit-l1-1-0) diff --git a/dlls/api-ms-win-appmodel-runtime-l1-1-2/Makefile.in b/dlls/api-ms-win-appmodel-runtime-l1-1-2/Makefile.in new file mode 100644 index 0000000..ea8597e --- /dev/null +++ b/dlls/api-ms-win-appmodel-runtime-l1-1-2/Makefile.in @@ -0,0 +1 @@ +MODULE = api-ms-win-appmodel-runtime-l1-1-2.dll diff --git a/dlls/api-ms-win-appmodel-runtime-l1-1-2/api-ms-win-appmodel-runtime-l1-1-2.spec b/dlls/api-ms-win-appmodel-runtime-l1-1-2/api-ms-win-appmodel-runtime-l1-1-2.spec new file mode 100644 index 0000000..ce38d95 --- /dev/null +++ b/dlls/api-ms-win-appmodel-runtime-l1-1-2/api-ms-win-appmodel-runtime-l1-1-2.spec @@ -0,0 +1,17 @@ +@ stub AppPolicyGetClrCompat +@ stub AppPolicyGetCreateFileAccess +@ stub AppPolicyGetLifecycleManagement +@ stub AppPolicyGetMediaFoundationCodecLoading +@ stub AppPolicyGetProcessTerminationMethod +@ stub AppPolicyGetShowDeveloperDiagnostic +@ stub AppPolicyGetThreadInitializationType +@ stub AppPolicyGetWindowingModel +@ stub GetApplicationUserModelIdFromToken +@ stub GetPackageFamilyNameFromToken +@ stub GetPackageFullNameFromToken +@ stub OpenPackageInfoByFullNameForUser +@ stub VerifyApplicationUserModelId +@ stub VerifyPackageFamilyName +@ stub VerifyPackageFullName +@ stub VerifyPackageId +@ stub VerifyPackageRelativeApplicationId diff --git a/tools/make_specfiles b/tools/make_specfiles index 3d29af8..d5747c4 100755 --- a/tools/make_specfiles +++ b/tools/make_specfiles @@ -292,6 +292,7 @@ my @dll_groups = ], [ "kernelbase", + "api-ms-win-appmodel-runtime-l1-1-2", "api-ms-win-core-quirks-l1-1-0", "api-ms-win-security-grouppolicy-l1-1-0", ],

1 0

Nikolay Sivov : gdiplus/tests: Fix matrix leak (Valgrind).
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: 160f5b2387a7b1e36f254e5393770a2efd7397f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=160f5b2387a7b1e36f254e539… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Oct 2 21:06:11 2017 +0300 gdiplus/tests: Fix matrix leak (Valgrind). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/tests/matrix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/gdiplus/tests/matrix.c b/dlls/gdiplus/tests/matrix.c index 3e655ce..5ca0209 100644 --- a/dlls/gdiplus/tests/matrix.c +++ b/dlls/gdiplus/tests/matrix.c @@ -164,6 +164,7 @@ static void test_invert(void) GdipCreateMatrix2(2.0/16.0, 2.0/16.0, -5.0/16.0, 3.0/16.0, 3.0/16.0, -21.0/16.0, &inverted); GdipIsMatrixEqual(matrix, inverted, &equal); expect(TRUE, equal); + GdipDeleteMatrix(matrix); GdipCreateMatrix2(0.0006, 0, 0, 0.0006, 400, 400, &matrix); status = GdipInvertMatrix(matrix);

1 0

Hans Leidekker : webservices: Simplify get_field_size.
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: a808821d722d7f7f1a6f351e6b639c963394167b URL: http://source.winehq.org/git/wine.git/?a=commit;h=a808821d722d7f7f1a6f351e6… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Oct 3 16:14:41 2017 +0200 webservices: Simplify get_field_size. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c index d767d5c..2ed9319 100644 --- a/dlls/webservices/reader.c +++ b/dlls/webservices/reader.c @@ -7311,28 +7311,8 @@ HRESULT get_param_desc( const WS_STRUCT_DESCRIPTION *desc, USHORT index, const W static ULONG get_field_size( const WS_FIELD_DESCRIPTION *desc ) { - WS_READ_OPTION option; - ULONG size; - - switch ((option = get_field_read_option( desc->type, desc->options ))) - { - case WS_READ_REQUIRED_POINTER: - case WS_READ_OPTIONAL_POINTER: - case WS_READ_NILLABLE_POINTER: - size = sizeof(void *); - break; - - case WS_READ_REQUIRED_VALUE: - case WS_READ_NILLABLE_VALUE: - size = get_type_size( desc->type, desc->typeDescription ); - break; - - default: - WARN( "unhandled option %u\n", option ); - return 0; - } - - return size; + if (desc->options & WS_FIELD_POINTER) return sizeof(void *); + return get_type_size( desc->type, desc->typeDescription ); } static HRESULT read_param( struct reader *reader, const WS_FIELD_DESCRIPTION *desc, WS_HEAP *heap, void *ret )

1 0

Hans Leidekker : webservices: Set event handles to NULL on error.
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: de139491f60db5799e5376cae2b65d2b4bfaa163 URL: http://source.winehq.org/git/wine.git/?a=commit;h=de139491f60db5799e5376cae… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Oct 3 16:14:42 2017 +0200 webservices: Set event handles to NULL on error. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/channel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/webservices/channel.c b/dlls/webservices/channel.c index 08e0493..ef37095 100644 --- a/dlls/webservices/channel.c +++ b/dlls/webservices/channel.c @@ -166,8 +166,11 @@ static HRESULT start_queue( struct queue *queue ) error: CloseHandle( queue->wait ); + queue->wait = NULL; CloseHandle( queue->cancel ); + queue->cancel = NULL; CloseHandle( queue->ready ); + queue->ready = NULL; return hr; }

1 0

Hans Leidekker : webservices: Fix return value in read_type_text.
by Alexandre Julliard 03 Oct '17

03 Oct '17

Module: wine Branch: master Commit: 0567952c7083c4a3e4921760728d172837577bb3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0567952c7083c4a3e49217607… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Oct 3 16:14:43 2017 +0200 webservices: Fix return value in read_type_text. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c index 2ed9319..0906cba 100644 --- a/dlls/webservices/reader.c +++ b/dlls/webservices/reader.c @@ -6216,7 +6216,7 @@ static HRESULT read_type_text( struct reader *reader, const WS_FIELD_DESCRIPTION if (reader->current == reader->last) { BOOL found; - if ((hr = read_to_startelement( reader, &found )) != S_OK) return S_OK; + if ((hr = read_to_startelement( reader, &found )) != S_OK) return hr; if (!found) return WS_E_INVALID_FORMAT; } if ((hr = read_next_node( reader )) != S_OK) return hr;

1 0