December 2017 - Wine-commits

Andrey Gusev : msi/tests: Fix typos in ok() messages.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: wine Branch: master Commit: d91985b279bdf4f49319ac5bf65cbb9c4f030928 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d91985b279bdf4f49319ac5b… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Fri Dec 22 17:25:04 2017 +0200 msi/tests: Fix typos in ok() messages. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/tests/db.c | 2 +- dlls/msi/tests/record.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index 6713bc0..3cbb9b3 100644 --- a/dlls/msi/tests/db.c +++ b/dlls/msi/tests/db.c @@ -4777,7 +4777,7 @@ static void test_update(void) MsiCloseHandle(rec); r = MsiViewFetch(view, &rec); - ok(r == ERROR_NO_MORE_ITEMS, "Expectd ERROR_NO_MORE_ITEMS, got %d\n", r); + ok(r == ERROR_NO_MORE_ITEMS, "Expected ERROR_NO_MORE_ITEMS, got %d\n", r); MsiViewClose(view); MsiCloseHandle(view); diff --git a/dlls/msi/tests/record.c b/dlls/msi/tests/record.c index 5caaefc..777f1f7 100644 --- a/dlls/msi/tests/record.c +++ b/dlls/msi/tests/record.c @@ -510,7 +510,7 @@ static void test_fieldzero(void) r = MsiRecordGetStringA(rec, 0, buf, &sz); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok(!lstrcmpA(buf, ""), "Expected \"\", got \"%s\"\n", buf); - ok(sz == 0, "Expectd 0, got %d\n", sz); + ok(sz == 0, "Expected 0, got %d\n", sz); r = MsiRecordIsNull(rec, 0); ok(r == TRUE, "Expected TRUE, got %d\n", r); @@ -529,7 +529,7 @@ static void test_fieldzero(void) r = MsiRecordGetStringA(rec, 0, buf, &sz); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok(!lstrcmpA(buf, ""), "Expected \"\", got \"%s\"\n", buf); - ok(sz == 0, "Expectd 0, got %d\n", sz); + ok(sz == 0, "Expected 0, got %d\n", sz); r = MsiRecordIsNull(rec, 0); ok(r == TRUE, "Expected TRUE, got %d\n", r); @@ -548,7 +548,7 @@ static void test_fieldzero(void) r = MsiRecordGetStringA(rec, 0, buf, &sz); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok(!lstrcmpA(buf, ""), "Expected \"\", got \"%s\"\n", buf); - ok(sz == 0, "Expectd 0, got %d\n", sz); + ok(sz == 0, "Expected 0, got %d\n", sz); r = MsiRecordIsNull(rec, 0); ok(r == TRUE, "Expected TRUE, got %d\n", r); @@ -558,7 +558,7 @@ static void test_fieldzero(void) r = MsiRecordGetStringA(rec, 1, buf, &sz); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok(!lstrcmpA(buf, "bologna"), "Expected \"bologna\", got \"%s\"\n", buf); - ok(sz == 7, "Expectd 7, got %d\n", sz); + ok(sz == 7, "Expected 7, got %d\n", sz); MsiCloseHandle(rec); @@ -599,7 +599,7 @@ static void test_fieldzero(void) r = MsiRecordGetStringA(rec, 0, buf, &sz); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok(!lstrcmpA(buf, "drone"), "Expected \"drone\", got \"%s\"\n", buf); - ok(sz == 5, "Expectd 5, got %d\n", sz); + ok(sz == 5, "Expected 5, got %d\n", sz); r = MsiRecordIsNull(rec, 0); ok(r == FALSE, "Expected FALSE, got %d\n", r);

1 0

Andrey Gusev : winhttp/tests: Fix typos in ok() messages.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: wine Branch: master Commit: 72052ca6c7c442e7059123a9154a361673f0dbba URL: https://source.winehq.org/git/wine.git/?a=commit;h=72052ca6c7c442e7059123a9… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Fri Dec 22 17:25:28 2017 +0200 winhttp/tests: Fix typos in ok() messages. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winhttp/tests/notification.c | 2 +- dlls/winhttp/tests/winhttp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winhttp/tests/notification.c b/dlls/winhttp/tests/notification.c index 702c6a1..da8f8e9 100644 --- a/dlls/winhttp/tests/notification.c +++ b/dlls/winhttp/tests/notification.c @@ -944,7 +944,7 @@ static void _read_request_data(struct test_request *req, struct info *info, cons WaitForSingleObject( info->wait, INFINITE ); len = strlen(expected_data); - ok(!memcmp(buffer, expected_data, len), "unexpeceted data\n"); + ok(!memcmp(buffer, expected_data, len), "unexpected data\n"); } static void test_persistent_connection(int port) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 469b882..ec33b56 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -568,7 +568,7 @@ static void test_WinHttpAddHeaders(void) SetLastError(0xdeadbeef); ret = WinHttpAddRequestHeaders(request, test_headers[0], -1L, WINHTTP_ADDREQ_FLAG_ADD); err = GetLastError(); - ok(ret, "WinHttpAddRequestHeader failed to add new header, got %d with error %u.\n", ret, err); + ok(ret, "WinHttpAddRequestHeaders failed to add new header, got %d with error %u.\n", ret, err); ok(err == ERROR_SUCCESS || broken(err == 0xdeadbeef) /* < win7 */, "got %u\n", err); index = 0;

1 0

Zebediah Figura : regedit/tests: Skip tests if running as non-elevated admin.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: wine Branch: master Commit: 0875bf8974561712f377fcccb17bd780a1290f75 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0875bf8974561712f377fccc… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Dec 22 09:43:12 2017 -0600 regedit/tests: Skip tests if running as non-elevated admin. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/regedit/tests/regedit.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/programs/regedit/tests/regedit.c b/programs/regedit/tests/regedit.c index d558f2b..d67c57b 100644 --- a/programs/regedit/tests/regedit.c +++ b/programs/regedit/tests/regedit.c @@ -3635,6 +3635,12 @@ START_TEST(regedit) return; } + if (!run_regedit_exe("regedit.exe /s test.reg") && GetLastError() == ERROR_ELEVATION_REQUIRED) + { + win_skip("User is a non-elevated admin; skipping regedit tests.\n"); + return; + } + test_basic_import(); test_basic_import_unicode(); test_basic_import_31();

1 0

Hans Leidekker : winhttp/tests: Fix an intermittent test failure on Windows XP/Vista.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: wine Branch: master Commit: 05cf71be99bcb02a1cdaeb779a1fc4e1a349c0b9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=05cf71be99bcb02a1cdaeb77… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Dec 22 16:52:51 2017 +0100 winhttp/tests: Fix an intermittent test failure on Windows XP/Vista. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winhttp/tests/winhttp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index ec33b56..4fc9c2c 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -319,7 +319,7 @@ static void test_SendRequest (void) static CHAR post_data[] = "mode=Test"; static const char test_post[] = "mode => Test\0\n"; HINTERNET session, request, connection; - DWORD header_len, optional_len, total_len, bytes_rw, size, err; + DWORD header_len, optional_len, total_len, bytes_rw, size, err, disable; DWORD_PTR context; BOOL ret; CHAR buffer[256]; @@ -350,6 +350,12 @@ static void test_SendRequest (void) ret = WinHttpSetOption(request, WINHTTP_OPTION_CONTEXT_VALUE, &context, sizeof(context)); ok(ret, "WinHttpSetOption failed: %u\n", GetLastError()); + /* writing more data than promised by the content-length header causes an error when the connection + is resued, so disable keep-alive */ + disable = WINHTTP_DISABLE_KEEP_ALIVE; + ret = WinHttpSetOption(request, WINHTTP_OPTION_DISABLE_FEATURE, &disable, sizeof(disable)); + ok(ret, "WinHttpSetOption failed: %u\n", GetLastError()); + context++; ret = WinHttpSendRequest(request, content_type, header_len, post_data, optional_len, total_len, context); err = GetLastError();

1 0

Alexandre Julliard : Release 3.0-rc3.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: wine Branch: master Commit: c0d8de63a9628aa304dc00edbb725b5abe615b5b URL: https://source.winehq.org/git/wine.git/?a=commit;h=c0d8de63a9628aa304dc00ed… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 22 18:12:27 2017 +0100 Release 3.0-rc3. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 246 ++++++++++++++++++++++++++++++-------------------------------- VERSION | 2 +- configure | 18 ++--- 3 files changed, 130 insertions(+), 136 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=c0d8de63a9628aa304dc…

1 0

Tag wine-3.0-rc3 : Alexandre Julliard : Release 3.0-rc3
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: wine Branch: refs/tags/wine-3.0-rc3 Tag: f9aeb5322250f2912ed1ad693ca8450d18043cd9 URL: https://source.winehq.org/git/wine.git/?a=tag;h=f9aeb5322250f2912ed1ad693ca… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 22 18:12:27 2017 +0100 Release 3.0-rc3

1 0

Francois Gouget : testbot/web: Show the TestBot' s mispredictions on the Activity page.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: tools Branch: master Commit: 895029ce5088cafed5320cd5c5170b5b3897422d URL: https://source.winehq.org/git/tools.git/?a=commit;h=895029ce5088cafed5320cd… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Dec 22 01:46:09 2017 +0100 testbot/web: Show the TestBot's mispredictions on the Activity page. The TestBot prepares VMs in advance so they are ready for the next Task. Some times it mispredicts which VM will be needed next. Higlight such cases on the Activity page so they can be identified and analyzed. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Activity.pm | 10 ++++++++++ testbot/web/Activity.pl | 6 ++++-- testbot/web/WineTestBot.css | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/testbot/lib/WineTestBot/Activity.pm b/testbot/lib/WineTestBot/Activity.pm index 38cd556..31930ed 100644 --- a/testbot/lib/WineTestBot/Activity.pm +++ b/testbot/lib/WineTestBot/Activity.pm @@ -195,6 +195,16 @@ sub GetActivity($) $VMStatus->{vmstatus} = $VMStatus; weaken($VMStatus->{vmstatus}); # avoid memory cycles } + if ($LastVMStatus and $LastVMStatus->{status} ne $VMStatus->{status} and + # Ignore acts of administrator + $VMStatus->{status} !~ /^(?:maintenance|engine)$/ and + # And flag forbidden transitions + (($LastVMStatus->{status} eq "reverting" and $VMStatus->{status} ne "sleeping") or + ($LastVMStatus->{status} eq "sleeping" and $VMStatus->{status} !~ /^(?:idle|running)$/) or + ($LastVMStatus->{status} eq "idle" and $VMStatus->{status} ne "running"))) + { + $LastVMStatus->{mispredict} = 1; + } $LastStatusVMs{$VM->Name} = $StatusVMs; } } diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl index e57ab7d..a33f3ef 100644 --- a/testbot/web/Activity.pl +++ b/testbot/web/Activity.pl @@ -160,11 +160,12 @@ EOF my $VMStatus = $Group->{statusvms}->{$VM->Name}; next if ($VMStatus->{merged}); - # Add borders to separate VM hosts + # Add borders to separate VM hosts and indicate anomalies. print "<td class='Record Record-$VMStatus->{status}"; my $Host = $VM->GetHost(); print " Record-left" if ($Col > 0 and $SortedVMs[$Col-1]->GetHost() ne $Host); print " Record-right" if ($Col+1 < @SortedVMs and $SortedVMs[$Col+1]->GetHost() ne $Host); + print " Record-miss" if ($VMStatus->{mispredict}); print "'"; print " rowspan='$VMStatus->{rows}'" if ($VMStatus->{rows} > 1); print ">"; @@ -235,7 +236,8 @@ sub GenerateFooter($) print "<span class='Record-running'>running</span> a task (in which case it links to it),<br>\n"; print "<span class='Record-dirty'>dirty</span> while the server is powering off the VM after a task or while it assesses its state on startup.</p>\n"; - print "<p>If no time is indicated then the VM remained in that state for less than 2 seconds. The tasks column indicates the number of runnable / queued tasks before that scheduling round. A long horizontal bar indicates the TestBot server was restarted. </p>\n"; + print "<p>If no time is indicated then the VM remained in that state for less than 2 seconds. The tasks column indicates the number of runnable / queued tasks before that scheduling round. A long horizontal bar indicates the TestBot server was restarted.</p>\n"; + print "<p>This <span class='Record Record-idle Record-miss'>border</span> indicates that the server threw away the VM's current state without using it.</p>\n"; print "<p>The VM could also be <span class='Record-offline'>offline</span> due to a temporary issue,<br>\n"; print "or until the administrator can look at it for <span class='Record-maintenance'>maintenance</span>,<br>\n"; diff --git a/testbot/web/WineTestBot.css b/testbot/web/WineTestBot.css index f0f3c01..55de9a3 100644 --- a/testbot/web/WineTestBot.css +++ b/testbot/web/WineTestBot.css @@ -371,3 +371,4 @@ td.Record { text-align: center; } /* Special borders */ .Record.Record-left { border-left: thin solid #601919; } .Record.Record-right { border-right: thin solid #601919; } +.Record.Record-miss { border-top: thick dashed #ff6600; }

1 0

Francois Gouget : testbot/web: Tweak the label of 64 bit tests on the Activity page.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: tools Branch: master Commit: 7197fb218984a313af5ab002604f74d50c5a4f03 URL: https://source.winehq.org/git/tools.git/?a=commit;h=7197fb218984a313af5ab00… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Dec 22 09:55:28 2017 +0100 testbot/web: Tweak the label of 64 bit tests on the Activity page. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/Activity.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl index a33f3ef..64a752b 100644 --- a/testbot/web/Activity.pl +++ b/testbot/web/Activity.pl @@ -190,9 +190,11 @@ EOF { $Label .= " ". $VMStatus->{step}->FileName; if ($VMStatus->{task}->CmdLineArg =~ /^\w+$/ and - $Label =~ s/_(?:cross)?test\.exe$//) + $Label =~ s/_(?:cross)?test(64)?\.exe$//) { + my $Bitness = $1; $Label .= ":". $VMStatus->{task}->CmdLineArg; + $Label .= "/64" if ($Bitness); } } $Label = "<a href='/JobDetails.pl?Key=". $VMStatus->{job}->Id ."#k". ($VMStatus->{step}->No * 100 + $VMStatus->{task}->No) ."'>$Label</a>";

1 0

Alexandre Julliard : patches: Use https URLs everywhere.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: tools Branch: master Commit: 268dff50ca68dca10db56b7b55930f9768c7f1e5 URL: https://source.winehq.org/git/tools.git/?a=commit;h=268dff50ca68dca10db56b7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 21 17:24:55 2017 +0100 patches: Use https URLs everywhere. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- patches/update | 2 +- patches/update-regressions | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/patches/update b/patches/update index 6f930ea..963234b 100755 --- a/patches/update +++ b/patches/update @@ -124,7 +124,7 @@ print INDEX "<div id=\"logo_glass\"><a href=\"/patches/\"><img src=\"//winehq.or print INDEX "<div id=\"logo_text\"><a href=\"/patches/\"><img src=\"//winehq.org/images/winehq_logo_text.png\" alt=\"WineHQ\" title=\"WineHQ\"></a></div>\n"; print INDEX "<div id=\"tabs\"><ul>", "<li><a href=\"//www.winehq.org/\">WineHQ</a></li>", - "<li><a href=\"http://wiki.winehq.org/\">Wiki</a></li>", + "<li><a href=\"//wiki.winehq.org/\">Wiki</a></li>", "<li><a href=\"//appdb.winehq.org/\">AppDB</a></li>", "<li><a href=\"//bugs.winehq.org/\">Bugzilla</a></li>", "<li><a href=\"//forum.winehq.org/\">Forums</a></li></ul></div>\n"; diff --git a/patches/update-regressions b/patches/update-regressions index 5c8b362..f4e4e2d 100755 --- a/patches/update-regressions +++ b/patches/update-regressions @@ -44,7 +44,7 @@ sub read_bugs() { my $csv = Text::CSV::Encoded->new({ binary => 1 }); - open LIST, "-|", "wget", "-qO-", "http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bu…" or die "cannot query bug list"; + open LIST, "-|", "wget", "-qO-", "https://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&b…" or die "cannot query bug list"; <LIST>; # skip header line while (<LIST>) @@ -125,7 +125,7 @@ print OUTPUT "<div id=\"logo_glass\"><a href=\"/regressions\"><img src=\"//wineh print OUTPUT "<div id=\"logo_text\"><a href=\"/regressions\"><img src=\"//winehq.org/images/winehq_logo_text.png\" alt=\"WineHQ\" title=\"WineHQ\"></a></div>\n"; print OUTPUT "<div id=\"tabs\"><ul>", "<li><a href=\"//www.winehq.org/\">WineHQ</a></li>", - "<li><a href=\"http://wiki.winehq.org/\">Wiki</a></li>", + "<li><a href=\"//wiki.winehq.org/\">Wiki</a></li>", "<li><a href=\"//appdb.winehq.org/\">AppDB</a></li>", "<li><a href=\"//bugs.winehq.org/\">Bugzilla</a></li>", "<li><a href=\"//forum.winehq.org/\">Forums</a></li></ul></div>\n";

1 0

Alexandre Julliard : patches: Add link to commit for committed patches.
by Alexandre Julliard 22 Dec '17

22 Dec '17

Module: tools Branch: master Commit: 8db125df744d54ce1dc3abfa13724c3589ea3299 URL: https://source.winehq.org/git/tools.git/?a=commit;h=8db125df744d54ce1dc3abf… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 21 17:26:49 2017 +0100 patches: Add link to commit for committed patches. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- patches/update | 41 ++++++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/patches/update b/patches/update index 963234b..03af078 100755 --- a/patches/update +++ b/patches/update @@ -101,6 +101,18 @@ sub uniq return grep { !$seen{$_}++ } @_; } +sub read_file($) +{ + my $file = shift; + if (open FILE, "<$file") + { + chomp( my $ret = <FILE> ); + close FILE; + return $ret; + } + return undef; +} + my $js = <<END; function toggle_display(id) { @@ -171,21 +183,9 @@ foreach my $file (readdir DIR) $patch{"id"} = $file; $patch{"author"} = "Marvin (Testbot)" if $patch{"from_marvin"}; - $patch{"status"} = "nil"; - - if (open STATUS, "<$dir/$file.status") - { - my $status = <STATUS>; - chomp $status; - $patch{"status"} = $status; - close STATUS; - } - $patch{"order"} = $file; - if (open ORDER, "<$dir/$file.order") - { - $patch{"order"} = <ORDER>; - close ORDER; - } + $patch{"status"} = read_file( "$dir/$file.status" ) || "nil"; + $patch{"order"} = read_file( "$dir/$file.order" ) || $file; + $patch{"commit"} = read_file( "$dir/$file.commit" ) if $patch{status} eq "committed"; if (open REVIEW, "<:raw", "$dir/$file.review") { $_ = <REVIEW>; @@ -272,8 +272,15 @@ foreach my $file (sort { $patches{$b}->{"order"} <=> $patches{$a}->{"order"} } k next unless $patch->{"subject"} =~ /^\[.*PATCH.*\]/; } - printf INDEX "<tr class=\"%s %s\"><td class=\"id\">%s</td><td class=\"status\"><a href=\"#legend\">%s</a></td>", - $row & 1 ? "odd" : "even", $patch->{"status"}, $file, $status_descr{$patch->{"status"}} || $patch->{"status"}; + printf INDEX "<tr class=\"%s %s\"><td class=\"id\">%s</td>", $row & 1 ? "odd" : "even", $patch->{status}, $file; + if (defined($patch->{commit})) + { + printf INDEX "<td class=\"status\"><a href=\"%s\">%s</a></td>", $patch->{commit}, $status_descr{$patch->{status}}; + } + else + { + printf INDEX "<td class=\"status\"><a href=\"#legend\">%s</a></td>", $status_descr{$patch->{status}} || $patch->{status}; + } if (defined $patch->{"children"}) { printf INDEX "<td class=\"author\">%s</td>", escapeHTML($patch->{"author"});

1 0