June 2017 - Wine-commits - list.winehq.org

Vincent Povirk : gdiplus: Set flatness more appropriately in GdipDrawPath.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 6ec3cd9434488ba5bc0fd271a47b7d46827477c5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6ec3cd9434488ba5bc0fd271a… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Jun 29 13:41:05 2017 -0500 gdiplus: Set flatness more appropriately in GdipDrawPath. If the path is going to be scaled before rendering, 1.0 does not make sense as an error value. Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/graphics.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 815ffb0..a6df52c 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -3715,6 +3715,7 @@ static GpStatus SOFTWARE_GdipDrawPath(GpGraphics *graphics, GpPen *pen, GpPath * GpStatus stat; GpPath *wide_path; GpMatrix *transform=NULL; + REAL flatness=1.0; /* Check if the final pen thickness in pixels is too thin. */ if (pen->unit == UnitPixel) @@ -3756,9 +3757,24 @@ static GpStatus SOFTWARE_GdipDrawPath(GpGraphics *graphics, GpPen *pen, GpPath * stat = get_graphics_transform(graphics, CoordinateSpaceDevice, CoordinateSpaceWorld, transform); } + else + { + /* Set flatness based on the final coordinate space */ + GpMatrix t; + + stat = get_graphics_transform(graphics, CoordinateSpaceDevice, + CoordinateSpaceWorld, &t); + + if (stat != Ok) + return stat; + + flatness = 1.0/sqrt(fmax( + t.matrix[0] * t.matrix[0] + t.matrix[1] * t.matrix[1], + t.matrix[2] * t.matrix[2] + t.matrix[3] * t.matrix[3])); + } if (stat == Ok) - stat = GdipWidenPath(wide_path, pen, transform, 1.0); + stat = GdipWidenPath(wide_path, pen, transform, flatness); if (pen->unit == UnitPixel) {

1 0

Piotr Caban : gdiplus: Add GdipDrawLine test on EmfTypeEmfOnly metafile.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 33993218282290a92f51aea36299730e5ede2346 URL: http://source.winehq.org/git/wine.git/?a=commit;h=33993218282290a92f51aea36… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jun 28 20:47:21 2017 +0200 gdiplus: Add GdipDrawLine test on EmfTypeEmfOnly metafile. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/tests/metafile.c | 50 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/dlls/gdiplus/tests/metafile.c b/dlls/gdiplus/tests/metafile.c index a61206d..f73dc42 100644 --- a/dlls/gdiplus/tests/metafile.c +++ b/dlls/gdiplus/tests/metafile.c @@ -640,6 +640,26 @@ static const emfplus_record emfonly_records[] = { {0} }; +static const emfplus_record emfonly_draw_records[] = { + {0, EMR_HEADER}, + {1, EMR_SAVEDC}, + {1, EMR_SETICMMODE}, + {1, EMR_SETMITERLIMIT}, + {1, EMR_MODIFYWORLDTRANSFORM}, + {1, EMR_EXTCREATEPEN}, + {1, EMR_SELECTOBJECT}, + {1, EMR_SELECTOBJECT}, + {1, EMR_POLYLINE16}, + {1, EMR_SELECTOBJECT}, + {1, EMR_SELECTOBJECT}, + {1, EMR_MODIFYWORLDTRANSFORM}, + {1, EMR_DELETEOBJECT}, + {1, EMR_SETMITERLIMIT}, + {1, EMR_RESTOREDC}, + {0, EMR_EOF}, + {1} +}; + static void test_emfonly(void) { GpStatus stat; @@ -658,6 +678,7 @@ static void test_emfonly(void) HBRUSH hbrush, holdbrush; GpBitmap *bitmap; ARGB color; + GpPen *pen; hdc = CreateCompatibleDC(0); @@ -900,6 +921,35 @@ static void test_emfonly(void) stat = GdipDisposeImage((GpImage*)metafile); expect(Ok, stat); + + /* test drawing to metafile with gdi+ functions */ + hdc = CreateCompatibleDC(0); + + stat = GdipRecordMetafile(hdc, EmfTypeEmfOnly, &frame, MetafileFrameUnitPixel, description, &metafile); + expect(Ok, stat); + + DeleteDC(hdc); + + if (stat != Ok) + return; + + stat = GdipGetImageGraphicsContext((GpImage*)metafile, &graphics); + expect(Ok, stat); + + stat = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, &pen); + expect(Ok, stat); + stat = GdipDrawLineI(graphics, pen, 0, 0, 10, 10); + expect(Ok, stat); + GdipDeletePen(pen); + + stat = GdipDeleteGraphics(graphics); + expect(Ok, stat); + + check_metafile(metafile, emfonly_draw_records, "emfonly draw metafile", dst_points, &frame, UnitPixel); + sync_metafile(&metafile, "emfonly_draw.emf"); + + stat = GdipDisposeImage((GpImage*)metafile); + expect(Ok, stat); } static const emfplus_record fillrect_records[] = {

1 0

Piotr Caban : gdiplus: Add GdipDrawImagePointsRect test on EmfTypeEmfPlusOnly file.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 4884815505701bc84b8068e86c21dbd16ce8fe9d URL: http://source.winehq.org/git/wine.git/?a=commit;h=4884815505701bc84b8068e86… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jun 28 20:47:31 2017 +0200 gdiplus: Add GdipDrawImagePointsRect test on EmfTypeEmfPlusOnly file. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/tests/metafile.c | 68 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/dlls/gdiplus/tests/metafile.c b/dlls/gdiplus/tests/metafile.c index f73dc42..0f5be7b 100644 --- a/dlls/gdiplus/tests/metafile.c +++ b/dlls/gdiplus/tests/metafile.c @@ -2322,6 +2322,73 @@ static void test_gditransform(void) expect(Ok, stat); } +static const emfplus_record draw_image_records[] = { + {0, EMR_HEADER}, + {0, EmfPlusRecordTypeHeader}, + {1, EmfPlusRecordTypeObject}, + {1, EmfPlusRecordTypeDrawImagePoints}, + {1, EMR_SAVEDC}, + {1, EMR_SETICMMODE}, + {1, EMR_BITBLT}, + {1, EMR_RESTOREDC}, + {0, EmfPlusRecordTypeEndOfFile}, + {0, EMR_EOF}, + {0} +}; + +static void test_drawimage(void) +{ + static const WCHAR description[] = {'w','i','n','e','t','e','s','t',0}; + static const GpPointF dst_points[3] = {{10.0,10.0},{25.0,15.0},{10.0,20.0}}; + static const GpRectF frame = {0.0, 0.0, 100.0, 100.0}; + + GpMetafile *metafile; + GpGraphics *graphics; + HENHMETAFILE hemf; + GpStatus stat; + BITMAPINFO info; + BYTE buff[400]; + GpBitmap *bm; + HDC hdc; + + memset(buff, 0x80, sizeof(buff)); + hdc = CreateCompatibleDC(0); + stat = GdipRecordMetafile(hdc, EmfTypeEmfPlusOnly, &frame, MetafileFrameUnitPixel, description, &metafile); + expect(Ok, stat); + DeleteDC(hdc); + + stat = GdipGetImageGraphicsContext((GpImage*)metafile, &graphics); + expect(Ok, stat); + + memset(&info, 0, sizeof(info)); + info.bmiHeader.biSize = sizeof(BITMAPINFOHEADER); + info.bmiHeader.biWidth = 10; + info.bmiHeader.biHeight = 10; + info.bmiHeader.biPlanes = 1; + info.bmiHeader.biBitCount = 32; + info.bmiHeader.biCompression = BI_RGB; + stat = GdipCreateBitmapFromGdiDib(&info, buff, &bm); + expect(Ok, stat); + + stat = GdipDrawImagePointsRect(graphics, (GpImage*)bm, dst_points, 3, + 0.0, 0.0, 10.0, 10.0, UnitPixel, NULL, NULL, NULL); + expect(Ok, stat); + + GdipDisposeImage((GpImage*)bm); + + stat = GdipDeleteGraphics(graphics); + expect(Ok, stat); + sync_metafile(&metafile, "draw_image.emf"); + + stat = GdipGetHemfFromMetafile(metafile, &hemf); + expect(Ok, stat); + + check_emfplus(hemf, draw_image_records, "draw image"); + + stat = GdipDisposeImage((GpImage*)metafile); + expect(Ok, stat); +} + START_TEST(metafile) { struct GdiplusStartupInput gdiplusStartupInput; @@ -2359,6 +2426,7 @@ START_TEST(metafile) test_containers(); test_clipping(); test_gditransform(); + test_drawimage(); GdiplusShutdown(gdiplusToken); }

1 0

Zebediah Figura : msi: Fix a buffer overrun.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 39b841d18920ab3a31f3176ec0327f8643023343 URL: http://source.winehq.org/git/wine.git/?a=commit;h=39b841d18920ab3a31f3176ec… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 29 00:09:50 2017 -0500 msi: Fix a buffer overrun. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/package.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msi/package.c b/dlls/msi/package.c index bf6ae10..3a75a1c 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -1812,17 +1812,17 @@ INT MSI_ProcessMessage( MSIPACKAGE *package, INSTALLMESSAGE eMessageType, MSIREC { WCHAR template_s[1024]; WCHAR *template_rec, *template; - DWORD length; LoadStringW(msi_hInstance, IDS_INFO, template_s, 1024); - res = MSI_RecordGetStringW(record, 0, NULL, &length); + res = MSI_RecordGetStringW(record, 0, NULL, &len); if (res != ERROR_SUCCESS && res != ERROR_MORE_DATA) return res; len++; template_rec = msi_alloc(len * sizeof(WCHAR)); if (!template_rec) return ERROR_OUTOFMEMORY; - MSI_RecordGetStringW(record, 0, template_rec, &length); + MSI_RecordGetStringW(record, 0, template_rec, &len); + len++; template = msi_alloc((len + strlenW(template_s)) * sizeof(WCHAR)); if (!template) return ERROR_OUTOFMEMORY;

1 0

Hans Leidekker : webservices: Fix write option mapping in write_type_struct_field.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 2f2a23a9bdb51a9069693f103484b9abbb4e3e92 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2f2a23a9bdb51a9069693f103… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jun 29 09:21:59 2017 +0200 webservices: Fix write option mapping in write_type_struct_field. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/writer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/webservices/writer.c b/dlls/webservices/writer.c index 9c479b2..95ebd7c 100644 --- a/dlls/webservices/writer.c +++ b/dlls/webservices/writer.c @@ -2954,7 +2954,11 @@ static HRESULT write_type_struct_field( struct writer *writer, const WS_FIELD_DE if (field_options & WS_FIELD_POINTER) option = WS_WRITE_NILLABLE_POINTER; else option = WS_WRITE_NILLABLE_VALUE; } - else return E_INVALIDARG; + else + { + if (field_options & WS_FIELD_POINTER) option = WS_WRITE_REQUIRED_POINTER; + else option = WS_WRITE_REQUIRED_VALUE; + } } else {

1 0

Hans Leidekker : webservices: Add an index to the static dictionary.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 5c24d4497387befc3a8f08a41a33290d39926d4b URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c24d4497387befc3a8f08a41… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jun 29 09:22:00 2017 +0200 webservices: Add an index to the static dictionary. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/string.c | 34 +++++++++++++++++++++++++++++++--- dlls/webservices/webservices_private.h | 2 +- 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/dlls/webservices/string.c b/dlls/webservices/string.c index f9df48f..8fc2b6a 100644 --- a/dlls/webservices/string.c +++ b/dlls/webservices/string.c @@ -723,12 +723,40 @@ static const WS_XML_STRING dict_strings[] = #undef X }; +static const ULONG dict_sorted[] = +{ + 81, 91, 129, 314, 185, 164, 346, 66, 235, 305, 14, 6, 114, 97, 96, 94, 11, 95, 110, 451, + 443, 121, 213, 7, 71, 82, 431, 343, 74, 75, 73, 59, 447, 445, 467, 163, 472, 463, 453, 409, + 69, 286, 466, 444, 383, 67, 117, 26, 40, 345, 465, 90, 25, 77, 482, 455, 470, 344, 353, 80, + 70, 449, 299, 331, 251, 330, 5, 253, 224, 390, 120, 76, 281, 4, 276, 56, 118, 436, 72, 394, + 232, 464, 486, 456, 473, 459, 357, 393, 21, 269, 209, 54, 204, 55, 83, 35, 317, 196, 221, 321, + 433, 387, 22, 78, 288, 419, 461, 446, 457, 474, 261, 272, 424, 308, 1, 274, 322, 93, 319, 202, + 277, 416, 104, 318, 309, 165, 87, 85, 388, 389, 364, 300, 391, 52, 31, 227, 301, 167, 323, 458, + 462, 411, 194, 8, 198, 179, 256, 392, 270, 418, 303, 337, 296, 13, 283, 284, 311, 12, 9, 41, + 287, 53, 187, 18, 58, 483, 471, 468, 425, 49, 271, 295, 410, 116, 15, 379, 112, 119, 109, 42, + 17, 485, 469, 254, 50, 206, 415, 20, 228, 339, 430, 435, 320, 127, 242, 208, 86, 484, 452, 420, + 328, 210, 243, 200, 19, 170, 312, 429, 376, 275, 247, 313, 278, 279, 285, 166, 417, 460, 448, 454, + 257, 199, 267, 46, 47, 421, 171, 32, 282, 79, 57, 226, 347, 168, 450, 252, 260, 201, 310, 380, + 332, 361, 225, 414, 413, 68, 280, 438, 45, 325, 0, 128, 27, 306, 39, 60, 377, 184, 44, 294, + 351, 327, 476, 475, 266, 362, 48, 354, 355, 365, 89, 297, 324, 326, 479, 381, 84, 378, 349, 98, + 258, 259, 291, 412, 366, 348, 423, 478, 477, 169, 360, 406, 273, 229, 113, 407, 100, 88, 363, 205, + 289, 24, 255, 264, 231, 182, 183, 101, 207, 115, 263, 334, 342, 186, 43, 480, 335, 338, 203, 30, + 265, 244, 197, 23, 290, 230, 358, 408, 341, 367, 368, 245, 262, 195, 246, 374, 404, 405, 422, 268, + 375, 442, 359, 37, 33, 3, 180, 487, 62, 155, 156, 157, 111, 2, 122, 16, 38, 316, 315, 144, + 154, 481, 441, 103, 28, 382, 145, 152, 139, 141, 143, 150, 99, 102, 298, 214, 130, 63, 147, 138, + 140, 142, 428, 356, 131, 292, 434, 159, 293, 307, 158, 10, 437, 151, 352, 162, 105, 403, 395, 402, + 238, 241, 248, 153, 108, 398, 399, 373, 149, 249, 211, 148, 400, 401, 396, 132, 212, 146, 65, 123, + 397, 340, 240, 133, 440, 124, 223, 384, 385, 371, 329, 250, 236, 34, 432, 107, 386, 237, 304, 234, + 439, 333, 161, 222, 64, 239, 92, 233, 160, 134, 217, 220, 350, 136, 135, 137, 125, 426, 218, 126, + 372, 215, 216, 106, 336, 29, 219, 61, 302, 193, 369, 191, 192, 181, 370, 178, 189, 36, 188, 51, + 190, 174, 427, 176, 173, 177, 172, 175, +}; + const struct dictionary dict_builtin_static = { {{0xf93578f8,0x5852,0x4eb7,{0xa6,0xfc,0xe7,0x2b,0xb7,0x1d,0xb6,0x22}}, - (WS_XML_STRING *)dict_strings, - sizeof(dict_strings) / sizeof(dict_strings[0]), - TRUE} + (WS_XML_STRING *)dict_strings, sizeof(dict_strings)/sizeof(dict_strings[0]), TRUE}, + (ULONG *)dict_sorted }; /************************************************************************** diff --git a/dlls/webservices/webservices_private.h b/dlls/webservices/webservices_private.h index cf6e1c4..4894223 100644 --- a/dlls/webservices/webservices_private.h +++ b/dlls/webservices/webservices_private.h @@ -38,8 +38,8 @@ void free_xmlbuf( struct xmlbuf * ) DECLSPEC_HIDDEN; struct dictionary { WS_XML_DICTIONARY dict; - ULONG size; ULONG *sorted; + ULONG size; }; struct dictionary dict_builtin DECLSPEC_HIDDEN; const struct dictionary dict_builtin_static DECLSPEC_HIDDEN;

1 0

Hans Leidekker : webservices: Make sure to use the right dictionary to look up text values.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: c59dd19c4e7511a3fe57e25c4c41fe0b47c52baf URL: http://source.winehq.org/git/wine.git/?a=commit;h=c59dd19c4e7511a3fe57e25c4… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jun 29 09:22:01 2017 +0200 webservices: Make sure to use the right dictionary to look up text values. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c index 787f75b..9ecc59a 100644 --- a/dlls/webservices/reader.c +++ b/dlls/webservices/reader.c @@ -1314,11 +1314,20 @@ static HRESULT read_encode_base64( struct reader *reader, ULONG len, unsigned ch return S_OK; } +static HRESULT lookup_string( struct reader *reader, ULONG id, const WS_XML_STRING **ret ) +{ + const WS_XML_DICTIONARY *dict = (id & 1) ? reader->dict : reader->dict_static; + if (!dict || (id >>= 1) >= dict->stringCount) return WS_E_INVALID_FORMAT; + *ret = &dict->strings[id]; + return S_OK; +} + static HRESULT read_attribute_value_bin( struct reader *reader, WS_XML_ATTRIBUTE *attr ) { static const unsigned char zero[] = {'0'}, one[] = {'1'}; static const unsigned char false[] = {'f','a','l','s','e'}, true[] = {'t','r','u','e'}; WS_XML_UTF8_TEXT *utf8 = NULL; + const WS_XML_STRING *str; unsigned char type, buf[46]; BOOL val_bool; INT8 val_int8; @@ -1444,9 +1453,8 @@ static HRESULT read_attribute_value_bin( struct reader *reader, WS_XML_ATTRIBUTE case RECORD_DICTIONARY_TEXT: if ((hr = read_int31( reader, &id )) != S_OK) return hr; - if (!reader->dict || (id >>= 1) >= reader->dict->stringCount) return WS_E_INVALID_FORMAT; - if (!(utf8 = alloc_utf8_text( reader->dict->strings[id].bytes, reader->dict->strings[id].length ))) - return E_OUTOFMEMORY; + if ((hr = lookup_string( reader, id, &str )) != S_OK) return hr; + if (!(utf8 = alloc_utf8_text( str->bytes, str->length ))) return E_OUTOFMEMORY; break; case RECORD_UNIQUEID_TEXT: @@ -1973,6 +1981,7 @@ static HRESULT read_text_bin( struct reader *reader ) unsigned char type, buf[46]; struct node *node = NULL, *parent; WS_XML_UTF8_TEXT *utf8; + const WS_XML_STRING *str; BOOL val_bool; INT8 val_int8; INT16 val_int16; @@ -2115,9 +2124,8 @@ static HRESULT read_text_bin( struct reader *reader ) case RECORD_DICTIONARY_TEXT: case RECORD_DICTIONARY_TEXT_WITH_ENDELEMENT: if ((hr = read_int31( reader, &id )) != S_OK) return hr; - if (!reader->dict || (id >>= 1) >= reader->dict->stringCount) return WS_E_INVALID_FORMAT; - if (!(node = alloc_text_node( reader->dict->strings[id].bytes, reader->dict->strings[id].length, NULL ))) - return E_OUTOFMEMORY; + if ((hr = lookup_string( reader, id, &str )) != S_OK) return hr; + if (!(node = alloc_text_node( str->bytes, str->length, NULL ))) return E_OUTOFMEMORY; break; case RECORD_UNIQUEID_TEXT:

1 0

Hans Leidekker : webservices: Fix reading byte records with 2 and 4 byte length.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 119afbd1510467b43ff5b0d9fe0f05cf5e3d8698 URL: http://source.winehq.org/git/wine.git/?a=commit;h=119afbd1510467b43ff5b0d9f… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jun 29 09:22:02 2017 +0200 webservices: Fix reading byte records with 2 and 4 byte length. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c index 9ecc59a..af1aa3f 100644 --- a/dlls/webservices/reader.c +++ b/dlls/webservices/reader.c @@ -1427,7 +1427,7 @@ static HRESULT read_attribute_value_bin( struct reader *reader, WS_XML_ATTRIBUTE break; case RECORD_BYTES16_TEXT: - if ((hr = read_byte( reader, (unsigned char *)&val_uint16 )) != S_OK) return hr; + if ((hr = read_bytes( reader, (unsigned char *)&val_uint16, sizeof(val_uint16) )) != S_OK) return hr; if (!(utf8 = alloc_utf8_text( NULL, ((4 * val_uint16 / 3) + 3) & ~3 ))) return E_OUTOFMEMORY; if ((hr = read_encode_base64( reader, val_uint16, utf8->value.bytes, &utf8->value.length )) != S_OK) { @@ -1437,7 +1437,7 @@ static HRESULT read_attribute_value_bin( struct reader *reader, WS_XML_ATTRIBUTE break; case RECORD_BYTES32_TEXT: - if ((hr = read_byte( reader, (unsigned char *)&val_int32 )) != S_OK) return hr; + if ((hr = read_bytes( reader, (unsigned char *)&val_int32, sizeof(val_int32) )) != S_OK) return hr; if (val_int32 < 0) return WS_E_INVALID_FORMAT; if (!(utf8 = alloc_utf8_text( NULL, ((4 * val_int32 / 3) + 3) & ~3 ))) return E_OUTOFMEMORY; if ((hr = read_encode_base64( reader, val_int32, utf8->value.bytes, &utf8->value.length )) != S_OK) @@ -2095,7 +2095,7 @@ static HRESULT read_text_bin( struct reader *reader ) case RECORD_BYTES16_TEXT: case RECORD_BYTES16_TEXT_WITH_ENDELEMENT: - if ((hr = read_byte( reader, (unsigned char *)&val_uint16 )) != S_OK) return hr; + if ((hr = read_bytes( reader, (unsigned char *)&val_uint16, sizeof(val_uint16) )) != S_OK) return hr; if (!(node = alloc_text_node( NULL, ((4 * val_uint16 / 3) + 3) & ~3, &utf8 ))) return E_OUTOFMEMORY; if ((hr = read_encode_base64( reader, val_uint16, utf8->value.bytes, &utf8->value.length )) != S_OK) { @@ -2106,7 +2106,7 @@ static HRESULT read_text_bin( struct reader *reader ) case RECORD_BYTES32_TEXT: case RECORD_BYTES32_TEXT_WITH_ENDELEMENT: - if ((hr = read_byte( reader, (unsigned char *)&val_int32 )) != S_OK) return hr; + if ((hr = read_bytes( reader, (unsigned char *)&val_int32, sizeof(val_int32) )) != S_OK) return hr; if (val_int32 < 0) return WS_E_INVALID_FORMAT; if (!(node = alloc_text_node( NULL, ((4 * val_int32 / 3) + 3) & ~3, &utf8 ))) return E_OUTOFMEMORY; if ((hr = read_encode_base64( reader, val_int32, utf8->value.bytes, &utf8->value.length )) != S_OK)

1 0

Hans Leidekker : webservices/tests: Add more dictionary tests.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: 5a0b3ff301af0417f5c49310a90d5acdb089d4d4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5a0b3ff301af0417f5c49310a… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jun 29 09:22:03 2017 +0200 webservices/tests: Add more dictionary tests. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/tests/writer.c | 57 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/dlls/webservices/tests/writer.c b/dlls/webservices/tests/writer.c index cf8ab61..0a8d753 100644 --- a/dlls/webservices/tests/writer.c +++ b/dlls/webservices/tests/writer.c @@ -3666,6 +3666,11 @@ static HRESULT CALLBACK dict_cb( void *state, const WS_XML_STRING *str, BOOL *fo *found = TRUE; break; + case 'z': + *id = 3; + *found = TRUE; + break; + case 'v': *found = FALSE; return WS_E_OTHER; @@ -3693,6 +3698,12 @@ static void test_dictionary(void) {0x40,0x01,0x75,0x0a,0x05,0x01}; static const char res7[] = {0x40,0x01,0x76,0x0a,0x05,0x01}; + static const char res8[] = + {0x42,0x03,0x0a,0x05,0x01}; + static const char res9[] = + {0x42,0x07,0x0a,0x05,0x01}; + static const char res10[] = + {0x42,0xd6,0x03,0x0a,0x05,0x01}; static const char res100[] = {0x42,0x06,0x06,0x06,0x98,0x00,0x01}; static const char res101[] = @@ -3703,7 +3714,7 @@ static void test_dictionary(void) WS_XML_WRITER_BUFFER_OUTPUT buf = {{WS_XML_WRITER_OUTPUT_TYPE_BUFFER}}; WS_XML_STRING prefix, localname, ns, strings[6]; const WS_XML_STRING *prefix_ptr, *localname_ptr, *ns_ptr; - WS_XML_DICTIONARY dict; + WS_XML_DICTIONARY dict, *dict_builtin; WS_XML_WRITER *writer; HRESULT hr; ULONG i, call_count; @@ -3851,6 +3862,50 @@ static void test_dictionary(void) ok( call_count == 2, "got %u\n", call_count ); check_output_bin( writer, res7, sizeof(res7), __LINE__ ); + /* dictionary and callback */ + hr = WsGetDictionary( WS_ENCODING_XML_BINARY_1, &dict_builtin, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + bin.staticDictionary = dict_builtin; + + /* string in dictionary, no string dictionary set */ + hr = WsSetOutput( writer, &bin.encoding, &buf.output, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + init_xmlstring( "t", &localname ); + init_xmlstring( "ns", &ns ); + call_count = 0; + hr = WsWriteStartElement( writer, NULL, &localname, &ns, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + hr = WsWriteEndElement( writer, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( call_count == 2, "got %u\n", call_count ); + check_output_bin( writer, res8, sizeof(res8), __LINE__ ); + + /* string not in dictionary, no string dictionary set */ + hr = WsSetOutput( writer, &bin.encoding, &buf.output, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + init_xmlstring( "z", &localname ); + init_xmlstring( "ns", &ns ); + call_count = 0; + hr = WsWriteStartElement( writer, NULL, &localname, &ns, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + hr = WsWriteEndElement( writer, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( call_count == 2, "got %u\n", call_count ); + check_output_bin( writer, res9, sizeof(res9), __LINE__ ); + + /* string in dictionary, string dictionary set */ + hr = WsSetOutput( writer, &bin.encoding, &buf.output, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + init_xmlstring_dict( dict_builtin, 235, &localname ); + init_xmlstring( "ns", &ns ); + call_count = 0; + hr = WsWriteStartElement( writer, NULL, &localname, &ns, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + hr = WsWriteEndElement( writer, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( call_count == 1, "got %u\n", call_count ); + check_output_bin( writer, res10, sizeof(res10), __LINE__ ); + WsFreeWriter( writer ); }

1 0

Hans Leidekker : webservices: Fix the empty text case for a couple of data types.
by Alexandre Julliard 29 Jun '17

29 Jun '17

Module: wine Branch: master Commit: d29c0e2bdffb704cf6c8339b8ddcca6c7e21ad5f URL: http://source.winehq.org/git/wine.git/?a=commit;h=d29c0e2bdffb704cf6c8339b8… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jun 29 09:22:04 2017 +0200 webservices: Fix the empty text case for a couple of data types. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 130 ++++++++--------- dlls/webservices/tests/reader.c | 307 ++++++++++++++++++++++++++++++++++------ 2 files changed, 330 insertions(+), 107 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d29c0e2bdffb704cf6c83…

1 0