September 2017 - Wine-commits

Alistair Leslie-Hughes : mfplat: Implement MFCreateEventQueue.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 19d57982ecb4520453a1b77ace386c625312e265 URL: http://source.winehq.org/git/wine.git/?a=commit;h=19d57982ecb4520453a1b77ac… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Sep 8 11:00:20 2017 +0000 mfplat: Implement MFCreateEventQueue. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 153 +++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 149 insertions(+), 4 deletions(-) diff --git a/dlls/mfplat/main.c b/dlls/mfplat/main.c index 4745094..7c5be65 100644 --- a/dlls/mfplat/main.c +++ b/dlls/mfplat/main.c @@ -1514,17 +1514,162 @@ HRESULT WINAPI MFCreateMediaType(IMFMediaType **type) return S_OK; } +typedef struct _mfeventqueue +{ + IMFMediaEventQueue IMFMediaEventQueue_iface; + LONG ref; +} mfeventqueue; + +static inline mfeventqueue *impl_from_IMFMediaEventQueue(IMFMediaEventQueue *iface) +{ + return CONTAINING_RECORD(iface, mfeventqueue, IMFMediaEventQueue_iface); +} + +static HRESULT WINAPI mfeventqueue_QueryInterface(IMFMediaEventQueue *iface, REFIID riid, void **out) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), out); + + if(IsEqualGUID(riid, &IID_IUnknown) || + IsEqualGUID(riid, &IID_IMFMediaEventQueue)) + { + *out = &This->IMFMediaEventQueue_iface; + } + else + { + FIXME("(%s, %p)\n", debugstr_guid(riid), out); + *out = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*out); + return S_OK; +} + +static ULONG WINAPI mfeventqueue_AddRef(IMFMediaEventQueue *iface) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%u\n", This, ref); + + return ref; +} + +static ULONG WINAPI mfeventqueue_Release(IMFMediaEventQueue *iface) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) ref=%u\n", This, ref); + + if (!ref) + { + HeapFree(GetProcessHeap(), 0, This); + } + + return ref; +} + +static HRESULT WINAPI mfeventqueue_GetEvent(IMFMediaEventQueue *iface, DWORD flags, IMFMediaEvent **event) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p, %p\n", This, event); + + return E_NOTIMPL; +} + +static HRESULT WINAPI mfeventqueue_BeginGetEvent(IMFMediaEventQueue *iface, IMFAsyncCallback *callback, IUnknown *state) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p, %p, %p\n", This, callback, state); + + return E_NOTIMPL; +} + +static HRESULT WINAPI mfeventqueue_EndGetEvent(IMFMediaEventQueue *iface, IMFAsyncResult *result, IMFMediaEvent **event) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p, %p, %p\n", This, result, event); + + return E_NOTIMPL; +} + +static HRESULT WINAPI mfeventqueue_QueueEvent(IMFMediaEventQueue *iface, IMFMediaEvent *event) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p, %p\n", This, event); + + return E_NOTIMPL; +} + +static HRESULT WINAPI mfeventqueue_QueueEventParamVar(IMFMediaEventQueue *iface, MediaEventType met, + REFGUID type, HRESULT status, const PROPVARIANT *value) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p, %d, %s, 0x%08x, %p\n", This, met, debugstr_guid(type), status, value); + + return E_NOTIMPL; +} + +static HRESULT WINAPI mfeventqueue_QueueEventParamUnk(IMFMediaEventQueue *iface, MediaEventType met, REFGUID type, + HRESULT status, IUnknown *unk) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p, %d, %s, 0x%08x, %p\n", This, met, debugstr_guid(type), status, unk); + + return E_NOTIMPL; +} + +static HRESULT WINAPI mfeventqueue_Shutdown(IMFMediaEventQueue *iface) +{ + mfeventqueue *This = impl_from_IMFMediaEventQueue(iface); + + FIXME("%p\n", This); + + return E_NOTIMPL; +} + +static const IMFMediaEventQueueVtbl mfeventqueue_vtbl = +{ + mfeventqueue_QueryInterface, + mfeventqueue_AddRef, + mfeventqueue_Release, + mfeventqueue_GetEvent, + mfeventqueue_BeginGetEvent, + mfeventqueue_EndGetEvent, + mfeventqueue_QueueEvent, + mfeventqueue_QueueEventParamVar, + mfeventqueue_QueueEventParamUnk, + mfeventqueue_Shutdown +}; + /*********************************************************************** * MFCreateEventQueue (mfplat.@) */ HRESULT WINAPI MFCreateEventQueue(IMFMediaEventQueue **queue) { - FIXME("%p\n", queue); + mfeventqueue *object; - if(queue) - *queue = NULL; + TRACE("%p\n", queue); - return E_FAIL; + object = HeapAlloc( GetProcessHeap(), 0, sizeof(*object) ); + if(!object) + return E_OUTOFMEMORY; + + object->ref = 1; + object->IMFMediaEventQueue_iface.lpVtbl = &mfeventqueue_vtbl; + + *queue = &object->IMFMediaEventQueue_iface; + + return S_OK; } typedef struct _mfdescriptor

1 0

Alexandre Julliard : kernel32/tests: Retrieve the page size only once.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 9b85cebf051762e25089c2ebf4cb0d889c4b1dfb URL: http://source.winehq.org/git/wine.git/?a=commit;h=9b85cebf051762e25089c2ebf… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 11 11:18:48 2017 +0200 kernel32/tests: Retrieve the page size only once. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/virtual.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c index 9b99464..4d9335e 100644 --- a/dlls/kernel32/tests/virtual.c +++ b/dlls/kernel32/tests/virtual.c @@ -36,6 +36,7 @@ #define MAPPING_SIZE 0x100000 static HINSTANCE hkernel32, hntdll; +static SYSTEM_INFO si; static LPVOID (WINAPI *pVirtualAllocEx)(HANDLE, LPVOID, SIZE_T, DWORD, DWORD); static BOOL (WINAPI *pVirtualFreeEx)(HANDLE, LPVOID, SIZE_T, DWORD); static UINT (WINAPI *pGetWriteWatch)(DWORD,LPVOID,SIZE_T,LPVOID*,ULONG_PTR*,ULONG*); @@ -3184,14 +3185,10 @@ static void test_VirtualProtect(void) char *base, *ptr; DWORD ret, old_prot, rw_prot, exec_prot, i, j; MEMORY_BASIC_INFORMATION info; - SYSTEM_INFO si; void *addr; SIZE_T size; NTSTATUS status; - GetSystemInfo(&si); - trace("system page size %#x\n", si.dwPageSize); - SetLastError(0xdeadbeef); base = VirtualAlloc(0, si.dwPageSize, MEM_RESERVE | MEM_COMMIT, PAGE_NOACCESS); ok(base != NULL, "VirtualAlloc failed %d\n", GetLastError()); @@ -3381,10 +3378,6 @@ static void test_VirtualAlloc_protection(void) char *base, *ptr; DWORD ret, i; MEMORY_BASIC_INFORMATION info; - SYSTEM_INFO si; - - GetSystemInfo(&si); - trace("system page size %#x\n", si.dwPageSize); for (i = 0; i < sizeof(td)/sizeof(td[0]); i++) { @@ -3475,15 +3468,11 @@ static void test_CreateFileMapping_protection(void) char *base, *ptr; DWORD ret, i, alloc_prot, prot, old_prot; MEMORY_BASIC_INFORMATION info; - SYSTEM_INFO si; char temp_path[MAX_PATH]; char file_name[MAX_PATH]; HANDLE hfile, hmap; BOOL page_exec_supported = TRUE; - GetSystemInfo(&si); - trace("system page size %#x\n", si.dwPageSize); - GetTempPathA(MAX_PATH, temp_path); GetTempFileNameA(temp_path, "map", 0, file_name); @@ -3857,15 +3846,11 @@ static void test_mapping(void) }; void *base, *nt_base, *ptr; DWORD i, j, k, ret, old_prot, prev_prot; - SYSTEM_INFO si; char temp_path[MAX_PATH]; char file_name[MAX_PATH]; HANDLE hfile, hmap; MEMORY_BASIC_INFORMATION info, nt_info; - GetSystemInfo(&si); - trace("system page size %#x\n", si.dwPageSize); - GetTempPathA(MAX_PATH, temp_path); GetTempFileNameA(temp_path, "map", 0, file_name); @@ -4201,6 +4186,9 @@ START_TEST(virtual) pNtAllocateVirtualMemory = (void *)GetProcAddress( hntdll, "NtAllocateVirtualMemory" ); pNtFreeVirtualMemory = (void *)GetProcAddress( hntdll, "NtFreeVirtualMemory" ); + GetSystemInfo(&si); + trace("system page size %#x\n", si.dwPageSize); + test_shared_memory(FALSE); test_shared_memory_ro(FALSE, FILE_MAP_READ|FILE_MAP_WRITE); test_shared_memory_ro(FALSE, FILE_MAP_COPY);

1 0

Alexandre Julliard : kernel32/tests: Fix mapping protection tests to succeed on recent Windows versions.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 1caf95d1ad24ac290e2ea20643e77b4b21246ae3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1caf95d1ad24ac290e2ea2064… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 11 11:33:18 2017 +0200 kernel32/tests: Fix mapping protection tests to succeed on recent Windows versions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/virtual.c | 126 ++++++++++++++++++++---------------------- 1 file changed, 61 insertions(+), 65 deletions(-) diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c index 4d9335e..054d335 100644 --- a/dlls/kernel32/tests/virtual.c +++ b/dlls/kernel32/tests/virtual.c @@ -3674,51 +3674,35 @@ static void test_CreateFileMapping_protection(void) #define ACCESS_READ 0x01 #define ACCESS_WRITE 0x02 #define ACCESS_EXECUTE 0x04 -#define ACCESS_WRITECOPY 0x08 static DWORD page_prot_to_access(DWORD prot) { switch (prot) { + case PAGE_READONLY: + case PAGE_WRITECOPY: + return ACCESS_READ; case PAGE_READWRITE: return ACCESS_READ | ACCESS_WRITE; - case PAGE_EXECUTE: case PAGE_EXECUTE_READ: + case PAGE_EXECUTE_WRITECOPY: return ACCESS_READ | ACCESS_EXECUTE; - case PAGE_EXECUTE_READWRITE: - return ACCESS_READ | ACCESS_WRITE | ACCESS_WRITECOPY | ACCESS_EXECUTE; - - case PAGE_EXECUTE_WRITECOPY: - return ACCESS_READ | ACCESS_WRITECOPY | ACCESS_EXECUTE; - - case PAGE_READONLY: - return ACCESS_READ; - - case PAGE_WRITECOPY: - return ACCESS_READ; - + return ACCESS_READ | ACCESS_WRITE | ACCESS_EXECUTE; default: return 0; } } -static BOOL is_compatible_protection(DWORD map_prot, DWORD view_prot, DWORD prot) +static BOOL is_compatible_protection(DWORD view_prot, DWORD prot) { - DWORD map_access, view_access, prot_access; + DWORD view_access, prot_access; - map_access = page_prot_to_access(map_prot); view_access = page_prot_to_access(view_prot); prot_access = page_prot_to_access(prot); - if (view_access == prot_access) return TRUE; - if (!view_access) return FALSE; - - if ((view_access & prot_access) != prot_access) return FALSE; - if ((map_access & prot_access) == prot_access) return TRUE; - - return FALSE; + return ((view_access & prot_access) == prot_access); } static DWORD map_prot_to_access(DWORD prot) @@ -3726,10 +3710,12 @@ static DWORD map_prot_to_access(DWORD prot) switch (prot) { case PAGE_READWRITE: + return SECTION_MAP_READ | SECTION_MAP_WRITE | SECTION_MAP_EXECUTE | SECTION_QUERY; case PAGE_EXECUTE_READWRITE: return SECTION_MAP_READ | SECTION_MAP_WRITE | SECTION_MAP_EXECUTE | SECTION_MAP_EXECUTE_EXPLICIT | SECTION_QUERY; case PAGE_READONLY: case PAGE_WRITECOPY: + return SECTION_MAP_READ | SECTION_MAP_EXECUTE | SECTION_QUERY; case PAGE_EXECUTE: case PAGE_EXECUTE_READ: case PAGE_EXECUTE_WRITECOPY: @@ -3739,11 +3725,23 @@ static DWORD map_prot_to_access(DWORD prot) } } +static DWORD file_access_to_prot( DWORD access ) +{ + BOOL exec = access & FILE_MAP_EXECUTE; + access &= ~FILE_MAP_EXECUTE; + + if (access == FILE_MAP_COPY) return exec ? PAGE_EXECUTE_WRITECOPY : PAGE_WRITECOPY; + if (access & FILE_MAP_WRITE) return exec ? PAGE_EXECUTE_READWRITE : PAGE_READWRITE; + if (access & FILE_MAP_READ) return exec ? PAGE_EXECUTE_READ : PAGE_READONLY; + return PAGE_NOACCESS; +} + static BOOL is_compatible_access(DWORD map_prot, DWORD view_prot) { DWORD access = map_prot_to_access(map_prot); - if (!view_prot) view_prot = SECTION_MAP_READ; - return (view_prot & access) == view_prot; + DWORD view_access = map_prot_to_access( file_access_to_prot( view_prot )); + if (!view_access) view_access = SECTION_MAP_READ; + return (view_access & access) == view_access; } static void *map_view_of_file(HANDLE handle, DWORD access) @@ -3752,7 +3750,6 @@ static void *map_view_of_file(HANDLE handle, DWORD access) LARGE_INTEGER offset; SIZE_T count; ULONG protect; - BOOL exec; void *addr; if (!pNtMapViewOfSection) return NULL; @@ -3761,32 +3758,7 @@ static void *map_view_of_file(HANDLE handle, DWORD access) offset.u.LowPart = 0; offset.u.HighPart = 0; - exec = access & FILE_MAP_EXECUTE; - access &= ~FILE_MAP_EXECUTE; - - if (access == FILE_MAP_COPY) - { - if (exec) - protect = PAGE_EXECUTE_WRITECOPY; - else - protect = PAGE_WRITECOPY; - } - else if (access & FILE_MAP_WRITE) - { - if (exec) - protect = PAGE_EXECUTE_READWRITE; - else - protect = PAGE_READWRITE; - } - else if (access & FILE_MAP_READ) - { - if (exec) - protect = PAGE_EXECUTE_READ; - else - protect = PAGE_READONLY; - } - else protect = PAGE_NOACCESS; - + protect = file_access_to_prot( access ); addr = NULL; status = pNtMapViewOfSection(handle, GetCurrentProcess(), &addr, 0, 0, &offset, &count, 1 /* ViewShare */, 0, protect); @@ -3804,7 +3776,7 @@ static void test_mapping(void) static const DWORD page_prot[] = { PAGE_NOACCESS, PAGE_READONLY, PAGE_READWRITE, PAGE_WRITECOPY, - PAGE_EXECUTE_READ, PAGE_EXECUTE_READWRITE, PAGE_EXECUTE_WRITECOPY + PAGE_EXECUTE, PAGE_EXECUTE_READ, PAGE_EXECUTE_READWRITE, PAGE_EXECUTE_WRITECOPY }; static const struct { @@ -3882,6 +3854,13 @@ static void test_mapping(void) CloseHandle(hmap); hmap = hmap2; } + if (page_prot[i] == PAGE_EXECUTE) + { + ok(!hmap, "CreateFileMapping(PAGE_NOACCESS) should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, + "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); + continue; + } if (!hmap) { @@ -3924,8 +3903,25 @@ static void test_mapping(void) if (!is_compatible_access(page_prot[i], view[j].access)) { - ok(!base, "%d: MapViewOfFile(%04x/%04x) should fail\n", j, page_prot[i], view[j].access); - ok(GetLastError() == ERROR_ACCESS_DENIED, "wrong error %d\n", GetLastError()); + /* FILE_MAP_EXECUTE | FILE_MAP_COPY broken on XP */ + if (base != NULL && view[j].access == (FILE_MAP_EXECUTE | FILE_MAP_COPY)) + { + todo_wine + ok( broken(base != NULL), "%d: MapViewOfFile(%04x/%04x) should fail\n", + j, page_prot[i], view[j].access); + UnmapViewOfFile( base ); + } + else todo_wine_if ((page_prot[i] == PAGE_READONLY && + is_compatible_access( PAGE_EXECUTE_READ, view[j].access )) || + (page_prot[i] == PAGE_READWRITE && + is_compatible_access( PAGE_EXECUTE_READWRITE, view[j].access )) || + (page_prot[i] == PAGE_WRITECOPY && + is_compatible_access( PAGE_EXECUTE_WRITECOPY, view[j].access ))) + { + ok(!base, "%d: MapViewOfFile(%04x/%04x) should fail\n", + j, page_prot[i], view[j].access); + ok(GetLastError() == ERROR_ACCESS_DENIED, "wrong error %d\n", GetLastError()); + } continue; } @@ -3974,11 +3970,12 @@ static void test_mapping(void) SetLastError(0xdeadbeef); old_prot = 0xdeadbeef; ret = VirtualProtect(base, si.dwPageSize, page_prot[k], &old_prot); - if (is_compatible_protection(page_prot[i], view[j].prot, page_prot[k])) + if (is_compatible_protection(view[j].prot, page_prot[k])) { /* win2k and XP don't support EXEC on file mappings */ if (!ret && page_prot[k] == PAGE_EXECUTE) { + todo_wine ok(broken(!ret), "VirtualProtect doesn't support PAGE_EXECUTE\n"); continue; } @@ -3991,6 +3988,7 @@ static void test_mapping(void) /* Vista+ supports PAGE_EXECUTE_WRITECOPY, earlier versions don't */ if (!ret && page_prot[k] == PAGE_EXECUTE_WRITECOPY) { + todo_wine ok(broken(!ret), "VirtualProtect doesn't support PAGE_EXECUTE_WRITECOPY\n"); continue; } @@ -4004,17 +4002,15 @@ static void test_mapping(void) ok(ret, "VirtualProtect error %d, map %#x, view %#x, requested prot %#x\n", GetLastError(), page_prot[i], view[j].prot, page_prot[k]); ok(old_prot == prev_prot, "got %#x, expected %#x\n", old_prot, prev_prot); prev_prot = page_prot[k]; + + ret = VirtualQuery(base, &info, sizeof(info)); + ok(ret, "%d: VirtualQuery failed %d\n", j, GetLastError()); + ok(info.Protect == page_prot[k], + "VirtualProtect wrong prot, map %#x, view %#x, requested prot %#x got %#x\n", + page_prot[i], view[j].prot, page_prot[k], info.Protect ); } else { - /* NT4 doesn't fail on incompatible map and view */ - if (ret) - { - ok(broken(ret), "VirtualProtect should fail, map %#x, view %#x, requested prot %#x\n", page_prot[i], view[j].prot, page_prot[k]); - skip("Incompatible map and view are not properly handled on this platform\n"); - break; /* NT4 won't pass remaining tests */ - } - ok(!ret, "VirtualProtect should fail, map %#x, view %#x, requested prot %#x\n", page_prot[i], view[j].prot, page_prot[k]); ok(GetLastError() == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); }

1 0

Alexandre Julliard : kernel32/tests: Also run mapping tests against an anonymous mapping.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: c88a858ecae783a8efe8422aa1341e55061615b1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c88a858ecae783a8efe8422aa… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 11 11:50:11 2017 +0200 kernel32/tests: Also run mapping tests against an anonymous mapping. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/virtual.c | 92 ++++++++++++++++++++++++++++++++++--------- 1 file changed, 73 insertions(+), 19 deletions(-) diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c index 054d335..a1c67d8 100644 --- a/dlls/kernel32/tests/virtual.c +++ b/dlls/kernel32/tests/virtual.c @@ -3725,6 +3725,16 @@ static DWORD map_prot_to_access(DWORD prot) } } +static DWORD map_prot_no_write(DWORD prot) +{ + switch (prot) + { + case PAGE_READWRITE: return PAGE_WRITECOPY; + case PAGE_EXECUTE_READWRITE: return PAGE_EXECUTE_WRITECOPY; + default: return prot; + } +} + static DWORD file_access_to_prot( DWORD access ) { BOOL exec = access & FILE_MAP_EXECUTE; @@ -3771,7 +3781,7 @@ static void *map_view_of_file(HANDLE handle, DWORD access) return addr; } -static void test_mapping(void) +static void test_mapping( HANDLE hfile ) { static const DWORD page_prot[] = { @@ -3818,20 +3828,11 @@ static void test_mapping(void) }; void *base, *nt_base, *ptr; DWORD i, j, k, ret, old_prot, prev_prot; - char temp_path[MAX_PATH]; - char file_name[MAX_PATH]; - HANDLE hfile, hmap; + HANDLE hmap; MEMORY_BASIC_INFORMATION info, nt_info; + BOOL anon_mapping = (hfile == INVALID_HANDLE_VALUE); - GetTempPathA(MAX_PATH, temp_path); - GetTempFileNameA(temp_path, "map", 0, file_name); - - SetLastError(0xdeadbeef); - hfile = CreateFileA(file_name, GENERIC_READ|GENERIC_WRITE|GENERIC_EXECUTE, 0, NULL, CREATE_ALWAYS, 0, 0); - ok(hfile != INVALID_HANDLE_VALUE, "CreateFile(%s) error %d\n", file_name, GetLastError()); - SetFilePointer(hfile, si.dwPageSize, NULL, FILE_BEGIN); - SetEndOfFile(hfile); - + trace( "testing %s mapping\n", anon_mapping ? "anonymous" : "file" ); for (i = 0; i < sizeof(page_prot)/sizeof(page_prot[0]); i++) { SetLastError(0xdeadbeef); @@ -4021,10 +4022,43 @@ static void test_mapping(void) /*trace("map %#x, view %#x, requested prot %#x\n", page_prot[i], view[j].prot, page_prot[k]);*/ SetLastError(0xdeadbeef); ptr = VirtualAlloc(base, si.dwPageSize, MEM_COMMIT, page_prot[k]); - ok(!ptr, "VirtualAlloc(%02x) should fail\n", page_prot[k]); - /* FIXME: remove once Wine is fixed */ - todo_wine_if (page_prot[k] == PAGE_WRITECOPY || page_prot[k] == PAGE_EXECUTE_WRITECOPY) + if (anon_mapping) + { + if (is_compatible_protection(view[j].prot, page_prot[k])) + { + todo_wine_if (!ptr) + ok(ptr != NULL, "VirtualAlloc error %u, map %#x, view %#x, requested prot %#x\n", + GetLastError(), page_prot[i], view[j].prot, page_prot[k]); + } + else + { + /* versions <= Vista accept all protections without checking */ + todo_wine_if (ptr) + ok(!ptr || broken(ptr != NULL), + "VirtualAlloc should fail, map %#x, view %#x, requested prot %#x\n", + page_prot[i], view[j].prot, page_prot[k]); + if (!ptr) ok( GetLastError() == ERROR_INVALID_PARAMETER, + "wrong error %u\n", GetLastError()); + } + if (ptr) + { + ret = VirtualQuery(base, &info, sizeof(info)); + ok(ret, "%d: VirtualQuery failed %d\n", j, GetLastError()); + ok(info.Protect == page_prot[k] || + /* if the mapping doesn't have write access, + * broken versions silently switch to WRITECOPY */ + broken( info.Protect == map_prot_no_write(page_prot[k]) ), + "VirtualAlloc wrong prot, map %#x, view %#x, requested prot %#x got %#x\n", + page_prot[i], view[j].prot, page_prot[k], info.Protect ); + } + } + else + { + ok(!ptr, "VirtualAlloc(%02x) should fail\n", page_prot[k]); + /* FIXME: remove once Wine is fixed */ + todo_wine_if (page_prot[k] == PAGE_WRITECOPY || page_prot[k] == PAGE_EXECUTE_WRITECOPY) ok(GetLastError() == ERROR_ACCESS_DENIED, "expected ERROR_ACCESS_DENIED, got %d\n", GetLastError()); + } } UnmapViewOfFile(base); @@ -4032,9 +4066,29 @@ static void test_mapping(void) CloseHandle(hmap); } +} - CloseHandle(hfile); - DeleteFileA(file_name); +static void test_mappings(void) +{ + char temp_path[MAX_PATH]; + char file_name[MAX_PATH]; + HANDLE hfile; + + GetTempPathA(MAX_PATH, temp_path); + GetTempFileNameA(temp_path, "map", 0, file_name); + + hfile = CreateFileA(file_name, GENERIC_READ|GENERIC_WRITE|GENERIC_EXECUTE, 0, NULL, CREATE_ALWAYS, 0, 0); + ok(hfile != INVALID_HANDLE_VALUE, "CreateFile(%s) error %d\n", file_name, GetLastError()); + SetFilePointer(hfile, si.dwPageSize, NULL, FILE_BEGIN); + SetEndOfFile(hfile); + + test_mapping( hfile ); + + CloseHandle( hfile ); + DeleteFileA( file_name ); + + /* now anonymous mappings */ + test_mapping( INVALID_HANDLE_VALUE ); } static void test_shared_memory(BOOL is_child) @@ -4189,7 +4243,7 @@ START_TEST(virtual) test_shared_memory_ro(FALSE, FILE_MAP_READ|FILE_MAP_WRITE); test_shared_memory_ro(FALSE, FILE_MAP_COPY); test_shared_memory_ro(FALSE, FILE_MAP_COPY|FILE_MAP_WRITE); - test_mapping(); + test_mappings(); test_CreateFileMapping_protection(); test_VirtualAlloc_protection(); test_VirtualProtect();

1 0

Alexandre Julliard : kernel32/tests: Also run mapping tests against an executable image.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: d6b523e69f7650bac94ba825cb335945cacb7186 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6b523e69f7650bac94ba825c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 11 15:48:54 2017 +0200 kernel32/tests: Also run mapping tests against an executable image. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/virtual.c | 72 +++++++++++++++++++++++++++++-------------- 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c index a1c67d8..46b019c 100644 --- a/dlls/kernel32/tests/virtual.c +++ b/dlls/kernel32/tests/virtual.c @@ -3772,16 +3772,11 @@ static void *map_view_of_file(HANDLE handle, DWORD access) addr = NULL; status = pNtMapViewOfSection(handle, GetCurrentProcess(), &addr, 0, 0, &offset, &count, 1 /* ViewShare */, 0, protect); - if (status) - { - /* for simplicity */ - SetLastError(ERROR_ACCESS_DENIED); - addr = NULL; - } + if ((int)status < 0) addr = NULL; return addr; } -static void test_mapping( HANDLE hfile ) +static void test_mapping( HANDLE hfile, DWORD sec_flags ) { static const DWORD page_prot[] = { @@ -3827,16 +3822,16 @@ static void test_mapping( HANDLE hfile ) { FILE_MAP_EXECUTE | SECTION_MAP_EXECUTE | FILE_MAP_READ | FILE_MAP_WRITE | FILE_MAP_COPY, PAGE_EXECUTE_READWRITE } /* 0x2f */ }; void *base, *nt_base, *ptr; - DWORD i, j, k, ret, old_prot, prev_prot; + DWORD i, j, k, ret, old_prot, prev_prot, alloc_prot; HANDLE hmap; MEMORY_BASIC_INFORMATION info, nt_info; BOOL anon_mapping = (hfile == INVALID_HANDLE_VALUE); - trace( "testing %s mapping\n", anon_mapping ? "anonymous" : "file" ); + trace( "testing %s mapping flags %08x\n", anon_mapping ? "anonymous" : "file", sec_flags ); for (i = 0; i < sizeof(page_prot)/sizeof(page_prot[0]); i++) { SetLastError(0xdeadbeef); - hmap = CreateFileMappingW(hfile, NULL, page_prot[i] | SEC_COMMIT, 0, si.dwPageSize, NULL); + hmap = CreateFileMappingW(hfile, NULL, page_prot[i] | sec_flags, 0, si.dwPageSize, NULL); if (page_prot[i] == PAGE_NOACCESS) { @@ -3847,7 +3842,10 @@ static void test_mapping( HANDLE hfile ) /* A trick to create a not accessible mapping */ SetLastError(0xdeadbeef); - hmap = CreateFileMappingW(hfile, NULL, PAGE_READWRITE | SEC_COMMIT, 0, si.dwPageSize, NULL); + if (sec_flags & SEC_IMAGE) + hmap = CreateFileMappingW(hfile, NULL, PAGE_WRITECOPY | sec_flags, 0, si.dwPageSize, NULL); + else + hmap = CreateFileMappingW(hfile, NULL, PAGE_READWRITE | sec_flags, 0, si.dwPageSize, NULL); ok(hmap != 0, "CreateFileMapping(PAGE_READWRITE) error %d\n", GetLastError()); SetLastError(0xdeadbeef); ret = DuplicateHandle(GetCurrentProcess(), hmap, GetCurrentProcess(), &hmap2, 0, FALSE, 0); @@ -3867,6 +3865,10 @@ static void test_mapping( HANDLE hfile ) { trace("%d: CreateFileMapping(%04x) failed: %d\n", i, page_prot[i], GetLastError()); + if ((sec_flags & SEC_IMAGE) && + (page_prot[i] == PAGE_READWRITE || page_prot[i] == PAGE_EXECUTE_READWRITE)) + continue; /* SEC_IMAGE doesn't support write access */ + /* NT4 and win2k don't support EXEC on file mappings */ if (page_prot[i] == PAGE_EXECUTE_READ || page_prot[i] == PAGE_EXECUTE_READWRITE) { @@ -3940,15 +3942,25 @@ static void test_mapping( HANDLE hfile ) ok(ret, "%d: VirtualQuery failed %d\n", j, GetLastError()); ok(info.BaseAddress == base, "%d: (%04x) got %p, expected %p\n", j, view[j].access, info.BaseAddress, base); ok(info.RegionSize == si.dwPageSize, "%d: (%04x) got %#lx != expected %#x\n", j, view[j].access, info.RegionSize, si.dwPageSize); - ok(info.Protect == view[j].prot || - broken(view[j].prot == PAGE_EXECUTE_READ && info.Protect == PAGE_READONLY) || /* win2k */ - broken(view[j].prot == PAGE_EXECUTE_READWRITE && info.Protect == PAGE_READWRITE) || /* win2k */ - broken(view[j].prot == PAGE_EXECUTE_WRITECOPY && info.Protect == PAGE_NOACCESS), /* XP */ - "%d: (%04x) got %#x, expected %#x\n", j, view[j].access, info.Protect, view[j].prot); + if (sec_flags & SEC_IMAGE) + ok(info.Protect == PAGE_READONLY, + "%d: (%04x) got %#x, expected %#x\n", j, view[j].access, info.Protect, view[j].prot); + else + ok(info.Protect == view[j].prot || + broken(view[j].prot == PAGE_EXECUTE_READ && info.Protect == PAGE_READONLY) || /* win2k */ + broken(view[j].prot == PAGE_EXECUTE_READWRITE && info.Protect == PAGE_READWRITE) || /* win2k */ + broken(view[j].prot == PAGE_EXECUTE_WRITECOPY && info.Protect == PAGE_NOACCESS), /* XP */ + "%d: (%04x) got %#x, expected %#x\n", j, view[j].access, info.Protect, view[j].prot); ok(info.AllocationBase == base, "%d: (%04x) got %p, expected %p\n", j, view[j].access, info.AllocationBase, base); - ok(info.AllocationProtect == info.Protect, "%d: (%04x) got %#x, expected %#x\n", j, view[j].access, info.AllocationProtect, info.Protect); + if (sec_flags & SEC_IMAGE) + ok(info.AllocationProtect == PAGE_EXECUTE_WRITECOPY, "%d: (%04x) got %#x, expected %#x\n", + j, view[j].access, info.AllocationProtect, info.Protect); + else + ok(info.AllocationProtect == info.Protect, "%d: (%04x) got %#x, expected %#x\n", + j, view[j].access, info.AllocationProtect, info.Protect); ok(info.State == MEM_COMMIT, "%d: (%04x) got %#x, expected MEM_COMMIT\n", j, view[j].access, info.State); - ok(info.Type == MEM_MAPPED, "%d: (%04x) got %#x, expected MEM_MAPPED\n", j, view[j].access, info.Type); + ok(info.Type == (sec_flags & SEC_IMAGE) ? SEC_IMAGE : MEM_MAPPED, + "%d: (%04x) got %#x, expected MEM_MAPPED\n", j, view[j].access, info.Type); if (nt_base && base) { @@ -3964,14 +3976,16 @@ static void test_mapping( HANDLE hfile ) } prev_prot = info.Protect; + alloc_prot = info.AllocationProtect; for (k = 0; k < sizeof(page_prot)/sizeof(page_prot[0]); k++) { /*trace("map %#x, view %#x, requested prot %#x\n", page_prot[i], view[j].prot, page_prot[k]);*/ + DWORD actual_prot = (sec_flags & SEC_IMAGE) ? map_prot_no_write(page_prot[k]) : page_prot[k]; SetLastError(0xdeadbeef); old_prot = 0xdeadbeef; ret = VirtualProtect(base, si.dwPageSize, page_prot[k], &old_prot); - if (is_compatible_protection(view[j].prot, page_prot[k])) + if (is_compatible_protection(alloc_prot, actual_prot)) { /* win2k and XP don't support EXEC on file mappings */ if (!ret && page_prot[k] == PAGE_EXECUTE) @@ -3983,6 +3997,7 @@ static void test_mapping( HANDLE hfile ) /* NT4 and win2k don't support EXEC on file mappings */ if (!ret && (page_prot[k] == PAGE_EXECUTE_READ || page_prot[k] == PAGE_EXECUTE_READWRITE)) { + todo_wine ok(broken(!ret), "VirtualProtect doesn't support PAGE_EXECUTE\n"); continue; } @@ -4002,11 +4017,11 @@ static void test_mapping( HANDLE hfile ) ok(ret, "VirtualProtect error %d, map %#x, view %#x, requested prot %#x\n", GetLastError(), page_prot[i], view[j].prot, page_prot[k]); ok(old_prot == prev_prot, "got %#x, expected %#x\n", old_prot, prev_prot); - prev_prot = page_prot[k]; + prev_prot = actual_prot; ret = VirtualQuery(base, &info, sizeof(info)); ok(ret, "%d: VirtualQuery failed %d\n", j, GetLastError()); - ok(info.Protect == page_prot[k], + ok(info.Protect == actual_prot, "VirtualProtect wrong prot, map %#x, view %#x, requested prot %#x got %#x\n", page_prot[i], view[j].prot, page_prot[k], info.Protect ); } @@ -4082,13 +4097,24 @@ static void test_mappings(void) SetFilePointer(hfile, si.dwPageSize, NULL, FILE_BEGIN); SetEndOfFile(hfile); - test_mapping( hfile ); + test_mapping( hfile, SEC_COMMIT ); CloseHandle( hfile ); DeleteFileA( file_name ); + /* SEC_IMAGE mapping */ + GetSystemDirectoryA( file_name, MAX_PATH ); + strcat( file_name, "\\kernel32.dll" ); + + hfile = CreateFileA( file_name, GENERIC_READ|GENERIC_EXECUTE, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0 ); + ok(hfile != INVALID_HANDLE_VALUE, "CreateFile(%s) error %d\n", file_name, GetLastError()); + + test_mapping( hfile, SEC_IMAGE ); + + CloseHandle( hfile ); + /* now anonymous mappings */ - test_mapping( INVALID_HANDLE_VALUE ); + test_mapping( INVALID_HANDLE_VALUE, SEC_COMMIT ); } static void test_shared_memory(BOOL is_child)

1 0

Matteo Bruni : wined3d: Restore support for d3d9 extension formats.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 6b98d3ebf1af1f55d00b66008bd9b37de5880def URL: http://source.winehq.org/git/wine.git/?a=commit;h=6b98d3ebf1af1f55d00b66008… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Sep 8 18:44:07 2017 +0200 wined3d: Restore support for d3d9 extension formats. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/directx.c | 7 +++++++ dlls/wined3d/utils.c | 4 ++++ dlls/wined3d/wined3d_private.h | 1 + 3 files changed, 12 insertions(+) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index e30430a..0cd784c 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -5220,6 +5220,13 @@ static BOOL wined3d_check_surface_capability(const struct wined3d_format *format return TRUE; } + if ((format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_EXTENSION | WINED3DFMT_FLAG_TEXTURE)) + == (WINED3DFMT_FLAG_EXTENSION | WINED3DFMT_FLAG_TEXTURE)) + { + TRACE("[OK]\n"); + return TRUE; + } + /* Reject other formats */ TRACE("[FAILED]\n"); return FALSE; diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 1c64606..4c878b6 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -333,6 +333,10 @@ static const struct wined3d_format_base_flags format_base_flags[] = {WINED3DFMT_D32_FLOAT, WINED3DFMT_FLAG_FLOAT}, {WINED3DFMT_S8_UINT_D24_FLOAT, WINED3DFMT_FLAG_FLOAT}, {WINED3DFMT_D32_FLOAT_S8X24_UINT, WINED3DFMT_FLAG_FLOAT}, + {WINED3DFMT_INST, WINED3DFMT_FLAG_EXTENSION}, + {WINED3DFMT_NULL, WINED3DFMT_FLAG_EXTENSION}, + {WINED3DFMT_NVDB, WINED3DFMT_FLAG_EXTENSION}, + {WINED3DFMT_RESZ, WINED3DFMT_FLAG_EXTENSION}, }; struct wined3d_format_block_info diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index e12f2a6..70120e8 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -4114,6 +4114,7 @@ extern enum wined3d_format_id pixelformat_for_depth(DWORD depth) DECLSPEC_HIDDEN #define WINED3DFMT_FLAG_DEPTH 0x00000004 #define WINED3DFMT_FLAG_STENCIL 0x00000008 #define WINED3DFMT_FLAG_RENDERTARGET 0x00000010 +#define WINED3DFMT_FLAG_EXTENSION 0x00000020 #define WINED3DFMT_FLAG_FBO_ATTACHABLE 0x00000040 #define WINED3DFMT_FLAG_FBO_ATTACHABLE_SRGB 0x00000080 #define WINED3DFMT_FLAG_FLOAT 0x00000200

1 0

Matteo Bruni : wined3d: Get rid of most of the redundant query flushes.
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: cc8e87372036504f1b25036125072d1d5a84e18c URL: http://source.winehq.org/git/wine.git/?a=commit;h=cc8e87372036504f1b2503612… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Sep 8 18:44:08 2017 +0200 wined3d: Get rid of most of the redundant query flushes. This way we avoid queueing up CS packets on each wined3d_query_get_data() call, which has been seen in some degenerate cases to starve other client threads that are trying to submit actual work into the CS (sort-of a livelock). Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/cs.c | 2 ++ dlls/wined3d/query.c | 2 +- dlls/wined3d/wined3d_private.h | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/wined3d/cs.c b/dlls/wined3d/cs.c index 6ea2fd2..0ff0c61 100644 --- a/dlls/wined3d/cs.c +++ b/dlls/wined3d/cs.c @@ -877,6 +877,7 @@ void wined3d_cs_emit_flush(struct wined3d_cs *cs) op->opcode = WINED3D_CS_OP_FLUSH; cs->ops->submit(cs, WINED3D_CS_QUEUE_DEFAULT); + cs->queries_flushed = TRUE; } static void wined3d_cs_exec_set_predication(struct wined3d_cs *cs, const void *data) @@ -1863,6 +1864,7 @@ void wined3d_cs_emit_query_issue(struct wined3d_cs *cs, struct wined3d_query *qu op->flags = flags; cs->ops->submit(cs, WINED3D_CS_QUEUE_DEFAULT); + cs->queries_flushed = FALSE; } static void wined3d_cs_exec_preload_resource(struct wined3d_cs *cs, const void *data) diff --git a/dlls/wined3d/query.c b/dlls/wined3d/query.c index 88f64bd..1bdaaf0 100644 --- a/dlls/wined3d/query.c +++ b/dlls/wined3d/query.c @@ -389,7 +389,7 @@ HRESULT CDECL wined3d_query_get_data(struct wined3d_query *query, } else if (query->counter_main != query->counter_retrieved) { - if (flags & WINED3DGETDATA_FLUSH) + if (flags & WINED3DGETDATA_FLUSH && !query->device->cs->queries_flushed) wined3d_cs_emit_flush(query->device->cs); return S_FALSE; } diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 70120e8..04f2955 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -3427,6 +3427,7 @@ struct wined3d_cs size_t data_size, start, end; void *data; struct list query_poll_list; + BOOL queries_flushed; HANDLE event; BOOL waiting_for_event;

1 0

Matteo Bruni : d3d9/tests: Trace the current test in test_signed_formats() .
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 22b9403d00d2ca34eea410b95ccf013a09d91da7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=22b9403d00d2ca34eea410b95… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Sep 8 18:44:09 2017 +0200 d3d9/tests: Trace the current test in test_signed_formats(). Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d9/tests/visual.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index 822e6e4..55047d0 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -18958,8 +18958,8 @@ static void test_signed_formats(void) color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); ok(color_match(color, expected_color, 1) || broken(r200_broken), - "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", - expected_color, color, formats[i].name, x, y); + "Expected color 0x%08x, got 0x%08x, format %s, test %u, location %ux%u.\n", + expected_color, color, formats[i].name, j, x, y); } } hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); @@ -18988,8 +18988,8 @@ static void test_signed_formats(void) color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); ok(color_match(color, expected_color, formats[i].slop) || broken(color_match(color, expected_color, formats[i].slop_broken)), - "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", - expected_color, color, formats[i].name, x, y); + "Expected color 0x%08x, got 0x%08x, format %s, test %u, location %ux%u.\n", + expected_color, color, formats[i].name, j, x, y); } } hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); @@ -19037,8 +19037,8 @@ static void test_signed_formats(void) color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); ok(color_match(color, expected_color, formats[i].slop) || broken(color_match(color, expected_color, formats[i].slop_broken)), - "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", - expected_color, color, formats[i].name, x, y); + "Expected color 0x%08x, got 0x%08x, format %s, test %u, location %ux%u.\n", + expected_color, color, formats[i].name, j, x, y); } } hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL);

1 0

Matteo Bruni : d3d8/tests: Trace the current test in test_signed_formats() .
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 210ce803a0cee28098cf29adf8d83df925d7962e URL: http://source.winehq.org/git/wine.git/?a=commit;h=210ce803a0cee28098cf29adf… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Sep 8 18:44:10 2017 +0200 d3d8/tests: Trace the current test in test_signed_formats(). Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d8/tests/visual.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c index 5ff96d4..588a629 100644 --- a/dlls/d3d8/tests/visual.c +++ b/dlls/d3d8/tests/visual.c @@ -6442,8 +6442,8 @@ static void test_signed_formats(void) color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); ok(color_match(color, expected_color, 1) || broken(r200_broken), - "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", - expected_color, color, formats[i].name, x, y); + "Expected color 0x%08x, got 0x%08x, format %s, test %u, location %ux%u.\n", + expected_color, color, formats[i].name, j, x, y); } } hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); @@ -6472,8 +6472,8 @@ static void test_signed_formats(void) color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); ok(color_match(color, expected_color, formats[i].slop) || broken(color_match(color, expected_color, formats[i].slop_broken)), - "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", - expected_color, color, formats[i].name, x, y); + "Expected color 0x%08x, got 0x%08x, format %s, test %u, location %ux%u.\n", + expected_color, color, formats[i].name, j, x, y); } } hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL);

1 0

Matteo Bruni : wined3d: Copy the module handle to a local variable in wined3d_cs_run().
by Alexandre Julliard 11 Sep '17

11 Sep '17

Module: wine Branch: master Commit: 6ee7f9074619265d7e3af99ba62fd7e9104ebb96 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6ee7f9074619265d7e3af99ba… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Sep 8 18:44:11 2017 +0200 wined3d: Copy the module handle to a local variable in wined3d_cs_run(). Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/cs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/wined3d/cs.c b/dlls/wined3d/cs.c index 0ff0c61..b3b6588 100644 --- a/dlls/wined3d/cs.c +++ b/dlls/wined3d/cs.c @@ -2569,11 +2569,16 @@ static DWORD WINAPI wined3d_cs_run(void *ctx) unsigned int spin_count = 0; struct wined3d_cs *cs = ctx; enum wined3d_cs_op opcode; + HMODULE wined3d_module; unsigned int poll = 0; LONG tail; TRACE("Started.\n"); + /* Copy the module handle to a local variable to avoid racing with the + * thread freeing "cs" before the FreeLibraryAndExitThread() call. */ + wined3d_module = cs->wined3d_module; + list_init(&cs->query_poll_list); cs->thread_id = GetCurrentThreadId(); for (;;) @@ -2621,7 +2626,7 @@ static DWORD WINAPI wined3d_cs_run(void *ctx) cs->queue[WINED3D_CS_QUEUE_MAP].tail = cs->queue[WINED3D_CS_QUEUE_MAP].head; cs->queue[WINED3D_CS_QUEUE_DEFAULT].tail = cs->queue[WINED3D_CS_QUEUE_DEFAULT].head; TRACE("Stopped.\n"); - FreeLibraryAndExitThread(cs->wined3d_module, 0); + FreeLibraryAndExitThread(wined3d_module, 0); } struct wined3d_cs *wined3d_cs_create(struct wined3d_device *device)

1 0