November 2018 - Wine-commits

Michael Stefaniuc : wbemprox: Prefer the standard ARRAY_SIZE macro.
by Alexandre Julliard 16 Nov '18

16 Nov '18

Module: wine Branch: master Commit: 904820a523154e2435d16efbc923da59ece8a95e URL: https://source.winehq.org/git/wine.git/?a=commit;h=904820a523154e2435d16efb… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Thu Nov 15 20:59:48 2018 +0100 wbemprox: Prefer the standard ARRAY_SIZE macro. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/builtin.c | 68 ++++++++++++++++++++-------------------- dlls/wbemprox/class.c | 4 +-- dlls/wbemprox/qualifier.c | 4 +-- dlls/wbemprox/services.c | 4 +-- dlls/wbemprox/wbemprox_private.h | 2 -- dlls/wbemprox/wql.y | 26 +++++++-------- 6 files changed, 53 insertions(+), 55 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=904820a523154e2435d1…

1 0

Francois Gouget : testbot: Shorten the test report names.
by Alexandre Julliard 16 Nov '18

16 Nov '18

Module: tools Branch: master Commit: 0a6fa83afe698b98d5f6847030c2d9558ac618ec URL: https://source.winehq.org/git/tools.git/?a=commit;h=0a6fa83afe698b98d5f6847… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Nov 16 11:14:15 2018 +0100 testbot: Shorten the test report names. The context makes it clear enough whether the report was produced on Windows or in Wine. So use a shorter, more readable name. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/LogUtils.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index 59b2d0a..f142982 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -596,11 +596,11 @@ sub GetLogFileNames($;$) } my %_LogFileLabels = ( - "exe32.report" => "32 bit Windows report", - "exe64.report" => "64 bit Windows report", - "win32.report" => "32 bit Wine report", - "wow32.report" => "32 bit WoW Wine report", - "wow64.report" => "64 bit Wow Wine report", + "exe32.report" => "32 bit report", + "exe64.report" => "64 bit report", + "win32.report" => "32 bit report", + "wow32.report" => "32 bit WoW report", + "wow64.report" => "64 bit WoW report", "log" => "task log", "old_log" => "old logs", );

1 0

Francois Gouget : testbot: Provide a better title for Wine update tasks.
by Alexandre Julliard 16 Nov '18

16 Nov '18

Module: tools Branch: master Commit: aef6074283a828b07249abcdc213184625771853 URL: https://source.winehq.org/git/tools.git/?a=commit;h=aef6074283a828b07249abc… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Nov 16 11:14:23 2018 +0100 testbot: Provide a better title for Wine update tasks. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/StepsTasks.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/StepsTasks.pm b/testbot/lib/WineTestBot/StepsTasks.pm index cfd78e5..8128bf9 100644 --- a/testbot/lib/WineTestBot/StepsTasks.pm +++ b/testbot/lib/WineTestBot/StepsTasks.pm @@ -70,7 +70,11 @@ sub GetTitle($) my ($self) = @_; my @TitleParts; - if ($self->Type eq "build") + if ($self->Type eq "reconfig") + { + push @TitleParts, "Wine update"; + } + elsif ($self->Type eq "build") { push @TitleParts, "build"; }

1 0

Józef Kucia : vkd3d: Use at least D3D12_SMALL_RESOURCE_PLACEMENT_ALIGNMENT for textures.
by Alexandre Julliard 16 Nov '18

16 Nov '18

Module: vkd3d Branch: master Commit: a5646b3aff52b58dad7492a5d460cbed95103a48 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=a5646b3aff52b58dad7492a… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Nov 16 13:28:24 2018 +0100 vkd3d: Use at least D3D12_SMALL_RESOURCE_PLACEMENT_ALIGNMENT for textures. It's the smallest alignment for textures supported by D3D12. Vulkan implementations may return lower values. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/device.c | 3 +++ tests/d3d12.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index c854050..cf40e7a 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -2062,6 +2062,7 @@ static D3D12_RESOURCE_ALLOCATION_INFO * STDMETHODCALLTYPE d3d12_device_GetResour } else { + /* FIXME: Should we support D3D12_DEFAULT_RESOURCE_PLACEMENT_ALIGNMENT for small MSSA resources? */ if (desc->SampleDesc.Count != 1) default_alignment = D3D12_DEFAULT_MSAA_RESOURCE_PLACEMENT_ALIGNMENT; @@ -2070,6 +2071,8 @@ static D3D12_RESOURCE_ALLOCATION_INFO * STDMETHODCALLTYPE d3d12_device_GetResour WARN("Failed to get allocation info for texture.\n"); valid = false; } + + info->Alignment = max(info->Alignment, D3D12_SMALL_RESOURCE_PLACEMENT_ALIGNMENT); } if (valid && desc->Alignment % info->Alignment) diff --git a/tests/d3d12.c b/tests/d3d12.c index 7fb0b41..c827785 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -21218,6 +21218,8 @@ static void test_suballocate_small_textures(void) check_alignment(info.SizeInBytes, info.Alignment); } + ok(info.Alignment >= D3D12_SMALL_RESOURCE_PLACEMENT_ALIGNMENT, "Got alignment %"PRIu64".\n", info.Alignment); + heap_desc.SizeInBytes = ARRAY_SIZE(textures) * info.SizeInBytes; memset(&heap_desc.Properties, 0, sizeof(heap_desc.Properties)); heap_desc.Properties.Type = D3D12_HEAP_TYPE_DEFAULT;

1 0

Hans Leidekker : winhttp: Skip the hostname part when escaping an absolute URL.
by Alexandre Julliard 15 Nov '18

15 Nov '18

Module: wine Branch: master Commit: 60a8bb68ec2f31381e8741b6227d683798f3d53a URL: https://source.winehq.org/git/wine.git/?a=commit;h=60a8bb68ec2f31381e8741b6… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 15 12:38:52 2018 +0100 winhttp: Skip the hostname part when escaping an absolute URL. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winhttp/request.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index adc039d..a5be242 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -541,7 +541,7 @@ BOOL WINAPI WinHttpAddRequestHeaders( HINTERNET hrequest, LPCWSTR headers, DWORD return ret; } -static WCHAR *build_absolute_request_path( request_t *request ) +static WCHAR *build_absolute_request_path( request_t *request, const WCHAR **path ) { static const WCHAR http[] = {'h','t','t','p',0}; static const WCHAR https[] = {'h','t','t','p','s',0}; @@ -555,16 +555,17 @@ static WCHAR *build_absolute_request_path( request_t *request ) len = strlenW( scheme ) + strlenW( request->connect->hostname ) + 4; /* '://' + nul */ if (request->connect->hostport) len += 6; /* ':' between host and port, up to 5 for port */ - if (request->path) len += strlenW( request->path ); + len += strlenW( request->path ); if ((ret = heap_alloc( len * sizeof(WCHAR) ))) { len = sprintfW( ret, fmt, scheme, request->connect->hostname ); if (request->connect->hostport) { static const WCHAR port_fmt[] = {':','%','u',0}; - sprintfW( ret + len, port_fmt, request->connect->hostport ); + len += sprintfW( ret + len, port_fmt, request->connect->hostport ); } - if (request->path) strcatW( ret, request->path ); + strcpyW( ret + len, request->path ); + if (path) *path = ret + len; } return ret; @@ -578,7 +579,7 @@ static WCHAR *build_request_string( request_t *request ) unsigned int i, len; if (!strcmpiW( request->connect->hostname, request->connect->servername )) path = request->path; - else if (!(path = build_absolute_request_path( request ))) return NULL; + else if (!(path = build_absolute_request_path( request, NULL ))) return NULL; len = strlenW( request->verb ) + 1 /* ' ' */; len += strlenW( path ) + 1 /* ' ' */; @@ -2125,16 +2126,16 @@ static DWORD str_to_wire( const WCHAR *src, int src_len, char *dst, enum escape_ static char *build_wire_path( request_t *request, DWORD *ret_len ) { WCHAR *full_path; - const WCHAR *path, *query = NULL; + const WCHAR *start, *path, *query = NULL; DWORD len, len_path = 0, len_query = 0; enum escape_flags path_flags, query_flags; char *ret; - if (!strcmpiW( request->connect->hostname, request->connect->servername )) full_path = request->path; - else if (!(full_path = build_absolute_request_path( request ))) return NULL; + if (!strcmpiW( request->connect->hostname, request->connect->servername )) start = full_path = request->path; + else if (!(full_path = build_absolute_request_path( request, &start ))) return NULL; len = strlenW( full_path ); - if ((path = strchrW( full_path, '/' ))) + if ((path = strchrW( start, '/' ))) { len_path = strlenW( path ); if ((query = strchrW( path, '?' )))

1 0

Hans Leidekker : winhttp: Simplify secure_proxy_connect.
by Alexandre Julliard 15 Nov '18

15 Nov '18

Module: wine Branch: master Commit: dffb4705c59ff648cf6efb4c9c3ffe0e45da4ae2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dffb4705c59ff648cf6efb4c… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 15 12:38:53 2018 +0100 winhttp: Simplify secure_proxy_connect. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winhttp/request.c | 143 ++++++++++++++++--------------------------------- 1 file changed, 47 insertions(+), 96 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index a5be242..7f3ef4c 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -1337,122 +1337,73 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla return ret; } -static LPWSTR concatenate_string_list( LPCWSTR *list, int len ) +static WCHAR *build_proxy_connect_string( request_t *request ) { - LPCWSTR *t; - LPWSTR str; - - for( t = list; *t ; t++ ) - len += strlenW( *t ); - len++; - - str = heap_alloc( len * sizeof(WCHAR) ); - if (!str) return NULL; - *str = 0; + static const WCHAR fmtW[] = {'%','s',':','%','u',0}; + static const WCHAR connectW[] = {'C','O','N','N','E','C','T', 0}; + static const WCHAR spaceW[] = {' ',0}, crlfW[] = {'\r','\n',0}, colonW[] = {':',' ',0}; + static const WCHAR twocrlfW[] = {'\r','\n','\r','\n',0}; + WCHAR *ret, *host; + unsigned int i; + int len; - for( t = list; *t ; t++ ) - strcatW( str, *t ); + if (!(host = heap_alloc( (strlenW( request->connect->hostname ) + 7) * sizeof(WCHAR) ))) return NULL; + len = sprintfW( host, fmtW, request->connect->hostname, request->connect->hostport ); - return str; -} + len += ARRAY_SIZE(connectW); + len += ARRAY_SIZE(http1_1); -static LPWSTR build_header_request_string( request_t *request, LPCWSTR verb, - LPCWSTR path, LPCWSTR version ) -{ - static const WCHAR crlf[] = {'\r','\n',0}; - static const WCHAR space[] = { ' ',0 }; - static const WCHAR colon[] = { ':',' ',0 }; - static const WCHAR twocrlf[] = {'\r','\n','\r','\n', 0}; - LPWSTR requestString; - DWORD len, n; - LPCWSTR *req; - UINT i; - LPWSTR p; - - /* allocate space for an array of all the string pointers to be added */ - len = (request->num_headers) * 4 + 10; - req = heap_alloc( len * sizeof(LPCWSTR) ); - if (!req) return NULL; - - /* add the verb, path and HTTP version string */ - n = 0; - req[n++] = verb; - req[n++] = space; - req[n++] = path; - req[n++] = space; - req[n++] = version; - - /* Append custom request headers */ for (i = 0; i < request->num_headers; i++) { if (request->headers[i].is_request) - { - req[n++] = crlf; - req[n++] = request->headers[i].field; - req[n++] = colon; - req[n++] = request->headers[i].value; - - TRACE("Adding custom header %s (%s)\n", - debugstr_w(request->headers[i].field), - debugstr_w(request->headers[i].value)); - } + len += strlenW( request->headers[i].field ) + strlenW( request->headers[i].value ) + 4; /* '\r\n: ' */ } + len += 4; /* '\r\n\r\n' */ - if( n >= len ) - ERR("oops. buffer overrun\n"); - - req[n] = NULL; - requestString = concatenate_string_list( req, 4 ); - heap_free( req ); - if (!requestString) return NULL; + if ((ret = heap_alloc( (len + 1) * sizeof(WCHAR) ))) + { + strcpyW( ret, connectW ); + strcatW( ret, spaceW ); + strcatW( ret, host ); + strcatW( ret, spaceW ); + strcatW( ret, http1_1 ); - /* - * Set (header) termination string for request - * Make sure there are exactly two new lines at the end of the request - */ - p = &requestString[strlenW(requestString)-1]; - while ( (*p == '\n') || (*p == '\r') ) - p--; - strcpyW( p+1, twocrlf ); + for (i = 0; i < request->num_headers; i++) + { + if (request->headers[i].is_request) + { + strcatW( ret, crlfW ); + strcatW( ret, request->headers[i].field ); + strcatW( ret, colonW ); + strcatW( ret, request->headers[i].value ); + } + } + strcatW( ret, twocrlfW ); + } - return requestString; + heap_free( host ); + return ret; } static BOOL read_reply( request_t *request ); static BOOL secure_proxy_connect( request_t *request ) { - static const WCHAR verbConnect[] = {'C','O','N','N','E','C','T',0}; - static const WCHAR fmt[] = {'%','s',':','%','u',0}; - BOOL ret = FALSE; - LPWSTR path; - connect_t *connect = request->connect; - - path = heap_alloc( (strlenW( connect->hostname ) + 13) * sizeof(WCHAR) ); - if (path) - { - LPWSTR requestString; + WCHAR *str; + char *strA; + int len, bytes_sent; + BOOL ret; - sprintfW( path, fmt, connect->hostname, connect->hostport ); - requestString = build_header_request_string( request, verbConnect, - path, http1_1 ); - heap_free( path ); - if (requestString) - { - LPSTR req_ascii = strdupWA( requestString ); + if (!(str = build_proxy_connect_string( request ))) return FALSE; + strA = strdupWA( str ); + heap_free( str ); + if (!strA) return FALSE; - heap_free( requestString ); - if (req_ascii) - { - int len = strlen( req_ascii ), bytes_sent; + len = strlen( strA ); + ret = netconn_send( request->netconn, strA, len, &bytes_sent ); + heap_free( strA ); + if (ret) ret = read_reply( request ); - ret = netconn_send( request->netconn, req_ascii, len, &bytes_sent ); - heap_free( req_ascii ); - if (ret) - ret = read_reply( request ); - } - } - } return ret; }

1 0

Alexander Morozov : crypt32: Use correct private key for signing.
by Alexandre Julliard 15 Nov '18

15 Nov '18

Module: wine Branch: master Commit: 263f6ef20123bd35dbcecca48a3137dc2be9ef94 URL: https://source.winehq.org/git/wine.git/?a=commit;h=263f6ef20123bd35dbcecca4… Author: Alexander Morozov <amorozov(a)etersoft.ru> Date: Wed Nov 14 15:33:38 2018 +0300 crypt32: Use correct private key for signing. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/crypt32_private.h | 1 + dlls/crypt32/msg.c | 13 +++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/dlls/crypt32/crypt32_private.h b/dlls/crypt32/crypt32_private.h index 1b390f4..ac70fe0 100644 --- a/dlls/crypt32/crypt32_private.h +++ b/dlls/crypt32/crypt32_private.h @@ -116,6 +116,7 @@ typedef struct _CRYPT_SIGNED_INFO CRYPT_CONTENT_INFO content; DWORD cSignerInfo; PCMSG_CMS_SIGNER_INFO rgSignerInfo; + PDWORD signerKeySpec; } CRYPT_SIGNED_INFO; BOOL CRYPT_AsnEncodeCMSSignedInfo(CRYPT_SIGNED_INFO *, void *pvData, diff --git a/dlls/crypt32/msg.c b/dlls/crypt32/msg.c index 26f2616..9fe63e2 100644 --- a/dlls/crypt32/msg.c +++ b/dlls/crypt32/msg.c @@ -1130,12 +1130,15 @@ static BOOL CSignedMsgData_Sign(CSignedMsgData *msg_data) for (i = 0; ret && i < msg_data->info->cSignerInfo; i++) { HCRYPTHASH hash; + DWORD keySpec = msg_data->info->signerKeySpec[i]; + if (!keySpec) + keySpec = AT_SIGNATURE; if (msg_data->info->rgSignerInfo[i].AuthAttrs.cAttr) hash = msg_data->signerHandles[i].authAttrHash; else hash = msg_data->signerHandles[i].contentHash; - ret = CryptSignHashW(hash, AT_SIGNATURE, NULL, 0, NULL, + ret = CryptSignHashW(hash, keySpec, NULL, 0, NULL, &msg_data->info->rgSignerInfo[i].EncryptedHash.cbData); if (ret) { @@ -1144,7 +1147,7 @@ static BOOL CSignedMsgData_Sign(CSignedMsgData *msg_data) msg_data->info->rgSignerInfo[i].EncryptedHash.cbData); if (msg_data->info->rgSignerInfo[i].EncryptedHash.pbData) { - ret = CryptSignHashW(hash, AT_SIGNATURE, NULL, 0, + ret = CryptSignHashW(hash, keySpec, NULL, 0, msg_data->info->rgSignerInfo[i].EncryptedHash.pbData, &msg_data->info->rgSignerInfo[i].EncryptedHash.cbData); if (ret) @@ -1194,6 +1197,7 @@ static void CSignedEncodeMsg_Close(HCRYPTMSG hCryptMsg) for (i = 0; i < msg->msg_data.info->cSignerInfo; i++) CSignerInfo_Free(&msg->msg_data.info->rgSignerInfo[i]); CSignedMsgData_CloseHandles(&msg->msg_data); + CryptMemFree(msg->msg_data.info->signerKeySpec); CryptMemFree(msg->msg_data.info->rgSignerInfo); CryptMemFree(msg->msg_data.info); } @@ -1416,6 +1420,9 @@ static HCRYPTMSG CSignedEncodeMsg_Open(DWORD dwFlags, msg->msg_data.info->cSignerInfo * sizeof(CMSG_CMS_SIGNER_INFO)); ret = CSignedMsgData_AllocateHandles(&msg->msg_data); + msg->msg_data.info->signerKeySpec = CryptMemAlloc(info->cSigners * sizeof(DWORD)); + if (!msg->msg_data.info->signerKeySpec) + ret = FALSE; for (i = 0; ret && i < msg->msg_data.info->cSignerInfo; i++) { if (info->rgSigners[i].SignerId.dwIdChoice == @@ -1432,6 +1439,8 @@ static HCRYPTMSG CSignedEncodeMsg_Open(DWORD dwFlags, CryptReleaseContext(info->rgSigners[i].hCryptProv, 0); } + msg->msg_data.info->signerKeySpec[i] = + info->rgSigners[i].dwKeySpec; } } else

1 0

Beren Minor : xinput1_3: Report SUCCESS from XInputSetState when FFB isn' t available.
by Alexandre Julliard 15 Nov '18

15 Nov '18

Module: wine Branch: master Commit: 186d107e4d586860008e2ac5fb1e2ebdbce06145 URL: https://source.winehq.org/git/wine.git/?a=commit;h=186d107e4d586860008e2ac5… Author: Beren Minor <beren.minor+git(a)gmail.com> Date: Wed Nov 14 05:34:59 2018 +0000 xinput1_3: Report SUCCESS from XInputSetState when FFB isn't available. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45992 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/xinput1_3/hid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/xinput1_3/hid.c b/dlls/xinput1_3/hid.c index 8a35443..d7e2248 100644 --- a/dlls/xinput1_3/hid.c +++ b/dlls/xinput1_3/hid.c @@ -457,10 +457,9 @@ DWORD HID_set_state(xinput_controller* device, XINPUT_VIBRATION* state) return ERROR_SUCCESS; return GetLastError(); } - return ERROR_SUCCESS; } - return ERROR_NOT_SUPPORTED; + return ERROR_SUCCESS; } void HID_enable(xinput_controller* device, BOOL enable)

1 0

Sven Baars : mfplat: Implement MFCreateMediaEvent.
by Alexandre Julliard 15 Nov '18

15 Nov '18

Module: wine Branch: master Commit: d7b05b219d34a8d719b722d6982412680453521e URL: https://source.winehq.org/git/wine.git/?a=commit;h=d7b05b219d34a8d719b722d6… Author: Sven Baars <sven.wine(a)gmail.com> Date: Tue Nov 13 23:20:45 2018 +0100 mfplat: Implement MFCreateMediaEvent. Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 361 +++++++++++++++++++++++++++++++++++++++++++++ dlls/mfplat/mfplat.spec | 2 +- dlls/mfplat/tests/mfplat.c | 66 +++++++++ include/mfapi.h | 2 + include/mfobjects.idl | 103 +++++++++++++ 5 files changed, 533 insertions(+), 1 deletion(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=d7b05b219d34a8d719b7…

1 0

Andreas Maier : dbghelp: Search for debug files in module path too.
by Alexandre Julliard 15 Nov '18

15 Nov '18

Module: wine Branch: master Commit: 6030ee5f6f64a2ebe6df2e505e2588eb300222c2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6030ee5f6f64a2ebe6df2e50… Author: Andreas Maier <andy1.m(a)gmx.de> Date: Mon Nov 5 22:20:33 2018 +0100 dbghelp: Search for debug files in module path too. Signed-off-by: Andreas Maier <andy1.m(a)gmx.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/dbghelp_private.h | 6 +++--- dlls/dbghelp/msc.c | 4 ++-- dlls/dbghelp/path.c | 32 +++++++++++++++++++++++++++++--- dlls/dbghelp/pe_module.c | 2 +- 4 files changed, 35 insertions(+), 9 deletions(-) diff --git a/dlls/dbghelp/dbghelp_private.h b/dlls/dbghelp/dbghelp_private.h index f689db8..1308d63 100644 --- a/dlls/dbghelp/dbghelp_private.h +++ b/dlls/dbghelp/dbghelp_private.h @@ -657,9 +657,9 @@ extern BOOL pdb_virtual_unwind(struct cpu_stack_walk *csw, DWORD_PTR ip, union ctx *context, struct pdb_cmd_pair *cpair) DECLSPEC_HIDDEN; /* path.c */ -extern BOOL path_find_symbol_file(const struct process* pcs, PCSTR full_path, - const GUID* guid, DWORD dw1, DWORD dw2, PSTR buffer, - BOOL* is_unmatched) DECLSPEC_HIDDEN; +extern BOOL path_find_symbol_file(const struct process* pcs, const struct module* module, + PCSTR full_path, const GUID* guid, DWORD dw1, DWORD dw2, + PSTR buffer, BOOL* is_unmatched) DECLSPEC_HIDDEN; /* pe_module.c */ extern BOOL pe_load_nt_header(HANDLE hProc, DWORD64 base, IMAGE_NT_HEADERS* nth) DECLSPEC_HIDDEN; diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c index 0508e12..6003bc3 100644 --- a/dlls/dbghelp/msc.c +++ b/dlls/dbghelp/msc.c @@ -2450,11 +2450,11 @@ static HANDLE map_pdb_file(const struct process* pcs, switch (lookup->kind) { case PDB_JG: - ret = path_find_symbol_file(pcs, lookup->filename, NULL, lookup->timestamp, + ret = path_find_symbol_file(pcs, module, lookup->filename, NULL, lookup->timestamp, lookup->age, dbg_file_path, &module->module.PdbUnmatched); break; case PDB_DS: - ret = path_find_symbol_file(pcs, lookup->filename, &lookup->guid, 0, + ret = path_find_symbol_file(pcs, module, lookup->filename, &lookup->guid, 0, lookup->age, dbg_file_path, &module->module.PdbUnmatched); break; } diff --git a/dlls/dbghelp/path.c b/dlls/dbghelp/path.c index 8c74426..0b9a1e3 100644 --- a/dlls/dbghelp/path.c +++ b/dlls/dbghelp/path.c @@ -49,6 +49,15 @@ static inline const WCHAR* file_nameW(const WCHAR* str) return p + 1; } +static inline void file_pathW(const WCHAR *src, WCHAR *dst) +{ + int len; + + for (len = strlenW(src) - 1; (len > 0) && (!is_sepW(src[len])); len--); + memcpy( dst, src, len * sizeof(WCHAR) ); + dst[len] = 0; +} + /****************************************************************** * FindDebugInfoFile (DBGHELP.@) * @@ -612,9 +621,9 @@ static BOOL CALLBACK module_find_cb(PCWSTR buffer, PVOID user) return mf->matched == 2; } -BOOL path_find_symbol_file(const struct process* pcs, PCSTR full_path, - const GUID* guid, DWORD dw1, DWORD dw2, PSTR buffer, - BOOL* is_unmatched) +BOOL path_find_symbol_file(const struct process* pcs, const struct module* module, + PCSTR full_path, const GUID* guid, DWORD dw1, DWORD dw2, + PSTR buffer, BOOL* is_unmatched) { struct module_find mf; WCHAR full_pathW[MAX_PATH]; @@ -643,6 +652,23 @@ BOOL path_find_symbol_file(const struct process* pcs, PCSTR full_path, return TRUE; } + /* FIXME: Use Environment-Variables (see MS docs) + _NT_SYMBOL_PATH and _NT_ALT_SYMBOL_PATH + FIXME: Implement "Standard Path Elements" (Path) ... (see MS docs) + do a search for (every?) path-element like this ... + <path> + <path>\dll + <path>\symbols\dll + (dll may be exe, or sys depending on the file extension) */ + + /* 2. check module-path */ + file_pathW(module->module.LoadedImageName, tmp); + if (do_searchW(filename, tmp, FALSE, module_find_cb, &mf)) + { + WideCharToMultiByte(CP_ACP, 0, tmp, -1, buffer, MAX_PATH, NULL, NULL); + return TRUE; + } + while (searchPath) { ptr = strchrW(searchPath, ';'); diff --git a/dlls/dbghelp/pe_module.c b/dlls/dbghelp/pe_module.c index e7255f8..ea2a826 100644 --- a/dlls/dbghelp/pe_module.c +++ b/dlls/dbghelp/pe_module.c @@ -531,7 +531,7 @@ static BOOL pe_load_dbg_file(const struct process* pcs, struct module* module, TRACE("Processing DBG file %s\n", debugstr_a(dbg_name)); - if (path_find_symbol_file(pcs, dbg_name, NULL, timestamp, 0, tmp, &module->module.DbgUnmatched) && + if (path_find_symbol_file(pcs, module, dbg_name, NULL, timestamp, 0, tmp, &module->module.DbgUnmatched) && (hFile = CreateFileA(tmp, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL)) != INVALID_HANDLE_VALUE && ((hMap = CreateFileMappingW(hFile, NULL, PAGE_READONLY, 0, 0, NULL)) != 0) &&

1 0