February 2018 - Wine-commits

Alex Henrie : d3dx9: Correctly round constants in D3DXSHMultiply3 implementation.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 00a352a3765223f9d37e111c13bcab8efa577318 URL: https://source.winehq.org/git/wine.git/?a=commit;h=00a352a3765223f9d37e111c… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Feb 5 20:47:08 2018 -0700 d3dx9: Correctly round constants in D3DXSHMultiply3 implementation. The correct constants are given to approximately 64-bit precision in "Code Generation and Factoring for Fast Evaluation of Low-order Spherical Harmonic Products and Squares" (2006) by John Snyder. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dx9_36/math.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/dlls/d3dx9_36/math.c b/dlls/d3dx9_36/math.c index 8f5f5b2..856e987 100644 --- a/dlls/d3dx9_36/math.c +++ b/dlls/d3dx9_36/math.c @@ -2573,27 +2573,27 @@ FLOAT * WINAPI D3DXSHMultiply3(FLOAT *out, const FLOAT *a, const FLOAT *b) out[0] = 0.28209479f * a[0] * b[0]; - ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; - tb = 0.28209479f * b[0] - 0.12615662f * b[6] - 0.21850968f * b[8]; + ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; + tb = 0.28209479f * b[0] - 0.12615663f * b[6] - 0.21850969f * b[8]; out[1] = ta * b[1] + tb * a[1]; t = a[1] * b[1]; out[0] += 0.28209479f * t; - out[6] = -0.12615662f * t; - out[8] = -0.21850968f * t; + out[6] = -0.12615663f * t; + out[8] = -0.21850969f * t; - ta = 0.21850968f * a[5]; - tb = 0.21850968f * b[5]; + ta = 0.21850969f * a[5]; + tb = 0.21850969f * b[5]; out[1] += ta * b[2] + tb * a[2]; out[2] = ta * b[1] + tb * a[1]; t = a[1] * b[2] +a[2] * b[1]; - out[5] = 0.21850968f * t; + out[5] = 0.21850969f * t; - ta = 0.21850968f * a[4]; - tb = 0.21850968f * b[4]; + ta = 0.21850969f * a[4]; + tb = 0.21850969f * b[4]; out[1] += ta * b[3] + tb * a[3]; out[3] = ta * b[1] + tb * a[1]; t = a[1] * b[3] + a[3] * b[1]; - out[4] = 0.21850968f * t; + out[4] = 0.21850969f * t; ta = 0.28209480f * a[0] + 0.25231326f * a[6]; tb = 0.28209480f * b[0] + 0.25231326f * b[6]; @@ -2629,14 +2629,14 @@ FLOAT * WINAPI D3DXSHMultiply3(FLOAT *out, const FLOAT *a, const FLOAT *b) out[4] += ta * b[5] + tb * a[5]; out[5] += ta * b[4] + tb * a[4]; t = a[4] * b[5] + a[5] * b[4]; - out[7] += 0.15607834f * t; + out[7] += 0.15607835f * t; - ta = 0.28209479f * a[0] + 0.09011186f * a[6] - 0.15607835f * a[8]; - tb = 0.28209479f * b[0] + 0.09011186f * b[6] - 0.15607835f * b[8]; + ta = 0.28209479f * a[0] + 0.09011188f * a[6] - 0.15607835f * a[8]; + tb = 0.28209479f * b[0] + 0.09011188f * b[6] - 0.15607835f * b[8]; out[5] += ta * b[5] + tb * a[5]; t = a[5] * b[5]; out[0] += 0.28209479f * t; - out[6] += 0.09011186f * t; + out[6] += 0.09011188f * t; out[8] -= 0.15607835f * t; ta = 0.28209480f * a[0]; @@ -2646,12 +2646,12 @@ FLOAT * WINAPI D3DXSHMultiply3(FLOAT *out, const FLOAT *a, const FLOAT *b) out[0] += 0.28209480f * t; out[6] += 0.18022376f * t; - ta = 0.28209479f * a[0] + 0.09011186f * a[6] + 0.15607835f * a[8]; - tb = 0.28209479f * b[0] + 0.09011186f * b[6] + 0.15607835f * b[8]; + ta = 0.28209479f * a[0] + 0.09011188f * a[6] + 0.15607835f * a[8]; + tb = 0.28209479f * b[0] + 0.09011188f * b[6] + 0.15607835f * b[8]; out[7] += ta * b[7] + tb * a[7]; t = a[7] * b[7]; out[0] += 0.28209479f * t; - out[6] += 0.09011186f * t; + out[6] += 0.09011188f * t; out[8] += 0.15607835f * t; ta = 0.28209479f * a[0] - 0.18022375f * a[6];

1 0

Matteo Bruni : wined3d: Introduce a WINED3DFMT_FLAG_GEN_MIPMAP flag.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 882742e17aabed5d68c7ec554063b8b95299a7bd URL: https://source.winehq.org/git/wine.git/?a=commit;h=882742e17aabed5d68c7ec55… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Tue Feb 13 15:54:13 2018 +0100 wined3d: Introduce a WINED3DFMT_FLAG_GEN_MIPMAP flag. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/directx.c | 8 ++------ dlls/wined3d/texture.c | 5 ++--- dlls/wined3d/utils.c | 18 ++++++++++++++++++ dlls/wined3d/wined3d_private.h | 1 + 4 files changed, 23 insertions(+), 9 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index c8f42fe..924cc72 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -5296,7 +5296,7 @@ HRESULT CDECL wined3d_check_device_format(const struct wined3d *wined3d, UINT ad const struct wined3d_gl_info *gl_info = &adapter->gl_info; const struct wined3d_format *adapter_format, *format; enum wined3d_gl_resource_type gl_type, gl_type_end; - BOOL mipmap_autogen_supported; + BOOL mipmap_autogen_supported = TRUE; DWORD format_flags = 0; DWORD allowed_usage; @@ -5410,7 +5410,6 @@ HRESULT CDECL wined3d_check_device_format(const struct wined3d *wined3d, UINT ad return WINED3DERR_NOTAVAILABLE; } - mipmap_autogen_supported = gl_info->supported[SGIS_GENERATE_MIPMAP]; for (; gl_type <= gl_type_end; ++gl_type) { if ((format->flags[gl_type] & format_flags) != format_flags) @@ -5440,11 +5439,8 @@ HRESULT CDECL wined3d_check_device_format(const struct wined3d *wined3d, UINT ad return WINED3DERR_NOTAVAILABLE; } - if ((format->flags[gl_type] & (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING)) - != (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING)) - { + if (!(format->flags[gl_type] & WINED3DFMT_FLAG_GEN_MIPMAP)) mipmap_autogen_supported = FALSE; - } } if ((usage & WINED3DUSAGE_AUTOGENMIPMAP) && !mipmap_autogen_supported) diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c index 3806103..c9210cb 100644 --- a/dlls/wined3d/texture.c +++ b/dlls/wined3d/texture.c @@ -386,8 +386,7 @@ static HRESULT wined3d_texture_init(struct wined3d_texture *texture, const struc texture->flags |= WINED3D_TEXTURE_DISCARD; if (flags & WINED3D_TEXTURE_CREATE_GENERATE_MIPMAPS) { - if (~format->flags[WINED3D_GL_RES_TYPE_TEX_2D] - & (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING)) + if (!(texture->resource.format_flags & WINED3DFMT_FLAG_GEN_MIPMAP)) WARN("Format doesn't support mipmaps generation, " "ignoring WINED3D_TEXTURE_CREATE_GENERATE_MIPMAPS flag.\n"); else @@ -2684,7 +2683,7 @@ static HRESULT volumetexture_init(struct wined3d_texture *texture, const struct texture->resource.map_binding = WINED3D_LOCATION_BUFFER; } - /* Generate all the surfaces. */ + /* Generate all the sub resources. */ for (i = 0; i < texture->level_count; ++i) { struct wined3d_texture_sub_resource *sub_resource; diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 6f7740d..960909f 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -3595,6 +3595,23 @@ static BOOL init_typeless_formats(struct wined3d_gl_info *gl_info) return TRUE; } +static void init_format_gen_mipmap_info(struct wined3d_gl_info *gl_info) +{ + unsigned int i, j; + + if (!gl_info->supported[SGIS_GENERATE_MIPMAP] && !gl_info->fbo_ops.glGenerateMipmap) + return; + + for (i = 0; i < gl_info->format_count; ++i) + { + struct wined3d_format *format = &gl_info->formats[i]; + + for (j = 0; j < ARRAY_SIZE(format->flags); ++j) + if (!(~format->flags[j] & (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING))) + format->flags[j] |= WINED3DFMT_FLAG_GEN_MIPMAP; + } +} + BOOL wined3d_caps_gl_ctx_test_viewport_subpixel_bits(struct wined3d_caps_gl_ctx *ctx) { static const struct wined3d_color red = {1.0f, 0.0f, 0.0f, 1.0f}; @@ -3783,6 +3800,7 @@ BOOL wined3d_adapter_init_format_info(struct wined3d_adapter *adapter, struct wi init_format_fbo_compat_info(ctx); init_format_filter_info(gl_info, adapter->driver_info.vendor); if (!init_typeless_formats(gl_info)) goto fail; + init_format_gen_mipmap_info(gl_info); init_format_depth_bias_scale(ctx, &adapter->d3d_info); return TRUE; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index f1f7530..8201536 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -4205,6 +4205,7 @@ extern enum wined3d_format_id pixelformat_for_depth(DWORD depth) DECLSPEC_HIDDEN #define WINED3DFMT_FLAG_TEXTURE 0x00080000 #define WINED3DFMT_FLAG_BLOCKS_NO_VERIFY 0x00100000 #define WINED3DFMT_FLAG_INTEGER 0x00200000 +#define WINED3DFMT_FLAG_GEN_MIPMAP 0x00400000 struct wined3d_rational {

1 0

Alexandre Julliard : include: Add definitions for SECTION_IMAGE_INFORMATION flags.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 1e036633e8fe54b69cf862794b012c98737c3ea6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1e036633e8fe54b69cf86279… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 13 10:37:28 2018 +0100 include: Add definitions for SECTION_IMAGE_INFORMATION flags. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/virtual.c | 2 +- include/wine/server_protocol.h | 5 +++++ include/winternl.h | 14 +++++++++++++- server/protocol.def | 5 +++++ 4 files changed, 24 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c index 426af01..8e764f7 100644 --- a/dlls/ntdll/virtual.c +++ b/dlls/ntdll/virtual.c @@ -3228,7 +3228,7 @@ NTSTATUS WINAPI NtQuerySection( HANDLE handle, SECTION_INFORMATION_CLASS class, info->DllCharacteristics = image_info.dll_charact; info->Machine = image_info.machine; info->ImageContainsCode = image_info.contains_code; - info->ImageFlags = image_info.image_flags; + info->u.ImageFlags = image_info.image_flags; info->LoaderFlags = image_info.loader_flags; info->ImageFileSize = image_info.file_size; info->CheckSum = image_info.checksum; diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index ba9f66f..602fc77 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -701,6 +701,11 @@ typedef struct unsigned int file_size; unsigned int checksum; } pe_image_info_t; +#define IMAGE_FLAGS_ComPlusNativeReady 0x01 +#define IMAGE_FLAGS_ComPlusILOnly 0x02 +#define IMAGE_FLAGS_ImageDynamicallyRelocated 0x04 +#define IMAGE_FLAGS_ImageMappedFlat 0x08 +#define IMAGE_FLAGS_BaseBelow4gb 0x10 struct rawinput_device { diff --git a/include/winternl.h b/include/winternl.h index 2911ff6..ec6850a 100644 --- a/include/winternl.h +++ b/include/winternl.h @@ -1965,7 +1965,19 @@ typedef struct _SECTION_IMAGE_INFORMATION { USHORT DllCharacteristics; USHORT Machine; BOOLEAN ImageContainsCode; - UCHAR ImageFlags; + union + { + UCHAR ImageFlags; + struct + { + UCHAR ComPlusNativeReady : 1; + UCHAR ComPlusILOnly : 1; + UCHAR ImageDynamicallyRelocated : 1; + UCHAR ImageMappedFlat : 1; + UCHAR BaseBelow4gb : 1; + UCHAR Reserved : 3; + } DUMMYSTRUCTNAME; + } DUMMYUNIONNAME; ULONG LoaderFlags; ULONG ImageFileSize; ULONG CheckSum; diff --git a/server/protocol.def b/server/protocol.def index a21d694..35824ae 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -717,6 +717,11 @@ typedef struct unsigned int file_size; unsigned int checksum; } pe_image_info_t; +#define IMAGE_FLAGS_ComPlusNativeReady 0x01 +#define IMAGE_FLAGS_ComPlusILOnly 0x02 +#define IMAGE_FLAGS_ImageDynamicallyRelocated 0x04 +#define IMAGE_FLAGS_ImageMappedFlat 0x08 +#define IMAGE_FLAGS_BaseBelow4gb 0x10 struct rawinput_device {

1 0

Alexandre Julliard : kernel32/tests: Add some tests for image flags and CLR images.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: b6ca8fd25dab76708b56150468278e4bde5f9264 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b6ca8fd25dab76708b561504… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 13 20:08:49 2018 +0100 kernel32/tests: Add some tests for image flags and CLR images. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/loader.c | 316 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 268 insertions(+), 48 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=b6ca8fd25dab76708b56…

1 0

Nikolay Sivov : comctl32/button: Use messages to get control text.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 65f23a745ad44dee50d451f063943ca80598e3c4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=65f23a745ad44dee50d451f0… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Feb 13 16:19:57 2018 +0300 comctl32/button: Use messages to get control text. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/button.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/button.c b/dlls/comctl32/button.c index 2f5a5b3..dccddf9 100644 --- a/dlls/comctl32/button.c +++ b/dlls/comctl32/button.c @@ -223,9 +223,10 @@ static inline void paint_button( HWND hwnd, LONG style, UINT action ) /* retrieve the button text; returned buffer must be freed by caller */ static inline WCHAR *get_button_text( HWND hwnd ) { - static const INT len = 512; + INT len = GetWindowTextLengthW( hwnd ); WCHAR *buffer = HeapAlloc( GetProcessHeap(), 0, (len + 1) * sizeof(WCHAR) ); - if (buffer) InternalGetWindowText( hwnd, buffer, len + 1 ); + if (buffer) + GetWindowTextW( hwnd, buffer, len + 1 ); return buffer; }

1 0

Nikolay Sivov : comctl32/button: Use the global memory allocation helpers.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 9d897b73a877e5eaae26df87930c951ff8273c14 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9d897b73a877e5eaae26df87… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Feb 13 16:19:58 2018 +0300 comctl32/button: Use the global memory allocation helpers. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/button.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/dlls/comctl32/button.c b/dlls/comctl32/button.c index dccddf9..7184d19 100644 --- a/dlls/comctl32/button.c +++ b/dlls/comctl32/button.c @@ -67,6 +67,7 @@ #include "uxtheme.h" #include "vssym32.h" #include "wine/debug.h" +#include "wine/heap.h" #include "comctl32.h" @@ -224,7 +225,7 @@ static inline void paint_button( HWND hwnd, LONG style, UINT action ) static inline WCHAR *get_button_text( HWND hwnd ) { INT len = GetWindowTextLengthW( hwnd ); - WCHAR *buffer = HeapAlloc( GetProcessHeap(), 0, (len + 1) * sizeof(WCHAR) ); + WCHAR *buffer = heap_alloc( (len + 1) * sizeof(WCHAR) ); if (buffer) GetWindowTextW( hwnd, buffer, len + 1 ); return buffer; @@ -732,14 +733,14 @@ static UINT BUTTON_CalcLabelRect(HWND hwnd, HDC hdc, RECT *rc) if (!(text = get_button_text( hwnd ))) goto empty_rect; if (!text[0]) { - HeapFree( GetProcessHeap(), 0, text ); + heap_free( text ); goto empty_rect; } if ((hFont = get_button_font( hwnd ))) hPrevFont = SelectObject( hdc, hFont ); DrawTextW(hdc, text, -1, &r, dtStyle | DT_CALCRECT); if (hPrevFont) SelectObject( hdc, hPrevFont ); - HeapFree( GetProcessHeap(), 0, text ); + heap_free( text ); break; } @@ -873,7 +874,7 @@ static void BUTTON_DrawLabel(HWND hwnd, HDC hdc, UINT dtFlags, const RECT *rc) DrawStateW(hdc, hbr, lpOutputProc, lp, wp, rc->left, rc->top, rc->right - rc->left, rc->bottom - rc->top, flags); - HeapFree( GetProcessHeap(), 0, text ); + heap_free( text ); } /********************************************************************** @@ -1278,7 +1279,7 @@ static void PB_ThemedPaint(HTHEME theme, HWND hwnd, HDC hDC, ButtonState drawSta if (text) { DrawThemeText(theme, hDC, BP_PUSHBUTTON, state, text, lstrlenW(text), dtFlags, 0, &textRect); - HeapFree(GetProcessHeap(), 0, text); + heap_free(text); } if (focused) @@ -1378,7 +1379,7 @@ static void CB_ThemedPaint(HTHEME theme, HWND hwnd, HDC hDC, ButtonState drawSta DrawFocusRect( hDC, &focusRect ); } - HeapFree(GetProcessHeap(), 0, text); + heap_free(text); } if (created_font) DeleteObject(font); @@ -1438,7 +1439,7 @@ static void GB_ThemedPaint(HTHEME theme, HWND hwnd, HDC hDC, ButtonState drawSta { InflateRect(&textRect, -2, 0); DrawThemeText(theme, hDC, BP_GROUPBOX, state, text, lstrlenW(text), 0, 0, &textRect); - HeapFree(GetProcessHeap(), 0, text); + heap_free(text); } if (created_font) DeleteObject(font);

1 0

Jacek Caban : mshtml: Use get_elem helper in IHTMLDocument2:: get_body implementation.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 06d54a6eb3fc7f7375983fbd4cc88e537abbeec9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=06d54a6eb3fc7f7375983fbd… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 12 23:27:02 2018 +0100 mshtml: Use get_elem helper in IHTMLDocument2::get_body implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmldoc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 5e3ed75..174ef20 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -261,7 +261,7 @@ static HRESULT WINAPI HTMLDocument_get_body(IHTMLDocument2 *iface, IHTMLElement { HTMLDocument *This = impl_from_IHTMLDocument2(iface); nsIDOMHTMLElement *nsbody = NULL; - HTMLDOMNode *node; + HTMLElement *element; HRESULT hres; TRACE("(%p)->(%p)\n", This, p); @@ -281,14 +281,13 @@ static HRESULT WINAPI HTMLDocument_get_body(IHTMLDocument2 *iface, IHTMLElement return S_OK; } - hres = get_node(This->doc_node, (nsIDOMNode*)nsbody, TRUE, &node); + hres = get_elem(This->doc_node, (nsIDOMElement*)nsbody, &element); nsIDOMHTMLElement_Release(nsbody); if(FAILED(hres)) return hres; - hres = IHTMLDOMNode_QueryInterface(&node->IHTMLDOMNode_iface, &IID_IHTMLElement, (void**)p); - node_release(node); - return hres; + *p = &element->IHTMLElement_iface; + return S_OK; } static HRESULT WINAPI HTMLDocument_get_activeElement(IHTMLDocument2 *iface, IHTMLElement **p)

1 0

Jacek Caban : mshtml: Use nsIDOMElement instead of nsIDOMHTMLElement where possible in HTMLElement implementation.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: 240fd267d9e139bbbd76781b96abc4d498ea6783 URL: https://source.winehq.org/git/wine.git/?a=commit;h=240fd267d9e139bbbd76781b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 12 23:27:34 2018 +0100 mshtml: Use nsIDOMElement instead of nsIDOMHTMLElement where possible in HTMLElement implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 140 ++++++++++++++++++++++++++++++++----------------- 1 file changed, 93 insertions(+), 47 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=240fd267d9e139bbbd76…

1 0

Jacek Caban : mshtml: Handle non-HTML elements in HTMLElement implementation.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: a219fd31d665b28e2472c3c0d8bcc0f55b0fcbd8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a219fd31d665b28e2472c3c0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 12 23:27:56 2018 +0100 mshtml: Handle non-HTML elements in HTMLElement implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 133 +++++++++++++++++++++++++++++++++++-------------- 1 file changed, 95 insertions(+), 38 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a219fd31d665b28e2472…

1 0

Jacek Caban : mshtml: Use nsIDOMElement instead of nsIDOMHTMLElement where possible.
by Alexandre Julliard 13 Feb '18

13 Feb '18

Module: wine Branch: master Commit: fba6da7982c3ef21fe6c717b9f2963829c4f9f7f URL: https://source.winehq.org/git/wine.git/?a=commit;h=fba6da7982c3ef21fe6c717b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 12 23:28:15 2018 +0100 mshtml: Use nsIDOMElement instead of nsIDOMHTMLElement where possible. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlattr.c | 4 ++-- dlls/mshtml/htmlcurstyle.c | 2 +- dlls/mshtml/htmlelemcol.c | 6 +++--- dlls/mshtml/htmlinput.c | 2 +- dlls/mshtml/htmloption.c | 6 +++--- dlls/mshtml/htmlscript.c | 2 +- dlls/mshtml/htmlstyle.c | 6 +++--- dlls/mshtml/script.c | 2 +- 8 files changed, 15 insertions(+), 15 deletions(-) diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c index e3a16df..61c6455 100644 --- a/dlls/mshtml/htmlattr.c +++ b/dlls/mshtml/htmlattr.c @@ -183,7 +183,7 @@ static HRESULT WINAPI HTMLDOMAttribute_get_specified(IHTMLDOMAttribute *iface, V TRACE("(%p)->(%p)\n", This, p); - if(!This->elem || !This->elem->nselem) { + if(!This->elem || !This->elem->dom_element) { FIXME("NULL This->elem\n"); return E_UNEXPECTED; } @@ -199,7 +199,7 @@ static HRESULT WINAPI HTMLDOMAttribute_get_specified(IHTMLDOMAttribute *iface, V /* FIXME: This is not exactly right, we have some attributes that don't map directly to Gecko attributes. */ nsAString_InitDepend(&nsname, name); - nsres = nsIDOMHTMLElement_GetAttributeNode(This->elem->nselem, &nsname, &nsattr); + nsres = nsIDOMElement_GetAttributeNode(This->elem->dom_element, &nsname, &nsattr); nsAString_Finish(&nsname); SysFreeString(name); if(NS_FAILED(nsres)) diff --git a/dlls/mshtml/htmlcurstyle.c b/dlls/mshtml/htmlcurstyle.c index a7daf4b..898fdd8 100644 --- a/dlls/mshtml/htmlcurstyle.c +++ b/dlls/mshtml/htmlcurstyle.c @@ -1345,7 +1345,7 @@ HRESULT HTMLCurrentStyle_Create(HTMLElement *elem, IHTMLCurrentStyle **p) assert(nsres == NS_OK); nsAString_Init(&nsempty_str, NULL); - nsres = nsIDOMWindow_GetComputedStyle(nswindow, (nsIDOMElement*)elem->nselem, &nsempty_str, &nsstyle); + nsres = nsIDOMWindow_GetComputedStyle(nswindow, elem->dom_element, &nsempty_str, &nsstyle); nsAString_Finish(&nsempty_str); nsIDOMWindow_Release(nswindow); if(NS_FAILED(nsres)) { diff --git a/dlls/mshtml/htmlelemcol.c b/dlls/mshtml/htmlelemcol.c index a851220..226cfe4 100644 --- a/dlls/mshtml/htmlelemcol.c +++ b/dlls/mshtml/htmlelemcol.c @@ -377,7 +377,7 @@ static BOOL is_elem_name(HTMLElement *elem, LPCWSTR name) static const PRUnichar nameW[] = {'n','a','m','e',0}; - if(!elem->nselem) + if(!elem->dom_element) return FALSE; nsAString_Init(&nsstr, NULL); @@ -507,10 +507,10 @@ static HRESULT WINAPI HTMLElementCollection_tags(IHTMLElementCollection *iface, nsAString_Init(&tag_str, NULL); for(i=0; i<This->len; i++) { - if(!This->elems[i]->nselem) + if(!This->elems[i]->dom_element) continue; - nsIDOMHTMLElement_GetTagName(This->elems[i]->nselem, &tag_str); + nsIDOMElement_GetTagName(This->elems[i]->dom_element, &tag_str); nsAString_GetData(&tag_str, &tag); if(CompareStringW(LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE, tag, -1, diff --git a/dlls/mshtml/htmlinput.c b/dlls/mshtml/htmlinput.c index 03b0aae..ad8663c 100644 --- a/dlls/mshtml/htmlinput.c +++ b/dlls/mshtml/htmlinput.c @@ -1590,7 +1590,7 @@ static HRESULT WINAPI HTMLLabelElement_put_htmlFor(IHTMLLabelElement *iface, BST nsAString_InitDepend(&for_str, forW); nsAString_InitDepend(&val_str, v); - nsres = nsIDOMHTMLElement_SetAttribute(This->element.nselem, &for_str, &val_str); + nsres = nsIDOMElement_SetAttribute(This->element.dom_element, &for_str, &val_str); nsAString_Finish(&for_str); nsAString_Finish(&val_str); if(NS_FAILED(nsres)) { diff --git a/dlls/mshtml/htmloption.c b/dlls/mshtml/htmloption.c index 43661b7..8210969 100644 --- a/dlls/mshtml/htmloption.c +++ b/dlls/mshtml/htmloption.c @@ -260,11 +260,11 @@ static HRESULT WINAPI HTMLOptionElement_put_text(IHTMLOptionElement *iface, BSTR while(1) { nsIDOMNode *child; - nsres = nsIDOMHTMLElement_GetFirstChild(This->element.nselem, &child); + nsres = nsIDOMElement_GetFirstChild(This->element.dom_element, &child); if(NS_FAILED(nsres) || !child) break; - nsres = nsIDOMHTMLElement_RemoveChild(This->element.nselem, child, &tmp); + nsres = nsIDOMElement_RemoveChild(This->element.dom_element, child, &tmp); nsIDOMNode_Release(child); if(NS_SUCCEEDED(nsres)) { nsIDOMNode_Release(tmp); @@ -282,7 +282,7 @@ static HRESULT WINAPI HTMLOptionElement_put_text(IHTMLOptionElement *iface, BSTR return E_FAIL; } - nsres = nsIDOMHTMLElement_AppendChild(This->element.nselem, (nsIDOMNode*)text_node, &tmp); + nsres = nsIDOMElement_AppendChild(This->element.dom_element, (nsIDOMNode*)text_node, &tmp); if(NS_SUCCEEDED(nsres)) nsIDOMNode_Release(tmp); else diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c index c755add..c449d3f 100644 --- a/dlls/mshtml/htmlscript.c +++ b/dlls/mshtml/htmlscript.c @@ -200,7 +200,7 @@ static HRESULT WINAPI HTMLScriptElement_put_text(IHTMLScriptElement *iface, BSTR return E_FAIL; } - nsres = nsIDOMHTMLElement_GetParentNode(This->element.nselem, &parent); + nsres = nsIDOMElement_GetParentNode(This->element.dom_element, &parent); if(NS_FAILED(nsres) || !parent) { TRACE("No parent, not executing\n"); This->parse_on_bind = TRUE; diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index fcec264..b99ea08 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -4701,12 +4701,12 @@ static HRESULT get_style_from_elem(HTMLElement *elem, nsIDOMCSSStyleDeclaration nsIDOMElementCSSInlineStyle *nselemstyle; nsresult nsres; - if(!elem->nselem) { - FIXME("NULL nselem\n"); + if(!elem->dom_element) { + FIXME("comment element\n"); return E_NOTIMPL; } - nsres = nsIDOMHTMLElement_QueryInterface(elem->nselem, &IID_nsIDOMElementCSSInlineStyle, + nsres = nsIDOMElement_QueryInterface(elem->dom_element, &IID_nsIDOMElementCSSInlineStyle, (void**)&nselemstyle); assert(nsres == NS_OK); diff --git a/dlls/mshtml/script.c b/dlls/mshtml/script.c index 72747af..0cd3162 100644 --- a/dlls/mshtml/script.c +++ b/dlls/mshtml/script.c @@ -905,7 +905,7 @@ static void script_file_available(ScriptBSC *bsc) return; } - nsres = nsIDOMHTMLElement_GetParentNode(script_elem->element.nselem, &parent); + nsres = nsIDOMElement_GetParentNode(script_elem->element.dom_element, &parent); if(NS_FAILED(nsres) || !parent) { TRACE("No parent, not executing\n"); script_elem->parse_on_bind = TRUE;

1 0