April 2018 - Wine-commits - list.winehq.org

Józef Kucia : d3d11: Do not print FIXMEs() for known DXBC chunks in shdr_handler().
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 67192c46bc93fd1aea92da88dbaf14bb3bba5b18 URL: https://source.winehq.org/git/wine.git/?a=commit;h=67192c46bc93fd1aea92da88… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Apr 27 14:52:43 2018 +0200 d3d11: Do not print FIXMEs() for known DXBC chunks in shdr_handler(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/d3d11_private.h | 6 ++++-- dlls/d3d11/shader.c | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/d3d11/d3d11_private.h b/dlls/d3d11/d3d11_private.h index bc9d6a1..94e9e39 100644 --- a/dlls/d3d11/d3d11_private.h +++ b/dlls/d3d11/d3d11_private.h @@ -45,14 +45,16 @@ #define MAKE_TAG(ch0, ch1, ch2, ch3) \ ((DWORD)(ch0) | ((DWORD)(ch1) << 8) | \ ((DWORD)(ch2) << 16) | ((DWORD)(ch3) << 24 )) +#define TAG_AON9 MAKE_TAG('A', 'o', 'n', '9') #define TAG_DXBC MAKE_TAG('D', 'X', 'B', 'C') #define TAG_ISGN MAKE_TAG('I', 'S', 'G', 'N') -#define TAG_OSGN MAKE_TAG('O', 'S', 'G', 'N') #define TAG_OSG5 MAKE_TAG('O', 'S', 'G', '5') +#define TAG_OSGN MAKE_TAG('O', 'S', 'G', 'N') #define TAG_PCSG MAKE_TAG('P', 'C', 'S', 'G') +#define TAG_RDEF MAKE_TAG('R', 'D', 'E', 'F') #define TAG_SHDR MAKE_TAG('S', 'H', 'D', 'R') #define TAG_SHEX MAKE_TAG('S', 'H', 'E', 'X') -#define TAG_AON9 MAKE_TAG('A', 'o', 'n', '9') +#define TAG_STAT MAKE_TAG('S', 'T', 'A', 'T') struct d3d_device; diff --git a/dlls/d3d11/shader.c b/dlls/d3d11/shader.c index 9c0059f..b15bd5c 100644 --- a/dlls/d3d11/shader.c +++ b/dlls/d3d11/shader.c @@ -136,6 +136,10 @@ static HRESULT shdr_handler(const char *data, DWORD data_size, DWORD tag, void * } break; + case TAG_RDEF: + case TAG_STAT: + break; + default: FIXME("Unhandled chunk %s.\n", debugstr_an((const char *)&tag, 4)); break;

1 0

Józef Kucia : wined3d: Implement clears for 1D render target views.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 130b6ed876e6c37ab4ff165ea0fedf567dcd7760 URL: https://source.winehq.org/git/wine.git/?a=commit;h=130b6ed876e6c37ab4ff165e… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Apr 27 14:52:44 2018 +0200 wined3d: Implement clears for 1D render target views. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 87d4542..86c36d5 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4394,7 +4394,7 @@ HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *devi return WINED3D_OK; resource = view->resource; - if (resource->type != WINED3D_RTYPE_TEXTURE_2D) + if (resource->type != WINED3D_RTYPE_TEXTURE_1D && resource->type != WINED3D_RTYPE_TEXTURE_2D) { FIXME("Not implemented for %s resources.\n", debug_d3dresourcetype(resource->type)); return WINED3DERR_INVALIDCALL;

1 0

Józef Kucia : wined3d: Implement copying for 1D textures.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 16517e4eea7cb477d504d737267db6fc52cf6c26 URL: https://source.winehq.org/git/wine.git/?a=commit;h=16517e4eea7cb477d504d737… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Apr 27 14:52:45 2018 +0200 wined3d: Implement copying for 1D textures. 1D textures are handled by raw and CPU blitter. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 3 +++ dlls/wined3d/cs.c | 12 ++++-------- dlls/wined3d/glsl_shader.c | 3 +++ dlls/wined3d/surface.c | 12 ++++++++++++ 4 files changed, 22 insertions(+), 8 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 7d3f547..7988398 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -7701,6 +7701,9 @@ static BOOL arbfp_blit_supported(enum wined3d_blit_op blit_op, const struct wine if (!context->gl_info->supported[ARB_FRAGMENT_PROGRAM]) return FALSE; + if (src_resource->type != WINED3D_RTYPE_TEXTURE_2D) + return FALSE; + if (blit_op == WINED3D_BLIT_OP_RAW_BLIT && dst_format->id == src_format->id) { if (dst_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL)) diff --git a/dlls/wined3d/cs.c b/dlls/wined3d/cs.c index ded49f2..173490d 100644 --- a/dlls/wined3d/cs.c +++ b/dlls/wined3d/cs.c @@ -2080,13 +2080,6 @@ static void wined3d_cs_exec_blt_sub_resource(struct wined3d_cs *cs, const void * buffer_from_resource(op->src_resource), op->src_box.left, op->src_box.right - op->src_box.left); } - else if (op->dst_resource->type == WINED3D_RTYPE_TEXTURE_2D) - { - if (FAILED(texture2d_blt(texture_from_resource(op->dst_resource), op->dst_sub_resource_idx, - &op->dst_box, texture_from_resource(op->src_resource), op->src_sub_resource_idx, - &op->src_box, op->flags, &op->fx, op->filter))) - FIXME("Blit failed.\n"); - } else if (op->dst_resource->type == WINED3D_RTYPE_TEXTURE_3D) { struct wined3d_texture *src_texture, *dst_texture; @@ -2165,7 +2158,10 @@ static void wined3d_cs_exec_blt_sub_resource(struct wined3d_cs *cs, const void * } else { - FIXME("Not implemented for %s resources.\n", debug_d3dresourcetype(op->dst_resource->type)); + if (FAILED(texture2d_blt(texture_from_resource(op->dst_resource), op->dst_sub_resource_idx, + &op->dst_box, texture_from_resource(op->src_resource), op->src_sub_resource_idx, + &op->src_box, op->flags, &op->fx, op->filter))) + FIXME("Blit failed.\n"); } error: diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 5d1f118..2af9b97 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -12481,6 +12481,9 @@ static BOOL glsl_blitter_supported(enum wined3d_blit_op blit_op, const struct wi return FALSE; } + if (src_resource->type != WINED3D_RTYPE_TEXTURE_2D) + return FALSE; + if (src_texture->target == GL_TEXTURE_2D_MULTISAMPLE || dst_texture->target == GL_TEXTURE_2D_MULTISAMPLE || src_texture->target == GL_TEXTURE_2D_MULTISAMPLE_ARRAY diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 7a13b58..bfee4d3 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -305,6 +305,9 @@ static BOOL fbo_blitter_supported(enum wined3d_blit_op blit_op, const struct win if (!(src_resource->access & dst_resource->access & WINED3D_RESOURCE_ACCESS_GPU)) return FALSE; + if (src_resource->type != WINED3D_RTYPE_TEXTURE_2D) + return FALSE; + switch (blit_op) { case WINED3D_BLIT_OP_COLOR_BLIT: @@ -1509,6 +1512,12 @@ static HRESULT wined3d_texture_blt_special(struct wined3d_texture *dst_texture, dst_texture, dst_sub_resource_idx, wine_dbgstr_rect(dst_rect), src_texture, src_sub_resource_idx, wine_dbgstr_rect(src_rect), flags, fx, debug_d3dtexturefiltertype(filter)); + if (dst_texture->resource.type != WINED3D_RTYPE_TEXTURE_2D) + { + FIXME("Not implemented for %s resources.\n", debug_d3dresourcetype(dst_texture->resource.type)); + return WINED3DERR_INVALIDCALL; + } + /* Get the swapchain. One of the surfaces has to be a primary surface. */ if (!(dst_texture->resource.access & WINED3D_RESOURCE_ACCESS_GPU)) { @@ -2171,6 +2180,9 @@ static BOOL ffp_blit_supported(enum wined3d_blit_op blit_op, const struct wined3 const struct wined3d_format *dst_format = dst_resource->format; BOOL decompress; + if (src_resource->type != WINED3D_RTYPE_TEXTURE_2D) + return FALSE; + decompress = src_format && (src_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_COMPRESSED) && !(dst_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_COMPRESSED); if (!decompress && !(src_resource->access & dst_resource->access & WINED3D_RESOURCE_ACCESS_GPU))

1 0

Józef Kucia : d3d11/tests: Add test for clearing 1D render target views.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 185119906584d335196112b1efbab0d5bfbf6491 URL: https://source.winehq.org/git/wine.git/?a=commit;h=185119906584d335196112b1… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Apr 27 14:52:46 2018 +0200 d3d11/tests: Add test for clearing 1D render target views. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 166 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 134 insertions(+), 32 deletions(-) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 465e2d5..8ca6634 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -678,9 +678,35 @@ struct resource_readback unsigned int width, height, sub_resource_idx; }; +static void init_resource_readback(ID3D11Resource *resource, ID3D11Resource *readback_resource, + unsigned int width, unsigned int height, unsigned int sub_resource_idx, + ID3D11Device *device, struct resource_readback *rb) +{ + HRESULT hr; + + rb->resource = readback_resource; + rb->width = width; + rb->height = height; + rb->sub_resource_idx = sub_resource_idx; + + ID3D11Device_GetImmediateContext(device, &rb->immediate_context); + + ID3D11DeviceContext_CopyResource(rb->immediate_context, rb->resource, resource); + if (FAILED(hr = ID3D11DeviceContext_Map(rb->immediate_context, + rb->resource, sub_resource_idx, D3D11_MAP_READ, 0, &rb->map_desc))) + { + trace("Failed to map resource, hr %#x.\n", hr); + ID3D11Resource_Release(rb->resource); + rb->resource = NULL; + ID3D11DeviceContext_Release(rb->immediate_context); + rb->immediate_context = NULL; + } +} + static void get_buffer_readback(ID3D11Buffer *buffer, struct resource_readback *rb) { D3D11_BUFFER_DESC buffer_desc; + ID3D11Resource *rb_buffer; ID3D11Device *device; HRESULT hr; @@ -694,30 +720,48 @@ static void get_buffer_readback(ID3D11Buffer *buffer, struct resource_readback * buffer_desc.CPUAccessFlags = D3D11_CPU_ACCESS_READ; buffer_desc.MiscFlags = 0; buffer_desc.StructureByteStride = 0; - if (FAILED(hr = ID3D11Device_CreateBuffer(device, &buffer_desc, NULL, (ID3D11Buffer **)&rb->resource))) + if (FAILED(hr = ID3D11Device_CreateBuffer(device, &buffer_desc, NULL, (ID3D11Buffer **)&rb_buffer))) { trace("Failed to create staging buffer, hr %#x.\n", hr); ID3D11Device_Release(device); return; } - rb->width = buffer_desc.ByteWidth; - rb->height = 1; - rb->sub_resource_idx = 0; + init_resource_readback((ID3D11Resource *)buffer, rb_buffer, + buffer_desc.ByteWidth, 1, 0, device, rb); - ID3D11Device_GetImmediateContext(device, &rb->immediate_context); + ID3D11Device_Release(device); +} + +static void get_texture1d_readback(ID3D11Texture1D *texture, unsigned int sub_resource_idx, + struct resource_readback *rb) +{ + D3D11_TEXTURE1D_DESC texture_desc; + ID3D11Resource *rb_texture; + unsigned int miplevel; + ID3D11Device *device; + HRESULT hr; + + memset(rb, 0, sizeof(*rb)); - ID3D11DeviceContext_CopyResource(rb->immediate_context, rb->resource, (ID3D11Resource *)buffer); - if (FAILED(hr = ID3D11DeviceContext_Map(rb->immediate_context, rb->resource, 0, - D3D11_MAP_READ, 0, &rb->map_desc))) + ID3D11Texture1D_GetDevice(texture, &device); + + ID3D11Texture1D_GetDesc(texture, &texture_desc); + texture_desc.Usage = D3D11_USAGE_STAGING; + texture_desc.BindFlags = 0; + texture_desc.CPUAccessFlags = D3D11_CPU_ACCESS_READ; + texture_desc.MiscFlags = 0; + if (FAILED(hr = ID3D11Device_CreateTexture1D(device, &texture_desc, NULL, (ID3D11Texture1D **)&rb_texture))) { - trace("Failed to map buffer, hr %#x.\n", hr); - ID3D11Resource_Release(rb->resource); - rb->resource = NULL; - ID3D11DeviceContext_Release(rb->immediate_context); - rb->immediate_context = NULL; + trace("Failed to create texture, hr %#x.\n", hr); + ID3D11Device_Release(device); + return; } + miplevel = sub_resource_idx % texture_desc.MipLevels; + init_resource_readback((ID3D11Resource *)texture, rb_texture, + max(1, texture_desc.Width >> miplevel), 1, sub_resource_idx, device, rb); + ID3D11Device_Release(device); } @@ -725,6 +769,7 @@ static void get_texture_readback(ID3D11Texture2D *texture, unsigned int sub_reso struct resource_readback *rb) { D3D11_TEXTURE2D_DESC texture_desc; + ID3D11Resource *rb_texture; unsigned int miplevel; ID3D11Device *device; HRESULT hr; @@ -738,7 +783,7 @@ static void get_texture_readback(ID3D11Texture2D *texture, unsigned int sub_reso texture_desc.BindFlags = 0; texture_desc.CPUAccessFlags = D3D11_CPU_ACCESS_READ; texture_desc.MiscFlags = 0; - if (FAILED(hr = ID3D11Device_CreateTexture2D(device, &texture_desc, NULL, (ID3D11Texture2D **)&rb->resource))) + if (FAILED(hr = ID3D11Device_CreateTexture2D(device, &texture_desc, NULL, (ID3D11Texture2D **)&rb_texture))) { trace("Failed to create texture, hr %#x.\n", hr); ID3D11Device_Release(device); @@ -746,22 +791,10 @@ static void get_texture_readback(ID3D11Texture2D *texture, unsigned int sub_reso } miplevel = sub_resource_idx % texture_desc.MipLevels; - rb->width = max(1, texture_desc.Width >> miplevel); - rb->height = max(1, texture_desc.Height >> miplevel); - rb->sub_resource_idx = sub_resource_idx; - - ID3D11Device_GetImmediateContext(device, &rb->immediate_context); - - ID3D11DeviceContext_CopyResource(rb->immediate_context, rb->resource, (ID3D11Resource *)texture); - if (FAILED(hr = ID3D11DeviceContext_Map(rb->immediate_context, rb->resource, sub_resource_idx, - D3D11_MAP_READ, 0, &rb->map_desc))) - { - trace("Failed to map sub-resource %u, hr %#x.\n", sub_resource_idx, hr); - ID3D11Resource_Release(rb->resource); - rb->resource = NULL; - ID3D11DeviceContext_Release(rb->immediate_context); - rb->immediate_context = NULL; - } + init_resource_readback((ID3D11Resource *)texture, rb_texture, + max(1, texture_desc.Width >> miplevel), + max(1, texture_desc.Height >> miplevel), + sub_resource_idx, device, rb); ID3D11Device_Release(device); } @@ -868,6 +901,30 @@ static void check_texture_color_(unsigned int line, ID3D11Texture2D *texture, check_texture_sub_resource_color_(line, texture, sub_resource_idx, NULL, expected_color, max_diff); } +#define check_texture1d_sub_resource_color(a, b, c, d, e) check_texture1d_sub_resource_color_(__LINE__, a, b, c, d, e) +static void check_texture1d_sub_resource_color_(unsigned int line, ID3D11Texture1D *texture, + unsigned int sub_resource_idx, const RECT *rect, DWORD expected_color, BYTE max_diff) +{ + struct resource_readback rb; + + get_texture1d_readback(texture, sub_resource_idx, &rb); + check_readback_data_color_(line, &rb, rect, expected_color, max_diff); + release_resource_readback(&rb); +} + +#define check_texture1d_color(t, c, d) check_texture1d_color_(__LINE__, t, c, d) +static void check_texture1d_color_(unsigned int line, ID3D11Texture1D *texture, + DWORD expected_color, BYTE max_diff) +{ + unsigned int sub_resource_idx, sub_resource_count; + D3D11_TEXTURE1D_DESC texture_desc; + + ID3D11Texture1D_GetDesc(texture, &texture_desc); + sub_resource_count = texture_desc.ArraySize * texture_desc.MipLevels; + for (sub_resource_idx = 0; sub_resource_idx < sub_resource_count; ++sub_resource_idx) + check_texture1d_sub_resource_color_(line, texture, sub_resource_idx, NULL, expected_color, max_diff); +} + #define check_texture_sub_resource_float(a, b, c, d, e) check_texture_sub_resource_float_(__LINE__, a, b, c, d, e) static void check_texture_sub_resource_float_(unsigned int line, ID3D11Texture2D *texture, unsigned int sub_resource_idx, const RECT *rect, float expected_value, BYTE max_diff) @@ -12574,7 +12631,51 @@ static void test_swapchain_flip(void) DestroyWindow(window); } -static void test_clear_render_target_view(void) +static void test_clear_render_target_view_1d(void) +{ + static const float color[] = {0.1f, 0.5f, 0.3f, 0.75f}; + static const float green[] = {0.0f, 1.0f, 0.0f, 0.5f}; + + struct d3d11_test_context test_context; + D3D11_TEXTURE1D_DESC texture_desc; + ID3D11DeviceContext *context; + ID3D11RenderTargetView *rtv; + ID3D11Texture1D *texture; + ID3D11Device *device; + HRESULT hr; + + if (!init_test_context(&test_context, NULL)) + return; + + device = test_context.device; + context = test_context.immediate_context; + + texture_desc.Width = 64; + texture_desc.MipLevels = 1; + texture_desc.ArraySize = 1; + texture_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; + texture_desc.Usage = D3D11_USAGE_DEFAULT; + texture_desc.BindFlags = D3D11_BIND_RENDER_TARGET; + texture_desc.CPUAccessFlags = 0; + texture_desc.MiscFlags = 0; + hr = ID3D11Device_CreateTexture1D(device, &texture_desc, NULL, &texture); + ok(SUCCEEDED(hr), "Failed to create depth texture, hr %#x.\n", hr); + + hr = ID3D11Device_CreateRenderTargetView(device, (ID3D11Resource *)texture, NULL, &rtv); + ok(SUCCEEDED(hr), "Failed to create render target view, hr %#x.\n", hr); + + ID3D11DeviceContext_ClearRenderTargetView(context, rtv, color); + check_texture1d_color(texture, 0xbf4c7f19, 1); + + ID3D11DeviceContext_ClearRenderTargetView(context, rtv, green); + check_texture1d_color(texture, 0x8000ff00, 1); + + ID3D11RenderTargetView_Release(rtv); + ID3D11Texture1D_Release(texture); + release_test_context(&test_context); +} + +static void test_clear_render_target_view_2d(void) { static const DWORD expected_color = 0xbf4c7f19, expected_srgb_color = 0xbf95bc59; static const float color[] = {0.1f, 0.5f, 0.3f, 0.75f}; @@ -26517,7 +26618,8 @@ START_TEST(d3d11) run_for_each_feature_level(test_swapchain_formats); test_swapchain_views(); test_swapchain_flip(); - test_clear_render_target_view(); + test_clear_render_target_view_1d(); + test_clear_render_target_view_2d(); test_clear_depth_stencil_view(); test_clear_buffer_unordered_access_view(); test_initial_depth_stencil_state();

1 0

Józef Kucia : wined3d: Do not check for ARB_fragment_program in arbfp_blit_supported().
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 3d746a6a43acca1b10cfc9800a0c52a544dba947 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3d746a6a43acca1b10cfc980… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Apr 27 14:52:47 2018 +0200 wined3d: Do not check for ARB_fragment_program in arbfp_blit_supported(). ARBfp blitter isn't be created if ARB_fragment_program is not supported. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 7988398..d4cc9d5 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -7698,9 +7698,6 @@ static BOOL arbfp_blit_supported(enum wined3d_blit_op blit_op, const struct wine enum complex_fixup src_fixup; BOOL decompress; - if (!context->gl_info->supported[ARB_FRAGMENT_PROGRAM]) - return FALSE; - if (src_resource->type != WINED3D_RTYPE_TEXTURE_2D) return FALSE;

1 0

Józef Kucia : wined3d: Correctly check for absence of precise flags.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 799719a4233ad463a0d2a309f8c831ae4744833c URL: https://source.winehq.org/git/wine.git/?a=commit;h=799719a4233ad463a0d2a309… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Apr 27 14:52:48 2018 +0200 wined3d: Correctly check for absence of precise flags. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/shader.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index 4986f3c..3750dee 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -1917,19 +1917,19 @@ static void shader_dump_sync_flags(struct wined3d_string_buffer *buffer, DWORD s shader_addline(buffer, "_unknown_flags(%#x)", sync_flags); } -static void shader_dump_precise_flags(struct wined3d_string_buffer *buffer, DWORD precise_flags) +static void shader_dump_precise_flags(struct wined3d_string_buffer *buffer, DWORD flags) { - if (!precise_flags) + if (!(flags & WINED3DSI_PRECISE_XYZW)) return; shader_addline(buffer, " [precise"); - if (precise_flags != WINED3DSI_PRECISE_XYZW) + if (flags != WINED3DSI_PRECISE_XYZW) { shader_addline(buffer, "(%s%s%s%s)", - precise_flags & WINED3DSI_PRECISE_X ? "x" : "", - precise_flags & WINED3DSI_PRECISE_Y ? "y" : "", - precise_flags & WINED3DSI_PRECISE_Z ? "z" : "", - precise_flags & WINED3DSI_PRECISE_W ? "w" : ""); + flags & WINED3DSI_PRECISE_X ? "x" : "", + flags & WINED3DSI_PRECISE_Y ? "y" : "", + flags & WINED3DSI_PRECISE_Z ? "z" : "", + flags & WINED3DSI_PRECISE_W ? "w" : ""); } shader_addline(buffer, "]"); }

1 0

Bernhard Übelacker : cmd: Avoid having first parameter to start.exe ignored.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: f95b85a856d06c93b316aca40a1481b4af6e814e URL: https://source.winehq.org/git/wine.git/?a=commit;h=f95b85a856d06c93b316aca4… Author: Bernhard Übelacker <bernhardu(a)mailbox.org> Date: Fri Apr 27 17:57:42 2018 +0800 cmd: Avoid having first parameter to start.exe ignored. Signed-off-by: Bernhard Übelacker <bernhardu(a)mailbox.org> Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/cmd/builtins.c | 15 ++++++++------- programs/cmd/tests/test_builtins.cmd | 4 ++++ programs/cmd/tests/test_builtins.cmd.exp | 2 ++ 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index ec66cd5..04b098e 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -4322,7 +4322,7 @@ void WCMD_start(WCHAR *args) int argno; int have_title; WCHAR file[MAX_PATH]; - WCHAR *cmdline; + WCHAR *cmdline, *cmdline_params; STARTUPINFOW st; PROCESS_INFORMATION pi; @@ -4331,6 +4331,7 @@ void WCMD_start(WCHAR *args) cmdline = heap_alloc( (strlenW(file) + strlenW(args) + 8) * sizeof(WCHAR) ); strcpyW( cmdline, file ); strcatW( cmdline, spaceW ); + cmdline_params = cmdline + strlenW(cmdline); /* The start built-in has some special command-line parsing properties * which will be outlined here. @@ -4382,17 +4383,17 @@ void WCMD_start(WCHAR *args) have_title = TRUE; /* Copy all of the cmdline processed */ - memcpy(cmdline, args, sizeof(WCHAR) * (argN - args)); - cmdline[argN - args] = '\0'; + memcpy(cmdline_params, args, sizeof(WCHAR) * (argN - args)); + cmdline_params[argN - args] = '\0'; /* Add quoted title */ - strcatW(cmdline, prefixQuote); - strcatW(cmdline, thisArg); - strcatW(cmdline, postfixQuote); + strcatW(cmdline_params, prefixQuote); + strcatW(cmdline_params, thisArg); + strcatW(cmdline_params, postfixQuote); /* Concatenate remaining command-line */ thisArg = WCMD_parameter_with_delims(args, argno, &argN, TRUE, FALSE, startDelims); - strcatW(cmdline, argN + strlenW(thisArg)); + strcatW(cmdline_params, argN + strlenW(thisArg)); break; } diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index f684628..63ec3ca 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -2988,6 +2988,10 @@ path set path=%WINE_backup_path% set WINE_backup_path= +echo ------------ Testing start /W ------------ +echo start /W failed to wait>foobar.txt +start /W "" cmd /C "ping -n1 & echo start /W seems to really wait>foobar.txt"& type foobar.txt& del foobar.txt + echo ------------ Testing combined CALLs/GOTOs ------------ echo @echo off>foo.cmd echo goto :eof>>foot.cmd diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index 4663c86..dcc9629 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -1574,6 +1574,8 @@ Correctly ignored trailing information PATH=original PATH=try2 PATH=try3 +------------ Testing start /W ------------ +start /W seems to really wait ------------ Testing combined CALLs/GOTOs ------------ world cheball

1 0

Zebediah Figura : msi: Initialize [out] strings to NULL.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 71c0738c0e2598d2af9e31e2e82b69e6a5081e51 URL: https://source.winehq.org/git/wine.git/?a=commit;h=71c0738c0e2598d2af9e31e2… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Apr 27 09:37:46 2018 -0500 msi: Initialize [out] strings to NULL. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/custom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c index 12fe53e..72c3efd 100644 --- a/dlls/msi/custom.c +++ b/dlls/msi/custom.c @@ -496,10 +496,10 @@ UINT __wine_msi_call_dll_function(const GUID *guid) RPC_WSTR binding_str; MSIHANDLE hPackage; RPC_STATUS status; + LPWSTR dll = NULL; + LPSTR proc = NULL; HANDLE hModule; HANDLE thread; - LPWSTR dll; - LPSTR proc; INT type; UINT r;

1 0

Alexandre Julliard : Release 3.7.
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: master Commit: 9fecb7499531ddbcde7970b4d98df92dbc1bc010 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9fecb7499531ddbcde7970b4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Apr 27 20:23:54 2018 +0200 Release 3.7. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 682 ++++++++++++++++++++++++++++++++------------------------------ AUTHORS | 1 + VERSION | 2 +- configure | 18 +- 4 files changed, 360 insertions(+), 343 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=9fecb7499531ddbcde79…

1 0

Tag wine-3.7 : Alexandre Julliard : Release 3.7
by Alexandre Julliard 27 Apr '18

27 Apr '18

Module: wine Branch: refs/tags/wine-3.7 Tag: 0bf86523956402bedf64ee42dc9c00c84d6c664c URL: https://source.winehq.org/git/wine.git/?a=tag;h=0bf86523956402bedf64ee42dc9… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Apr 27 20:23:54 2018 +0200 Release 3.7

1 0