May 2018 - Wine-commits - list.winehq.org

Józef Kucia : libs/vkd3d-shader: Implement swizzling for shader outputs.
by Alexandre Julliard 24 May '18

24 May '18

Module: vkd3d Branch: master Commit: 40ee9fa0e9204c7891670a8393312a7b85314906 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=40ee9fa0e9204c7891670a8… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu May 24 13:08:35 2018 +0200 libs/vkd3d-shader: Implement swizzling for shader outputs. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/private/vkd3d_shader.h | 23 ++++++++++++++++++++++- libs/vkd3d-shader/spirv.c | 25 ++++++++++++++++++++++--- libs/vkd3d-shader/vkd3d_shader_main.c | 9 +++++---- libs/vkd3d-shader/vkd3d_shader_private.h | 13 +------------ libs/vkd3d/state.c | 2 +- programs/vkd3d-compiler/main.c | 2 +- 6 files changed, 52 insertions(+), 22 deletions(-) Diff: https://source.winehq.org/git/vkd3d.git/?a=commitdiff;h=40ee9fa0e9204c78916…

1 0

Francois Gouget : testbot: Remove support for archiving jobs.
by Alexandre Julliard 24 May '18

24 May '18

Module: tools Branch: master Commit: 09a8d72b062d613581271eea05623ec16aac5bca URL: https://source.winehq.org/git/tools.git/?a=commit;h=09a8d72b062d613581271ee… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 24 17:28:21 2018 +0200 testbot: Remove support for archiving jobs. We don't use it and there does not seem to be any forseable need for it anyway. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/Janitor.pl | 26 +----------- testbot/ddl/update34.sql | 4 ++ testbot/ddl/winetestbot.sql | 2 - testbot/doc/winetestbot-schema.dia | 85 ++++++++++++++------------------------ testbot/lib/WineTestBot/Config.pm | 5 +-- testbot/lib/WineTestBot/Jobs.pm | 9 ---- testbot/web/index.pl | 20 +-------- 7 files changed, 39 insertions(+), 112 deletions(-) Diff: https://source.winehq.org/git/tools.git/?a=commitdiff;h=09a8d72b062d6135812…

1 0

Francois Gouget : testbot: Sort the modules and test units alphabetically when creating jobs.
by Alexandre Julliard 24 May '18

24 May '18

Module: tools Branch: master Commit: 3501004ebe177a3c76528433a1d9b6468022e17b URL: https://source.winehq.org/git/tools.git/?a=commit;h=3501004ebe177a3c7652843… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 24 17:28:28 2018 +0200 testbot: Sort the modules and test units alphabetically when creating jobs. This makes it easier to find the results for a specific module or test unit. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Patches.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/lib/WineTestBot/Patches.pm b/testbot/lib/WineTestBot/Patches.pm index 26127e9..b156687 100644 --- a/testbot/lib/WineTestBot/Patches.pm +++ b/testbot/lib/WineTestBot/Patches.pm @@ -241,7 +241,7 @@ sub Submit($$$) my $Disposition = "Submitted job "; my $First = 1; - foreach my $Module (keys %Modules) + foreach my $Module (sort keys %Modules) { my $Jobs = CreateJobs(); @@ -287,7 +287,7 @@ sub Submit($$$) return $ErrMessage; } - foreach my $Unit (keys %{$Modules{$Module}}) + foreach my $Unit (sort keys %{$Modules{$Module}}) { # Add 32 and 64-bit tasks foreach my $Bits ("32", "64")

1 0

Francois Gouget : testbot/build: Better detect when a native rebuild is needed.
by Alexandre Julliard 24 May '18

24 May '18

Module: tools Branch: master Commit: 6dc36c17a79255663041f33182821726bf95c408 URL: https://source.winehq.org/git/tools.git/?a=commit;h=6dc36c17a79255663041f33… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 24 17:28:39 2018 +0200 testbot/build: Better detect when a native rebuild is needed. The builds need more than just winebuild and wrc. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/build/Build.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/bin/build/Build.pl b/testbot/bin/build/Build.pl index 19f220b..ce27baa 100755 --- a/testbot/bin/build/Build.pl +++ b/testbot/bin/build/Build.pl @@ -122,7 +122,7 @@ sub ApplyPatch($$$) { $NeedBuildNative = $NeedMakeMakefiles = $NeedConfigure = 1; } - elsif ($Line =~ m=^diff.*tools/(?:winebuild|wrc)=) + elsif ($Line =~ m=^diff.*tools/(?:makedep\.c|make_xftmpl\.c|sfnt2fon|winebuild|winegcc|widl|wmc|wrc)=) { $NeedBuildNative = 1; }

1 0

Nikolay Sivov : dwrite/tests: Remove a test failing after recent update.
by Alexandre Julliard 23 May '18

23 May '18

Module: wine Branch: master Commit: 3493792da30bd5ce3531bc5168199c8f4efd7605 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3493792da30bd5ce3531bc51… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed May 23 08:24:37 2018 +0300 dwrite/tests: Remove a test failing after recent update. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/tests/font.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c index f23bfcc..6c72319 100644 --- a/dlls/dwrite/tests/font.c +++ b/dlls/dwrite/tests/font.c @@ -3233,12 +3233,7 @@ static void test_shared_isolated(void) ok(shared == shared2, "got %p, and %p\n", shared, shared2); IDWriteFactory_Release(shared2); - hr = DWriteCreateFactory(DWRITE_FACTORY_TYPE_SHARED, &IID_IUnknown, (IUnknown**)&shared2); - ok(hr == S_OK, "got 0x%08x\n", hr); - ok(shared == shared2, "got %p, and %p\n", shared, shared2); - IDWriteFactory_Release(shared); - IDWriteFactory_Release(shared2); /* we got 2 references, released 2 - still same pointer is returned */ hr = DWriteCreateFactory(DWRITE_FACTORY_TYPE_SHARED, &IID_IDWriteFactory, (IUnknown**)&shared2);

1 0

Nikolay Sivov : dwrite/tests: Skip some tests on variable fonts.
by Alexandre Julliard 23 May '18

23 May '18

Module: wine Branch: master Commit: abe71945ef04578daf356b8f2ad904d9fe6c7ba8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=abe71945ef04578daf356b8f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed May 23 08:24:38 2018 +0300 dwrite/tests: Skip some tests on variable fonts. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/tests/font.c | 34 ++++++++++++++++++++++++++++++++++ include/dwrite_3.idl | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+) diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c index 6c72319..44a81a1 100644 --- a/dlls/dwrite/tests/font.c +++ b/dlls/dwrite/tests/font.c @@ -2544,6 +2544,19 @@ static void get_logfont_from_font(IDWriteFont *font, LOGFONTW *logfont) IDWriteFontFace_Release(fontface); } +static BOOL has_face_variations(IDWriteFontFace *fontface) +{ + IDWriteFontFace5 *fontface5; + BOOL ret = FALSE; + + if (SUCCEEDED(IDWriteFontFace_QueryInterface(fontface, &IID_IDWriteFontFace5, (void **)&fontface5))) { + ret = IDWriteFontFace5_HasVariations(fontface5); + IDWriteFontFace5_Release(fontface5); + } + + return ret; +} + static void test_ConvertFontFaceToLOGFONT(void) { IDWriteFontCollection *collection; @@ -2614,6 +2627,13 @@ if (0) /* crashes on native */ hr = IDWriteFont_CreateFontFace(font, &fontface); ok(hr == S_OK, "got 0x%08x\n", hr); + if (has_face_variations(fontface)) { + skip("%s: test does not support variable fonts.\n", wine_dbgstr_w(nameW)); + IDWriteFontFace_Release(fontface); + IDWriteFont_Release(font); + continue; + } + memset(&logfont, 0xcc, sizeof(logfont)); hr = IDWriteGdiInterop_ConvertFontFaceToLOGFONT(interop, fontface, &logfont); ok(hr == S_OK, "got 0x%08x\n", hr); @@ -4014,6 +4034,8 @@ if (0) { /* crashes on native */ for (j = 0; j < font_count; j++) { static const WCHAR spaceW[] = {' ', 0}; + IDWriteFontFace *fontface; + BOOL has_variations; hr = IDWriteFontFamily_GetFont(family, j, &font); ok(hr == S_OK, "got 0x%08x\n", hr); @@ -4028,6 +4050,18 @@ if (0) { /* crashes on native */ lstrcatW(nameW, spaceW); lstrcatW(nameW, facenameW); + hr = IDWriteFont_CreateFontFace(font, &fontface); + ok(hr == S_OK, "got 0x%08x\n", hr); + + has_variations = has_face_variations(fontface); + IDWriteFontFace_Release(fontface); + + if (has_variations) { + skip("%s: test does not support variable fonts.\n", wine_dbgstr_w(nameW)); + IDWriteFont_Release(font); + continue; + } + system = FALSE; memset(&logfont, 0xcc, sizeof(logfont)); hr = IDWriteGdiInterop_ConvertFontToLOGFONT(interop, font, &logfont, &system); diff --git a/include/dwrite_3.idl b/include/dwrite_3.idl index 6b4931c..af4ffc8 100644 --- a/include/dwrite_3.idl +++ b/include/dwrite_3.idl @@ -22,6 +22,7 @@ interface IDWriteFontFaceReference; interface IDWriteFontFace3; interface IDWriteFontSet; interface IDWriteFontDownloadQueue; +interface IDWriteFontResource; cpp_quote("#ifndef _WINGDI_") /* already defined in wingdi.h but needed for WIDL */ @@ -457,6 +458,37 @@ interface IDWriteFontFace4 : IDWriteFontFace3 void ReleaseGlyphImageData(void *context); } +typedef enum DWRITE_FONT_AXIS_TAG +{ + DWRITE_FONT_AXIS_TAG_WEIGHT = 0x74686777, /* 'wght' */ + DWRITE_FONT_AXIS_TAG_WIDTH = 0x68746477, /* 'wdth' */ + DWRITE_FONT_AXIS_TAG_SLANT = 0x746e6c73, /* 'slnt' */ + DWRITE_FONT_AXIS_TAG_OPTICAL_SIZE = 0x7a73706f, /* 'opsz' */ + DWRITE_FONT_AXIS_TAG_ITALIC = 0x6c617469, /* 'ital' */ +} DWRITE_FONT_AXIS_TAG; + +typedef struct DWRITE_FONT_AXIS_VALUE +{ + DWRITE_FONT_AXIS_TAG axisTag; + FLOAT value; +} DWRITE_FONT_AXIS_VALUE; + +[ + local, + object, + uuid(98eff3a5-b667-479a-b145-e2fa5b9fdc29) +] +interface IDWriteFontFace5 : IDWriteFontFace4 +{ + UINT32 GetFontAxisValueCount(); + HRESULT GetFontAxisValues( + DWRITE_FONT_AXIS_VALUE *values, + UINT32 value_count); + BOOL HasVariations(); + HRESULT GetFontResource(IDWriteFontResource **resource); + BOOL Equals(IDWriteFontFace *fontface); +} + typedef struct DWRITE_COLOR_GLYPH_RUN1 { DWRITE_GLYPH_RUN glyphRun;

1 0

Michael Stefaniuc : notepad: Use the available ARRAY_SIZE() macro.
by Alexandre Julliard 23 May '18

23 May '18

Module: wine Branch: master Commit: d98be23eaba1cd49a2d0733581266b233f6e52d4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d98be23eaba1cd49a2d07335… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Wed May 23 00:41:53 2018 +0200 notepad: Use the available ARRAY_SIZE() macro. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/notepad/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/notepad/main.c b/programs/notepad/main.c index 6f567a9..da39eec 100644 --- a/programs/notepad/main.c +++ b/programs/notepad/main.c @@ -76,7 +76,7 @@ VOID SetFileNameAndEncoding(LPCWSTR szFileName, ENCODING enc) { lstrcpyW(Globals.szFileName, szFileName); Globals.szFileTitle[0] = 0; - GetFileTitleW(szFileName, Globals.szFileTitle, sizeof(Globals.szFileTitle) / sizeof(WCHAR)); + GetFileTitleW(szFileName, Globals.szFileTitle, ARRAY_SIZE(Globals.szFileTitle)); Globals.encFile = enc; }

1 0

Gijs Vermeulen : include: Add IO_REPARSE* definitions.
by Alexandre Julliard 23 May '18

23 May '18

Module: wine Branch: master Commit: f32862b0995255bb1801740914e0137072266f05 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f32862b0995255bb18017409… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Tue May 22 23:25:25 2018 +0200 include: Add IO_REPARSE* definitions. Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/winnt.h | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/include/winnt.h b/include/winnt.h index ba10be7..54bf11d 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -2424,6 +2424,58 @@ extern struct _TEB * WINAPI NtCurrentTeb(void); #define TLS_MINIMUM_AVAILABLE 64 +#define MAXIMUM_REPARSE_DATA_BUFFER_SIZE (16 * 1024) + +#define IO_REPARSE_TAG_RESERVED_ZERO 0 +#define IO_REPARSE_TAG_RESERVED_ONE 1 +#define IO_REPARSE_TAG_RESERVED_TWO 2 + +#define IO_REPARSE_TAG_RESERVED_RANGE IO_REPARSE_TAG_RESERVED_TWO + +#define IO_REPARSE_TAG_MOUNT_POINT __MSABI_LONG(0xA0000003) +#define IO_REPARSE_TAG_HSM __MSABI_LONG(0xC0000004) +#define IO_REPARSE_TAG_DRIVE_EXTENDER __MSABI_LONG(0x80000005) +#define IO_REPARSE_TAG_HSM2 __MSABI_LONG(0x80000006) +#define IO_REPARSE_TAG_SIS __MSABI_LONG(0x80000007) +#define IO_REPARSE_TAG_WIM __MSABI_LONG(0x80000008) +#define IO_REPARSE_TAG_CSV __MSABI_LONG(0x80000009) +#define IO_REPARSE_TAG_DFS __MSABI_LONG(0x8000000A) +#define IO_REPARSE_TAG_FILTER_MANAGER __MSABI_LONG(0x8000000B) +#define IO_REPARSE_TAG_SYMLINK __MSABI_LONG(0xA000000C) +#define IO_REPARSE_TAG_IIS_CACHE __MSABI_LONG(0xA0000010) +#define IO_REPARSE_TAG_DFSR __MSABI_LONG(0x80000012) +#define IO_REPARSE_TAG_DEDUP __MSABI_LONG(0x80000013) +#define IO_REPARSE_TAG_NFS __MSABI_LONG(0x80000014) +#define IO_REPARSE_TAG_FILE_PLACEHOLDER __MSABI_LONG(0x80000015) +#define IO_REPARSE_TAG_WOF __MSABI_LONG(0x80000017) +#define IO_REPARSE_TAG_WCI __MSABI_LONG(0x80000018) +#define IO_REPARSE_TAG_WCI_1 __MSABI_LONG(0x90001018) +#define IO_REPARSE_TAG_GLOBAL_REPARSE __MSABI_LONG(0xA0000019) +#define IO_REPARSE_TAG_CLOUD __MSABI_LONG(0x9000001A) +#define IO_REPARSE_TAG_CLOUD_1 __MSABI_LONG(0x9000101A) +#define IO_REPARSE_TAG_CLOUD_2 __MSABI_LONG(0x9000201A) +#define IO_REPARSE_TAG_CLOUD_3 __MSABI_LONG(0x9000301A) +#define IO_REPARSE_TAG_CLOUD_4 __MSABI_LONG(0x9000401A) +#define IO_REPARSE_TAG_CLOUD_5 __MSABI_LONG(0x9000501A) +#define IO_REPARSE_TAG_CLOUD_6 __MSABI_LONG(0x9000601A) +#define IO_REPARSE_TAG_CLOUD_7 __MSABI_LONG(0x9000701A) +#define IO_REPARSE_TAG_CLOUD_8 __MSABI_LONG(0x9000801A) +#define IO_REPARSE_TAG_CLOUD_9 __MSABI_LONG(0x9000901A) +#define IO_REPARSE_TAG_CLOUD_A __MSABI_LONG(0x9000A01A) +#define IO_REPARSE_TAG_CLOUD_B __MSABI_LONG(0x9000B01A) +#define IO_REPARSE_TAG_CLOUD_C __MSABI_LONG(0x9000C01A) +#define IO_REPARSE_TAG_CLOUD_D __MSABI_LONG(0x9000D01A) +#define IO_REPARSE_TAG_CLOUD_E __MSABI_LONG(0x9000E01A) +#define IO_REPARSE_TAG_CLOUD_F __MSABI_LONG(0x9000F01A) +#define IO_REPARSE_TAG_CLOUD_MASK __MSABI_LONG(0x0000F000) +#define IO_REPARSE_TAG_APPEXECLINK __MSABI_LONG(0x8000001B) +#define IO_REPARSE_TAG_GVFS __MSABI_LONG(0x9000001C) +#define IO_REPARSE_TAG_STORAGE_SYNC __MSABI_LONG(0x8000001E) +#define IO_REPARSE_TAG_WCI_TOMBSTONE __MSABI_LONG(0xA000001F) +#define IO_REPARSE_TAG_UNHANDLED __MSABI_LONG(0x80000020) +#define IO_REPARSE_TAG_ONEDRIVE __MSABI_LONG(0x80000021) +#define IO_REPARSE_TAG_GVFS_TOMBSTONE __MSABI_LONG(0xA0000022) + /* * File formats definitions */

1 0

Louis Lenders : include: Add IWMCodecInfo interfaces.
by Alexandre Julliard 23 May '18

23 May '18

Module: wine Branch: master Commit: 15284a972c036e008a46807cd5eb14a28f380029 URL: https://source.winehq.org/git/wine.git/?a=commit;h=15284a972c036e008a46807c… Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Tue May 22 16:01:30 2018 +0200 include: Add IWMCodecInfo interfaces. Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/wmsdkidl.idl | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/include/wmsdkidl.idl b/include/wmsdkidl.idl index 60d8b2c..5bc8546 100644 --- a/include/wmsdkidl.idl +++ b/include/wmsdkidl.idl @@ -511,6 +511,98 @@ cpp_quote("HRESULT WINAPI WMCreateProfileManager(IWMProfileManager**);") [ object, + uuid(a970f41e-34de-4a98-b3ba-e4b3ca7528f0), + pointer_default(unique), + local +] +interface IWMCodecInfo : IUnknown +{ + HRESULT GetCodecInfoCount( + [in] REFGUID guid, + [out] DWORD *count); + + HRESULT GetCodecFormatCount( + [in] REFGUID guid, + [in] DWORD codecindex, + [out] DWORD *formatcount); + + HRESULT GetCodecFormat( + [in] REFGUID guid, + [in] DWORD codecindex, + [in] DWORD formatindex, + [out] IWMStreamConfig **streamconfig); +} + +[ + object, + uuid(aa65e273-b686-4056-91ec-dd768d4df710), + pointer_default(unique), + local +] +interface IWMCodecInfo2 : IWMCodecInfo +{ + HRESULT GetCodecName( + [in] REFGUID guid, + [in] DWORD codecindex, + [out, size_is(*namesize)] WCHAR *name, + [in, out] DWORD *namesize); + + HRESULT GetCodecFormatDesc( + [in] REFGUID guid, + [in] DWORD codecindex, + [in] DWORD formatindex, + [out] IWMStreamConfig **streamconfig, + [out, size_is(*descrsize)] WCHAR *description, + [in, out] DWORD *descrsize); +} + +[ + object, + uuid(7e51f487-4d93-4f98-8ab4-27d0565adc51), + pointer_default(unique), + local +] +interface IWMCodecInfo3 : IWMCodecInfo2 +{ + HRESULT GetCodecFormatProp( + [in] REFGUID guid, + [in] DWORD codecindex, + [in] DWORD formatindex, + [in] const WCHAR *name, + [out] WMT_ATTR_DATATYPE *type, + [out, size_is(*size)] BYTE *value, + [in, out] DWORD *size); + + HRESULT GetCodecProp( + [in] REFGUID guid, + [in] DWORD codecindex, + [in] const WCHAR *name, + [out] WMT_ATTR_DATATYPE *type, + [out, size_is(*size)] BYTE *value, + [in, out] DWORD *size); + + HRESULT SetCodecEnumerationSetting( + [in] REFGUID guid, + [in] DWORD codecindex, + [in] const WCHAR *name, + [in] WMT_ATTR_DATATYPE type, + [in, size_is(size)] const BYTE *value, + [in] DWORD size); + + HRESULT GetCodecEnumerationSetting( + [in] REFGUID guid, + [in] DWORD codecindex, + [in] const WCHAR *name, + [out] WMT_ATTR_DATATYPE *type, + [out, size_is(*size)] BYTE *value, + [in, out] DWORD *size); +} + +cpp_quote("static const WCHAR g_wszNumPasses[] = {'_','P','A','S','S','E','S','U','S','E','D',0};") +cpp_quote("static const WCHAR g_wszVBREnabled[] = {'_','V','B','R','E','N','A','B','L','E','D',0};") + +[ + object, uuid(96406bce-2b2b-11d3-b36b-00c04f6108ff), pointer_default(unique), local

1 0

Louis Lenders : wmvcore: Add a fixme in WMProfileManager_QueryInterface if interface not found.
by Alexandre Julliard 23 May '18

23 May '18

Module: wine Branch: master Commit: 737bbbecd7f70f545849f3de247631fe7ba2a19c URL: https://source.winehq.org/git/wine.git/?a=commit;h=737bbbecd7f70f545849f3de… Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Tue May 22 15:44:08 2018 +0200 wmvcore: Add a fixme in WMProfileManager_QueryInterface if interface not found. Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmvcore/wmvcore_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wmvcore/wmvcore_main.c b/dlls/wmvcore/wmvcore_main.c index 1b45288..690885e 100644 --- a/dlls/wmvcore/wmvcore_main.c +++ b/dlls/wmvcore/wmvcore_main.c @@ -2133,6 +2133,7 @@ static HRESULT WINAPI WMProfileManager_QueryInterface(IWMProfileManager *iface, TRACE("(%p)->(IID_IWMProfileManager %p)\n", This, ppv); *ppv = &This->IWMProfileManager_iface; }else { + FIXME("Unsupported iface %s\n", debugstr_guid(riid)); *ppv = NULL; return E_NOINTERFACE; }

1 0