August 2018 - Wine-commits - list.winehq.org

Alex Henrie : shell32: Add remaining help icons.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: ce40aa4edfee97fc770c1226ce50f2eacd251236 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ce40aa4edfee97fc770c1226… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:20 2018 -0600 shell32: Add remaining help icons. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32.rc | 9 +++++++++ dlls/shell32/shresdef.h | 4 ++++ 2 files changed, 13 insertions(+) diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index 5447aac..87330c3 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -915,6 +915,9 @@ IDI_SHELL_DELETE_FILE ICON resources/delete.ico /* @makedep: resources/delete.ico */ IDI_SHELL_ERASE_DISC ICON resources/delete.ico +/* @makedep: resources/help.ico */ +IDI_SHELL_HELP2 ICON resources/help.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/folder.ico */ IDI_SHELL_TO_FOLDER ICON resources/folder.ico @@ -944,6 +947,9 @@ IDI_SHELL_WEB_CALENDAR ICON resources/internet.ico /* @makedep: resources/users.ico */ IDI_SHELL_USERS_XP2 ICON resources/users.ico +/* @makedep: resources/help.ico */ +IDI_SHELL_HELP_FILE ICON resources/help.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/optical_drive.ico */ IDI_SHELL_DVD_DRIVE ICON resources/optical_drive.ico @@ -1006,6 +1012,9 @@ IDI_SHELL_BURN_DISC2 ICON resources/optical_disc.ico /* @makedep: resources/favorites.ico */ IDI_SHELL_FAVORITES_SMALL ICON resources/favorites.ico +/* @makedep: resources/help.ico */ +IDI_SHELL_HELP_SMALL ICON resources/help.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/folder.ico */ IDI_SHELL_APP_FOLDER_SMALL ICON resources/folder.ico diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 78c1ce1..e688725 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -324,6 +324,7 @@ #define IDI_SHELL_WRITE_DISC 260 #define IDI_SHELL_DELETE_FILE 261 #define IDI_SHELL_ERASE_DISC 262 +#define IDI_SHELL_HELP2 263 #define IDI_SHELL_TO_FOLDER 264 #define IDI_SHELL_BURN_DISC 266 #define IDI_SHELL_SHARED_FOLDER 267 @@ -332,6 +333,8 @@ #define IDI_SHELL_INTERNET 273 #define IDI_SHELL_WEB_CALENDAR 276 #define IDI_SHELL_USERS_XP2 279 +/* 285 - 288 not used on Windows */ +#define IDI_SHELL_HELP_FILE 289 #define IDI_SHELL_DVD_DRIVE 291 #define IDI_SHELL_HYBRID_CD 292 #define IDI_SHELL_UNKNOWN_DISC 293 @@ -348,6 +351,7 @@ #define IDI_SHELL_NEW_FOLDER 319 #define IDI_SHELL_BURN_DISC2 320 #define IDI_SHELL_FAVORITES_SMALL 322 +#define IDI_SHELL_HELP_SMALL 324 #define IDI_SHELL_APP_FOLDER_SMALL 326 #define IDI_SHELL_RESTRICTED2 338 /* 339 - 511 not used on Windows */

1 0

Alex Henrie : shell32: Add XP install icon.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: 46dcc1a3dfaf3170030874cd09188851605d5407 URL: https://source.winehq.org/git/wine.git/?a=commit;h=46dcc1a3dfaf3170030874cd… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:21 2018 -0600 shell32: Add XP install icon. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32.rc | 3 +++ dlls/shell32/shresdef.h | 1 + 2 files changed, 4 insertions(+) diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index 87330c3..89e9cca 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -933,6 +933,9 @@ IDI_SHELL_SHARED_FOLDER ICON resources/folder.ico /* @makedep: resources/users.ico */ IDI_SHELL_USERS_XP ICON resources/users.ico +/* @makedep: resources/update.ico */ +IDI_SHELL_INSTALL_XP ICON resources/update.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/printer.ico */ IDI_SHELL_MULTIFUNCTION_PRINTER ICON resources/printer.ico diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index e688725..7816644 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -329,6 +329,7 @@ #define IDI_SHELL_BURN_DISC 266 #define IDI_SHELL_SHARED_FOLDER 267 #define IDI_SHELL_USERS_XP 269 +#define IDI_SHELL_INSTALL_XP 271 #define IDI_SHELL_MULTIFUNCTION_PRINTER 272 #define IDI_SHELL_INTERNET 273 #define IDI_SHELL_WEB_CALENDAR 276

1 0

Alex Henrie : shell32: Add remaining search icons.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: d0d1c6c2fdb92c7eb80be4cc5870949e34813459 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d0d1c6c2fdb92c7eb80be4cc… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:22 2018 -0600 shell32: Add remaining search icons. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32.rc | 11 +++++++++++ dlls/shell32/shresdef.h | 5 +++++ 2 files changed, 16 insertions(+) diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index 89e9cca..7dcdc2d 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -950,6 +950,10 @@ IDI_SHELL_WEB_CALENDAR ICON resources/internet.ico /* @makedep: resources/users.ico */ IDI_SHELL_USERS_XP2 ICON resources/users.ico +/* FIXME: Following resource is not yet added */ +/* @makedep: resources/search.ico */ +IDI_SHELL_SEARCH_WINDOW ICON resources/search.ico + /* @makedep: resources/help.ico */ IDI_SHELL_HELP_FILE ICON resources/help.ico @@ -1015,6 +1019,9 @@ IDI_SHELL_BURN_DISC2 ICON resources/optical_disc.ico /* @makedep: resources/favorites.ico */ IDI_SHELL_FAVORITES_SMALL ICON resources/favorites.ico +/* @makedep: resources/search.ico */ +IDI_SHELL_SEARCH_SMALL ICON resources/search.ico + /* @makedep: resources/help.ico */ IDI_SHELL_HELP_SMALL ICON resources/help.ico @@ -1022,6 +1029,10 @@ IDI_SHELL_HELP_SMALL ICON resources/help.ico /* @makedep: resources/folder.ico */ IDI_SHELL_APP_FOLDER_SMALL ICON resources/folder.ico +/* FIXME: Following resource is not yet added */ +/* @makedep: resources/search.ico */ +IDI_SHELL_SEARCH_DIRECTORY ICON resources/search.ico + /* @makedep: resources/restricted.ico */ IDI_SHELL_RESTRICTED2 ICON resources/restricted.ico diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 7816644..5990750 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -334,6 +334,8 @@ #define IDI_SHELL_INTERNET 273 #define IDI_SHELL_WEB_CALENDAR 276 #define IDI_SHELL_USERS_XP2 279 +/* 280 not used on Windows */ +#define IDI_SHELL_SEARCH_WINDOW 281 /* 285 - 288 not used on Windows */ #define IDI_SHELL_HELP_FILE 289 #define IDI_SHELL_DVD_DRIVE 291 @@ -352,8 +354,11 @@ #define IDI_SHELL_NEW_FOLDER 319 #define IDI_SHELL_BURN_DISC2 320 #define IDI_SHELL_FAVORITES_SMALL 322 +#define IDI_SHELL_SEARCH_SMALL 323 #define IDI_SHELL_HELP_SMALL 324 #define IDI_SHELL_APP_FOLDER_SMALL 326 +/* 332 - 336 not used on Windows */ +#define IDI_SHELL_SEARCH_DIRECTORY 337 #define IDI_SHELL_RESTRICTED2 338 /* 339 - 511 not used on Windows */ #define IDI_SHELL_WEB_BROWSER 512

1 0

Alex Henrie : shell32: Add Jaz drive icon.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: 17a0c2afa661395871f814eb3f0885b42feb866b URL: https://source.winehq.org/git/wine.git/?a=commit;h=17a0c2afa661395871f814eb… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:23 2018 -0600 shell32: Add Jaz drive icon. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32.rc | 4 ++++ dlls/shell32/shresdef.h | 1 + 2 files changed, 5 insertions(+) diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index 7dcdc2d..5a48421 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -1002,6 +1002,10 @@ IDI_SHELL_INTERNET_PRINTER ICON resources/printer.ico /* FIXME: Following resource is not yet added */ /* @makedep: resources/disk_drive.ico */ +IDI_SHELL_JAZ_DRIVE ICON resources/disk_drive.ico + +/* FIXME: Following resource is not yet added */ +/* @makedep: resources/disk_drive.ico */ IDI_SHELL_ZIP_DRIVE2 ICON resources/disk_drive.ico /* FIXME: Following resource is not yet added */ diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 5990750..421261a 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -349,6 +349,7 @@ #define IDI_SHELL_OPTICAL_DISC 302 #define IDI_SHELL_DVD_ROM 304 #define IDI_SHELL_INTERNET_PRINTER 311 +#define IDI_SHELL_JAZ_DRIVE 312 #define IDI_SHELL_ZIP_DRIVE2 313 #define IDI_SHELL_DVD_RW 318 #define IDI_SHELL_NEW_FOLDER 319

1 0

Alex Henrie : shell32: Rename icon 137 from "options" to "control panel XP ".
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: e26bf9c3ea2e3ed2728a008722d54f7a8f89350b URL: https://source.winehq.org/git/wine.git/?a=commit;h=e26bf9c3ea2e3ed2728a0087… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:24 2018 -0600 shell32: Rename icon 137 from "options" to "control panel XP". Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shresdef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 421261a..6e910dc 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -228,7 +228,7 @@ #define IDI_SHELL_FILE_SEARCH 134 #define IDI_SHELL_SYSTEM_SEARCH 135 /* 136 not used on Windows */ -#define IDI_SHELL_OPTIONS 137 +#define IDI_SHELL_CONTROL_PANEL_XP 137 #define IDI_SHELL_PRINTERS_FOLDER_XP 138 #define IDI_SHELL_ADD_PRINTER 139 #define IDI_SHELL_REMOTE_PRINTER 140

1 0

Alex Henrie : shell32: Add remaining control panel icons.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: 1a924932da5655ab1270beaa0003f8b5bcc4dba1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1a924932da5655ab1270beaa… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:25 2018 -0600 shell32: Add remaining control panel icons. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32.rc | 6 ++++++ dlls/shell32/shresdef.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index 5a48421..0180e76 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -1020,6 +1020,9 @@ IDI_SHELL_NEW_FOLDER ICON resources/folder.ico /* @makedep: resources/optical_disc.ico */ IDI_SHELL_BURN_DISC2 ICON resources/optical_disc.ico +/* @makedep: resources/control.ico */ +IDI_SHELL_CONTROL_PANEL_XP2 ICON resources/control.ico + /* @makedep: resources/favorites.ico */ IDI_SHELL_FAVORITES_SMALL ICON resources/favorites.ico @@ -1033,6 +1036,9 @@ IDI_SHELL_HELP_SMALL ICON resources/help.ico /* @makedep: resources/folder.ico */ IDI_SHELL_APP_FOLDER_SMALL ICON resources/folder.ico +/* @makedep: resources/control.ico */ +IDI_SHELL_CONTROL_PANEL_SMALL ICON resources/control.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/search.ico */ IDI_SHELL_SEARCH_DIRECTORY ICON resources/search.ico diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 6e910dc..4858c8e2 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -354,10 +354,12 @@ #define IDI_SHELL_DVD_RW 318 #define IDI_SHELL_NEW_FOLDER 319 #define IDI_SHELL_BURN_DISC2 320 +#define IDI_SHELL_CONTROL_PANEL_XP2 321 #define IDI_SHELL_FAVORITES_SMALL 322 #define IDI_SHELL_SEARCH_SMALL 323 #define IDI_SHELL_HELP_SMALL 324 #define IDI_SHELL_APP_FOLDER_SMALL 326 +#define IDI_SHELL_CONTROL_PANEL_SMALL 330 /* 332 - 336 not used on Windows */ #define IDI_SHELL_SEARCH_DIRECTORY 337 #define IDI_SHELL_RESTRICTED2 338

1 0

Alex Henrie : shell32: Add remaining small icons.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: 4c1a5099f094720a75b6327a6e8488002e2fdbb0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4c1a5099f094720a75b6327a… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:41:26 2018 -0600 shell32: Add remaining small icons. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32.rc | 15 +++++++++++++++ dlls/shell32/shresdef.h | 5 +++++ 2 files changed, 20 insertions(+) diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index 0180e76..5c11590 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -1032,13 +1032,28 @@ IDI_SHELL_SEARCH_SMALL ICON resources/search.ico /* @makedep: resources/help.ico */ IDI_SHELL_HELP_SMALL ICON resources/help.ico +/* @makedep: resources/log_off.ico */ +IDI_SHELL_LOG_OFF_SMALL ICON resources/log_off.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/folder.ico */ IDI_SHELL_APP_FOLDER_SMALL ICON resources/folder.ico +/* @makedep: resources/recent.ico */ +IDI_SHELL_RECENT_SMALL ICON resources/recent.ico + +/* @makedep: resources/window.ico */ +IDI_SHELL_RUN_SMALL ICON resources/window.ico + +/* @makedep: resources/shut_down.ico */ +IDI_SHELL_POWER_OFF_SMALL ICON resources/shut_down.ico + /* @makedep: resources/control.ico */ IDI_SHELL_CONTROL_PANEL_SMALL ICON resources/control.ico +/* @makedep: resources/eject.ico */ +IDI_SHELL_EJECT_SMALL ICON resources/eject.ico + /* FIXME: Following resource is not yet added */ /* @makedep: resources/search.ico */ IDI_SHELL_SEARCH_DIRECTORY ICON resources/search.ico diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 4858c8e2..16c9293 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -358,8 +358,13 @@ #define IDI_SHELL_FAVORITES_SMALL 322 #define IDI_SHELL_SEARCH_SMALL 323 #define IDI_SHELL_HELP_SMALL 324 +#define IDI_SHELL_LOG_OFF_SMALL 325 #define IDI_SHELL_APP_FOLDER_SMALL 326 +#define IDI_SHELL_RECENT_SMALL 327 +#define IDI_SHELL_RUN_SMALL 328 +#define IDI_SHELL_POWER_OFF_SMALL 329 #define IDI_SHELL_CONTROL_PANEL_SMALL 330 +#define IDI_SHELL_EJECT_SMALL 331 /* 332 - 336 not used on Windows */ #define IDI_SHELL_SEARCH_DIRECTORY 337 #define IDI_SHELL_RESTRICTED2 338

1 0

Alex Henrie : schedsvc/tests: Check the entire entry list to find the new job.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: 63eb45083c01b509400b17a2e4fbbaa296a92143 URL: https://source.winehq.org/git/wine.git/?a=commit;h=63eb45083c01b509400b17a2… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Aug 30 21:49:50 2018 -0600 schedsvc/tests: Check the entire entry list to find the new job. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/schedsvc/tests/atsvcapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/schedsvc/tests/atsvcapi.c b/dlls/schedsvc/tests/atsvcapi.c index 66f237e..d7d48a1 100644 --- a/dlls/schedsvc/tests/atsvcapi.c +++ b/dlls/schedsvc/tests/atsvcapi.c @@ -118,7 +118,7 @@ START_TEST(atsvcapi) container.EntriesRead = 0; container.Buffer = NULL; total = start_index = 0; - ret = NetrJobEnum(server_name, &container, 1, &total, &start_index); + ret = NetrJobEnum(server_name, &container, -1, &total, &start_index); if (ret == ERROR_ACCESS_DENIED) { win_skip("NetrJobEnum: Access denied, skipping the tests\n");

1 0

Lauri Kenttä : po: Update Finnish translation.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: fbd1bd4544ae5fb155805664a7e4ce151cbeaeea URL: https://source.winehq.org/git/wine.git/?a=commit;h=fbd1bd4544ae5fb155805664… Author: Lauri Kenttä <lauri.kentta(a)gmail.com> Date: Fri Aug 31 07:28:02 2018 +0300 po: Update Finnish translation. Signed-off-by: Lauri Kenttä <lauri.kentta(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/fi.po | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/po/fi.po b/po/fi.po index 54a636b..f5a7b9c 100644 --- a/po/fi.po +++ b/po/fi.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2017-07-20 17:38+0200\n" +"PO-Revision-Date: 2018-08-31 07:27+0200\n" "Last-Translator: Lauri Kenttä <lauri.kentta(a)gmail.com>\n" "Language-Team: Finnish\n" "Language: fi\n" @@ -399,16 +399,12 @@ msgid "&Retry" msgstr "&Uudelleen" #: comctl32.rc:62 -#, fuzzy -#| msgid "Hide &Tabs" msgid "Hide details" -msgstr "P&iilota välilehdet" +msgstr "Piilota lisätiedot" #: comctl32.rc:63 -#, fuzzy -#| msgid "Details" msgid "See details" -msgstr "Tiedot" +msgstr "Näytä lisätiedot" #: comctl32.rc:31 cryptui.rc:230 regedit.rc:286 taskmgr.rc:434 winedbg.rc:61 #: winedbg.rc:76 wordpad.rc:180 @@ -3440,18 +3436,16 @@ msgid "Connections" msgstr "Yhteydet" #: inetcpl.rc:125 -#, fuzzy -#| msgid "Wine configuration" msgid "Automatic configuration" -msgstr "Winen asetukset" +msgstr "Automaattiset asetukset" #: inetcpl.rc:126 msgid "Use Web Proxy Auto-Discovery (WPAD)" -msgstr "" +msgstr "Käytä Web Proxy Auto-Discovery (WPAD) -protokollaa" #: inetcpl.rc:127 msgid "Use Proxy Auto-Config (PAC) script" -msgstr "" +msgstr "Käytä Proxy Auto-Config (PAC) -skriptiä" #: inetcpl.rc:128 inetcpl.rc:132 msgid "Address:" @@ -14183,11 +14177,11 @@ msgstr "&Väri:" #: winecfg.rc:304 msgid "MIME types" -msgstr "" +msgstr "MIME-tyypit" #: winecfg.rc:305 msgid "Manage file &associations" -msgstr "" +msgstr "&Muokkaa tiedostosidoksia" #: winecfg.rc:308 msgid "Folders"

1 0

Daniel Lehman : msxml3/tests: Add test for treating namespaces as attributes.
by Alexandre Julliard 31 Aug '18

31 Aug '18

Module: wine Branch: master Commit: 9b950387e52f57451060c37c3f16257deb9ae9cf URL: https://source.winehq.org/git/wine.git/?a=commit;h=9b950387e52f57451060c37c… Author: Daniel Lehman <dlehman25(a)gmail.com> Date: Fri Aug 31 09:06:14 2018 +0300 msxml3/tests: Add test for treating namespaces as attributes. Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msxml3/tests/domdoc.c | 126 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 35fa42a..b602e03 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -12830,6 +12830,131 @@ todo_wine { IXMLDOMDocument2_Release(doc); } +typedef struct _namespace_as_attribute_t { + const GUID *guid; + const char *clsid; + const char *xmlns_uri; + BOOL todo; +} namespace_as_attribute_t; + +static const namespace_as_attribute_t namespace_as_attribute_test_data[] = { + { &CLSID_DOMDocument, "CLSID_DOMDocument", "", FALSE }, + { &CLSID_DOMDocument2, "CLSID_DOMDocument2", "", FALSE }, + { &CLSID_DOMDocument26, "CLSID_DOMDocument26", "", FALSE }, + { &CLSID_DOMDocument30, "CLSID_DOMDocument30", "", FALSE }, + { &CLSID_DOMDocument40, "CLSID_DOMDocument40", "", FALSE }, + { &CLSID_DOMDocument60, "CLSID_DOMDocument60", "http://www.w3.org/2000/xmlns/", TRUE }, + { 0 } +}; + +void test_namespaces_as_attributes(void) +{ + const namespace_as_attribute_t *entry = namespace_as_attribute_test_data; + static const char ns_as_attr_doc[] = { + "<?xml version=\"1.0\"?>" + "<a ns:b=\"b attr\" d=\"d attr\" xmlns:ns=\"nshref\" />" + }; + static const char *names[] = { "ns:b", "d", "xmlns:ns" }; + static const char *prefixes[] = { "ns", NULL, "xmlns" }; + static const char *basenames[] = { "b", "d", "ns" }; + static const char *uris[] = { "nshref", NULL, "" }; + static const char *texts[] = { "b attr", "d attr", "nshref" }; + IXMLDOMNamedNodeMap *map; + IXMLDOMNode *node, *item; + IXMLDOMDocument *doc; + VARIANT_BOOL b; + LONG len, i; + HRESULT hr; + BSTR str; + + while (entry->guid) + { + if (!is_clsid_supported(entry->guid, &IID_IXMLDOMDocument2)) + { + entry++; + continue; + } + + hr = CoCreateInstance(entry->guid, NULL, CLSCTX_INPROC_SERVER, &IID_IXMLDOMDocument2, (void **)&doc); + ok(SUCCEEDED(hr), "Failed to create document %s, hr %#x.\n", wine_dbgstr_guid(entry->guid), hr); + + hr = IXMLDOMDocument_loadXML(doc, _bstr_(ns_as_attr_doc), &b); + ok(hr == S_OK, "Failed to load xml, hr %#x.\n", hr); + + node = NULL; + hr = IXMLDOMDocument_selectSingleNode(doc, _bstr_("a"), &node); + ok(SUCCEEDED(hr), "Failed to select a node, hr %#x.\n", hr); + + hr = IXMLDOMNode_get_attributes(node, &map); + ok(SUCCEEDED(hr), "Failed to get attributes, hr %#x.\n", hr); + + len = -1; + hr = IXMLDOMNamedNodeMap_get_length(map, &len); + ok(SUCCEEDED(hr), "Failed to get map length, hr %#x.\n", hr); + todo_wine ok(len == 3, "got %d\n", len); + + for (i = 0; i < len; i++) + { + item = NULL; + hr = IXMLDOMNamedNodeMap_get_item(map, i, &item); + ok(SUCCEEDED(hr), "Failed to get item, hr %#x.\n", hr); + + str = NULL; + hr = IXMLDOMNode_get_nodeName(item, &str); + ok(SUCCEEDED(hr), "Failed to get node name, hr %#x.\n", hr); + ok(!lstrcmpW(str, _bstr_(names[i])), "got %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + + str = NULL; + hr = IXMLDOMNode_get_prefix(item, &str); + if (prefixes[i]) + { + ok(hr == S_OK, "Failed to get node name, hr %#x.\n", hr); + ok(!lstrcmpW(str, _bstr_(prefixes[i])), "got %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + } + else + ok(hr == S_FALSE, "Failed to get node name, hr %#x.\n", hr); + + str = NULL; + hr = IXMLDOMNode_get_baseName(item, &str); + ok(SUCCEEDED(hr), "Failed to get base name, hr %#x.\n", hr); + ok(!lstrcmpW(str, _bstr_(basenames[i])), "got %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + + str = NULL; + hr = IXMLDOMNode_get_namespaceURI(item, &str); + if (uris[i]) + { + ok(hr == S_OK, "Failed to get node name, hr %#x.\n", hr); + if (prefixes[i] && !strcmp(prefixes[i], "xmlns")) + todo_wine_if(entry->todo) + ok(!lstrcmpW(str, _bstr_(entry->xmlns_uri)), "got %s\n", wine_dbgstr_w(str)); + else + ok(!lstrcmpW(str, _bstr_(uris[i])), "got %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + } + else + ok(hr == S_FALSE, "Failed to get node name, hr %#x.\n", hr); + + str = NULL; + hr = IXMLDOMNode_get_text(item, &str); + ok(SUCCEEDED(hr), "Failed to get node text, hr %#x.\n", hr); + ok(!lstrcmpW(str, _bstr_(texts[i])), "got %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + + IXMLDOMNode_Release(item); + } + + IXMLDOMNamedNodeMap_Release(map); + IXMLDOMNode_Release(node); + IXMLDOMDocument_Release(doc); + + entry++; + } + free_bstrs(); +} + START_TEST(domdoc) { HRESULT hr; @@ -12914,6 +13039,7 @@ START_TEST(domdoc) test_merging_text(); test_transformNodeToObject(); test_normalize_attribute_values(); + test_namespaces_as_attributes(); test_xsltemplate(); test_xsltext();

1 0