August 2018 - Wine-commits - list.winehq.org

Zebediah Figura : setupapi: Only delete unregistered device interfaces when deleting a device.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: wine Branch: master Commit: 9ccf51e3c12b95d06b5cf8bfffc3b5990977146f URL: https://source.winehq.org/git/wine.git/?a=commit;h=9ccf51e3c12b95d06b5cf8bf… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sun Aug 19 15:23:14 2018 -0500 setupapi: Only delete unregistered device interfaces when deleting a device. Fixes a regression introduced by 86d26dded5560d6d8adb195372f0676d1f7229b0. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/devinst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c index 4d53bd7..71356e8 100644 --- a/dlls/setupapi/devinst.c +++ b/dlls/setupapi/devinst.c @@ -524,7 +524,7 @@ static void SETUPDI_RemoveDevice(struct device *device) struct device_iface, entry) { list_remove(&iface->entry); - if ((path = get_refstr_key_path(iface))) + if (device->phantom && (path = get_refstr_key_path(iface))) { RegDeleteKeyW(HKEY_LOCAL_MACHINE, path); heap_free(path);

1 0

Michael Stefaniuc : dmusic: Add a stub midi out port.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: wine Branch: master Commit: 8c48fba6a207824676364b0e11929fdf4f1047f1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8c48fba6a207824676364b0e… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Mon Aug 20 00:01:34 2018 +0200 dmusic: Add a stub midi out port. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dmusic/port.c | 225 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 223 insertions(+), 2 deletions(-) diff --git a/dlls/dmusic/port.c b/dlls/dmusic/port.c index 7131756..2f8fb92 100644 --- a/dlls/dmusic/port.c +++ b/dlls/dmusic/port.c @@ -21,6 +21,7 @@ #include <assert.h> #include "dmusic_private.h" +#include "wine/heap.h" WINE_DEFAULT_DEBUG_CHANNEL(dmusic); @@ -903,12 +904,232 @@ HRESULT synth_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_param return hr; } +struct midi_port { + IDirectMusicPort IDirectMusicPort_iface; + LONG ref; +}; + +static inline struct midi_port *impl_from_IDirectMusicPort(IDirectMusicPort *iface) +{ + return CONTAINING_RECORD(iface, struct midi_port, IDirectMusicPort_iface); +} + +static HRESULT WINAPI midi_IDirectMusicPort_QueryInterface(IDirectMusicPort *iface, REFIID riid, + void **ret_iface) +{ + TRACE("(%p, %s, %p)\n", iface, debugstr_dmguid(riid), ret_iface); + + if (IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IDirectMusicPort)) + *ret_iface = iface; + else { + WARN("no interface for %s\n", debugstr_dmguid(riid)); + *ret_iface = NULL; + return E_NOINTERFACE; + } + + IDirectMusicPort_AddRef(iface); + + return S_OK; +} + +static ULONG WINAPI midi_IDirectMusicPort_AddRef(IDirectMusicPort *iface) +{ + struct midi_port *This = impl_from_IDirectMusicPort(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref = %u\n", iface, ref); + + return ref; +} + +static ULONG WINAPI midi_IDirectMusicPort_Release(IDirectMusicPort *iface) +{ + struct midi_port *This = impl_from_IDirectMusicPort(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) ref = %u\n", iface, ref); + + if (!ref) + heap_free(This); + + return ref; +} + +static HRESULT WINAPI midi_IDirectMusicPort_PlayBuffer(IDirectMusicPort *iface, + IDirectMusicBuffer *buffer) +{ + FIXME("(%p, %p) stub!\n", iface, buffer); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_SetReadNotificationHandle(IDirectMusicPort *iface, + HANDLE event) +{ + FIXME("(%p, %p) stub!\n", iface, event); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_Read(IDirectMusicPort *iface, + IDirectMusicBuffer *buffer) +{ + FIXME("(%p, %p) stub!\n", iface, buffer); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_DownloadInstrument(IDirectMusicPort *iface, + IDirectMusicInstrument *instrument, IDirectMusicDownloadedInstrument **downloaded, + DMUS_NOTERANGE *ranges, DWORD num_ranges) +{ + FIXME("(%p, %p, %p, %p, %u) stub!\n", iface, instrument, downloaded, ranges, num_ranges); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_UnloadInstrument(IDirectMusicPort *iface, + IDirectMusicDownloadedInstrument *downloaded) +{ + FIXME("(%p, %p) stub!\n", iface, downloaded); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_GetLatencyClock(IDirectMusicPort *iface, + IReferenceClock **clock) +{ + FIXME("(%p, %p) stub!\n", iface, clock); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_GetRunningStats(IDirectMusicPort *iface, + DMUS_SYNTHSTATS *stats) +{ + FIXME("(%p, %p) stub!\n", iface, stats); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_Compact(IDirectMusicPort *iface) +{ + FIXME("(%p) stub!\n", iface); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_GetCaps(IDirectMusicPort *iface, DMUS_PORTCAPS *caps) +{ + FIXME("(%p, %p) stub!\n", iface, caps); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_DeviceIoControl(IDirectMusicPort *iface, + DWORD io_control_code, void *in, DWORD size_in, void *out, DWORD size_out, DWORD *ret_len, + OVERLAPPED *overlapped) +{ + FIXME("(%p, %u, %p, %u, %p, %u, %p, %p) stub!\n", iface, io_control_code, in, size_in, out + , size_out, ret_len, overlapped); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_SetNumChannelGroups(IDirectMusicPort *iface, + DWORD cgroups) +{ + FIXME("(%p, %u) stub!\n", iface, cgroups); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_GetNumChannelGroups(IDirectMusicPort *iface, + DWORD *cgroups) +{ + FIXME("(%p, %p) stub!\n", iface, cgroups); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_Activate(IDirectMusicPort *iface, BOOL active) +{ + FIXME("(%p, %u) stub!\n", iface, active); + + return S_OK; +} + +static HRESULT WINAPI midi_IDirectMusicPort_SetChannelPriority(IDirectMusicPort *iface, + DWORD channel_group, DWORD channel, DWORD priority) +{ + FIXME("(%p, %u, %u, %u) stub!\n", iface, channel_group, channel, priority); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_GetChannelPriority(IDirectMusicPort *iface, + DWORD channel_group, DWORD channel, DWORD *priority) +{ + FIXME("(%p, %u, %u, %p) stub!\n", iface, channel_group, channel, priority); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_SetDirectSound(IDirectMusicPort *iface, + IDirectSound *dsound, IDirectSoundBuffer *dsbuffer) +{ + FIXME("(%p, %p, %p) stub!\n", iface, dsound, dsbuffer); + + return E_NOTIMPL; +} + +static HRESULT WINAPI midi_IDirectMusicPort_GetFormat(IDirectMusicPort *iface, WAVEFORMATEX *format, + DWORD *format_size, DWORD *buffer_size) +{ + FIXME("(%p, %p, %p, %p) stub!\n", iface, format, format_size, buffer_size); + + return E_NOTIMPL; +} + +static const IDirectMusicPortVtbl midi_port_vtbl = { + midi_IDirectMusicPort_QueryInterface, + midi_IDirectMusicPort_AddRef, + midi_IDirectMusicPort_Release, + midi_IDirectMusicPort_PlayBuffer, + midi_IDirectMusicPort_SetReadNotificationHandle, + midi_IDirectMusicPort_Read, + midi_IDirectMusicPort_DownloadInstrument, + midi_IDirectMusicPort_UnloadInstrument, + midi_IDirectMusicPort_GetLatencyClock, + midi_IDirectMusicPort_GetRunningStats, + midi_IDirectMusicPort_Compact, + midi_IDirectMusicPort_GetCaps, + midi_IDirectMusicPort_DeviceIoControl, + midi_IDirectMusicPort_SetNumChannelGroups, + midi_IDirectMusicPort_GetNumChannelGroups, + midi_IDirectMusicPort_Activate, + midi_IDirectMusicPort_SetChannelPriority, + midi_IDirectMusicPort_GetChannelPriority, + midi_IDirectMusicPort_SetDirectSound, + midi_IDirectMusicPort_GetFormat, +}; + HRESULT midi_out_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_params, DMUS_PORTCAPS *port_caps, IDirectMusicPort **port) { - FIXME("(%p, %p, %p): stub\n", port_params, port_caps, port); + struct midi_port *obj; - return E_NOTIMPL; + TRACE("(%p, %p, %p)\n", port_params, port_caps, port); + + if (!(obj = heap_alloc_zero(sizeof(*obj)))) + return E_OUTOFMEMORY; + + obj->IDirectMusicPort_iface.lpVtbl = &midi_port_vtbl; + obj->ref = 1; + + *port = &obj->IDirectMusicPort_iface; + + return S_OK; } HRESULT midi_in_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_params,

1 0

Michael Stefaniuc : dmusic: Implement IDirectMusicPort_GetLatencyClock() for the midi port.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: wine Branch: master Commit: 25dcca4b30fbae830386eac90d57077b8965e6fb URL: https://source.winehq.org/git/wine.git/?a=commit;h=25dcca4b30fbae830386eac9… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Mon Aug 20 00:01:35 2018 +0200 dmusic: Implement IDirectMusicPort_GetLatencyClock() for the midi port. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dmusic/port.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/dlls/dmusic/port.c b/dlls/dmusic/port.c index 2f8fb92..ebc8506 100644 --- a/dlls/dmusic/port.c +++ b/dlls/dmusic/port.c @@ -907,6 +907,7 @@ HRESULT synth_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_param struct midi_port { IDirectMusicPort IDirectMusicPort_iface; LONG ref; + IReferenceClock *clock; }; static inline struct midi_port *impl_from_IDirectMusicPort(IDirectMusicPort *iface) @@ -949,8 +950,11 @@ static ULONG WINAPI midi_IDirectMusicPort_Release(IDirectMusicPort *iface) TRACE("(%p) ref = %u\n", iface, ref); - if (!ref) + if (!ref) { + if (This->clock) + IReferenceClock_Release(This->clock); heap_free(This); + } return ref; } @@ -999,9 +1003,17 @@ static HRESULT WINAPI midi_IDirectMusicPort_UnloadInstrument(IDirectMusicPort *i static HRESULT WINAPI midi_IDirectMusicPort_GetLatencyClock(IDirectMusicPort *iface, IReferenceClock **clock) { - FIXME("(%p, %p) stub!\n", iface, clock); + struct midi_port *This = impl_from_IDirectMusicPort(iface); - return E_NOTIMPL; + TRACE("(%p, %p)\n", iface, clock); + + if (!clock) + return E_POINTER; + + *clock = This->clock; + IReferenceClock_AddRef(*clock); + + return S_OK; } static HRESULT WINAPI midi_IDirectMusicPort_GetRunningStats(IDirectMusicPort *iface, @@ -1118,6 +1130,7 @@ HRESULT midi_out_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_pa DMUS_PORTCAPS *port_caps, IDirectMusicPort **port) { struct midi_port *obj; + HRESULT hr; TRACE("(%p, %p, %p)\n", port_params, port_caps, port); @@ -1127,6 +1140,12 @@ HRESULT midi_out_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_pa obj->IDirectMusicPort_iface.lpVtbl = &midi_port_vtbl; obj->ref = 1; + hr = DMUSIC_CreateReferenceClockImpl(&IID_IReferenceClock, (void **)&obj->clock, NULL); + if (hr != S_OK) { + HeapFree(GetProcessHeap(), 0, obj); + return hr; + } + *port = &obj->IDirectMusicPort_iface; return S_OK;

1 0

Michael Stefaniuc : dmusic: Support midi in ports too.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: wine Branch: master Commit: fcedc2b92076437a38b504a539e93992ccd8da09 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fcedc2b92076437a38b504a5… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Mon Aug 20 00:01:36 2018 +0200 dmusic: Support midi in ports too. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dmusic/port.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/dlls/dmusic/port.c b/dlls/dmusic/port.c index ebc8506..4df8664 100644 --- a/dlls/dmusic/port.c +++ b/dlls/dmusic/port.c @@ -1126,14 +1126,12 @@ static const IDirectMusicPortVtbl midi_port_vtbl = { midi_IDirectMusicPort_GetFormat, }; -HRESULT midi_out_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_params, - DMUS_PORTCAPS *port_caps, IDirectMusicPort **port) +HRESULT midi_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *params, DMUS_PORTCAPS *caps, + IDirectMusicPort **port) { struct midi_port *obj; HRESULT hr; - TRACE("(%p, %p, %p)\n", port_params, port_caps, port); - if (!(obj = heap_alloc_zero(sizeof(*obj)))) return E_OUTOFMEMORY; @@ -1151,10 +1149,18 @@ HRESULT midi_out_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_pa return S_OK; } -HRESULT midi_in_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *port_params, - DMUS_PORTCAPS *port_caps, IDirectMusicPort **port) +HRESULT midi_out_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *params, + DMUS_PORTCAPS *caps, IDirectMusicPort **port) { - FIXME("(%p, %p, %p): stub\n", port_params, port_caps, port); + TRACE("(%p, %p, %p, %p)\n", parent, params, caps, port); - return E_NOTIMPL; + return midi_port_create(parent, params, caps, port); +} + +HRESULT midi_in_port_create(IDirectMusic8Impl *parent, DMUS_PORTPARAMS *params, + DMUS_PORTCAPS *caps, IDirectMusicPort **port) +{ + TRACE("(%p, %p, %p, %p)\n", parent, params, caps, port); + + return midi_port_create(parent, params, caps, port); }

1 0

Józef Kucia : build: Add a line about demos to the configure summary.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: vkd3d Branch: master Commit: b5d2374ff320f13e33c9cd42ad427f40a0feacd6 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=b5d2374ff320f13e33c9cd4… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Aug 17 09:56:56 2018 +0200 build: Add a line about demos to the configure summary. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index d437e1b..ddc6c97 100644 --- a/configure.ac +++ b/configure.ac @@ -96,6 +96,7 @@ VKD3D_CHECK_FUNC([HAVE_SYNC_SUB_AND_FETCH], [__sync_sub_and_fetch], [__sync_sub_ VKD3D_CHECK_PTHREAD_SETNAME_NP +AS_IF([test "x$enable_demos" != "xyes"], [enable_demos=no]) AM_CONDITIONAL([BUILD_DEMOS], [test "x$enable_demos" = "xyes"]) AM_CONDITIONAL([HAVE_WIDL], [test "x$WIDL" != "xno"]) AM_CONDITIONAL([HAVE_CROSSTARGET32], [test "x$CROSSTARGET32" != "xno"]) @@ -113,6 +114,8 @@ AS_ECHO([" Have SPIRV-Tools: ${HAVE_SPIRV_TOOLS} + Building demos: ${enable_demos} + Building crosstests: ${HAVE_CROSSTEST}"]) AS_IF([test "x$CROSSTARGET32" != "xno"], [AS_ECHO([" Using 32-bit cross compiler: $CROSSCC32"])]) AS_IF([test "x$CROSSTARGET64" != "xno"], [AS_ECHO([" Using 64-bit cross compiler: $CROSSCC64"])])

1 0

Józef Kucia : tests: Do not require libxcb and libx11 headers.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: vkd3d Branch: master Commit: 8b6158301146fa3f15a08cfff9c8f2e3be0ae0b3 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=8b6158301146fa3f15a08cf… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Aug 17 09:56:58 2018 +0200 tests: Do not require libxcb and libx11 headers. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tests/vkd3d_api.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/vkd3d_api.c b/tests/vkd3d_api.c index e2d9d01..2c022ba 100644 --- a/tests/vkd3d_api.c +++ b/tests/vkd3d_api.c @@ -19,8 +19,6 @@ #define COBJMACROS #define INITGUID #define WIDL_C_INLINE_WRAPPERS -#define VK_USE_PLATFORM_XCB_KHR -#define VK_USE_PLATFORM_XLIB_KHR #include "vkd3d_test.h" #include <vkd3d.h> @@ -215,8 +213,8 @@ static void test_additional_instance_extensions(void) struct vulkan_extension extensions[] = { {VK_KHR_SURFACE_EXTENSION_NAME}, - {VK_KHR_XCB_SURFACE_EXTENSION_NAME}, - {VK_KHR_XLIB_SURFACE_EXTENSION_NAME}, + {"VK_KHR_xcb_surface"}, + {"VK_KHR_xlib_surface"}, }; const char *enabled_extensions[ARRAY_SIZE(extensions)]; @@ -249,12 +247,12 @@ static void test_additional_instance_extensions(void) if (!extensions[i].is_supported) continue; - if (!strcmp(extensions[i].name, VK_KHR_XCB_SURFACE_EXTENSION_NAME)) + if (!strcmp(extensions[i].name, "VK_KHR_xcb_surface")) { pfn = vkGetInstanceProcAddr(vk_instance, "vkCreateXcbSurfaceKHR"); ok(pfn, "Failed to get proc addr for vkCreateXcbSurfaceKHR.\n"); } - else if (!strcmp(extensions[i].name, VK_KHR_XLIB_SURFACE_EXTENSION_NAME)) + else if (!strcmp(extensions[i].name, "VK_KHR_xlib_surface")) { pfn = vkGetInstanceProcAddr(vk_instance, "vkCreateXlibSurfaceKHR"); ok(pfn, "Failed to get proc addr for vkCreateXlibSurfaceKHR.\n");

1 0

Józef Kucia : vkd3d: Add support for optional instance extensions.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: vkd3d Branch: master Commit: d175afad7812a4aa6b84bb31bb0d732ceb293186 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=d175afad7812a4aa6b84bb3… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Aug 17 09:57:00 2018 +0200 vkd3d: Add support for optional instance extensions. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/vkd3d.h | 11 +++++ libs/vkd3d/device.c | 116 ++++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 109 insertions(+), 18 deletions(-) Diff: https://source.winehq.org/git/vkd3d.git/?a=commitdiff;h=d175afad7812a4aa6b8…

1 0

Józef Kucia : tests: Fix mixed enums.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: vkd3d Branch: master Commit: 82e2e4d1a6dc5df736072a99d6d33b88d44fdcb6 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=82e2e4d1a6dc5df736072a9… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Aug 17 09:57:02 2018 +0200 tests: Fix mixed enums. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tests/d3d12.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index 7b00407..7d28661 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -16064,9 +16064,9 @@ static void test_resolve_query_data_in_different_command_list(void) ID3D12GraphicsCommandList_RSSetViewports(command_list, 1, &context.viewport); ID3D12GraphicsCommandList_RSSetScissorRects(command_list, 1, &context.scissor_rect); - ID3D12GraphicsCommandList_BeginQuery(command_list, query_heap, heap_desc.Type, 0); + ID3D12GraphicsCommandList_BeginQuery(command_list, query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0); ID3D12GraphicsCommandList_DrawInstanced(command_list, 3, 1, 0, 0); - ID3D12GraphicsCommandList_EndQuery(command_list, query_heap, heap_desc.Type, 0); + ID3D12GraphicsCommandList_EndQuery(command_list, query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0); transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_RENDER_TARGET, D3D12_RESOURCE_STATE_COPY_SOURCE); @@ -16076,7 +16076,7 @@ static void test_resolve_query_data_in_different_command_list(void) for (i = 0; i < readback_buffer_capacity / 2; ++i) { ID3D12GraphicsCommandList_ResolveQueryData(command_list, - query_heap, heap_desc.Type, 0, 1, readback_buffer, i * sizeof(UINT64)); + query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0, 1, readback_buffer, i * sizeof(UINT64)); } hr = ID3D12GraphicsCommandList_Close(command_list); ok(SUCCEEDED(hr), "Failed to close command list, hr %#x.\n", hr); @@ -16087,7 +16087,7 @@ static void test_resolve_query_data_in_different_command_list(void) for (; i < readback_buffer_capacity; ++i) { ID3D12GraphicsCommandList_ResolveQueryData(command_list, - query_heap, heap_desc.Type, 0, 1, readback_buffer, i * sizeof(UINT64)); + query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0, 1, readback_buffer, i * sizeof(UINT64)); } get_buffer_readback_with_command_list(readback_buffer, DXGI_FORMAT_UNKNOWN, &rb, queue, command_list); @@ -16142,7 +16142,7 @@ static void test_resolve_query_data_in_reordered_command_list(void) /* Read query results in the second command list. */ ID3D12GraphicsCommandList_ResolveQueryData(command_lists[1], - query_heap, heap_desc.Type, 0, 1, readback_buffer, 0); + query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0, 1, readback_buffer, 0); hr = ID3D12GraphicsCommandList_Close(command_lists[1]); ok(SUCCEEDED(hr), "Failed to close command list, hr %#x.\n", hr); @@ -16153,9 +16153,9 @@ static void test_resolve_query_data_in_reordered_command_list(void) ID3D12GraphicsCommandList_IASetPrimitiveTopology(command_lists[0], D3D_PRIMITIVE_TOPOLOGY_TRIANGLELIST); ID3D12GraphicsCommandList_RSSetViewports(command_lists[0], 1, &context.viewport); ID3D12GraphicsCommandList_RSSetScissorRects(command_lists[0], 1, &context.scissor_rect); - ID3D12GraphicsCommandList_BeginQuery(command_lists[0], query_heap, heap_desc.Type, 0); + ID3D12GraphicsCommandList_BeginQuery(command_lists[0], query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0); ID3D12GraphicsCommandList_DrawInstanced(command_lists[0], 3, 1, 0, 0); - ID3D12GraphicsCommandList_EndQuery(command_lists[0], query_heap, heap_desc.Type, 0); + ID3D12GraphicsCommandList_EndQuery(command_lists[0], query_heap, D3D12_QUERY_TYPE_OCCLUSION, 0); hr = ID3D12GraphicsCommandList_Close(command_lists[0]); ok(SUCCEEDED(hr), "Failed to close command list, hr %#x.\n", hr);

1 0

Józef Kucia : vkd3d-shader: Strip debug info after generating all code.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: vkd3d Branch: master Commit: 99a2daedb1e8dbce2d0aa83bf5e402abbfc68c9f URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=99a2daedb1e8dbce2d0aa83… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Aug 17 09:57:03 2018 +0200 vkd3d-shader: Strip debug info after generating all code. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/spirv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index d62d553..d40350f 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -6364,14 +6364,14 @@ int vkd3d_dxbc_compiler_generate_spirv(struct vkd3d_dxbc_compiler *compiler, { struct vkd3d_spirv_builder *builder = &compiler->spirv_builder; - if (compiler->options & VKD3D_SHADER_STRIP_DEBUG) - vkd3d_spirv_stream_clear(&builder->debug_stream); - vkd3d_spirv_build_op_function_end(builder); if (compiler->output_setup_function_id) vkd3d_dxbc_compiler_emit_output_setup_function(compiler); + if (compiler->options & VKD3D_SHADER_STRIP_DEBUG) + vkd3d_spirv_stream_clear(&builder->debug_stream); + if (!vkd3d_spirv_compile_module(builder, spirv)) return VKD3D_ERROR;

1 0

Francois Gouget : testbot: Avoid map when when items must be handled in order.
by Alexandre Julliard 20 Aug '18

20 Aug '18

Module: tools Branch: master Commit: b278c2a057677b8d280cf823d74622b8880658ba URL: https://source.winehq.org/git/tools.git/?a=commit;h=b278c2a057677b8d280cf82… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 20 09:05:22 2018 +0200 testbot: Avoid map when when items must be handled in order. Instead use 'statement($_) for (@List)' which is just as readable. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/PendingPatchSets.pm | 2 +- testbot/web/Munin.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/lib/WineTestBot/PendingPatchSets.pm b/testbot/lib/WineTestBot/PendingPatchSets.pm index fc22a86..4ef7a66 100644 --- a/testbot/lib/WineTestBot/PendingPatchSets.pm +++ b/testbot/lib/WineTestBot/PendingPatchSets.pm @@ -113,7 +113,7 @@ sub SubmitSubset($$$) if (defined $Part and open(my $PartFile, "<" , "$DataDir/patches/" . $Part->Patch->Id)) { - map { print $CombinedFile $_; } <$PartFile>; + print $CombinedFile $_ for (<$PartFile>); close($PartFile); } } diff --git a/testbot/web/Munin.pl b/testbot/web/Munin.pl index 91155b7..840d912 100755 --- a/testbot/web/Munin.pl +++ b/testbot/web/Munin.pl @@ -474,7 +474,7 @@ sub GetOutput($) # Then print the corresponding data print "===== data =====\n"; - map { print $_ } @Data; + print $_ for (@Data); }

1 0