September 2018 - Wine-commits

Zebediah Figura : quartz/filtergraph: Improve HRESULT propagation from IFilterGraph2_Connect().
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 58148a31fcc4962eee1017242e03fc8680dccf67 URL: https://source.winehq.org/git/wine.git/?a=commit;h=58148a31fcc4962eee101724… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Sep 24 23:55:21 2018 -0500 quartz/filtergraph: Improve HRESULT propagation from IFilterGraph2_Connect(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtergraph.c | 11 +++++-- dlls/quartz/tests/filtergraph.c | 67 +++++++++++++++++++++++++++++++++++++++-- 2 files changed, 73 insertions(+), 5 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index 4f3e0a7..8d99ee5 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -1147,7 +1147,11 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut, /* Try direct connection first */ hr = IPin_Connect(ppinOut, ppinIn, NULL); - if (SUCCEEDED(hr)) + + /* If direct connection succeeded, we should propagate that return value. + * If it returned VFW_E_NOT_CONNECTED or VFW_E_NO_AUDIO_HARDWARE, then don't + * even bother trying intermediate filters, since they won't succeed. */ + if (SUCCEEDED(hr) || hr == VFW_E_NOT_CONNECTED || hr == VFW_E_NO_AUDIO_HARDWARE) goto out; TRACE("Direct connection failed, trying to render using extra filters\n"); @@ -1345,6 +1349,9 @@ error: } } + if (FAILED(hr)) + hr = VFW_E_CANNOT_CONNECT; + IEnumMoniker_Release(pEnumMoniker); out: @@ -1357,7 +1364,7 @@ out: --This->recursioncount; LeaveCriticalSection(&This->cs); TRACE("--> %08x\n", hr); - return SUCCEEDED(hr) ? S_OK : hr; + return hr; } /* Render all output pins of the given filter. Helper for FilterGraph2_Render(). */ diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index 6c8b9fa..5693c86 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -609,7 +609,6 @@ static void test_render_run(const WCHAR *file) ok(!refs, "Graph has %u references\n", refs); hr = test_graph_builder_connect_file(filename); -todo_wine ok(hr == VFW_E_CANNOT_CONNECT, "got %#x\n", hr); } else @@ -776,6 +775,8 @@ struct testpin unsigned int type_count, enum_idx; AM_MEDIA_TYPE *request_mt, *accept_mt; + HRESULT Connect_hr; + HRESULT EnumMediaTypes_hr; HRESULT QueryInternalConnections_hr; }; @@ -964,6 +965,9 @@ static HRESULT WINAPI testpin_EnumMediaTypes(IPin *iface, IEnumMediaTypes **out) struct testpin *pin = impl_from_IPin(iface); if (winetest_debug > 1) trace("%p->EnumMediaTypes()\n", pin); + if (FAILED(pin->EnumMediaTypes_hr)) + return pin->EnumMediaTypes_hr; + *out = &pin->IEnumMediaTypes_iface; IEnumMediaTypes_AddRef(*out); pin->enum_idx = 0; @@ -1063,6 +1067,8 @@ static void testpin_init(struct testpin *pin, const IPinVtbl *vtbl, PIN_DIRECTIO pin->IEnumMediaTypes_iface.lpVtbl = &testenummt_vtbl; pin->ref = 1; pin->dir = dir; + pin->Connect_hr = S_OK; + pin->EnumMediaTypes_hr = S_OK; pin->QueryInternalConnections_hr = E_NOTIMPL; } @@ -1077,12 +1083,16 @@ static HRESULT WINAPI testsource_Connect(IPin *iface, IPin *peer, const AM_MEDIA HRESULT hr; if (winetest_debug > 1) trace("%p->Connect(%p)\n", pin, peer); + if (FAILED(pin->Connect_hr)) + return pin->Connect_hr; + ok(!mt, "Got media type %p.\n", mt); if (SUCCEEDED(hr = IPin_ReceiveConnection(peer, &pin->IPin_iface, pin->request_mt))) { pin->peer = peer; IPin_AddRef(peer); + return pin->Connect_hr; } return hr; } @@ -1711,12 +1721,50 @@ static void test_graph_builder_connect(void) IFilterGraph2_Disconnect(graph, source_pin.peer); IFilterGraph2_Disconnect(graph, &source_pin.IPin_iface); + for (source_pin.Connect_hr = 0x00040200; source_pin.Connect_hr <= 0x000402ff; + ++source_pin.Connect_hr) + { + hr = IFilterGraph2_Connect(graph, &source_pin.IPin_iface, &sink_pin.IPin_iface); + ok(hr == source_pin.Connect_hr, "Got hr %#x for Connect() hr %#x.\n", + hr, source_pin.Connect_hr); + ok(source_pin.peer == &sink_pin.IPin_iface, "Got peer %p.\n", source_pin.peer); + IFilterGraph2_Disconnect(graph, source_pin.peer); + IFilterGraph2_Disconnect(graph, &source_pin.IPin_iface); + } + source_pin.Connect_hr = S_OK; + sink_pin.accept_mt = &sink_type; hr = IFilterGraph2_Connect(graph, &source_pin.IPin_iface, &sink_pin.IPin_iface); -todo_wine ok(hr == VFW_E_CANNOT_CONNECT, "Got hr %#x.\n", hr); ok(!source_pin.peer, "Got peer %p.\n", source_pin.peer); + for (source_pin.Connect_hr = 0x80040200; source_pin.Connect_hr <= 0x800402ff; + ++source_pin.Connect_hr) + { + hr = IFilterGraph2_Connect(graph, &source_pin.IPin_iface, &sink_pin.IPin_iface); + if (source_pin.Connect_hr == VFW_E_NOT_CONNECTED + || source_pin.Connect_hr == VFW_E_NO_AUDIO_HARDWARE) + ok(hr == source_pin.Connect_hr, "Got hr %#x for Connect() hr %#x.\n", + hr, source_pin.Connect_hr); + else + ok(hr == VFW_E_CANNOT_CONNECT, "Got hr %#x for Connect() hr %#x.\n", + hr, source_pin.Connect_hr); + ok(!source_pin.peer, "Got peer %p.\n", source_pin.peer); + ok(!sink_pin.peer, "Got peer %p.\n", sink_pin.peer); + } + source_pin.Connect_hr = S_OK; + + for (source_pin.EnumMediaTypes_hr = 0x80040200; source_pin.EnumMediaTypes_hr <= 0x800402ff; + ++source_pin.EnumMediaTypes_hr) + { + hr = IFilterGraph2_Connect(graph, &source_pin.IPin_iface, &sink_pin.IPin_iface); + ok(hr == source_pin.EnumMediaTypes_hr, "Got hr %#x for EnumMediaTypes() hr %#x.\n", + hr, source_pin.EnumMediaTypes_hr); + ok(!source_pin.peer, "Got peer %p.\n", source_pin.peer); + ok(!sink_pin.peer, "Got peer %p.\n", sink_pin.peer); + } + source_pin.EnumMediaTypes_hr = S_OK; + /* Test usage of intermediate filters. Similarly to Render(), filters are * simply tried in enumeration order. */ @@ -1740,6 +1788,20 @@ todo_wine IFilterGraph2_Disconnect(graph, sink_pin.peer); IFilterGraph2_Disconnect(graph, &sink_pin.IPin_iface); + for (source_pin.Connect_hr = 0x00040200; source_pin.Connect_hr <= 0x000402ff; + ++source_pin.Connect_hr) + { + hr = IFilterGraph2_Connect(graph, &source_pin.IPin_iface, &sink_pin.IPin_iface); + ok(hr == S_OK, "Got hr %#x for Connect() hr %#x.\n", hr, source_pin.Connect_hr); + ok(source_pin.peer == &parser2_pins[0].IPin_iface, "Got peer %p.\n", source_pin.peer); + ok(sink_pin.peer == &parser2_pins[1].IPin_iface, "Got peer %p.\n", sink_pin.peer); + IFilterGraph2_Disconnect(graph, source_pin.peer); + IFilterGraph2_Disconnect(graph, &source_pin.IPin_iface); + IFilterGraph2_Disconnect(graph, sink_pin.peer); + IFilterGraph2_Disconnect(graph, &sink_pin.IPin_iface); + } + source_pin.Connect_hr = S_OK; + IFilterGraph2_RemoveFilter(graph, &parser1.IBaseFilter_iface); IFilterGraph2_AddFilter(graph, &parser1.IBaseFilter_iface, NULL); @@ -1805,7 +1867,6 @@ todo_wine parser1_pins[1].name[0] = '~'; hr = IFilterGraph2_Connect(graph, &source_pin.IPin_iface, &sink_pin.IPin_iface); -todo_wine ok(hr == VFW_E_CANNOT_CONNECT, "Got hr %#x.\n", hr); ok(!source_pin.peer, "Got peer %p.\n", source_pin.peer);

1 0

Jason Edmeades : msvcrt: Do not put cmd.exe special environment variables into the environ.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 0dcfc97fcbea15037d15dd1021870de25b8382df URL: https://source.winehq.org/git/wine.git/?a=commit;h=0dcfc97fcbea15037d15dd10… Author: Jason Edmeades <us(a)edmeades.me.uk> Date: Tue Sep 25 08:39:59 2018 +0100 msvcrt: Do not put cmd.exe special environment variables into the environ. All the special environment variables from the command shell which track directory use are stripped out from the C runtime environ/wenviron. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45320 Signed-off-by: Jason Edmeades <us(a)edmeades.me.uk> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/data.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/data.c b/dlls/msvcrt/data.c index 06e16a8..f08d9b1 100644 --- a/dlls/msvcrt/data.c +++ b/dlls/msvcrt/data.c @@ -73,7 +73,8 @@ char ** msvcrt_SnapshotOfEnvironmentA(char **blk) for (ptr = environ_strings; *ptr; ptr += strlen(ptr) + 1) { - count++; + /* Don't count environment variables starting with '=' which are command shell specific */ + if (*ptr != '=') count++; len += strlen(ptr) + 1; } if (blk) @@ -88,7 +89,8 @@ char ** msvcrt_SnapshotOfEnvironmentA(char **blk) memcpy(&blk[count],environ_strings,len); for (ptr = (char*) &blk[count]; *ptr; ptr += strlen(ptr) + 1) { - blk[i++] = ptr; + /* Skip special environment strings set by the command shell */ + if (*ptr != '=') blk[i++] = ptr; } } blk[i] = NULL; @@ -105,7 +107,8 @@ MSVCRT_wchar_t ** msvcrt_SnapshotOfEnvironmentW(MSVCRT_wchar_t **wblk) for (wptr = wenviron_strings; *wptr; wptr += strlenW(wptr) + 1) { - count++; + /* Don't count environment variables starting with '=' which are command shell specific */ + if (*wptr != '=') count++; len += strlenW(wptr) + 1; } if (wblk) @@ -119,7 +122,8 @@ MSVCRT_wchar_t ** msvcrt_SnapshotOfEnvironmentW(MSVCRT_wchar_t **wblk) memcpy(&wblk[count],wenviron_strings,len * sizeof(MSVCRT_wchar_t)); for (wptr = (MSVCRT_wchar_t*)&wblk[count]; *wptr; wptr += strlenW(wptr) + 1) { - wblk[i++] = wptr; + /* Skip special environment strings set by the command shell */ + if (*wptr != '=') wblk[i++] = wptr; } } wblk[i] = NULL;

1 0

Alexandre Julliard : server: Return more specific error status for NE binaries.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 622aeeba6a37fe85f516b9ceeb3f66c9fcc6865f URL: https://source.winehq.org/git/wine.git/?a=commit;h=622aeeba6a37fe85f516b9ce… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 25 16:52:00 2018 +0200 server: Return more specific error status for NE binaries. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/loader.c | 18 ++++++++++++++++++ server/mapping.c | 7 +++++-- server/trace.c | 1 + 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c index e7a1a43..bc88c5f 100644 --- a/dlls/kernel32/tests/loader.c +++ b/dlls/kernel32/tests/loader.c @@ -972,6 +972,24 @@ static void test_Loader(void) nt_header.Signature = IMAGE_OS2_SIGNATURE; status = map_image_section( &nt_header, &section, section_data, __LINE__ ); ok( status == STATUS_INVALID_IMAGE_NE_FORMAT, "NtCreateSection error %08x\n", status ); + for (i = 0; i < 16; i++) + { + ((IMAGE_OS2_HEADER *)&nt_header)->ne_exetyp = i; + status = map_image_section( &nt_header, &section, section_data, __LINE__ ); + switch (i) + { + case 2: + ok( status == STATUS_INVALID_IMAGE_WIN_16, "NtCreateSection %u error %08x\n", i, status ); + break; + case 5: + ok( status == STATUS_INVALID_IMAGE_PROTECT, "NtCreateSection %u error %08x\n", i, status ); + break; + default: + ok( status == STATUS_INVALID_IMAGE_NE_FORMAT, "NtCreateSection %u error %08x\n", i, status ); + break; + } + } + ((IMAGE_OS2_HEADER *)&nt_header)->ne_exetyp = ((IMAGE_OS2_HEADER *)&nt_header_template)->ne_exetyp; nt_header.Signature = 0xdeadbeef; status = map_image_section( &nt_header, &section, section_data, __LINE__ ); diff --git a/server/mapping.c b/server/mapping.c index 1ed8c9d..2955766 100644 --- a/server/mapping.c +++ b/server/mapping.c @@ -587,8 +587,11 @@ static unsigned int get_image_params( struct mapping *mapping, file_pos_t file_s if (size < sizeof(nt)) memset( (char *)&nt + size, 0, sizeof(nt) - size ); if (nt.Signature != IMAGE_NT_SIGNATURE) { - if (*(WORD *)&nt.Signature == IMAGE_OS2_SIGNATURE) return STATUS_INVALID_IMAGE_NE_FORMAT; - return STATUS_INVALID_IMAGE_PROTECT; + IMAGE_OS2_HEADER *os2 = (IMAGE_OS2_HEADER *)&nt; + if (os2->ne_magic != IMAGE_OS2_SIGNATURE) return STATUS_INVALID_IMAGE_PROTECT; + if (os2->ne_exetyp == 2) return STATUS_INVALID_IMAGE_WIN_16; + if (os2->ne_exetyp == 5) return STATUS_INVALID_IMAGE_PROTECT; + return STATUS_INVALID_IMAGE_NE_FORMAT; } switch (nt.opt.hdr32.Magic) diff --git a/server/trace.c b/server/trace.c index 7b54c4f..5140ab1 100644 --- a/server/trace.c +++ b/server/trace.c @@ -5480,6 +5480,7 @@ static const struct { "INVALID_IMAGE_NE_FORMAT", STATUS_INVALID_IMAGE_NE_FORMAT }, { "INVALID_IMAGE_NOT_MZ", STATUS_INVALID_IMAGE_NOT_MZ }, { "INVALID_IMAGE_PROTECT", STATUS_INVALID_IMAGE_PROTECT }, + { "INVALID_IMAGE_WIN_16", STATUS_INVALID_IMAGE_WIN_16 }, { "INVALID_IMAGE_WIN_64", STATUS_INVALID_IMAGE_WIN_64 }, { "INVALID_LOCK_SEQUENCE", STATUS_INVALID_LOCK_SEQUENCE }, { "INVALID_OWNER", STATUS_INVALID_OWNER },

1 0

Alexandre Julliard : kernel32: Reimplement GetBinaryTypeW to rely on the server for header parsing.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 57512807b9da8c5852e0ff1466950bad9ece36ad URL: https://source.winehq.org/git/wine.git/?a=commit;h=57512807b9da8c5852e0ff14… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 25 17:42:19 2018 +0200 kernel32: Reimplement GetBinaryTypeW to rely on the server for header parsing. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/module.c | 122 ++++++++++++++++++++++++++----------------------- 1 file changed, 65 insertions(+), 57 deletions(-) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index 1188298..31e3014 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -563,76 +563,84 @@ void MODULE_get_binary_info( HANDLE hfile, struct binary_info *info ) * ".com" and ".pif" files are only recognized by their file name extension, * as per native Windows. */ -BOOL WINAPI GetBinaryTypeW( LPCWSTR lpApplicationName, LPDWORD lpBinaryType ) +BOOL WINAPI GetBinaryTypeW( LPCWSTR name, LPDWORD type ) { - BOOL ret = FALSE; - HANDLE hfile; - struct binary_info binary_info; + static const WCHAR comW[] = { '.','c','o','m',0 }; + static const WCHAR pifW[] = { '.','p','i','f',0 }; + HANDLE hfile, mapping; + NTSTATUS status; + const WCHAR *ptr; - TRACE("%s\n", debugstr_w(lpApplicationName) ); + TRACE("%s\n", debugstr_w(name) ); - /* Sanity check. - */ - if ( lpApplicationName == NULL || lpBinaryType == NULL ) - return FALSE; + if (type == NULL) return FALSE; - /* Open the file indicated by lpApplicationName for reading. - */ - hfile = CreateFileW( lpApplicationName, GENERIC_READ, FILE_SHARE_READ, - NULL, OPEN_EXISTING, 0, 0 ); + hfile = CreateFileW( name, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0 ); if ( hfile == INVALID_HANDLE_VALUE ) return FALSE; - /* Check binary type - */ - MODULE_get_binary_info( hfile, &binary_info ); - switch (binary_info.type) - { - case BINARY_UNKNOWN: + status = NtCreateSection( &mapping, STANDARD_RIGHTS_REQUIRED | SECTION_QUERY, + NULL, NULL, PAGE_READONLY, SEC_IMAGE, hfile ); + CloseHandle( hfile ); + + switch (status) { - static const WCHAR comW[] = { '.','C','O','M',0 }; - static const WCHAR pifW[] = { '.','P','I','F',0 }; - const WCHAR *ptr; - - /* try to determine from file name */ - ptr = strrchrW( lpApplicationName, '.' ); - if (!ptr) break; - if (!strcmpiW( ptr, comW )) + case STATUS_SUCCESS: { - *lpBinaryType = SCS_DOS_BINARY; - ret = TRUE; + SECTION_IMAGE_INFORMATION info; + + status = NtQuerySection( mapping, SectionImageInformation, &info, sizeof(info), NULL ); + CloseHandle( mapping ); + if (status) return FALSE; + switch (info.Machine) + { + case IMAGE_FILE_MACHINE_I386: + case IMAGE_FILE_MACHINE_ARM: + case IMAGE_FILE_MACHINE_THUMB: + case IMAGE_FILE_MACHINE_ARMNT: + case IMAGE_FILE_MACHINE_POWERPC: + *type = SCS_32BIT_BINARY; + return TRUE; + case IMAGE_FILE_MACHINE_AMD64: + case IMAGE_FILE_MACHINE_ARM64: + *type = SCS_64BIT_BINARY; + return TRUE; + } + return FALSE; } - else if (!strcmpiW( ptr, pifW )) + case STATUS_INVALID_IMAGE_WIN_16: + *type = SCS_WOW_BINARY; + return TRUE; + case STATUS_INVALID_IMAGE_WIN_32: + *type = SCS_32BIT_BINARY; + return TRUE; + case STATUS_INVALID_IMAGE_WIN_64: + *type = SCS_64BIT_BINARY; + return TRUE; + case STATUS_INVALID_IMAGE_NE_FORMAT: + *type = SCS_OS216_BINARY; + return TRUE; + case STATUS_INVALID_IMAGE_PROTECT: + *type = SCS_DOS_BINARY; + return TRUE; + case STATUS_INVALID_IMAGE_NOT_MZ: + if ((ptr = strrchrW( name, '.' ))) { - *lpBinaryType = SCS_PIF_BINARY; - ret = TRUE; + if (!strcmpiW( ptr, comW )) + { + *type = SCS_DOS_BINARY; + return TRUE; + } + if (!strcmpiW( ptr, pifW )) + { + *type = SCS_PIF_BINARY; + return TRUE; + } } - break; - } - case BINARY_PE: - *lpBinaryType = (binary_info.flags & BINARY_FLAG_64BIT) ? SCS_64BIT_BINARY : SCS_32BIT_BINARY; - ret = TRUE; - break; - case BINARY_WIN16: - *lpBinaryType = SCS_WOW_BINARY; - ret = TRUE; - break; - case BINARY_OS216: - *lpBinaryType = SCS_OS216_BINARY; - ret = TRUE; - break; - case BINARY_DOS: - *lpBinaryType = SCS_DOS_BINARY; - ret = TRUE; - break; - case BINARY_UNIX_EXE: - case BINARY_UNIX_LIB: - ret = FALSE; - break; + return FALSE; + default: + return FALSE; } - - CloseHandle( hfile ); - return ret; } /***********************************************************************

1 0

Alexandre Julliard : kernel32: Remove the DOS/Win16/ OS2 binary distinction.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 1060567cc592aaf7aa453d43a0a48bf7e9ac87f3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1060567cc592aaf7aa453d43… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 25 19:23:00 2018 +0200 kernel32: Remove the DOS/Win16/OS2 binary distinction. They all need to be run through winevdm. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/kernel_private.h | 2 -- dlls/kernel32/module.c | 72 +----------------------------------------- dlls/kernel32/process.c | 8 ++--- 3 files changed, 3 insertions(+), 79 deletions(-) diff --git a/dlls/kernel32/kernel_private.h b/dlls/kernel32/kernel_private.h index 9073e18..b465d17 100644 --- a/dlls/kernel32/kernel_private.h +++ b/dlls/kernel32/kernel_private.h @@ -69,8 +69,6 @@ enum binary_type BINARY_UNKNOWN = 0, BINARY_PE, BINARY_WIN16, - BINARY_OS216, - BINARY_DOS, BINARY_UNIX_EXE, BINARY_UNIX_LIB }; diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index 31e3014..f03b498 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -259,54 +259,6 @@ BOOL WINAPI DisableThreadLibraryCalls( HMODULE hModule ) } -/* Check whether a file is an OS/2 or a very old Windows executable - * by testing on import of KERNEL. - * - * Reading the module imports is the only reasonable way of discerning - * old Windows binaries from OS/2 ones. - */ -static DWORD MODULE_Decide_OS2_OldWin(HANDLE hfile, const IMAGE_DOS_HEADER *mz, const IMAGE_OS2_HEADER *ne) -{ - DWORD currpos = SetFilePointer( hfile, 0, NULL, SEEK_CUR); - DWORD ret = BINARY_OS216; - LPWORD modtab = NULL; - LPSTR nametab = NULL; - DWORD len; - int i; - - /* read modref table */ - if ( (SetFilePointer( hfile, mz->e_lfanew + ne->ne_modtab, NULL, SEEK_SET ) == -1) - || (!(modtab = HeapAlloc( GetProcessHeap(), 0, ne->ne_cmod*sizeof(WORD)))) - || (!(ReadFile(hfile, modtab, ne->ne_cmod*sizeof(WORD), &len, NULL))) - || (len != ne->ne_cmod*sizeof(WORD)) ) - goto done; - - /* read imported names table */ - if ( (SetFilePointer( hfile, mz->e_lfanew + ne->ne_imptab, NULL, SEEK_SET ) == -1) - || (!(nametab = HeapAlloc( GetProcessHeap(), 0, ne->ne_enttab - ne->ne_imptab))) - || (!(ReadFile(hfile, nametab, ne->ne_enttab - ne->ne_imptab, &len, NULL))) - || (len != ne->ne_enttab - ne->ne_imptab) ) - goto done; - - for (i=0; i < ne->ne_cmod; i++) - { - LPSTR module = &nametab[modtab[i]]; - TRACE("modref: %.*s\n", module[0], &module[1]); - if (!(strncmp(&module[1], "KERNEL", module[0]))) - { /* very old Windows file */ - MESSAGE("This seems to be a very old (pre-3.0) Windows executable. Expect crashes, especially if this is a real-mode binary !\n"); - ret = BINARY_WIN16; - break; - } - } - -done: - HeapFree( GetProcessHeap(), 0, modtab); - HeapFree( GetProcessHeap(), 0, nametab); - SetFilePointer( hfile, currpos, NULL, SEEK_SET); /* restore filepos */ - return ret; -} - /*********************************************************************** * MODULE_GetBinaryType */ @@ -460,7 +412,7 @@ void MODULE_get_binary_info( HANDLE hfile, struct binary_info *info ) * This will tell us if there is more header information * to read or not. */ - info->type = BINARY_DOS; + info->type = BINARY_WIN16; info->arch = IMAGE_FILE_MACHINE_I386; if (SetFilePointer( hfile, header.mz.e_lfanew, NULL, SEEK_SET ) == -1) return; if (!ReadFile( hfile, &ext_header, sizeof(ext_header), &len, NULL ) || len < 4) return; @@ -504,28 +456,6 @@ void MODULE_get_binary_info( HANDLE hfile, struct binary_info *info ) } } } - else if (!memcmp( &ext_header.os2.ne_magic, "NE", 2 )) - { - /* This is a Windows executable (NE) header. This can - * mean either a 16-bit OS/2 or a 16-bit Windows or even a - * DOS program (running under a DOS extender). To decide - * which, we'll have to read the NE header. - */ - if (len >= sizeof(ext_header.os2)) - { - if (ext_header.os2.ne_flags & NE_FFLAGS_LIBMODULE) info->flags |= BINARY_FLAG_DLL; - switch ( ext_header.os2.ne_exetyp ) - { - case 1: info->type = BINARY_OS216; break; /* OS/2 */ - case 2: info->type = BINARY_WIN16; break; /* Windows */ - case 3: info->type = BINARY_DOS; break; /* European MS-DOS 4.x */ - case 4: info->type = BINARY_WIN16; break; /* Windows 386; FIXME: is this 32bit??? */ - case 5: info->type = BINARY_DOS; break; /* BOSS, Borland Operating System Services */ - /* other types, e.g. 0 is: "unknown" */ - default: info->type = MODULE_Decide_OS2_OldWin(hfile, &header.mz, &ext_header.os2); break; - } - } - } } } diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index b0b5ccf..e159047 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2478,9 +2478,7 @@ static BOOL create_process_impl( LPCWSTR app_name, LPWSTR cmd_line, LPSECURITY_A retv = create_process( hFile, name, tidy_cmdline, envW, cur_dir, process_attr, thread_attr, inherit, flags, startup_info, info, unixdir, &binary_info, FALSE ); break; - case BINARY_OS216: case BINARY_WIN16: - case BINARY_DOS: TRACE( "starting %s as Win16/DOS binary\n", debugstr_w(name) ); retv = create_vdm_process( name, tidy_cmdline, envW, cur_dir, process_attr, thread_attr, inherit, flags, startup_info, info, unixdir, &binary_info, FALSE ); @@ -2498,7 +2496,7 @@ static BOOL create_process_impl( LPCWSTR app_name, LPWSTR cmd_line, LPSECURITY_A if (!strcmpiW( p, comW ) || !strcmpiW( p, pifW )) { TRACE( "starting %s as DOS binary\n", debugstr_w(name) ); - binary_info.type = BINARY_DOS; + binary_info.type = BINARY_WIN16; binary_info.arch = IMAGE_FILE_MACHINE_I386; retv = create_vdm_process( name, tidy_cmdline, envW, cur_dir, process_attr, thread_attr, inherit, flags, startup_info, info, unixdir, @@ -2640,12 +2638,10 @@ static void exec_process( LPCWSTR name ) /* check for .com or .pif extension */ if (!(p = strrchrW( name, '.' ))) break; if (strcmpiW( p, comW ) && strcmpiW( p, pifW )) break; - binary_info.type = BINARY_DOS; + binary_info.type = BINARY_WIN16; binary_info.arch = IMAGE_FILE_MACHINE_I386; /* fall through */ - case BINARY_OS216: case BINARY_WIN16: - case BINARY_DOS: TRACE( "starting %s as Win16/DOS binary\n", debugstr_w(name) ); create_vdm_process( name, GetCommandLineW(), NULL, NULL, NULL, NULL, FALSE, 0, &startup_info, &info, NULL, &binary_info, TRUE );

1 0

Nikolay Sivov : crypt32/base64: Fix certificate request header and trailer in CryptBinaryToStringW() output.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: fb53f6e79d9c1948af206f58ba2f9a294d23c8d7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fb53f6e79d9c1948af206f58… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Sep 25 16:55:36 2018 +0300 crypt32/base64: Fix certificate request header and trailer in CryptBinaryToStringW() output. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/base64.c | 4 +- dlls/crypt32/tests/base64.c | 226 ++++++++++++++++++++++++++++++-------------- 2 files changed, 159 insertions(+), 71 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=fb53f6e79d9c1948af20…

1 0

Józef Kucia : dxgi: Simplify dxgi_adapter_GetDesc().
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 47cf3204b45d6a81f531008035e45ffb6f2c5d40 URL: https://source.winehq.org/git/wine.git/?a=commit;h=47cf3204b45d6a81f5310080… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Sep 25 10:33:21 2018 +0200 dxgi: Simplify dxgi_adapter_GetDesc(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/adapter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/dxgi/adapter.c b/dlls/dxgi/adapter.c index b7d7a0a..1f81d77 100644 --- a/dlls/dxgi/adapter.c +++ b/dlls/dxgi/adapter.c @@ -200,9 +200,8 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_GetDesc(IWineDXGIAdapter *iface, D if (!desc) return E_INVALIDARG; - if (FAILED(hr = dxgi_adapter_GetDesc1(iface, &desc1))) - return hr; - memcpy(desc, &desc1, sizeof(*desc)); + if (SUCCEEDED(hr = dxgi_adapter_GetDesc1(iface, &desc1))) + memcpy(desc, &desc1, sizeof(*desc)); return hr; }

1 0

Józef Kucia : dxgi: Merge dxgi_check_feature_level_support() into dxgi_adapter_CheckInterfaceSupport().
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 04887860caecb2b88783eabb2416299f620ec8f5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=04887860caecb2b88783eabb… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Sep 25 10:33:22 2018 +0200 dxgi: Merge dxgi_check_feature_level_support() into dxgi_adapter_CheckInterfaceSupport(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/adapter.c | 30 ++++++++++++++------------ dlls/dxgi/dxgi_private.h | 3 --- dlls/dxgi/utils.c | 56 ------------------------------------------------ 3 files changed, 16 insertions(+), 73 deletions(-) diff --git a/dlls/dxgi/adapter.c b/dlls/dxgi/adapter.c index 1f81d77..4bc57a2 100644 --- a/dlls/dxgi/adapter.c +++ b/dlls/dxgi/adapter.c @@ -209,9 +209,10 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_GetDesc(IWineDXGIAdapter *iface, D static HRESULT STDMETHODCALLTYPE dxgi_adapter_CheckInterfaceSupport(IWineDXGIAdapter *iface, REFGUID guid, LARGE_INTEGER *umd_version) { - static const D3D_FEATURE_LEVEL feature_level = D3D_FEATURE_LEVEL_10_0; struct dxgi_adapter *adapter = impl_from_IWineDXGIAdapter(iface); struct wined3d_adapter_identifier adapter_id; + struct wined3d_caps caps; + struct wined3d *wined3d; HRESULT hr; TRACE("iface %p, guid %s, umd_version %p.\n", iface, debugstr_guid(guid), umd_version); @@ -224,23 +225,24 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_CheckInterfaceSupport(IWineDXGIAda return DXGI_ERROR_UNSUPPORTED; } - if (!dxgi_check_feature_level_support(adapter->factory, adapter, &feature_level, 1)) - return DXGI_ERROR_UNSUPPORTED; + adapter_id.driver_size = 0; + adapter_id.description_size = 0; + adapter_id.device_name_size = 0; - if (umd_version) - { - adapter_id.driver_size = 0; - adapter_id.description_size = 0; - adapter_id.device_name_size = 0; + wined3d_mutex_lock(); + wined3d = adapter->factory->wined3d; + hr = wined3d_get_device_caps(wined3d, adapter->ordinal, WINED3D_DEVICE_TYPE_HAL, &caps); + if (SUCCEEDED(hr)) + hr = wined3d_get_adapter_identifier(wined3d, adapter->ordinal, 0, &adapter_id); + wined3d_mutex_unlock(); - wined3d_mutex_lock(); - hr = wined3d_get_adapter_identifier(adapter->factory->wined3d, adapter->ordinal, 0, &adapter_id); - wined3d_mutex_unlock(); - if (FAILED(hr)) - return hr; + if (FAILED(hr)) + return hr; + if (caps.max_feature_level < WINED3D_FEATURE_LEVEL_10) + return DXGI_ERROR_UNSUPPORTED; + if (umd_version) *umd_version = adapter_id.driver_version; - } return S_OK; } diff --git a/dlls/dxgi/dxgi_private.h b/dlls/dxgi/dxgi_private.h index 8c3e41a..78f1886 100644 --- a/dlls/dxgi/dxgi_private.h +++ b/dlls/dxgi/dxgi_private.h @@ -199,7 +199,4 @@ struct dxgi_surface HRESULT dxgi_surface_init(struct dxgi_surface *surface, IDXGIDevice *device, IUnknown *outer, struct wined3d_texture *wined3d_texture) DECLSPEC_HIDDEN; -D3D_FEATURE_LEVEL dxgi_check_feature_level_support(struct dxgi_factory *factory, struct dxgi_adapter *adapter, - const D3D_FEATURE_LEVEL *feature_levels, unsigned int level_count) DECLSPEC_HIDDEN; - #endif /* __WINE_DXGI_PRIVATE_H */ diff --git a/dlls/dxgi/utils.c b/dlls/dxgi/utils.c index ad8e2a2..73b37fd 100644 --- a/dlls/dxgi/utils.c +++ b/dlls/dxgi/utils.c @@ -619,59 +619,3 @@ HRESULT dxgi_set_private_data_interface(struct wined3d_private_store *store, return hr; } - -static enum wined3d_feature_level wined3d_feature_level_from_d3d(D3D_FEATURE_LEVEL feature_level) -{ - switch (feature_level) - { - case D3D_FEATURE_LEVEL_11_1: - return WINED3D_FEATURE_LEVEL_11_1; - case D3D_FEATURE_LEVEL_11_0: - return WINED3D_FEATURE_LEVEL_11; - case D3D_FEATURE_LEVEL_10_1: - return WINED3D_FEATURE_LEVEL_10_1; - case D3D_FEATURE_LEVEL_10_0: - return WINED3D_FEATURE_LEVEL_10; - case D3D_FEATURE_LEVEL_9_3: - return WINED3D_FEATURE_LEVEL_9_SM3; - case D3D_FEATURE_LEVEL_9_2: - return WINED3D_FEATURE_LEVEL_9_SM2; - case D3D_FEATURE_LEVEL_9_1: - return WINED3D_FEATURE_LEVEL_9_1; - default: - FIXME("Unhandled feature level %#x.\n", feature_level); - return 0; - } -} - -D3D_FEATURE_LEVEL dxgi_check_feature_level_support(struct dxgi_factory *factory, struct dxgi_adapter *adapter, - const D3D_FEATURE_LEVEL *feature_levels, unsigned int level_count) -{ - enum wined3d_feature_level wined3d_feature_level; - struct wined3d_caps caps; - unsigned int i; - HRESULT hr; - - wined3d_mutex_lock(); - hr = wined3d_get_device_caps(factory->wined3d, adapter->ordinal, WINED3D_DEVICE_TYPE_HAL, &caps); - wined3d_mutex_unlock(); - - if (FAILED(hr)) - level_count = 0; - - for (i = 0; i < level_count; ++i) - { - wined3d_feature_level = wined3d_feature_level_from_d3d(feature_levels[i]); - if (wined3d_feature_level && caps.max_feature_level >= wined3d_feature_level) - { - TRACE("Choosing supported feature level %s.\n", - debug_feature_level(feature_levels[i])); - return feature_levels[i]; - } - - TRACE("Feature level %s not supported, trying next fallback if available.\n", - debug_feature_level(feature_levels[i])); - } - - return 0; -}

1 0

Józef Kucia : wined3d: Cleanup fallback cards list.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: c83a47004a707d1292b77eabc1cf44c037d46156 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c83a47004a707d1292b77eab… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Sep 25 10:33:23 2018 +0200 wined3d: Cleanup fallback cards list. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/directx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index f7ef5c0..97037b6 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -637,7 +637,6 @@ enum wined3d_pci_device wined3d_gpu_from_feature_level(enum wined3d_pci_vendor * card_fallback_amd[] = { {WINED3D_FEATURE_LEVEL_5, CARD_AMD_RAGE_128PRO}, - {WINED3D_FEATURE_LEVEL_6, CARD_AMD_RAGE_128PRO}, {WINED3D_FEATURE_LEVEL_7, CARD_AMD_RADEON_7200}, {WINED3D_FEATURE_LEVEL_8, CARD_AMD_RADEON_8500}, {WINED3D_FEATURE_LEVEL_9_SM2, CARD_AMD_RADEON_9500}, @@ -649,10 +648,7 @@ enum wined3d_pci_device wined3d_gpu_from_feature_level(enum wined3d_pci_vendor * card_fallback_intel[] = { {WINED3D_FEATURE_LEVEL_5, CARD_INTEL_845G}, - {WINED3D_FEATURE_LEVEL_6, CARD_INTEL_845G}, - {WINED3D_FEATURE_LEVEL_7, CARD_INTEL_845G}, {WINED3D_FEATURE_LEVEL_8, CARD_INTEL_915G}, - {WINED3D_FEATURE_LEVEL_9_SM2, CARD_INTEL_915G}, {WINED3D_FEATURE_LEVEL_9_SM3, CARD_INTEL_945G}, {WINED3D_FEATURE_LEVEL_10, CARD_INTEL_G45}, {WINED3D_FEATURE_LEVEL_11, CARD_INTEL_IVBD},

1 0

Józef Kucia : d3d11: Trace skipped DXBC chunks.
by Alexandre Julliard 25 Sep '18

25 Sep '18

Module: wine Branch: master Commit: 508512312cd1f6959a2e2cbe107b64fcdd14cc63 URL: https://source.winehq.org/git/wine.git/?a=commit;h=508512312cd1f6959a2e2cbe… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Sep 25 10:33:24 2018 +0200 d3d11: Trace skipped DXBC chunks. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/d3d11_private.h | 2 -- dlls/d3d11/shader.c | 6 +----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/dlls/d3d11/d3d11_private.h b/dlls/d3d11/d3d11_private.h index 3049193..e26554a 100644 --- a/dlls/d3d11/d3d11_private.h +++ b/dlls/d3d11/d3d11_private.h @@ -47,10 +47,8 @@ #define TAG_OSG5 MAKE_TAG('O', 'S', 'G', '5') #define TAG_OSGN MAKE_TAG('O', 'S', 'G', 'N') #define TAG_PCSG MAKE_TAG('P', 'C', 'S', 'G') -#define TAG_RDEF MAKE_TAG('R', 'D', 'E', 'F') #define TAG_SHDR MAKE_TAG('S', 'H', 'D', 'R') #define TAG_SHEX MAKE_TAG('S', 'H', 'E', 'X') -#define TAG_STAT MAKE_TAG('S', 'T', 'A', 'T') struct d3d_device; diff --git a/dlls/d3d11/shader.c b/dlls/d3d11/shader.c index c8d512f..759c570 100644 --- a/dlls/d3d11/shader.c +++ b/dlls/d3d11/shader.c @@ -136,12 +136,8 @@ static HRESULT shdr_handler(const char *data, DWORD data_size, DWORD tag, void * } break; - case TAG_RDEF: - case TAG_STAT: - break; - default: - FIXME("Unhandled chunk %s.\n", debugstr_an((const char *)&tag, 4)); + TRACE("Skipping chunk %s.\n", debugstr_an((const char *)&tag, 4)); break; }

1 0