December 2019 - Wine-commits

Gabriel Ivăncescu : vbscript: Implement ScriptTypeInfo_GetMops.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: 4bca2a33c74a62c1b9aab22d30c8c00dcb4cce1e URL: https://source.winehq.org/git/wine.git/?a=commit;h=4bca2a33c74a62c1b9aab22d… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Dec 11 18:20:07 2019 +0100 vbscript: Implement ScriptTypeInfo_GetMops. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vbscript/vbdisp.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c index 55307d127c..c14cd7b4c7 100644 --- a/dlls/vbscript/vbdisp.c +++ b/dlls/vbscript/vbdisp.c @@ -1014,10 +1014,23 @@ static HRESULT WINAPI ScriptTypeInfo_CreateInstance(ITypeInfo *iface, IUnknown * static HRESULT WINAPI ScriptTypeInfo_GetMops(ITypeInfo *iface, MEMBERID memid, BSTR *pBstrMops) { ScriptTypeInfo *This = ScriptTypeInfo_from_ITypeInfo(iface); + ITypeInfo *disp_typeinfo; + HRESULT hr; - FIXME("(%p)->(%d %p)\n", This, memid, pBstrMops); + TRACE("(%p)->(%d %p)\n", This, memid, pBstrMops); - return E_NOTIMPL; + if (!pBstrMops) return E_INVALIDARG; + + if (!get_func_from_memid(This, memid) && memid > This->num_vars) + { + hr = get_dispatch_typeinfo(&disp_typeinfo); + if (FAILED(hr)) return hr; + + return ITypeInfo_GetMops(disp_typeinfo, memid, pBstrMops); + } + + *pBstrMops = NULL; + return S_OK; } static HRESULT WINAPI ScriptTypeInfo_GetContainingTypeLib(ITypeInfo *iface, ITypeLib **ppTLib, UINT *pIndex)

1 0

Gabriel Ivăncescu : vbscript/tests: Add more tests for the script TypeInfo.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: a79bde85916043412a3d2928397095831ebe69b8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a79bde85916043412a3d2928… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Dec 11 18:20:15 2019 +0100 vbscript/tests: Add more tests for the script TypeInfo. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vbscript/tests/vbscript.c | 126 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 125 insertions(+), 1 deletion(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a79bde85916043412a3d…

1 0

Gabriel Ivăncescu : jscript: Keep a pointer to the bytecode in function_code_t.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: c70c10564a61221be5a519dbcf360e44eb18c19b URL: https://source.winehq.org/git/wine.git/?a=commit;h=c70c10564a61221be5a519db… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Dec 11 16:08:22 2019 +0200 jscript: Keep a pointer to the bytecode in function_code_t. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/compile.c | 1 + dlls/jscript/engine.h | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index db05d3c360..a530e87d8e 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -2279,6 +2279,7 @@ static HRESULT compile_function(compiler_ctx_t *ctx, source_elements_t *source, TRACE("\n"); + func->bytecode = ctx->code; ctx->func_head = ctx->func_tail = NULL; ctx->from_eval = from_eval; ctx->func = func; diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 955c315ff9..48cc9529f4 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -103,6 +103,8 @@ OP_LIST OP_LAST } jsop_t; +typedef struct _bytecode_t bytecode_t; + typedef union { BSTR bstr; LONG lng; @@ -163,11 +165,13 @@ typedef struct _function_code_t { unsigned locals_cnt; local_ref_t *locals; + + bytecode_t *bytecode; } function_code_t; local_ref_t *lookup_local(const function_code_t*,const WCHAR*) DECLSPEC_HIDDEN; -typedef struct _bytecode_t { +struct _bytecode_t { LONG ref; BOOL is_persistent; @@ -187,7 +191,7 @@ typedef struct _bytecode_t { unsigned str_cnt; struct list entry; -} bytecode_t; +}; HRESULT compile_script(script_ctx_t*,const WCHAR*,const WCHAR*,const WCHAR*,BOOL,BOOL,bytecode_t**) DECLSPEC_HIDDEN; void release_bytecode(bytecode_t*) DECLSPEC_HIDDEN;

1 0

Ken Thomases : winemac: Only manipulate an NSOpenGLContext's view on the main thread.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: 1261589c2cc68061d4bd9d41a387cd4979d7073c URL: https://source.winehq.org/git/wine.git/?a=commit;h=1261589c2cc68061d4bd9d41… Author: Ken Thomases <ken(a)codeweavers.com> Date: Wed Dec 11 11:49:47 2019 -0600 winemac: Only manipulate an NSOpenGLContext's view on the main thread. I was seeing a crash due to an assert about manipulating it on a background thread. I can't recall where I was seeing that. I think it's new in Catalina. Signed-off-by: Chip Davis <cdavis(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/cocoa_opengl.m | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dlls/winemac.drv/cocoa_opengl.m b/dlls/winemac.drv/cocoa_opengl.m index 5a097a12d2..e60b0b388b 100644 --- a/dlls/winemac.drv/cocoa_opengl.m +++ b/dlls/winemac.drv/cocoa_opengl.m @@ -79,8 +79,10 @@ macdrv_set_view_backing_size((macdrv_view)self.view, view_backing); NSView* save = self.view; - [super clearDrawable]; - [super setView:save]; + OnMainThread(^{ + [super clearDrawable]; + [super setView:save]; + }); shouldClearToBlack = TRUE; } } @@ -122,7 +124,11 @@ - (void) setView:(NSView*)newView { NSView* oldView = [self view]; - [super setView:newView]; + if ([NSThread isMainThread]) + [super setView:newView]; + else OnMainThread(^{ + [super setView:newView]; + }); [newView retain]; [oldView release]; } @@ -130,7 +136,11 @@ - (void) clearDrawable { NSView* oldView = [self view]; - [super clearDrawable]; + if ([NSThread isMainThread]) + [super clearDrawable]; + else OnMainThread(^{ + [super clearDrawable]; + }); [oldView release]; [self wine_updateBackingSize:NULL];

1 0

Michael Stefaniuc : mountmgr.sys: Use the ARRAY_SIZE() macro.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: 269f29f3c01b15f693bf350d9dcdb00f8bfad1e1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=269f29f3c01b15f693bf350d… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Wed Dec 11 20:30:14 2019 +0100 mountmgr.sys: Use the ARRAY_SIZE() macro. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mountmgr.sys/device.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c index 3369a92922..0ca2d42517 100644 --- a/dlls/mountmgr.sys/device.c +++ b/dlls/mountmgr.sys/device.c @@ -704,19 +704,19 @@ static HKEY get_scsi_device_lun_key( SCSI_ADDRESS *scsi_addr ) if (RegOpenKeyExW( HKEY_LOCAL_MACHINE, scsi_keyW, 0, KEY_READ|KEY_WRITE, &scsi_key )) return NULL; - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), scsi_port_keyW, scsi_addr->PortNumber ); + snprintfW( dataW, ARRAY_SIZE( dataW ), scsi_port_keyW, scsi_addr->PortNumber ); if (RegCreateKeyExW( scsi_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &port_key, NULL )) return NULL; RegCloseKey( scsi_key ); - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), scsi_bus_keyW, scsi_addr->PathId ); + snprintfW( dataW, ARRAY_SIZE( dataW ), scsi_bus_keyW, scsi_addr->PathId ); if (RegCreateKeyExW( port_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &bus_key, NULL )) return NULL; RegCloseKey( port_key ); - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), target_id_keyW, scsi_addr->TargetId ); + snprintfW( dataW, ARRAY_SIZE( dataW ), target_id_keyW, scsi_addr->TargetId ); if (RegCreateKeyExW( bus_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &target_key, NULL )) return NULL; RegCloseKey( bus_key ); - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), lun_keyW, scsi_addr->Lun ); + snprintfW( dataW, ARRAY_SIZE( dataW ), lun_keyW, scsi_addr->Lun ); if (RegCreateKeyExW( target_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &lun_key, NULL )) return NULL; RegCloseKey( target_key ); @@ -746,7 +746,7 @@ void create_scsi_entry( SCSI_ADDRESS *scsi_addr, UINT init_id, const char *drive if (RegOpenKeyExW( HKEY_LOCAL_MACHINE, scsi_keyW, 0, KEY_READ|KEY_WRITE, &scsi_key )) return; - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), scsi_port_keyW, scsi_addr->PortNumber ); + snprintfW( dataW, ARRAY_SIZE( dataW ), scsi_port_keyW, scsi_addr->PortNumber ); if (RegCreateKeyExW( scsi_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &port_key, NULL )) return; RegCloseKey( scsi_key ); @@ -757,19 +757,19 @@ void create_scsi_entry( SCSI_ADDRESS *scsi_addr, UINT init_id, const char *drive value = 0; - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), scsi_bus_keyW, scsi_addr->PathId ); + snprintfW( dataW, ARRAY_SIZE( dataW ), scsi_bus_keyW, scsi_addr->PathId ); if (RegCreateKeyExW( port_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &bus_key, NULL )) return; RegCloseKey( port_key ); - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), init_id_keyW, init_id ); + snprintfW( dataW, ARRAY_SIZE( dataW ), init_id_keyW, init_id ); if (RegCreateKeyExW( bus_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &target_key, NULL )) return; RegCloseKey( target_key ); - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), target_id_keyW, scsi_addr->TargetId ); + snprintfW( dataW, ARRAY_SIZE( dataW ), target_id_keyW, scsi_addr->TargetId ); if (RegCreateKeyExW( bus_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &target_key, NULL )) return; RegCloseKey( bus_key ); - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), lun_keyW, scsi_addr->Lun ); + snprintfW( dataW, ARRAY_SIZE( dataW ), lun_keyW, scsi_addr->Lun ); if (RegCreateKeyExW( target_key, dataW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &lun_key, NULL )) return; RegCloseKey( target_key ); @@ -811,7 +811,7 @@ void create_scsi_entry( SCSI_ADDRESS *scsi_addr, UINT init_id, const char *drive } else if (type == SCSI_TAPE_PERIPHERAL) { - snprintfW( dataW, sizeof(dataW)/sizeof(*dataW), tapeW, tape_no++ ); + snprintfW( dataW, ARRAY_SIZE( dataW ), tapeW, tape_no++ ); RegSetValueExW( lun_key, devnameW, 0, REG_SZ, (const BYTE *)dataW, strlenW( dataW ) ); }

1 0

Michael Stefaniuc : winetest: Remove superfluous cast to self.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: 8576d5ad84f6360896858998bd6ba697e8c218a2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8576d5ad84f6360896858998… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Wed Dec 11 20:30:15 2019 +0100 winetest: Remove superfluous cast to self. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winetest/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 60cb49d139..9d6a318e9c 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -202,7 +202,7 @@ static BOOL running_on_visible_desktop (void) HWINSTA wstation; USEROBJECTFLAGS uoflags; - wstation = (HWINSTA)pGetProcessWindowStation(); + wstation = pGetProcessWindowStation(); assert(pGetUserObjectInformationA(wstation, UOI_FLAGS, &uoflags, sizeof(uoflags), &len)); return (uoflags.dwFlags & WSF_VISIBLE) != 0; }

1 0

Bernat Arlandis : dinput: Log effect directions, and use effective flags.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: 5d07cdf54f576cf0c235ea6ba90756c849f5ac60 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5d07cdf54f576cf0c235ea6b… Author: Bernat Arlandis <berarma(a)hotmail.com> Date: Wed Dec 11 09:28:26 2019 -0600 dinput: Log effect directions, and use effective flags. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/effect_linuxinput.c | 4 ++-- dlls/dinput/joystick.c | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/dinput/effect_linuxinput.c b/dlls/dinput/effect_linuxinput.c index 4b2f317ce3..cc2df3ce87 100644 --- a/dlls/dinput/effect_linuxinput.c +++ b/dlls/dinput/effect_linuxinput.c @@ -489,8 +489,6 @@ static HRESULT WINAPI LinuxInputEffectImpl_SetParameters( TRACE("(this=%p,%p,%d)\n", This, peff, dwFlags); - dump_DIEFFECT(peff, &This->guid, dwFlags); - if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | @@ -498,6 +496,8 @@ static HRESULT WINAPI LinuxInputEffectImpl_SetParameters( DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; } + dump_DIEFFECT(peff, &This->guid, dwFlags); + if (dwFlags & DIEP_AXES) { /* the linux input effect system only supports one or two axes */ if (peff->cAxes > 2) diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c index 2220b5d576..01611b0e44 100644 --- a/dlls/dinput/joystick.c +++ b/dlls/dinput/joystick.c @@ -207,6 +207,12 @@ void dump_DIEFFECT(LPCDIEFFECT eff, REFGUID guid, DWORD dwFlags) TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - rglDirection: %p\n", eff->rglDirection); + if (dwFlags & DIEP_DIRECTION) { + TRACE(" "); + for (i = 0; i < eff->cAxes; ++i) + TRACE("%d ", eff->rglDirection[i]); + TRACE("\n"); + } TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams);

1 0

Biswapriyo Nath : include: Update d3d9caps.h header file.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: 7157160865874344c330c936697942d2e8bca2f3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7157160865874344c330c936… Author: Biswapriyo Nath <nathbappai(a)gmail.com> Date: Wed Dec 11 07:18:00 2019 +0530 include: Update d3d9caps.h header file. Signed-off-by: Biswapriyo Nath <nathbappai(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d3d9caps.h | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/include/d3d9caps.h b/include/d3d9caps.h index feee0d4ce5..1068a2c35a 100644 --- a/include/d3d9caps.h +++ b/include/d3d9caps.h @@ -407,6 +407,49 @@ typedef struct _D3DCAPS9 { } D3DCAPS9; +#ifndef D3D_DISABLE_9EX + +#define D3DOVERLAYCAPS_FULLRANGERGB 0x00000001 +#define D3DOVERLAYCAPS_LIMITEDRANGERGB 0x00000002 +#define D3DOVERLAYCAPS_YCbCr_BT601 0x00000004 +#define D3DOVERLAYCAPS_YCbCr_BT709 0x00000008 +#define D3DOVERLAYCAPS_YCbCr_BT601_xvYCC 0x00000010 +#define D3DOVERLAYCAPS_YCbCr_BT709_xvYCC 0x00000020 +#define D3DOVERLAYCAPS_STRETCHX 0x00000040 +#define D3DOVERLAYCAPS_STRETCHY 0x00000080 + +typedef struct _D3DOVERLAYCAPS { + UINT Caps; + UINT MaxOverlayDisplayWidth; + UINT MaxOverlayDisplayHeight; +} D3DOVERLAYCAPS; + +#define D3DCPCAPS_SOFTWARE 0x00000001 +#define D3DCPCAPS_HARDWARE 0x00000002 +#define D3DCPCAPS_PROTECTIONALWAYSON 0x00000004 +#define D3DCPCAPS_PARTIALDECRYPTION 0x00000008 +#define D3DCPCAPS_CONTENTKEY 0x00000010 +#define D3DCPCAPS_FRESHENSESSIONKEY 0x00000020 +#define D3DCPCAPS_ENCRYPTEDREADBACK 0x00000040 +#define D3DCPCAPS_ENCRYPTEDREADBACKKEY 0x00000080 +#define D3DCPCAPS_SEQUENTIAL_CTR_IV 0x00000100 +#define D3DCPCAPS_ENCRYPTSLICEDATAONLY 0x00000200 + +typedef struct _D3DCONTENTPROTECTIONCAPS { + DWORD Caps; + GUID KeyExchangeType; + UINT BufferAlignmentStart; + UINT BlockAlignmentSize; + ULONGLONG ProtectedMemorySize; +} D3DCONTENTPROTECTIONCAPS; + +DEFINE_GUID(D3DCRYPTOTYPE_AES128_CTR, 0x9b6bd711, 0x4f74, 0x41c9, 0x9e, 0x7b, 0xb, 0xe2, 0xd7, 0xd9, 0x3b, 0x4f); +DEFINE_GUID(D3DCRYPTOTYPE_PROPRIETARY, 0xab4e9afd, 0x1d1c, 0x46e6, 0xa7, 0x2f, 0x8, 0x69, 0x91, 0x7b, 0xd, 0xe8); +DEFINE_GUID(D3DKEYEXCHANGE_RSAES_OAEP, 0xc1949895, 0xd72a, 0x4a1d, 0x8e, 0x5d, 0xed, 0x85, 0x7d, 0x17, 0x15, 0x20); +DEFINE_GUID(D3DKEYEXCHANGE_DXVA, 0x43d3775c, 0x38e5, 0x4924, 0x8d, 0x86, 0xd3, 0xfc, 0xcf, 0x15, 0x3e, 0x9b); + +#endif + #ifdef __i386__ #include <poppack.h> #endif

1 0

Hans Leidekker : msado15: Implement Field_put_Type, Field_put_DefinedSize and Field_put_Attributes.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: c5f82e3903f172e5334dc0cdd7536ae5deb2c9c8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c5f82e3903f172e5334dc0cd… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Dec 11 17:18:29 2019 +0100 msado15: Implement Field_put_Type, Field_put_DefinedSize and Field_put_Attributes. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msado15/recordset.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c index 99d22e4db0..78d13d1577 100644 --- a/dlls/msado15/recordset.c +++ b/dlls/msado15/recordset.c @@ -54,6 +54,9 @@ struct field Field Field_iface; LONG refs; WCHAR *name; + DataTypeEnum type; + LONG defined_size; + LONG attrs; LONG index; struct recordset *recordset; }; @@ -240,20 +243,32 @@ static HRESULT WINAPI field_put_NumericScale( Field *iface, unsigned char scale static HRESULT WINAPI field_put_Type( Field *iface, DataTypeEnum type ) { - FIXME( "%p, %u\n", iface, type ); - return E_NOTIMPL; + struct field *field = impl_from_Field( iface ); + + TRACE( "%p, %u\n", field, type ); + + field->type = type; + return S_OK; } static HRESULT WINAPI field_put_DefinedSize( Field *iface, LONG size ) { - FIXME( "%p, %d\n", iface, size ); - return E_NOTIMPL; + struct field *field = impl_from_Field( iface ); + + TRACE( "%p, %d\n", field, size ); + + field->defined_size = size; + return S_OK; } static HRESULT WINAPI field_put_Attributes( Field *iface, LONG attrs ) { - FIXME( "%p, %d\n", iface, attrs ); - return E_NOTIMPL; + struct field *field = impl_from_Field( iface ); + + TRACE( "%p, %d\n", field, attrs ); + + field->attrs = attrs; + return S_OK; } static HRESULT WINAPI field_get_Status( Field *iface, LONG *status )

1 0

Hans Leidekker : msado15: Implement Fields_get_Count.
by Alexandre Julliard 11 Dec '19

11 Dec '19

Module: wine Branch: master Commit: a5939587c92c16c5a0eb0e144c434b2ae75f8e10 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a5939587c92c16c5a0eb0e14… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Dec 11 17:18:28 2019 +0100 msado15: Implement Fields_get_Count. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msado15/recordset.c | 8 ++++++-- dlls/msado15/tests/msado15.c | 48 ++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 52 insertions(+), 4 deletions(-) diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c index ed3cdf6bbf..99d22e4db0 100644 --- a/dlls/msado15/recordset.c +++ b/dlls/msado15/recordset.c @@ -388,8 +388,12 @@ static HRESULT WINAPI fields_Invoke( Fields *iface, DISPID member, REFIID riid, static HRESULT WINAPI fields_get_Count( Fields *iface, LONG *count ) { - FIXME( "%p, %p\n", iface, count ); - return E_NOTIMPL; + struct fields *fields = impl_from_Fields( iface ); + + TRACE( "%p, %p\n", fields, count ); + + *count = fields->count; + return S_OK; } static HRESULT WINAPI fields__NewEnum( Fields *iface, IUnknown **obj ) diff --git a/dlls/msado15/tests/msado15.c b/dlls/msado15/tests/msado15.c index e6371b8392..4ef4762ac6 100644 --- a/dlls/msado15/tests/msado15.c +++ b/dlls/msado15/tests/msado15.c @@ -77,8 +77,8 @@ static void test_Recordset(void) count = -1; hr = Fields_get_Count( fields2, &count ); - todo_wine ok( hr == S_OK, "got %08x\n", hr ); - todo_wine ok( !count, "got %d\n", count ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( !count, "got %d\n", count ); refs = _Recordset_Release( recordset ); ok( !refs, "got %d\n", refs ); @@ -88,6 +88,49 @@ static void test_Recordset(void) ok( refs == 1, "got %d\n", refs ); } +static void test_Fields(void) +{ + _Recordset *recordset; + Fields *fields; + VARIANT val; + BSTR name; + LONG count; + HRESULT hr; + + hr = CoCreateInstance( &CLSID_Recordset, NULL, CLSCTX_INPROC_SERVER, &IID__Recordset, (void **)&recordset ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = _Recordset_get_Fields( recordset, &fields ); + ok( hr == S_OK, "got %08x\n", hr ); + + count = -1; + hr = Fields_get_Count( fields, &count ); + ok( !count, "got %d\n", count ); + + name = SysAllocString( L"field" ); + V_VT( &val ) = VT_ERROR; + V_ERROR( &val ) = DISP_E_PARAMNOTFOUND; + hr = Fields_Append( fields, name, adInteger, 4, adFldUnspecified, val ); + ok( hr == S_OK, "got %08x\n", hr ); + SysFreeString( name ); + + count = -1; + hr = Fields_get_Count( fields, &count ); + ok( count == 1, "got %d\n", count ); + + name = SysAllocString( L"field2" ); + hr = Fields__Append( fields, name, adInteger, 4, adFldUnspecified ); + ok( hr == S_OK, "got %08x\n", hr ); + SysFreeString( name ); + + count = -1; + hr = Fields_get_Count( fields, &count ); + ok( count == 2, "got %d\n", count ); + + Fields_Release( fields ); + _Recordset_Release( recordset ); +} + static HRESULT str_to_byte_array( const char *data, VARIANT *ret ) { SAFEARRAY *vector; @@ -406,6 +449,7 @@ START_TEST(msado15) { CoInitialize( NULL ); test_Connection(); + test_Fields(); test_Recordset(); test_Stream(); CoUninitialize();

1 0