June 2019 - Wine-commits - list.winehq.org

Zebediah Figura : qcap/avico: Use BaseFilterImpl_QueryFilterInfo().
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: ca77a7e0c16b9ae2e2dfc440fbae234a9fe99412 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ca77a7e0c16b9ae2e2dfc440… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:22:55 2019 -0400 qcap/avico: Use BaseFilterImpl_QueryFilterInfo(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qcap/avico.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/dlls/qcap/avico.c b/dlls/qcap/avico.c index 40bc82b..6ebe0fd 100644 --- a/dlls/qcap/avico.c +++ b/dlls/qcap/avico.c @@ -160,13 +160,6 @@ static HRESULT WINAPI AVICompressor_Run(IBaseFilter *iface, REFERENCE_TIME tStar return S_OK; } -static HRESULT WINAPI AVICompressor_QueryFilterInfo(IBaseFilter *iface, FILTER_INFO *pInfo) -{ - AVICompressor *This = impl_from_IBaseFilter(iface); - FIXME("(%p)->(%p)\n", This, pInfo); - return E_NOTIMPL; -} - static HRESULT WINAPI AVICompressor_QueryVendorInfo(IBaseFilter *iface, LPWSTR *pVendorInfo) { AVICompressor *This = impl_from_IBaseFilter(iface); @@ -187,7 +180,7 @@ static const IBaseFilterVtbl AVICompressorVtbl = { BaseFilterImpl_GetSyncSource, BaseFilterImpl_EnumPins, BaseFilterImpl_FindPin, - AVICompressor_QueryFilterInfo, + BaseFilterImpl_QueryFilterInfo, BaseFilterImpl_JoinFilterGraph, AVICompressor_QueryVendorInfo };

1 0

Zebediah Figura : qcap/avico: Use BaseFilterImpl_QueryVendorInfo().
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: eab720d35d794c58625bfccc586035c57fb14822 URL: https://source.winehq.org/git/wine.git/?a=commit;h=eab720d35d794c58625bfccc… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:22:56 2019 -0400 qcap/avico: Use BaseFilterImpl_QueryVendorInfo(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qcap/avico.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/dlls/qcap/avico.c b/dlls/qcap/avico.c index 6ebe0fd..684a332 100644 --- a/dlls/qcap/avico.c +++ b/dlls/qcap/avico.c @@ -160,13 +160,6 @@ static HRESULT WINAPI AVICompressor_Run(IBaseFilter *iface, REFERENCE_TIME tStar return S_OK; } -static HRESULT WINAPI AVICompressor_QueryVendorInfo(IBaseFilter *iface, LPWSTR *pVendorInfo) -{ - AVICompressor *This = impl_from_IBaseFilter(iface); - FIXME("(%p)->(%p)\n", This, pVendorInfo); - return E_NOTIMPL; -} - static const IBaseFilterVtbl AVICompressorVtbl = { BaseFilterImpl_QueryInterface, BaseFilterImpl_AddRef, @@ -182,7 +175,7 @@ static const IBaseFilterVtbl AVICompressorVtbl = { BaseFilterImpl_FindPin, BaseFilterImpl_QueryFilterInfo, BaseFilterImpl_JoinFilterGraph, - AVICompressor_QueryVendorInfo + BaseFilterImpl_QueryVendorInfo, }; static IPin *avi_compressor_get_pin(BaseFilter *iface, unsigned int index)

1 0

Zebediah Figura : hidclass.sys: Use PDRIVER_ADD_DEVICE.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 700633ee0ff65a73bb6383b4e9796b5b54bb2d4b URL: https://source.winehq.org/git/wine.git/?a=commit;h=700633ee0ff65a73bb6383b4… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:12:49 2019 -0400 hidclass.sys: Use PDRIVER_ADD_DEVICE. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hidclass.sys/hid.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h index ff2e7ef..b9bf135 100644 --- a/dlls/hidclass.sys/hid.h +++ b/dlls/hidclass.sys/hid.h @@ -34,8 +34,6 @@ #define DEFAULT_POLL_INTERVAL 200 #define MAX_POLL_INTERVAL_MSEC 10000 -typedef NTSTATUS (WINAPI *pAddDevice)(DRIVER_OBJECT *DriverObject, DEVICE_OBJECT *PhysicalDeviceObject); - /* Ring buffer functions */ struct ReportRingBuffer; @@ -85,7 +83,7 @@ typedef struct _minidriver PDRIVER_UNLOAD DriverUnload; - pAddDevice AddDevice; + PDRIVER_ADD_DEVICE AddDevice; PDRIVER_DISPATCH PNPDispatch; struct list device_list; } minidriver;

1 0

Zebediah Figura : hidclass.sys: Get rid of unused minidriver parameter to HID_DeleteDevice().
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 3d011fcdffe39ae856cbb0915938fe158b60742a URL: https://source.winehq.org/git/wine.git/?a=commit;h=3d011fcdffe39ae856cbb091… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:12:50 2019 -0400 hidclass.sys: Get rid of unused minidriver parameter to HID_DeleteDevice(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hidclass.sys/device.c | 3 +-- dlls/hidclass.sys/hid.h | 2 +- dlls/hidclass.sys/pnp.c | 14 +++++++------- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c index 93187b5..e961772 100644 --- a/dlls/hidclass.sys/device.c +++ b/dlls/hidclass.sys/device.c @@ -174,8 +174,7 @@ static void WINAPI read_cancel_routine(DEVICE_OBJECT *device, IRP *irp) IoCompleteRequest(irp, IO_NO_INCREMENT); } - -void HID_DeleteDevice(HID_MINIDRIVER_REGISTRATION *driver, DEVICE_OBJECT *device) +void HID_DeleteDevice(DEVICE_OBJECT *device) { BASE_DEVICE_EXTENSION *ext; IRP *irp; diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h index b9bf135..0f82323 100644 --- a/dlls/hidclass.sys/hid.h +++ b/dlls/hidclass.sys/hid.h @@ -94,7 +94,7 @@ minidriver* find_minidriver(DRIVER_OBJECT* driver) DECLSPEC_HIDDEN; /* Internal device functions */ NTSTATUS HID_CreateDevice(DEVICE_OBJECT *native_device, HID_MINIDRIVER_REGISTRATION *driver, DEVICE_OBJECT **device) DECLSPEC_HIDDEN; NTSTATUS HID_LinkDevice(DEVICE_OBJECT *device) DECLSPEC_HIDDEN; -void HID_DeleteDevice(HID_MINIDRIVER_REGISTRATION *driver, DEVICE_OBJECT *device) DECLSPEC_HIDDEN; +void HID_DeleteDevice(DEVICE_OBJECT *device) DECLSPEC_HIDDEN; void HID_StartDeviceThread(DEVICE_OBJECT *device) DECLSPEC_HIDDEN; NTSTATUS WINAPI HID_Device_ioctl(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; diff --git a/dlls/hidclass.sys/pnp.c b/dlls/hidclass.sys/pnp.c index 826ade9..8265efd 100644 --- a/dlls/hidclass.sys/pnp.c +++ b/dlls/hidclass.sys/pnp.c @@ -122,7 +122,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO) if (status != STATUS_SUCCESS) { ERR("Minidriver AddDevice failed (%x)\n",status); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); return status; } @@ -132,7 +132,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO) if (status != STATUS_SUCCESS) { ERR("Minidriver failed to get Attributes(%x)\n",status); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); return status; } @@ -146,7 +146,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO) if (status != STATUS_SUCCESS) { ERR("Cannot get Device Descriptor(%x)\n",status); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); return status; } for (i = 0; i < descriptor.bNumDescriptors; i++) @@ -156,7 +156,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO) if (i >= descriptor.bNumDescriptors) { ERR("No Report Descriptor found in reply\n"); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); return status; } @@ -166,7 +166,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO) if (status != STATUS_SUCCESS) { ERR("Cannot get Report Descriptor(%x)\n",status); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); HeapFree(GetProcessHeap(), 0, reportDescriptor); return status; } @@ -177,7 +177,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO) if (!ext->preparseData) { ERR("Cannot parse Report Descriptor\n"); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); return STATUS_NOT_SUPPORTED; } @@ -217,7 +217,7 @@ NTSTATUS PNP_RemoveDevice(minidriver *minidriver, DEVICE_OBJECT *device, IRP *ir if (irp) rc = minidriver->PNPDispatch(device, irp); - HID_DeleteDevice(&minidriver->minidriver, device); + HID_DeleteDevice(device); LIST_FOR_EACH_ENTRY(hiddev, &minidriver->device_list, hid_device, entry) { if (hiddev->device == device)

1 0

Zebediah Figura : ntoskrnl.exe: Dispatch user IRPs to the top of the device stack.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 4820d9d76ca2dba20c264354f776ed6633df0817 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4820d9d76ca2dba20c264354… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:12:51 2019 -0400 ntoskrnl.exe: Dispatch user IRPs to the top of the device stack. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/ntoskrnl.c | 12 ++++++----- dlls/ntoskrnl.exe/tests/driver.c | 44 ++++++++++++++++++++++++++++++-------- dlls/ntoskrnl.exe/tests/driver.h | 1 + dlls/ntoskrnl.exe/tests/ntoskrnl.c | 11 ++++++++-- include/ddk/ntifs.h | 1 + 5 files changed, 53 insertions(+), 16 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index cf4d8cb..ec24e08 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -516,6 +516,8 @@ static NTSTATUS dispatch_create( struct dispatch_context *context ) file->Size = sizeof(*file); file->DeviceObject = device; + device = IoGetAttachedDevice( device ); + if (!(irp = IoAllocateIrp( device->StackSize, FALSE ))) return STATUS_NO_MEMORY; irpsp = IoGetNextIrpStackLocation( irp ); @@ -550,7 +552,7 @@ static NTSTATUS dispatch_close( struct dispatch_context *context ) if (!file) return STATUS_INVALID_HANDLE; - device = file->DeviceObject; + device = IoGetAttachedDevice( file->DeviceObject ); TRACE( "device %p file %p\n", device, file ); @@ -590,7 +592,7 @@ static NTSTATUS dispatch_read( struct dispatch_context *context ) if (!file) return STATUS_INVALID_HANDLE; - device = file->DeviceObject; + device = IoGetAttachedDevice( file->DeviceObject ); TRACE( "device %p file %p size %u\n", device, file, out_size ); @@ -630,7 +632,7 @@ static NTSTATUS dispatch_write( struct dispatch_context *context ) if (!file) return STATUS_INVALID_HANDLE; - device = file->DeviceObject; + device = IoGetAttachedDevice( file->DeviceObject ); TRACE( "device %p file %p size %u\n", device, file, context->in_size ); @@ -665,7 +667,7 @@ static NTSTATUS dispatch_flush( struct dispatch_context *context ) if (!file) return STATUS_INVALID_HANDLE; - device = file->DeviceObject; + device = IoGetAttachedDevice( file->DeviceObject ); TRACE( "device %p file %p\n", device, file ); @@ -697,7 +699,7 @@ static NTSTATUS dispatch_ioctl( struct dispatch_context *context ) if (!file) return STATUS_INVALID_HANDLE; - device = file->DeviceObject; + device = IoGetAttachedDevice( file->DeviceObject ); TRACE( "ioctl %x device %p file %p in_size %u out_size %u\n", context->params.ioctl.code, device, file, context->in_size, out_size ); diff --git a/dlls/ntoskrnl.exe/tests/driver.c b/dlls/ntoskrnl.exe/tests/driver.c index 468b183..f5801a5 100644 --- a/dlls/ntoskrnl.exe/tests/driver.c +++ b/dlls/ntoskrnl.exe/tests/driver.c @@ -34,12 +34,15 @@ #include "driver.h" -static const WCHAR driver_device[] = {'\\','D','e','v','i','c','e', - '\\','W','i','n','e','T','e','s','t','D','r','i','v','e','r',0}; +static const WCHAR device_name[] = {'\\','D','e','v','i','c','e', + '\\','W','i','n','e','T','e','s','t','D','r','i','v','e','r',0}; +static const WCHAR upper_name[] = {'\\','D','e','v','i','c','e', + '\\','W','i','n','e','T','e','s','t','U','p','p','e','r',0}; static const WCHAR driver_link[] = {'\\','D','o','s','D','e','v','i','c','e','s', '\\','W','i','n','e','T','e','s','t','D','r','i','v','e','r',0}; static DRIVER_OBJECT *driver_obj; +static DEVICE_OBJECT *lower_device, *upper_device; static HANDLE okfile; static LONG successes; @@ -234,10 +237,11 @@ static void test_irp_struct(IRP *irp, DEVICE_OBJECT *device) { IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation( irp ); + ok(device == upper_device, "Expected device %p, got %p.\n", upper_device, device); ok(last_created_file != NULL, "last_created_file = NULL\n"); ok(irpsp->FileObject == last_created_file, "FileObject != last_created_file\n"); - ok(irpsp->DeviceObject == device, "unexpected DeviceObject\n"); - ok(irpsp->FileObject->DeviceObject == device, "unexpected FileObject->DeviceObject\n"); + ok(irpsp->DeviceObject == upper_device, "unexpected DeviceObject\n"); + ok(irpsp->FileObject->DeviceObject == lower_device, "unexpected FileObject->DeviceObject\n"); ok(!irp->UserEvent, "UserEvent = %p\n", irp->UserEvent); ok(irp->Tail.Overlay.Thread == (PETHREAD)KeGetCurrentThread(), "IRP thread is not the current thread\n"); @@ -1591,7 +1595,7 @@ static NTSTATUS main_test(DEVICE_OBJECT *device, IRP *irp, IO_STACK_LOCATION *st if (main_test_work_item) return STATUS_UNEXPECTED_IO_ERROR; - main_test_work_item = IoAllocateWorkItem(device); + main_test_work_item = IoAllocateWorkItem(lower_device); ok(main_test_work_item != NULL, "main_test_work_item = NULL\n"); IoQueueWorkItem(main_test_work_item, main_test_task, DelayedWorkQueue, irp); @@ -1687,6 +1691,10 @@ static NTSTATUS WINAPI driver_IoControl(DEVICE_OBJECT *device, IRP *irp) case IOCTL_WINETEST_GET_CANCEL_COUNT: status = get_cancel_count(irp, stack, &irp->IoStatus.Information); break; + case IOCTL_WINETEST_DETACH: + IoDetachDevice(lower_device); + status = STATUS_SUCCESS; + break; default: break; } @@ -1703,6 +1711,7 @@ static NTSTATUS WINAPI driver_IoControl(DEVICE_OBJECT *device, IRP *irp) static NTSTATUS WINAPI driver_FlushBuffers(DEVICE_OBJECT *device, IRP *irp) { IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation(irp); + ok(device == lower_device, "Expected device %p, got %p.\n", lower_device, device); ok(irpsp->DeviceObject == device, "device != DeviceObject\n"); ok(irp->Tail.Overlay.Thread == (PETHREAD)KeGetCurrentThread(), "IRP thread is not the current thread\n"); @@ -1726,13 +1735,13 @@ static VOID WINAPI driver_Unload(DRIVER_OBJECT *driver) RtlInitUnicodeString(&linkW, driver_link); IoDeleteSymbolicLink(&linkW); - IoDeleteDevice(driver->DeviceObject); + IoDeleteDevice(upper_device); + IoDeleteDevice(lower_device); } NTSTATUS WINAPI DriverEntry(DRIVER_OBJECT *driver, PUNICODE_STRING registry) { UNICODE_STRING nameW, linkW; - DEVICE_OBJECT *device; NTSTATUS status; DbgPrint("loading driver\n"); @@ -1748,12 +1757,29 @@ NTSTATUS WINAPI DriverEntry(DRIVER_OBJECT *driver, PUNICODE_STRING registry) driver->MajorFunction[IRP_MJ_FLUSH_BUFFERS] = driver_FlushBuffers; driver->MajorFunction[IRP_MJ_CLOSE] = driver_Close; - RtlInitUnicodeString(&nameW, driver_device); + RtlInitUnicodeString(&nameW, device_name); RtlInitUnicodeString(&linkW, driver_link); if (!(status = IoCreateDevice(driver, 0, &nameW, FILE_DEVICE_UNKNOWN, - FILE_DEVICE_SECURE_OPEN, FALSE, &device))) + FILE_DEVICE_SECURE_OPEN, FALSE, &lower_device))) + { status = IoCreateSymbolicLink(&linkW, &nameW); + lower_device->Flags &= ~DO_DEVICE_INITIALIZING; + } + + if (!status) + { + RtlInitUnicodeString(&nameW, upper_name); + + status = IoCreateDevice(driver, 0, &nameW, FILE_DEVICE_UNKNOWN, + FILE_DEVICE_SECURE_OPEN, FALSE, &upper_device); + } + + if (!status) + { + IoAttachDeviceToDeviceStack(upper_device, lower_device); + upper_device->Flags &= ~DO_DEVICE_INITIALIZING; + } return status; } diff --git a/dlls/ntoskrnl.exe/tests/driver.h b/dlls/ntoskrnl.exe/tests/driver.h index 1e75529..d5ff09a 100644 --- a/dlls/ntoskrnl.exe/tests/driver.h +++ b/dlls/ntoskrnl.exe/tests/driver.h @@ -28,6 +28,7 @@ #define IOCTL_WINETEST_RESET_CANCEL CTL_CODE(FILE_DEVICE_UNKNOWN, 0x803, METHOD_BUFFERED, FILE_ANY_ACCESS) #define IOCTL_WINETEST_TEST_CANCEL CTL_CODE(FILE_DEVICE_UNKNOWN, 0x804, METHOD_BUFFERED, FILE_ANY_ACCESS) #define IOCTL_WINETEST_GET_CANCEL_COUNT CTL_CODE(FILE_DEVICE_UNKNOWN, 0x805, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define IOCTL_WINETEST_DETACH CTL_CODE(FILE_DEVICE_UNKNOWN, 0x806, METHOD_BUFFERED, FILE_ANY_ACCESS) static const char teststr[] = "Wine is not an emulator"; diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c index 43418f3..19eeca2 100644 --- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c @@ -63,8 +63,6 @@ static void unload_driver(SC_HANDLE service) { SERVICE_STATUS status; - CloseHandle(device); - ControlService(service, SERVICE_CONTROL_STOP, &status); while (status.dwCurrentState == SERVICE_STOP_PENDING) { @@ -343,6 +341,8 @@ START_TEST(ntoskrnl) { char filename[MAX_PATH], filename2[MAX_PATH]; SC_HANDLE service, service2; + DWORD written; + BOOL ret; HMODULE hntdll = GetModuleHandleA("ntdll.dll"); pRtlDosPathNameToNtPathName_U = (void *)GetProcAddress(hntdll, "RtlDosPathNameToNtPathName_U"); @@ -368,6 +368,13 @@ START_TEST(ntoskrnl) test_overlapped(); test_load_driver(service2); + /* We need a separate ioctl to call IoDetachDevice(); calling it in the + * driver unload routine causes a live-lock. */ + ret = DeviceIoControl(device, IOCTL_WINETEST_DETACH, NULL, 0, NULL, 0, &written, NULL); + ok(ret, "DeviceIoControl failed: %u\n", GetLastError()); + + CloseHandle(device); + unload_driver(service2); unload_driver(service); ok(DeleteFileA(filename), "DeleteFile failed: %u\n", GetLastError()); diff --git a/include/ddk/ntifs.h b/include/ddk/ntifs.h index acdd232..b287b06 100644 --- a/include/ddk/ntifs.h +++ b/include/ddk/ntifs.h @@ -130,6 +130,7 @@ typedef struct _FS_FILTER_CALLBACKS } FS_FILTER_CALLBACKS, *PFS_FILTER_CALLBACKS; BOOLEAN WINAPI FsRtlIsNameInExpression(PUNICODE_STRING, PUNICODE_STRING, BOOLEAN, PWCH); +DEVICE_OBJECT * WINAPI IoGetAttachedDevice(DEVICE_OBJECT*); NTSTATUS WINAPI ObOpenObjectByPointer(void*,ULONG,PACCESS_STATE,ACCESS_MASK,POBJECT_TYPE,KPROCESSOR_MODE,HANDLE*); NTSTATUS WINAPI ObQueryNameString(PVOID,POBJECT_NAME_INFORMATION,ULONG,PULONG); BOOLEAN WINAPI PsIsSystemThread(PETHREAD);

1 0

Zebediah Figura : ntoskrnl.exe: Send PnP IRPs to the top of the device stack.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 9392aaa17fa029a05dbae780b0b85644ec72a1ad URL: https://source.winehq.org/git/wine.git/?a=commit;h=9392aaa17fa029a05dbae780… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:12:52 2019 -0400 ntoskrnl.exe: Send PnP IRPs to the top of the device stack. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/pnp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/ntoskrnl.exe/pnp.c b/dlls/ntoskrnl.exe/pnp.c index 20e1538..e7303b6 100644 --- a/dlls/ntoskrnl.exe/pnp.c +++ b/dlls/ntoskrnl.exe/pnp.c @@ -176,6 +176,8 @@ static NTSTATUS get_device_id( DEVICE_OBJECT *device, BUS_QUERY_ID_TYPE type, WC IO_STATUS_BLOCK irp_status; IRP *irp; + device = IoGetAttachedDevice( device ); + if (!(irp = IoBuildSynchronousFsdRequest( IRP_MJ_PNP, device, NULL, 0, NULL, NULL, &irp_status ))) return STATUS_NO_MEMORY; @@ -192,6 +194,8 @@ static NTSTATUS send_pnp_irp( DEVICE_OBJECT *device, UCHAR minor ) IO_STATUS_BLOCK irp_status; IRP *irp; + device = IoGetAttachedDevice( device ); + if (!(irp = IoBuildSynchronousFsdRequest( IRP_MJ_PNP, device, NULL, 0, NULL, NULL, &irp_status ))) return STATUS_NO_MEMORY; @@ -291,6 +295,8 @@ static NTSTATUS send_power_irp( DEVICE_OBJECT *device, DEVICE_POWER_STATE power IO_STACK_LOCATION *irpsp; IRP *irp; + device = IoGetAttachedDevice( device ); + if (!(irp = IoBuildSynchronousFsdRequest( IRP_MJ_POWER, device, NULL, 0, NULL, NULL, &irp_status ))) return STATUS_NO_MEMORY;

1 0

Zebediah Figura : ntoskrnl.exe: Implement automatically generated device names.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 365f162fb1443d201177eec31f009a59b061e853 URL: https://source.winehq.org/git/wine.git/?a=commit;h=365f162fb1443d201177eec3… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jun 6 11:12:53 2019 -0400 ntoskrnl.exe: Implement automatically generated device names. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/ntoskrnl.c | 36 +++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index ec24e08..a0812dc 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1466,9 +1466,12 @@ NTSTATUS WINAPI IoCreateDevice( DRIVER_OBJECT *driver, ULONG ext_size, ULONG characteristics, BOOLEAN exclusive, DEVICE_OBJECT **ret_device ) { + static const WCHAR auto_format[] = {'\\','D','e','v','i','c','e','\\','%','0','8','x',0}; NTSTATUS status; DEVICE_OBJECT *device; HANDLE manager = get_device_manager(); + static unsigned int auto_idx = 0; + WCHAR autoW[17]; TRACE( "(%p, %u, %s, %u, %x, %u, %p)\n", driver, ext_size, debugstr_us(name), type, characteristics, exclusive, ret_device ); @@ -1481,15 +1484,34 @@ NTSTATUS WINAPI IoCreateDevice( DRIVER_OBJECT *driver, ULONG ext_size, device->DeviceType = type; device->StackSize = 1; - SERVER_START_REQ( create_device ) + if (characteristics & FILE_AUTOGENERATED_DEVICE_NAME) { - req->rootdir = 0; - req->manager = wine_server_obj_handle( manager ); - req->user_ptr = wine_server_client_ptr( device ); - if (name) wine_server_add_data( req, name->Buffer, name->Length ); - status = wine_server_call( req ); + do + { + sprintfW( autoW, auto_format, auto_idx++ ); + SERVER_START_REQ( create_device ) + { + req->rootdir = 0; + req->manager = wine_server_obj_handle( manager ); + req->user_ptr = wine_server_client_ptr( device ); + wine_server_add_data( req, autoW, strlenW(autoW) * sizeof(WCHAR) ); + status = wine_server_call( req ); + } + SERVER_END_REQ; + } while (status == STATUS_OBJECT_NAME_COLLISION); + } + else + { + SERVER_START_REQ( create_device ) + { + req->rootdir = 0; + req->manager = wine_server_obj_handle( manager ); + req->user_ptr = wine_server_client_ptr( device ); + if (name) wine_server_add_data( req, name->Buffer, name->Length ); + status = wine_server_call( req ); + } + SERVER_END_REQ; } - SERVER_END_REQ; if (status) {

1 0

Andrey Gusev : quartz: Avoid cast for VMR9_ImagePresenter_QueryInterface.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: e87322e9d40b8a5184919a1d1010b138f018ff84 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e87322e9d40b8a5184919a1d… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Thu Jun 6 13:40:02 2019 +0300 quartz: Avoid cast for VMR9_ImagePresenter_QueryInterface. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/vmr9.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index d208b1c..751eeeb 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -2326,16 +2326,14 @@ HRESULT VMR9Impl_create(IUnknown *outer_unk, LPVOID *ppv) } -static HRESULT WINAPI VMR9_ImagePresenter_QueryInterface(IVMRImagePresenter9 *iface, REFIID riid, LPVOID * ppv) +static HRESULT WINAPI VMR9_ImagePresenter_QueryInterface(IVMRImagePresenter9 *iface, REFIID riid, void **ppv) { VMR9DefaultAllocatorPresenterImpl *This = impl_from_IVMRImagePresenter9(iface); TRACE("(%p/%p)->(%s, %p)\n", This, iface, qzdebugstr_guid(riid), ppv); *ppv = NULL; - if (IsEqualIID(riid, &IID_IUnknown)) - *ppv = (LPVOID)&(This->IVMRImagePresenter9_iface); - else if (IsEqualIID(riid, &IID_IVMRImagePresenter9)) + if (IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IVMRImagePresenter9)) *ppv = &This->IVMRImagePresenter9_iface; else if (IsEqualIID(riid, &IID_IVMRSurfaceAllocatorEx9)) *ppv = &This->IVMRSurfaceAllocatorEx9_iface;

1 0

Alistair Leslie-Hughes : dbghelp: Support S_HEAPALLOCSITE entry.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 48a74277f5f9e0c87d8c01457236a89d94cb71d3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=48a74277f5f9e0c87d8c0145… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Mon Jun 3 23:55:46 2019 +0000 dbghelp: Support S_HEAPALLOCSITE entry. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/msc.c | 5 +++++ include/wine/mscvpdb.h | 10 ++++++++++ 2 files changed, 15 insertions(+) diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c index 54fbe36..4be0cb2 100644 --- a/dlls/dbghelp/msc.c +++ b/dlls/dbghelp/msc.c @@ -2011,6 +2011,11 @@ static BOOL codeview_snarf(const struct msc_debug_info* msc_dbg, const BYTE* roo case S_ALIGN_V1: TRACE("S-Align V1\n"); break; + case S_HEAPALLOCSITE: + TRACE("heap site: offset=0x%08x at sect_idx 0x%04x, inst_len 0x%08x, index 0x%08x\n", + sym->heap_alloc_site.offset, sym->heap_alloc_site.sect_idx, + sym->heap_alloc_site.inst_len, sym->heap_alloc_site.index); + break; /* the symbols we can safely ignore for now */ case S_TRAMPOLINE: diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h index a44331b..2301e80 100644 --- a/include/wine/mscvpdb.h +++ b/include/wine/mscvpdb.h @@ -1644,6 +1644,16 @@ union codeview_symbol unsigned short eh_sect; /* section for exception handler */ unsigned int flags; } frame_info_v2; + + struct + { + unsigned short len; + unsigned short id; + unsigned int offset; + unsigned short sect_idx; + unsigned short inst_len; + unsigned int index; + } heap_alloc_site; }; #define S_COMPILAND_V1 0x0001

1 0

Alexandre Julliard : imagehlp: Build with msvcrt.
by Alexandre Julliard 06 Jun '19

06 Jun '19

Module: wine Branch: master Commit: 4bc3657962b4988c5f63de9d9f1a5229bd837a1e URL: https://source.winehq.org/git/wine.git/?a=commit;h=4bc3657962b4988c5f63de9d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 6 09:00:49 2019 +0200 imagehlp: Build with msvcrt. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/imagehlp/Makefile.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/imagehlp/Makefile.in b/dlls/imagehlp/Makefile.in index e8958d9..0e707a5 100644 --- a/dlls/imagehlp/Makefile.in +++ b/dlls/imagehlp/Makefile.in @@ -3,6 +3,8 @@ MODULE = imagehlp.dll IMPORTLIB = imagehlp IMPORTS = dbghelp +EXTRADLLFLAGS = -mno-cygwin + C_SRCS = \ access.c \ imagehlp_main.c \

1 0