September 2019 - Wine-commits

Alistair Leslie-Hughes : hhctrl.ocx: Simplify extracting the help filename (Coverity).
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: ec83f0c53c8630dcbbf917337c82495aaf0946fb URL: https://source.winehq.org/git/wine.git/?a=commit;h=ec83f0c53c8630dcbbf91733… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Sep 5 00:18:17 2019 +0000 hhctrl.ocx: Simplify extracting the help filename (Coverity). Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hhctrl.ocx/hhctrl.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/dlls/hhctrl.ocx/hhctrl.c b/dlls/hhctrl.ocx/hhctrl.c index 6a98ae4..893cdde 100644 --- a/dlls/hhctrl.ocx/hhctrl.c +++ b/dlls/hhctrl.ocx/hhctrl.c @@ -99,15 +99,12 @@ static const char *command_to_string(UINT command) static BOOL resolve_filename(const WCHAR *env_filename, WCHAR *fullname, DWORD buflen, WCHAR **index, WCHAR **window) { - const WCHAR *extra; - WCHAR chm_file[MAX_PATH]; - static const WCHAR helpW[] = {'\\','h','e','l','p','\\',0}; static const WCHAR delimW[] = {':',':',0}; static const WCHAR delim2W[] = {'>',0}; DWORD env_len; - WCHAR *filename; + WCHAR *filename, *extra; env_filename = skip_schema(env_filename); @@ -128,9 +125,7 @@ static BOOL resolve_filename(const WCHAR *env_filename, WCHAR *fullname, DWORD b extra = wcsstr(filename, delim2W); if (extra) { - memcpy(chm_file, filename, (extra-filename)*sizeof(WCHAR)); - chm_file[extra-filename] = 0; - filename = chm_file; + *extra = 0; if (window) *window = strdupW(extra+1); } @@ -138,10 +133,7 @@ static BOOL resolve_filename(const WCHAR *env_filename, WCHAR *fullname, DWORD b extra = wcsstr(filename, delimW); if (extra) { - if (filename != chm_file) - memcpy(chm_file, filename, (extra-filename)*sizeof(WCHAR)); - chm_file[extra-filename] = 0; - filename = chm_file; + *extra = 0; if (index) *index = strdupW(extra+2); }

1 0

Zebediah Figura : amstream: Reimplement IMemInputPin locally for the primary audio stream.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: 55274438656f43f7e4a34d79bc1b44996a082a25 URL: https://source.winehq.org/git/wine.git/?a=commit;h=55274438656f43f7e4a34d79… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Sep 4 19:43:16 2019 -0500 amstream: Reimplement IMemInputPin locally for the primary audio stream. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/amstream/audiostream.c | 102 ++++++++++++++++++++++++++++++++++++++++- dlls/amstream/tests/amstream.c | 1 + 2 files changed, 102 insertions(+), 1 deletion(-) diff --git a/dlls/amstream/audiostream.c b/dlls/amstream/audiostream.c index 683ab7d..966e1ae 100644 --- a/dlls/amstream/audiostream.c +++ b/dlls/amstream/audiostream.c @@ -175,12 +175,16 @@ struct audio_stream { IAMMediaStream IAMMediaStream_iface; IAudioMediaStream IAudioMediaStream_iface; + IMemInputPin IMemInputPin_iface; LONG ref; + IMultiMediaStream* parent; MSPID purpose_id; STREAM_TYPE stream_type; AudioMediaStreamInputPin *input_pin; CRITICAL_SECTION critical_section; + + IMemAllocator *allocator; }; static inline struct audio_stream *impl_from_IAMMediaStream(IAMMediaStream *iface) @@ -219,7 +223,7 @@ static HRESULT WINAPI AudioMediaStreamImpl_IAMMediaStream_QueryInterface(IAMMedi else if (IsEqualGUID(riid, &IID_IMemInputPin)) { IAMMediaStream_AddRef(iface); - *ret_iface = &This->input_pin->pin.IMemInputPin_iface; + *ret_iface = &This->IMemInputPin_iface; return S_OK; } @@ -794,6 +798,101 @@ static const BaseInputPinFuncTable AudioMediaStreamInputPin_FuncTable = AudioMediaStreamInputPin_Receive, }; +static inline struct audio_stream *impl_from_IMemInputPin(IMemInputPin *iface) +{ + return CONTAINING_RECORD(iface, struct audio_stream, IMemInputPin_iface); +} + +static HRESULT WINAPI audio_meminput_QueryInterface(IMemInputPin *iface, REFIID iid, void **out) +{ + struct audio_stream *stream = impl_from_IMemInputPin(iface); + return IAMMediaStream_QueryInterface(&stream->IAMMediaStream_iface, iid, out); +} + +static ULONG WINAPI audio_meminput_AddRef(IMemInputPin *iface) +{ + struct audio_stream *stream = impl_from_IMemInputPin(iface); + return IAMMediaStream_AddRef(&stream->IAMMediaStream_iface); +} + +static ULONG WINAPI audio_meminput_Release(IMemInputPin *iface) +{ + struct audio_stream *stream = impl_from_IMemInputPin(iface); + return IAMMediaStream_Release(&stream->IAMMediaStream_iface); +} + +static HRESULT WINAPI audio_meminput_GetAllocator(IMemInputPin *iface, IMemAllocator **allocator) +{ + struct audio_stream *stream = impl_from_IMemInputPin(iface); + + TRACE("stream %p, allocator %p.\n", stream, allocator); + + if (stream->allocator) + { + IMemAllocator_AddRef(*allocator = stream->allocator); + return S_OK; + } + + *allocator = NULL; + return VFW_E_NO_ALLOCATOR; +} + +static HRESULT WINAPI audio_meminput_NotifyAllocator(IMemInputPin *iface, IMemAllocator *allocator, BOOL readonly) +{ + struct audio_stream *stream = impl_from_IMemInputPin(iface); + + TRACE("stream %p, allocator %p, readonly %d.\n", stream, allocator, readonly); + + if (!allocator) + return E_POINTER; + + if (allocator) + IMemAllocator_AddRef(allocator); + if (stream->allocator) + IMemAllocator_Release(stream->allocator); + stream->allocator = allocator; + + return S_OK; +} + +static HRESULT WINAPI audio_meminput_GetAllocatorRequirements(IMemInputPin *iface, ALLOCATOR_PROPERTIES *props) +{ + TRACE("iface %p, props %p.\n", iface, props); + return E_NOTIMPL; +} + +static HRESULT WINAPI audio_meminput_Receive(IMemInputPin *iface, IMediaSample *sample) +{ + FIXME("iface %p, sample %p, stub!\n", iface, sample); + return E_NOTIMPL; +} + +static HRESULT WINAPI audio_meminput_ReceiveMultiple(IMemInputPin *iface, + IMediaSample **samples, LONG count, LONG *processed) +{ + FIXME("iface %p, samples %p, count %u, processed %p, stub!\n", iface, samples, count, processed); + return E_NOTIMPL; +} + +static HRESULT WINAPI audio_meminput_ReceiveCanBlock(IMemInputPin *iface) +{ + TRACE("iface %p.\n", iface); + return S_OK; +} + +static const IMemInputPinVtbl audio_meminput_vtbl = +{ + audio_meminput_QueryInterface, + audio_meminput_AddRef, + audio_meminput_Release, + audio_meminput_GetAllocator, + audio_meminput_NotifyAllocator, + audio_meminput_GetAllocatorRequirements, + audio_meminput_Receive, + audio_meminput_ReceiveMultiple, + audio_meminput_ReceiveCanBlock, +}; + HRESULT audiomediastream_create(IMultiMediaStream *parent, const MSPID *purpose_id, IUnknown *stream_object, STREAM_TYPE stream_type, IAMMediaStream **media_stream) { @@ -812,6 +911,7 @@ HRESULT audiomediastream_create(IMultiMediaStream *parent, const MSPID *purpose_ object->IAMMediaStream_iface.lpVtbl = &AudioMediaStreamImpl_IAMMediaStream_Vtbl; object->IAudioMediaStream_iface.lpVtbl = &AudioMediaStreamImpl_IAudioMediaStream_Vtbl; + object->IMemInputPin_iface.lpVtbl = &audio_meminput_vtbl; object->ref = 1; InitializeCriticalSection(&object->critical_section); diff --git a/dlls/amstream/tests/amstream.c b/dlls/amstream/tests/amstream.c index fd192ce..12d7d9b 100644 --- a/dlls/amstream/tests/amstream.c +++ b/dlls/amstream/tests/amstream.c @@ -172,6 +172,7 @@ static void test_interfaces(void) check_interface(stream, &IID_IAMMediaStream, TRUE); check_interface(stream, &IID_IAudioMediaStream, TRUE); check_interface(stream, &IID_IMediaStream, TRUE); + check_interface(stream, &IID_IMemInputPin, TRUE); check_interface(stream, &IID_IPin, TRUE); check_interface(stream, &IID_IUnknown, TRUE);

1 0

Zebediah Figura : amstream: Get rid of the AudioMediaStreamImpl typedef.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: 47105ce35c39c7b1a0873b85e3481e721428c130 URL: https://source.winehq.org/git/wine.git/?a=commit;h=47105ce35c39c7b1a0873b85… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Sep 4 19:43:15 2019 -0500 amstream: Get rid of the AudioMediaStreamImpl typedef. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/amstream/audiostream.c | 69 +++++++++++++++++++++++---------------------- 1 file changed, 35 insertions(+), 34 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=47105ce35c39c7b1a087…

1 0

Zebediah Figura : amstream: Reimplement IPin locally for the primary audio stream.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: 953cf31158926dfc0bf68ab866d5204497bbe8fe URL: https://source.winehq.org/git/wine.git/?a=commit;h=953cf31158926dfc0bf68ab8… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Sep 4 19:43:17 2019 -0500 amstream: Reimplement IPin locally for the primary audio stream. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/amstream/audiostream.c | 318 +++++++++++++++++++++++++++++--------------- 1 file changed, 210 insertions(+), 108 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=953cf31158926dfc0bf6…

1 0

Zebediah Figura : amstream: Use shorter names for primary audio stream methods.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: d49417c081eef7169b145135a73f9d1d43a867c7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d49417c081eef7169b145135… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Sep 4 19:43:18 2019 -0500 amstream: Use shorter names for primary audio stream methods. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/amstream/amstream_private.h | 2 +- dlls/amstream/audiostream.c | 127 +++++++++++++++++++-------------------- dlls/amstream/multimedia.c | 2 +- 3 files changed, 63 insertions(+), 68 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=d49417c081eef7169b14…

1 0

Zebediah Figura : winegstreamer: Use strmbase_source_init().
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: 06d72b61ced162b0c19102fe48d3f38598cd5c0f URL: https://source.winehq.org/git/wine.git/?a=commit;h=06d72b61ced162b0c19102fe… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Sep 4 19:43:19 2019 -0500 winegstreamer: Use strmbase_source_init(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gst_private.h | 1 + dlls/winegstreamer/gstdemux.c | 58 +++++++++++++++++++++------------------- 2 files changed, 31 insertions(+), 28 deletions(-) diff --git a/dlls/winegstreamer/gst_private.h b/dlls/winegstreamer/gst_private.h index 06236e2..18d6eb8 100644 --- a/dlls/winegstreamer/gst_private.h +++ b/dlls/winegstreamer/gst_private.h @@ -30,6 +30,7 @@ #include "winuser.h" #include "dshow.h" #include "strmif.h" +#include "wine/heap.h" #include "wine/strmbase.h" #define MEDIATIME_FROM_BYTES(x) ((LONGLONG)(x) * 10000000) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 9e634bc..aa27a36 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -104,7 +104,7 @@ static const IPinVtbl GST_InputPin_Vtbl; static const IBaseFilterVtbl GST_Vtbl; static const IQualityControlVtbl GSTOutPin_QualityControl_Vtbl; -static HRESULT GST_AddPin(GSTImpl *This, const PIN_INFO *piOutput, const AM_MEDIA_TYPE *amt); +static BOOL create_pin(GSTImpl *filter, const PIN_INFO *pin_info, const AM_MEDIA_TYPE *mt); static HRESULT GST_RemoveOutputPins(GSTImpl *This); static HRESULT WINAPI GST_ChangeCurrent(IMediaSeeking *iface); static HRESULT WINAPI GST_ChangeStop(IMediaSeeking *iface); @@ -825,9 +825,9 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, GSTImpl *This) return; } - hr = GST_AddPin(This, &piOutput, &amt); - if (FAILED(hr)) { - ERR("%08x\n", hr); + if (!create_pin(This, &piOutput, &amt)) + { + ERR("Failed to allocate memory.\n"); return; } @@ -1771,13 +1771,12 @@ static void free_source_pin(GSTOutPin *pin) gst_object_unref(pin->my_sink); CloseHandle(pin->caps_event); DeleteMediaType(pin->pmt); - FreeMediaType(&pin->pin.pin.mtCurrent); gst_segment_free(pin->segment); if (pin->gstpool) gst_object_unref(pin->gstpool); - if (pin->pin.pAllocator) - IMemAllocator_Release(pin->pin.pAllocator); - CoTaskMemFree(pin); + + strmbase_source_cleanup(&pin->pin); + heap_free(pin); } static const IPinVtbl GST_OutputPin_Vtbl = { @@ -1811,27 +1810,30 @@ static const BaseOutputPinFuncTable output_BaseOutputFuncTable = { GSTOutPin_DecideAllocator, }; -static HRESULT GST_AddPin(GSTImpl *This, const PIN_INFO *piOutput, const AM_MEDIA_TYPE *amt) +static BOOL create_pin(GSTImpl *filter, const PIN_INFO *pin_info, const AM_MEDIA_TYPE *mt) { - HRESULT hr; - This->ppPins = CoTaskMemRealloc(This->ppPins, (This->cStreams + 1) * sizeof(IPin *)); - - hr = BaseOutputPin_Construct(&GST_OutputPin_Vtbl, sizeof(GSTOutPin), piOutput, &output_BaseOutputFuncTable, &This->filter.csFilter, (IPin**)(This->ppPins + This->cStreams)); - if (SUCCEEDED(hr)) { - GSTOutPin *pin = This->ppPins[This->cStreams]; - memset((char*)pin + sizeof(pin->pin), 0, sizeof(GSTOutPin) - sizeof(pin->pin)); - pin->pmt = CoTaskMemAlloc(sizeof(AM_MEDIA_TYPE)); - CopyMediaType(pin->pmt, amt); - pin->pin.pin.pinInfo.pFilter = &This->filter.IBaseFilter_iface; - pin->caps_event = CreateEventW(NULL, 0, 0, NULL); - pin->segment = gst_segment_new(); - This->cStreams++; - pin->IQualityControl_iface.lpVtbl = &GSTOutPin_QualityControl_Vtbl; - SourceSeeking_Init(&pin->seek, &GST_Seeking_Vtbl, GST_ChangeStop, GST_ChangeCurrent, GST_ChangeRate, &This->filter.csFilter); - BaseFilterImpl_IncrementPinVersion(&This->filter); - } else - ERR("Failed with error %x\n", hr); - return hr; + GSTOutPin *pin, **new_array; + + if (!(new_array = CoTaskMemRealloc(filter->ppPins, (filter->cStreams + 1) * sizeof(*new_array)))) + return FALSE; + filter->ppPins = new_array; + + if (!(pin = heap_alloc_zero(sizeof(*pin)))) + return FALSE; + + strmbase_source_init(&pin->pin, &GST_OutputPin_Vtbl, pin_info, + &output_BaseOutputFuncTable, &filter->filter.csFilter); + pin->pmt = CoTaskMemAlloc(sizeof(AM_MEDIA_TYPE)); + CopyMediaType(pin->pmt, mt); + pin->caps_event = CreateEventW(NULL, FALSE, FALSE, NULL); + pin->segment = gst_segment_new(); + pin->IQualityControl_iface.lpVtbl = &GSTOutPin_QualityControl_Vtbl; + SourceSeeking_Init(&pin->seek, &GST_Seeking_Vtbl, GST_ChangeStop, + GST_ChangeCurrent, GST_ChangeRate, &filter->filter.csFilter); + BaseFilterImpl_IncrementPinVersion(&filter->filter); + + filter->ppPins[filter->cStreams++] = pin; + return TRUE; } static HRESULT GST_RemoveOutputPins(GSTImpl *This)

1 0

Alistair Leslie-Hughes : wbemprox: Return NULL on error (Coverity).
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: d2590f2099779e7e79bd8f1d3125750b7900e85a URL: https://source.winehq.org/git/wine.git/?a=commit;h=d2590f2099779e7e79bd8f1d… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Sep 4 23:48:51 2019 +0000 wbemprox: Return NULL on error (Coverity). Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/builtin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index bbc96bf..299a2ed 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -3886,7 +3886,7 @@ static struct array *get_systemenclosure_chassistypes( const char *buf, UINT len if (!(types = heap_alloc( sizeof(*types) ))) { heap_free( ret ); - goto done; + return NULL; } types[0] = chassis->type & ~0x80;

1 0

Huw Davies : wininet: Include limits.h to define UINT_MAX and ULONG_MAX.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: f5a3d43f45fdc5ab2b451e8592d4f8e1508f22a0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f5a3d43f45fdc5ab2b451e85… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Sep 5 08:39:56 2019 +0100 wininet: Include limits.h to define UINT_MAX and ULONG_MAX. Fixes build error on macOS introduced by commit 968201424d92a2117d91ba0253f30a9c67018e7e Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wininet/http.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 065a8b7..fccbb02 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -43,6 +43,7 @@ #include <time.h> #include <assert.h> #include <errno.h> +#include <limits.h> #include "windef.h" #include "winbase.h"

1 0

Alistair Leslie-Hughes : dsound: Trace each special effect as it' s processed.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: ff4ef417b707da4aacdd456fc4f405dcd9cc33db URL: https://source.winehq.org/git/wine.git/?a=commit;h=ff4ef417b707da4aacdd456f… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Sep 5 03:33:49 2019 +0000 dsound: Trace each special effect as it's processed. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dsound/buffer.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/dlls/dsound/buffer.c b/dlls/dsound/buffer.c index dacd639..f600652 100644 --- a/dlls/dsound/buffer.c +++ b/dlls/dsound/buffer.c @@ -695,6 +695,23 @@ static HRESULT WINAPI IDirectSoundBufferImpl_GetFrequency(IDirectSoundBuffer8 *i return DS_OK; } +static const char* dump_DSFX_guid(const DSEFFECTDESC *desc) +{ +#define FE(guid) if (IsEqualGUID(&guid, &desc->guidDSFXClass)) return #guid + FE(GUID_DSFX_STANDARD_GARGLE); + FE(GUID_DSFX_STANDARD_CHORUS); + FE(GUID_DSFX_STANDARD_FLANGER); + FE(GUID_DSFX_STANDARD_ECHO); + FE(GUID_DSFX_STANDARD_DISTORTION); + FE(GUID_DSFX_STANDARD_COMPRESSOR); + FE(GUID_DSFX_STANDARD_PARAMEQ); + FE(GUID_DSFX_STANDARD_I3DL2REVERB); + FE(GUID_DSFX_WAVES_REVERB); +#undef FE + + return debugstr_guid(&desc->guidDSFXClass); +} + static HRESULT WINAPI IDirectSoundBufferImpl_SetFX(IDirectSoundBuffer8 *iface, DWORD dwEffectsCount, LPDSEFFECTDESC pDSFXDesc, DWORD *pdwResultCodes) { @@ -767,6 +784,8 @@ static HRESULT WINAPI IDirectSoundBufferImpl_SetFX(IDirectSoundBuffer8 *iface, D dmt.pbFormat = (BYTE*)&wfx; for (u = 0; u < dwEffectsCount; u++) { + TRACE("%d: 0x%08x, %s\n", u, pDSFXDesc[u].dwFlags, dump_DSFX_guid(&pDSFXDesc[u])); + hr2 = CoCreateInstance(&pDSFXDesc[u].guidDSFXClass, NULL, CLSCTX_INPROC_SERVER, &IID_IMediaObject, (LPVOID*)&filters[u].obj); if (SUCCEEDED(hr2)) {

1 0

Dmitry Timoshkov : localspl: Remove useless NULL checks from AddMonitor trace.
by Alexandre Julliard 05 Sep '19

05 Sep '19

Module: wine Branch: master Commit: c113c5b9e7f52d8568e7e474ae2a70b054ff90d1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c113c5b9e7f52d8568e7e474… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Sep 5 20:31:06 2019 +0800 localspl: Remove useless NULL checks from AddMonitor trace. AddMonitor dereferences pMonitors later without any checks. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/localspl/provider.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/localspl/provider.c b/dlls/localspl/provider.c index cb31b19..ccd1981 100644 --- a/dlls/localspl/provider.c +++ b/dlls/localspl/provider.c @@ -1475,9 +1475,7 @@ static BOOL WINAPI fpAddMonitor(LPWSTR pName, DWORD Level, LPBYTE pMonitors) mi2w = (LPMONITOR_INFO_2W) pMonitors; TRACE("(%s, %d, %p): %s %s %s\n", debugstr_w(pName), Level, pMonitors, - debugstr_w(mi2w ? mi2w->pName : NULL), - debugstr_w(mi2w ? mi2w->pEnvironment : NULL), - debugstr_w(mi2w ? mi2w->pDLLName : NULL)); + debugstr_w(mi2w->pName), debugstr_w(mi2w->pEnvironment), debugstr_w(mi2w->pDLLName)); if (copy_servername_from_name(pName, NULL)) { FIXME("server %s not supported\n", debugstr_w(pName));

1 0