January 2020 - Wine-commits

Zebediah Figura : evr: Use wide character string literals.
by Alexandre Julliard 22 Jan '20

22 Jan '20

Module: wine Branch: master Commit: 3ceda2e269550f9f83d8a6ff7c2de87608d3d5a0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3ceda2e269550f9f83d8a6ff… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jan 15 20:30:30 2020 -0600 evr: Use wide character string literals. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/evr/evr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/evr/evr.c b/dlls/evr/evr.c index acaa9927c1..d6f6603eaa 100644 --- a/dlls/evr/evr.c +++ b/dlls/evr/evr.c @@ -70,7 +70,6 @@ static const struct strmbase_renderer_ops renderer_ops = HRESULT evr_filter_create(IUnknown *outer, void **out) { - static const WCHAR sink_name[] = {'E','V','R',' ','I','n','p','u','t','0',0}; evr_filter *object; *out = NULL; @@ -80,7 +79,7 @@ HRESULT evr_filter_create(IUnknown *outer, void **out) return E_OUTOFMEMORY; strmbase_renderer_init(&object->renderer, outer, - &CLSID_EnhancedVideoRenderer, sink_name, &renderer_ops); + &CLSID_EnhancedVideoRenderer, L"EVR Input0", &renderer_ops); *out = &object->renderer.filter.IUnknown_inner;

1 0

Zebediah Figura : shell32/tests: Fix some failures in test_contextmenu().
by Alexandre Julliard 22 Jan '20

22 Jan '20

Module: wine Branch: master Commit: 49a71fcc7704e7b52762b77eb45691713cc2218b URL: https://source.winehq.org/git/wine.git/?a=commit;h=49a71fcc7704e7b52762b77e… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Jan 18 10:55:19 2020 -0600 shell32/tests: Fix some failures in test_contextmenu(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/tests/shlfolder.c | 34 ++++++++++++---------------------- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index 43cbbfda2c..14d243a03b 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -4356,23 +4356,19 @@ if (hr == S_OK) static void test_contextmenu(IContextMenu *menu, BOOL background) { HMENU hmenu = CreatePopupMenu(); - const int id_upper_limit = 32767; - const int baseItem = 0x40; - INT max_id, max_id_check; - UINT count, i; + UINT count, i, max_id; HRESULT hr; test_contextmenu_qi(menu, FALSE); - hr = IContextMenu_QueryContextMenu(menu, hmenu, 0, baseItem, id_upper_limit, CMF_NORMAL); + hr = IContextMenu_QueryContextMenu(menu, hmenu, 0, 64, 32767, CMF_NORMAL); ok(SUCCEEDED(hr), "Failed to query the menu, hr %#x.\n", hr); max_id = HRESULT_CODE(hr) - 1; /* returns max_id + 1 */ - ok(max_id <= id_upper_limit, "Got %d\n", max_id); + ok(max_id <= 32767, "Got %d\n", max_id); count = GetMenuItemCount(hmenu); ok(count, "Got %d\n", count); - max_id_check = 0; for (i = 0; i < count; i++) { MENUITEMINFOA mii; @@ -4387,26 +4383,20 @@ static void test_contextmenu(IContextMenu *menu, BOOL background) res = GetMenuItemInfoA(hmenu, i, TRUE, &mii); ok(res, "Failed to get menu item info, error %d.\n", GetLastError()); - ok((mii.wID <= id_upper_limit) || (mii.fType & MFT_SEPARATOR), - "Got non-separator ID out of range: %d (type: %x)\n", mii.wID, mii.fType); if (!(mii.fType & MFT_SEPARATOR)) { - max_id_check = (mii.wID > max_id_check) ? mii.wID : max_id_check; - hr = IContextMenu_GetCommandString(menu, mii.wID - baseItem, GCS_VERBA, 0, buf, sizeof(buf)); + ok(mii.wID >= 64 && mii.wID <= 64 + max_id, + "Expected between 64 and %d, got %d.\n", 64 + max_id, mii.wID); + hr = IContextMenu_GetCommandString(menu, mii.wID - 64, GCS_VERBA, 0, buf, sizeof(buf)); todo_wine_if(background) - ok(SUCCEEDED(hr) || hr == E_NOTIMPL, "for id 0x%x got 0x%08x (menustr: %s)\n", mii.wID - baseItem, hr, mii.dwTypeData); - if (SUCCEEDED(hr)) - trace("for id 0x%x got string %s (menu string: %s)\n", mii.wID - baseItem, buf, mii.dwTypeData); - else if (hr == E_NOTIMPL) - trace("for id 0x%x got E_NOTIMPL (menu string: %s)\n", mii.wID - baseItem, mii.dwTypeData); + ok(hr == S_OK || hr == E_NOTIMPL || hr == E_INVALIDARG, + "Got unexpected hr %#x for ID %d, string %s.\n", hr, mii.wID, debugstr_a(mii.dwTypeData)); + if (hr == S_OK) + trace("Got ID %d, verb %s, string %s.\n", mii.wID, debugstr_a(buf), debugstr_a(mii.dwTypeData)); + else + trace("Got ID %d, hr %#x, string %s.\n", mii.wID, hr, debugstr_a(mii.dwTypeData)); } } - max_id_check -= baseItem; - ok((max_id_check == max_id) || - (max_id_check == max_id-1) || /* Win 7 */ - (max_id_check == max_id-2) || /* Win 8 */ - (max_id_check == max_id-3), - "Not equal (or near equal), got %d and %d\n", max_id_check, max_id); if (count) {

1 0

Zhiyi Zhang : rasenh/tests: Fix a test failure.
by Alexandre Julliard 22 Jan '20

22 Jan '20

Module: wine Branch: master Commit: 39f96c1fa9e8d3ae356ed475091b218e3e0da35d URL: https://source.winehq.org/git/wine.git/?a=commit;h=39f96c1fa9e8d3ae356ed475… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Jan 20 11:43:37 2020 +0800 rasenh/tests: Fix a test failure. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/rsaenh/tests/rsaenh.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/rsaenh/tests/rsaenh.c b/dlls/rsaenh/tests/rsaenh.c index 3e782be279..3039971474 100644 --- a/dlls/rsaenh/tests/rsaenh.c +++ b/dlls/rsaenh/tests/rsaenh.c @@ -2388,8 +2388,11 @@ static void test_rsa_encrypt(void) /* It is not allowed to use the signature key for encryption/decryption */ result = CryptGetUserKey(hProv, AT_SIGNATURE, &hRSAKey); - ok (result, "%08x\n", GetLastError()); - if (!result) return; + if (!result) + { + skip("No signature key in provider %s found, error %#x.\n", szProviders[iProv], GetLastError()); + return; + } dwVal = 0xdeadbeef; dwLen = sizeof(DWORD);

1 0

Francois Gouget : testbot: Use a more explicit filename to stage patchsets.
by Alexandre Julliard 22 Jan '20

22 Jan '20

Module: tools Branch: master Commit: ea5990edc396b92d6abbde64c37a5abcdc8afe7c URL: https://source.winehq.org/git/tools.git/?a=commit;h=ea5990edc396b92d6abbde6… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jan 22 11:16:11 2020 +0100 testbot: Use a more explicit filename to stage patchsets. Use a different filename for patches and patchsets so that in case of trouble one can trace the staging file to its source. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/Janitor.pl | 2 +- testbot/lib/WineTestBot/PendingPatchSets.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/bin/Janitor.pl b/testbot/bin/Janitor.pl index 121a3a6..115b7d5 100755 --- a/testbot/bin/Janitor.pl +++ b/testbot/bin/Janitor.pl @@ -276,7 +276,7 @@ if (opendir(my $dh, "$DataDir/staging")) # These files always expire after one day $TTL = 1 - $Age; } - elsif ($Entry !~ /^[0-9a-f]{32}_(?:patch|patch\.diff|wine-patches|winetest(?:64)?-latest\.exe)$/) + elsif ($Entry !~ /^[0-9a-f]{32}_(?:patch\.diff|patchset\.diff|wine-patches|winetest(?:64)?-latest\.exe)$/) { my $Deletion = defined $TTL ? " (deletion in $TTL days)" : ""; Error "Found a suspicious file$Deletion: staging/$Entry\n"; diff --git a/testbot/lib/WineTestBot/PendingPatchSets.pm b/testbot/lib/WineTestBot/PendingPatchSets.pm index 286b393..5be39e4 100644 --- a/testbot/lib/WineTestBot/PendingPatchSets.pm +++ b/testbot/lib/WineTestBot/PendingPatchSets.pm @@ -104,7 +104,7 @@ sub SubmitSubset($$$) { my ($self, $MaxPart, $FinalPatch) = @_; - my ($CombinedFile, $CombinedFileName) = OpenNewFile("$DataDir/staging", "_patch"); + my ($CombinedFile, $CombinedFileName) = OpenNewFile("$DataDir/staging", "_patchset.diff"); return "Could not create a combined patch file: $!" if (!$CombinedFile); my $ErrMessage;

1 0

Francois Gouget : testbot/UpdateTaskLogs: Fix reporting log access errors.
by Alexandre Julliard 22 Jan '20

22 Jan '20

Module: tools Branch: master Commit: cceea335a9c789272ab0faff56fac6a8ff9ddf52 URL: https://source.winehq.org/git/tools.git/?a=commit;h=cceea335a9c789272ab0faf… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jan 22 11:12:13 2020 +0100 testbot/UpdateTaskLogs: Fix reporting log access errors. Use the error message returned by ParseWineTestReport() when it could not open the report instead of recreating it from scratch. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/UpdateTaskLogs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/bin/UpdateTaskLogs b/testbot/bin/UpdateTaskLogs index ae3b305..ca9bf44 100755 --- a/testbot/bin/UpdateTaskLogs +++ b/testbot/bin/UpdateTaskLogs @@ -193,7 +193,7 @@ sub BuildErrFile($$$$) my ($TestUnitCount, $TimeoutCount, $LogFailures, $LogErrors) = ParseWineTestReport("$Dir/$ReportName", $IsWineTest, $TaskTimedOut); if (!defined $LogFailures and @$LogErrors == 1) { - return "Unable to open '$TaskKey/$ReportName' for reading: $!"; + return "$TaskKey: $LogErrors->[0]"; } return undef if (!@$LogErrors);

1 0

Francois Gouget : testbot: Remove unneeded references to the mailing list name in comments.
by Alexandre Julliard 22 Jan '20

22 Jan '20

Module: tools Branch: master Commit: 6ce470919b1ccaba42978e145d8f9c57b7599c4b URL: https://source.winehq.org/git/tools.git/?a=commit;h=6ce470919b1ccaba42978e1… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jan 22 19:33:11 2020 +0100 testbot: Remove unneeded references to the mailing list name in comments. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/Engine.pl | 2 +- testbot/bin/WinePatchesMLSubmit.pl | 2 +- testbot/lib/WineTestBot/VMs.pm | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/testbot/bin/Engine.pl b/testbot/bin/Engine.pl index 49347b5..ca35233 100755 --- a/testbot/bin/Engine.pl +++ b/testbot/bin/Engine.pl @@ -611,7 +611,7 @@ sub ClientRead($) This is called on startup and regularly after that to catch things that fall through the cracks, possibly because of an Engine restart. -Specifically it checks the staging directory for wine-patches emails dropped +Specifically it checks the staging directory for mailing list patches dropped by WinePatchesMLSubmit.pl, for notifications of changes on Wine's Patches web site dropped by WinePatchesWebSubmit.pl, and checks whether any pending patchsets are now complete and thus can be scheduled. diff --git a/testbot/bin/WinePatchesMLSubmit.pl b/testbot/bin/WinePatchesMLSubmit.pl index 65fe848..bddd42c 100755 --- a/testbot/bin/WinePatchesMLSubmit.pl +++ b/testbot/bin/WinePatchesMLSubmit.pl @@ -1,7 +1,7 @@ #!/usr/bin/perl -Tw # -*- Mode: Perl; perl-indent-level: 2; indent-tabs-mode: nil -*- # -# This script expects to receive a wine-devel email on stdin and submits it +# This script expects to receive a mailing list email on stdin and submits it # to WineTestBot for testing. It is meant to be called from a tool such as # procmail. # diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index 2f4b703..6c3c8b7 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -73,8 +73,8 @@ them. A base VM is used for every suitable task. This is the only role that build VMs can play besides retired. For Windows VMs, this means that it will run the -WineTest jobs, the wine-patches jobs, and also the manually submitted jobs -unless the submitter decided otherwise. +WineTest jobs, jobs for the mailing list patches, and also the manually +submitted jobs unless the submitter decided otherwise. =item winetest

1 0

Alexandre Julliard : Add link to the 5.0 announce file.
by Alexandre Julliard 21 Jan '20

21 Jan '20

Module: website Branch: master Commit: 34164adee44386b1aba1153f6c54a7e9f177f05f URL: https://source.winehq.org/git/website.git/?a=commit;h=34164adee44386b1aba11… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 21 20:02:23 2020 +0100 Add link to the 5.0 announce file. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2020012101.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/news/en/2020012101.xml b/news/en/2020012101.xml index c8f50938..2d6b9836 100644 --- a/news/en/2020012101.xml +++ b/news/en/2020012101.xml @@ -3,7 +3,7 @@ <title>Wine 5.0 Released</title> <body> The Wine team is proud to announce that the stable release Wine 5.0 is now available. - This release represents a year of development effort and over 7,400 individual changes. It contains a large number of improvements that are listed in the release notes below. The main highlights are: + This release represents a year of development effort and over 7,400 individual changes. It contains a large number of improvements that are listed in the <a href="{$root}/announce/5.0">release notes</a> below. The main highlights are: <ul> <li>Builtin modules in PE format.</li> <li>Multi-monitor support.</li>

1 0

Alexandre Julliard : Wine release 5.0
by Alexandre Julliard 21 Jan '20

21 Jan '20

Module: website Branch: master Commit: 1f0352ad092fd204f6a97c9ee8d5a89f6ce38c5d URL: https://source.winehq.org/git/website.git/?a=commit;h=1f0352ad092fd204f6a97… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 21 18:05:08 2020 +0100 Wine release 5.0 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2020012101.xml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/news/en/2020012101.xml b/news/en/2020012101.xml new file mode 100644 index 00000000..c8f50938 --- /dev/null +++ b/news/en/2020012101.xml @@ -0,0 +1,16 @@ +<news> +<date>January 21, 2020</date> +<title>Wine 5.0 Released</title> +<body> + The Wine team is proud to announce that the stable release Wine 5.0 is now available. + This release represents a year of development effort and over 7,400 individual changes. It contains a large number of improvements that are listed in the release notes below. The main highlights are: +<ul> + <li>Builtin modules in PE format.</li> + <li>Multi-monitor support.</li> + <li>XAudio2 reimplementation.</li> + <li>Vulkan 1.1 support.</li> +</ul> + This release is dedicated to the memory of Józef Kucia, who passed away in August 2019 at the young age of 30. Józef was a major contributor to Wine's Direct3D implementation, and the lead developer of the vkd3d project. His skills and his kindness are sorely missed by all of us. +The source is <a href="//dl.winehq.org/wine/source/5.0/wine-5.0.tar.xz">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0

Alexandre Julliard : Release 5.0.
by Alexandre Julliard 21 Jan '20

21 Jan '20

Module: wine Branch: master Commit: da816802e022e8aa8eb197de94e18305a92766c1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=da816802e022e8aa8eb197de… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 21 18:03:21 2020 +0100 Release 5.0. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 510 ++++++++++++++++++++++++++++++++++++++++++++++++-------------- VERSION | 2 +- configure | 18 +-- 3 files changed, 411 insertions(+), 119 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=da816802e022e8aa8eb1…

1 0

Tag wine-5.0 : Alexandre Julliard : Release 5.0
by Alexandre Julliard 21 Jan '20

21 Jan '20

Module: wine Branch: refs/tags/wine-5.0 Tag: 3aff0a58f185944036fb0c140462e07b0ab881aa URL: https://source.winehq.org/git/wine.git/?a=tag;h=3aff0a58f185944036fb0c14046… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 21 18:03:21 2020 +0100 Release 5.0

1 0