October 2020 - Wine-commits

Michael Stefaniuc : find: Use wide-char string literals.
by Alexandre Julliard 20 Oct '20

20 Oct '20

Module: wine Branch: master Commit: 66119ad2284f275d667f5351a8b0d11a2f6cc999 URL: https://source.winehq.org/git/wine.git/?a=commit;h=66119ad2284f275d667f5351… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Oct 20 00:31:43 2020 +0200 find: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/find/find.c | 3 +-- programs/find/tests/find.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/programs/find/find.c b/programs/find/find.c index 2eeb1ce2120..7d178874b4d 100644 --- a/programs/find/find.c +++ b/programs/find/find.c @@ -117,7 +117,6 @@ static void write_to_stdout(const WCHAR *str) static BOOL run_find_for_line(const WCHAR *line, const WCHAR *tofind) { void *found; - WCHAR lineending[] = {'\r', '\n', 0}; if (lstrlenW(line) == 0 || lstrlenW(tofind) == 0) return FALSE; @@ -127,7 +126,7 @@ static BOOL run_find_for_line(const WCHAR *line, const WCHAR *tofind) if (found) { write_to_stdout(line); - write_to_stdout(lineending); + write_to_stdout(L"\r\n"); return TRUE; } diff --git a/programs/find/tests/find.c b/programs/find/tests/find.c index d50dcdd36ae..b7c2d7b77c4 100644 --- a/programs/find/tests/find.c +++ b/programs/find/tests/find.c @@ -128,7 +128,6 @@ static void mangle_text(const BYTE *input, int input_len, BYTE *output, int outp static void run_find_stdin_(const WCHAR *commandline, const BYTE *input, int input_len, const BYTE *out_expected, int out_expected_len, int exitcode_expected, const char *file, int line) { - static const WCHAR find_exe[] = { 'f','i','n','d','.','e','x','e',' ','%','s',0 }; HANDLE child_stdin_read; HANDLE child_stdout_write; HANDLE parent_stdin_write; @@ -157,7 +156,7 @@ static void run_find_stdin_(const WCHAR *commandline, const BYTE *input, int inp startup_info.hStdError = NULL; startup_info.dwFlags |= STARTF_USESTDHANDLES; - wsprintfW(cmd, find_exe, commandline); + wsprintfW(cmd, L"find.exe %s", commandline); CreateProcessW(NULL, cmd, NULL, NULL, TRUE, 0, NULL, NULL, &startup_info, &process_info); CloseHandle(child_stdin_read); @@ -243,7 +242,7 @@ static void run_find_str_(const char *commandline, const char *input, const char static void run_find_unicode_(const BYTE *input, int input_len, const BYTE *out_expected, int out_expected_len, int exitcode_expected, BOOL is_file, const char *file, int line) { /* Need "test" as char and quoted wchar */ - static const WCHAR wstr_quoted_test[] = { '"','t', 'e', 's', 't','"',0 }; + static const WCHAR wstr_quoted_test[] = L"\"test\""; static const char str_test[] = "test"; BYTE out_expected_mangled[200] = {0};

1 0

Michael Stefaniuc : uxtheme: Use wide-char string literals in struct initialization.
by Alexandre Julliard 20 Oct '20

20 Oct '20

Module: wine Branch: master Commit: e947b081498baac1854526a84baffe106b73685b URL: https://source.winehq.org/git/wine.git/?a=commit;h=e947b081498baac1854526a8… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Oct 20 00:31:45 2020 +0200 uxtheme: Use wide-char string literals in struct initialization. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/stylemap.c | 1776 +++++++++++++++++++++++------------------------ 1 file changed, 888 insertions(+), 888 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e947b081498baac18545…

1 0

Michael Stefaniuc : uxtheme: Use wide-char string literals.
by Alexandre Julliard 20 Oct '20

20 Oct '20

Module: wine Branch: master Commit: 1f040d666b30039b46019dcdde4aa68343cb4109 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1f040d666b30039b46019dcd… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Oct 20 00:31:46 2020 +0200 uxtheme: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/draw.c | 3 +- dlls/uxtheme/msstyles.c | 46 ++++++--------------- dlls/uxtheme/system.c | 107 ++++++++++++++++-------------------------------- dlls/uxtheme/uxini.c | 6 +-- 4 files changed, 49 insertions(+), 113 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=1f040d666b30039b4601…

1 0

Michael Stefaniuc : taskmgr: Use NtQuerySystemInformation() directly.
by Alexandre Julliard 20 Oct '20

20 Oct '20

Module: wine Branch: master Commit: cf3e6c353bfc19d79237aa7b001be8a8905b8270 URL: https://source.winehq.org/git/wine.git/?a=commit;h=cf3e6c353bfc19d79237aa7b… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Oct 20 00:31:47 2020 +0200 taskmgr: Use NtQuerySystemInformation() directly. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/taskmgr/perfdata.c | 23 +++++++++-------------- programs/taskmgr/perfdata.h | 1 - 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/programs/taskmgr/perfdata.c b/programs/taskmgr/perfdata.c index 67f0d934412..a152415357e 100644 --- a/programs/taskmgr/perfdata.c +++ b/programs/taskmgr/perfdata.c @@ -30,7 +30,6 @@ #include "taskmgr.h" #include "perfdata.h" -static PROCNTQSI pNtQuerySystemInformation = NULL; static PROCGPIC pGetProcessIoCounters = NULL; static PROCISW64 pIsWow64Process = NULL; static CRITICAL_SECTION PerfDataCriticalSection; @@ -58,22 +57,17 @@ static size_t size_diff(size_t x, size_t y) BOOL PerfDataInitialize(void) { LONG status; - static const WCHAR wszNtdll[] = {'n','t','d','l','l','.','d','l','l',0}; static const WCHAR wszKernel32[] = {'k','e','r','n','e','l','3','2','.','d','l','l',0}; - pNtQuerySystemInformation = (PROCNTQSI)GetProcAddress(GetModuleHandleW(wszNtdll), "NtQuerySystemInformation"); pGetProcessIoCounters = (PROCGPIC)GetProcAddress(GetModuleHandleW(wszKernel32), "GetProcessIoCounters"); pIsWow64Process = (PROCISW64)GetProcAddress(GetModuleHandleW(wszKernel32), "IsWow64Process"); InitializeCriticalSection(&PerfDataCriticalSection); - if (!pNtQuerySystemInformation) - return FALSE; - /* * Get number of processors in the system */ - status = pNtQuerySystemInformation(SystemBasicInformation, &SystemBasicInfo, sizeof(SystemBasicInfo), NULL); + status = NtQuerySystemInformation(SystemBasicInformation, &SystemBasicInfo, sizeof(SystemBasicInfo), NULL); if (status != NO_ERROR) return FALSE; @@ -102,24 +96,25 @@ void PerfDataRefresh(void) /* Get new system time */ - status = pNtQuerySystemInformation(SystemTimeOfDayInformation, &SysTimeInfo, sizeof(SysTimeInfo), 0); + status = NtQuerySystemInformation(SystemTimeOfDayInformation, &SysTimeInfo, sizeof(SysTimeInfo), 0); if (status != NO_ERROR) return; /* Get new CPU's idle time */ - status = pNtQuerySystemInformation(SystemPerformanceInformation, &SysPerfInfo, sizeof(SysPerfInfo), NULL); + status = NtQuerySystemInformation(SystemPerformanceInformation, &SysPerfInfo, sizeof(SysPerfInfo), NULL); if (status != NO_ERROR) return; /* Get system cache information */ - status = pNtQuerySystemInformation(SystemCacheInformation, &SysCacheInfo, sizeof(SysCacheInfo), NULL); + status = NtQuerySystemInformation(SystemCacheInformation, &SysCacheInfo, sizeof(SysCacheInfo), NULL); if (status != NO_ERROR) return; /* Get processor time information */ SysProcessorTimeInfo = HeapAlloc(GetProcessHeap(), 0, - sizeof(*SysProcessorTimeInfo) * SystemBasicInfo.NumberOfProcessors); - status = pNtQuerySystemInformation(SystemProcessorPerformanceInformation, SysProcessorTimeInfo, sizeof(*SysProcessorTimeInfo) * SystemBasicInfo.NumberOfProcessors, &ulSize); + sizeof(*SysProcessorTimeInfo) * SystemBasicInfo.NumberOfProcessors); + status = NtQuerySystemInformation(SystemProcessorPerformanceInformation, SysProcessorTimeInfo, + sizeof(*SysProcessorTimeInfo) * SystemBasicInfo.NumberOfProcessors, &ulSize); if (status != NO_ERROR) { HeapFree(GetProcessHeap(), 0, SysProcessorTimeInfo); return; @@ -135,7 +130,7 @@ void PerfDataRefresh(void) BufferSize += 0x10000; SysHandleInfoData = HeapAlloc(GetProcessHeap(), 0, BufferSize); - status = pNtQuerySystemInformation(SystemHandleInformation, SysHandleInfoData, BufferSize, &ulSize); + status = NtQuerySystemInformation(SystemHandleInformation, SysHandleInfoData, BufferSize, &ulSize); if (status == 0xC0000004 /*STATUS_INFO_LENGTH_MISMATCH*/) { HeapFree(GetProcessHeap(), 0, SysHandleInfoData); @@ -153,7 +148,7 @@ void PerfDataRefresh(void) BufferSize += 0x10000; pBuffer = HeapAlloc(GetProcessHeap(), 0, BufferSize); - status = pNtQuerySystemInformation(SystemProcessInformation, pBuffer, BufferSize, &ulSize); + status = NtQuerySystemInformation(SystemProcessInformation, pBuffer, BufferSize, &ulSize); if (status == 0xC0000004 /*STATUS_INFO_LENGTH_MISMATCH*/) { HeapFree(GetProcessHeap(), 0, pBuffer); diff --git a/programs/taskmgr/perfdata.h b/programs/taskmgr/perfdata.h index 8b9fabbd910..0b06965d52e 100644 --- a/programs/taskmgr/perfdata.h +++ b/programs/taskmgr/perfdata.h @@ -66,7 +66,6 @@ struct _SYSTEM_PAGEFILE_INFORMATION #define GR_GDIOBJECTS 0 /* Count of GDI objects */ #define GR_USEROBJECTS 1 /* Count of USER objects */ -typedef LONG (WINAPI *PROCNTQSI)(UINT,PVOID,ULONG,PULONG); typedef BOOL (WINAPI *PROCGPIC)(HANDLE,PIO_COUNTERS); typedef BOOL (WINAPI *PROCISW64)(HANDLE,PBOOL);

1 0

Michael Stefaniuc : taskmgr: Use two kernel32 functions directly.
by Alexandre Julliard 20 Oct '20

20 Oct '20

Module: wine Branch: master Commit: c2883d77b8c272f8699a8683cc0901f5eec6daf1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c2883d77b8c272f8699a8683… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Oct 20 00:31:48 2020 +0200 taskmgr: Use two kernel32 functions directly. The yougest one, IsWow64Proces, is available since WinXP SP2 / Vista. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/taskmgr/perfdata.c | 12 ++---------- programs/taskmgr/perfdata.h | 3 --- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/programs/taskmgr/perfdata.c b/programs/taskmgr/perfdata.c index a152415357e..bbd3327ab58 100644 --- a/programs/taskmgr/perfdata.c +++ b/programs/taskmgr/perfdata.c @@ -30,8 +30,6 @@ #include "taskmgr.h" #include "perfdata.h" -static PROCGPIC pGetProcessIoCounters = NULL; -static PROCISW64 pIsWow64Process = NULL; static CRITICAL_SECTION PerfDataCriticalSection; static PPERFDATA pPerfDataOld = NULL; /* Older perf data (saved to establish delta values) */ static PPERFDATA pPerfData = NULL; /* Most recent copy of perf data */ @@ -57,11 +55,7 @@ static size_t size_diff(size_t x, size_t y) BOOL PerfDataInitialize(void) { LONG status; - static const WCHAR wszKernel32[] = {'k','e','r','n','e','l','3','2','.','d','l','l',0}; - pGetProcessIoCounters = (PROCGPIC)GetProcAddress(GetModuleHandleW(wszKernel32), "GetProcessIoCounters"); - pIsWow64Process = (PROCISW64)GetProcAddress(GetModuleHandleW(wszKernel32), "IsWow64Process"); - InitializeCriticalSection(&PerfDataCriticalSection); /* @@ -291,10 +285,8 @@ void PerfDataRefresh(void) } pPerfData[Idx].USERObjectCount = GetGuiResources(hProcess, GR_USEROBJECTS); pPerfData[Idx].GDIObjectCount = GetGuiResources(hProcess, GR_GDIOBJECTS); - if (pGetProcessIoCounters) - pGetProcessIoCounters(hProcess, &pPerfData[Idx].IOCounters); - if (pIsWow64Process) - pIsWow64Process(hProcess, &pPerfData[Idx].Wow64Process); + GetProcessIoCounters(hProcess, &pPerfData[Idx].IOCounters); + IsWow64Process(hProcess, &pPerfData[Idx].Wow64Process); CloseHandle(hProcess); } pPerfData[Idx].UserTime.QuadPart = pSPI->UserTime.QuadPart; diff --git a/programs/taskmgr/perfdata.h b/programs/taskmgr/perfdata.h index 0b06965d52e..615e7db2a64 100644 --- a/programs/taskmgr/perfdata.h +++ b/programs/taskmgr/perfdata.h @@ -66,9 +66,6 @@ struct _SYSTEM_PAGEFILE_INFORMATION #define GR_GDIOBJECTS 0 /* Count of GDI objects */ #define GR_USEROBJECTS 1 /* Count of USER objects */ -typedef BOOL (WINAPI *PROCGPIC)(HANDLE,PIO_COUNTERS); -typedef BOOL (WINAPI *PROCISW64)(HANDLE,PBOOL); - BOOL PerfDataInitialize(void); void PerfDataRefresh(void);

1 0

Hans Leidekker : dssenh: Access the hash value directly in CPSignHash and CPVerifySignature.
by Alexandre Julliard 19 Oct '20

19 Oct '20

Module: wine Branch: master Commit: 554e315bcfd7aa58ffc38ce69bfe4cba04c26de4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=554e315bcfd7aa58ffc38ce6… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 19 11:24:14 2020 +0200 dssenh: Access the hash value directly in CPSignHash and CPVerifySignature. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dssenh/main.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/dlls/dssenh/main.c b/dlls/dssenh/main.c index 2d9569672a5..a2e5a72148d 100644 --- a/dlls/dssenh/main.c +++ b/dlls/dssenh/main.c @@ -860,8 +860,7 @@ BOOL WINAPI CPSignHash( HCRYPTPROV hprov, HCRYPTHASH hhash, DWORD keyspec, const { struct container *container = (struct container *)hprov; struct hash *hash = (struct hash *)hhash; - UCHAR hashval[MAX_HASH_LEN]; - ULONG len, hashlen = sizeof(hashval); + ULONG len; TRACE( "%p, %p, %u, %s, %08x, %p, %p\n", (void *)hprov, (void *)hhash, keyspec, debugstr_w(desc), flags, sig, siglen ); @@ -870,14 +869,13 @@ BOOL WINAPI CPSignHash( HCRYPTPROV hprov, HCRYPTHASH hhash, DWORD keyspec, const if (hash->magic != MAGIC_HASH) return FALSE; if (!(len = get_signature_length( container->sign_key->algid ))) return FALSE; - if (!CPGetHashParam( hprov, hhash, HP_HASHVAL, hashval, &hashlen, 0 )) return FALSE; if (*siglen < len) { *siglen = len; return TRUE; } - return !BCryptSignHash( container->sign_key->handle, NULL, hashval, hashlen, sig, *siglen, siglen, 0 ); + return !BCryptSignHash( container->sign_key->handle, NULL, hash->value, hash->len, sig, *siglen, siglen, 0 ); } BOOL WINAPI CPVerifySignature( HCRYPTPROV hprov, HCRYPTHASH hhash, const BYTE *sig, DWORD siglen, HCRYPTKEY hpubkey, @@ -885,8 +883,6 @@ BOOL WINAPI CPVerifySignature( HCRYPTPROV hprov, HCRYPTHASH hhash, const BYTE *s { struct hash *hash = (struct hash *)hhash; struct key *key = (struct key *)hpubkey; - UCHAR hashval[MAX_HASH_LEN]; - ULONG hashlen = sizeof(hashval); TRACE( "%p, %p, %p, %u %p, %s, %08x\n", (void *)hprov, (void *)hhash, sig, siglen, (void *)hpubkey, debugstr_w(desc), flags ); @@ -898,9 +894,7 @@ BOOL WINAPI CPVerifySignature( HCRYPTPROV hprov, HCRYPTHASH hhash, const BYTE *s return FALSE; } - if (!CPGetHashParam( hprov, hhash, HP_HASHVAL, hashval, &hashlen, 0 )) return FALSE; - - return !BCryptVerifySignature( key->handle, NULL, hashval, hashlen, (UCHAR *)sig, siglen, 0 ); + return !BCryptVerifySignature( key->handle, NULL, hash->value, hash->len, (UCHAR *)sig, siglen, 0 ); } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved)

1 0

Hans Leidekker : dssenh: Implement CPSetHashParam.
by Alexandre Julliard 19 Oct '20

19 Oct '20

Module: wine Branch: master Commit: 1b1637fc1fe648511bc9043b4927f24bb3143537 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1b1637fc1fe648511bc9043b… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 19 11:24:15 2020 +0200 dssenh: Implement CPSetHashParam. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dssenh/dssenh.spec | 2 +- dlls/dssenh/main.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/dlls/dssenh/dssenh.spec b/dlls/dssenh/dssenh.spec index 473bd08205f..9060614ce49 100644 --- a/dlls/dssenh/dssenh.spec +++ b/dlls/dssenh/dssenh.spec @@ -18,7 +18,7 @@ @ stub CPHashSessionKey @ stdcall CPImportKey(ptr ptr long ptr long ptr) @ stdcall CPReleaseContext(ptr long) -@ stub CPSetHashParam +@ stdcall CPSetHashParam(ptr ptr long ptr long) @ stub CPSetKeyParam @ stub CPSetProvParam @ stdcall CPSignHash(ptr ptr long wstr long ptr ptr) diff --git a/dlls/dssenh/main.c b/dlls/dssenh/main.c index a2e5a72148d..1da56493170 100644 --- a/dlls/dssenh/main.c +++ b/dlls/dssenh/main.c @@ -837,6 +837,27 @@ BOOL WINAPI CPGetHashParam( HCRYPTPROV hprov, HCRYPTHASH hhash, DWORD param, BYT } } +BOOL WINAPI CPSetHashParam( HCRYPTPROV hprov, HCRYPTHASH hhash, DWORD param, const BYTE *data, DWORD flags ) +{ + struct hash *hash = (struct hash *)hhash; + + TRACE( "%p, %p, %08x, %p, %08x\n", (void *)hprov, (void *)hhash, param, data, flags ); + + if (hash->magic != MAGIC_HASH) return FALSE; + + switch (param) + { + case HP_HASHVAL: + memcpy( hash->value, data, hash->len ); + return TRUE; + + default: + FIXME( "param %u not supported\n", param ); + SetLastError( NTE_BAD_TYPE ); + return FALSE; + } +} + BOOL WINAPI CPDeriveKey( HCRYPTPROV hprov, ALG_ID algid, HCRYPTHASH hhash, DWORD flags, HCRYPTKEY *ret_key ) { return FALSE;

1 0

Hans Leidekker : dssenh: Add support for exporting private keys.
by Alexandre Julliard 19 Oct '20

19 Oct '20

Module: wine Branch: master Commit: b4ca2d001c31c4a7805135549eddc5844b60e319 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b4ca2d001c31c4a780513554… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 19 11:24:16 2020 +0200 dssenh: Add support for exporting private keys. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dssenh/main.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/dlls/dssenh/main.c b/dlls/dssenh/main.c index 1da56493170..e3771dc6f06 100644 --- a/dlls/dssenh/main.c +++ b/dlls/dssenh/main.c @@ -578,6 +578,7 @@ BOOL WINAPI CPExportKey( HCRYPTPROV hprov, HCRYPTKEY hkey, HCRYPTKEY hexpkey, DW BYTE *data, DWORD *len ) { struct key *key = (struct key *)hkey; + const WCHAR *type; TRACE( "%p, %p, %p, %08x, %08x, %p, %p\n", (void *)hprov, (void *)hkey, (void *)hexpkey, blobtype, flags, data, len ); @@ -588,18 +589,28 @@ BOOL WINAPI CPExportKey( HCRYPTPROV hprov, HCRYPTKEY hkey, HCRYPTKEY hexpkey, DW FIXME( "export key not supported\n" ); return FALSE; } - if (blobtype != PUBLICKEYBLOB) + if (flags) { - FIXME( "blob type %u not supported\n", blobtype ); + FIXME( "flags %08x not supported\n", flags ); return FALSE; } - if (flags) + + switch (blobtype) { - FIXME( "flags %08x not supported\n", flags ); + case PUBLICKEYBLOB: + type = LEGACY_DSA_V2_PUBLIC_BLOB; + break; + + case PRIVATEKEYBLOB: + type = LEGACY_DSA_V2_PRIVATE_BLOB; + break; + + default: + FIXME( "blob type %u not supported\n", blobtype ); return FALSE; } - return !BCryptExportKey( key->handle, NULL, LEGACY_DSA_V2_PUBLIC_BLOB, data, *len, len, 0 ); + return !BCryptExportKey( key->handle, NULL, type, data, *len, len, 0 ); } BOOL WINAPI CPDuplicateKey( HCRYPTPROV hprov, HCRYPTKEY hkey, DWORD *reserved, DWORD flags, HCRYPTKEY *ret_key )

1 0

Nikolay Sivov : server: Handle duplicate handles when inheriting them for the new process.
by Alexandre Julliard 19 Oct '20

19 Oct '20

Module: wine Branch: master Commit: 2a7a1bbee2116d1ec242920c68fa12dfdf747347 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2a7a1bbee2116d1ec242920c… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Oct 19 12:39:35 2020 +0300 server: Handle duplicate handles when inheriting them for the new process. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50004 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/handle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/handle.c b/server/handle.c index 15382256f10..2556a03901e 100644 --- a/server/handle.c +++ b/server/handle.c @@ -363,8 +363,9 @@ static void inherit_handle( struct process *parent, const obj_handle_t handle, s src = get_handle( parent, handle ); if (!src || !(src->access & RESERVED_INHERIT)) return; - grab_object_for_handle( src->ptr ); index = handle_to_index( handle ); + if (dst[index].ptr) return; + grab_object_for_handle( src->ptr ); dst[index] = *src; table->last = max( table->last, index ); }

1 0

Nikolay Sivov : comsvcs: Create MTA without initialization thread.
by Alexandre Julliard 19 Oct '20

19 Oct '20

Module: wine Branch: master Commit: c9cc098ccd7f0cdb82b8e52d00c415042c5ff717 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c9cc098ccd7f0cdb82b8e52d… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Oct 19 12:43:04 2020 +0300 comsvcs: Create MTA without initialization thread. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49679 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comsvcs/main.c | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/dlls/comsvcs/main.c b/dlls/comsvcs/main.c index 9ab77dfceda..74704077ecb 100644 --- a/dlls/comsvcs/main.c +++ b/dlls/comsvcs/main.c @@ -40,7 +40,7 @@ typedef struct dispensermanager { IDispenserManager IDispenserManager_iface; LONG ref; - HANDLE mta_thread, mta_stop_event; + CO_MTA_USAGE_COOKIE mta_cookie; } dispensermanager; typedef struct holder @@ -285,27 +285,14 @@ static ULONG WINAPI dismanager_Release(IDispenserManager *iface) if (!ref) { - if (This->mta_thread) - { - SetEvent(This->mta_stop_event); - WaitForSingleObject(This->mta_thread, INFINITE); - CloseHandle(This->mta_stop_event); - CloseHandle(This->mta_thread); - } + if (This->mta_cookie) + CoDecrementMTAUsage(This->mta_cookie); heap_free(This); } return ref; } -static DWORD WINAPI mta_thread_proc(void *arg) -{ - CoInitializeEx(NULL, COINIT_MULTITHREADED); - WaitForSingleObject(arg, INFINITE); - CoUninitialize(); - return 0; -} - static HRESULT WINAPI dismanager_RegisterDispenser(IDispenserManager *iface, IDispenserDriver *driver, LPCOLESTR name, IHolder **dispenser) { @@ -319,11 +306,8 @@ static HRESULT WINAPI dismanager_RegisterDispenser(IDispenserManager *iface, IDi hr = create_holder(driver, dispenser); - if (!This->mta_thread) - { - This->mta_stop_event = CreateEventA(NULL, TRUE, FALSE, NULL); - This->mta_thread = CreateThread(NULL, 0, mta_thread_proc, This->mta_stop_event, 0, NULL); - } + if (!This->mta_cookie) + CoIncrementMTAUsage(&This->mta_cookie); TRACE("<-- 0x%08x, %p\n", hr, *dispenser);

1 0